- 15 Oct, 2020 40 commits
-
-
Wei Lee authored
Originally, we use background page and chrome.runtime API for communication between CCA and Tast tests. However, since SWA does not have background page and cannot use chrome.runtime API, we introduce a new implementation using SharedWorker for communication. Bug: 980846 Test: Tested with the related Tast CL and run "$ tast run [DUT] camera.CCAUI*" Change-Id: I575aeb11db4af90de1eebf63ad7f1d8f1608ded2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362235Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817490}
-
Evan Stade authored
This change adds a workaround for the fact that GMS's CastContext typecasts from Context to Application (in WebLayer, ContextUtils.getApplicationContext() will return a ClassLoaderContextWrapper, not an Application). MediaRouteDialogFragment is made public as it appears DialogFragment subclasses must be public. This also adds a CastOptionsProvider reference in WebLayer shell. It's still clear not whether WebLayer should provide this in its client- side manifest, so this errs on the side of not breaking clients. For now, clients that want to use MediaRouter code will have to provide their own CastOptionsProvider. Bug: 1057100 Change-Id: I12c651e005e495fa1f83c311c569ae0e2973ff80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468563 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817489}
-
Owen Min authored
Remove following uma metrics as they are not actively monitoring by anyone. Signin.ForceSigninVerificationTime.Success Signin.ForceSigninVerificationTime.Failure Signin.ForceSigninVerificationRequest Bug: 1089514 Change-Id: I74693b957544e4f285aad2b6685ebaaefebe3cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468461Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817488}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602741093-813b9f30d38756007f17b964e7014a850d40bedc.profdata to chrome-mac-master-1602762990-5c0ecdd782b8586c3ade2c97da0a453329c89923.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6074203051a3455dcc791c6fbd1d88ee394cb028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817487}
-
Mark Mentovai authored
This version of Xcode updates the macOS SDK from 11.0 20A5384b (close to 11.0db9) to 11.0 20A5395d (close to 11.0db10). lipo is added to build/xcode_binaries.yaml because it may help with https://chromium-review.googlesource.com/c/chromium/src/+/2462242/17#message-eee09fed41f8e46c1241f0d5a33d336b0221a4fc. The xcode_12_beta hermetic toolchain in build/mac_toolchain.py was built with this new build/xcode_binaries.yaml and contains lipo. CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: Ie4398f7d7d51c67a9f81dfaf5c45b6f2dfca8ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475753 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817486}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dfccae249ee2..2948c1aca72c 2020-10-15 jleconte@google.com Fix 'Unknown git hash' when repository is not chromium. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649 Tbr: wenbinzhang@google.com Change-Id: Ic5e3164cc3317857a07e848ef929958668afb4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474579Reviewed-by:
-
Jeremy Roman authored
This reverts commit c5f263f5. Reason for revert: Fails on Mac 10.14 bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9431 Failures appear to show "Close" and "Settings" mismatch. Original change's description: > Add user defined categories to UNNotifications > > -Adds complex categories that support 2 developer buttons > > -Moves all init methods from builders to the base builder > > -Modifies response builder to accommodate for developer buttons > > -Tests the built category and its response > > Bug: 1136061 > Change-Id: Ifabb0d06e8379f957ff8af7ab4bc8ea2228cf38d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471637 > Commit-Queue: Mohamed Adel <adelm@google.com> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817457} TBR=rayankans@chromium.org,knollr@chromium.org,adelm@google.com Change-Id: Ib47f9481ec77bb973f587339b329981f6d909f3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475894Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817484}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/239f92ecf7fc..ad2ec763873b 2020-10-15 ilnik@webrtc.org Revert "introduce an unsupported content description type" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie4e782f159ca10022e5968913a52113bce300848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474582Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23b0ebb5..c6b4ce00 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22df336a9052a459bb029415fe4f13b74a3e0a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475300Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817482}
-
Stephen McGruer authored
Bug: None Change-Id: I27bb1a3cfcf27a1057308864c3ab48b8437ab523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475533 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#817481}
-
cfredric authored
Bug: 1138586 Change-Id: Ie3f67b8db60c66c1920b9af8e3c1ec03edc4921f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472264 Auto-Submit: Chris Fredrickson <cfredric@google.com> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#817480}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/179979c8b382..139f1af3ffa6 2020-10-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-15 bmeurer@chromium.org [sources] Add tooltip with method name in Call Stack sidebar. 2020-10-15 alexrudenko@chromium.org Enable TypeScript for TransformController.js 2020-10-15 sigurds@chromium.org [ts] Type-check security/SecurityPanel.js with TypeScript 2020-10-15 kprokopenko@google.com Update Images readme and add comments to the spritesheets. 2020-10-15 alcastano@google.com Unit tests for Markdown rendering bug on angle brackets 2020-10-15 mathias@chromium.org Move some custom cm CSS to text_editor instead If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1076825,chromium:1126031,chromium:1136484,chromium:1138302 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I063849ac2abd5033887b3f44dafc64da889c787b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474580Reviewed-by:
-
Eric Lawrence authored
This function's definition was removed in 2019 in commit a8966d94. Remove the declaration from the header file. Bug: 1138616 Change-Id: I065bb1358a326a0cb6e272db2a9c88462ea0ba21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472922 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#817478}
-
Nektarios Paisios authored
This patch prepares the groundwork for three related changes: 1. The merging of AXNodePosition and BrowserAccessibilityPosition by moving hypertext computation to AXNode. This work will be completed in the following patch: https://chromium-review.googlesource.com/c/chromium/src/+/2327552 2. Computing the value of rich text fields on the browser which will improve performance considerably in online document editors such as Google Docs, once Blink stops computing and sending their value with every selection or text change event. This work will be done in the following patches: A) Improves performance by generating value and text changed events on the browser instead of in Blink. https://chromium-review.googlesource.com/c/chromium/src/+/2322487 B) Stops generating the value attribute for non-native text controls. https://chromium-review.googlesource.com/c/chromium/src/+/2250070 3. Consolidates all the methods for retrieving the value of any control, e.g. text field, color well, <select> element and ARIA combo box, in AXNode::GetValueForControl. This will enable Views to use an AXTree and deduplicate logic between BrowserAccessibility and AXPlatformNodeDelegateBase. R=dmazzoni@chromium.org, aleventhal@chromium.org, sadrul@chromium.org AX-Relnotes: n/a. Bug: 1049261 Change-Id: I6b69edbe692ecfe10a91388d5ef28e0907cf1fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446210Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#817477}
-
Maksim Sisov authored
This is a reland of 0d3b1f9c Remove lacros from the expectations as well. Original change's description: > Reland "ozone: fix expectations in clipboard test" > > This is a reland of a60f7247 > > Original change's description: > > ozone: fix expectations in clipboard test > > > > In case of Ozone, we support more types. > > > > Bug: 1134495 > > Change-Id: I9712931545c8b70a1a0357d5b119b8c9a7c08c4e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443650 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#814303} > > Bug: 1134495 > Change-Id: I5849855e3fd037dc7eb34d0b94bbc08b6246b234 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454051 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#814742} Bug: 1134495 Change-Id: I206fbece35e21e5beebd8e5777cd332ffebd9e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463602 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
Hidehiko Abe authored
Bug: 1110266 Test: Built and took diff of the executable via objdump. Change-Id: I80832fb472e6cc78d1e967f6216b1c33cc79ba73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475013 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
Currently OS_LINUX macro is defined for Chrome OS build, but it will be unset. This CL is the preparation for the change to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I7bd1930a7bfd35ce91278ae4cf0a6db3db25adf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474835 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Jeremy Roman authored
This reverts commit 291faaf5. Reason for revert: this test is flaky, especially on Mac where it has broken several waterfall bots Original change's description: > [SyncInvalidations] Add signout and signin integration test. > > This CL adds a test that checks the following: > - On signout, the FCM registration token should be cleared. > - On signin, it should be requested again. > > Bug: 1135167 > Change-Id: Ie1b1967b9ed317c0a36d4b751aef0dfeb81c45d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467979 > Commit-Queue: Paula Vidas <paulavidas@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Rushan Suleymanov <rushans@google.com> > Cr-Commit-Position: refs/heads/master@{#817408} TBR=treib@chromium.org,rushans@google.com,paulavidas@google.com Change-Id: Ib76160df2896caf1e14515d9f94c000cdbd133ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135167,1138843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475755Reviewed-by:
-
Deepanjan Roy authored
Also some other minor code changes. Change-Id: I3ef1f5a92506c394b6f496944cdabb75f7689310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472478Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817472}
-
Viktor Semeniuk authored
This change adds Password Check feature to testing config. Bug: 1075494 Change-Id: Id978b05e839d0e1f492396a7b0a12e8e2f516bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436817Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#817471}
-
sandromaggi authored
This CL renames the wrongly named |GetElementPosition| to |GetElementRect|. It changes the callback from a bool to a |ClientStatus|. This CL changes the callback from |GetVisualViewport| from a bool to a |ClientStatus|. Bug: b/168107066 Change-Id: Ib6ca58007f587993954598c72936dd1574a6bc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474293Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#817470}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //services/network. R=morlovich@chromium.org Bug: 1113033 Change-Id: I0c9b39b705c8c44d9567f78952ee5e17d6f3855f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473378 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817469}
-
Peter Kasting authored
Bug: 772945 Change-Id: I5c4f19ddc8bbfe9aa4b533d04243ff59bfcf88bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473587 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#817468}
-
Ramin Halavati authored
Support of ephemeral Guest profiles in several classes of chrome/browser/profile folder is updated. Bug: 1125474 Change-Id: I829bbc3f812f51466b90b6c2286c724fce85f767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461011Reviewed-by:
-
Sébastien Séguin-Gagnon authored
They are more efficient for binary size: https://chromium.googlesource.com/chromium/src/tools/+/refs/heads/master/metrics/histograms/README.md#coding-emitting-to-histograms Change-Id: I03d41e1d29b69470001d70f5f20934d3e610e3e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472443Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#817466}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c4de62d51fff..239f92ecf7fc 2020-10-15 philipp.hancke@googlemail.com introduce an unsupported content description type 2020-10-15 ivoc@webrtc.org Signal to NetEq Controller if arrived packets are DTX packets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifcfb38fd2aece0ea11baa31cbf387ceaca001c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474578Reviewed-by:
-
Sébastien Séguin-Gagnon authored
The histograms.xml already mentioned the enum. Bug: 1138614 Change-Id: I6552185daf485e09ffe24063382f3b8f89433c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473037Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
There should be no reason to recompute the ::selection style if it is already cached on the originating element's ComputedStyle. Also, we had another method which did the cache lookup, but that method did not handle input selection like the other method did. This coincidentally fixes an issue with missing text-shadow in text input selection. TEST=virtual/forced-high-contrast-colors/fast/css/forced-colors-mode/forced-colors-mode-15.html Bug: 1055101 Change-Id: I40eac078e61f626d0ff25913530a2bbe4ea975b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465750Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#817463}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3351394f225e..179979c8b382 2020-10-15 sigurds@chromium.org Remove isScrolledToBottom from Element's prototype 2020-10-15 alcastano@google.com Use Markdown for CSP related messages in the Issue tab 2020-10-15 mathias@chromium.org Improve dark theme contrast for Sources text selection 2020-10-15 pfaffe@chromium.org Add an emscripten config file 2020-10-15 kprokopenko@google.com Replace icons in the issues tab with the new Icon component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125465,chromium:1126031,chromium:1128888,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idbf8fafdec13e37b606d722e43fc33e41105c502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474602Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/10e5c20c9931..dfccae249ee2 2020-10-15 dberris@chromium.org chromeperf: Improve Monorail interaction logging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I71bd440d9d7c2e1c65d87f573a64b742c485c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474604Reviewed-by:
-
Nate Fischer authored
This removes "actionSearch" search from the IME options, since this appears to have been causing a crash on Android L and M. This also seems to have been the cause of some UI jank on higher Android OS versions (tapping the action button used to cause the fragment layout to quickly jump up and down). I don't think I had a particularly good reason for including actionSearch and the keyboard seems to behave as expected without it. I tried writing automated tests for this but I couldn't get the crash to repro in the test. Fixed: 1136300 Test: manual - tapped the action button on several Android L, M, P, & Q Change-Id: Ia200119259e8eccae46b4762f23fcd900e5738dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463075 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#817460}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6f2d01f0096..0963e7ee54a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: I8d4518c913207068b1008ea42f412607ee89acac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817459}
-
Rob Buis authored
In order to react to changing values for the lspace/rspace attributes, recalc the computed style so MathLSpace/MathRSpace internal values are updated, and do a relayout of the operator next. Bug: 6606 Change-Id: I08b9bad216d7902f6c6d705c748fcb0677407316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474354Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#817458}
-
Mohamed Adel authored
-Adds complex categories that support 2 developer buttons -Moves all init methods from builders to the base builder -Modifies response builder to accommodate for developer buttons -Tests the built category and its response Bug: 1136061 Change-Id: Ifabb0d06e8379f957ff8af7ab4bc8ea2228cf38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471637 Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#817457}
-
Mugdha Lakhani authored
This currently doesn't add support for waking the browser up to process registrations. That will be done later once BackgroundTaskScheduler supports multiple profiles. (crbug.com/1087482). A few simple browsertests have been added to verify Weblayer-specific logic. Bug: 1087486 Change-Id: Id9cf98c05f46fa58f0739aa853876ca51e71dd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460895 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#817456}
-
Rohit Agarwal authored
Bug: 1133656 Change-Id: Ia80c3887719fd05bfd2811e304d7b46690615593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462079Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#817455}
-
Christian Biesinger authored
A small float number will convert to a zero layout unit, leading to a division by zero. R=ikilpatrick@chromium.org, mstensho@chromium.org Fixed: 1137262, 1137264, 1137471, 1137227 Change-Id: Iea57ab61369570f08e74384a763e6ec4f2fa155e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475453 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#817454}
-
Stepan Khapugin authored
Plumbs dispatcher to BVC. Makes the browser coordinator zero it out during shutdown before stopping child coordinators to avoid a crash. Bug: 1137686 Test: No repro steps available. Change-Id: Ica001018459d3667c53f010487292ffae774d8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471737Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817453}
-
Noel Gordon authored
Tune up the current API doc comments as it stands today. There is more discuss and we might amend our public methods or update them, given V8 bugs preventing collection to background extension page code coverage, decide if GetCoverage() API should implicitly stop code coverage (what it does today and works for the browser test used-case) and so on. Tbr: benreich Bug: 1113941 Change-Id: I5684e399cd601c5119652a15966cf874b3c56ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474954Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817452}
-
Noel Gordon authored
Similarly to SpanToStringPiece just above, a {} can in-place construct a type: it calls the type constructor with the provided {values...}, a shorthand to save writing the constructor std::string(...). The same code is used in file manager browser test, where it is called EncodeURI, and used for files app DocumentsProvider integration tests. Change it to use {} type construction. Note the subtle distinction b/w encodeURI, encodeURIComponent (the web APIs) still needs addressing for our DevtoolsListener use-case, so TBD once the URLs in our code coverage output is being post-processed with the chromium bot coverage tools. Tbr: benreich Bug: 1113941 Change-Id: I58ec172ef738d3314fbd1a008ffdc76f1f89c1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474533Reviewed-by:
-
