- 13 Nov, 2017 40 commits
-
-
Scott Violet authored
The FYI bot ran without any failures in browser_tests for the weekend. BUG=755272,755328 TEST=test only change Change-Id: I104e75be6c0f6edf767cb1e67eafb4514725d1c2 Reviewed-on: https://chromium-review.googlesource.com/767015Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#516085}
-
Xianzhu Wang authored
Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7258834a228a67f0adae1496fb89ebe2ed29c3f8 Reviewed-on: https://chromium-review.googlesource.com/723859 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516084}
-
Matthew Wang authored
Needed for JS support for OpenVPN.ExtraHosts Bug=742666 TEST=Manually tested using networkingPrivate Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If0de0606074c6805311d9b299bdc5c0a3de91b19 Reviewed-on: https://chromium-review.googlesource.com/726884Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#516083}
-
Raymond Toy authored
The test code for verifying the scaling of the FFT was totally confused (and confusing). Correct the code, and only use the promise instead of both the promise and the completion event. Bug: 783314 Test: Analyser/realtimeanalyser-fft-scaling.html Change-Id: Iecc607205c1cd0ed6e76bfa7c627907238f6a46e Reviewed-on: https://chromium-review.googlesource.com/761436Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#516082}
-
Lukasz Anforowicz authored
Before this CL, windows (or tabs, panels, etc.) created by chrome.windows.create API form a relationship that is almost, but not quite, like an opener relationship: 1. Unlike in a true opener relationship, the 2 frames (opener and openee) can find each other, but only if they are still in the same process. For example, if only 1 frame navigates cross-process, then the frames won't be able to find each other (for a specific example please see https://crbug.com/713888#c5). 2. Unlike in a true opener relationship, window.opener is not set (and consequently cannot be navigated by the openee). After this CL, chrome.windows.create API forms a true opener relationship *iff* the new parameter - setSelfAsOpener is used. Otherwise, the newly opened window is created in a separate browsing instance. This is required for later restricting named frame lookup to the current browsing instance (see https://crbug.com/718489). The CL establishes a true opener relationship, by having extensions::WindowsCreateFunction::Run pass an opener (a RenderFrameHost*) into chrome::NavigateParams, rather than using |force_new_process_for_new_contents| field which this CL removes. This CL tweaks ExtensionApiTest.WindowsCreateVsBrowsingInstance test so that: - The test is closer to what the hangouts extension does (it navigates both windows to the same web origin and *then* attempts to lookup one window from the other). Without this modification, the test would NOT have caught the hangouts extension regression that was almost introduced by https://crrev.com/2873503002). - The test verifies the opener relationship (i.e. |window.opener|, findability via |window.open|, SiteInstance::IsRelatedSiteInstance) rather than accidental, indirect manifestations of having an opener relationship (i.e. being in the same process or site instance). Relevant automated tests: - Tweaked test: - ExtensionApiTest.WindowsCreateVsSiteInstance (the window.open part passes before and after this CL; the window.opener part + the IsRelatedSiteInstance part only pass after this CL) - Other tests: - AppBackgroundPageApiTest.Basic (hosted app -> background page can violate browsing instance; tests handling of mapping of web urls [full url, not just origin] to extensions) - CtrlClickShouldEndUpInNewProcessTest.* tests (tests for behavior that used to depend on the removed |force_new_process_for_new_contents| field). I have also verified that the Hangouts extension (current prod version - 2017.1019.418.1) works fine before and after this CL (i.e. I have verified that this CL doesn't regress https://crbug.com/597750). Bug: 713888 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Test: See above. Change-Id: If23ac7b72256bfcd695fc4bc3759a5bd73f4812f Reviewed-on: https://chromium-review.googlesource.com/758801Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#516081}
-
John Abd-El-Malek authored
BUG=598073 TBR=yzshen@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibbafcf79f7bf10d1b96f252c94f1b90ec668cf6d Reviewed-on: https://chromium-review.googlesource.com/767025 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#516080}
-
Hwanseung Lee authored
fix the normalize-ident.html LayoutTest failure. normalize-ident.html seems like to merge between my patch which is replaced with Element.attributeSytleMap pass CQ dry run and merge. Bug: 784278, 774933 Change-Id: I779b6177399c3e10b6323b6ed891d81e523cfcfe Reviewed-on: https://chromium-review.googlesource.com/765753Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#516079}
-
Jamie Walch authored
Bug: 783173 Change-Id: I2bcf961155fab34a9a58865ca17ebe28876bab10 Reviewed-on: https://chromium-review.googlesource.com/764118 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#516078}
-
Yuke Liao authored
This reverts commit d16c535e. Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I978fde2edb396307d896a2027beb04457e5f1972 Reviewed-on: https://chromium-review.googlesource.com/758809Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516077}
-
spqchan authored
Currently when you click on an item in a folder on the bookmarks bar, the item will flash several times to provide feedback to the user. This CL reduces the flashing so that it will only flash once before closing the menu. Bug: 640138 Change-Id: I7bbc51ae0f4c4a1aac1d908b41984efb310f3854 Reviewed-on: https://chromium-review.googlesource.com/765094Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#516076}
-
nednguyen authored
Back then, telemetry_perf_unittest was removed from linux_android_rel_ng because it occasionally get stuck while fetching dependent files from GS. Two things have changed since then: 1) linux_android_rel_ng is swarmed, which mean we don't run telemetry_perf_unittest in multi-process mode. 2) Dependent telemetry files are prefetched during "gclient sync" (crbug.com/780967) This CL reenables telemetry_perf_unittest on linux_android_rel_ng to get coverage on Nexus5 devices. Bug: 725516 Change-Id: Ib5ff018be5d702c3d60ee3a09cf5fdfb36b605d5 Reviewed-on: https://chromium-review.googlesource.com/764570Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#516075}
-
Emircan Uysaler authored
This CL is a followup to https://chromium-review.googlesource.com/743022. It adds the missing stride information for single planar frames. Bug: 555909 Change-Id: Ied15fa15b898dbd17f3dae45788b68a0a286ef24 Reviewed-on: https://chromium-review.googlesource.com/766867Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#516074}
-
Ashley Enstad authored
This change adds speedometer-future and speedometer2-future benchmarks to the perf waterfall. These benchmarks enable v8 developers to see the performance of upcoming VM features that aren't ready to be shipped yet. BUG=chromium:777818 Change-Id: If77b51046a279706d6f48d6a73733f068a55e91d Reviewed-on: https://chromium-review.googlesource.com/764403 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#516073}
-
Tarun Bansal authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 753436 Change-Id: I10a88bac9831ed86251af6e78185bf5a5d6bdf2b Reviewed-on: https://chromium-review.googlesource.com/764964Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#516072}
-
Raymond Toy authored
Move the ConstantSourceNode tests from the chrome directory to the the-constantsourcenode-interface directory. The test failures on Firefox are bugs in Firefox and issues have been filed. Safari and Edge fail these because they don't currently support ConstantSourceNode. Remove these tests from LayoutTests/webaudio since the WPT tests are identical except for the script locations (as confirmed by diffing). Bug: 745778 Change-Id: I2c082834a78437e2d6773ef890dfaf063b3ac49e Reviewed-on: https://chromium-review.googlesource.com/759023Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#516071}
-
Jonathan Metzman authored
Add code to print out native input for proto fuzzers. Document this and other miscellanious proto fuzzer things as well. Bug: 783293 Change-Id: I4b9adbe1f9df2fb16d2b05a33cfe5b12911716b6 Reviewed-on: https://chromium-review.googlesource.com/765567Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516070}
-
Vladimir Levin authored
This patch address an UMA assert failure. It happens because we record metrics with a null client in most of the tests (the metrics name is never set). However, some tests that verify UMA buckets do set the name. In those cases, UMA assert fails since the we are using a different uma name in the same process. The fix is to only record UMAs if we have a client name set. Ideally we would fix this at the test level instead, so I left a TODO. R=khushalsagar@chromium.org, ericrk@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ida6d605963d123ce683b1c1b8b9814904d17ff45 Reviewed-on: https://chromium-review.googlesource.com/764583Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516069}
-
Tibor Goldschwendt authored
Bind Ganesh to //ui/gl provided GL functions. This avoids the need for linking to system provided EGL and GLESv2 libraries. Bug: 782871, 782540 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I04f250ac68b926b25c7563a8fad4f7d939930da2 Reviewed-on: https://chromium-review.googlesource.com/764648Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#516068}
-
Elly Fong-Jones authored
This change replaces the infobar's custom padding with the new INSETS_DIALOG padding constant. This causes the infobar's icon to be aligned with the other controls on the left margin. Bug: 610428 Change-Id: Idb4c2faaa16004951eaf9988cd768b7dcc359167 Reviewed-on: https://chromium-review.googlesource.com/758558Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#516067}
-
Ashley Enstad authored
Instead of verifying that a user manually ran the update command, just run it anyways and block presubmit if there are uncommitted changes (namely the updated csv and json files). BUG=chromium:781312 Change-Id: I8f05cd0bf817ca958c608c0e54c87a990ba6848e Reviewed-on: https://chromium-review.googlesource.com/754062 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#516066}
-
Xiyuan Xia authored
Bug: 771698, 780542 Change-Id: I751a646cd04ee62eaf9de34df974c6560b82afbe Reviewed-on: https://chromium-review.googlesource.com/761716Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#516065}
-
Randy Smith authored
Bug: 721395 Change-Id: I0d4c7152dededabbc37d11a0f799837d87930958 Reviewed-on: https://chromium-review.googlesource.com/759696Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#516064}
-
Ahmed Fakhry authored
Reading the keyboard device layout property from udev might fail. When this happens, we used to store the keyboard info with a default layout value = Layout1. This CL avoid storing the keyboard info when a failure in udev is detected, we will still fallback to the default layout for the current key event, but we will attempt to re-read the layout property from udev on subsequent keys until a valid layout is returned. This eliminates the need to reboot the device to exit the bad state. BUG=783166 TEST=added new test. Change-Id: I94d6771ef955e20cee831ad0a93e31dcaaf8f610 Reviewed-on: https://chromium-review.googlesource.com/764444Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#516063}
-
dpapad authored
mocha.grep() does substring matching, which causes accidentally running some tests multiple times. Strengthen the RegExp passed to mocha.grep() to ensure that no sub-string matching occurs. This CL deploys the new runMochaTest() method in MD Extensions only. Remaining WebUI tests will be updated in follow up CLs. Before this CL there were actually a couple of tests accidentally run multiple times, fixed now. Bug: 783334 Change-Id: I63fe4fc327f5a2bba4307b087380f1883d337cc1 Reviewed-on: https://chromium-review.googlesource.com/761981 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#516062}
-
kylechar authored
Add a custom GLSurfaceOSMesaPng that outputs to file. Unfortunately the GPU sandbox will block this from writing to file, so it only works without the GPU sandbox. Bug: 783792 Change-Id: I868702aa5dab81bffb8ea4867d659225255e5d50 Reviewed-on: https://chromium-review.googlesource.com/758608 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#516061}
-
Matt Menke authored
The behavior is tested by NetworkContextConfigurationBrowserTest.Cache, and the latter uses the correct URLRequestContext when the network service is in use. In another CL, I'll be switching the vestigal in-process system URLRequestContext to use default parameters when the network service is enabled, which will cause that context to use an in-memory cache. When the network service is disabled, the legacy URLRequestContext will still have no cache. Seems best to just remove the test, since it's redundant. Bug: 754007 Change-Id: I0ce14ee613cf0d400d6fc86e8931eae370df13f5 Reviewed-on: https://chromium-review.googlesource.com/766951Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516060}
-
rbpotter authored
Convert the remaining settings sections that are similar to copies and layout. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I987905956434e37ac5a5409454c87a1f6babb900 Reviewed-on: https://chromium-review.googlesource.com/759679Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#516059}
-
Xianzhu Wang authored
There were hundreds of tests directly under paint/invalidation, causing little paralellism and long run time when running the directory without --fully-parallel, and always little parallelism and long run time when running the directory as virtual suite even with --fully-parallel. Move some tests into subdirectories to increase parallelism. Examples: *selection*.html => selection/ *multicol*.html => multicol/ *scroll*.html => scroll/ *table*.html => table/ *box*.html => box/ ... In addition of moving the tests: - Relative paths in the HTML files are updated; - Expectation files are updated; - -expected* files are moved, including common files, platform-specific files and flag-specific files. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id1498a289ee7c70716216ebdfe3e625d94bca35c Reviewed-on: https://chromium-review.googlesource.com/766652 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516058}
-
Vladimir Levin authored
This patch adds a helper class that can stringify PaintOps. This is done in a best effort manner to help with debugging. Also adds corresponding unittests. R=enne@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic5003365251fa40710e7a79ccf3934096d9f7d6a Reviewed-on: https://chromium-review.googlesource.com/764390Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516057}
-
Dale Curtis authored
We were incorrectly ignoring the stream latency component when calculating the fixed latency of streams. This needs to be done for both input and output. Since these methods are very similar I've refactored the one our input and output streams had into a common AudioMangerMac method. BUG=783282 TEST=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic583a2f314728b566a5a3e3de8c8ffd118652f91 Reviewed-on: https://chromium-review.googlesource.com/764542 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#516056}
-
Koji Ishii authored
This patch fixes an inconsistency in NGTextFragmentPaintInfo where text offset is for the whole text content of the block, while the text itself is for the text fragment. While fixing to either way is possible, this patch fixes to use the block text, to align to character indexes in the ShapeResult. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1db3e91bebb724ba24c408ce05cd10c70f66e887 Reviewed-on: https://chromium-review.googlesource.com/762812Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#516055}
-
Shanfeng Zhang authored
When experiment on and bank name available. Bug: 781041 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I178259d749c6ea1fe5402b33647077de176c3bd9 Reviewed-on: https://chromium-review.googlesource.com/754281Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Cr-Commit-Position: refs/heads/master@{#516054}
-
John Budorick authored
Bug: 771231 Change-Id: I18fe47904ae828f98fbfca7186c2cdf4cffe05cf Reviewed-on: https://chromium-review.googlesource.com/762409Reviewed-by:
Yoland Yan <yolandyan@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#516053}
-
Matthew Jones authored
In cases where the indeterminate animation was running and stopped, if progress jumped to 100%, the progress bar would remain on-screen. In most cases, if the progress bar reaches 100%, the progress bar is hidden immediately. If the animation is running, the user should be able to see progress reach 100% before it disappears. The discrepancy was in this logic. This change ensures that the progress bar restarts animation on update and blocks finish until the animation is complete. BUG=780856 Change-Id: Ife33e5d69824cb48b03a38312f817a31963b848a Reviewed-on: https://chromium-review.googlesource.com/766848Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#516052}
-
nednguyen authored
Previously, smoothness.maps benchmark uses TBMv1 measurement to collect the data (unlike others smoothness tests which use smoothness measurement). With https://chromium-review.googlesource.com/764536, measuring smoothness only supported through smoothness measurement, which breaks smoothness.maps. This CL fixes the breakage by switching smoothness.maps benchmark to use smoothness measurement like others. Bug: 784418,760553 Change-Id: Id423b5210f0741254ead967a266cf8610fc9a883 Reviewed-on: https://chromium-review.googlesource.com/766482Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#516051}
-
Scott Violet authored
When a client embeds another client it can choose to intercept events by specifying kEmbedFlagEmbedderInterceptsEvents. When this happens events targetted at windows created by the embedded client go to the embedder. When this happens the embedder needs to know about the windows created by the embedded client, otherwise it has no way to know the real target. This patch makes it so that if kEmbedFlagEmbedderInterceptsEvents was specified (and the client was not created by way of Embed()) then the embedder client sees all windows created by any embedded client. The embedder can still not operate on the windows, but it sees the windows. In terms of chrome this makes it so that browser sees the windows created by renderers. Renderers can not see any windows created by other renderers (even ones embedded in renderers). The long term goal is to get rid of kEmbedFlagEmbedderInterceptsEvents, at which point this will be removed. BUG=781391 TEST=covered by test Change-Id: I110d3205cd3b9c3bfa0e78760dd58b517fa43856 Reviewed-on: https://chromium-review.googlesource.com/760797 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#516050}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/b251b72d3d91..0030c5ed3ca6 $ git log b251b72d3..0030c5ed3 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 mtklein generalize IntelIris540 Win/Vulkan blacklists 2017-11-13 mtklein streamline GDI bots 2017-11-13 egdaniel Add tilesmode_npot to nexus player blacklist 2017-11-13 robertphillips Patch up ref counting of proxies (take 2) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I466bbbbb47152c5f32febb9557fa13fc6e061f5d Reviewed-on: https://chromium-review.googlesource.com/767053Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516049}
-
Chris Blume authored
zlib's deflate requires non-zero length inputs. As a result, the deflate fuzzer was asserting on the error value indicating an invalid input when the fuzzer provided a zero-length input. This change will exit early when the input is zero-length so it matches the precondition required for deflate. BUG=784148 Change-Id: I12558bb47c4bc5e5147d07707fe01a0e8feb314b Reviewed-on: https://chromium-review.googlesource.com/766474 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#516048}
-
Matt Reynolds authored
On Mac, Xbox gamepads connected over USB are supported by an internal driver that is used when no OS-level driver is installed. This CL adds haptics support for Xbox gamepads connected in this way. BUG=749295 Change-Id: Ie674b0b832ad0f1922821c3f9ef1ce232ab2dcd0 Reviewed-on: https://chromium-review.googlesource.com/754366Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#516047}
-
Maks Orlovich authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iec06439e965046a8173d2a7aa23fd66728792a68 Reviewed-on: https://chromium-review.googlesource.com/751281 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#516046}
-