GitLab

When mirroring I think of the source as the source of the
mirror, and the target where the mirror is being displayed.
That isn't the case here.

BUG=none
TEST=none

Change-Id: Id55075cee0f96871bb6d8b6f47257a4cafad2d09
Reviewed-on: https://chromium-review.googlesource.com/c/1354576Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612037}

BUG=907572

Change-Id: Iad549397cbf3e6391d3d92dccb492ef73e1cb65d
Reviewed-on: https://chromium-review.googlesource.com/c/1354443Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612036}

This reverts commit eacb6ed3.

Reason for revert: Makes ChromeVoxLiveRegionsUnitTests flaky:

https://crbug.com/909973
https://crbug.com/909984

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16620

[ RUN      ] ChromeVoxLiveRegionsUnitTest.AddToLiveRegion
[23526:23526:1128/180604.087820:WARNING:chrome_browser_main_chromeos.cc(544)] Running as stub user with profile dir: test-user
[23526:23526:1128/180604.176618:WARNING:easy_unlock_service_regular.cc(523)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
[23526:23526:1128/180604.197349:INFO:remote_commands_service.cc(38)] Fetching remote commands.
[23526:23526:1128/180604.222292:WARNING:remote_commands_service.cc(40)] Client is not registered.
[23526:23526:1128/180604.222531:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
[23526:23526:1128/180604.222602:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
[23526:23526:1128/180604.222654:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
[23526:23526:1128/180604.222699:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[23526:23526:1128/180604.245434:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[23526:23526:1128/180604.326719:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[23526:23526:1128/180604.607132:INFO:CONSOLE(1281)] "Running TestCase ChromeVoxLiveRegionsUnitTest.AddToLiveRegion", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1281)
[23526:23526:1128/180604.617409:INFO:CONSOLE(53)] "done setup", source: file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/tester.js (53)
[23526:23526:1128/180604.636340:ERROR:web_ui_test_handler.cc(100)] Failed: RUN_TEST_F("ChromeVoxLiveRegionsUnitTest","AddToLiveRegion")
AssertionError: expected undefined to equal 'Eric'
    at Function.assert.strictEqual (file:///b/s/w/ir/third_party/chaijs/chai.js:2277:32)
    at assertEquals (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:923:15)
    at ChromeVoxLiveRegionsUnitTest.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs:157:7)
    at ChromeVoxLiveRegionsUnitTest.<anonymous> (file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:123:12)
    at CallbackHelper.<anonymous> (file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/callback_helper.js:32:16)
    at CallFunctionAction.invoke (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:1430:22)
    at RunAllAction.invoke (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:1591:35)
    at file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/callback_helper.js:42:14
    at file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js:319:59
gen/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test-gen.cc:1442: Failure
Value of: RunJavascriptTestF( true, "ChromeVoxLiveRegionsUnitTest", "AddToLiveRegion")
  Actual: false
Expected: true

Original change's description:
> Reland "Start gpu channel and compositor mojo pipe collection eagerly"
> 
> This is a reland of 66794d00
> 
> In this reland we revert changes to RenderThreadImpl and mus to make
> LayerTreeFrameSink creation asynchronous again.
> 
> Then in RenderWidget we must remember that a warmup is underway, we do
> so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool
> and invalidate the WeakPtrFactory.
> 
> If a request for a frame sink beats the warmup completing, we save
> the callback and run that instead of saving the frame sink on
> RenderWidget when the warmup completes.
> 
> This ignores some weird weird corner cases like where warmup is
> aborted then we start another warmup or unfreeze the widget or something
> and will just make redundant requests. Since these are so rare they
> are not worth adding complexity for.
> 
> Original change's description:
> > Start gpu channel and compositor mojo pipe collection eagerly
> >
> > When a RenderWidget is frozen, its compositor is stopped. However when
> > the main frame is being navigated, we want to start requesting mojo
> > pipes for the gpu and display compositor immediately so that it can
> > happen in parallel with the navigation loading.
> >
> > Previously, we just always did this when creating a RenderWidget, and
> > left them active when freezing the RenderWidget. After 678f025f
> > however, we don't, and this causes time-to-first-pixels regressions
> > on navigation.
> >
> > So we add a WarmupCompositor() method to RenderWidget, and call this
> > from RenderFrameImpl::CreateFrame() when it makes the provisional
> > frame, and the WebFrameWidget, since we expect to make use of the
> > main frame RenderWidget shortly.
> >
> > Then, if RenderFrameImpl::FrameDetached() occurs, due to the
> > navigation failing, we will AbortWarmupCompositor() to drop the
> > mojo pipes instead of holding onto them indefinitely.
> >
> > This recovers the loading regressions introduced, while also not
> > allocating mojo channels for frozen RenderWidgets indefinitely.
> >
> > In order to do this reasonably, we drop the "callback" from the
> > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that
> > it always returns something immediately. This way RenderWidget
> > does not need to worry about having a task run to collect the
> > new frame sink, and ordering with tasks from the compositor to
> > collect it.
> >
> > R=piman@chromium.org
> >
> > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0
> > Bug: 905191
> > Reviewed-on: https://chromium-review.googlesource.com/c/1341073
> > Commit-Queue: danakj <danakj@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#610909}
> 
> Bug: 905191
> Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60
> Reviewed-on: https://chromium-review.googlesource.com/c/1351938
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611838}

TBR=danakj@chromium.org,dcheng@chromium.org,sergeyu@chromium.org,piman@chromium.org

Change-Id: I68e348f7fac337580bf3f79a29f618ac3ce3c6d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905191
Reviewed-on: https://chromium-review.googlesource.com/c/1354725Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612035}

In debug mode, Windows WebAuthn requests would previously crash because the
WinWebAuthnApiAuthenticator destructor invoked the destructor of its
base::Thread member, which is blocking, on a task runner that was non-blocking.

This works around the issue by moving the thread for doing the blocking Windows
API calls into the WinWebAuthnApi wrapper class. Unfortunately, this moves the
inputs to the API call out of scope with the actual blocking call, which is a
problem since they get passed as pointers. Therefore we now have to stash all
of this data temporarily in the FidoAuthenticator instance while the API call
is pending.

Bug: 898718
Change-Id: Ic36c4f9119e1fcc452cc789182f98c3c59f51610
Reviewed-on: https://chromium-review.googlesource.com/c/1354559
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612034}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ife2e72a5e39aa5453143b2ff589039dcb3d310b0
Reviewed-on: https://chromium-review.googlesource.com/c/1354408Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612033}

Move 'disabled' state handling code from HTMLFormControlElement to
ListedElement. This is a preparation to support 'disabledStateChangedCallback'
of form-associated custom elmeents.

This CL has no behavior changes.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: I34703dd7b167be13e4b19324b5e931bda224a866
Reviewed-on: https://chromium-review.googlesource.com/c/1353039
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612032}

Prevents stack overflow when copying/moving large files caused by continually
wrapping the callback with base::AdaptCallbackForRepeating.

Bug: 905798
Change-Id: I5bd6c923a27d626cd2c2b157c301c7e43de923ce
Reviewed-on: https://chromium-review.googlesource.com/c/1353042Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612031}

Bug: 726066, 909750
Change-Id: I12242ad3facdc7e8877833d2c436e383f2c9530f
Reviewed-on: https://chromium-review.googlesource.com/c/1352322
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612030}

Add a histogram to record when we close an audible
tab whether it was the newest.

BUG=907671

Change-Id: Ie607223ee94b011389c1c7e3146c779f9cfce47c
Reviewed-on: https://chromium-review.googlesource.com/c/1347492Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612029}

These bindings are needed to implement GL_WEBGL_multi_draw and
GL_WEBGL_multi_draw_instanced in the passthrough cmd decoder

Bug: chromium:890539
Change-Id: I5fb9398ff258387261af5306c8e94ef6192107c6
Reviewed-on: https://chromium-review.googlesource.com/c/1343099Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612028}

"Invalid Application ID" crashes have surfaced now that the new
RemotePlayback pipeline is turned on by default in M72. The custom app
ID fetched from the AndroidManifest should never be empty in theory, but
in practice it seems like it can be.

This CL fixes the issue by adding an empty check, and falling back to
the default media receiver if ever we aren't able to fetch a valid
app ID.

Bug: 902871
Change-Id: I573f9a11433c1394cee99459a3154539be8d7081
Reviewed-on: https://chromium-review.googlesource.com/c/1354570Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612027}

This reverts commit 514c49d4.

Reason for revert: Breaks test on Mac10.12 Tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17139

[ RUN      ] WebMediaPlayerMSTest.RotationChange/3
../../content/renderer/media/stream/webmediaplayer_ms_unittest.cc:1136: Failure
Expected equality of these values:
  kStandardHeight
    Which is: 240
  natural_size.height
    Which is: 320
Stack trace:
0   content_unittests                   0x00000001030aac4b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   content_unittests                   0x00000001030aa609 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   content_unittests                   0x0000000102314244 content::WebMediaPlayerMSTest_RotationChange_Test::TestBody() + 3492


Original change's description:
> Use the SequenceManager in ScopedTaskEnvironment
> 
> This is necessary because we want content::TestBrowserThreadBundle to
> own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment
> and you can't have two SequenceManagers on the same thread.
> 
> This patch allows ScopedTaskEnvironment to optionally work with an
> externally owned SequenceManager solving the problem.
> 
> This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk,
> 
> We now have the ability to mock time on the UI thread.
> 
> TBR=asvitkine@chromium.org,miu@chromium.org
> 
> Bug: 863341, 891670, 708584
> Change-Id: I96aa34c5cc8832c263621c2d9c228a8da4372c68
> Reviewed-on: https://chromium-review.googlesource.com/c/1324391
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611895}

TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org

Change-Id: I4b4922b5f393bcb9aace5f28b09a61fbdf2bfa04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863341, 891670, 708584
Reviewed-on: https://chromium-review.googlesource.com/c/1354723Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612026}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/cdbaaa244432..0eed05c79fc2


git log cdbaaa244432..0eed05c79fc2 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 dgarrett@chromium.org Revert "Reland generic_stage.GetRepoRepository: Make arguments flexible."


Created with:
  gclient setdep -r src/third_party/chromite@0eed05c79fc2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib3ccbc7854cacedfe9617742b4fab6c1ea3c5f51
Reviewed-on: https://chromium-review.googlesource.com/c/1354335Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612025}

The Material Design style introduced in M69 is now default.

Bug: 893362
Change-Id: I17049cfb6b1c2b61aef2edd221645d77b5297fca
Reviewed-on: https://chromium-review.googlesource.com/c/1313868
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612024}

Otherwise we could read out-of-bounds even if an invalid |buffer| is passed
in and in theory we should not read the buffer at all.

BUG=908749
TEST=gl_tests in ASAN build
R=piman@chromium.org

Change-Id: I94b69b56ce3358ff9bfc0e21f0618aec4371d1ec
Reviewed-on: https://chromium-review.googlesource.com/c/1354571Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612023}

Conversions performed with a tool
./node_modules/lebab/bin/index.js --replace ui/webui/resources/cr_elements --transform let

Also adding .eslintrc.js file to prevent future additions of 'var' in that folder.

Bug: 792774
Change-Id: Ia7de669ffa717bc898fdc2989b9820a156ac1b1a
Reviewed-on: https://chromium-review.googlesource.com/c/1354565Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612022}

https://chromium.googlesource.com/angle/angle.git/+log/5829c03d383e..2c0d6a9404cd


git log 5829c03d383e..2c0d6a9404cd --date=short --no-merges --format='%ad %ae %s'
2018-11-29 jmadill@chromium.org WebGL: Fix DrawElements test and remove size check.


Created with:
  gclient setdep -r src/third_party/angle@2c0d6a9404cd

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I1dadc9a160917ab030dc01c69e9d07a4ba9fafce
Reviewed-on: https://chromium-review.googlesource.com/c/1354622Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612021}

The HTML5 spec recently refactored WindowBase64 into
WindowOrWorkerGlobalScope, removing the need to reflect this in our IDL.
{btoa,atob} implementations have been merged into
window_or_worker_global_scope.{cc,h}.

This CL has no behavior changes.

Bug: 701498
Change-Id: Ib40b30e166ef3e4c0c92791f3ffecbb7bd1bed0b
Reviewed-on: https://chromium-review.googlesource.com/c/1351141Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#612020}

https://pdfium.googlesource.com/pdfium.git/+log/0559d9d48f8b..7c8f33a1f59c


git log 0559d9d48f8b..7c8f33a1f59c --date=short --no-merges --format='%ad %ae %s'
2018-11-29 tsepez@chromium.org Use CFWL_Widget::Is*() helpers
2018-11-29 tsepez@chromium.org Allow PDFium to suggest V8 flags via public/ API.
2018-11-29 thestig@chromium.org Remove remaining "exceptions" in fxbarcode.
2018-11-28 tsepez@chromium.org Avoid CFWL_Widget::m_pProperties null check.
2018-11-28 tsepez@chromium.org Replace CFWL_Widget::IsInstance() with IsForm().
2018-11-28 tsepez@chromium.org No need to check CFX_Barcode::Create() return value


Created with:
  gclient setdep -r src/third_party/pdfium@7c8f33a1f59c

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic6b9105a225ec7101f00346b3112790a1193c612
Reviewed-on: https://chromium-review.googlesource.com/c/1354619Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612019}

Bug: 889122
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I797dab237ccf1629fe0c7d0e1152ecac1d00c8d4
Reviewed-on: https://chromium-review.googlesource.com/c/1286198
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612018}

This currently only records attempted link previews, since the feature
is not actually supported yet.  If the histogram shows that users are
frequently attempting to use the 3D touch link preview API, additional
actions may be added.

Bug: 897261
Change-Id: I7cec3daa242146f50ae329a20624c79dd361310d
Reviewed-on: https://chromium-review.googlesource.com/c/1351787
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612017}

Bug: 872343
Change-Id: I54395ae26ee9c2202e77580f76b82f766270fff8
Reviewed-on: https://chromium-review.googlesource.com/c/1352947
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612016}

Fixes controlled buttons not propagating disabled state down to the
paper buttons.

Caused connection buttons to be enabled in some instances where
they should be disabled.

TEST=browser_tests --gtest_filter=*CrSettingsInternetDetailPageTest*
BUG=804455

Change-Id: I878c572e1fc55c8cbf1b4d0d362f27d1f2d0ee8b
Reviewed-on: https://chromium-review.googlesource.com/c/1347062
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612015}

We designed to parse IDL files at collecting per component,
but we found it duplicates the work.

This CL drops the parsing phase in collecting IDL information
per files, and hence we collect IDL information as a collection
of AST objects.
This CL also updates GN dependency to enroll all IDL files
including generated files in the output collections.


Bug: 839389
Change-Id: Ic014c8081c214f23ffffe932db04d5023841a3d1
Reviewed-on: https://chromium-review.googlesource.com/c/1322669Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612014}

(Behind experiment) This CL makes these links keyboard navigable:
- Links found in Console logs with source=Network
- Links found in Console stack traces

Bug: 865674
Change-Id: Icc11d5441e5d7963ffa0b41b07cc8fcdf4575d39
Reviewed-on: https://chromium-review.googlesource.com/c/1318817
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612013}

Fix RamGpuMemoryBuffer enum naming that was forgotten, and some
style nags.

Bug: 902585
Change-Id: Ieede0b6b7164ed8a50c60d94a4449a91bf944eaf
Reviewed-on: https://chromium-review.googlesource.com/c/1354405Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612012}

VAConfig created in GetMaxResolution_Locked() is not destroyed. It should be
destroyed in the end of the function.

BUG=None
TEST=VDA unittest on eve

Change-Id: Ia7e53bb7f9414232820ac6cd5e4eb85777f18ed4
Reviewed-on: https://chromium-review.googlesource.com/c/1348152Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612011}

ForeignLayerDisplayItem's location and size should always equal to
the cc layer's offset_to_transform_parent and bounds, respectively.
Removing them can simplify logic and reduce duplicated data.

Let ForeignLayerDisplayItem create its client by itself. The
client returns VisualRect based on the geometry of the cc layer.

Let ForeignLayerDisplayItem::DrawsContent() return false because it
doesn't issue paint operations.

This enables us not to repaint a foreign layer display item when
the cc layer changes geometry, though this is not the case for now
because we need to update the geometry of the cc layers during paint.
However, with the duplicated data removed, we can decouple cc layer
geometry update from paint if needed.

Change-Id: Idac393608467933bf1eda3691aa4f4cd6379f27e
Reviewed-on: https://chromium-review.googlesource.com/c/1352971
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612010}

Bug: 902196

Change-Id: If1de22019158abde2c1b75d17d5096d5ec43d500
Reviewed-on: https://chromium-review.googlesource.com/c/1353047Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612009}

Bug: 908388
Change-Id: Iecdfd9081cb56769bac3643589c145e648e7bbe4
Reviewed-on: https://chromium-review.googlesource.com/c/1354309Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612008}

Bug: 908654
Change-Id: I184bbfd27ff1116bccb1e5cb9a9ef1e19cacd26d
Reviewed-on: https://chromium-review.googlesource.com/c/1351906
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612007}

Renamed PlatformFontLinux to PlatformFontSkia and enabled that code
on Fuchsia

Also removed unnecessary platform if-defs in that code.

TBR=sky@chromium.org (for renames under //chrome/browser)

Change-Id: Ic51db62d87e2bf33e6095ce42e91a69862c3b402
Reviewed-on: https://chromium-review.googlesource.com/c/1313873
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612006}

Update APIPermission and ManifestPermission (and their subsequent
subclasses) to return a std::unique_ptr from the Clone(), Diff(),
Union(), and Intersection() methods. This makes the ownership of the
return result significantly more clear.

Update all usages of these methods as well.

Bug: 907661
Change-Id: I5110014cca0af9b5364fd8fa8bdcdfc4fee58195
Reviewed-on: https://chromium-review.googlesource.com/c/1347777
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612005}

Stat on top 25 sites showed that the objects that have PaintProperties
but not LocalBorderBoxProperties were only 1% of all objects having
PaintProperties. Most of them were objects with link highlight and some
SVG objects with paint properties.

This fixes a bug in svg/text/text-selection-text-08-b.svg that the opacity
was not applied on the selection tint.

This will simplify handling in situations e.g. when we need to know the
transform state of an object with link highlight.

Change-Id: Iaa48469e69a96c3decb739d6b49526519556b869
Reviewed-on: https://chromium-review.googlesource.com/c/1354221
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612004}

Just names and icons for now. More features will come in future commits.

Tested manually, with "chrome --enable-features=AppService".

BUG=826982

Change-Id: I465daa7597e5172792d185e8b33228b127879057
Reviewed-on: https://chromium-review.googlesource.com/c/1349155
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612003}

This fixes a crash if you don't pass --enable-features=OzoneDrmMojo.
Oops.

Bug: 861853
Test: run_content_shell with no arguments
Change-Id: I5408ca9323b8481ed6c5f092172b75f2181c94fe
Reviewed-on: https://chromium-review.googlesource.com/c/1354502Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612002}

Note that this does not affect mac_chromium_rel_ng.

Bug: 908929
Change-Id: I4834ae78bb0e037a2def2fd73762b5a90c0ef949
Reviewed-on: https://chromium-review.googlesource.com/c/1354131Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612001}

Adds a SharedProtoDatabase that owns a LevelDB instance. The shared
database provides a way to get SharedProtoDatabaseClients to access
the shared DB with a unique namespace/prefix. The SharedProtoDatabase
instance is provided through the KeyedService ProtoDatabaseProvider
so the shared database is tied to the appropriate profile directory.

Bug: 870813
Change-Id: I433518c3fee4d37abcaa0c7efa94e7912da521ec
Reviewed-on: https://chromium-review.googlesource.com/c/1332009Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612000}

This is preferred over unchecked observers.

Bug: b:120097552
Change-Id: Id44822dce375e3400baa336fee3154ad99d18d7f
Reviewed-on: https://chromium-review.googlesource.com/c/1354569
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611999}

Bug: 909944
Change-Id: Ic3304d8a0244a9cea5b5a3b151f8245b8c8269eb
Reviewed-on: https://chromium-review.googlesource.com/c/1354642
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611998}