- 12 Jun, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591977558-7170645d7cf66fa796ff151165a33077272cf120.profdata to chrome-mac-master-1591991989-bc016108b2b5e29558a9e9ceecfec9b523f83fb2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I096c4097a7e99739babf900e02b35d607304372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777968}
-
Sahel Sharify authored
This cl sends the merchant provided updated payment details (in response to a change event) to the invoked native payment app. Change[PaymentMethod|ShippingAddress|ShippingOptions] calls with invalid arguments are responded immediately with a blank bundle only containing the error message. Bug: 1026667 Change-Id: I458120ecaf328140bd711c8e26e41978c71fe9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240048Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777967}
-
Peng Huang authored
Bug: None Change-Id: I89d721e8dc5f1ad322ba1ecea0b45c0e4b97d5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242040 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777966}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I839e5f0c35af8b3a84384a2004409e468d83e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241296Reviewed-by:
-
Ian Kilpatrick authored
Previously we'd always miss the layout-result cache if a sub-tree had an orthogonal root present. This was required as we didn't store the ICB size on the constraint space, so we couldn't determine if this subtree actually needed layout or not. This caused a 2^dom_depth layout explosion for FlexNG. As FlexNG is our first multi-pass layout, always missing the layout result cache in these cases caused extremely long layout times. This patch removes this cache-miss, by instead marking all the writing mode roots as needing layout if the ICB size changes. Bug: 1092747 Change-Id: Iaa58d00d6184ad30554ffb9fdf8c2b68fad40623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242378Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#777964}
-
Scott Violet authored
BUG=1087464 TEST=getAndRemoveBrowserPersistenceIds Change-Id: I3a7cb7da302f91a92353a5a19c07d558d2ebbe6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242683 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#777963}
-
Domenic Denicola authored
Now that I've written a bunch of them, I'm confident in building some abstractions to deduplicate the testing code. This additionally adds jsdoc documentation for all of the exported functions in helpers.mjs. Bug: 1042415 Change-Id: I3e2220708f4d5afff5a815de876971db3f689826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229435Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#777962}
-
Daniel Cheng authored
base::SequenceBound uses alignof(T) to calculate the alignment requirement for the stored type; however, alignof(T) can be smaller than sizeof(void*) (e.g. for a class with no fields or virtuals). Clamp the alignment parameter at a minimum of sizeof(void*) to ensure the preconditions for calling AlignedAlloc() are not violated. Change-Id: I3e2126b70472181ada6e7a60280db1b656b9bff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242972 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#777961}
-
Miguel Casas authored
VA-API offers "normal" and "Low Power" encoding ("entry point", in libva parlance). Certain platforms such as JSL/TGL only offer Low Power ones. VaapiTest.DefaultEntrypointIsSupported verifies that the default entry point is among the supported ones. For that it calls VaapiWrapper's GetDefaultVaEntryPoint(). However, the low-power/normal decision is not there, but near its callsite in VaapiWrapper. This CL moves the low-power encoding entry point decision logic to VaapiWrapper::GetDefaultVaEntryPoint() so the test sees the same thing as the actual production logic. Bug: b:158713599 Change-Id: I477c86a3a1c36a8c0a3598a7406944bae8341249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243268Reviewed-by:Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#777960}
-
Frank Tang authored
Cherry-pick pull/1152to fix minimum group digits Needed to fix Minimum Grouping Digits for Intl.RelativeTimeFormat Add ability to use locale default for minimum grouping digits - patches/grouping_digits.patch - upstream PR: https://github.com/unicode-org/icu/pull/1152 - upbstream bug: https://unicode-org.atlassian.net/browse/ICU-21109 https://chromium.googlesource.com/chromium/deps/icu.git/+log/46f53df..9e7dae8 9e7dae8 Cherry-pick pull/1152to fix minimum group digits e4b8586 Remove *.mk files which no longer exist c981f19 Sort the list in the filter files w/o changes All these three has no dat size impact. Bug: v8:10443 Change-Id: I3b4e32fae2e50c804bc906c5e279f198b35ad752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242745Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777959}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b64ecd9960d5..6f727da62bb0 2020-06-12 handellm@webrtc.org Revert "RtpTransceiverInterface: introduce SetOfferedRtpHeaderExtensions." 2020-06-12 mbonadei@webrtc.org Clobber x86 win bots. 2020-06-12 mflodman@webrtc.org Search and replace gendered terms according to style guide: 2020-06-12 sprang@webrtc.org Adjusts allowable thread count for vp9 decoders. 2020-06-12 danilchap@webrtc.org in AV1 Encoder remove hack of removing temporal delimiter OBU 2020-06-12 titovartem@webrtc.org Revert "Generalize NetworkQualityMetricsReporter to support multiple peers in test" 2020-06-12 nisse@webrtc.org Delete MediaTransportFactory from android and objc apis 2020-06-12 kron@webrtc.org Add decoder support for VP9 profile 1 I444 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051821 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5ce7966a40274a7b07b0e6a89f2321ecb6fd48b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243169Reviewed-by:
-
Angela Yoeurng authored
There was no case to handle KeyEvents for the Button Row buttons previously. This was added so Enter and Space will trigger the button's actions. This CL moves some of the business logic to PopupModel, merging the handling of Mouse/ButtonPressed events and Key events Keyword entry method was also changed to Tab rather than Keyboard shortcut. Bug: 1091351 Change-Id: I2818e47860d8993bbb99836c40d60197b8ef7e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233780 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#777957}
-
Jarryd Goodman authored
Change-Id: Ieb7efb546b20c35f2711cc3c05f85165f7b93767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243457 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#777956}
-
James Long authored
Rough code, mostly copied from wnwen's visualization, as a framework for future visualization work. It is forecast that this code will be restructured heavily in the future, hence the lack of more thorough documentation. npm is used for this project, please read the README on how to run locally. The dependencies so far are: - ESLint - d3 (however, as we continue to identify what is required, I plan to break this up so we only import the v4 microlibraries we actually need) The page is currently served the JSON file via a small Python script. This is easy to use for development, but will hopefully be replaced with either a user file upload or being served from somewhere else. Bug: 1093962 Change-Id: I8d35ae2cde64581ff7d22fb06a29cd850e42cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242171 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#777955}
-
Andrew Grieve authored
Allows us to remove special-casing in java target name patterns. Bug: None Change-Id: I5377b75ea8539194fbf0b88f646ac8869d8fc062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243261 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777954}
-
Hazem Ashmawy authored
This reverts commit 1a25897e. Reason for revert: Mitigate crashes caused by the change Original change's description: > [AW] Keep the MetricsBridgeService running while having active tasks > > Although MetricsBridgeService has a sync AIDL interface where all its > calls block till they finish, recordMetrics does it job > asynchronously behind the scenes where it posts the actual recording > task to a background TaskRunner. This may result in some rare cases > that the service may be killed by the system (because all clients had > unbound the service) while still having some writing tasks in the > background that haven't finished yet. To solve this: > > - Make SequencedTaskRunner static so that all service instances > created by the system will share the same task runner avoiding, > possible race conditions writing to file. > - Make the service both start and bound service. The service will > start itself with the first client binding and it will manage its > own lifecycle to ensure that it stays running until it has finished > its writing tasks. Service will not be destroyed by the system until > all clients unbind and the service calls stopSelf() > See https://developer.android.com/guide/components/bound-services. > > There is no evidence that this actually happens and there is no > reliable way to reproduce this in tests but this is still a potential > bug that should be fixed. > > Fixed: 1082572 > Test: /bin/run_webview_instrumentation_test_apk -f "*MetricsBridgeServiceTest*" > Change-Id: I5e8e9226379f4b2b38f8b720405f78603ae2b3c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235597 > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776763} TBR=ntfschr@chromium.org,hazems@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Fixed: 1093300 Change-Id: Ibb65885ddfb223e32c0d83fa4f28faa26aad8ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241838Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#777953}
-
Kyle Ju authored
It will read the comment history and dump all comments to https://chromium-review.googlesource.com/c/chromium/src/+/2241634/. Also tweak the Gerrit CL SHA so that the SHA is unique identified to each CL. Testing command: third_party/blink/tools/wpt_export.py --credentials ~/.credentials --surface-failures-to-gerrit Output: https://chromium-review.googlesource.com/c/chromium/src/+/2241634 Bug: 1027618 Change-Id: I3a4932524488072cdbb820ccabdd4dd9a079cd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242001 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#777952}
-
Daniel Murphy authored
This adds sync tests for the following cases: * Installing the same app independently on two different profiles * Above, but then uninstalling on one profile. * Syncing of user display mode between profiles * Installing a non-syncing app, then installing a sync version on the second profile, and verifying that the first installation is now syncing. * Unsynced apps are not synced * Local installation parameters override sync parameters (app title) The following bug is uncovered by these tests: * Installing an app on two profiles, and then uninstalling on one, can lead to inconsistent results (not just the racy who-wins - one profile could end up with the app installed, while the other has it uninstalled, even after sync runs). https://crbug.com/1091867 Bug: 1025156 Change-Id: I9b22b84ade5dbe82b43127d30f9426923fc8b251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231283 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#777951}
-
Yoshifumi Inoue authored
This patch moves |EndPositionForLine()| template function before template parameter class to use |EndPositionForLine()| for preparation of [1]. [1] http://crrev.com/c/2139612 EditingNG All-In-One Bug: 707656 Change-Id: I19a95ad805d2ace4e0bc704a8d39c983d830392f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241068 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Robert Flack authored
This reverts commit 10be77c2. Reason for revert: blink_web_tests failing webaudio/Analyser/realtimeanalyser-fftsize-reset.html Example failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/51317 https://test-results.appspot.com/data/layout_results/Mac10_11_Tests/51317/blink_web_tests/layout-test-results/results.html Original change's description: > Use SIMD for the main loop for k-rate Oscillator > > The main processing loop for the k-rate Oscillator is updated to use > SSE2 instructions to speed up processing. > > Four tests fail because we have slightly reduced accuracy. Testing > shows that the loss of accuracy is due to using a float for > virtual_read_index in the loop instead of a double as previously. A > implementation using a double passes all the original tests but does > show that it does lose performance. I think the change in accuracy is > acceptable. > > WebAudio Bench results from a linux machine. In summary, the SIMD > version is about 60% as much time (about 1.75 times faster). > > Without CL: > TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV > Baseline 713 713 748 757 766 877 760.25 18.35 > Oscillator 949 949 972 990 1005 1132 990.78 24.35 > > With CL: > TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV > Baseline 728 728 747 756 763 908 757.46 16.81 > Oscillator 521 521 549 564 581 874 566.87 27.77 > > Bug: 1013118 > Change-Id: I2d1cb14f47db32e27d8baf79fb015885ba6b1eb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229639 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777865} TBR=dalecurtis@chromium.org,rtoy@chromium.org,hongchan@chromium.org Change-Id: I68e94bbf15de74332f0a0c0fa4f83aa5fbcb7f06 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243536Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#777949}
-
Josh Simmons authored
This is a bloom filter over fast hosts. Also updating PerformanceHintsObserver to check this type if no hint was found in link hints or page hints. Apologies for the large change count in the unittests. This is mostly due to rearranging tests and adding a using statement for ::testing:_. Bug: 1087123 Change-Id: Ie25145f28354a17955b16b87ebb6c36601b23ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238357 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777948}
-
John Abd-El-Malek authored
Move SubprocessMetricsProvider from chrome to components/metrics so that it can be shared with WebView and WebLayer. Renderer metrics are still not working, but this is a precursor. Keeping it separate so it's easy to review. Bug: 1090682 Change-Id: I3546c684f7b0eded7545e60422ba65b7f1b44898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242235Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#777947}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0e19d3f..197a756b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I262677196cc86408aaf67db5c1a0731da0f26786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240959Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777946}
-
Roger McFarlane authored
Change-Id: Idbefd3b8758806d8fd3f93b9ef142a589d210069 Bug: 1073600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228449 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#777945}
-
Miguel Casas authored
This CL flips the "enable-use-hdr-transfer-function" so that it's enabled by default. This only affects ChromeOS. It also affects the "standard" brightness of the screen in HDR-supporting models, making it dimmer so that the transition SDR-HDR is not noticeablee. It also takes the chance to tweak a bit said brightness. Test: kohaku and codepen.io/miguelao/full/PooMbbx Bug: 958166 Change-Id: I56f8f8f81b90ac58f139f7a54085ca11325ce0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241946 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#777944}
-
Robert Flack authored
This reverts commit fef917d3. Reason for revert: Suspect broke core.tbmv3.run_tbmv3_metric_unittest.RunTbmv3MetricIntegrationTests.testRunAllTbmv3Metrics on https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests Looks like it can't find the referenced file. Original change's description: > [tools/perf] Call a trace processor metric in webview_cpu_usage > > This change updates webview_cpu_usage_metric.sql to run a built-in trace > processor metric since most of the code was moved there. > No functional changes. > > Test: ran trace_processor_shell on a trace file > Bug: b/158665113 > Change-Id: I1a805db2dc2a84671e5967078203e80cac701bce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242208 > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777819} TBR=oksamyt@chromium.org,khokhlov@google.com Change-Id: I267c752dcc5213b4caf6279ea956adbce6a24b13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/158665113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243672Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia2427886dd72249dc7961677e91b3aa5e39229e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242867Reviewed-by:
-
Filip Gorski authored
In this fix we check for presence of mAutocompleteCoordinator when running a lambda handling focus change. We also need to prevent a case of double destroy, which happens in test. Alternative considered was to have a boolean: mIsDestroyed and check that where necessary. Choosing a more specific solution as that is more consistent with the other code we have. Bug: 1094242 Change-Id: Iba32f931e1ccec76357c551fddd72acddcd1d5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243258Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#777941}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 035eeea6. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" d2ee98f4 "Move manual offscreen wpt tests to own folder" 458dc853 "WPT: Migrate content-visibility tests to wpt." 84f61c81 "Exclude non relevants reports from the COOP-opener-breakage tests." e106756f "[COOP] Access reporting. Update the test." 4fc29945 "Split up canvas test yaml files" ce88cedc "[css-grid] Fix line name positions after implicit tracks" 14ce7141 "Counters/contain: Fix a case where the parent counter is created after child." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ic8c4ab25324fb7f138144a3930a116c256baf711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242893Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777940}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4576282f49d8..660b9dfbe395 2020-06-12 zhin@chromium.org [DevTools] Add acorn-logical-assignment 2020-06-12 zhin@chromium.org [third-party] Update acorn to 7.3.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1080569,chromium:1083214 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08f1c4ac270c4af57b917daadd3636dc75f1c373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243434Reviewed-by:
-
Tina Wang authored
- Refactor the class name to TableViewDetailTextWithInfoAccessoryItem/Cell - Add the cell to the catalog to make it discoverable in the future. Change-Id: I497d96c9c9fa37740c109dbb8295cd6902f55b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239886 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#777938}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591933637-56b5eca298ef15d7b9336759d0a45a4b34bcba1e.profdata to chrome-win64-master-1591977558-abdc4af0521917678b079bf82ef4430fa9fc4d9f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iffd750f374a4eea6ca84af2515515bd7d05e204e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243436Reviewed-by:
-
Chris Harrelson authored
Previously, perspective was applied via the containing block. In addition, LayoutObject ancestors that are anonymous should not count as a "DOM ancestor". This is exhibited in the two fixed WPT tests. Bug: 1008483 Change-Id: I3daa94e255bf6205f9cfb789d0426e24953f8427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236221Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#777936}
-
Tina Wang authored
Add a customized PopoverEnterpriseInfoViewController. - Adjusted PopoverLabelViewController and use it as a generic bubble view controller. - PopoverEnterpriseInfoViewController inherits PopoverLabelViewController and reformats the secondary label. - Added enterprise icon. - Added corresponding strings. Screenshot: https://screenshot.googleplex.com/iVO01su8CTs Bug: 1085202 Change-Id: Ia6f0b3e4a81a55835a9592dd5361ab3ac71a90a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229999Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Siyu An authored
Only local card can have nickname but no card number. So if a card has a valid nickname, show it in the suggestion dropdown. Bug: 1082013 Change-Id: I6439cce08ef2593a455312bcc1771662a315d1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233824Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#777934}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/796e7022eee8..407c9825da8a 2020-06-12 adlai@google.com Fix copyright 2020-06-12 herb@google.com make options robust 2020-06-12 djsollen@google.com Skottie example app to copy InputStreams in Java. 2020-06-12 adlai@google.com Cache last-accessed entry in lastRenderTask table. 2020-06-12 brianosman@google.com Move all SkReadBuffer member initialization to header 2020-06-12 fmalita@chromium.org [skjson] Use lower bits for tagging 2020-06-12 herb@google.com Make explicit SDF default values. 2020-06-12 kjlubick@google.com [canvaskit] Fix bug with TextStyle color 2020-06-12 bsalomon@google.com Make ColorTableEffect use child processor 2020-06-12 brianosman@google.com Initialize SkReadBuffer pointers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1093902 Tbr: bungeman@google.com Change-Id: I452ff51f51f57ef016e769f39bd777cf12c494fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243454Reviewed-by:
-
Tim Volodine authored
Ensure API checks (M84) and UI thread checks for setBooleanSetting() and getBooleanSetting() Profile methods. BUG=1083376 Change-Id: I6addddd65a8d9b4074e06274d9d4615455d5df87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242081Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#777932}
-
Stephen White authored
Bug:1094411 TBR=sgilhuly@chromium.org Change-Id: I592daa45de913c5fa9d925d98384c99fadcef527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243592 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Auto-Submit: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#777931}
-
Hesen Zhang authored
- Apply ignore_timeout_duration config for prefetch notification. - TODO: Add unit test for prefetch_notification_service. Bug: 1047037 Change-Id: I5402ddc48f2d1f00cf15988fa748f68101d2f71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238508Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#777930}
-
Henrique Ferreiro authored
WebString was using strlen without the proper includes. Apparently, this broke some external code. Change-Id: Ib01efa6bf3fe72e4f27e2f43641d0157dd457b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243133Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#777929}
-
