GitLab

BUG=663019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2513163002
Cr-Commit-Position: refs/heads/master@{#434778}

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019

Review-Url: https://codereview.chromium.org/2525933002
Cr-Commit-Position: refs/heads/master@{#434777}

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2529493002
Cr-Commit-Position: refs/heads/master@{#434776}

This should no longer be necessary now that the scrollbar animations are
no longer driven by NSAnimation (https://codereview.chromium.org/529103002/).

BUG=306348,533537
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2509273005
Cr-Commit-Position: refs/heads/master@{#434775}

BUG=none

Review-Url: https://codereview.chromium.org/2530893003
Cr-Commit-Position: refs/heads/master@{#434774}

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

The request handler for "/slow?" gets added to the server when
AddDefaultHandlers() is called[1], which already happens in
createAndStartServer(), so the additional call here isn't necessary.

[1] https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_test_server.cc?sq=package:chromium&dr=C&rcl=1480321223&l=295

BUG=546060

Review-Url: https://codereview.chromium.org/2524153002
Cr-Commit-Position: refs/heads/master@{#434773}

BUG=668384

Review-Url: https://codereview.chromium.org/2524293002
Cr-Commit-Position: refs/heads/master@{#434772}

There was an edge case here where we might get an arbitrary element as the
document.documentElement. In these cases, the element won't get a LayoutObject
as LayoutView will refuse to attach to it, but when we replace it a layout will
create a non-LayoutBox for it and when RootScroller tries to replace it as the
effective root scroller it needs to do some book keeping using the old root
scroller. It incorrectly assumed it must be a LayoutBox.

This patch now guards against this edge case.

BUG=668553

Review-Url: https://codereview.chromium.org/2531343002
Cr-Commit-Position: refs/heads/master@{#434771}

We have an experiment running that would disable parser-inserted usage
of 'chrome-extension://' URLs unless explicitly whitelisted. This breaks
the print preview page, which relies on the PDF extension URLs inside an
HTML import. So. This patch adds a mechanism for whitelisting that
extension URL for the print preview page.

BUG=667224
R=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2528903002
Cr-Commit-Position: refs/heads/master@{#434770}

 * Path building now can only complete synchronously
 * Access to trust store is done synchronously
 * The network dependencies (AIA fetching) will block the thread

BUG=649017

Review-Url: https://codereview.chromium.org/2453093004
Cr-Commit-Position: refs/heads/master@{#434769}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bced9de7..dade4fe3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2531373003
Cr-Commit-Position: refs/heads/master@{#434768}

BUG=664887

Review-Url: https://codereview.chromium.org/2533923002
Cr-Commit-Position: refs/heads/master@{#434767}

As requested by sgabriel@, this cl reduces the hover "glow" when mousing
over an incognito tab.

R=avi@chromium.org
BUG=632160

Review-Url: https://codereview.chromium.org/2506843002
Cr-Commit-Position: refs/heads/master@{#434766}

FileUtilProxy::DeleteFile() deletes a file on a TaskRunner and then
invokes a callback on the source thread. All call sites provide a null
callback. They might as well just post a base::DeleteFile() task to
the TaskRunner.

This is a prerequisite to stop allowing null callbacks in
base::PostTaskAndReplyWithResult().

BUG=162712

Review-Url: https://codereview.chromium.org/2528193002
Cr-Commit-Position: refs/heads/master@{#434765}

https://codereview.chromium.org/2491613004 failed TimerTest.OneShotTimer_CustomTaskRunner
with the old tests per lacking a TaskRunnerHandle instance. Fixing that
led to a bunch of cleanup. Decoupling from that CL to make it clear that the
new tests pass in the old world and that the new world then passes the tests
without tweaking them.

Mostly moving towards RunLoop/TaskRunners/WaitableEvents to ease a few things.

Also removed incorrect DCHECK in Timer::PostNewScheduledTask() which was tripped
by the new version of TimerTest.OneShotTimer_CustomTaskRunner

BUG=587199, 552633

Review-Url: https://codereview.chromium.org/2514293004
Cr-Commit-Position: refs/heads/master@{#434764}

Rename SyntheticPointer to SyntheticPointerDriver, SyntheticTouchPointer to
SyntheticTouchDriver, and SyntheticMousePointer to SyntheticMouseDriver,
because these classes do not represent the synthetic pointers. They actually create
synthetic pointers for each pointer types and their actions.

BUG=525187

Review-Url: https://codereview.chromium.org/2478423002
Cr-Commit-Position: refs/heads/master@{#434763}

This CL removes xdisplaycheck from xvfb.py.  Previously, we used
xdisplaycheck to block until Xvfb set up a display.  However, there's
a utility called xvfb-run that does this already, and it's included in
the xvfb package.

In future CLs, this will allow us to:
* Remove the /path/to/build_dir argument to xvfb.py since it was only
used determine the xdisplaycheck path.
* Remove xdisplaycheck from the tree

R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2526663002
Cr-Commit-Position: refs/heads/master@{#434762}

After we placed omnibox suggestion list as a child of
CompositorViewHolder, it no longer is able to scroll.

The investigation of this regression gave interesting result: if an
ACTION_MOVE is dispatched to a ListView or a ScrollView and the
ViewGroup intercepts it, the framework will generate an ACTION_CANCEL to
the ViewGroup's children. The behavior, however, will steal this cancel
event and send to the ViewGroup again, causing scroll to fail. Thus we
should specifically not catch ACTION_CANCEL in behavior.

BUG=648136

Review-Url: https://codereview.chromium.org/2526673004
Cr-Commit-Position: refs/heads/master@{#434761}

This patch wraps the process of getting requests in a simple task
in order to ensure that getting requests can be serialized with
other tasks to prevent race conditions.

BUG=651238

Review-Url: https://codereview.chromium.org/2517383008
Cr-Commit-Position: refs/heads/master@{#434760}

The goal is to reduce number of datatype controllers to simplify future
refactoring.

In this chagne:
- Removed UIDataTypeController
- All datatypes are switched to NonUIDataTypeController
- Removed model_safe_group method, in favor of DirectoryDataTypeController field
- Added backend_thread_ so that most of datatypes don't need to override
  PostTaskOnBackendThread

R=maxbogue@chromium.org
BUG=647505

TBR=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2511703004
Cr-Commit-Position: refs/heads/master@{#434759}

BUG=668001

Review-Url: https://codereview.chromium.org/2526713002
Cr-Commit-Position: refs/heads/master@{#434758}

The current module id length check excludes some third party modules
that are not as well behaved as expected. Remove it so we can transfer
profiles containing these modules.

BUG=659903

Review-Url: https://codereview.chromium.org/2532243002
Cr-Commit-Position: refs/heads/master@{#434757}

This function uses GURL::ReplaceComponents which triggers
canonicalization of the new URL. For the normal case where urls do not
have usernames, passwords, or ref parts, we can just return the original
URL.

ReplaceComponents takes around 13% of the time spent in
HttpCache::Transaction::Start with a SimpleCache backend on Linux, but
this method is used in a few different places.

BUG=664174

Review-Url: https://codereview.chromium.org/2498423004
Cr-Commit-Position: refs/heads/master@{#434756}

BUG=669076

Review-Url: https://codereview.chromium.org/2532193002
Cr-Commit-Position: refs/heads/master@{#434755}

Now DesktopEnvironmentOptions are passed to the desktop process in
StartSessionAgent IPC message. This will allow the network process
controll DesktopEnvironment configuration and particularly
DesktopCaptureOptions.

Review-Url: https://codereview.chromium.org/2529533003
Cr-Commit-Position: refs/heads/master@{#434754}

This patch is done on behalf of roisinmcl@chromium.org (original work in
https://codereview.chromium.org/2230053002/).

When a chromedrvier session is created with a flag for W3C compliance,
chromedriver will reference the element with a UUID in place of the
existing ID generation method.

Chromedriver wrapping/unwrapping functions have been changed to match
the new referencing when the W3C flag is true.

BUG=

Review-Url: https://codereview.chromium.org/2295443003
Cr-Commit-Position: refs/heads/master@{#434753}

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457

Review-Url: https://codereview.chromium.org/2533753003
Cr-Commit-Position: refs/heads/master@{#434752}

Small bug fix.

BUG=625382, 626752

Review-Url: https://codereview.chromium.org/2483573002
Cr-Commit-Position: refs/heads/master@{#434751}

BUG=542537

Review-Url: https://codereview.chromium.org/2528323002
Cr-Commit-Position: refs/heads/master@{#434750}

Remove useless class and struct forward declarations, and add
missing ones in extensions header files.

BUG=662195

Review-Url: https://codereview.chromium.org/2535713004
Cr-Commit-Position: refs/heads/master@{#434749}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6d2cfc95eb2f..1e916c1c87c8

$ git log 6d2cfc95e..1e916c1c8 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 charliea Enable arrow-body-style eslint rule
2016-11-28 perezju [dashboard] Disiable story filtering for octane benchmark
2016-11-28 simonhatch Dashboard - Bisect bot guessing code should return valid bot.

BUG=668165

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2533853002
Cr-Commit-Position: refs/heads/master@{#434748}

This cl restores the line break attribute as it was calculated in the past. Once we implement something based on the AX-tree that covers all bases, this can be safely removed.

TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2526073003
Cr-Commit-Position: refs/heads/master@{#434747}

BUG=angleproject:1492
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2533873002
Cr-Commit-Position: refs/heads/master@{#434746}

Linux Aura got support for translucent windows in CL:
https://chromium.googlesource.com/chromium/src.git/+/62ba78ffcdf525eb9ed640724e640fcf22fbbf87

Some Chrome widgets used a TRANSLUCENT_WINDOW opacity for widgets that fade in
or out, but that don't actually have an alpha mask.  This was to support a
limitation on MS Windows where windows must be translucent to fade.

However, most Linux window managers only draw shadows on opaque windows: that is,
windows that do not have an alpha channel.  Windows that fade in or out may still
have shadows since opacity is set as a property of the toplevel window.

Therefore, the solution is to use INFER_OPACITY for fading widgets so it will
work across platforms.  TRANSLUCENT_WINDOW should only be used on widgets that
have alpha masks.

BUG=640170

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2398203002
Cr-Commit-Position: refs/heads/master@{#434745}

This change implements the key C++ portion of the Select-to-speak feature
by adding an event handler that takes Search plus the mouse button, and
fires accessibility events instead.

In the future we could modify or extend this event handler for use in
ChromeVox too, but for now I think building something specifically for
Select-to-speak makes sense.

Adds new accessibility events for mouse down, mouse up, and so on - allowing
the select-to-speak extension to get not only the mouse events and global
coordinates, but most importantly the proper accessibility object that's hit
for each event.

This change implements support for hit testing in Views. For web,
the extension will get the event fired on the views::WebView and it can do
its own hit testing within the accessibility tree from there. A follow-up
will improve on this by doing native hit testing in the web before firing
the accessibility event.

BUG=593887

Review-Url: https://codereview.chromium.org/2493923002
Cr-Commit-Position: refs/heads/master@{#434744}

The problem was that |route_id| is scoped to a particular child process,
but the process was not being plumbed in correctly, resulting in a
situation where we would create (1) a RenderFrameHost with a routing ID
that might later be reused, and also, (2) a RenderFrameHost with a
plumbed-in routing ID, but no corresponding extant RenderFrame in the
child process.

The solution involves plumbing in the actual SiteInstance, and only
using |route_id| if we don't change to a different SiteInstance.

BUG=627852
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2521793003
Cr-Commit-Position: refs/heads/master@{#434743}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5e9339ae484..0ab5a1cdaf39

$ git log b5e9339ae..0ab5a1cda --date=short --no-merges --format='%ad %ae %s'
2016-11-28 chrome-bot Update config settings by config-updater.
2016-11-28 drinkcat parseelf: Add comment about getting number of symbols from DT_HASH
2016-11-16 sjg crosfw: Return an exit code when we get a build error
2016-11-25 drinkcat parseelf: Ignore empty symbol_name
2016-11-25 drinkcat parseelf: Parse number of symbols from DT_HASH section
2016-11-21 sadrul deploy_chrome: Remove special handling for mash
2016-11-23 ayatane [sysmon] Track the number of running sysmon processes
2016-11-23 chrome-bot Update config settings by config-updater.
2016-11-23 nxia Revert "Add buildbucket_id index in buildTable"

BUG=none

Review-Url: https://codereview.chromium.org/2536553004
Cr-Commit-Position: refs/heads/master@{#434742}

This is a follow up to https://codereview.chromium.org/2483003003/

It introduces a factory class to create and get a CertificateReportingService
singleton. It also introduces a metrics provider class that currently doesn't
do anything, but will send pending reports in follow up CLs.

BUG=554323

Review-Url: https://codereview.chromium.org/2507253004
Cr-Commit-Position: refs/heads/master@{#434741}

GpuMemoryBufferHandle::shared_memory_handle is only valid if type is
SHARED_MEMORY_BUFFER. So try to serialize only when it's valid.

BUG=643746

Review-Url: https://codereview.chromium.org/2534533002
Cr-Commit-Position: refs/heads/master@{#434740}

Passing -S to python breaks in a virtualenv because it cannot
find the stdlib modules (e.g. base64). Only pass -S if not
already in a virtualenv.

BUG=667897
TEST=net_unittests inside a virtualenv

Review-Url: https://codereview.chromium.org/2526553002
Cr-Commit-Position: refs/heads/master@{#434739}