- 14 Feb, 2014 40 commits
-
-
nkostylev@chromium.org authored
Add a custom user pod icon for such apps. Enable this UI by default. Provide --disable-new-kiosk-ui flag which reverts back to the original UI (menu). BUG=334304,341884 R=xiyuan@chromium.org TBR=oshima Review URL: https://codereview.chromium.org/158833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251315 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
The strings currently say Chrome apps will close. Actually they will close and then relaunch in the new desktop type. BUG=315239 Review URL: https://codereview.chromium.org/161083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251314 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
I'll look into if we can eliminate this. BUG=343696 Review URL: https://codereview.chromium.org/165273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251313 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=343616 Review URL: https://codereview.chromium.org/164403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251312 0039d316-1c4b-4281-b951-d872f2087c98
-
pmarch@chromium.org authored
call. The call takes an array of activity IDs (each activity ID is a string) and deletes the matching activities form the Activity Log database. BUG=330210 Review URL: https://codereview.chromium.org/154053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251311 0039d316-1c4b-4281-b951-d872f2087c98
-
hajimehoshi@chromium.org authored
Modifies the output to the following style: #LEAK renderer pid PID (DETAIL_IN_JSON_FORMAT) Now, this leaking output is not used anywhere, and this will be used by https://codereview.chromium.org/148153009/. See also: https://docs.google.com/a/chromium.org/document/d/1sFAsZxeISKnbGdXoLZlB2tDZ8pvO102ePFQx6TX4X14/edit BUG=332630 Review URL: https://codereview.chromium.org/142043010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251310 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
Revert of Fix (or tag) uses of explicit '64' instead of GL_MAILBOX_SIZE_CHROMIUM (https://codereview.chromium.org/138763009/) Reason for revert: FAILED: c++ -MMD -MF obj/cc/layers/cc_unittests.texture_layer_unittest.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1 -DUSE_XI2_MT=2 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGTEST_HAS_POSIX_RE=0 -DGL_GLEXT_PROTOTYPES -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../../cc/test -I../../cc -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -c ../../cc/layers/texture_layer_unittest.cc -o obj/cc/layers/cc_unittests.texture_layer_unittest.o In file included from ../../testing/gmock/include/gmock/gmock-spec-builders.h:71:0, from ../../testing/gmock/include/gmock/gmock-generated-function-mockers.h:43, from ../../testing/gmock/include/gmock/gmock.h:61, from ../../cc/layers/texture_layer_unittest.cc:33: ../../testing/gmock/include/gmock/gmock-matchers.h: In member function 'bool testing::internal::EqMatcher<Rhs>::Impl<Lhs>::MatchAndExplain(Lhs, testing::MatchResultListener*) const [with Lhs = const gpu::Mailbox&, Rhs = gpu::Mailbox]': ../../cc/layers/texture_layer_unittest.cc:2173:1: instantiated from here ../../testing/gmock/include/gmock/gmock-matchers.h:784:1: error: no match for 'operator==' in 'lhs == ((const testing::internal::EqMatcher<gpu::Mailbox>::Impl<const gpu::Mailbox&>*)this)->testing::internal::EqMatcher<gpu::Mailbox>::Impl<const gpu::Mailbox&>::rhs_' ../../testing/gmock/include/gmock/gmock-matchers.h:784:1: note: candidate is: ../../testing/gtest/include/gtest/internal/gtest-linked_ptr.h:213:6: note: template<class T> bool testing::internal::operator==(T*, const testing::internal::linked_ptr<T>&) ../../testing/gmock/include/gmock/gmock-matchers.h:784:1: error: control reaches end of non-void function [-Werror=return-type] Original issue's description: > Fix (or tag) uses of explicit '64' instead of GL_MAILBOX_SIZE_CHROMIUM > > That way we can easily change the size later. Security says 64 may be overkill. > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251306 TBR=danakj@chromium.org,piman@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/166853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251309 0039d316-1c4b-4281-b951-d872f2087c98
-
dfalcantara@chromium.org authored
There was nothing specific about this class, so I'm generalizing it and moving it upwards in the tree for more use cases (e.g. app banners). Code that will use it is not ready for review, but is located at https://chromiumcodereview.appspot.com/156343002/ BUG=341556 Review URL: https://codereview.chromium.org/155273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251308 0039d316-1c4b-4281-b951-d872f2087c98
-
siva.gunturi@samsung.com authored
BUG=323150 Review URL: https://codereview.chromium.org/151203005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251307 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
That way we can easily change the size later. Security says 64 may be overkill. BUG=None Review URL: https://codereview.chromium.org/138763009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251306 0039d316-1c4b-4281-b951-d872f2087c98
-
droger@chromium.org authored
TranslatePrefs now needs the path to preferences in its constructor. To help with this, a helper method is added to TranslateTabHelper to build TranslatePrefs instances. As a result, TranslatePrefs are no longer instantiated on the stack, but rather on the heap. BUG=335079 TBR=battre, jochen, joi Review URL: https://codereview.chromium.org/159883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251305 0039d316-1c4b-4281-b951-d872f2087c98
-
luoruiyi2008@gmail.com authored
In normal mode, the plugin is created at the moment the page is loaded. Then when the first time the plugin is clicked. It will set the flag "has_webkit_focus_" true in real plugin instance. Then, send out the focus change notification in PepperPluginInstanceImpl::SetWebKitFocus, which will finally affect the IME stuff. However, at "Click to play" mode, WebViewPlugin is created at first, which will be replaced by real plugin. When the first time we click, the real plugin is created, loaded. But no focus is set in real plugin, which cause the IME stuff can't be enabled. In solution, we transfer the |focused_| in WebViewPlugin to new plugin after it loaded. BUG=336740 Review URL: https://codereview.chromium.org/144803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251303 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelpg@chromium.org authored
Adds bubble buttons to indicate which settings are shared. When signed in as a secondary user (i.e., added to a multi-profile session), a banner should be display. The "Internet connection" header should show a shared icon. Owner-controlled settings should show the owner icon. "Require password to wake from sleep" is a special case. This also fixes a bug where controlled settings on managed devices should say they are controlled by policy, but instead say the (non-existent) owner controls them. For details, see PRD with additional links at bottom: https://docs.google.com/a/google.com/document/d/1G09Mql1TtVFA4qhb7hlt4u2crBv6_fhrZMf40Yo--lc BUG=326354 R=dbeam@chromium.org, stevenjb@chromium.org, oshima@chromium.org Review URL: https://codereview.chromium.org/152143009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251302 0039d316-1c4b-4281-b951-d872f2087c98
-
imcheng@chromium.org authored
This change brings this type of event in line with the rest - having separate types for audio / video. As a new type that is potentially sent over in RTCP is introduced, a new RTCP encoding for that type is added as well. This change is backwards-compatible because these events aren't being sent over in RTCP because they are not processed by ReceiverRtcpEventSubscriber. BUG=337901 Review URL: https://codereview.chromium.org/164253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251301 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
R=tapted BUG=343692 Review URL: https://codereview.chromium.org/164953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251300 0039d316-1c4b-4281-b951-d872f2087c98
-
jennyz@chromium.org authored
Remove the animation delay for showing the top level apps when user opens app list launcher. The animation will be performed only when user return to the top level apps grid view from a folder view. BUG=336187 Review URL: https://codereview.chromium.org/163953008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251299 0039d316-1c4b-4281-b951-d872f2087c98
-
dtu@chromium.org authored
Given a list of Python modules, it will find all: - bootstrap_deps folders, recursively. - Python dependencies. - Page sets in those modules' folders. - Serving dirs of those page sets. And print a list of all files, or zip them up. Example bot command: tools/telemetry_tools/find_dependencies -v tools/perf/run_benchmark tools/perf/run_measurement tools/perf/record_wpr content/test/gpu/run_gpu_test -z telemetry.zip BUG=311380 TEST=Ran it. Review URL: https://codereview.chromium.org/103433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251298 0039d316-1c4b-4281-b951-d872f2087c98
-
scr@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/134163014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251297 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251296 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
BUG=309077 TEST=None Review URL: https://codereview.chromium.org/157973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251295 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
R=rmistry@google.com Review URL: https://codereview.chromium.org/164253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251294 0039d316-1c4b-4281-b951-d872f2087c98
-
mohsen@chromium.org authored
gesture.config_is_trustworthy pref is a temporary flag added in M30 to do a one-time wipe of gesture config prefs. After two milestones, the prefs should have been wiped for a good majority of users. So, the flag is not needed anymore. BUG=269292 Review URL: https://codereview.chromium.org/162193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251293 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
CloudPolicyValidator now accpets a "domain" parameter which is used to generate verification signatures for public keys. Broke out CloudPolicyValidator cached-key verification code into a separate validation function: ValidateCachedKey(). Added new hard-coded signatures for our PolicyBuilder test keys for the example.com domain. BUG=275291 TBR=rogerta@chromium.org Review URL: https://codereview.chromium.org/143183007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251292 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
The last mouse location should be the updated only by real event because it should point to the real mouse point and synthesized enter/leave may not contain the valid point. minor: remove unnecessary cast. BUG=None TEST=TBD. Review URL: https://codereview.chromium.org/143303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251291 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
This patch fixes the exception in clicking a thumbnail. It is a regression caused by r249027 and a possible cause of crbug.com/340624. The 'length' property of the selection model is NOT the number of the selected item. To get it, we need to get the length of 'selectedIndex' property. BUG=340624 TEST=manually Review URL: https://codereview.chromium.org/135973012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251290 0039d316-1c4b-4281-b951-d872f2087c98
-
guangzhen.li@intel.com authored
The app will be crashed when using vibrate API, without VIBRATE permission specified. Catch the security exception instead of crash should be more friendly. BUG=338151 TEST= Review URL: https://codereview.chromium.org/143673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251289 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=341586 Review URL: https://codereview.chromium.org/157093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251288 0039d316-1c4b-4281-b951-d872f2087c98
-
hyunki.baik@samsung.com authored
added log messages when LoadLibrary fails for GLES/EGL libraries. BUG=none Review URL: https://codereview.chromium.org/160403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251287 0039d316-1c4b-4281-b951-d872f2087c98
-
tengs@chromium.org authored
BUG=335449 Review URL: https://codereview.chromium.org/138833012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251286 0039d316-1c4b-4281-b951-d872f2087c98
-
sheu@chromium.org authored
Flakiness should be fixed. Renabling tests. BUG=335916,341265 TEST=trybots Review URL: https://codereview.chromium.org/145093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251285 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
Fix most users of ExtensionSystemFactory::GetInstance() to use ExtensionsBrowserClient::Get()->GetExtensionSystemFactory(). Clean up extension_system_factory.h includes. Follows https://codereview.chromium.org/137753016/ BUG=337707 Review URL: https://codereview.chromium.org/148083014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251284 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
Speculative revert to determine whether it is causing the below WebViewTest.AutoSizeSW failure on the Linux Test bots (e.g., http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/30888/steps/browser_tests/logs/AutoSizeSW): FATAL:texture_layer.cc(141)] Check failed: !mailbox.IsValid() || !holder_ref_ || !mailbox.Equals(holder_ref_->holder()->mailbox()). This failure also appeared on the trybot run for this CL. > Use gpu::Mailbox instead of std:string in IPCs > > - easier to read > - safer since gpu::Mailbox is constant size and checked in the ParamTraits > > BUG=None > > Review URL: https://codereview.chromium.org/148003006 TBR=piman@chromium.org Review URL: https://codereview.chromium.org/163433008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251281 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
Revert of Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163173003/) Reason for revert: The original CL (https://src.chromium.org/viewvc/chrome?view=rev&revision=251213 ) was reverted (and reverted twice more) because VMtest on chromeos-{x86,amd64} failed to find icudtl.dat. It turned out that my Chrome OS side change (chromeos-chrome.ebuild) was not picked up by build bots until several hours after landing of that CL. It's now picked up [1] and VMtest (on chromeos_x86 bot) finally passed with the original CL still in. So, I'm re-landing the original CL by reverting. [1] See LGKMSync section at http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/19858 Original issue's description: > Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/164333003/) > > Reason for revert: > CrOS-side change (chromeos-chrome.ebuild) may not be used by a buildbot. > > ./1_autotest_tests/results-27-experimental_login_OwnershipNotRetaken/login_OwnershipNotRetaken/sysinfo/var/log/ui/ui.LATEST still has > > [0214/002103:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU() > > Original issue's description: > > Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/) > > > > Reason for revert: > > https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. > > > > Original issue's description: > > > Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/) > > > > > > Reason for revert: > > > https://chromium-review.googlesource.com/#/c/185937/ has to go in first. > > > > > > > > > Original issue's description: > > > > Turn on icu_use_data_file_flag on CrOS > > > > > > > > See also https://chromium-review.googlesource.com/#/c/185937/ > > > > > > > > The switch has to be turned on in two places (chromeos-chrome.ebuild and > > > > build/common.gypi). One or the other can get landed separately, though. > > > > > > > > BUG=72633 > > > > TEST=net_unittests:*IDN* and base_unittests:*String* > > > > TBR=mark > > > > > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213 > > > > > > TBR=mark@chromium.org > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=72633 > > > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214 > > > > TBR=mark@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=72633 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251220 > > TBR=mark@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=72633 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251276 TBR=mark@chromium.org NOTREECHECKS=true NOTRY=true BUG=72633 Review URL: https://codereview.chromium.org/166513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251279 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@google.com authored
During the teardown process, media pipeline will be waiting on the render main thread. If a Decryptor depends on the render main thread (e.g. PpapiDecryptor), the pending DecryptCB will not be satisfied. This CL adds a DecryptingDemuxerStream::Stop() method so that the stopping process doesn't wait for any pending operation. BUG=343748 TEST=Add unittests to cover this case. R=ddorwin@chromium.org Review URL: https://codereview.chromium.org/165733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251277 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/164333003/) Reason for revert: CrOS-side change (chromeos-chrome.ebuild) may not be used by a buildbot. ./1_autotest_tests/results-27-experimental_login_OwnershipNotRetaken/login_OwnershipNotRetaken/sysinfo/var/log/ui/ui.LATEST still has [0214/002103:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU() Original issue's description: > Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/) > > Reason for revert: > https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. > > Original issue's description: > > Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/) > > > > Reason for revert: > > https://chromium-review.googlesource.com/#/c/185937/ has to go in first. > > > > > > Original issue's description: > > > Turn on icu_use_data_file_flag on CrOS > > > > > > See also https://chromium-review.googlesource.com/#/c/185937/ > > > > > > The switch has to be turned on in two places (chromeos-chrome.ebuild and > > > build/common.gypi). One or the other can get landed separately, though. > > > > > > BUG=72633 > > > TEST=net_unittests:*IDN* and base_unittests:*String* > > > TBR=mark > > > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213 > > > > TBR=mark@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=72633 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214 > > TBR=mark@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=72633 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251220 TBR=mark@chromium.org NOTREECHECKS=true NOTRY=true BUG=72633 Review URL: https://codereview.chromium.org/163173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251276 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
TBR=jln Review URL: https://codereview.chromium.org/166303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251273 0039d316-1c4b-4281-b951-d872f2087c98
-
jln@chromium.org authored
The setuid sandbox waits on its one child and then dies afterwards. When receiving SIGABRT, instead of dumping core, simply exit the process. There is no interesting information to be gathered from knowing that the process is inside waitid(2), one should look at the child process instead. This patch is in hope to reduce red herrings. BUG=334345 TBR=jorgelo@chromium.org Review URL: https://codereview.chromium.org/166193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251271 0039d316-1c4b-4281-b951-d872f2087c98
-
Hokein.Wu@gmail.com authored
BUG=None TEST=compiled Review URL: https://codereview.chromium.org/133503012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251270 0039d316-1c4b-4281-b951-d872f2087c98
-
jln@chromium.org authored
> Setuid sandbox: exit(2) on SIGABRT > > The setuid sandbox waits on its one child and then dies > afterwards. > > When receiving SIGABRT, instead of dumping core, simply exit the > process. There is no interesting information to be gathered from > knowing that the process is inside waitid(2), one should look at > the child process instead. > > This patch hopes to reduce red herrings. > > BUG=334345 > NOTRY=true > R=jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/165673002 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/164373005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251269 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
Review URL: https://codereview.chromium.org/163013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251268 0039d316-1c4b-4281-b951-d872f2087c98
-