GitLab

Default favicon now has the same color as the close button. This CL
also makes sure that the favicon's color gets updated when the theme
changes. CloseButtonColor has been refactored.

BUG=621015, 625821

Review-Url: https://codereview.chromium.org/2126043002
Cr-Commit-Position: refs/heads/master@{#405612}

We currently assume that the occlusion calculated for contributing
surface (the second last element of the stack in occlusion tracker) is
always the occlusion by its target. This is not true.

BUG=501135
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2147283002
Cr-Commit-Position: refs/heads/master@{#405611}

This issue was caused during a recent refactoring.  This CL adds the
initialization code for Trackpad mode back.

BUG=628034

Review-Url: https://codereview.chromium.org/2146303002
Cr-Commit-Position: refs/heads/master@{#405610}

DCHECK can be tripped when there is a chain of openers or when the
opener has been cleared. The subsequent comparison against file:
fails, and we may make a browser navigation where one could have
been avoided, but it is still correct.

Since it is still correct, we can simplify the check, perhaps
forking in more cases that we used to, but that doesn't matter.

BUG=622509
R=creis@chromium.org

Review-Url: https://codereview.chromium.org/2153573002
Cr-Commit-Position: refs/heads/master@{#405609}

Out-of-flow items should not be frozen. This would have problematic
effects when they have flex-grow/flex-shrink set because freezing
them would subtract them from our flex-grow/shrink total without
having been added.

This also adds some DCHECKs.

R=eae@chromium.org,dgrogan@chromium.org
BUG=628072

Review-Url: https://codereview.chromium.org/2146603007
Cr-Commit-Position: refs/heads/master@{#405608}

* Adds hooks in DownloadManagerService for calling GetAllDownloads()
  and sending the information back to Java.  This creates a
  List of DownloadItems that contain the basic information needed
  for the UI.

* Adds a basic RecyclerView to display the files in the user's
  download history.

* Adds a DownloadHistoryAdapter that is used to track information
  about the download history.  This *should* be reusable among
  multiple RecyclerViews in case the user opens up multi-window
  mode.

- This currently doesn't monitor any changes to the history and is
  used solely for getting a skeleton working.

BUG=616324

Review-Url: https://codereview.chromium.org/2143303002
Cr-Commit-Position: refs/heads/master@{#405607}

kOzoneTestSingleOverlaySupport was originally added to test a single
overlay plane when using Ozone.

The code evolved and now passing that parameter enable overlays (not
only a single overlay).

This CL removes the command line flag and uses kEnableHardwareOverlays
instead to enable overlays on Ozone.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2122303003
Cr-Commit-Position: refs/heads/master@{#405606}

follow-on to https://codereview.chromium.org/2126973004

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API. (See linked crbug for details.)
No new layout API methods were required in this CL.

There are no functional changes.

BUG=499321

Review-Url: https://codereview.chromium.org/2151883004
Cr-Commit-Position: refs/heads/master@{#405605}

- Add a placeholder for CUPS printers subpage
- Move the google cloud printing page to the Cloud Printers subpage.

See the mock: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/flow#%2F101_Printing.png%3Fz=width

BUG=626752, 625364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2110653003
Cr-Commit-Position: refs/heads/master@{#405604}

The close (X) button now sets the kDefaultBrowserLastDeclined pref.

BUG=627615

Review-Url: https://codereview.chromium.org/2148523002
Cr-Commit-Position: refs/heads/master@{#405603}

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against that library.
This CL fixes the shared library build with GYP.

TBR=erg

Review-Url: https://codereview.chromium.org/2146363002
Cr-Commit-Position: refs/heads/master@{#405602}

No longer try to set overlay message and no longer send
"Inspecotr.enable" message to the targets of JS inspector type.

BUG=624494

Review-Url: https://codereview.chromium.org/2122113004
Cr-Commit-Position: refs/heads/master@{#405601}

This command-line switch was added for testing on an experimental
'backlog' heuristic for measuring encoder utilization in:
https://codereview.chromium.org/2108373002/

From lab testing, the new heuristic works better and more stable than
original deadline heuristic. This CL removes the command-line switch
and makes the new heuristic default.

BUG=chrome-os-partner:55236,chrome-os-partner:54806

Review-Url: https://codereview.chromium.org/2149843002
Cr-Commit-Position: refs/heads/master@{#405600}

Patch generation and various utilities (disasm) now use memory mapped file
instead of copying into a string buffer. This saves the equivalent of the size of
both |old_file| and |new_file| in memory when generating the patch
(~300Mb with chrome.7z).

BUG=

Review-Url: https://codereview.chromium.org/2143973004
Cr-Commit-Position: refs/heads/master@{#405599}

BUG=612802

Review-Url: https://codereview.chromium.org/2151023004
Cr-Commit-Position: refs/heads/master@{#405598}

(1) Remove redundant checks for bundled vs. component-updated Flash:
    This distinction is handled at registration time by the DCI.
(2) Update PathService after calling register. These two events are
    already racy, and it's more convenient to have the registration
    finished by the time the component updater notifies that the
    component has been updated.
(3) No need to explicitly pick up the bundled version of Flash for non-
    Linux: the component updater will manage registration of bundled
    Flash the same way it does component-updated Flash.

BUG=624067
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1

Committed: https://crrev.com/ae2a704ab712680c8b53a86e77eba78d0e591106
Review-Url: https://codereview.chromium.org/2130803003
Cr-Original-Commit-Position: refs/heads/master@{#405148}
Cr-Commit-Position: refs/heads/master@{#405597}

BUG=621542

Review-Url: https://codereview.chromium.org/2145103003
Cr-Commit-Position: refs/heads/master@{#405596}

This CL fixed crash cause by css:
```
    cursor:url('?'),auto;
    display:list-item;
```

|LayoutObject::imageChanged()| can be shared by multiple image listeners, it could be invoked by other listeners (from base class) before we add our own listeners.

We should make sure the object is ready and the image is the expected image.

Example Crash Log:
#0 0x7f0b7e03def7 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f0b7aa78330 <unknown>
#2 0x7f0b7d98ae36 blink::LayoutListMarker::imageChanged()
#3 0x7f0b7d73002c blink::ImageResource::notifyObservers()
#4 0x7f0b7d72fb9e blink::ImageResource::updateImage()
#5 0x7f0b7d730240 blink::ImageResource::finish()
#6 0x7f0b7d74335c blink::ResourceFetcher::didFinishLoading()
#7 0x7f0b7d0426f1 content::WebURLLoaderImpl::Context::OnCompletedRequest()
#8 0x7f0b7d029de5 content::ResourceDispatcher::OnRequestComplete()
#9 0x7f0b7d02b395 _ZN3IPC8MessageTI32ResourceMsg_RequestComplete_MetaSt5tupleIJiN7content31ResourceRequestCompletionStatusEEEvE8DispatchINS3_18ResourceDispatcherES8_vMS8_FviRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#10 0x7f0b7d0283e2 content::ResourceDispatcher::DispatchMessage()
#11 0x7f0b7d027cdb content::ResourceDispatcher::OnMessageReceived()
#12 0x7f0b7bba92e9 _ZN4base8internal7InvokerINS0_9BindStateIPFvSt10unique_ptrIN6syncer22AttachmentStoreBackendESt14default_deleteIS5_EEEJNS0_13PassedWrapperIS8_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#13 0x7f0b7e0afdd6 base::debug::TaskAnnotator::RunTask()

BUG=627811

Review-Url: https://codereview.chromium.org/2152853003
Cr-Commit-Position: refs/heads/master@{#405595}

These will be necessary to get the StatusAreaWidget to display in mojo:ash.

* Fork ash::sysui::ShellDelegateMus into //ash/mus
* Convert WmShell constructors to take ShellDelegate via unique_ptr
* Use ash::KeyboardUI for now, rather than KeyboardUIMus
* Move GPUSupport and PointerWatcherDelegate to //ash/common
* Fix some IWYU

No functional changes for regular non-mash chrome.

BUG=619636
TEST=ash_unittests, run chrome --mash manually and no crashes

Review-Url: https://codereview.chromium.org/2150023002
Cr-Commit-Position: refs/heads/master@{#405594}

Converts some source sets that were source sets into static libraries. Converts additional targets in the touched files to static libraries where it seemed relevant.

A few redundant dependencies were removed (one shouldn't need to specify both "foo" and "foo:test_support"). A few empty source sets were converted to groups.

BUG=627637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2151013002
Cr-Commit-Position: refs/heads/master@{#405593}

- remove callUID from CPUProfileNode in js_protocol;
- replace some used object with Map/Set;
- better types for closure compiler.

R=alph@chromium.org, dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2144153002
Cr-Commit-Position: refs/heads/master@{#405592}

BUG=628035

Review-Url: https://codereview.chromium.org/2149863002
Cr-Commit-Position: refs/heads/master@{#405591}

- Loads device info including OS, platform, browser version info, locale
  and firmware.

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS

Review-Url: https://codereview.chromium.org/2153553002
Cr-Commit-Position: refs/heads/master@{#405590}

Modal window could have non-modal transient descendants. Those window
should also receive events.

BUG=626147
TEST=SystemModalContainerLayoutManagerTest.ModalTransientChildEvents

Review-Url: https://codereview.chromium.org/2151973002
Cr-Commit-Position: refs/heads/master@{#405589}

https://chromium.googlesource.com/skia.git/+log/64bbad360f30..4c7e117b696b

$ git log 64bbad360..4c7e117b6 --date=short --no-merges --format='%ad %ae %s'
2016-07-14 robertphillips Remove dead flag from SkPictureRecorder

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2154473002
Cr-Commit-Position: refs/heads/master@{#405588}

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API. No new API methods were required.

There are no functional changes.

BUG=499321

Review-Url: https://codereview.chromium.org/2143973005
Cr-Commit-Position: refs/heads/master@{#405587}

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API. No new API methods were required.

There are no functional changes.

BUG=499321

Review-Url: https://codereview.chromium.org/2146313003
Cr-Commit-Position: refs/heads/master@{#405586}

This CL disables the unified media pipeline for Vivante GC1000
GPUs on KitKat and earlier.  It crashes quite a bit.

BUG=626814
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2149013002
Cr-Commit-Position: refs/heads/master@{#405585}

There was some confusion about this, and one would also expect that
these build-in variables would be listed in the help under the other
built-in variables.

BUG=468991

Review-Url: https://codereview.chromium.org/2149213002
Cr-Commit-Position: refs/heads/master@{#405584}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2151643003
Cr-Commit-Position: refs/heads/master@{#405583}

BUG=627306

Review-Url: https://codereview.chromium.org/2146233002
Cr-Commit-Position: refs/heads/master@{#405582}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/627023176cd4..4d408bfe9dec

$ git log 627023176..4d408bfe9 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2152933002
Cr-Commit-Position: refs/heads/master@{#405581}

https://chromium.googlesource.com/angle/angle.git/+log/8495498..4c32feb

BUG=

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2153473002
Cr-Commit-Position: refs/heads/master@{#405580}

In later patch of https://codereview.chromium.org/2079843003/, I update the code to display AudioDevice display_name. But I forget to update the unittest. Since try server is not running in USE_CRAS, it is not detected.

BUG=628342
TEST=run in USE_CRAS building condition, it returns to work fine.

Review-Url: https://codereview.chromium.org/2150983003
Cr-Commit-Position: refs/heads/master@{#405579}

This CL restricts access to the WebApkSandboxedProcessService
IChildProcessService implementation to the host browser only. The host browser
is defined in the WebAPK's manifest. A RemoteException is thrown if an app other
than the host browser attempts to use WebApkSandboxedProcessService's IBinder
interface

BUG=625448

Review-Url: https://codereview.chromium.org/2114293003
Cr-Commit-Position: refs/heads/master@{#405578}

PathService::Get() is treated as safe-to-call from any thread, but
PathProviderMac(FILE_EXE,...) looks up the NSExecutable path, and
translates it from relative to absolute using
base::MakeAbsoluteFilePath(), which asserts that IO is allowed on the
calling thread.

This was being hit by code in NaClBrowser in developers' local debug
builds.

As per the discussion on crbug.com/259796, the one-off cost of this
IO (given PathService then caches the result) seems acceptable.

NOPRESUBMIT=true
BUG=373477, 259796

Review-Url: https://codereview.chromium.org/2145003004
Cr-Commit-Position: refs/heads/master@{#405577}

I haven't really confirmed that this solves the problem because I wasn't able to reproduce it again :-/

Note, there's a related change http://crrev.com/2143123004 which would make it so that the real os.environ isn't used in tests.

BUG=612730

Review-Url: https://codereview.chromium.org/2141093006
Cr-Commit-Position: refs/heads/master@{#405576}

This is part of the touch hud app for mustash (https://codereview.chromium.org/2092343002/).

BUG=588311
TEST=ash_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win8_chromium_gyp_dbg;master.tryserver.chromium.win:win8_chromium_gyp_rel

Committed: https://crrev.com/98caac0fdcd637a95eb27e72c9a4c0a487e72d25
Committed: https://crrev.com/fd4123fd2d8efaa85d0b2f1550ca6e70ddc7cb55
Review-Url: https://codereview.chromium.org/2118223004
Cr-Original-Original-Commit-Position: refs/heads/master@{#405296}
Cr-Original-Commit-Position: refs/heads/master@{#405506}
Cr-Commit-Position: refs/heads/master@{#405575}

  In order to roll GN 547610b2..af92718f (r405294:r405547) and pick up
  the following changes:

  af92718f GN: Use the correct defaults for templates invoked via target().
  af8a964b Allow multiple set_default calls in GN.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2149073003
Cr-Commit-Position: refs/heads/master@{#405574}

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API. No new API methods were required.

There are no functional changes.

BUG=499321

Review-Url: https://codereview.chromium.org/2124013002
Cr-Commit-Position: refs/heads/master@{#405573}