- 22 Mar, 2019 40 commits
-
-
David Tseng authored
Regressing change https://chromium-review.googlesource.com/c/chromium/src/+/1477455 - the msg id's get used in various other places (e.g. panel.js, command_store.js); changing them requires changing all uses of them - the above change overwrote https://chromium-review.googlesource.com/c/chromium/src/+/1512256 Test: make sure the ChromeVox Panel works. Change-Id: I8074c000751ff6ab1e600615e68ca31a6686049e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535002Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#643428}
-
Changwan Ryu authored
Bug: 944476 Change-Id: Icbf128c2577d767eddc0b4008bae4b3b2ff8759a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534273 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Changwan Ryu <changwan@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#643427}
-
Joe Mason authored
R=csharp Bug: 830892 Change-Id: I1699c9de2076741781071051f6a24ff54aaf94e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526562 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#643426}
-
Tom Sepez authored
Change-Id: I518b842d63af413684e3af3e203335a9726357ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535194Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#643425}
-
John Rummell authored
The security level used for provisioning cannot be set and is cached from when a need for provisioning is last detected. If it is not cached, it uses the default security level. Updating the code to open a session first, which should report that provisioning is needed (and have the correct level set). BUG=943226 TEST=tried on a Pixel 2 Change-Id: I9cb87e86f340c5558f2d5739a421621173df9cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535183Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#643424}
-
Darwin Huang authored
No logic changes, just fixing a misspelling. Change-Id: Idaba70fe850dee5036c7a0acad76e325eebbc917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533303 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#643423}
-
Matt Menke authored
This was never supported, but we don't have any code that actually prevents us from trying to support it. We could theoretically support wss over QUIC tunnels pretty easily, but that wasn't hooked up correctly, either, so just don't even try, for now. Bug: 944861 Change-Id: Ic337374ca7ac028a78a3c7ef24baeb63431bbd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535751 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#643422}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I69c2e3a0d9144d6f01ab534380995191ea145132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536160Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#643421}
-
Devlin Cronin authored
Custom bindings in JS files used to require guards around bindingUtil, since it was only set if native extension bindings were used. Now that native extension bindings are the only form of bindings, we can remove the guards and JS versions of the same invocations. Bug: 938998 Change-Id: I318f969eb7cd590785dfd8ced49c7c3d44c48aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535749Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#643420}
-
Mei Liang authored
Bug: NONE Change-Id: I2d0f237630ca617536f308ac080ff31f2b5c4d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535174Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#643419}
-
Orin Jaworski authored
This CL reverts commit 7e78ad7d , called "Revert "[omnibox] Load Pedal concept matching data from JSON resource"" It also disables the unit test that caused initial revert. The test was passing, but taking too long because of the inefficient re2-based implementation of EraseWords. That code was experimental, behind a flag, and is already replaced with a technique that executes orders of magnitude faster. So the test will be re-enabled very soon. Bug: 893183, 944377 Change-Id: I3e313246b2d15f4c5ab4fa3725695f2707317607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534193Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#643418}
-
Matt Menke authored
Replace it with an is_quic boolean, and extract the version from the list of supported quic versions. This used to be done by HttpStreamFactory::Job for QUIC proxies, but it can just as easily be done at a lower layer. Bug: 921369 Change-Id: Ie28ae85754b5104da89fdd817c78aa54e5e49d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534892 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit c90084e3. Reason for revert: The following interactive_ui_tests broke on Windows NativeWindowOcclusionTrackerTest.OcclusionAfterVisibilityToggle NativeWindowOcclusionTrackerTest.OffscreenOcclusion NativeWindowOcclusionTrackerTest.SimpleOcclusion https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/50710 Original change's description: > Support windows virtual desktops in occlusion calculation. > > If a browser window is not on the current virtual desktop, it is marked occluded. > If a window is not on the current virtual desktop, we ignore it when deciding if > a browser window is occluded or not. > > This unfortunately spams the VS output window - newer versions of Windows have fixed this. > > Bug: 943534 > Change-Id: Iee9654f494fb2f977688c93347f4171447fb4b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531460 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643347} TBR=sky@chromium.org,fdoray@chromium.org,davidbienvenu@chromium.org Change-Id: Ia7a00ff66d541b0ddc81603e0327a6412bf1f562 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535272Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#643416}
-
Jeffrey Kardatzke authored
This was never implemented, so this is just cleaning up dead code. Also added self to OWNERS files. Bug: 756716 Test: Feedback tool still works Change-Id: I9550a4802465fe6ddac44949ec83b829393fd2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532910Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#643415}
-
Alexei Svitkine authored
We see 26-27 being reported from the wild, so bump DCHECK to 35 and hard limit to 50. Bug: 944576 Change-Id: I7c52a3f3f71f7d83de7c2dc476ed9b488b35718a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535861Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#643414}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b42165eeab9c..0d617ccc1c0a git log b42165eeab9c..0d617ccc1c0a --date=short --no-merges --format='%ad %ae %s' 2019-03-22 srte@webrtc.org Adds simulated time controller 2019-03-22 nisse@webrtc.org Delete unused method VCMReceiveStatisticsCallback::OnReceiveRatesUpdated 2019-03-22 nisse@webrtc.org Delete unused enum StreamType and kViEStreamType* values. 2019-03-22 ilnik@webrtc.org Fix obsolete settings in VideoEngine for VP9 screenshare 2019-03-22 brandtr@webrtc.org Save encoded ivf files separately for different TLs. 2019-03-22 nisse@webrtc.org Make VideoFrameType an enum class, and move to separate file and target 2019-03-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c03b7c57..16175758 (643221:643321) 2019-03-22 kthelgason@webrtc.org Add interface class for bitstream parser. 2019-03-22 phensman@webrtc.org Decouple input and output sample rate overrides. 2019-03-22 jakobi@webrtc.org Add group_ids to RTCStatsMemberInterface. Created with: gclient setdep -r src/third_party/webrtc@0d617ccc1c0a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:943076 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a42e6e2083993c50888a5d9333a77bfb284bae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535972Reviewed-by:
-
Sergio Villar Senin authored
This is a follow up of crrev.com/c/1497005 which marked all the WPT entries in SlowTests as slow but using the WPT machinery, i.e., by adding <meta name=timeout content=long> to the actual tests. We can remove them all from the SlowTests file as there is no need to keep them listed in there too. Bug: 24182, 451577, 492664, 592183, 626703, 676572, 736056, 757292, 765026, 779956, 787971, 798572, 800359, 816026, 817091, 810963, 825170, 833215, 840792, 842995, 874695, 875195, 888225, 925600, 927183, 933550 Change-Id: I454d4f436565c8f254446999a3344908a9b58176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498537 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#643412}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3e8a8d5b8567..896e7811184e git log 3e8a8d5b8567..896e7811184e --date=short --no-merges --format='%ad %ae %s' 2019-03-22 jmadill@chromium.org Revert "Vulkan:Optimize SecondaryCommandBuffers" 2019-03-21 jonahr@google.com Prevent vk shader generator from using anything but ANGLE's out. 2019-03-21 tobine@google.com Vulkan:Optimize SecondaryCommandBuffers Created with: gclient setdep -r src/third_party/angle@896e7811184e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I3ea8185932985ba1f374c2f17ef39136a74666d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535420Reviewed-by:
-
Carlos IL authored
Added bindings so user commands in SB interstitials work with committed interstitials enabled. Also adapted tests so they pass with CI enabled. Bug: 910794, 940555, 940567 Change-Id: I85c9133ff9f194070b68fc94a8954bcbae71b62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1371068Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#643410}
-
Mugdha Lakhani authored
tests. Some notification tests are still setting the ExperimentalWebPlatformFeatures flag when the features they're testing are no longer experimental. Change-Id: Ia7f0d636d3231c7b9aece5e3ea3c667c809c1d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534168 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#643409}
-
Chase Phillips authored
This reverts commit 0f7feedd. Reason for revert: Perhaps this causes a failure in bots. Reverting just in case it's the cause. Original change's description: > Fix storage partition class name > > This CL fixes a typo in the StoragePartitionInterceptor class name. > > Change-Id: I2fd58f16ded7d4587a6b5c942ad474922f923626 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1387684 > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642739} TBR=cmp@chromium.org,nasko@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idb33259a5e16ad4593a9272dc03f8daed0ad13cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536137Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#643408}
-
Akihiro Ota authored
This change also adds two tests to exercise the GetUnignoredChildCount and GetUnignoredChildAtIndex functions. Change-Id: I9cd5e7367356968de0ccebcdceb4068e7f904caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534188Reviewed-by:
-
Chase Phillips authored
This CL creates a bare IDBTransaction interface with just the CreateObjectStore method. Later CLs will be responsible for moving the remaining methods from IDBDatabase to IDBTransaction. Bug: 717812 Change-Id: Ie1e084957e66f2afef563d37af9243726e48855b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526172Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#643406}
-
Takumi Fujimoto authored
This CL enables anchoring the Cast dialog to gfx::Rect, so that a window without a Browser object (e.g. CrOS video player) can show the dialog anchored to it. Bug: 930606 Change-Id: I107e27565970d2e7df68395b982ba1f9ff66b868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519469 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#643405}
-
Dan Harrington authored
We were kicking off MetricsFinalizationTask from the background task, and when URLs are added to the pipeline. This CL avoids running this task from the background. The motivation is that we suspect metrics are being dropped when reported in the background. When this change goes live, we expect to see an uptick in reports. This change is safe because the metrics task has no end-user effect, and users reliably get URLs added to the pipeline. If URLs are no longer added, then there's no need to run this task anyway. Bug: 944615 Change-Id: I8a5239933945d0fe75941d9c8d905749be96903f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534361 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#643404}
-
Thomas Anderson authored
This reverts commit 82efddec. Reason for revert: Latest run of angle_unittests on Win10 FYI Debug (NVIDIA) is green: https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20Debug%20%28NVIDIA%29/3076 Original change's description: > Disable TextureFunctionTest.NonConstantOffset on win gpu fyi bots for a bit. > > Bug: 943140 > Change-Id: I0ba9ef377ced18e5ccce6d0eabe86fae63be8a15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529180 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Alexander Hendrich <hendrich@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641928} TBR=thakis@chromium.org,hendrich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 943140 Change-Id: I8eec88f1fa1ce6c14779a5f5e51dc6395ae3f416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534998Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#643403}
-
Sergio Villar Senin authored
This is the 2nd step in the process of banning external/wpt from SlowTests. After cleaning up the wtp entries we're marking them as slow by using wpt idioms, i.e.: 1) Add <meta name="timeout" content="long"> to .html files 2) Add // META: timeout=long to .js files Bug: 765026 Change-Id: Iaf051104f419524916e19324996cc36ee37d5426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497005 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#643402}
-
Rayan Kanso authored
Move existing match tests to a match file, and add a test for matching with query options. Change-Id: I678c968fb56c4ff5a715f29746ec1e3a81958a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535879Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#643401}
-
Carlos IL authored
The console message informing users about the mixed content autoupgrade experiment had a typo in it, this has been fixed in 74, but since the experiment will be run in M73 while it's in beta, this CL adds a doc at the URL with the typo pointing to the correct doc. Additionally, since we are not running the experiment with fallback, that section was removed from the doc. Bug: 938916 Change-Id: If791704151b1ea541d66bb1a280e31c0967320c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534934Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#643400}
-
Avery Musbach authored
When an indicator label fades in or out, the correct animation parameters depend upon whether the corresponding indicator is expanding/contracting or just also fading in or out. Currently, SplitviewAnimationType has separate values for these cases, but calls to DoSplitviewOpacityAnimation() show confusion over the distinction. Also, ApplyAnimationSettings() does not correctly handle the case where an opacity animation and a transform animation should be both delayed simultaneously, on the same layer. I am fixing both problems in the present CL. Test: manual Bug: 943718 Change-Id: Idc68e80c382bdefca7658c5a3050a55c5bbc8c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533097Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#643399}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cf1866183620..2e96bac879cf git log cf1866183620..2e96bac879cf --date=short --no-merges --format='%ad %ae %s' 2019-03-22 bclayton@google.com Regres: Transition from out/ to build/ 2019-03-22 bclayton@google.com Regres: Include an example test for each of top N failures Created with: gclient setdep -r src/third_party/swiftshader@2e96bac879cf The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129056755 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ia4834793ad548cdecdd33f4a281576c625bd7163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535421Reviewed-by:
-
Erik Språng authored
Bug: chromium:942101 Change-Id: Ie15a8ea693fee8eb800196e52f45dd7acb6994d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535888 Commit-Queue: Erik Språng <sprang@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
-
Huanzhong Huang authored
- Manager holds a reference to the time range item upon creation and update the item text when notified a change of time range. - Replace the |timePeriod| property with one that is synced with preferences. Bug: 944230 Change-Id: Id815963830eb2337ae1dfed931259b3d10de68fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532010 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#643396}
-
Gauthier Ambard authored
The target has been split in multiple targets. It is currently empty. This CL removes it. Bug: 944008 Change-Id: I0b7d9147d229408cd4e9cac93a64a36b6bffd7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534163 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#643395}
-
Justin DeWitt authored
https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester has been failing for a long time, trying to green it up. Tbr: miu@chromium.org, backer@chromium.org Bug: 933080 Change-Id: Ibd6ef09a394e0be677b392435a81dd6de94f3547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535283Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#643394}
-
Elly Fong-Jones authored
This change: 1) Removes this flag 2) Removes the backing feature OmniboxVoiceSearchAlwaysVisible 3) Reworks some of the Java location bar layout tests that used to depend on the feature Bug: 807726 Change-Id: Iced90b4ca7828a8ac7f92630579fb88ff1c87f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531033Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#643393}
-
Jeffrey Cohen authored
Adding objective-c factories and sync clients for SendTabToSelf, and changing browser_sync code to make use of those new classes. Bug: 910390 Change-Id: Ieae03174e8c1ff02e2e2de845247f037e805a811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488118 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#643392}
-
Abhijeet Kandalkar authored
The primary motivation of this CL is to replace |ToBasicShapeCircle| with |To<BasicShapeCircle>|, |ToBasicShapeEllipse| with |To<BasicShapeEllipse>|, |ToBasicShapeInset| with |To<BasicShapeInset>|, |ToBasicShapePolygon| with |To<BasicShapePolygon>| This CL also ports other dependent files to refer to a new template function name. Bug: 891908 Change-Id: I2225a79a5198d3287893b3a0ccd1cc5168810423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535076Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#643391}
-
Antonio Gomes authored
The following classes were switched over: - NGPhysicalBoxFragment - NGBlockBreakToken - NGBoxFragment - NGBlockNode - NGPhysicalContainerFragment R=dgozman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I5edfead9cfe91c254210de3c37f1bff832809d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535480 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Andrew Grieve authored
This showed up when trying to enable multidex by default on all targets. Bug: 917426, 944525 Change-Id: I42d12e12e73e043b9608ff6ef7886a9331d00a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535352Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#643389}
-
