- 15 Aug, 2019 40 commits
-
-
Adam Langley authored
As suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1752937/3/chrome/browser/ui/views/webauthn/authenticator_qr_sheet_view.cc#222 Change-Id: I3401c7c77f6b3989383ecda1d8e68c173aa5ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754709 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#687317}
-
Bailey Berro authored
When there are no nearby printers available, show a message indicating that. Bug: 991929 Change-Id: If430ff4c526120aa0b0c97f1670b6e68d6a0f1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754942Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#687316}
-
Peter Kasting authored
We originally did this to try and ensure tabs had sufficient contrast to be readable in all cases. However, this caused problems if the background colors were not correctly calculated, and also limited theme authors' ability to make aesthetic choices (or override us if we got something wrong). Instead, use the specified colors directly. Generate unspecified inactive tab colors by blending with the background, as we do for the default theme. No changes to how the default theme's colors are calculated. Bug: 904372 Change-Id: I90d96afbf3a1e9b095b0860a64aa044fecdad6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755142 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#687315}
-
Virender Singh authored
This CL makes following changes - Uses default keyword for dtors in ActionHandlingFakePepperPluginInstance, FakeRendererPpapiHost and PdfAccessibilityTreeTest classes. - Removes ConvertAXScrollToPdfScrollAlignment function from member variable of PdfAxActionTarget to a function in anonymous namespace. - Rephrased and moved comments in pdf_accessibility_tree_browsertest.cc and accessibility_unittest.cc files. Bug: 769940 Change-Id: If7515d09e271d867af72a2f74e10e43b10fff236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753370 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#687314}
-
Daniel Clark authored
Update input type 'date', 'datetime-local', and 'week' ControlType, LocalizedControlType, and AriaRole The html-aam spec doesn't specify values for ControlType, LocalizedControlType, or ARIA role for input date, datetime-local, or week. However, the current values for these don't really reflect the way that the user interacts with the controls. The current values are: ControlType: UIA_ListControlTypeId LocalizedControlType: "list" AriaRole: "list" The values should be changed to the following to better reflect the way that the user interacts with the control (basically as a textbox that restricts its input to valid dates), with LocalizedControlTypes that distinguish between the different types: ControlType: UIA_EditControlTypeId LocalizedControlType: "date picker" for input date, "local date and time picker" for datetime-local, "week picker" for week. AriaRole: "textbox" Note that the above refers to the textbox part of the control, not the calendar popup. Bug: 993549 Change-Id: I1071d9c69701cb312426c8cded4875ac339c57ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751975Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Alex Clarke authored
This API is not being used much and one of the tests is flaky. Rather than fix the test it has been decided to remove the API. The internal working is left untouched so it would be easy to add it back should the need arise. Bug: 970187 Change-Id: I036d5843cd41795a84ca7f0c2be2a31acc4e9b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692981 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#687312}
-
Joshua Peraza authored
This is generally convenient on any Linux platform because build-ids aren't generated by default in non-official builds. Change-Id: I83584fadfe3e1374bb7ad99eb9d22b8d2a698df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755974 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#687311}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/096b09187476..bacb821c428a git log 096b09187476..bacb821c428a --date=short --no-merges --format='%ad %ae %s' 2019-08-15 brianosman@google.com Fix crash in reinterpretcolorspace GM with abandoned context 2019-08-15 dtapuska@chromium.org Fix duplicate definition of kRect_ClipType. 2019-08-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@bacb821c428a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:993871 Change-Id: I606cc8b44c0461f1a146199f8d0b6d02d20f0783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687310}
-
Samuel Huang authored
This reverts commit 461a68da. Reason for revert: This is no longer needed: We've decided to let each DFM load native resources (on install) in its own way, instead of relying on common infrastructure. Reverting this also fixes crbug.com/994035 Original change's description: > [Bundles] Add module_installer_backend.cc with native OnInstallModule handler. > > To prepare for handling native resource loading after DFM installation, > this CL adds a new hook in ModuleInstallerBackend.onFinished() to call > (via JNI) a new native handler for each newly installed module: > JNI_ModuleInstallerBackend_OnInstallModule() > > AsyncTask is used to make the JNI call asynchronous, taking place > outside the UI thread. This allows file access (e.g., to open native > resources) to take place in the native code, thereby preventing > assert failure in Debug builds. > > After the JNI call, |mListener.onFinished()| is called on UI thread, > just like before. > > Bug: 927131 > Change-Id: I36880cc7739a48534052b51d3d655d1ae0beb29a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702905 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680452} TBR=danakj@chromium.org,huangs@chromium.org,agrieve@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927131,994035 Change-Id: If9fdbffb35d226615135c9db596ad50960bc2958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756154Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#687309}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 4ff606217..c152cc559 (7 commits) https://quiche.googlesource.com/quiche.git/+log/4ff606217c21..c152cc559e6c $ git log 4ff606217..c152cc559 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 renjietang Prevent QuicStreamSequencer from taking in new data after the stream is reset. 2019-08-13 renjietang Early return in QuicSpdyClientSessionBase after connection is closed. 2019-08-13 danzh gfe-relnote: n/a(code clean up) inline quic::CreatePccSender() 2019-08-13 renjietang Allow creation of HTTP/3 static stream after MAX_STREAM frame is received. 2019-08-13 bnc Track unacknowledged references on the encoder stream in QpackBlockingManager. 2019-08-12 renjietang Improve hard-coded QuicSimpleServerStream's push promise id. 2019-08-12 renjietang Initialize session in quic_simple_server_stream_test. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I7be248b26644adfe330d2005f3c0192a50607d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756145 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#687308}
-
John Chen authored
When web page adds toJSON function to Array prototype, ChromeDriver incorrectly calls this function while doing JSON serialization of array objects. This is incorrect, as the W3C WebDriver spec (https://w3c.github.io/webdriver/#dfn-internal-json-clone-algorithm) explicitly specifies that implementation should check for collection before looking for the toJSON function. Bug: chromedriver:3084 Change-Id: Ib2ed0c79833a6ca557d33595687efd70ade7d8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749617 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#687307}
-
Alex Newcomer authored
Since CL 1737730, AppList visibility is now correct in tablet mode. After this change, bugs have surfaced with the shelf background. To fix this, modify HomeLauncherGestureHandler so we no longer notify observers that the animation has completed before clearing state. The specific issue was that HomeLauncherGestureHandler::IsDragInProgress returns true when observers are notified of home launcher animation completion. So, fix this, then check HomeLauncherGestureHandler::IsDragInProgress to more accurately determine the proper shelf background. Also check for widget visibility, not activation, because the widget is not activated in tablet mode when shown. Bug: 990995 Change-Id: I560a6db4c045dbbc802f18b43266e2c1f2f19e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746915Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687306}
-
Brendan Hansknecht authored
Added AutotestPrivateGetAllInstalledAppsFunction to autotestPrivate api. Created enums for AppType and AppReadiness in autotest_private_api.idl Added test case to confirm that all default apps are available. Updated HistogramValue enum for extension functions with new item. Test: locally on eve and browser_tests --gtest_filter="AutotestPrivateApiTest.AutotestPrivate" Bug: 989231 Change-Id: Id8a83335d7ad0922480652bb871e200e470d923a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742394Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Brendan Hansknecht <bhansknecht@chromium.org> Cr-Commit-Position: refs/heads/master@{#687305}
-
Gabriel Marin authored
Nobody uses it anymore. Depends on http://crrev.com/c/1754158. BUG=989976,b:131626644 Change-Id: I04bd32cf285b46b79c22f997ef6dc972ec55e8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754159Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#687304}
-
Peter Collingbourne authored
Clang derives the value of __ANDROID_API__ from the triple these days. The behaviour of the HWASAN pass is dependent on the API level in the triple, so it's going to need to be accurate. Bug: 916828 Change-Id: Ie8ab8942fcb22a1247bd0ef3a2c622c7992e71ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755145Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#687303}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/611663f4f61c..be74c47db7dd git log 611663f4f61c..be74c47db7dd --date=short --no-merges --format='%ad %ae %s' 2019-08-15 jmadill@chromium.org Capture/Replay: Also capture on postSubBuffer. Created with: gclient setdep -r src/third_party/angle@be74c47db7dd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Ife267e7e54660d630e121f4a5b4684af309d5ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755560Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 992345 Change-Id: I7160af820454a08c1b7eb2ff13845cc0eeba759d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751944 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#687301}
-
Cameron authored
Create a suggestion chip that shows up once when an update has been applied to a chromebook. Bug: 992490 Change-Id: I91492d5eefeccfce5037309da8c9683a76cb8158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731770 Commit-Queue: Cameron Womack <camw@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#687300}
-
John Chen authored
While handling events from DevTools, ChromeDriver should avoid making unnecessary blocking function calls, to avoid blocking other parts of the system. This CL replaces some calls to SendCommand with SendCommandAndIgnoreResponse in event handlers. Only places where the replacement is safe is made. Bug: chromedriver:907 Change-Id: Idd73b4e6bfeaf750ae7ba341a1033ec30b720682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755404Reviewed-by:
-
Evan Stade authored
BrowserActivityWatcher is now a TabStripModelObserver, and runs the activity callback whenever a tab action is taken (to include parenting, i.e. addition or replacement, as well as closing). Note these notifications are sent by Browser, so they don't exist on Android. BrowserActivityWatcher and TabStripModelObserver are also unique to desktop, so this entire CL only affects desktop. Bug: 268984 Change-Id: I668e22bf637c33266060cd27c1464118a8c6ed1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752912Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#687298}
-
Anna Malova authored
Bug: 992146 Change-Id: Ib7c3ae979bebc79f64a455ecd29c6e4f2b76512b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751796Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#687297}
-
Justin Cohen authored
Reduce some duplicative tests between iOS12 vs 13. In general it's good to test both iOS versions here, but cycle time for both builders are getting too high. Bug: 992500 Change-Id: I6d6d30e66c8cb8320c20d934e05167e43d8d2282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756150 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687296}
-
Edvard Thörnros authored
This is the fifth commit in the series of updating all the old svg animation tests. The usage of testharness has replaced the older SVGAnimationTest.js for all where it's suitable. No functionality should have changed and the tests should cover almost the same. In all of the animations where there is a sampling at T=0, where it was assumed that no animations had started. Which didn't work flawlessly when moved to the new system, it has thus been removed. Bug: 985335 Change-Id: I34fc15e34d01f774c7992ed6c1d79d9e86cd9409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753003 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Julian Kung authored
This changelist allows a user client to send DevTools commands through a ChromeDriver websocket connection made between the user client and ChromeDriver. It should be followed by a changelist that allows the client to receive events from DevTools in real time. The test client has been augmented to be able to create a websocket connection with ChromeDriver. To keep command IDs sent to DevTools unique,it was decided that commands sent from ChromeDriver through the websocket connection between the user and Chromedriver will have negative IDs, and commands not sent through the websocket connection will have positive IDs. ChromeDriver will not receive command responses from with negative IDs, as the websocket connection between ChromeDriver and the client is supposed to eventually allow bidirectional communication between the client and DevTools. Therefore, negative ID commands will eventually be sent to the user client, which will be completed in another CL. The websocket message sent by the client to ChromeDriver is formatted through DevToolClient's SendCommandInternal method in order to abstract away OOPIFs. Some notes: When ChromeDriver receives a request to establish a websocket connection, the method OnWebSocketRequest in chromedriver_server.cc is invoked. In this method ChromeDriver accepts the websocket connection. When ChromeDriver receives a websocket message from the client, the method OnWebSocketMessage in chromedriver_server.cc is invoked. The websocket message should be a JSON dictionary with a key "urlPath" that contains the http endpoint send_command_from_websocket, a key "id" with a negative value, and cmd and params identical to what would be seen in a call to ExecuteSendCommand (or similar). The method OnWebSocketMessage formats an http request with that information. ExecuteSendCommandFromWebSocket in window_commands.cc is called and a similar code pathway as ExecuteSendCommand is taken. Notable differences include the passing of a negative ID which is used in place of the positive ID usually assigned by ChromeDriver. In SyncWebSocketImpl, a response/event is only queued in the received_queue_ if it is relevant to ChromeDriver. This is denoted by either being an event or containing and positive ID. Currently, all negative ID messages are dropped, but the subsequent CL in the relation chain forwards messages with negative IDs to the client. R=crouleau@chromium.org, johnchen@chromium.org Bug: chromedriver:2815 Change-Id: I3f900567fa184a2af5f0092338e071172acc879d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730860 Commit-Queue: Julian Kung <juliankung@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
Mike Frysinger authored
The WrapOutputStream logic as written only works for Python 2. Python 3.7 added a dedicated API for this, but older Python 3 versions require a bit of effort. It's all a bit hairy, but there aren't any other options here. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I980fe4e92af7b5c0a44f25737ac267bb90d207d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755385Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f714c29b97d0..74bf49a9abc9 git log f714c29b97d0..74bf49a9abc9 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 khokhlov@google.com Merge "Trace processor: Export legacy ftrace and json trace events to JSON" Created with: gclient setdep -r src/third_party/perfetto@74bf49a9abc9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Iad99ba8bbd2a6a9ee1af9fc163ea693237388b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755558Reviewed-by:
-
Mike Frysinger authored
The Python folks decided to break re.sub behavior and have it randomly replace empty matches with non-empty strings. For example: >>> re.sub(r'(.*)', r'foo', 'asd') 'foofoo' To avoid this crazy pants behavior, we could make the regex match the entire string (by adding ^ and $ anchors), but this bit of code doesn't really need a regex at all. We're simply inserting the string "2x" before the last "/" in the filename. Rewrite the code to do a little ad-hoc string splitting instead as this is a bit easier to read. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I7aa005d685bb1019c464af1c1f12ce2701431ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755391Reviewed-by:
-
Mike Frysinger authored
We rely on the unicode(node) result for testing & display of the node state, but this doesn't work in Python 3 where str==unicode. Rename the exsting __unicode__ to __str__ and add a backwards compatible alias for Python 2. Now str(node) works in both. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I9cb3027d3f013e53c0a6bfc23705ea7a30e88ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755393Reviewed-by:
-
Julien Racle authored
If you include both base/win/async_operation.h and base/win/vector.h then a few aliases (like Complex, Abi) will collide. This CL proposes using dedicated type names to prevent collision to happen. BUG=728870 Change-Id: Ib7757ecd0793a25de18818f1156920973e8ef8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755748 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#687289}
-
Avery Musbach authored
Before the present CL, the caption buttons of a browser window would be hidden most of the time, but not at the moment when a browser window is created in tablet mode. Workflows such as entering and exiting overview would then cause the browser window caption buttons to be hidden because they were supposed to be hidden all along. As of the present CL, the caption buttons really will be hidden in the first place. The present CL adds a very flaky unit test. Without the present CL, the related test TabletModeBrowserCaptionButtonVisibility is already a little bit flaky, meaning that the present CL is not really introducing a new problem. The present CL just adds to the priority of addressing the preexisting test flake issue. See Issue 993974. Test: browser_tests HomeLauncherBrowserNonClientFrameViewAshTest.CaptionButtonVisibilityForBrowserLaunchedInTabletMode Bug: 993594, 993974 Change-Id: I63442abd452eba4ea6b35ad67273dec000ea1c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754239Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#687288}
-
Hirokazu Honda authored
AMD GPU driver shows the whole black frame if the surface size is coded size specified in the bitstream. This bug turns out when Android begins to inform the adjusted size (crrev.com/c/1694962 & crrev.com/c/1722468). This CL is a workaround for this driver bug. VaapiVDA ignores the frame size adjusted by a client and use coded size embedded in codec bitstream. Bug: b:139460315, b:139325471 Test: android.media.cts.EncodeDecodeTest on grunt and atlas Change-Id: Ic9b2d69b2ceb669e1e8660edc2df3f3f0fc20b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755434 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#687287}
-
Gabriel Charette authored
This is a reland of 1219f372 It was initially reverted per conflict with skyostil@'s crrev.com/686824 landing simultaneously. I fixed that in the reland that landed in crrev.com/687250 but crrev.com/686824 was reverted simultaneously making the first patch the one needed again... So I'm relanding the first CL as-is. Original change's description: > [base] Additional no-compile tests for traits_bag.h > > This assertion was tested in task_traits_unittest.nc already but it > should also be tested generically alongside the generic code. > > Change-Id: I77ea066a2a82c63f6ad8c692a23b93f74913fe1d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753655 > Auto-Submit: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686836} Change-Id: I39da37fc659a1bdf7476f772d816e43a3ef10df4 TBR=fdoray@chromium.org Change-Id: I39da37fc659a1bdf7476f772d816e43a3ef10df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756151Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#687286}
-
Yi Xu authored
remove (Canvas|OffscreenCanvas).TextMetrics.MeasureText metrics. Since measuring text is dependent on the length of the text, the measurement times are not comparable. Bug: 982019 TBR=rkaplow@chromium.org Change-Id: Iaddc190ba5d71a5aacdbe48ddff8427cbb616bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753588 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#687285}
-
Evan Stade authored
Recent changes have removed its usage throughout the codebase. Bug: 268984 Change-Id: Id6b211af5e99d8774f68db7235196f869ca782b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753548Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#687284}
-
Egor Pasko authored
Fix symlink creation for cases when the binary does not have build-id. When --symbols-dir is a relative path, the symlink under discussion would look like this: 'path/to/libfoo.so/000000000000000000000000000000000' -> (pointing to) 'path/to/libfoo.so/<HASH>' It works for absolute paths, but not for relative ones like 'path/to'. It will work for both absolute and relative paths if the link itself is relative and points to -> '<HASH>'. Fortunately it is easy to do. Done. Bug: None Change-Id: Ic764f0380063e2f2e15cf484afd5468dcca8f51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745986Reviewed-by:Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
Ryan Powell authored
This CL creates the MultiSourceMemoryPressureMonitor, MemoryPressureVoteAggregator, and MemoryPressureVoter classes described here: https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit#. The aggregator class collects votes from voter instances via the OnVote method. A MemoryPressureVoteAggregator object will be owned by the MultiSourceMemoryPressureMonitor class, which will be merged with the MemoryPressureMonitor class after subsequent CL's which will migrate the OS-specific MemoryPressureMonitors to own a Voter and use that Voter to inform the Monitor of their votes. Bug: 980965 Change-Id: Ib84aadca9a4cf74b3c1f8a42787d63a96f5dfd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719109 Commit-Queue: Ryan Powell <ryanpow@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#687282}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/201cdbb64614..096b09187476 git log 201cdbb64614..096b09187476 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 bsalomon@google.com Make GrBlend.h private 2019-08-15 brianosman@google.com Add SkImage::reinterpretColorSpace 2019-08-15 egdaniel@google.com Remove remaining functions in GrGLCaps that use GrPixelConfig. 2019-08-15 michaelludwig@google.com Move the source image into Context Created with: gclient setdep -r src/third_party/skia@096b09187476 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:795132 chromium:985500 Change-Id: If39f8a34c9c0653236b6494284635a9c7d8d90a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755553Reviewed-by:
-
Robert Ma authored
No-Try because the test hasn't arrived yet. TBR=lpz No-Try: True Bug: 994214 Change-Id: I522b21423261f1f9d3cdccad6c3a40edc78b9185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755973Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#687280}
-
Fred Mello authored
Bug: 949729 Change-Id: I8ebb40af59aea33f27e0a38e7ac6e617af099b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751963 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#687279}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/75b6f212c853..ae0f75063c10 git log 75b6f212c853..ae0f75063c10 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 chrisforbes@google.com Add libyarn static library to Android build Created with: gclient setdep -r src/third_party/swiftshader@ae0f75063c10 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139010488 Change-Id: I030e013b5fbd1123ec51b22de2e03d08d03931d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755556Reviewed-by:
-
