GitLab

This can be used to get a path to the source file relative to the target's
directory.

Review-Url: https://codereview.chromium.org/2387763002
Cr-Commit-Position: refs/heads/master@{#439541}

Reason: for consistency.

Closely related CL: https://codereview.chromium.org/2064313003

This CL was made in the same way, for the same purpose, but renames the
rest of the files in webkitpy, outside of the tool/ directory.

In addition to renaming files, this change also handles pylint warnings
by making additional changes or adding pylint disable pragma comments.

Review-Url: https://codereview.chromium.org/2578213005
Cr-Commit-Position: refs/heads/master@{#439540}

Checking whether the RFH is associated with the frame tree shouldn't
be needed anymore after r437660, which fixed GetLastCommittedOrigin()
to work properly with pending delete RenderFrameHosts.

BUG=663740

Review-Url: https://codereview.chromium.org/2583943002
Cr-Commit-Position: refs/heads/master@{#439539}

BUG=555550

Review-Url: https://codereview.chromium.org/2584963002
Cr-Commit-Position: refs/heads/master@{#439538}

Without this, we were downloading chromium_commands.dex.jar from GCS every
time we tried to use it. This is both unnecessary and potentially problematic,
as catapult/devil's downloading mechanism is currently prone to hanging with
lock failures.

With this change, we will instead use the locally built version of
chromium_commands.dex.jar when available.

BUG=674172

Review-Url: https://codereview.chromium.org/2575003003
Cr-Commit-Position: refs/heads/master@{#439537}

Also:
- upstream some "ifdef(OS_WIN)" by moving stability_debugging_win.{h,cc} to stability_debugging.{h,cc}.
- enclose components/browser_watcher/BUILD.gn targets in "if (is_win) {}" as the dependency from components/metrics started causing win only targets to be built on other platforms.

BUG=620813

Review-Url: https://codereview.chromium.org/2531123002
Cr-Commit-Position: refs/heads/master@{#439536}

Enforce check on how many pref updates and cache updates are called in http_server_properties_manager_unittests

BUG=670519

Review-Url: https://codereview.chromium.org/2585823003
Cr-Commit-Position: refs/heads/master@{#439535}

It uses WeakPtrFactory and as such must be destroyed on its owning thread (UI).

The rest of the changes can then be inferred from the stack trace on the bug:

1) RefcountedKeyedServiceTraits::Destruct() must check for
   ThreadTaskRunnerHandle::IsSet() before invoking TTRH::Get().
  ** UPDATE in PS 5 : Use STR::RunsTasksOnCurrentThread() instead of STRH comparison.

2) Nothing about RefcountedKeyedService's use of its |task_runner| is thread-affine
   => using SequencedTaskRunner instead is inline with our desire to make all
   top-level API use sequence-affinity instead of thread-affinity for thread-safety.

3) Calling SequencedTaskRunnerHandle::IsSet() from the Callback's destructor requires
   the SequencedWorkerPool's task info to be set in that scope
   => brought changes from same requirements in another CL
      @ https://codereview.chromium.org/2491613004/#ps160001
   Note: intentionally not adding tests as this change highlights that this deletion is
   racy in theory (deleting without owning the sequence means potentially deleting
   things from the same SequenceToken in parallel... any good test would fail TSAN and
   I also don't want to address this issue given it's long standing and SWP is being
   replaced by TaskScheduler shortly).

4) Switch to ScopedMockTimeMessageLoopTaskRunner in NotificationPermissionContextTest
   => otherwise LSAN catches a leak in patch set 3 as the HostContentSettingsMap is
      sent for deletion on the wrong task runner and the task is never flushed.
      (ScopedMockTimeMessageLoopTaskRunner ensures the loop is flushed before replacing
       it, both ways).

Precursor requirement to https://codereview.chromium.org/2576243003/ which
for some reason makes this destruction race come to life.

BUG=674946, 665588, 622400
TBR=mukai (NotificationPermissionContextTest side-effects)

Review-Url: https://codereview.chromium.org/2581213002
Cr-Commit-Position: refs/heads/master@{#439534}

SVGIntegerOptionalInteger parses values as floats but stores them as
integers. Add helpers to avoid issues with overflow and to make this
conversion the same way in all places it's needed.
The "normal" parsing code would truncate the float value while the parsing
code for animation values would round. Make them both use truncation (and the
avoid duplicating the code.)

BUG=675130

Review-Url: https://codereview.chromium.org/2590433002
Cr-Commit-Position: refs/heads/master@{#439533}

Currently the previous/next arrows are not disabled when there is no
text match. Fixed this.

BUG=509857

Review-Url: https://codereview.chromium.org/2584983002
Cr-Commit-Position: refs/heads/master@{#439532}

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578793004
Cr-Commit-Position: refs/heads/master@{#439531}

A string-backed source map and ability to use safe builtins in testing
are going to be necessary for future API binding unit tests, in addition
to the module system tests that use them already. Pull them out into
separate files to allow reuse.

BUG=653596

Review-Url: https://codereview.chromium.org/2586303002
Cr-Commit-Position: refs/heads/master@{#439530}

We're currently always drawing tiled backgrounds in repeat/repeat mode,
even if we need tiling in one dimension only.

This has the unexpected side effect of opposite edge bleed, in the
dimension which doesn't require tiling, when rasterized for hidpi
devices (DSF causing Skia to sample across the tile boundary).

Detect cases where tile repetition is not needed, and strength-reduce the
shader tile mode accordingly.

Also make Image::drawPattern() protected, as it is only used in subclasses.

BUG=673261
R=reed@google.com,fs@opera.com,schenney@chromium.org

Review-Url: https://codereview.chromium.org/2582383002
Cr-Commit-Position: refs/heads/master@{#439529}

BUG=620034

Review-Url: https://codereview.chromium.org/2583283002
Cr-Commit-Position: refs/heads/master@{#439528}

DownloadNotificationService lags behind Download Home on learning about
downloads that exist.  Problematically, Download Home needs to act on
downloads via DownloadNotificationService to ensure that notifications
properly account for download updates.  Currently, when
DownloadNotificationService is told to do something for a download it
doesn't know about, the Intent is dropped on the floor.

Instead, fall back so that the DownloadManagerService is notified by
DownloadNotificationService about actions triggered via Download Home.

BUG=673994,658246

Review-Url: https://codereview.chromium.org/2577303002
Cr-Commit-Position: refs/heads/master@{#439527}

Read cached estimates from the network quality estimator (NQE) prefs.
The read estimates are notified to observers if the network ID of the
cached estimates matches the ID of the current network. Both writing
and readings of prefs is guarded behind field trial.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=490870

Review-Url: https://codereview.chromium.org/2487883002
Cr-Commit-Position: refs/heads/master@{#439526}

The hash has to be generated from an ARM platform, since the x86 hash does not match.

Review-Url: https://codereview.chromium.org/2579423002
Cr-Commit-Position: refs/heads/master@{#439525}

Merge internal change 142151597

BUG=

Review-Url: https://codereview.chromium.org/2580393003
Cr-Commit-Position: refs/heads/master@{#439524}

https://pdfium.googlesource.com/pdfium.git/+log/da587fab5760..0fdeeb817556

$ git log da587fab5..0fdeeb817 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 tsepez Relax the EncryptMetadata check.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2592453002
Cr-Commit-Position: refs/heads/master@{#439523}

The exponent was being checked against numeric_limits<...>::max_exponent
which is the power-of-two limit. Use max_exponent10 instead. Also make
sure to apply any exponent sign prior to the range check so that
min_exponent10 can be used as the lower bound. This means computing the
base number before checking for/parsing the exponent part. This could
be slower in some cases, but reasonably only when an error is
encountered. Also, scientific notation should be fairly scarce to begin
with.

Also move declarations of local variables closer to their first use (and
in the inner-most scope possible.) Unravel the handling of/accumulation
into 'frac' when computing the decimal part.

BUG=675174

Review-Url: https://codereview.chromium.org/2588023002
Cr-Commit-Position: refs/heads/master@{#439522}

see https://skia-review.googlesource.com/c/6206/

BUG=
NOTRY=True

Review-Url: https://codereview.chromium.org/2583023003
Cr-Commit-Position: refs/heads/master@{#439521}

This fixes a couple of bugs:

1. Makes sure the ChromeNetworkDelegate can't call in to a destroyed DomainReliabilityMonitor by moving ownership of the Monitor from ProfileImplIOData to ChromeNetworkDelegate.

2. Makes sure the uploader doesn't leave URL requests around once they're all supposed to be gone by adding a separate "shutdown" step that deletes existing requests and prohibits new ones.

BUG=644858

Review-Url: https://codereview.chromium.org/2336043007
Cr-Commit-Position: refs/heads/master@{#439520}

Review-Url: https://codereview.chromium.org/2587063002
Cr-Commit-Position: refs/heads/master@{#439519}

Review-Url: https://codereview.chromium.org/2564123002
Cr-Commit-Position: refs/heads/master@{#439518}

https://skia.googlesource.com/skia.git/+log/efa9d34ccbde..d1c550e71fa7

$ git log efa9d34cc..d1c550e71 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 fmalita Consolidate TILEX_LOW_BITS/TILEY_LOW_BITS -> EXTRACT_LOW_BITS
2016-12-19 robertphillips "Fix" some ImageFilter fuzzer issues

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2587093002
Cr-Commit-Position: refs/heads/master@{#439517}

This CL adds a module which is intended to produce simple HTML
diffs to view with layout test results.

BUG=672651

Review-Url: https://codereview.chromium.org/2580143002
Cr-Commit-Position: refs/heads/master@{#439516}

Remove //components/proximity_auth/remote_device.h. It was supposed to have been removed in https://codereview.chromium.org/2560713002.

BUG=672263

TBR=tengs@chromium.org

Review-Url: https://codereview.chromium.org/2586983003
Cr-Commit-Position: refs/heads/master@{#439515}

We can't really make the calls use an event in the current situation.
Adding TODO's to explain how it should be done and rename methods for
future usage

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2587083002
Cr-Commit-Position: refs/heads/master@{#439514}

BUG=654071

Review-Url: https://codereview.chromium.org/2580023002
Cr-Commit-Position: refs/heads/master@{#439513}

TBR=kbr@chromium.org
BUG=655335
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2586283002
Cr-Commit-Position: refs/heads/master@{#439512}

Original CL: http://crrev.com/2562643004

Fixes BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline.

TBR=mariakhomenko@chromium.org
BUG=601053,674293

Review-Url: https://codereview.chromium.org/2580523002
Cr-Commit-Position: refs/heads/master@{#439511}

Clear the StyleEngine of css connected fonts on detach().

This used to be saved by an active stylesheet update, it seems. With
the new active stylesheet update this is done more selectively and it
might have been done when document going inactive before. Clearing the
font cache on detach fixes the leak issues in css3/fonts.

TEST=css3/fonts/
BUG=674934

Review-Url: https://codereview.chromium.org/2582413002
Cr-Commit-Position: refs/heads/master@{#439510}

Update list of required files and compile flags.

BUG=None

Review-Url: https://codereview.chromium.org/2588003002
Cr-Commit-Position: refs/heads/master@{#439509}

Plumb custom bounds through DstRangeRelationToSrcRange to remove
duplicate comparisons. Refactor RangeConstraint from an enum to a class
containing bools, which can be independently evaluated at compile-time.

NOTRY=true

Review-Url: https://codereview.chromium.org/2585043002
Cr-Commit-Position: refs/heads/master@{#439508}

Last week, a CL landed that contained a gtest with an empty test name,
e.g.

  TEST(FooTest, )

This broke our gtest-list-tests parsing logic because it saw this:

  FooTest.

    testBar

and incorrectly handled the line containing only spaces. This patch
fixes the handling of that case.

Review-Url: https://codereview.chromium.org/2582263003
Cr-Commit-Position: refs/heads/master@{#439507}

Revert of Enable connection to Mojo services from Blink (patchset #19 id:360001 of https://codereview.chromium.org/2460723003/ )

Reason for revert:
Caused some build failures, looks like missing dependencies?

https://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds/56562/steps/compile/logs/stdio

FAILED: obj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj.rsp /c ../../third_party/WebKit/Source/platform/heap/ThreadState.cpp /Foobj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj /Fd"obj/third_party/WebKit/Source/platform/heap/heap_cc.pdb"
e:\b\c\b\win\src\third_party\webkit\public\platform\platform.h(59): fatal error C1083: Cannot open include file: 'services/service_manager/public/interfaces/connector.mojom-blink.h': No such file or directory

Original issue's description:
> Enable connection to Mojo services from Blink
>
> This CL enables connections to Mojo services from Blink; more specifically,
> from //third_party/WebKit/Source/modules, where dependencies on Chromium
> code are in general undesired (including on Mojo services' client
> libraries). To enable connecting to services without using the
> Service Manager's client library, this CL does the following:
>
> (1) Adds a method to Platform that exposes the connection to the
> ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
> (2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
> supports connecting to Mojo services by name from Blink.
> (3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
> of connecting to an interface that is hosted in a service other than
> //content/browser from Blink.
>
> ServiceConnector being "bare-bones" includes the facts that:
> - Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
> thread-hostile. This should be easy to relax using similar mechanisms as
> InterfaceProviderImpl.
> - There is currently no API for obtaining an InterfaceProvider for a given
> service (or a thread-safe wrapper, per the above comment). Again, this should
> be easy to add.
>
> This CL also moves the definition of the device service name to mojom instead
> of C++ in order to facilitate using this constant from Blink.
>
> BUG=612341
> TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
>      and then click "recheck" to ensure that the renderer picks up the new
>      time zone. Don't reload the page, which is likely to give you a new
>      renderer process, use the "recheck" link on the page.
>
> Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
> Cr-Commit-Position: refs/heads/master@{#439498}

TBR=jochen@chromium.org,dcheng@chromium.org,esprehn@chromium.org,haraken@chromium.org,noel@chromium.org,rockot@chromium.org,blundell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612341

Review-Url: https://codereview.chromium.org/2589493006
Cr-Commit-Position: refs/heads/master@{#439506}

With this CL, tasks posted to the base/task_scheduler/post_task.h API
no longer run asynchronously on a dedicated thread. Instead, they are
posted to a MessageLoop on the thread where the ScopedTaskScheduler
lives and run synchronously when RunLoop::Run/RunUntilIdle() is
invoked. This CL also allows usage of the
base/task_scheduler/post_task.h API within the scope of a
TestBrowserThreadBundle.

Benefits of running TaskScheduler tasks synchronously:
- Tests are more deterministic.
- It is easier to wait for a chain of tasks involving TaskScheduler.
  E.g.:
   base::PostTaskAndReplyWithTraits(
       FROM_HERE, TaskTraits(), Bind(&A), Bind(&B));
   base::RunLoop().RunUntilIdle();
       // Without this CL, this returns immediately because there
       // are no pending tasks on the main thread initially. With
       // this CL, this returns when A and B have run.

Note that this CL prevents a TestBrowserThreadBundle or a MessageLoop
from being initialized in the scope of a ScopedTaskScheduler. It
fixes tests that previously did this.

BUG=553459

Review-Url: https://codereview.chromium.org/2557083002
Cr-Commit-Position: refs/heads/master@{#439505}

Deleted a comment in MessageService::OpenChannelImpl that
questioned the use of |guest_process_id| and
|guest_render_frame_routing_id|. These ID appear to be used by some
component extensions (bug 424762) so they cannot be removed.

Review-Url: https://codereview.chromium.org/2529213002
Cr-Commit-Position: refs/heads/master@{#439504}

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2589873002
Cr-Commit-Position: refs/heads/master@{#439503}

Fixed typo in color_space.typemap

Added color_space.typemap to typemaps.gni

BUG=670364

Review-Url: https://codereview.chromium.org/2585213004
Cr-Commit-Position: refs/heads/master@{#439502}