- 01 Jun, 2020 40 commits
-
-
siashah authored
We update the status of the Done button based on whether the nickname is valid and then call PersonalDataManager.setCreditCard to save the card with the nickname. Video (Googlers only): https://drive.google.com/file/d/1rH_L7gPIiRSjmkoY5oxWEFoU5uUcCGVR/view?usp=sharing Bug: 1082013 Change-Id: Ifab123a53762da03f3c903962a70e431fc8fb78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218987Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#773857}
-
Adrienne Walker authored
This change turns back on (it's explicitly turned off in the test base class) the require appcache origin trial feature for several manifest 404/410 tests. It also adds a 410 gone test for an upgrade scenario. Bug: 1081907 Change-Id: I533f6ddfc6d45b4f73de5a82af159d77479dacbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225385Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#773856}
-
Stephan Hartmann authored
Bug: 957519 Change-Id: I535b3bcf318f98cecbf4be1520ffe4126abcacd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214556 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773855}
-
Ana Salazar authored
This is part of the new drag spec in the apps grid. When the user drags an app, the apps grid enters a new cardified state. In this state we scale down items to 84% of its size and add a background card to the apps grid, giving a more modular look to the app pages. We define an array of Layers for the background cards so we are able to manipulate the animations during the cardified state in every step (start, translation across pages, end). When we end the cardified state, we also delete the cards. This functionality is hidden under the app_list_feature kNewDragSpecInLauncher. Bug: 996822 Change-Id: Ic8dcca8cfa2f11ceb52634dbf1206321d924752f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171453 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#773854}
-
James Cook authored
Mustash/mash was shut down over a year ago. Clean up mash references in DEPS files. Remove a few obsolete entries. All the mash bugs referenced in the files were already closed. Bug: none Change-Id: I4205fb880d69f0e1ddaae133458bf9f2c0d8a6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225456Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#773853}
-
Xiaoqian Dai authored
Bug: 1063144 Change-Id: I85379cc2f4aded28ac9eefb09e2086d446f42168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166360 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#773852}
-
Chris Sharp authored
This histogram is deprecated and no longer need to be recorded. Bug: 1089422 Change-Id: I9c29449b3080535e1451163f1b76c65139df792d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225536Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773851}
-
Sahel Sharify authored
This is a reland of 561f6a86 I reverted the original cl since I wanted to wait for thread safety review of the following two classes: -PaymentDetailsUpdateService.java -PaymentDetailsUpdateServiceHelper.java Original change's description: > [Web Payments][Android] Delegation support for intent based apps [2/3] > > This cl introduces IPaymentDetailsUpdateService.aidl and > IPaymentDetailsUpdateServiceCallback.aidl interfaces so that the invoked > native app can call changePaymentMethod, changeShippingOption, and > changeShippingAddress methods to notify the browser about the user > choosing a different payment method, shipping address, or shipping > option. > > This cl implements the plumbing for sending the change events to the > merchant, but the plumbing for sending the updated payment details from > the merchant to the invoked app will be landed in a follow up cl. > > To test the feature enable "Experimental Web Payments API features" from > chrome:/flags or use the following commandline flag: > enable-features=AndroidAppPaymentUpdateEvents > > Bug: 1026667 > Change-Id: I799c9dfced15fe2fa916b8ca3634b91366cfc32f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168009 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773401} TBR=mthiesse@chromium.org,rsesek@chromium.org Bug: 1026667 Change-Id: I10bfc1778ef950deab59dffef48a027ce7e234bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222899Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773850}
-
Ryan Sleevi authored
Net.CertCommonNameFallbackPrivateCA and Net.CertCommonNameFallback are obsoleted as of r531345, while Net.Cronet.CertVerifierCache.DeserializeTime and Net.Cronet.CertVerifierCache.SerializeTime were removed in r571588. Net.SSLCertVerificationTime and Net.SSLCertVerificationTimeError are extended to M89 as part of the overall cert verification service work. Net.Certificate.TrustAnchor.VerifyOutOfDate is moved to never expire, in line with the other two Net.Certificate.TrustAnchor metrics Bug: 1088988, 1088993 Change-Id: I36482558df69dff2732aff2da27402365c9c2344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224834Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773849}
-
Leonard Grey authored
Currently, in BridgedContentView we "opt out"[1] of BaseView's tracking area to install a different one which: - Specifies `NSTrackingCursorUpdate` - As a consequence, only tracks while app is active, since the docs say that always tracking is incompatible with cursor updates However: - Empirically, cursor updates work fine without this (some test cases: move mouse between Omnibox and other parts of topchrome, move from webcontent links/inputs to topchrome and vice-versa). - Only tracking while app is active means we don't get entered/exited events from app switching. This means: - Switching away from Chrome while showing a topchrome hover tooltip keeps the hover on and makes the tooltip stuck - Under some circumstances, hover stops working on switching back to Chrome (see bug) - Even though we allow mouse clicks to function when Chrome is inactive (that is, we return `YES` from `acceptsFirstMouse:`, we don't process hovers in this case, contrary to other apps on the system. This change removes BridgedContentView's tracking area in favor of the default one and gives BaseView some explicit enable/disables, mostly to make tests happy. [1] By overriding a private method with a no-op! Bug: 841792 Change-Id: Ifb5d65e22299959b8cac25a9e0a0407650a40746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216530Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773848}
-
Yi Gu authored
The resolved scroll source of ScrollTimeline could be null so we should check before dereference it when checking whether it uses composited scrolling. Bug: 1088319 Change-Id: Ib20cceefcd0e1de05cf1d5932a6da6aac37ef8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223995 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773847}
-
Eric Robinson authored
Bug: 1089680,1089681,1089679,1089211,1077807 Change-Id: I1103f31e6b9152007276f7f15e05f8fd9194fabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225265Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#773846}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/394c4a94dbc7..3fb1d569defc 2020-06-01 brucedawson@chromium.org Fix command prompt title after update_depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iee9970e4ba7070b356575e01db14032b9179a528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773845}
-
Kai Ninomiya authored
Bug: 1069302 Change-Id: Iea10257e35bd11e724241dbc038955cc8a0b47a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222299 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#773844}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 378036cd. With Chromium commits locally applied on WPT: bc9a80d4 "Origin isolation: parse the header" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie0770ea924d20b0a3468826131b5256d9dfa33bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224650Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773843}
-
Ian Struiksma authored
updated giftcardmall.test to remove autofill-information reference in xpath. This required update of cipd version in DEPS diff of cipd versions: 265c265 < "selector": "//select[@id=\"statesList\"]", --- > "selector": "//select[@id=\"statesList\" and normalize-space(@autofill-information)=\"overall type: ADDRESS_HOME_STATE server type: ADDRESS_HOME_STATE heuristic type: ADDRESS_HOME_STATE label: State parseable name: state section: address_2-default field signature: 1878375253 form signature: 2667380901547437148\"]", 276c276 < "selector": "//input[@id=\"addressZip\"]", --- > "selector": "//input[@id=\"addressZip\" and normalize-space(@autofill-information)=\"overall type: ADDRESS_HOME_ZIP server type: ADDRESS_HOME_ZIP heuristic type: ADDRESS_HOME_ZIP label: Zip parseable name: zip section: address_2-default field signature: 569224803 form signature: 2667380901547437148\"]", Bug: 1088252 Change-Id: I06821a54e0f0e92505e92d31a5b54aef54c951f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224052 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#773842}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0aaf24a2757..ced839500960 2020-06-01 michael.liao@microsoft.com [TreeElement]: null treeOutline exception in TreeElement.select If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1085816 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2840a29f5384df37de70679478af20577c872126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225308Reviewed-by:
-
John Chen authored
Add missing commas in _DISABLED_TESTS. TBR=wenbinzhang@google.com Bug: 1060068, 1088106, 1088447 Change-Id: I7f2ab1e14314237e4d4b466f775c6a7108de9f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225338 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773840}
-
Behnood Momenzadeh authored
Some top domains use a common word for their website name. Office.com and weather.com are examples of such domains. As a result, hostnames embedding these common words might be falsely flagged. We allowlist some common words in this CL that have shown to lead to false positives. There are two types of common word allowlisting. One is allowing the common word to be embedded with all TLDs and two is allowing the common word to be embedded with TLDs other than the TLD of the top domain. For example, weather is a common word for all TLDs. As a result, neither of weather.com-foo.com, and weather.info-foo.com would trigger this heuristic. However, office is a common word just for TLDs other than ".com". So, office.info-foo.com won't trigger the heuristic, but office.com-foo.com would trigger it. Bug: 1087636 Change-Id: Id5b6bc5204254f45429a7d91690af192fcef81e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224313 Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#773839}
-
Jonathan Backer authored
Sometimes a device driver signals an internal error and we just need to reset. This CL checks for reset more aggressively on all {SharedContextState,SharedImageStub}::MakeCurrent calls. This will hopefully turn some crashes into restarts. Bug: 1079161,1081806 Change-Id: I260f90b4ed2ba63be3cf7ca6759c5aa086f0c46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214919 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773838}
-
Christopher Cameron authored
Change SkiaOutputDevice::FinishSwapBuffers to take a gfx::SwapCompletionResult instead of just a gfx::SwapResult. This makes its way to the population of the gpu::SwapBuffersCompleteParams in SkiaOutputDevice::SwapInfo::Complete, where we will be adding the gfx::CALayerParams structure in a subsequent patch. Bug: 894929 Change-Id: I873f6611b3e87a0b3bedb116d33224aed59b7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225360Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#773837}
-
Karandeep Bhatia authored
Add tests to ensure empty ruleset paths raise an error while manifest parsing. Also add a regression test for issue 1087348 by ensuring DNRManfiestHandler handles an extension with an empty root path correctly. BUG=1087348 Change-Id: I7d3886d2116f5f6126abba153045ded71dcead71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223372Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773836}
-
Dominic Mazzoni authored
This is a small, targeted fix to prevent an issue where pages with CSS animations - especially long-running animations like spinners - experience poor performance with accessibility. It's completely safe to suppress events when a node is aria-hidden. Bug: 1090046 Change-Id: I431d53ffd97263e1013b5c5a0359f1d7515dce23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225497 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#773835}
-
Kelvin Jiang authored
Once again this flakes, at the exact same sub-test as well. Will need further investigation. Bug: 1087765 Change-Id: Ibe431541b835a8e3de613b6006e1526795c0648c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223652 Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
Users may sometimes press non character keys such as ESC when on a webpage (e.g. to close popups or other prompts). This CL ignores these cases and does not undelay the warning. Bug: 1057157 Change-Id: I4cfc2c621e4c0a84f46fdaa8f800e6843ed6b4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225361 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#773833}
-
Jonathan Ross authored
On the Intel 0x3e92 bots the deqp/functional/gles3/shaderoperator/binary_operator_* and deqp/functional/gles3/shaderoperator/unary_operator_(01|02).html have continued being flaky, even with RetryOnFailure. I'm marking them as Skip until the root cause can be addressed. TBR=bsheedy@chromium.org Bug:1085222 Change-Id: I04e1ec7e047afd2a63055b5e5b4915f8319dc9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224844Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#773832}
-
Ken MacKay authored
Bug: internal b/151898798 Change-Id: Iefa00b066a834f99f4559d16c94aee47d94ce590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216881Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#773831}
-
Tomasz Wiszkowski authored
Change-Id: Iee930bac15483daaf0bb7a88ab48af0007717a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219580 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#773830}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b369376270f8..6169aca6f508 2020-06-01 jmadill@chromium.org Update dirty bits flow example. 2020-06-01 plamoureux@google.com Move ShaderVariable utility function from utilities.cpp ShaderVars.cpp. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I447f2ba857842dca3ea293d2dbf4315d35b2efb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225436Reviewed-by:
-
Ken MacKay authored
The resampler may still have some non-zero data buffered, so we need to flush it to avoid a pop. Therefore, provide one additional buffer of zeros before removing the stream. Bug: internal b/157599040 Change-Id: I2d366c733f2e4cc5df1c1d6011c3f5ab856e4120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225336Reviewed-by:
-
Jesse Schettler authored
ARC++ printing usage is still being analyzed, and one of the histograms is still brand new. Bug: chromium:1088573 Change-Id: I8b235bd91fc1f08851e618006b634edc5d50f70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224974 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#773827}
-
Paul Jensen authored
Instead of looking at ApplicationStateListener's |newState| param, use hasVisibleActivities() to determine if one of Chrome's activities is visible. Using |newState| causes spurious unregister then register events when flipping between Chrome's Activities (e.g. Bookmarks). Bug: 1030229 Change-Id: Id2ecb19fd612c3a71e49d87047e0eccd8f9859fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219668 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773826}
-
David Benjamin authored
These histograms measure Android devices with some broken CPU capability reporting. Net.HasBrokenNEON measures something we can likely get rid of now, but we haven't yet so extend it a bit. Net.NeedsHWCAP2Workaround measures something that we are *very* far from dropping, but I've extended it for two years (hardware lifecycles are long) to check back in then. Bug: 1089000, 1089009 Change-Id: I068b4c3cdd82579622344cf3cf543560bc299013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225381 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Joel Hockey authored
With my recent crrev.com/c/2189893 to create popups from apps as TYPE_APP_POPUP, rather than TYPE_APP, we are now showing the location bar on these popups which is not expected. TYPE_APP_POPUP should match the set of features from legacy apps, rather than those of popups. The legacy apps are already 'inheriting' from popups, with 2 differences: FEATURE_TITLEBAR: Popups will show this for non-trusted sites which are not in fullscreen. Legacy apps show this for all sites which are not in fullscreen. FEATURE_LOCATIONBAR: Popups will show this for non-trusted sites which are not in fullscreen. Legacy apps never show this. However they will display the CustomTabBarView when the URL navigates out of scope of the app. This CL renames 'LegacyApp...' function to 'AppPopup...', and modifies the TODO suggestion of having TYPE_WEB_APP and TYPE_LEGACY_APP which predates the creating of TYPE_APP_POPUP. It seems that the solution now would be to create legacy apps using TYPE_APP_POPUP rather than TYPE_APP. Bug: 1088300 Change-Id: I77044b62cc5ff88208d02df74af42b59783b78e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224473Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773824}
-
Moe Ahmadi authored
Overriding color of the icon in hovered and focused states (via overriding the background color of the masked image) seems to interfere with the CSS transition applied to the background color of the masked image. See below: :host(:not([iron-icon])) #maskedImage { ... background-color: var(--cr-icon-button-fill-color); transition: background-color var(--cr-icon-button-transition); ... } My attempts at recreating this failed https://jsfiddle.net/g9tj82af/7/ however, setting -cr-icon-button-transition: none; solves the issue Bug: 1087597 Change-Id: I7a0b8e704adf937be5d3cc75b0f1adb46111cf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225339Reviewed-by:Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773823}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33dbd656112d..67e50a6b5c59 2020-06-01 johnstiles@google.com Allow printf-style formatting to be used in SK_ABORT. 2020-06-01 herb@google.com Make fMaskFormat private 2020-06-01 nifong@google.com Additional tests covering parts of path interface 2020-06-01 lingyun.cai@intel.com Add AVX2 implementations for SkSwizzler opts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I68afa7b1eb264e302b0de82991492f3e069cbbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224018Reviewed-by:
-
Haiyang Pan authored
Also disabled them in network_service_out_of_process_content_browsertests Also use separate filters on M and P for content_browsertests since failed tests on them start diverging Bug: 1056325, 1081969 Change-Id: Ida0a29736eb9a5532f29942de8a68a4c30ed2c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225155 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#773821}
-
Stefan Zager authored
The iframe's root graphics layer should not be treated specially; it should be incorporated into the regular GraphicsLayerTreeBuilder flow. This has the added benefit that it's not necessary for the iframe element in the parent document to be composited. A future CL will stop compositing iframe elements by default. Change-Id: I9bcfdc2384b072601c87786b269a32d86d7973e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220868Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#773820}
-
Charlene Yan authored
Bug: 1018230 Change-Id: I837514789ae6809c3d2eb8f3927837c48c416eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209236 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#773819}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9a0423c5f727..da87b8d8b0a1 2020-06-01 bryan.bernhart@intel.com Support forcing storage buffers to be always declared as UAV. (#1076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ia6abe3ece2f49a44f6273b22b86e4601214516f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225306Reviewed-by:
-
