- 09 Sep, 2020 40 commits
-
-
Fredrik Söderqvist authored
No longer flaky. Tbr: schenney@chromium.org Fixed: 874567 Change-Id: I5979dd0fc541966f4ed67c359f73132ede7f46d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400458Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805254}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fd05605bef1c..a187dd58a048 2020-09-08 stevenperron@google.com Allow SPV_KHR_8bit_storage extension. (#3780) 2020-09-08 stefanomil@google.com spirv-opt: Add function to compute nesting depth of a block (#3771) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC ianelliott@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: ianelliott@google.com,radial-bots+chrome-roll@google.com Change-Id: I095c18f1adb30ac352ab53166f044905bff9614c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805253}
-
Trent Apted authored
These were slightly different when the duplication happened in r790679, but they appear to be identical now. Change-Id: I9e15f8c63084d2d98cf0c03695e87bc9392eb9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397980Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#805252}
-
Kent Tamura authored
It has a circular dependency with modules/mediastream. The dependency is safe because these targets are in a single library. This CL has no behavior changes. Bug: 800764 Change-Id: I663ae35586865c65f5ced2eaac92737136684f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398445 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805251}
-
Ye Kuang authored
Follow up of https://crrev.com/c/2400058 Bug: 894045 Change-Id: Id5837c7d742c060f1e2b7e969a7d337b193676f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400578 Auto-Submit: Ye Kuang <yekuang@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805250}
-
Maksim Moskvitin authored
This reverts commit 73ac7d88. Reason for revert: new tests consistently crashes on Mac builders, see crbug.com/1126379. Original change's description: > Keep DevTools navigator.language in-sync with chromiums app language > > DevTools is considered part of the Chromium UI, so it should be > displayed in the same language as the Chromium UI and not the configured > accepted language (chrome://settings/languages). > > This CL moves the code where we override the DevTools renderer > preferences around so it works consistently across platforms. It also > installs an event handler in case the user changes his language settings > so `navigator.language` has consistently the same value in the > DevTools renderer. > > R=petermarshall@chromium.org > > Bug: chromium:1125490 > Change-Id: Iaac568d82357d6ae7c50d5022d687f4f1741b147 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398538 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805219} TBR=caseq@chromium.org,petermarshall@chromium.org,szuend@chromium.org Change-Id: I5d80fbfce70fd62336b15beb0d29a7bbe09ba6fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1125490, chromium:1126379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400280Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#805249}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8ae7fa12aa0..209d12c8b5b4 2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e96bb06c to 02f4f19d (359 revisions) 2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 07d44b97cf65 to 41c93c550b07 (9 revisions) 2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 10121443c16d to 5f71fdf34b76 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1125354 Tbr: reed@google.com Test: Test: Test: angle_unittests.exe --gtest_filter=AtomicCounterBufferTest31.AtomicCounterBuffer* Change-Id: I4f7cab37a9580232c55473ddc8dfb94d02768e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805248}
-
arthursonzogni authored
RenderFrameHostImplBrowserTest defines: web_contents(). Tests can uses it, this is shorter and avoid doing many static_cast everywhere. This patch updates all the tests. This removes a lot of noise. This is 97 line shorter and ~50 static_cast are removed. By updating the whole file, goal is to make others start using it, instead of copy-pasting the old lines over and over. Bug: NONE Change-Id: Id06e69150ace6d9ba70983411c4830cfa4012a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396117 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805247}
-
Maksim Moskvitin authored
This reverts commit 7f67680c. Reason for revert: seems to cause telemetry_perf_unittests failing on Mac (crbug.com/1126367). Original change's description: > Roll Perfetto Trace Processor Mac from 6b0afc48ae3d to 9d7944292456 > > https://android.googlesource.com/platform/external/perfetto.git/+log/6b0afc48ae3d..9d7944292456 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: perfetto-bugs@google.com > Change-Id: If390c64139c1b24b220b4c0866bb26f9e6fb0db5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399439 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#805080} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I6da871dd14e028bdf536ef2ae8457f31774dc3af No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400479Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#805246}
-
Joel Hockey authored
This reverts commit 3c2af663. Reason for revert: Test updated to hopefully fix flakes Original change's description: > Revert "Convert crostini and plugin VM shared paths settings lists to iron-list" > > This reverts commit 552c5361. > > Reason for revert: Breaking "browser_tests" failing on builder "linux-chromeos-rel" (specifically OSSettingsCrostiniPageTest.SubPageSharedPaths). See attached bug (https://bugs.chromium.org/p/chromium/issues/detail?id=1126295). > > Original change's description: > > Convert crostini and plugin VM shared paths settings lists to iron-list > > > > iron-list provides better focus management for tab/chromevox navigation. > > > > Bug: 1096143 > > Change-Id: Icaf2d27da606c9792a5aef9ac27226a77c63e76a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390939 > > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805101} > > TBR=khorimoto@chromium.org,joelhockey@chromium.org > > Change-Id: I6ada643aa15046f223417a72518269a643221152 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1096143, 1126295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398446 > Reviewed-by: Patti <patricialor@chromium.org> > Commit-Queue: Patti <patricialor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805194} TBR=khorimoto@chromium.org,patricialor@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1096143 Bug: 1126295 Change-Id: I6e793f762f9a3ba46d68ea095a1dde1284bebbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398045Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805245}
-
Ye Kuang authored
This is supposedly a transient config until CAS support. So far only the staging builders need to override this (to dev host). This CL adds the property to goma and webrtc builders. Bug: 894045, 1126307 Change-Id: I7cff2541d919fc1ad46be5dd550aad208fdb1ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400058Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#805244}
-
Maksim Moskvitin authored
Bug: 1094326 Change-Id: Iba070069d1dfc82f450defccf2eebf4d9b46480c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390908 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#805243}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca9078f199ff..b7a88f49d2ab 2020-09-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-09 alexrudenko@chromium.org Move inspector overlay unit tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iccce91aa717a44e0afa67d8807a225330ef6dcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399870Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805242}
-
Fumitoshi Ukai authored
when enabled java, errorprone for NoRedundantFieldInitCheck fails. disable use_java_goma as it is not a priority for now. Bug: b/167942918, 726475 Change-Id: I1e864ae881225bca4879b7aa3f47af5ddc8ac54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398864Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/master@{#805241}
-
Tanmoy Mollik authored
Bug: 1125810 Change-Id: If12ce4eaef778e39d1b8c476be428b1a8721dbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398683Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805240}
-
Maciej Malinowski authored
The GlobalDumpGraphConverter is converting between the Perfetto type GlobalNodeGraph and Chromium GlobalDumpGraph. Using this class it is possible to use produced by Perfetto GraphProcessor graphs in Chromium. See crbug.com/1095982 for more details. Bug: 1095982 Change-Id: I8bda59287a07d3759ca6da1037ecb6bfbad6439f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299745 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#805239}
-
jchen10 authored
Currently when only swapchain size changes, we attempt to resize the buffers of current swapchain to avoid creating a new swapchain. But this can lead to video glitches on Intel platforms. Bug: 1116542 Change-Id: I1627d97da69928304cbb7b89e5691ff0683cffd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394957Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#805238}
-
Matt Falkenhagen authored
The signature had been ported to the components class but the function itself was removed. Bug: 1106294 Change-Id: I74a959468fc32024a86e95fc1651eae670eb7d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397117Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805237}
-
Ioana Pandele authored
This CL adds a delay to status updates whenever multiple updates are notified to the mediator in a short time window. The minimum time interval between updates is set to 1 second. Bug: 1122026, 1092444 Change-Id: I64d9c95a11a5ed9b9d6fcf8941c260bf8b3a64ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390642Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#805236}
-
Eugene Zemtsov authored
Bug: 1124897 Change-Id: Idede30d03e3c0aadf78a9386553d81a638c369c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399750 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#805235}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/10121443c16d..5f71fdf34b76 2020-09-09 capn@google.com Fix component swizzle for uniform texel buffers 2020-09-09 sugoi@google.com Allow alphaToCoverage with a single sample If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie26a2ec666c90ade39183d9d942f33934f39ee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805234}
-
Xinghui Lu authored
Add SafeBrowsingEnhancedProtectionAndroid, server-side CL: http://cl/330537550. Add WebProtectRealTimeURLCheck, server-side CL: http://cl/330538388. Remove some stale testing configs to avoid Windows' 32767 character limit. These studies were already launched and enabled by default: SafeBrowsingRealTimeUrlLookupEnabled SafeBrowsingRealTimeUrlLookupEnabledAndroid SafeBrowsingRealTimeUrlLookupEnabledAndroidAllDevices Bug: 1097310 Change-Id: I2b241b0d7157915a370996f86e90785165588f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399440 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805233}
-
Xing Liu authored
This reverts commit 7da3d4aa. Reason for revert: This CL doesn't fix the bug, and it's not needed. Original change's description: > Download notification: Never call stopForeground without startForeground. > > This CL adds a boolean check for stopForeground that if startForeground > is not called, then ignore stopForeground call. > > Bug: 1121096 > Change-Id: I71295038925947472b0df7be2630a7cffbb79f97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386421 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803529} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org,qinminusc@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121096 Change-Id: I2871266fe482a11f48b21b9bda778444b4f72a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398987Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805232}
-
Yan authored
Current fast path for webgl uploading video frame is to render YUV planars to a RGBA8 intermediate gl texture, then do gpu to gpu copy to update the dst webgl texture. It is possible to optimize the uploading path by drawing YUV planars to SkSurface backed by dst webgl texture directly. This will save the extra gpu-gpu texture copy. BUG=1108154 Change-Id: I81598aa864337bc6ce944b09e26542c22ec073eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384337Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#805231}
-
Alice Wang authored
This CL sets up correct icon for sign-in auth error. Bug: 1120308 Change-Id: I56f65ba780298bf36950164c0823652e7d9a9aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382121Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805230}
-
chrome://signin-internalsJun Kokatsu authored
This change removes innerHTML usage by changing it to textContent. This make the page compatible with Trusted Types. Bug: 1125965 Change-Id: I0f01d25ef3e001be1c1aa6d056b0a5b72da99592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399821 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805229}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599544645-d1be9de4019833ccd2c919c2308fdd2d63a2121c.profdata to chrome-win64-master-1599609504-6aed31ad43427a24d3f18572e204bc1984bf6c08.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I283f71f1608401d67b36a18c6795904f257d09f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399878Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805228}
-
Jan Wilken Dörrie authored
This change re-enables the base::Bind PRESUBMIT check in the password manager and autofill component and removes last usages of the deprecated API. Bug: 714018 Change-Id: Ib9d8b97533e3421c5ee1b32f47455a135581bee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396301 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#805227}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a67d868f6c11..ca9078f199ff 2020-09-09 alexrudenko@chromium.org Move unittests karma config out of the frontend folder 2020-09-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba1501362b2a806509f3dffb5e8492fb915a50c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805226}
-
Matt Falkenhagen authored
* PrerenderRenderFrameObserver::SetIsPrerendering() was only calling PrerenderHelper::SetIsPrerendering() when mode != kNoPrerender, and the function just early returns in that case. Therefore, delete PrerenderHelper::SetIsPrerendering(). * Also mark some code only used by tests as test-only code. This is a bit uncomfortable since we might be needing this code as prerender gets revisited. However, I found it confusing that the caller was calling the callee only when the callee ignores the call, so think it's constructive to simplify this. This also reveals that PrerenderURLLoaderThrottle::PrerenderUsed() is never called, but I won't traverse into there since we might want the code. Bug: 755921 Change-Id: I486e78066350c8a20c63fdca3feb1344766c6b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396057 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#805225}
-
Matt Falkenhagen authored
As far as I can see, there's no need to assign these specific values, so remove them. Change-Id: I10c79593c0a115f9f5cf672ea085d2390f5c6083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395316Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805224}
-
Hiroshige Hayashizaki authored
Note: although the test case originates from crbug.com/1119729, this is NOT a regression test for crbug.com/1119729 that turned to be a DevTools issue (not a Fetch API issue). Bug: 1119729 Change-Id: Ica0a9d0c91314bf6ba54f3f73cb9f77cc0e94915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367580Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#805223}
-
Kent Tamura authored
It hsa a circular dependency with modules:modules. Usually a sub-module of modules:modules are allowed to have a circular dependency with modules:modules by |allow_circular_includes_from = sub_modules|. However, modules/serial was not listed in |sub_modules|. This CL makes modules/serial an item of |sub_modules|. This CL has no behavior changes. Bug: 800764 Change-Id: Icb8621ee0fecca124a03f84301838bd92c056f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398043 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805222}
-
Jan Wilken Dörrie authored
... fieldtrial_testing_config.json. Furthermore, this change removes the BrowserBlacklist experiment from the testing config in order to stay below Windows' 32767 character limit for command line arguments. Bug: 927473 Change-Id: Id5250e76bebbea4217b1b21a0973eaeca5cd0bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398506Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#805221}
-
Alice Wang authored
This CL moves the legacy add account icon from code to xml file. Bug: 948367 Change-Id: I286b2d0af8c6f26c4151f6936a4c9a354876420d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398269 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805220}
-
Simon Zünd authored
DevTools is considered part of the Chromium UI, so it should be displayed in the same language as the Chromium UI and not the configured accepted language (chrome://settings/languages). This CL moves the code where we override the DevTools renderer preferences around so it works consistently across platforms. It also installs an event handler in case the user changes his language settings so `navigator.language` has consistently the same value in the DevTools renderer. R=petermarshall@chromium.org Bug: chromium:1125490 Change-Id: Iaac568d82357d6ae7c50d5022d687f4f1741b147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398538 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805219}
-
Mitsuru Oshima authored
Bug: 1021902, 1120295, 1125849 Change-Id: I8b172db0da065ae6eb9127154d04b027bf79604b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393620Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#805218}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibece64247083feef35eed2f3e70e6e30990044fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805217}
-
Joel Hockey authored
Close destroys the CrosUsbNotificationDelegate and vm_name and guid args may be invalid after Close. Removed HexEncode calls around guid. I incorrectly added these earlier when I was seeing garbage in the logs for guid and assumed it was binary. I should have looked into this more at the time and realized that guid was being deleted by the call to Close. Change-Id: Id5adeb8476773821d5725e6befe73203aabdffc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398444 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805216}
-
Chih-Hsuan Kuo authored
Chromecast creates MemoryPressureMonitor and evaluator itself in CastBrowserMainParts::PreMainMessageLoopRun and that it conflicts with Chromium adding a MemoryPressureMonitor in the following CL and causes a fatal error when creating MemoryPressureMonitor: https://chromium-review.googlesource.com/c/chromium/src/+/1386856 Bug: 1125990 Test: Pass CQ Change-Id: I8fb76f6fcbc725b9b5e252898dc8d75a17d41bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397990Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Cr-Commit-Position: refs/heads/master@{#805215}
-