GitLab

This reverts commit cd74eba0.

Reason for revert: Speculative revert due to DCHECK failures in linux-chromeos-dbg

Bug: 929785

Original change's description:
> Declare Chrome OS Account Manager for field trial testing
> 
> Bug: 816954
> Change-Id: I4ee640075af0948cbb8b5bfcc127123348cad98b
> Reviewed-on: https://chromium-review.googlesource.com/c/1426779
> Commit-Queue: Kush Sinha <sinhak@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629940}

TBR=isherman@chromium.org,sinhak@chromium.org

Change-Id: I3d89e1e798164bc774c084e867e7cbd969487063
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816954
Reviewed-on: https://chromium-review.googlesource.com/c/1459326Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630035}

This change removes a bunch of flags from flag-metadata that have already been
deleted from other source files.

Bug: None
Change-Id: I0d4dad01a01dc175d1003e68c25745bc674d85f6
Reviewed-on: https://chromium-review.googlesource.com/c/1458677
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630034}

Currently when DecryptingDemuxerStream is selected, we only have
"video_dds = true" in MediaLog, which isn't obvious for readers. This CL
adds an explicit log event to make it clear.

Unit test is not updated because it's not trivial to set when we expect this to
be logged. For example, even with encrypted stream and a valid Decryptor, we
don't expect this log when decoder initialization failed.

Test: Manually tested. See note above.
Change-Id: If2149cd73c51916f1aa55e6f073ed2f73d65f28a
Reviewed-on: https://chromium-review.googlesource.com/c/1457432Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630033}

Increases the amount of time between polling for scroll quiescence to
500 ms to ensure that the scroll actually started and actually finished
(as opposed to being temporarily frozen due to scroll jank). Scrolling
was taking longer to start on Vega than on smartphones, which was
flakily causing the wait for scroll quiescence to finish before the
scroll actually started.

Bug: 876946
Change-Id: I5d77be8c224bedc7ed6e0d96204307c93366cb0f
Reviewed-on: https://chromium-review.googlesource.com/c/1456209Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630032}

Preparation for introducing a separate singleton class that builds the
font unique name lookup table. The UMA methods will be used by both, so
they need to be in a separate file.

No functional changes.

Bug: 889864
Change-Id: Ib8dcdda2a13323db185b65f13dc26222d05d9532
Reviewed-on: https://chromium-review.googlesource.com/c/1456008
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630031}

Bug: 929411
Change-Id: I4e25536f1ca51a5c8fbea87d8bd85e60b3fa99e5
Reviewed-on: https://chromium-review.googlesource.com/c/1457414Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630030}

This fixes the GCC build:

    ../../base/containers/any_internal.h: In member function ‘constexpr void base::internal::AnyInternal::operator=(base::internal::AnyInternal&&)’:
    ../../base/containers/any_internal.h:42:10: error: call to non-‘constexpr’ function ‘void base::internal::AnyInternal::reset()’
         reset();
         ~~~~~^~

reset() itself is not constexpr, and it is not clear if it should be given
it calls |delete_fn_ptr|.

Bug: 819294, 906125
Change-Id: I7760c62213db0e59a82e5210988ee469b5006090
Reviewed-on: https://chromium-review.googlesource.com/c/1458096
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630029}

NOTRY=True
TBR=charliea@chromium.org

Bug: 928796
Change-Id: I20e82d18cd4ceb9f02630ae04e3a8223dc9372b7
Reviewed-on: https://chromium-review.googlesource.com/c/1459318Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630028}

Change-Id: I8409f764a93d69d5dc0d8ee2575558fe83a68033
Reviewed-on: https://chromium-review.googlesource.com/c/1458688Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630027}

Following https://github.com/WICG/picture-in-picture/issues/116, it
would be great to allow video to enter Picture-in-Picture without user
activation if there's already a visible PiP window in the context of the
document, in other words if `document.pictureInPictureElement` is set.

Bug: 928697
Change-Id: I2c191368d8dd1bd6ddade719399d0679ef410575
Reviewed-on: https://chromium-review.googlesource.com/c/1454360
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630026}

No behavior change.

Bug: 926235
Change-Id: I731ae4f33079088d62b0748c99663fb9c5667fff
Reviewed-on: https://chromium-review.googlesource.com/c/1458680
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630025}

Changing use_gwp_asan to true on macOS wires in the call to
gwp_asan::EnableForMalloc in chrome/

Bug: 912286
Change-Id: Ic8d57464ba9d1c8cd81a79f02ec53ab2ed616c74
Reviewed-on: https://chromium-review.googlesource.com/c/1457227
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630024}

Bug: 790137, 790148
Change-Id: I887131fdd09852a8b400f797096971ce1fde1a76
Reviewed-on: https://chromium-review.googlesource.com/c/1457817
Auto-Submit: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630023}

Fixes a race condition in VrBrowserWebInputEditingTest#testSelectTag
on Vega (and probably other fast devices) where the click meant for the
modal dialog could happen so fast that it registered on the web contents
instead of the dialog, causing the dialog to be dismissed.

Bug: 876946
Change-Id: I043e19d49ce02e76de4b2447619f365e8dc90244
Reviewed-on: https://chromium-review.googlesource.com/c/1456940Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630022}

These are needed by supersize.

Also makes a couple minor optimizations:
 * Track .jar.info rather than .jar in merge_jar_info_files.py
 * Make create_final_jar_info() a dep of the final android_apk group(),
   rather than a dep of the create_apk() target.

Bug: 873714
Change-Id: I0ff452cbd19d07d6ee0a44c9b7def4e2c728ec3f
Reviewed-on: https://chromium-review.googlesource.com/c/1457430
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630021}

Change-Id: I4ce13d9ed00da78a8a715e0e45847fc1cfb3fe4e
Reviewed-on: https://chromium-review.googlesource.com/c/1457924Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630020}

This CL changes the security check for ElementTiming from same-origin to
TAO, which requires plumbing the OriginalTimingAllowOrigin attribute for
the case of 304 responses. It also removes bubbling to be consistent with
ResourceTiming. Some tests are fixed to properly use cross-origins within
external/wpt, and a cross-origin resource with TAO wildcard test is
added. More TAO tests will be added in a followup.

Bug: 928425, 879270
Change-Id: I4df40818823e3db9851fbc9586a0bda9c1adcfec
Reviewed-on: https://chromium-review.googlesource.com/c/1453074
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630019}

PDF, Image (png/jpeg/gif), and video (mp4)

Change-Id: I8e97b3dc376a599cb2900f5a31c8d5cfa1999623
Reviewed-on: https://chromium-review.googlesource.com/c/1457421Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630018}

These will be used by bots & diagnose_bloat.py for measuring binary
size.

Also updates related code in apk_operations.py:
 * Makes --output-apks required for build-bundle-apks
 * Adds --minimal for build-bundle-apks
 * Logs bundletool commands when in verbose mode

Bug: 873714
Change-Id: I6fb4bcc366110cacfd8e1b772db4ea1e00f81cc9
Reviewed-on: https://chromium-review.googlesource.com/c/1456223Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630017}

This patch ensures that clusterfuzz doesn't hit the web_test CHECK that
is ensuring we have accelerated compositing active. This can happen if
we're navigating and trying to capture pixels at the same time. However,
the pixel capture code would do a composite which in turn makes sure
this check "becomes true" by setting up a root layer.

So, it seems to be safe to just remove the CHECK.

R=lukasza@chromium.org, danakj@chromium.org

Bug: 919174
Change-Id: Ib5725c91b0cd827f8bfaf0e2266ad12de313f592
Reviewed-on: https://chromium-review.googlesource.com/c/1452781Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: vmpstr <vmpstr@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630016}

At touch sequence start, the white listed touch action may not have value
under certain corner cases, which is similar to the case when a touch
start is ack from the main thread (that the main thread touch action
may not have value). In this case, we explicitly set the white listed
touch action to Auto.

Unit tests are added to ensure correctness.

Bug: 904648
Change-Id: I9140f1f0625ab9b4f8c30765cd10324605b8db40
Reviewed-on: https://chromium-review.googlesource.com/c/1454089
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630015}

Currently we only support converting TimeDelta to/from Value, where
2 of the 3 references actually intend to store Time instead of
TimeDelta.

This CL adds functions to help convert Time to/from Value directly.

Also update CreateTimeDeltaValue() and GetValueAsTimeDelta() to use
FromMicroseconds() and InMicroseconds() instead of
FromInternalValue() and ToInternalValue() which are deprecated.

Bug: 917527,928787
Change-Id: Icb0543031ab4f526cfe835d52e85c28efba66863
Reviewed-on: https://chromium-review.googlesource.com/c/1449326Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630014}

This is in preparation for serving versioned test pages for
cross-version testing. For local serving, the extra '../' will
be ignored by the server.

Bug: 923149
Change-Id: Ieb23b397d331de6babc41c94132d1b924cec956d
Reviewed-on: https://chromium-review.googlesource.com/c/1455305Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630013}

There are no more users outside of the IdentityTestEnvironmentProfileAdaptor
class. This CL folds FakeSigninManagerForTesting into (and the helper classes)
the adaptor.

BUG=926948

Change-Id: I8d57947660eab6f217ba1f6cddf9b1baf64f1cc5
Reviewed-on: https://chromium-review.googlesource.com/c/1456516Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#630012}

It only has one non-test caller, and that caller always passes in a
valid |use_stale| parameter. Update the unit tests to pass in the
parameter as well. After that, change it from an out parameter to the
return value.

Change-Id: Ia7862d74363b052c18ed9f37d4253c5f515f1d5f
Reviewed-on: https://chromium-review.googlesource.com/c/1456987Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630011}

Bug: 922187
Change-Id: I7f8837f9d32672d33a4143d51c30f6997f0cd180
Reviewed-on: https://chromium-review.googlesource.com/c/1455618Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630010}

Specify the relevant metrics cthomp reviews in the OWNERS file, on the
same line so that `git cl owners` and similar tools will include it.

Change-Id: I37769bd88edadf77dce56f23da0002eef0546b73
Reviewed-on: https://chromium-review.googlesource.com/c/1453082
Auto-Submit: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630009}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ide4eafad476339e8993f95e7c28b052dc69cead3
Reviewed-on: https://chromium-review.googlesource.com/c/1458423Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630008}

Connect Java and native sides of JNI bridge for Get- and SetTokenMappings methods.

Bug: 923581
Change-Id: Ia800003a41a1daba5da776183ed5942dde7d9018
Reviewed-on: https://chromium-review.googlesource.com/c/1455109Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630007}

Switches chromeos::assistant::ChromiumHttpConnection from using
//net directly to using the network service (SimpleURLLoader).

Bug: 913757
Change-Id: If89b2eb49f66a0279d9b23c1533c15166c322110
Reviewed-on: https://chromium-review.googlesource.com/c/1380541Reviewed-by: Leo Zhang <googleo@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#630006}

In Applocation>Cache Storage, to preview a cached response, DevTools
needs to call requestCachedResponse() to the backend to fetch it.
Originally, DevTools is unable to fetch cached responses for requests
that have headers, and this is because in DevTools's beckend, the field
'headers' of mojom::blink::FetchAPIRequest remains unfilled. This
patch fixes the issue by filling this field.


Bug: 890359
Change-Id: I599cc1393d5c02baa7d7f90fc22fd379b1745090
Reviewed-on: https://chromium-review.googlesource.com/c/1455272Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630005}

Mask execution closely follows background execution, which results in the
size of the mask being reduced to the exact size requested, rather than
filling out the dest_rect in BackgroundImageGeography::SetNoRepeatX and
::SetNoRepeatY. This CL puts the mask in the correct location, then
when we are creating the shader in image.cc, if the mask doesn't fill
out the dest_rect, decal tilemode is used to fill the rest with
transparency, which allows the mask to fill the full area.

Regarding the change to the fast/backgrounds/mask-composite.html test:
This change results in the original test failing, displaying the same
thing that it displays when using source-out. Based on my understanding
of how the 'copy' Porter-Duff keyword works, I believe this is correct
and that the test previously had an incorrect baseline because of this
bug. My understanding is that, if mask-composite is 'copy', then regardless
of the number of masks, only the first one will be displayed. The PD
definition of copy is that only the source mask is displayed, and since
this would be applied starting from the last two masks listed, moving up
to the first two, the end result is that only the first mask is displayed.
And, since this matches what happens when mask-composite:source-out is
used (and matches Edge and Firefox using 'subtract'), I just changed it
to a likely more commonly used keyword.

Bug: 917067
Change-Id: Ic9174ea67d92abe6b78acf9b7f2640796d30d249
Reviewed-on: https://chromium-review.googlesource.com/c/1447261
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#630004}

web_tests/animations/animationworklet/worklet-animation-local-time-after-duration.html -> web_tests/external/wpt/animation-worklet/worklet-animation-local-time-after-duration.https.html
web_tests/animations/animationworklet/worklet-animation-local-time-before-start.html -> web_tests/external/wpt/animation-worklet/worklet-animation-local-time-before-start.http

Bug: 915352
Change-Id: Ic24945fc071ebc9aada2cf925fcb07b111d23a99
Reviewed-on: https://chromium-review.googlesource.com/c/1446566Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#630003}

|ObfuscatedFileUtilDelegate| and |ObfuscatedFileUtilMemoryDelegate|
are added to support in-memory file system for incognito mode and
|ObfuscatedFileUtil| is updated to choose the appropriate delegate
based on being incognito or not.

To avoid making the CL large, only the skeleton of the
|ObfuscatedFileUtilMemoryDelegate| is added in this CL and the actual
implementation will be added in a next one.

The change is part of the following design doc:
https://docs.google.com/document/d/17NV1cGSIEG2i5qm2QU4EzDMKRoyVEbNNq-Re-JhwSB0

Bug: 93417
Change-Id: I47353c656ab70ab6c98c8e06c9e0c3a03319d012
Reviewed-on: https://chromium-review.googlesource.com/c/1452176Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630002}

Web UI lock screen is not used anymore.

BUG=929466

Change-Id: I0984b3f6ccc7bb148784a56d7522393e9ef77a24
Reviewed-on: https://chromium-review.googlesource.com/c/1457656Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630001}

This flag was added as a means of swapping the ABIs of a 64-bit build,
to get a 64-bit browser instead of 32.  There are now build targets to
achieve the same thing, so the flag can be removed.

On a 64-bit configuration, you can now build:

- monochrome_public_bundle: 32-bit browser w/ 64-bit WebView
- monochrome_64_32_public_bundle: 64-bit browser w/ 32-bit WebView
- monochrome_64_public_bundle: 64-bit browser

BUG=907640

Change-Id: Id021645ac9b411510fdf23c09428d3d888a857f5
Reviewed-on: https://chromium-review.googlesource.com/c/1458360Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630000}

The fix was submitted in
https://android-review.googlesource.com/c/platform/external/perfetto/+/874695

So we no longer need to special case this instead we can just
delegate the call directly.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=839074
Change-Id: Ie6d6ee8d94b00f73b59dd95a90d2c29dd3f9a383
Reviewed-on: https://chromium-review.googlesource.com/c/1451942
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629999}

Bug: 910288
Change-Id: Icfbb9da91d5f15d53839e7a6b3de4dd084a37ab1
Reviewed-on: https://chromium-review.googlesource.com/c/1456977
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629998}

There are no flags to be updated.

--------------------------------------------------
Date:   Fri Jan 25 19:26:18 2019 +0000

Change SerializeHeadersFrameHeader() to take header frame length.

n/a (No functional change.)

Change SerializeHeadersFrameHeader() to take header frame payload length
instead of entire header frame payload, just like
SerializeDataFrameHeaders() already takes a length.  Also change
SerializeDataFrameHeaders() argument name from |length| to
|payload_length| for clarity.

Motivation:  Just like SerializeDataFrameHeaders(),
SerializeHeadersFrameHeader() does not need to know the entire frame
payload, only its length.  This is in contrast with Serialize*Frame()
methods that serialize the payload in addition to the frame header.

Merge internal change: 230937339

https://chromium-review.googlesource.com/c/1454132/


--------------------------------------------------
Date:   Fri Jan 25 22:34:31 2019 +0000

Set is_current_packet_connectivity_probing_ to false in the end of
QuicConnection::ProcessUdpPacket. Protected by default true flag
FLAGS_quic_reloadable_flag_quic_clear_probing_mark_after_packet_processing.

This should fix the flaky test in b/122963316, see
http://b/122963316#comment3 for more details.

Merge internal change: 230970486

https://chromium-review.googlesource.com/c/1454134/

Bug: 122963316

--------------------------------------------------
Date:   Sat Jan 26 12:14:43 2019 +0000

In QUIC, accept packet number 0 in v99. Protected by version 99 and
gfe2_restart_flag_quic_uint64max_uninitialized_pn.

Merge internal change: 231039835

https://chromium-review.googlesource.com/c/1455016/

Bug: 121265775

--------------------------------------------------
Date:   Sun Jan 27 01:47:29 2019 +0000

Progress towards allowing variable length connection IDs

This CL refactors some of the QUIC codebase to plumb the version to
more places. It uses that to introduce
QuicUtils::CreateZeroConnectionId which currently provides 64bits set
to zero but will eventually allow clients like quartc to use
zero-length connection IDs.

refactoring, no change of behavior, not flag protected

NO_BUG=n/a

Merge internal change: 231077921

https://chromium-review.googlesource.com/c/1455019/


--------------------------------------------------
Date:   Mon Jan 28 19:13:29 2019 +0000

(n/a) Change QUIC_LOG_ to function-like macros, these
macros are allowed to 'return' different values based on the current
QUIC logging threshold. No bahavior change, not protected.

Merge internal change: 231254026

https://chromium-review.googlesource.com/c/1455058/


--------------------------------------------------
Date:   Mon Jan 28 19:57:32 2019 +0000

Change frame type values for IETF QUIC

This CL changes the frame type values used for IETF QUIC.

In doing this, a bug was found in the test code to test the
construction of IETF QUIC BLOCKED frames. This error was fixed. After
the test was corrected, there were no bugs in the core QUIC code.

There are no other logical or functional changes.

N/A all code is for version99/IETF QUIC only and is flag protected.fayang

Merge internal change: 231263146

https://chromium-review.googlesource.com/c/1455059/


--------------------------------------------------
Date:   Tue Jan 29 19:14:31 2019 +0000

Add QUIC v47 which will use IETF draft-17 header format with
demultiplexing bit. Protected by BLOCKED
FLAGS_quic_reloadable_flag_quic_enable_version_47.

Merge internal change: 231437303

https://chromium-review.googlesource.com/c/1455296/

Bug: 118781128

--------------------------------------------------
Date:   Wed Jan 30 00:48:40 2019 +0000

Do not include "base/logging.h" to silent BUILD error because of
./base/internal/logging.h:347:32: error: comparison of integers of
different signs: 'const int' and 'const unsigned long'
[-Werror,-Wsign-compare]

n/a (include only change)

Merge internal change: 231499804

https://chromium-review.googlesource.com/c/1455298/


--------------------------------------------------
Date:   Wed Jan 30 15:40:40 2019 +0000

Actually use IETF draft-17 header format with demultiplexing bit in
v47. Protected by BLOCKED
FLAGS_quic_reloadable_flag_quic_enable_version_47.

Merge internal change: 231592167

https://chromium-review.googlesource.com/c/1455300/

Bug: 118781128

--------------------------------------------------
Date:   Wed Jan 30 16:03:14 2019 +0000

Enable quic version 47 for Quartc.

Quic version 47 adds draft 17 bit, which will allow for demuxing quic
from RTP.

n/a (Quartc only)

Merge internal change: 231595566

https://chromium-review.googlesource.com/c/1455301/


--------------------------------------------------
Date:   Wed Jan 30 16:06:50 2019 +0000

In QUIC, change ParsedQuicVersion(PROTOCOL_UNSUPPORTED,
QUIC_VERSION_UNSUPPORTED) to UnsupportedQuicVersion().

(n/a) Refactor only, not protected.

Merge internal change: 231596249

https://chromium-review.googlesource.com/c/1455303/


--------------------------------------------------
Date:   Wed Jan 30 21:01:47 2019 +0000

remove unused #include base/macros.h in platform api.

Merge internal change: 231652158

https://chromium-review.googlesource.com/c/1455066/


--------------------------------------------------
Date:   Thu Jan 31 15:00:32 2019 +0000

n/a (No functional change in tests only.)

Introduce and use IsVersion99() method in QuicSpdySessionTestBase,
QuicSpdyStreamTest, and QuicSimpleServerSessionTest, where long inline
comparisons were used before, and in QuicSimpleServerStreamTest, where
there was a bool member before.

This simplifies a lot of conditionals in these tests.  This is
particularily beneficial as cr/231494986 is about to add even more.

Merge internal change: 231779345

https://chromium-review.googlesource.com/c/1455071/


--------------------------------------------------
Date:   Thu Jan 31 15:15:32 2019 +0000

n/a (Test only change, no functional change.)

Remove some redundant Times() expectations in three test files that will be
touched by a future CL cr/231494986.

Only remove redundant Times(1) and Times(AnyNumber) expectation is
there is also a WillOnce() or WillRepeatedly() expectation, which
implies the Times() expectation according to
https://github.com/google/googletest/blob/master/googlemock/docs/CheatSheet.md#setting-expectations.
This is true regardless of whether the mock is a StrictMock or not.

Also change a Times(1).WillRepeatedly() to WillOnce().

Do not touch any Times(1) or Times(0) expectations if there are no WillOnce() or
WillRepeatedly(), because these are there to guide the reader.  (Even though
Times(1) is implied, and an expectation with Times(0) could be entirely removed
on a StrictMock.)

Merge internal change: 231781155

https://chromium-review.googlesource.com/c/1455072/


--------------------------------------------------
Date:   Thu Jan 31 15:17:58 2019 +0000

In QUIC, let v46 adopt QUIC bit header change, while v47 will be used
for CRYPTO frame change. Protected by BLOCKED
FLAGS_quic_reloadable_flag_quic_enable_version_46 and
FLAGS_quic_reloadable_flag_quic_enable_version_47.

Merge internal change: 231781497

https://chromium-review.googlesource.com/c/1455088/

Bug: 118781128

--------------------------------------------------
Date:   Thu Jan 31 15:48:32 2019 +0000

Only enable version 46 for Quartc, as v46 supports QUIC bit header now.

n/a (Quartc only)

Merge internal change: 231785372

https://chromium-review.googlesource.com/c/1455313/


--------------------------------------------------
Date:   Thu Jan 31 17:28:16 2019 +0000

Add QpackEncoder and QpackDecoder to QuicSpdySession only when using
QUIC version 99.  Not flag protected.

Merge internal change: 231799718

https://chromium-review.googlesource.com/c/1456278/


--------------------------------------------------
Date:   Thu Jan 31 21:13:58 2019 +0000

Use GetInvalidStreamId() instead of hard-coded 0s

In several places, the IETF-QUIC/Version99 code used hard coded 0s
to indicate an invalid stream id. This is incorrect. The 0s have
been replaced with QuicUtils::GetInvalidStreamId() calls so that
the correct invalid value is used.

N/A, all code is version 99/IETF-QUIC and thereby flag protected.

Merge internal change: 231839770

https://chromium-review.googlesource.com/c/1456279/


--------------------------------------------------
Date:   Fri Feb 1 17:24:43 2019 +0000

Pass the current connection to QuartcPacketWriter through PerPacketOptions.

This is mostly a nicer way to organize the relationship between the connection
and packet writer.  Under the previous arrangement, the connection registered
itself once with the packet writer and the packet writer assumed that it's only
used by that connection forevermore.

Under the new arrangement, the connection identifies itself whenever it sends a
packet.  Packets that are not sent by the connection will not cause confusion.

For example, the QuicDispatcher may send packets before a connection is created
(for version negotiation) or after it closes (rejecting the same connection id
for some time before allowing it to be reused).  Under the previous arrangement,
such packets could cause problems--there might still be a dead connection
registered with the packet writer.

This makes the QuartcPacketWriter usable with multiple connections.  Quartc
doesn't really need this (yet), but it's a nice benefit of organizing the code
this way.

n/a (Quartc only)

FIG_CHANGESET=011d79c4fbb12d50a6039d41a2fbad81f03c42be

Merge internal change: 231983473

https://chromium-review.googlesource.com/c/1456280/

Bug: 117157454

--------------------------------------------------
Date:   Sat Feb 2 00:08:37 2019 +0000

Deprecate FLAGS_quic_reloadable_flag_quic_limit_version_negotiation.

Also add a unit tests for doing version negotiation with a full size packet.

Merge internal change: 232055257

https://chromium-review.googlesource.com/c/1456281/

R=rch@chromium.org

Change-Id: If05c598e85bffe7933e5d404527a2acc358bcc59
Reviewed-on: https://chromium-review.googlesource.com/c/1456979Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629997}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: I17f40d166c9666826defa11278f8b32967fa67f6
Reviewed-on: https://chromium-review.googlesource.com/c/1458687Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629996}