- 16 Jul, 2020 40 commits
-
-
Raymond Toy authored
Add SSE2 optimization for the main processing loop for the a-rate Oscillator and for the computation in WaveDataForFundamentalFrequency. Profiling showed WaveDataForFundamentalFrequency was taking 27% of the total time. The optimized version takes about half as long by computing 4 results at a time. The failed test is caused by changing the linear interpolation formula from (1-f)*x0 + f*x1 to the mathematically equivalent x0+f*(x1-x0). However, this isn't exactly the same in floating-point. The updated formula has one less operation so it's a useful speed up. Using a float virtual_read_index in the SIMD loop causes significant loss of precision (50 dB or less in the osc sweep tests instead of 100+ dB), so we need to do a slightly more complex SIMD version with double virtual_read_index. WebAudio bench results without this CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Oscillator.frequency-linear-a-rate 1884 1884 1948 1969 1997 2598 1987.72 94.13 With this CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Oscillator.frequency-linear-a-rate 1348 1348 1397 1418 1453 2028 1474.74 151.59 We see about a 25% improvement in speed (based on the mean). Bug: 1013118 Change-Id: I818834c64c3529b26467dbaa7623354f92b47b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264204Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789097}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9277ee741395..82359f926f81 2020-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 4c33fb0d3dba to 7221ccf85e26 (5 revisions) 2020-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1de497cc50ab to 0a8f44c514ce (1 revision) 2020-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from b481744aea1e to 4f72970ed3e0 (1 revision) 2020-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 521eaacef67a to d093d9723b7c (2 revisions) 2020-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from d8f34456c819 to dd3511549b18 (1 revision) 2020-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04c82ec6f36f to 7548cbeabfa7 (100 revisions) 2020-07-15 cnorthrop@google.com Tests: Change screen orientation for traces on Android 2020-07-15 nguyenmh@google.com Add buffer serialization capability 2020-07-15 jonahr@google.com GL: Fix issue with EXTBlendFuncExtendedES3DrawTest 2020-07-15 jmadill@chromium.org Test Runner: Accept Chromium args. 2020-07-15 kbr@chromium.org Revise documentation on adding EGL extensions. 2020-07-15 cnorthrop@google.com Capture/Replay: More ES 3.1 support 2020-07-15 shrekshao@google.com Fix ANGLE_base_vertex_base_instance baseInstances type 2020-07-15 lehoangq@gmail.com Metal: Compile default shader source files separately. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1099763 Tbr: jonahr@google.com Test: Test: Capture from beginning of Asphalt 8 and Aztec Ruins Change-Id: Ib17f2109d49fbbf3ead187b3419396e68909722b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789096}
-
Miguel Casas authored
This CL follows up on the previous one making VASupportedProfiles GetSupportedVAProfiles() and AreAttribsSupported_Locked() file static. No new code intended. Bug: 1040291 Change-Id: If4ea4425eed2ce2e698b56f0c8dff127f52eacae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298482 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#789095}
-
Jia Li authored
Design doc: go/chrome-ml-service This creates the //chrome/services/machine_learning directory for adding the Chrome ML Service, and added definitions of the Mojo API and shells of service implementations. Bug: 1102416 Change-Id: I8e3bb3651b44afc8c82664c8ce7a00d27d1b7c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283227Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#789094}
-
behdad authored
Using the updated script in https://chromium-review.googlesource.com/c/chromium/src/+/2274097 the 5 percentile of recorded values for CPU_wall_time_ratio is recorded for each story, to be used as invalidation of failures. Bug: chromium:1052361 Change-Id: I4250452414b5dcebe734630c48397b55419e1347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275487 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#789093}
-
Sean Gilhuly authored
Many of the cc_unittests are already passing for SkiaRenderer Dawn. Enable all of the mirror, readback, scrollbars, synchronous, and tiles test cases. The partial raster test cases are failing on Linux, so set up a filter file for them. Bug: 1021566 Change-Id: I8d8212eccf3c9ff5cfe30fb55f92d9bda6d9d6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204406 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#789092}
-
Mario Sanchez Prada authored
This allows us to remove the translation between routingIDs and AXTreeIDs in RenderFrameHostImpl, as well as to remove completely AXContentNodeData and AXContentTreeUpdate due to no longer needing to pass routing IDs between the renderer and the browser process. A side effect of this CL, though, is that it is now necessary that the HTMLFrameOwnerElement that hosts the frame tree for an inner WebContents (e.g. a <webview> or a portal) has the EmbeddingToken of the main frame it is embedding set, as it already happens for both same-site and cross-site iframes. For this reason, this CL also adds a small change in RFHI::SetEmbeddingToken() in order to make sure that the EmbeddingToken of a local main frame of an inner WebContents gets properly propagated to the owner element in the parent outer WebContents. Additionally, this CL adds a helper method GetEmbeddingToken() to Blink's Element and WebElement classes which allows retrieving the EmbeddingToken out of an Element if it's set in a clean way, something that is only the case for HTMLFrameOwnerElement for now. Bug: 1094150 Change-Id: I25e5fbad934487602136136c02ebc1ef05b14755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270065 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789091}
-
Peter Wen authored
Removed //media* from the allowlist and added missing deps. Bug: 1092528 Change-Id: Iba92cca4d986b28aadd081a3f2adc838dff71c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302450 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789090}
-
Min Qin authored
BUG=1104628 Change-Id: Ief8b14f4b0f915b30ca28eb22612ffc5c7c00d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298224Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789089}
-
Joey Arhar authored
Multiplying by the device scale factor is needed to fix tests which are using hard coded pixel coordinates for the new --force-device-scale-factor=1.5 tests. Bug: 1068400 Change-Id: I1862fdfbcc72278d5495864a0df4c0a54af87e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298339Reviewed-by:
-
Haiyang Pan authored
This reverts commit a1a087cf. Reason for revert: PortalsTest#testTouchTransferAfterReactivation flakily fails in https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel and https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel. For example: https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1499 https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1502 https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1243 https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1244 Original change's description: > Reland "Portals: Fix flakes in testTouchTransferAcrossReactivation" > > This is a reland of c615367a > > Original change's description: > > Portals: Fix flakes in testTouchTransferAcrossReactivation > > > > The flakes were caused by crbug.com/1098773. As a workaround until the > > issue is fixed, this wraps the activate call in a setTimeout. > > > > Bug: 1024850 > > Change-Id: I36e2b948818d81578acc97a9a60758b281ff6764 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264856 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#782379} > > Bug: 1024850 > Change-Id: Ie6ad8a764f493de62cc2ab25f8b48b5d3c22375b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295835 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788863} TBR=dtrainor@chromium.org,adithyas@chromium.org,lfg@chromium.org Change-Id: I03416bf69a6d3b0f93ace7461c73fc582ce0d69a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302715Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#789087}
-
Daniel Nicoara authored
Need to query for the capability otherwise the browser process won't create a fence object and pass it in for presentation. The GPU process expects this fence as the synchronization primitive when supported. If it isn't provided the submitted buffer may be presented before the GPU finishes rendering into it. BUG=1097320,1083171 TEST=Manually on device and checked for tearing with passthrough command decoder. Change-Id: Ic1449d0fa0c0178078a88ac78fb38d94d950a11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300810Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#789086}
-
Giovanni Ortuño Urquidi authored
Create test with custom data source. Bug: b:159927590 Change-Id: I69fad503e8927cf3ea46e8c6cc47680f8af099f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283033Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#789085}
-
Xianzhu Wang authored
We should snap to pixels for foreign layer offsets. Most of the offsets of the layers were already integral. Only added RoundedIntPoint in places: WebPluginContainerImpl and RemoteFrameView, which is consistent with other places about pixel-snapping of replaced contents, e.g. CompositedLayer::UpdateContentsRect(). Change-Id: I1749088c05f0aaf81f10efae744c6e81dd3965c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300827 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789084}
-
Haiyang Pan authored
Bug: 1105423 Change-Id: If6f818d9414968f038feb62038cd6072c64bfe1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300822Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#789083}
-
Karandeep Bhatia authored
- Remove references to update-docs.sh. It was the same as update-docs-full.sh. - A new script update-docs-cloud.sh was added to the VM instance for just updating the GCS buckets. Modify the documentation to refer to it. BUG=None Change-Id: I4ed85772b332801ece36f9303a44d067b97ad8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301200 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789082}
-
Oleh Lamzin authored
Allow everyone to modify src/chromeos/components/BUILD.gn. Change-Id: Ib15be316a55a8f79b9f8fc95820f1aca925c9242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300379 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789081}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e9e8c01f3c5a..78a6bf63710d 2020-07-16 sebmarchand@chromium.org Revert "Roll git to 2.27.0 on Windows" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1070694 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9d1325c9fa8f13c1a6307aefffbc433d921a607c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302391Reviewed-by:
-
Haiyang Pan authored
This reverts commit f55cd37e. Reason for revert: The tests testAuthenticatorImplGetAssertionBridge_resultCanceled and testAuthenticatorImplGetAssertionBridgeWithUvmRequestedWithUvmResponded_success in org.chromium.chrome.browser.webauth.Fido2CredentialRequestTest consistently fail on android-pie-x86-rel since https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1498. This CL is the only one that touches authenticator_impl around that time. Revert it to see if it can fix the failure Original change's description: > fido: make AuthenticatorTestBase set the MOCK_TIME TaskEnvironment trait > > This allows us to get rid of base::Timer injection into > AuthenticatorCommon, which tests used to wait for requests to time out. > > Also get remove a number of superfluous RunUntilIdle() calls, and of > calls to OverrideLastCommittedOrigin() where SimulateNavigation() would > suffice. > > Change-Id: I8cb4980d51efe43f59d828cde5f34ce67d38d928 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299630 > Auto-Submit: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Adam Langley <agl@chromium.org> > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#788885} TBR=agl@chromium.org,jsaul@google.com,martinkr@google.com Change-Id: I47c8796582f40f1946811b5eca4ae3cdfe5aac0f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303030Reviewed-by:
-
Jonah Ryan-Davis authored
This reverts commit 56f7b697. Reason for revert: win-asan failures https://bugs.chromium.org/p/chromium/issues/detail?id=1106392 Original change's description: > [Sync] Postpone reupload of bookmarks until next updates received > > When reupload is initiated after loading from the disk right away, it > may lead to upload bookmarks which were removed from the other device. > This would restore removed bookmarks. In practise it may be caused by > some devices which a rarely used. > > Initiating reupload after receiving latest updates from the server helps > to prevent such behaviour. > > Bug: 1061411 > Change-Id: Ibc5646b19bf133de496140fa152b544bc06ebcf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299721 > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788775} TBR=mastiz@chromium.org,rushans@google.com Change-Id: Ib00d0dfc3cd570aaf1081482cf1bd727b3dbdf8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302773Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#789078}
-
Nicolás Peña Moreno authored
This CL updates 2020 Q2 progress and adds Q3 objectives. Change-Id: Ia65bb468c7f617d62d80e8ecc034754c5531a4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295758Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789077}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0a8f44c514ce..e8dd233c7a85 2020-07-16 cwallez@chromium.org Fix B<->T copies of multiple array layers and unpacked rowpitch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id8d18a7898b400b8a47c0842bbbe21739ed54879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302390Reviewed-by:
-
Joshua Berenhaus authored
This relands the change as well as fixes the Linux CFI issue. ScaledLinearHistogram is a wrapper around LinearHistogram but the Linux CFI disallows base-to-derived cast to the wrong dynamic type. Thus we need to cast explicitly to BaseHistogram so that a ScaledLinearHistogram can be a DummyHistogram. Bug: 1088051 Change-Id: If4f4cfdaaaf40e2a640cc1e972c676f73da6ca33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296633 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789075}
-
Lukasz Krakowiak authored
This change replaces base::RunLoop::QuitCurrentWhenIdleClosureDeprecated() call with a loop->QuitClosure() call on local RunLoop instance. R=wez@chromium.org Bug: 922118 Change-Id: Ifb9717fd538252fc17017a81b32c41e6e154109f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236137 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#789074}
-
Alice Wang authored
Change-Id: If6ff8df4df7b8ab8002a6e02c7d8d438b56ebe7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299224Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789073}
-
Pâris MEULEMAN authored
This test was not run following the refactoring of IdentityManager that happened end of 2019. This reinstate the test, requiring some change as the identity and signin test helpers changed: |AccountManagerTestRule| was moved in //chrome and is not accessible anymore. Bug: 1091510 Change-Id: I845b4761bf13e1f219de1024d002ccaedd471663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292453 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The binary XCTRunner will change if the version of Xcode changes, but the timestamp and the input paths may not be reliable signals to determine whether the target is dirty. Force the command-line of build/config/ios/strip_arm64e.py to be different if the version of Xcode changes. This will force ninja to consider the target as dirty and will force using the correct version of the binary (even if older than current output). The parameter is ignored by the script, it is there only to force ninja to consider the target dirty: $ ninja -C out/Debug-iphoneos -d explain ... ninja explain: command line changed for obj/build/config/ios/XCTRunner ... Bug: 1101531 Change-Id: Iaf2baf8eadc2e5b3c66848d5f9be9638c5b44dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301975 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789071}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06980dba90a4..2b4404b14b04 2020-07-16 mtklein@google.com JIT to_half/from_half 2020-07-16 bsalomon@google.com Revert "Don't avoid disabling subset for planar image draws" 2020-07-16 egdaniel@google.com Using staging buffers for vulkan texture uploads. 2020-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4ad0f250a010 to 6fe87f4a226d (14 revisions) 2020-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1de497cc50ab to 0a8f44c514ce (1 revision) 2020-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from b31f5e717e2d to 1b9b53a39576 (9 revisions) 2020-07-16 fmalita@chromium.org [skottie] Fix mask difference 2020-07-15 jvanverth@google.com Change hairline pathrenderer to avoid vertex buffer reads. 2020-07-15 robertphillips@google.com Switch the DDLRecorder over to holding a GrRecordingContext ... 2020-07-15 bsalomon@google.com Rename GrSamplerState::Filter::kBilerp to kLinear 2020-07-15 bungeman@google.com Remove SkFontArguments::Axis. 2020-07-15 mtklein@google.com a bunch of half-related stuff 2020-07-15 elliotevans@google.com Fix experimental_simd CanvasKit build. 2020-07-15 adlai@google.com Remove makeSubset compatibility flag 2020-07-15 egdaniel@google.com Reland "Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)" 2020-07-15 bungeman@google.com Implement SkFontMgr::onMakeFromFontData in subclasses. 2020-07-15 michaelludwig@google.com Support releasing blocks while iterating them 2020-07-15 jvanverth@google.com Add new GM to test hairline subdivision. 2020-07-15 jlavrova@google.com add SkParagraph to public headers and fix warnings 2020-07-15 fmalita@chromium.org [skottie] Improved pucker/bloat center heuristic 2020-07-15 michaelludwig@google.com Generalize iterator in GrTAllocator to be useful for other data types 2020-07-15 adlai@google.com Reland "Add a direct context arg to makeColorTypeAndColorSpace" 2020-07-15 mtklein@google.com minor skvm cleanup 2020-07-15 brianosman@google.com Clean up some boilerplate in runtimeshader.cpp 2020-07-15 mtklein@google.com add store(PixelFormat,...) 2020-07-15 mtklein@google.com generalize skvm pixel unpacking 2020-07-15 michaelludwig@google.com QoL improvements to GrTAllocator 2020-07-15 herb@google.com Reland "rename MakePath to Make" 2020-07-15 bsalomon@google.com Don't avoid disabling subset for planar image draws If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1070089,chromium:1099763,chromium:1105202 Tbr: nifong@google.com Test: Test: Test: Capture from beginning of Asphalt 8 and Aztec Ruins Change-Id: Icdcffce483bc4f282e6a7c9e1b446d75834d37f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302220Reviewed-by:
-
Shimi Zhang authored
There is no need to use this flag, we can check |mInvalidationRunnable| is null or not directly. Bug: 836558 Change-Id: Ib82786489ff6963825f021a1f537e7b61a20ab30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300997Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789069}
-
Liquan (Max) Gu authored
Before: * The implementation of PaymentAppComparator lived in PaymentRequestImpl. * Its internal methods were visible to the whole PaymentRequestImpl. * Although it only requires 4 parameters of PaymentRequestImpl, it depends on the whole PaymentRequestImpl. After: * The implementation of PaymentAppComparator lived in a separate file. * Its internal methods are not visible to PaymentRequestImpl. * Its dependencies on PaymentRequestImpl are explicitly passed in through the constructor. Bug: 1102522 Change-Id: Ia8cb0611de83a2ef5b7d97943e3334156d2bb08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299857 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789068}
-
Numfor Mbiziwo-Tiapo authored
Change-Id: I4932d737c4895d2cb4ebfee07b31b306f2580fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300010Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#789067}
-
Doug Arnett authored
Bug: 1093320 Change-Id: I55789e32c2de0c91767c37377be46cdc213a8d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297817Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#789066}
-
Chunbo Hua authored
Due to https://crbug.com/345569, hardware encoders do not distinguish between Constrained Baseline Profile and Baseline Profile from VideoCodecProfile. Here, a new flag is added to VideoEncodeAcceleratorConfig to tell whether the current H.264 profile is constrained or not. Bug: 982799 Change-Id: I47ee56949eec43922c7eb8338a6873c8285bb602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278847Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Charlie Hu authored
This CL split the DocumentPolicy negotiation mechanism out from DocumentPolicy runtime flag so that DocumentPolicy can be shipped without the negotiation mechanism, which includes: - Request HTTP header: Sec-Required-Document-Policy - Response HTTP header: Required-Document-Policy - Iframe attribute: policy Change-Id: I789fdeab9232ff7d69814af0ea478cc4d5f128a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287814Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#789064}
-
Mark Brand authored
Temporary fix until the debug build can be properly fixed. Bug: 1105964 Change-Id: I7651acc7367ea675f0c18709fd3aa5f42bb2cfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301146 Auto-Submit: Mark Brand <markbrand@google.com> Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#789063}
-
Maxime Charland authored
The new look for empty state in History will have: - Small title inside the navigation bar - New TableView background layout, implemented by TableViewIllustratedEmptyView - Only one button in the toolbar: Clear Browsing Data Refactoring needed to facilitate implementation: - addEmptyTableViewBackground: Since the empty state is called from multiple places, it makes more sense to have that logic in a method - updateToolbarButtonsWithAnimation: Now that the toolbar buttons depend on more than just edit/non-edit state, it becomes easier to call a single method that chooses the right buttons and updates the toolbar (Googlers only links) Screenshot: https://drive.google.com/file/d/1ecvACvLxSqi-pNoJph8tluvldxoX9EyH/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I5678f54901f17da71974ff763855e3cd149f2cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289397Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#789062}
-
Wenhan (Han) Zhang authored
Removed imports and references related to histograms_print_style.py which is now replaced by histogram_configuration_model.py. Original description below: Now enums and histograms pretty-printed using model representation, like how ukm and rappor currently are. Change-Id: I3b3a29333b9d4fa2418ee4faa64cf14c59d6341f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300324Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Cr-Commit-Position: refs/heads/master@{#789061}
-
Stepan Khapugin authored
Fix a DCHECK that happens when two scenes are shown in FRE and the user goes to background and then foreground. The crash happens because the check for "is first run happening" was only checking the current scene. Instead, check all the scenes for FRE before scheduling the promo. This way the attempt to show a promo isn't happening. The promo involves a blocking UI, and the attempt happens in the second scene, hence the crash. Bug: 1104123 Change-Id: I2008894d4698edbb4ba9d2f19a45bae6c8bff8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292299Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789060}
-
zengqiang authored
PopupWindow.update() will trigger android wm performLayout in the same doFrame(), which is a serious waste of CPU and easy to cause page jitter when scrolling, the user experience become worse. Bug: 1105392 Change-Id: I3ff97b62f3b9229e6bec5b7bf1069399a5b326ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295002Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
When we resolve %-based offsets for a relative position child, if its parent is a flex-item we'll read the constraint-space used to generate this fragment, and resolve the %-based offset using that block-size. I.e. https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_box.cc;l=4521;drc=3f50460dcc4c426eb876cd0a1d2838eb35472e18?originalUrl=https:%2F%2Fcs.chromium.org%2F However flex can have two passes, one without a fixed block-size, and one with. If we can determine ahead of time that these would result in the same fragment we'll hit the cache, but the constraint space would be the one without the fixed block-size. In other words, if a flex-item remained the same size between the measure, and layout passes, a relative position grandchild would resolve its %-based offsets incorrectly. This patch introduces *some* logic from another patch current WIP: https://chromium-review.googlesource.com/c/chromium/src/+/2214608 which got reverted for unrelated reasons. Effectively if we have a %-based grandchild like this, we'll miss the cache, meaning that when we later read the constraint space fixed block-size, it'll resolve against the correct size. Bug: 1106074 Change-Id: I5003e4c0903bda408c45f8fb608ad4106c8f22b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302231 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789058}
-
