- 20 May, 2020 40 commits
-
-
Danan S authored
Not focusing on the password field after incorrect entry was causing A11Y issues, as described in the bug. Bug: 1070750 Change-Id: Ib725c528e69e3733fd06cb50e587607b31ae60aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209990 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#770635}
-
Clark DuVall authored
This adds isNavigationEntryMarkedToBeSkipped() to NavigationController which allows the client to check if an entry will be taken into account by goBack(). Will look into whether we need some sort of notification for when entries are marked/unmarked as skipped. Bug: 1082208 Change-Id: I3b5652e01c76677623d3edb3b97638a4df496fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209591 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Christopher Cameron authored
To justify investing in mechanisms to avoid compiling shaders, we are going to need data comparing shader compile and link head to head. Previously, I had been using the same histograms for both, and time-slicing them. Now I need both. Leave this as just doing link -- a future patch will test compile as well. Also, stop doing this testing in the browser process -- it didn't make a difference. Bug: 974219 Change-Id: Idc35e195515991cd919ef9cde3b75a92e50a7b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208266 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770633}
-
Yue Zhang authored
This CL adds an info bar for conditional tab strip to allow user to opt-out the feature. Some behavior of the info bar: * It will show after three consecutive sessions of dismissals. * If user clicks the "Don't show again" button, conditional tab strip will never show for this user in later sessions. * If user clicks the "Show later" button, conditional tab strip will show again for this user in later sessions, and the info bar will never reshow. * If user clicks the dismiss button to dismiss the info bar, the info bar will reshow after another three consecutive dismissal, but the limit times of info bar showing is two, i.e. 6 consecutive sessions of dismissal. * When the info bar shows, the undo snackbar will not show. Note that this is the simple version of info bar that we want, in that it is tied to one tab and cannot live across tab navigation. Bug: 1076295 Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770632}
-
Peter Kasting authored
Instead, have the ExtensionDialog or ExtensionPopup create this and ensure it's properly owned by the Views hierarchy. Bug: 1044687 Change-Id: I988473f274a0b0f7434ba85e4874932e8cb45cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207803 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#770631}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9adfd61269a0..52fe4b9946f7 2020-05-20 shaochuan@chromium.org Cleanup NYC PFQ configs and related constants 2020-05-20 mmortensen@google.com Port get_all_firmware_versions from cbuildbot/build_stages. 2020-05-20 richardfung@google.com Remove master-arc-dev container targets 2020-05-20 dhaddock@chromium.org cros_update: Save the logs dir earlier. 2020-05-19 amusbach@chromium.org deploy_chrome: Warn before deploying to device with mismatched board 2020-05-19 khmel@chromium.org arc: Fix misprint in upreving runtime artifacts. 2020-05-19 lamontjones@chromium.org commands: proper encoding in MarkChromeAsStable 2020-05-19 bpastene@chromium.org device: Replace usage of RemoteDevice with ChromiumOSDevice. 2020-05-19 bpastene@chromium.org cros_chrome_sdk: Update cache links when a non-default component is used. 2020-05-19 seanabraham@chromium.org constants: enhance the reasoning for not doing retries 2020-05-19 khmel@chromium.org arc: Move master UprevAndroid and AndroidMetadata after slave sync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Icd8064c287c61299d35a81b3fbd3401eae3efc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770630}
-
Dan Harrington authored
Change-Id: I72d01908dd17cf2ac66ee26eb314e1cb8b22f55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208296Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#770629}
-
Maksim Sisov authored
By default, the size of the virtual display that Weston size is quite small and some browser_tests (not part of the Wayland tester yet) fail because of their expectations of windows' vs screen's bounds. Thus, set the size to be 1920x1080, which adequate enough and gives plenty of room to manage sizes of windows. Bug: 1022750 Change-Id: I4c90b9923431b533020fb63f8a9eb0153823a451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207199 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/682fca92996b..1ac547483837 2020-05-20 mtklein@google.com split up ==/!= for C++20 2020-05-20 jvanverth@google.com Set up D3D textures and draw buffers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I6745f5d6dae83c6bb5748868fc406e9168972835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210382Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b860c1fb389..704fb55255c8 2020-05-20 danilchap@webrtc.org In common_audio/ and modules/audio_* replace mock macros with unified MOCK_METHOD macro 2020-05-20 sprang@webrtc.org Reland "Removes lock release in PacedSender callback." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id71b29c555b46640638da42b0b11be6f00e95b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210383Reviewed-by:
-
David Black authored
By using the "mutable" keyword, we can make Add/RemoveObserver const in Assistant sub-controller models and therefore remove the APIs we added to Assistant sub-controllers to workaround previous const access restrictions. Bug: b:156920236 Change-Id: Ib709e9731f3df3ad261c64bf3aa3083fb7a20853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207936Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#770625}
-
Koji Ishii authored
As |PaintController::SetFragment()| was changed in r770260 <crrev.com/c/2207948>. This patch has no behavior changes. Bug: 982194 Change-Id: Ifcaef8e5022fa1c6b257fad6deca621662709e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208846 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770624}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/690f0c26c832..a9f5e8e76386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sebsg@google.com,clamy@google.com Change-Id: If4e68116746116ee9201bac0abef41c018f70743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210380Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770623}
-
Devlin Cronin authored
Add support for an icon in the settings overridden dialogs, and add a UI browsertest to cover the change. Bug: 1079364 Change-Id: I4ec0595e8b2a7e59029920a502d02dd39d152e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200044 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#770622}
-
Liquan (Max) Gu authored
Context: App store billing (knowned as Play Billing, for Google Play Store) is the context where a TWA issues a PaymentRequest to request a transaction with the app-store payment method. This CL imposes an restriction on the TWA's source of installation and add an about flag to loosen the restriction to facilitate local development & debugging. Before: The TWA can be installed from any source to be able to request the app-store method. After: * By default, in order to request payments with an app-store payment method, the TWA must be installed from the same app store. * When users turn on the added about flag, they are allowed to use an TWA from any source for the app-store billing purpose. Change: * Add an about flag: enable-debug-for-store-billing * Add a restriction on the source of installation based on the flag's state. Bug: 1073936 Change-Id: I2213d979fcfc29085100ea7f71e4af508f376fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199729Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
yilkal authored
This cl updates parent information strings in coexistence screen. The screenshot of the new screen can be found below. Screenshot: https://drive.google.com/file/d/1xDw5j2PYvthKcMIH_QBojz9r_t3kiePn/view?usp=sharing Bug: 1082336 Change-Id: Ie08052c2a079bec7d2762557b740a48a98cc7034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209337Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#770620}
-
Anatoliy Potapchuk authored
Some windows in kiosk mode already have a close button(e.g. accessibility settings window). Let's make this window closable by keyboard press. Bug: 1061068 Change-Id: Iacb597bd7f68d9814517128ee2150b7b5d2145a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210352 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770619}
-
James Cook authored
The function IsSafeToApplyDefaultPinLayout() checks to see if sync has started so that ChromeLauncherController can decide when to apply the default pinned apps. We should only check for app sync and OS pref sync if the user has enabled OS sync. We didn't need this before SplitSettingsSync because sync was always on. Bug: 1084189 Test: added to unit_tests Change-Id: I02fef532d880cc30fa96d1c177c376f4f8ec9ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209597 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
sebsg authored
This reverts commit c01760eb. Reason for revert: Compile error on https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/13260 Original change's description: > Crash fast in case of an exception from ATL. > > BUG=1081762 > R=robliao@chromium.org, wfh@chromium.org > > Change-Id: I3e23655e52c737061d6b5e3093536a3064480df8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207221 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Auto-Submit: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770606} TBR=fdoray@chromium.org,robliao@chromium.org,wfh@chromium.org,grt@chromium.org Change-Id: Ie980dcefbb3314ab1ac135728adfe4029402e92f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1081762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210002Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770617}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34dc00881b0b..6a935445b316 2020-05-20 tvanderlippe@chromium.org Port perf test suite to mocha runner If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I00b1390a2406c11ac0f0c67836aa3422535f6428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210379Reviewed-by:
-
Alexander Surkov authored
Switch from obsolette base::DictionaryValue to base::Value. Unify object serialization functions. Move serialization functions into the formatter for the future dependencies on the formatter state. Bug: 1082800 Change-Id: I55e7ca1df973c3bafb7710941165e817db7714ce AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202338 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770615}
-
Peter Kotwicz authored
This CL: - Changes WebappIntentDataProvider#getIntent() to return intent used to build WebappActivity instead of empty intent. - Adds a test for return value of IntentHandler.shouldIgnoreIntent() for webapp intents BUG=985328 Change-Id: I2bfc7d136627c0fb982856e3cd95870a18dae343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208116Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770614}
-
Etienne Pierre-doray authored
Since sampler_ is now always created or passed at construction (or null), there's no point saving unwinder as |pending_aux_unwinder_| before Start since it can be added directly. This simplifies the impl and allows us to add multiple auxiliary unwinders. Bug: 989102 Change-Id: I92b718c3e73760b86488820e7c5e749fcd29655b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208931 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770613}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I7209065b8e38e8276403b5d511759699e1d99845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210485Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770612}
-
kylechar authored
This reverts commit 40eb3bd7. Reason for revert: vulkan tag is already used by ANGLE Original change's description: > Fix GPU integration test tags > > Both [no-]skia-renderer and [no-]use-vulkan tags in GPU integration > tests were based on the command line. Code assumed that if there was > nothing on the command line then the feature was disabled which was > incorrect. > > Change the tags to be based on if the feature is enabled or not. Also > change use-vulkan to just be vulkan for brevity. > > Bug: 1069551, 1084569 > Change-Id: I33fdbfb4d8078127f066f4a86a267477e4e9e020 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209348 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770579} TBR=backer@chromium.org,zmo@chromium.org,kylechar@chromium.org Change-Id: I1fb173347fb8355a911dd618aed36d11d26b38d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069551, 1084569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209998Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#770611}
-
Alice Wang authored
This CL uses RuleChain in SearchEngineSettingsTest to ensure that SettingsActivity is destroyed before tearing down the mock sign-in environment. Without the RuleChain, this test will become flaky once we will cleanup the SigninTestUtil setup in ChromeBrowserTestRule. Bug: 1004418 Change-Id: If642a7307be58871a33167e0b6cc1c486f645ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207328Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770610}
-
Ramin Halavati authored
Incognito CCTs are updated to use an isolated off-the-record profile that doesn't share data with the incognito tabs in Chrome. Bug: 1023759 Change-Id: Icf3bfa6ed7fb92ba84fd361940d0077b04d93aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950949Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
-
Jesse Schettler authored
Use cros_healthd to collect and report Bluetooth info for each of a device's Bluetooth adapters. Bug: chromium:1067677 Change-Id: Ibd0c7b71062e90bcf5a3fedd74a8704180d64e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207800 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#770608}
-
Xiaohan Wang authored
Currently the CDM process is a per-CDM-type singleton shared by all user profiles and all sites. This CL makes it per-CDM-type, per-user-profile and per-site for security and privacy improvements. See go/cdm-process-site-isolation for details. This CL also adds a new base::Feature media::kCdmProcessSiteIsolation to control this feature. It is enabled by default. Manually tested by running 3 sites in one user profile and 1 site in guest mode, with all sites serving protected content using Widevine key system. With this CL, a maximum of 4 CDM processes are created. Without this CL or when media::kCdmProcessSiteIsolation is disabled, there is always at most one CDM process. Bug: 638950, 1077390 Test: See above Change-Id: I326795648111cc7f9436a4389076d92be437d6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204686Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770607}
-
Greg Thompson authored
BUG=1081762 R=robliao@chromium.org, wfh@chromium.org Change-Id: I3e23655e52c737061d6b5e3093536a3064480df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207221Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#770606}
-
Rouslan Solomakhin authored
Before this patch, PaymentHandlerHost was passed only to ServiceWorkerPaymentApps, which are based on payment handlers. This prevented introducing more types of payment apps which may be based on payment handler, such as a JNI wrapper on top of C++ payment app interface. This patch sends the PaymentHandlerHost to all payment apps, so it's up to the payment app implementation to determine whether the Host should be used. After this patch, it's easier to add a JNI wrapper on top of a C++ payment app, regardless of whether that app is backed by a payment handler. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1083242 Change-Id: Ibf785fd665691a402500705c5b6d39061c904f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207290 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770605}
-
Eric Willigers authored
The flag AspectRatioFromWidthAndHeight has been stable since M79. Bug: 979891 Change-Id: Ifd330c76ddf71c11e03ddb65916585255b12aeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209772 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#770604}
-
Peter Kasting authored
* DISALLOW_COPY_AND_ASSIGN() -> explicit deletions * Remove using declarations * Use =default * Use in-declaration initializers * NULL -> nullptr * Combine ExtensionViewHost::CreateView() with constructor * Use const and auto more * Use make_unique instead of bare new * Shorten code * Move most of ExtensionDialog::Show() into the constructor * Combine ExtensionDialog::InitWindow() with constructor * Replace GetExtensionView() functions with |extension_view_| members, since the return value is constant (and its source will change in an upcoming CL) * Remove always-true condition from ExtensionDialog::CanResize() (size was always set) * Consistently use |host_|, not host(), in ExtensionPopup * Have ExtensionViewViews obtain the relevant profile from the |host| instead of having it explicitly passed in * For clarity, make ExtensionViewViews::minimum_size_ an Optional instead of treating Size() as a magic value that means "not set" * Eliminate unnecessary friend declaration Bug: none Change-Id: I2733f7460b09c07ada3fcae819d71bee960886ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209593 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL: - Introduces an end to end WebAPK share intent test: WebApkIntegrationTest#testShare() - Changes testWebApkLaunchesByLauncherActivity() to send the intent to the WebAPK instead of the WebappLauncherActivity BUG=1082895 Change-Id: I58da1607ffb5687572a29055a671e1529cec4668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207780Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770602}
-
Oleh Lamzin authored
Use space delimiter for numbers in documentation instead apostrophe. Space delimiter is part of SI/ISO 31-0 standard. Bug: b:130276290 Change-Id: I74845855621ad62cb24db4f744c6de04b7974e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207371Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#770601}
-
Akihiro Ota authored
In addition to checking the commit footer, we should also check the commit description for the AX-Relnotes field. Bug: N/A Change-Id: Ie9839bbf02b84d97ace0c60e8b972d048bbe7eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198931 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770600}
-
danakj authored
This test was testing the web test harness' ability to synchronously hide the window. R=reillyg@chromium.org Bug: 1083585 Change-Id: I5e83e3a8bb683e3cd8a8bc01effbf7406015171f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207739Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#770599}
-
Ravjit Singh Uppal authored
This CL adds the possibility to throw away patterns with wildcards defined in the enterprise policies for a content settings Bug: 1073883 Change-Id: I99f2d742289e77f1d00081a7cf186d4b21a91f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207159 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770598}
-
Dominic Battre authored
Extend our key metrics by 1 year. Bug: 1084131,1084132,1084133,1084134,1084135,1084136,1084137,1084138,1084139,1084140,1084141 Change-Id: Ifa068177a86af8a3653c48dc35ef9f705d6608dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210441 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#770597}
-
Greg Kerr authored
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2176183 added a new histogram to track unlock time, and this will collect it in Chrome. BUG=1069904 Change-Id: Ie3dfaa047d0c6ffd5c14449246566d34a7031b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209951Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#770596}
-
