1. 11 Mar, 2011 40 commits
    • michaeln@google.com's avatar
      2011-03-11 Michael Nordman <michaeln@google.com> · 7dad9153
      michaeln@google.com authored
              Reviewed by David Levin.
      
              Add SQLCallbackWrapper
              Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
              which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
              https://bugs.webkit.org/show_bug.cgi?id=55919
      
              No new tests, existing tests apply.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * storage/SQLCallbackWrapper.h: Added.
              (WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
              (WebCore::SQLCallbackWrapper::clear):
              (WebCore::SQLCallbackWrapper::unwrap):
              (WebCore::SQLCallbackWrapper::hasCallback):
              (WebCore::SQLCallbackWrapper::safeRelease):
              * storage/SQLStatement.cpp:
              (WebCore::SQLStatement::create):
              (WebCore::SQLStatement::SQLStatement):
              (WebCore::SQLStatement::performCallback):
              * storage/SQLStatement.h:
              (WebCore::SQLStatement::hasStatementCallback):
              (WebCore::SQLStatement::hasStatementErrorCallback):
              * storage/SQLTransaction.cpp:
              (WebCore::SQLTransaction::SQLTransaction):
              (WebCore::SQLTransaction::executeSQL):
              (WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
              (WebCore::SQLTransaction::deliverTransactionCallback):
              (WebCore::SQLTransaction::deliverStatementCallback):
              (WebCore::SQLTransaction::postflightAndCommit):
              (WebCore::SQLTransaction::deliverSuccessCallback):
              (WebCore::SQLTransaction::handleTransactionError):
              (WebCore::SQLTransaction::deliverTransactionErrorCallback):
              * storage/SQLTransaction.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80876 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7dad9153
    • andersca@apple.com's avatar
      2011-03-11 Anders Carlsson <andersca@apple.com> · 64ad8b25
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Don't paint more than 60 times per second
              https://bugs.webkit.org/show_bug.cgi?id=56206
              <rdar://problem/9085989>
      
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::DrawingAreaImpl):
              Initialize m_lastDisplayTime to 0. Change the display timer to call displayTimerFired.
      
              (WebKit::DrawingAreaImpl::didUpdate):
              Call displayTimerFired instead of display.
      
              (WebKit::DrawingAreaImpl::displayTimerFired):
              If we're asked to paint again less than 1/60th of a second after we've already painted,
              defer painting.
      
              (WebKit::DrawingAreaImpl::display):
              Update m_lastDisplayTime.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80875 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      64ad8b25
    • eric.carlson@apple.com's avatar
      2011-03-11 Eric Carlson <eric.carlson@apple.com> · fe7ffcba
      eric.carlson@apple.com authored
              Reviewed by Sam Weinig.
      
              <rdar://problem/8955589> Adopt AVFoundation media back end on Lion.
      
              No new tests, existing media tests cover this.
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC.
              (WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace.
              (WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto.
              (WebCore::MediaPlayer::inMediaDocument): Ditto.
              * platform/graphics/MediaPlayer.h:
      
              * platform/graphics/avfoundation: Added.
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added.
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added.
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added.
      
      2011-03-11  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/8955589> Adopt AVFoundation media back end on Lion.
      
              No new tests, existing media tests cover this.
      
              * JavaScriptCore.exp: Export cancelCallOnMainThread
              * wtf/Platform.h: Define WTF_USE_AVFOUNDATION.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80874 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fe7ffcba
    • dino@apple.com's avatar
      2011-03-11 Dean Jackson <dino@apple.com> · 79cc3526
      dino@apple.com authored
              Reviewed by Simon Fraser.
      
              https://bugs.webkit.org/show_bug.cgi?id=56205
              m_restrictions needs to allow multiple values (a bitfield)
      
              HTMLMediaElement::m_restrictions needs to hold multiple values, so
              change BehaviorRestrictions to an unsigned typedef and rename the
              existing enum BehaviorRestrictionFlags.
      
              * html/HTMLMediaElement.h:
              (WebCore::HTMLMediaElement::setBehaviorRestrictions):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80873 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      79cc3526
    • dglazkov@chromium.org's avatar
      2011-03-11 Dimitri Glazkov <dglazkov@chromium.org> · 2441337d
      dglazkov@chromium.org authored
              [GTK] Update expectations after r80857.
              https://bugs.webkit.org/show_bug.cgi?id=55972
      
              * platform/gtk/media/audio-controls-rendering-expected.txt:
              * platform/gtk/media/audio-repaint-expected.txt:
              * platform/gtk/media/controls-strict-expected.txt:
              * platform/gtk/media/controls-styling-expected.txt:
              * platform/gtk/media/controls-without-preload-expected.txt:
              * platform/gtk/media/media-document-audio-repaint-expected.txt:
              * platform/gtk/media/video-controls-rendering-expected.txt:
              * platform/gtk/media/video-empty-source-expected.txt:
              * platform/gtk/media/video-no-audio-expected.txt:
              * platform/gtk/media/video-volume-slider-expected.txt:
              * platform/gtk/media/video-zoom-controls-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80872 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2441337d
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=47206 · 27c111b6
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Table rows don't support ::before/::after.  Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
      properly constructed.
      
      Added fast/css-generated-content/table-row-before-after.html
      
      Source/WebCore: 
      
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::styleDidChange):
      * rendering/RenderTableRow.h:
      
      LayoutTests: 
      
      * fast/css-generated-content/table-row-before-after.html: Added.
      * platform/mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
      * platform/mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
      * platform/mac/fast/css-generated-content/table-row-before-after-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80871 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      27c111b6
    • jamesr@google.com's avatar
      2011-03-11 James Robinson <jamesr@chromium.org> · 79a88371
      jamesr@google.com authored
              Reviewed by Kenneth Russell.
      
              [chromium] Avoid updating a composited layer&apos;s contents if the layer has nonpositive dimensions
              https://bugs.webkit.org/show_bug.cgi?id=56209
      
              This matches the behavior prior to r80482.  No test since the only changes in
              behavior are avoiding work on invisible layers, which is unobservable,
              and fixing a crash due to bug 56153.
      
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::updateContentsRecursive):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80869 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      79a88371
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=47159 · 034eb365
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      CSS2.1 failures in background position parsing.
              
      Rewrite background position component parsing to match the spec.  Our old parsing would allow "100% left" to be valid
      when it should not have.  Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for
      it to understand what the first component was.
              
      For individual property parsing using background-position-x/y, I added new functions that just handle that without
      worrying about the other component.
              
      In order to pass the CSS2.1 test, I also had to fix multiple background parsing.  The number of layers in multiple
      backgrounds is determined solely by the background-image property and not by any of the other properties.  cullEmptyLayers
      has been changed to always consider a layer empty if it has no image set, even if other properties are set.
              
      A number of layout tests had to be patched as they were invalid.  A couple of them relied on incorrect background-position
      parsing (e.g., "50 left") and another relied on incorrect multiple background parsing.  It's not clear if the computed style
      should actually include the additional values when no image is set though, so that should perhaps be the subject of a 
      follow-up bug.
      
      Added fast/backgrounds/background-position-parsing.html
      
      Source/WebCore: 
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFillPositionX):
      (WebCore::CSSParser::parseFillPositionY):
      (WebCore::CSSParser::parseFillPositionComponent):
      (WebCore::CSSParser::parseFillPosition):
      (WebCore::CSSParser::parseFillProperty):
      (WebCore::CSSParser::parseTransformOrigin):
      (WebCore::CSSParser::parsePerspectiveOrigin):
      * css/CSSParser.h:
      * rendering/style/FillLayer.cpp:
      (WebCore::FillLayer::fillUnsetProperties):
      (WebCore::FillLayer::cullEmptyLayers):
      
      LayoutTests: 
      
      * fast/backgrounds/background-position-1.html:
      * fast/backgrounds/background-position-parsing.html: Added.
      * fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
      * fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
      * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
      * fast/backgrounds/resources/diamond.png: Added.
      * fast/backgrounds/resources/ring.png: Added.
      * fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
      * platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
      * platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
      * platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
      * platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
      * platform/mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
      * platform/mac/fast/backgrounds/background-position-parsing-expected.png: Added.
      * platform/mac/fast/backgrounds/background-position-parsing-expected.txt: Added.
      * platform/mac/fast/backgrounds/bgCompositeCopy-expected.png:
      * platform/mac/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize03-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
      * platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
      * platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
      * platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
      * platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
      * platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80868 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      034eb365
    • vangelis@chromium.org's avatar
      2011-03-11 Vangelis Kokkevis <vangelis@chromium.org> · 1b022b83
      vangelis@chromium.org authored
              Reviewed by James Robinson.
      
              [chromium] Adding a test for rotated large layers.
              https://bugs.webkit.org/show_bug.cgi?id=55984
      
              * platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added.
              * platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
              * platform/chromium/compositing/huge-layer-rotated-expected.txt: Added.
              * platform/chromium/compositing/huge-layer-rotated.html: Added.
      2011-03-11  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by James Robinson.
      
              [chromium] Allow large layers with non-identity transforms to be drawn
              as long as their visible portion is smaller than the largest supported
              texture size. This code will soon be replaced by tiled layers.
              https://bugs.webkit.org/show_bug.cgi?id=55984
      
              Test: platform/chromium/compositing/huge-layer-rotated.html
      
              * platform/graphics/chromium/ContentLayerChromium.cpp:
              (WebCore::ContentLayerChromium::updateContentsIfDirty):
              (WebCore::ContentLayerChromium::draw):
              * platform/graphics/chromium/ContentLayerChromium.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80867 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1b022b83
    • cmarrin@apple.com's avatar
      2011-03-09 Chris Marrin <cmarrin@apple.com> · 05f9d249
      cmarrin@apple.com authored
              Reviewed by Adam Roben.
      
              REGRESSION (5.0.3-ToT): Scrolling text doesn&apos;t scroll in Star Wars intro animation
              https://bugs.webkit.org/show_bug.cgi?id=52468
      
              Added WIN32 to the ifdef controlling whether animations are applied in normal or
              reverse order. On Mac, animations used to be applied in reverse, but 
              <rdar://problem/7095638> fixed this in the release after Snow Leopard.
              But that patch has not be applied to the Safari Windows SDK yet. For now
              I've made Windows use the reverse order logig. <rdar://problem/9112233> is
              tracking the inclusion of the patch on Windows.
      
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80866 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      05f9d249
    • dglazkov@chromium.org's avatar
      2011-03-11 Dimitri Glazkov <dglazkov@chromium.org> · 2cf847ca
      dglazkov@chromium.org authored
              Reviewed by Adam Barth.
      
              Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
              https://bugs.webkit.org/show_bug.cgi?id=56207
      
              * JavaScriptCore.gypi: Added Tracing.d to the sources.
              * gyp/generate-dtrace-header.sh: Added.
              * gyp/JavaScriptCore.gyp: Updated dylib paths (now the project can see them),
                  and added DTrace header generating step.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80865 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2cf847ca
    • aroben@apple.com's avatar
      Make it possible to view all leaks from a build at once in Leaks Viewer · bf077ecd
      aroben@apple.com authored
      You can now give Leaks Viewer the URL of a build results page (e.g.,
      <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
      will load all the leaks files from that build.
      
      Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
      files from a particular build at once, rather than one at a time
      
      Reviewed by David Kilzer.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
      (LeaksLoader): Initialize our properties.
      (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
      load it. Otherwise assume it's a build results page URL and start fetching the leaks files
      from that page.
      (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
      so it can provide feedback. Then load each one and pass it to the client.
      (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
      it into a DOM, pull out all the links to leaks files, and load each one.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
      (LeaksParser): Initialize our worker.
      (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
      This code mostly came from Worker.js.
      (LeaksParserWorker): Initialize our profile.
      (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
      profile.
      (LeaksParserWorker.prototype._parseLeaks):
      (LeaksParserWorker.prototype._createNode):
      (LeaksParserWorker.prototype._incorporateLeaks):
      Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
      version of createProfile which adds to this.profile instead of making a new profile each
      time.
      (onmessage): Parse the file and send back the new profile.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
      (#loading-indicator):
      (#spinner):
      (#loading-indicator-label):
      Tweaked styles to accomodate a longer label.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
      (LeaksViewer.loaded): Set up a loader and parser.
      
      (LeaksViewer.get filesLeftToParse):
      (LeaksViewer.set filesLeftToParse):
      Added these simple accessors.
      
      (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
      (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
      the parser.
      (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
      tell the ProfilerAgent and mark that we're done loading. (Code came from the old
      _loadLeaksFromURL function).
      (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
      (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
      loading indicator, including the number of files being loaded.
      (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
      (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
      (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
      _loadingIndicatorText.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
      (getResource): Moved here from LeaksViewer.js.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
      LeaksParserWorker.js.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
      files, added a #loading-indicator-label element, and tweaked the prompt wording.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80864 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bf077ecd
    • aroben@apple.com's avatar
      Don't trigger a build when build.webkit.org's HTML files are modified · 5f2e8030
      aroben@apple.com authored
      Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
      
      Reviewed by Dan Bernstein.
      
      * Scripts/webkitpy/common/config/build.py:
      (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
      directories that shouldn't trigger builds. Re-sorted the list.
      
      * Scripts/webkitpy/common/config/build_unittest.py:
      (ShouldBuildTest): Added a test to cover the above change.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5f2e8030
    • commit-queue@webkit.org's avatar
      2011-03-11 Avi Drissman <avi@google.com> · 4482c126
      commit-queue@webkit.org authored
              Reviewed by Tony Chang.
      
              Fix missing initialization of new member variables.
              https://bugs.webkit.org/show_bug.cgi?id=50969
      
              * public/WebMenuItemInfo.h:
              (WebKit::WebMenuItemInfo::WebMenuItemInfo):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80862 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4482c126
    • tonyg@chromium.org's avatar
      2011-03-11 Tony Gentilcore <tonyg@chromium.org> · ecc58804
      tonyg@chromium.org authored
              Reviewed by Eric Seidel.
      
              Let the parser yield for layout before running scripts
              https://bugs.webkit.org/show_bug.cgi?id=54355
      
              Prior to this patch, the parser would yield to perform a layout/paint before running a
              script only if the script or a stylesheet blocking the script is not loaded yet. Since we
              don't preload scan into the body while parsing the head, typically we'll block on a script
              early in the body that causes us to yield to do the first paint within a reasonable time.
      
              However, I'm planning to change the PreloadScanner to scan into the body from the head.
              That significantly improves overall load time, but would hurt first paint time because
              fewer scripts would be blocked during parsing and thus wouldn't yield.
      
              This change causes us to yield before running scripts if we haven't painted yet (regardless
              of whether or not the script is loaded). In addition to allowing the above mentioned
              PreloadScanner change to be implemented without regressing first paint time, this also
              improves first paint time by itself.
      
              I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
              bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
              6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
              signifcant change in page load time.
      
              Within the pages tested, 33 had no statistically significant change in time to first paint,
              12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
              are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
      
              * html/parser/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
              (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
              means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
              the right thing whether we are just before a token or waiting for a script. Now that we may
              yield before a token or before a script, this may be called while paused.
              * html/parser/HTMLParserScheduler.cpp:
              (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
              * page/FrameView.h:
              (WebCore::FrameView::hasEverPainted): Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80861 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ecc58804
    • commit-queue@webkit.org's avatar
      2011-03-11 Alexis Menard <alexis.menard@openbossa.org> · b99eb8a1
      commit-queue@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
              https://bugs.webkit.org/show_bug.cgi?id=56181
      
              We need to stop the auto hide cursor timer when closing the widget otherwise the timer
              might get fired and therefore hide the cursor even when the fullscreen widget is closed.
      
              * WebCoreSupport/FullScreenVideoWidget.cpp:
              (WebCore::FullScreenVideoWidget::closeEvent):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80860 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b99eb8a1
    • dglazkov@chromium.org's avatar
      2011-03-11 Dimitri Glazkov <dglazkov@chromium.org> · dad2de30
      dglazkov@chromium.org authored
              Fix crashes in dom/html/level2/html/HTMLInputElement*.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e,
                  because e can certainly be a null.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80859 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dad2de30
    • dglazkov@chromium.org's avatar
      2011-03-09 Dimitri Glazkov <dglazkov@chromium.org> · 274a4183
      dglazkov@chromium.org authored
              Reviewed by David Hyatt.
      
              Choke text-decoration when entering shadow DOM subtree.
              https://bugs.webkit.org/show_bug.cgi?id=56044
      
              No new tests, because the functionality can't be tested yet.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80858 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      274a4183
    • dglazkov@chromium.org's avatar
      2011-03-08 Dimitri Glazkov <dglazkov@chromium.org> · 88dcc37f
      dglazkov@chromium.org authored
              Reviewed by Eric Carlson.
      
              Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
              https://bugs.webkit.org/show_bug.cgi?id=55972
      
              Update test results, because they are now laying out timeline consistently.
      
              * media/audio-repaint-expected.txt: Updated.
              * platform/mac/media/audio-controls-rendering-expected.checksum: Ditto.
              * platform/mac/media/audio-controls-rendering-expected.png: Ditto.
              * platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
              * platform/mac/media/audio-repaint-expected.checksum: Ditto.
              * platform/mac/media/audio-repaint-expected.png: Ditto.
      2011-03-08  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
              https://bugs.webkit.org/show_bug.cgi?id=55972
      
              Instead of poking at the time display elements all the way from RenderMedia,
              let the standard layout cycle take care of things. Move the logic of calculating
              when to collapse the time display elements into a custom renderer, since
              this is not something that can be accomplished with CSS.
      
              Also, the logic of keeping the timeline slider at least 100px needed refreshing,
              since it didn't actually keep it at 100px.
      
              * html/shadow/MediaControls.cpp: Moved the logic of determining visibility
                  of time display elements to RenderMediaControlTimeDisplay, eliminating
                  updateTimeDisplayVisibility method.
              * html/shadow/MediaControls.h: Removed decl.
              * rendering/MediaControlElements.cpp:
              (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
                  Added new renderer class.
              (WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)
                  size-sensing logic, still using hard-coded values.
              (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
                  Removed m_isVisible member, which is no longer necessary.
              (WebCore::MediaControlTimeDisplayElement::createRenderer): Added to
                  return the new renderer.
              * rendering/MediaControlElements.h: Adjusted decls.
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::layout): Remove the now-unnecessary poking at
                  media controls in layout.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80857 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      88dcc37f
    • commit-queue@webkit.org's avatar
      2011-03-11 Marco Peereboom <marco@peereboom.us> · 9c4414cf
      commit-queue@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              Provide a knob to enable/disable DNS prefetching.
              DNS prefetching is enabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=55973
      
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
              (webkit_web_view_settings_notify):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80856 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9c4414cf
    • dglazkov@chromium.org's avatar
      2011-03-09 Dimitri Glazkov <dglazkov@chromium.org> · 997dd40a
      dglazkov@chromium.org authored
              Reviewed by Eric Carlson.
      
              Start focusing updates to media controls, away from always updating everything.
              https://bugs.webkit.org/show_bug.cgi?id=56038
      
              For now, the new methods just call generic MediaControls::update.
      
              Covered by existing tests.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset.
              (WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute.
              (WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume.
              (WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls
                  accessor.
              (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use
                  MediaControls::changedClosedCaptionsVisibility.
              (WebCore::HTMLMediaElement::mediaControls): Added.
              (WebCore::HTMLMediaElement::hasMediaControls): Added.
              * html/HTMLMediaElement.h: Added decls.
              * html/shadow/MediaControls.cpp:
              (WebCore::MediaControls::reset): Added.
              (WebCore::MediaControls::changedMute): Added.
              (WebCore::MediaControls::changedVolume): Added.
              (WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
              * html/shadow/MediaControls.h: Added decls.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80855 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      997dd40a
    • commit-queue@webkit.org's avatar
      2011-03-11 Alexis Menard <alexis.menard@openbossa.org> · ab87eaab
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GStreamer] When seeking webKitWebSrcStop release the frame but should not.
              https://bugs.webkit.org/show_bug.cgi?id=55703
      
              When calling webKitWebSrcStop in case of a seeking, the frame should not
              be reset (the source hasn't change). The frame may be used to get the network
              context. Some network stack (like Qt) are relaying on the network context
              to work.
      
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              (webKitWebSrcStop):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80854 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ab87eaab
    • dino@apple.com's avatar
      2011-03-11 Dean Jackson <dino@apple.com> · 1d5740fa
      dino@apple.com authored
              Unreviewed.
      
              Build fixes for GTK and Leopard.
      
              * bindings/gobject/GNUmakefile.am:
              - add missing WebKitAnimation* generated bindings
              * page/WebKitAnimation.idl:
              - use double in place of float (the core values are double anyway)
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80853 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1d5740fa
    • aroben@apple.com's avatar
      Update Windows results after r80846 · 1df39915
      aroben@apple.com authored
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-expected.txt:
      * platform/win/fast/js/global-constructors-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80852 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1df39915
    • aroben@apple.com's avatar
      Roll out r80848 · db37e697
      aroben@apple.com authored
      It was accidentally committed.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
      (LeaksViewer._loadLeaksFromURL):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80851 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      db37e697
    • aroben@apple.com's avatar
      Skip a crashing test on Windows · de345892
      aroben@apple.com authored
      The crash is tracked by <http://webkit.org/b/56185>.
      
      * platform/win/Skipped: Added http/tests/websocket/tests/url-with-credential.html. Grouped
      possibly-related websocket crashes.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80850 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      de345892
    • aroben@apple.com's avatar
      Disable fast/text/large-text-composed-char-dos.html · 88234305
      aroben@apple.com authored
      It is failing on multiple bots. The failure is tracked by <http://webkit.org/b/56140>.
      
      * fast/text/large-text-composed-char-dos.html-disabled: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      88234305
    • aroben@apple.com's avatar
      Work on fetching all leaks for a build · cac89af3
      aroben@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@80848 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cac89af3
    • dino@apple.com's avatar
      2011-03-11 Dean Jackson <dino@apple.com> · f12fa457
      dino@apple.com authored
              Unreviewed build fix for QT.
      
              * WebCore.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80847 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f12fa457
    • dino@apple.com's avatar
      2011-03-11 Dean Jackson <dino@apple.com> · 8eb83ef3
      dino@apple.com authored
              Reviewed by Simon Fraser and Chris Marrin.
      
              https://bugs.webkit.org/show_bug.cgi?id=54151
              Implement an API to play/pause/scrub animations
      
              This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
              APIs, exposed via Element.getWebKitAnimations(). This first pass
              is a read-only API - a subsequent commit will add the ability
              to scrub animations.
      
              Test: animations/animation-api-1.html
      
              * Android.derived.jscbindings.mk:
              * Android.derived.v8bindings.mk:
              * Android.mk:
              * Android.v8bindings.mk:
              * CMakeLists.txt:
              * CodeGenerators.pri:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              - All build settings updated for new files
              * bindings/js/JSBindingsAllInOne.cpp:
              - Include new custom files
              * bindings/js/JSWebKitAnimationCustom.cpp: Added.
              (WebCore::JSWebKitAnimation::iterationCount):
              - Custom property getter so that we can return INFINITY
              * bindings/js/JSWebKitAnimationListCustom.cpp: Added.
              (WebCore::JSWebKitAnimationList::markChildren):
              - Make sure WebKitAnimations are marked
              * bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added.
              (WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
              - Custom property getter so that we can return INFINITY
              * dom/Element.cpp:
              (WebCore::Element::webkitGetAnimations):
              * dom/Element.h:
              * dom/Element.idl:
              - New API entry point
              * page/DOMWindow.idl:
              - Constructor definitions for WebKitAnimation and WebKitAnimationList
              * page/animation/AnimationBase.cpp:
              (WebCore::AnimationBase::~AnimationBase):
              - Since AnimationBase can now live longer (if a WebKitAnimation is
              held in Javascript) we need to guard for the renderer having disappeared.
              (WebCore::AnimationBase::setElapsedTime):
              (WebCore::AnimationBase::play):
              (WebCore::AnimationBase::pause):
              - Stub implementations at present
              * page/animation/AnimationBase.h:
              (WebCore::AnimationBase::animation):
              - Expose the Animation properties
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::animationsForRenderer):
              (WebCore::AnimationController::animationsForRenderer):
              - Builds the list of WebKitAnimations
              * page/animation/AnimationController.h:
              * page/animation/AnimationControllerPrivate.h:
              * page/animation/CompositeAnimation.cpp:
              (WebCore::CompositeAnimation::updateKeyframeAnimations):
              - Make sure we clear the renderer if we are removing the animation
              (WebCore::CompositeAnimation::animations):
              * page/animation/CompositeAnimation.h:
              * page/animation/WebKitAnimation.cpp: Added.
              (WebCore::WebKitAnimation::WebKitAnimation):
              (WebCore::WebKitAnimation::name):
              (WebCore::WebKitAnimation::duration):
              (WebCore::WebKitAnimation::elapsedTime):
              (WebCore::WebKitAnimation::setElapsedTime):
              (WebCore::WebKitAnimation::delay):
              (WebCore::WebKitAnimation::iterationCount):
              (WebCore::WebKitAnimation::paused):
              (WebCore::WebKitAnimation::ended):
              (WebCore::WebKitAnimation::direction):
              (WebCore::WebKitAnimation::fillMode):
              (WebCore::WebKitAnimation::pause):
              (WebCore::WebKitAnimation::play):
              - The implementation of the new API. All the read-only parts are
              done, but elapsedTime, play() and pause() are stubs.
              * page/animation/WebKitAnimation.h: Added.
              (WebCore::WebKitAnimation::create):
              (WebCore::WebKitAnimation::~WebKitAnimation):
              * page/animation/WebKitAnimation.idl: Added.
              * page/animation/WebKitAnimationList.cpp: Added.
              * page/animation/WebKitAnimationList.h: Added.
              * page/animation/WebKitAnimationList.idl: Added.
              - Copies NodeList implementation
      
      2011-03-11  Dean Jackson  <dino@apple.com>
      
              Reviewed by Simon Fraser and Chris Marrin.
      
              https://bugs.webkit.org/show_bug.cgi?id=54151
              Implement an API to play/pause/scrub animations
      
              This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
              APIs, exposed via Element.getWebKitAnimations(). This first pass
              is read-only. One new layout test that examines animation
              properties. Update existing layout tests for the new interfaces
              on Window.
      
              * animations/animation-api-1-expected.txt: Added.
              * animations/animation-api-1.html: Added.
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/Window/window-property-descriptors-expected.txt:
              * fast/dom/prototype-inheritance-2-expected.txt:
              * fast/dom/prototype-inheritance-expected.txt:
              * fast/js/global-constructors-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80846 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8eb83ef3
    • loislo@chromium.org's avatar
      2011-03-11 Ilya Tikhonovsky <loislo@chromium.org> · 1276edad
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: introduce error argument for all the callbacks on frontend.
              https://bugs.webkit.org/show_bug.cgi?id=56100
      
              * inspector/CodeGeneratorInspector.pm:
              * inspector/front-end: number of files
      
      2011-03-11  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: introduce error argument for all the callbacks on frontend.
              https://bugs.webkit.org/show_bug.cgi?id=56100
      
              * http/tests/inspector/extensions-test.js:
              (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
              * http/tests/inspector/inspector-test.js:
              (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback):
              (initialize_InspectorTest.InspectorTest.evaluateInPage):
              * inspector/console/console-dir-global.html:
              * inspector/elements/dom-agent-query-selector.html:
              * inspector/protocol/console-agent-expected.txt:
              * inspector/protocol/console-agent.html:
              * inspector/protocol/runtime-agent-expected.txt:
              * inspector/protocol/runtime-agent.html:
              * inspector/report-protocol-errors-expected.txt:
              * inspector/report-protocol-errors.html:
              * inspector/styles/styles-new-API.html:
              * inspector/styles/styles-source-offsets.html:
              * inspector/timeline/timeline-test.js:
              (initialize_Timeline.InspectorTest.stopTimeline):
      
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80845 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1276edad
    • yurys@chromium.org's avatar
      2011-03-11 Yury Semikhatsky <yurys@chromium.org> · 4cfcb169
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
              https://bugs.webkit.org/show_bug.cgi?id=56173
      
              * inspector/protocol/console-agent-expected.txt:
              * inspector/protocol/console-agent.html:
      2011-03-11  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
              https://bugs.webkit.org/show_bug.cgi?id=56173
      
              Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              * bindings/js/JSInjectedScriptManager.cpp: Added.
              (WebCore::InjectedScriptManager::createInjectedScript):
              (WebCore::InjectedScriptManager::discardInjectedScript):
              (WebCore::InjectedScriptManager::injectedScriptFor):
              (WebCore::InjectedScriptManager::canAccessInspectedWindow):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
              (WebCore::WeakReferenceCallback):
              (WebCore::createInjectedScriptHostV8Wrapper):
              (WebCore::InjectedScriptManager::createInjectedScript):
              (WebCore::InjectedScriptManager::discardInjectedScript):
              (WebCore::InjectedScriptManager::injectedScriptFor):
              (WebCore::InjectedScriptManager::canAccessInspectedWindow):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::addToFrontend):
              * inspector/ConsoleMessage.h:
              * inspector/InjectedScript.cpp:
              (WebCore::InjectedScript::canAccessInspectedWindow):
              * inspector/InjectedScript.h:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::create):
              (WebCore::InjectedScriptHost::InjectedScriptHost):
              (WebCore::InjectedScriptHost::~InjectedScriptHost):
              (WebCore::InjectedScriptHost::disconnect):
              (WebCore::InjectedScriptHost::inspectImpl):
              (WebCore::InjectedScriptHost::clearConsoleMessages):
              (WebCore::InjectedScriptHost::databaseIdImpl):
              (WebCore::InjectedScriptHost::storageIdImpl):
              * inspector/InjectedScriptHost.h:
              (WebCore::InjectedScriptHost::init):
              (WebCore::InjectedScriptHost::setFrontend):
              (WebCore::InjectedScriptHost::clearFrontend):
              * inspector/InjectedScriptManager.cpp: Added.
              (WebCore::InjectedScriptManager::create):
              (WebCore::InjectedScriptManager::InjectedScriptManager):
              (WebCore::InjectedScriptManager::~InjectedScriptManager):
              (WebCore::InjectedScriptManager::disconnect):
              (WebCore::InjectedScriptManager::injectedScriptHost):
              (WebCore::InjectedScriptManager::injectedScriptForId):
              (WebCore::InjectedScriptManager::injectedScriptForObjectId):
              (WebCore::InjectedScriptManager::discardInjectedScripts):
              (WebCore::InjectedScriptManager::releaseObjectGroup):
              (WebCore::InjectedScriptManager::injectedScriptSource):
              (WebCore::InjectedScriptManager::injectScript):
              * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::focusNode):
              (WebCore::InspectorAgent::didClearWindowObjectInWorld):
              (WebCore::InspectorAgent::createFrontendLifetimeAgents):
              (WebCore::InspectorAgent::didCommitLoad):
              (WebCore::InspectorAgent::domContentLoadedEventFired):
              * inspector/InspectorAgent.h:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::clearConsoleMessages):
              (WebCore::InspectorConsoleAgent::addInspectedNode):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              (WebCore::InspectorConsoleAgent::addConsoleMessage):
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::disconnectFrontend):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::discardBindings):
              (WebCore::InspectorDOMAgent::pushNodeToFrontend):
              (WebCore::InspectorDOMAgent::resolveNode):
              * inspector/InspectorDOMAgent.h:
              (WebCore::InspectorDOMAgent::create):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::create):
              (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
              (WebCore::InspectorDebuggerAgent::currentCallFrames):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorRuntimeAgent.cpp:
              (WebCore::InspectorRuntimeAgent::create):
              (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
              (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
              (WebCore::InspectorRuntimeAgent::evaluate):
              (WebCore::InspectorRuntimeAgent::evaluateOn):
              (WebCore::InspectorRuntimeAgent::getProperties):
              (WebCore::InspectorRuntimeAgent::setPropertyValue):
              (WebCore::InspectorRuntimeAgent::releaseObject):
              (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
              * inspector/InspectorRuntimeAgent.h:
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
              (WebInspector.ElementsPanel):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80844 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4cfcb169
    • sergio@webkit.org's avatar
      2011-03-11 Sergio Villar Senin <svillar@igalia.com> · c6434761
      sergio@webkit.org authored
              [GTK] JSC crashes in 32bit Release bots after r80743
              https://bugs.webkit.org/show_bug.cgi?id=56180
      
              Skipping a couple of tests until the original issue is fixed.
      
              * platform/gtk/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80843 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c6434761
    • antonm@chromium.org's avatar
      2011-03-11 Anton Muhin <antonm@chromium.org> · 84c1f734
      antonm@chromium.org authored
              Reviewed by Adam Barth.
      
              [v8] Change the way group id for CSS objects is calculated
              https://bugs.webkit.org/show_bug.cgi?id=56117
      
              Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
              as they should not be reachable in JavaScript.
      
              Covered by existing layout tests.  Fact of absence of retention is not trivial to prove.
      
              * bindings/v8/V8GCController.cpp:
              (WebCore::calculateGroupId):
              (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80842 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      84c1f734
    • sergio@webkit.org's avatar
      2011-03-11 Sergio Villar Senin <svillar@igalia.com> · 34f97397
      sergio@webkit.org authored
              Added new GTK+ test expectations.
      
              * platform/gtk/fast/backgrounds/positioned-root-expected.checksum: Added.
              * platform/gtk/fast/backgrounds/positioned-root-expected.png: Added.
              * platform/gtk/fast/backgrounds/positioned-root-expected.txt: Added.
              * platform/gtk/fast/backgrounds/table-root-expected.checksum: Added.
              * platform/gtk/fast/backgrounds/table-root-expected.png: Added.
              * platform/gtk/fast/backgrounds/table-root-expected.txt: Added.
              * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
              * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
              * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
              * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
              * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
              * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
              * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
              * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
              * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80841 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      34f97397
    • apavlov@chromium.org's avatar
      2011-03-11 Alexander Pavlov <apavlov@chromium.org> · e6a79a11
      apavlov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: hover over elements in Elements panel does not highlight nodes
              https://bugs.webkit.org/show_bug.cgi?id=56121
      
              In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
              is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
              for these 16px when computing the test point coordinates.
      
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80840 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e6a79a11
    • yurys@chromium.org's avatar
      2011-03-11 Yury Semikhatsky <yurys@chromium.org> · f2472abf
      yurys@chromium.org authored
              Unreviewed. Roll out r80837.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80839 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f2472abf
    • caseq@chromium.org's avatar
      2011-03-11 Andrey Kosyakov <caseq@chromium.org> · b26b460a
      caseq@chromium.org authored
              Unreviewied trivial fix. Leave default state of setMonitoringXHREnabled intact so it doesn't affect other tests.
      
              * inspector/report-API-errors.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b26b460a
    • yurys@chromium.org's avatar
      2011-03-11 Yury Semikhatsky <yurys@chromium.org> · d155b7b8
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
              https://bugs.webkit.org/show_bug.cgi?id=56173
      
              * inspector/protocol/console-agent-expected.txt:
              * inspector/protocol/console-agent.html:
      2011-03-11  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
              https://bugs.webkit.org/show_bug.cgi?id=56173
      
              Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              * bindings/js/JSInjectedScriptManager.cpp: Added.
              (WebCore::InjectedScriptManager::createInjectedScript):
              (WebCore::InjectedScriptManager::discardInjectedScript):
              (WebCore::InjectedScriptManager::injectedScriptFor):
              (WebCore::InjectedScriptManager::canAccessInspectedWindow):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
              (WebCore::WeakReferenceCallback):
              (WebCore::createInjectedScriptHostV8Wrapper):
              (WebCore::InjectedScriptManager::createInjectedScript):
              (WebCore::InjectedScriptManager::discardInjectedScript):
              (WebCore::InjectedScriptManager::injectedScriptFor):
              (WebCore::InjectedScriptManager::canAccessInspectedWindow):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::addToFrontend):
              * inspector/ConsoleMessage.h:
              * inspector/InjectedScript.cpp:
              (WebCore::InjectedScript::canAccessInspectedWindow):
              * inspector/InjectedScript.h:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::create):
              (WebCore::InjectedScriptHost::InjectedScriptHost):
              (WebCore::InjectedScriptHost::~InjectedScriptHost):
              (WebCore::InjectedScriptHost::disconnect):
              (WebCore::InjectedScriptHost::inspectImpl):
              (WebCore::InjectedScriptHost::clearConsoleMessages):
              (WebCore::InjectedScriptHost::databaseIdImpl):
              (WebCore::InjectedScriptHost::storageIdImpl):
              * inspector/InjectedScriptHost.h:
              (WebCore::InjectedScriptHost::init):
              (WebCore::InjectedScriptHost::setFrontend):
              (WebCore::InjectedScriptHost::clearFrontend):
              * inspector/InjectedScriptManager.cpp: Added.
              (WebCore::InjectedScriptManager::create):
              (WebCore::InjectedScriptManager::InjectedScriptManager):
              (WebCore::InjectedScriptManager::~InjectedScriptManager):
              (WebCore::InjectedScriptManager::disconnect):
              (WebCore::InjectedScriptManager::injectedScriptHost):
              (WebCore::InjectedScriptManager::injectedScriptForId):
              (WebCore::InjectedScriptManager::injectedScriptForObjectId):
              (WebCore::InjectedScriptManager::discardInjectedScripts):
              (WebCore::InjectedScriptManager::releaseObjectGroup):
              (WebCore::InjectedScriptManager::injectedScriptSource):
              (WebCore::InjectedScriptManager::injectScript):
              * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::focusNode):
              (WebCore::InspectorAgent::didClearWindowObjectInWorld):
              (WebCore::InspectorAgent::createFrontendLifetimeAgents):
              (WebCore::InspectorAgent::didCommitLoad):
              (WebCore::InspectorAgent::domContentLoadedEventFired):
              * inspector/InspectorAgent.h:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::clearConsoleMessages):
              (WebCore::InspectorConsoleAgent::addInspectedNode):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              (WebCore::InspectorConsoleAgent::addConsoleMessage):
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::disconnectFrontend):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::discardBindings):
              (WebCore::InspectorDOMAgent::pushNodeToFrontend):
              (WebCore::InspectorDOMAgent::resolveNode):
              * inspector/InspectorDOMAgent.h:
              (WebCore::InspectorDOMAgent::create):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::create):
              (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
              (WebCore::InspectorDebuggerAgent::currentCallFrames):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorRuntimeAgent.cpp:
              (WebCore::InspectorRuntimeAgent::create):
              (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
              (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
              (WebCore::InspectorRuntimeAgent::evaluate):
              (WebCore::InspectorRuntimeAgent::evaluateOn):
              (WebCore::InspectorRuntimeAgent::getProperties):
              (WebCore::InspectorRuntimeAgent::setPropertyValue):
              (WebCore::InspectorRuntimeAgent::releaseObject):
              (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
              * inspector/InspectorRuntimeAgent.h:
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
              (WebInspector.ElementsPanel):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d155b7b8
    • philn@webkit.org's avatar
      2011-03-08 Philippe Normand <pnormand@igalia.com> · c8566e9c
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] close-web-view emitted on disposed WebView
              https://bugs.webkit.org/show_bug.cgi?id=55932
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib
              source before destruction of the ChromeClient.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c8566e9c