- 05 Aug, 2014 40 commits
-
-
tburkard@chromium.org authored
prefetches would be. The hope is to obtain higher numbers than with prerender control group prerenders, since these still get cancelled for a fair number of reasons. R=asvitkine@chromium.org, davidben@chromium.org Review URL: https://codereview.chromium.org/441923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287582 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
This CL introduces the |SessionLocales| policy that can be used to recommend one or more UI locales for a public session. If the policy is set, the first recommended locale is pre-selected when starting a public session. If more than one locale is recommended, the public session pod is shown in its advanced form, highlighting the availability of language and keyboard layout pickers. The keyboard layout is automatically set to the most popular layout matching the UI locale. BUG=214904,241790 TEST=Extensive browser test coverage, including picker UI R=asvitkine@chromium.org, nkostylev@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/426063005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287581 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This change links the trusted plugin into the renderer, making it easier for the trusted plugin to use libraries in Chromium. This removes the ppGoogleNaClPlugin loadable module file on various platforms. This is part of a larger effort to remove the "trusted plugin" used to bootstrap NaCl plugins. It introduces an "internal_module" interface for setting the value returned by pp::Module::Get(). This is so that both the trusted plugin and the remoting plugin can be linked into the renderer. However, I believe this is safe because the trusted plugin runs in-process and the remoting plugin runs out-of-process. BUG=394497 R=dmichael@chromium.org, mseaborn@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org, wez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287071 Review URL: https://codereview.chromium.org/397243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287580 0039d316-1c4b-4281-b951-d872f2087c98
-
nasko@chromium.org authored
This CL adds a method to content::Referrer that allows for sanitizing the referrer before making a network request and uses it to scrub the Referer header for requests originating in the context menu. It is based on work started by cbentzel@ in https://codereview.chromium.org/277903002/. BUG=357473 Review URL: https://codereview.chromium.org/438283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287579 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
It flakes quite frequently on win_chromium_rel_swarming. Locally, it fails 100% of the time on my machine and on scottmg's. BUG=400646 TBR=msw@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/447523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287577 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
BUG=82385 NOTRY=true Review URL: https://codereview.chromium.org/440163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287576 0039d316-1c4b-4281-b951-d872f2087c98
-
timvolodine@chromium.org authored
Fix failing tests on windows platform. BUG=344379 Review URL: https://codereview.chromium.org/199743008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287574 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
In most files under sync_file_system/drive_backend/, leveldb::DB and leveldb::WriteBatch are replaced with LevelDBWrapper to have a database transparent. BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabase*:DriveBackend*:LevelDBWrapper*" Review URL: https://codereview.chromium.org/428063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287573 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
This was causing latency on switching tabs. BUG=398103,381820 Review URL: https://codereview.chromium.org/435333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287571 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
On ChromeOS, this patch should have no effect on the menu's appearance. On Windows, this patch will give the menu the new style buttons, item placement, and item strings. The rows with buttons should be the same height before and after the patch (which is less than the height for ChromeOS). BUG=365418 Review URL: https://codereview.chromium.org/431473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287570 0039d316-1c4b-4281-b951-d872f2087c98
-
dconnelly@chromium.org authored
This CL also moves the common decoration grit ID computation logic up into ManagePasswordsIcon. BUG=328847 Review URL: https://codereview.chromium.org/419263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287562 0039d316-1c4b-4281-b951-d872f2087c98
-
xingx@chromium.org authored
2. Adds a couple of functions to return different fingerprint value for tamper detection. 3. Adds a function to remove Chrome-Proxy header's fingerprint from its header values, and return the rest of header values. 4. Changes HasDataReductionProxyViaHeader to also tell whether data reduction proxy Via header occurs at the last or not. BUG=381907 Review URL: https://codereview.chromium.org/387353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287561 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287560 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/444563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287559 0039d316-1c4b-4281-b951-d872f2087c98
-
kouhei@chromium.org authored
Revert of [DevTools] Move DispatchOnDevToolsFrontend to embedder. (https://codereview.chromium.org/418243003/) Reason for revert: I think this CL broke inspector/ layout tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/35062 Original issue's description: > [DevTools] Move DispatchOnDevToolsFrontend to embedder. > > We already have a way to send message via ExecuteJavaScript, > no need for another mechanism. > > BUG=398046 > TBR=jam > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287514 TBR=pfeldman@chromium.org,jam@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=398046 Review URL: https://codereview.chromium.org/444633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287558 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
Instantiate RenderFrameProxyHost objects for remote frames when using --site-per-process. BUG=357747, 399709, 399775, 400594 TBR=kenrb, creis, kalman Review URL: https://codereview.chromium.org/444503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287557 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287556 0039d316-1c4b-4281-b951-d872f2087c98
-
capn@chromium.org authored
Aside from MANGLE refactorings this fixes using -1 in a D3D11 index buffer. BUG=396058 Review URL: https://codereview.chromium.org/427333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287555 0039d316-1c4b-4281-b951-d872f2087c98
-
shreyas.g@samsung.com authored
(like LayerAnimationController::NotifyObserversOpacityAnimated) While sending the notification to the observers, the notify settings of the animation (active and pending) are checked against the state of the observer (whether active or not). In most cases, the default setting of the animation will set active and pending as true. So in those cases there is no need to check for the active state of observer. This patch first checks if both active and pending state are true for animation. If yes then it proceedes sending the notification to observer and there is no need to check the active state of observer. Review URL: https://codereview.chromium.org/441913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287554 0039d316-1c4b-4281-b951-d872f2087c98
-
mallinath@chromium.org authored
happens when domain name is not resolved through DNS. BUG=https://code.google.com/p/webrtc/issues/detail?id=3384 R=jiayl@chromium.org TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/439153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287553 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
This must be dcommit'd because CQ corrupts PNG files when landing them. crbug.com/339068 BUG=none TEST=none R=rockot@chromium.org TBR=rockot@chromium.org Review URL: https://codereview.chromium.org/424123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287552 0039d316-1c4b-4281-b951-d872f2087c98
-
shreyas.g@samsung.com authored
LayerAnimationController::AccumulatePropertyUpdates The animation value is computed from the animation curve. The general format used is to get the specific animation curve into one variable and then use the getvalue to get the actual animation value. The same is followed across the file except in AccumulatePropertyUpdates. This patch takes cares of the same. Review URL: https://codereview.chromium.org/440873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287551 0039d316-1c4b-4281-b951-d872f2087c98
-
ricea@chromium.org authored
Previously, multiple simultaneous wss: connections to the same endpoint did not work because the endpoint lock was not correctly released at the end of the handshake. This happened because the socket was wrapped for SSL and so the original socket address that was passed to RememberSocket() was not the same one passed to UnlockSocket(). Make releasing of the lock on successful handshake happen using the address provided by GetPeerAddress() instead of the RememberSocket() mechanism. This will not work if the socket has already been closed; however, in that case the socket should be rapidly returned to the pool anyway at which point UnlockSocket() will be called as normal. Also add a browser test for multiple simultaneous wss: connections (WebSocketBrowserTest.SSLConnectionLimit). BUG=398737 TEST=net_unittests, browser_tests Review URL: https://codereview.chromium.org/436493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287550 0039d316-1c4b-4281-b951-d872f2087c98
-
abhishek.a21@samsung.com authored
Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to test_common. 5) Removed un-used test_common header. BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287382 Review URL: https://codereview.chromium.org/436133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287549 0039d316-1c4b-4281-b951-d872f2087c98
-
jbudorick@chromium.org authored
Some versions of gtest print type- and value-parameterized tests with their respective parameter as a comment after the test name when listing tests. This patch should allow the android test runner scripts to correctly ignore these comments. BUG= Review URL: https://codereview.chromium.org/441783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287548 0039d316-1c4b-4281-b951-d872f2087c98
-
csharp@chromium.org authored
BUG=399744 Review URL: https://codereview.chromium.org/440663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287546 0039d316-1c4b-4281-b951-d872f2087c98
-
mfomitchev@chromium.org authored
for Ozone. The Ozone flake hasn't been reported on non-ozone trybots. Created a separate bug for Ozone flake: http://crbug.com/399676 and added some analysis. BUG=357311 Review URL: https://codereview.chromium.org/428303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287545 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TBR=tonyg BUG=366899, 400747 Review URL: https://codereview.chromium.org/439943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287544 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
BUG=400094 Review URL: https://codereview.chromium.org/422443008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287543 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287542 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179497:179499&mode=html TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org BUG= Review URL: https://codereview.chromium.org/445553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287541 0039d316-1c4b-4281-b951-d872f2087c98
-
jbroman@chromium.org authored
gtest.h is included pref_store_observer_mock.cc and testing_pref_service.cc. Found using 'gn check'. Review URL: https://codereview.chromium.org/435983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287540 0039d316-1c4b-4281-b951-d872f2087c98
-
rdsmith@chromium.org authored
Note that this also involved copying neterror.css/js over to chrome/browser/resources/ssl so as to break the dependency between blocking.html in that directory and the css/js files in chrome/renderer/resources. That copy means that, while I'm going through presubmit errors before uploading, I"m not fixing them all-- there are pre-existing errors in neterror.css that I don't have the expertise to fix. BUG=None Review URL: https://codereview.chromium.org/422933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287538 0039d316-1c4b-4281-b951-d872f2087c98
-
hush@chromium.org authored
2 problems here: 1. Setting the frame time to 0 does nothing, because LTHI will read from gfx::FrameTime::Now() instead. Need to start at 1 millisecond. 2. Need to tick the frame timer after SetupDrawPropertiesAndUpdateTiles. BUG=399796 Review URL: https://codereview.chromium.org/444463004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287536 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
. Add a shadow around the bottom-view of the home-card. . Make the background slightly transparent. . Make the bottom-view slightly narrower. . Remove the borders around the apps. BUG=none R=mukai@chromium.org TBR=sky@chromium.org for DEPS on ui/gfx/ from athena/home Review URL: https://codereview.chromium.org/439673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287535 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
Followup to https://codereview.chromium.org/403343002/ This CL renames ChromeOS-specific resource IDs (strings/images) Still missing: - The global ENABLE_MANAGED_USERS define TBRing a bunch of renames. TBR=oshima@chromium.org (ash and c/b/ui/ash) TBR=antrim@chromium.org (c/b/chromeos and ui/login) BUG=385113 Review URL: https://codereview.chromium.org/425293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287534 0039d316-1c4b-4281-b951-d872f2087c98
-
vivek.vg@samsung.com authored
Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets. This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb. Part 1: https://codereview.chromium.org/436843004/ Part 1 with conditional: https://codereview.chromium.org/440683004/ Part 3: https://codereview.chromium.org/438843004/ BUG=312586 Review URL: https://codereview.chromium.org/422023008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287532 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
Revert of Resubmit: Remove deprecated extension notifications from ProcessManager (https://codereview.chromium.org/434593002/) Reason for revert: Speculative revert, see http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5773/steps/unit_tests/logs/GetHostZoomMap The stack trace mentions extensions::ExtensionRegistry::RemoveObserver Original issue's description: > Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead. > > ProcessManagerTest inherts ExtensionsTest for the test settings. So now unit test is passed. > > R=rdevlin.cronin@chromium.org > BUG=354046 > TEST=extensions_unittests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287521 TBR=rdevlin.cronin@chromium.org,limasdf@gmail.com NOTREECHECKS=true NOTRY=true BUG=354046 Review URL: https://codereview.chromium.org/443623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287530 0039d316-1c4b-4281-b951-d872f2087c98
-
mkosiba@chromium.org authored
This fixes a typo. BUG=None TEST=None Review URL: https://codereview.chromium.org/442743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287529 0039d316-1c4b-4281-b951-d872f2087c98
-
merkulova@chromium.org authored
BUG=398880 NOTRY=true Review URL: https://codereview.chromium.org/440053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287528 0039d316-1c4b-4281-b951-d872f2087c98
-