- 22 Jan, 2021 40 commits
-
-
Nathan Zabriskie authored
Currently with some texture sizes GLES2Util::ComputeImageDataSizesES3 will attempt to add row padding when calculating the size of a VideoFrame plane. This is because it's currently assumed that each row aligns on a 4 byte boundary based on GL_UNPACK_ALIGNMENT but VideoFrames make no such guarantee as they may be densely packed. This CL removes the GL_UNPACK_ALIGNMENT assumption so that we only use the VideoFrame's stride when calculating padding. Bug: 1166504, 1161131 Change-Id: I2484f5dfd2ad85b088fee57758776a5c9bd01d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642765Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846298}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1d5174b9dc3b..3fe96b789504 2021-01-22 capn@google.com Target macOS 10.14 on ARM64 to enable C++17 2021-01-22 bclayton@google.com Merge changes I6c21b03d,Ic6136d02,I988c0288,I21d11818,I79fa8162, ... 2021-01-21 capn@google.com Implement non-void indirect Reactor Call() support 2021-01-21 amaiorano@google.com Make RoutineT::getEntry() type safe 2021-01-21 swiftshader.regress@gmail.com Regres: Update test lists @ b3e5c440 2021-01-21 capn@google.com Target macOS 10.12 when building LLVM 2021-01-21 capn@google.com Use aligned allocation for classes with aligned members 2021-01-21 nicolascapens@google.com Enable and require C++17 compilation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I00e926222eb0c3c21c1eca6556da874af335badb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846297}
-
yilkal authored
This cl makes sure that the dialog size and bounds are consistent with the rest of onboarding flow. Bug: 1169786 Change-Id: Ie433562bf353a287eaa8449cc8e50c27c0bce4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645298Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846296}
-
Andre Vincent authored
As of now, the Drive Service fetches an access token. Fixed: 1166345 Change-Id: I9446d5811ea1726c8865c7f3604da1554cce4fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628048 Commit-Queue: Andre Vincent <andrevincent@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#846295}
-
Klaus Weidner authored
The onbeforexrselect event is supposed to be part of GlobalEventHandlers and separately inherited by {HTML,MathML,SVG}Element, Window, and Document. The current implementation had added it at the Element level which isn't correct, causing test failures in the idlharness test. Update the implementation to fix the inheritance, which unfortunately adds a bit of extra boilerplate. Also add objects to the idlharness test to verify the inheritance. Spec: https://immersive-web.github.io/dom-overlays/#onbeforexrselect Fixed: 1108685 Change-Id: I8df73304b7b2d9bd93df30b78953aa9b378f8cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317813 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#846294}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/app_mode. Bug: 1148570 Change-Id: I92338ffa90e975cf9c79e151f2c784a55ddd2556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645404 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#846293}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611316382-256aee3c7474e8e8ef074b7619cf9a4131f41980.profdata to chrome-mac-master-1611338398-fa58905b438c50560fef9145146b7c6ec25beb1e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I67b394ba47370b8116884835e0a51d44fa6e297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645325Reviewed-by:
-
Gauthier Ambard authored
This CL ensures that the fakebox width is correct when the screenshot of the NTP is taken. It was wrong as the width was first computed while the collection view had a zero width. The width is now re-computed when the NTP is added to its parent ViewController. Fixed: 1165956 Change-Id: I63cf57584fe185280956779791973495092dfbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640440 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#846291}
-
Roberto Carrillo authored
Also, accept a flag on builder() to specify this, but make it False by default. R=chanli,nodir,bpastene@chromium.org Bug: 1074407 Change-Id: Ic27a484138f7ccedab2f0daebed4bccc448a435d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644319 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#846290}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I739bd6b4cdda298c4d9bdc58d4684fe389806a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644524Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611316382-94c9fd181d84cd42486f5188444029563baefc6b.profdata to chrome-linux-master-1611338398-a577d8d6149e541857ea88692e66f5943d6a799b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I171a65164c559f4147ebe0b8b95f160d7a130012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645324Reviewed-by:
-
Victor Costan authored
This CL replaces calls to base::TaskEnvironment::RunUntilIdle() with a base::RunLoop that is Quit() when the tested function's base::Callback is executed. A few minor cleanups are included. Change-Id: I94488c922df13fe67bdd246c80c7f15064a1bda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644144 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#846287}
-
Jonah Chin authored
This CL parameterizes PaintCanvasVideoRendererWithGLTests to run tests with and without OOP raster. It also updates RasterInProcessContext to use the thread's task runner instead of TestSimpleTaskRunner. This ensures that OOPR tests can still use base::RunLoop::Run to trigger their posted callbacks. Bug: 1115217 Change-Id: I663bf6c2cb9ce2d13222a2bb8bc7f6189a91e517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519172Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846286}
-
Mikel Astiz authored
In this patch, GaiaScreenHandler adds support to deal with the received sync trusted vault keys. This information is wrapped in a new class (SyncTrustedVaultKeys) and propagated via UserContext to UserSessionManager, where during profile preparation is propagated to SyncService and consumed. Browser tests are introduced to exercise the whole integration, from the server (FakeGaia) to the final storage (TrustedVaultClient). Change-Id: I3cdc16086b2eec2b2a603255ed644c7b1f53192e Bug: 1081651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590035 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846285}
-
Mohamed Amir Yosef authored
... in AutofillBubbleHandler. Before this patch: Each bubble used to call the enum value using its own class name. (specifically SaveCardBubbleViews and LocalCardMigrationBubbleViews) After this patch: LocationBarBubbleDelegateView is used instead when referring to USER_GESTURE and AUTOMATIC enum values. Change-Id: I4bfb79713443f608cee6d245af8c2064793e6d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644624 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#846284}
-
Martin Rodriguez authored
In policy_test_cases.json there is a typo in the test definition of `ClearBrowsingDataOnExitList`, `policy_pref_mapping_test` (the suffix should be `tests`). This typo make to skip this test. This CL fix this typo making the policy mapping be tested. Bug: b/178171564 Change-Id: Id432006e15ad7747de1ea0e12c152aca28cb0be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643722Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Martin Rodriguez <rodmartin@google.com> Cr-Commit-Position: refs/heads/master@{#846283}
-
Jeffrey Young authored
This is a reland of d82af7a9 Move ambient photo controller reset to fix use-after-free. Fix possible race condition with |AmbientPhotoController| by clearing photo cache upon sending network request to update settings. Old behavior showing bug: * User toggles on Ambient Mode, changes photo setting * |UpdateSettings| is called and sends network request * User toggles off Ambient mode, |AmbientPhotoController| is destructed * Network request resolves and |AmbientPhotoController::ClearCache| is called Original change's description: > ambient: construct photo_controller on enabled > > AmbientPhotoController and AmbientPhotoCache are only necessary > when a user is logged in and ambient mode is enabled. Construct them > at that time, and destruct them if ambient mode is disabled. > > Schedule fetching backup images when AmbientPhotoController is > constructed, rather than in OnFirstSessionStarted. > > BUG=b:176094707 > TEST=ash_unittests --gtest_filter="AmbientControllerTest.*" > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Id87bb16e6d4cc14074dd9bdb352fb5795d0f8915 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605744 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842133} Bug: b:176094707 Change-Id: I485fef447e6afb92ac5f66a7991e7ec477be30da Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626511 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#846282}
-
Christian Biesinger authored
No need for this test to be async; I think this was copy-pasted from the video or img test which do need async. R=masonfreed@chromium.org Change-Id: I0f9a6e651fa3914fb8ae35ec8cd856cc839a8e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643071 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#846281}
-
Mark Edward Winter authored
Use constexpr maps when possible inside the browser/ui directories R=chromium-chrome-browser-ui-views-reviews@google.com Bug: 1150744 Change-Id: I2ecfc10c911d6242cf7bafafe9878673a9ba2c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642384Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#846280}
-
Michael Thiessen authored
We can get into a situation where an Activity is finished before Deferred startup finishes, then the old DeferredStartupHandler finishes during startup of the next test and a new instance is created before we wait for deferred startup completion. The solution is just to hold onto the DeferredStartupHandler instance in tests during startup to ensure a new instance isn't created. The test that's actually flaky under these circumstances is TabbedActivityLaunchCauseMetricsTest#testMainIntentMetrics Change-Id: I4e172f77c3ebad45f5b3236b68614b2b152c718c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643030Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#846279}
-
Michael Hansen authored
This change lets us observe screen idle state (on/off state) so that we can invalidate send and receive surfaces in response. This also collapses PowerClientChromeos into PowerClient since we no longer need to guard Chrome OS-specific functionality. Fixed: 1169262 Change-Id: I893df57d113590c0e09a81a381c3a291b74fd00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643918Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#846278}
-
Jun Mukai authored
On the failed case of ui.HotseatAnimation tast test, app-list is actually animating, and HomeLauncherStateWaiter is not used, thus the callback is never invoked. This CL cleans up the condition for HomeLauncherStateWaiter to be used. Note: this CL also adds a test case of autotestPrivate API. However, this new test case does NOT reproduce the reported problem -- it passes even without the change of autotest_private_api_utils.cc. I couldn't find the way to reproduce the reported problem within browser_tests. Still, I think it's better to have a basic test case of waitForLauncherState in tablet-mode, as its internal code path is significantly different. Bug: 1167225 Test: ui.HotseatAnimation.non_overflow_shelf tast test Change-Id: I33352f216af795e20d651942ce219feb5c4f052a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640928 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Fabian Sommer authored
This CL implements the core part of SecurityTokenSessionController. The controller observes security tokens and triggers lock / logout when a token that was used for login is removed, alongside UI implemented in previous CLs. This behavior can be controlled by the SecurityTokenSessionBehavior and SecurityTokenSessionNotificationSeconds policies, which this CL activates. This CL also adds browser tests for both policies. In doing so, it also adds a test for SecurityTokenRestrictionView. The CL renames the should_fail_certificate_requests property in TestCertificateProviderExtension to should_provide_certificates, which more accurately reflects its purpose. Fixed: 1131450 Change-Id: I8cf4e25fbbcb8ae4ab607ace254a85197f594f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632990 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#846276}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bef4c393..783a881e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I82258411117e2f8f0b647cf54410211e72f21de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846275}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc6961b9ac5e..793871779799 2021-01-22 johnstiles@google.com Update folding tests to return pass/fail status. 2021-01-22 johnstiles@google.com Add checkpointing functionality to the Parser. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ia4b973008a18377d790f17908d30cf2de494ff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643189Reviewed-by:
-
Abigail Klein authored
one of their languages. Since Live Caption currently only works for English, we should not advertise the feature to users who we do not expect to want English captions. We can make a guess as to which users would want English caption by checking whether English is one of the user's fluent languages, found in chrome://settings/languages. Bug: 1169760, 1055150 Change-Id: Id16e99de1edb777b8d5b2d793f0dcbefc925935d AX-Relnotes: Live Caption only promoted to English-language users. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643443Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#846273}
-
Yusuke Sato authored
The function has been moved to platform2/arc/setup/. BUG=chromium:1163122 TEST=try Change-Id: I12fe15ee0d86a5be443f27ec7640e0298114102b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611179 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846272}
-
Wenyu Fu authored
Fix the flaky test by adding a dummy view. This helps collecting the focus when it is cleared in RadioButtonWithEditText. This is however a short-term solution and should be revisited with a fix on the widget itself. For more details see the original crbug. Change-Id: Ibae61514ffc98c253db4a8bd63498967178d523f Bug: 1169215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644935 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#846271}
-
Yusuke Sato authored
The former has been moved to platform2/arc/setup. The latter is not used anymore. BUG=chromium:1163122 TEST=try Change-Id: I104a468668b7e56087740818ef5cdf93a370f761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613398 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Monica Basta authored
This CL resets the invalid state of the input profile name on the profile picker's local profile creation flow on navigation to the flow if the profile name is empty. Fixed: 1169724 Change-Id: I81ab063edbc544102aea0dc439e8b2de18774898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643731Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#846269}
-
Matt Jones authored
This patch adds a LayoutManagerProvider with a static method to access the activity's LayoutManager. This patch has a fair amount of indirection to keep certain apis internal and the public api clean. LayoutManagerAppUtils: A utility class only exposed to app or glue code to attach the LayoutManager to the window. This exists in its own build target with ManagedLayoutManager. ManagedLayoutManager: Another app/glue code api for lifecycle management. This extends LayoutManager and includes other external signals that would not otherwise be exposed through the LayoutManager interface. LayoutManagerProvider: This is the main access point for clients wanting an instance of the LayoutManager. LayoutManagerProvider.Unowned: A package-protected interface for obscuring attach and detach method implementations in the public api. Bug: 1161560, 1167255 Change-Id: Ie9561cd6d9dafcca8acac54a85c3c7bc27ca085e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634003Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#846268}
-
Monica Basta authored
Fixed: 1162443 Change-Id: I32b86c1d8bb600e45920aaf508a2ad313354e930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645124Reviewed-by:
-
Lukasz Anforowicz authored
After this CL, blink::ResourceFetcher should not start HTTP requests if an MHTML archive is present. Additionally tweak GetCacheIdentifier to make sure that globally cached requests (e.g. fulfilled via HTTP) are not reused for requests within MHTML archive. Change-Id: I3b7253c22bc42b941d9abd8dec82e58f730dd815 Bug: 1168249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638219Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#846266}
-
Owen Min authored
CloudReportingExtension is fully deprecated in Chromium. Hence we no longer need to support them in the management UI. Also removing safe browsing message from the management UI as there is nothing display this message. Bug: 1107440 Change-Id: I67eab265860a2b31930fd8255027bf6109a19b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642186Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846265}
-
James Cook authored
Regression test for https://crbug.com/1157664. Verifies that opening a menu via long-press on a tab does not result in a popup window with empty bounds. In production this bug caused a Wayland protocol error and lacros crash. Adds a new test crosapi to inject touch events from the ash side. See comments in test for why we do it this way. I verified that this test fails appropriately when the fix for the original bug is reverted. The test does not reproduce the Wayland protocol error, because that error is in code that only runs when graphics overlay forwarding is enabled, which only happens on device. However, it's sufficient for the test to verify that the popup in lacros has non-empty bounds. Bug: 1157664 Test: lacros_chrome_browsertests Change-Id: Ia8aabaec1d6ec4bc72d1e77eda9a7f0efbe5f0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643026 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846264}
-
Owen Min authored
Round II EXPECT_DEATH tests are executed in a sub-process. However, this doesn't work with the BrowserWithTestWindowTest which requires access to the global |g_browser_process| instance. Running in a sub-process causes crash during SetUp(). The test was passed as EXPECT_DEATH can catch the crash inside SetUp() but it didn't check the crash error message. There is no good way to solve this issue, hence only run the NoExtension test while DCHECK is off and no longer verify any DCHECK failure. Bug: 1137094 Change-Id: I59a9eb4ab0c6283194dbd80f8f1afec15410def0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643629 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#846263}
-
Nina Satragno authored
This reverts commit d2adbc52. Reason for revert: causing ~600 html failures on tests Example stack trace STDERR: Received signal 11 SEGV_MAPERR 000000000099 STDERR: #0 0x56419ad17d39 base::debug::CollectStackTrace() STDERR: #1 0x56419ac8fc63 base::debug::StackTrace::StackTrace() STDERR: #2 0x56419ad178e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7f96ed01d390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) STDERR: #4 0x56419c8a9228 WTF::StaticSingleton<>::StaticSingleton<>() STDERR: #5 0x56419c8a90cc blink::CounterStyleMap::GetUACounterStyleMap() STDERR: #6 0x56419c8da407 blink::StyleEngine::FindCounterStyleAcrossScopes() STDERR: #7 0x56419ce564a7 blink::ListMarker::GetCounterStyle() STDERR: #8 0x56419ce5640e blink::ListMarker::GetListStyleCategory() STDERR: #9 0x56419ce56d3e blink::ListMarker::InlineMarginsForInside() STDERR: #10 0x56419c8846ae blink::StyleAdjuster::AdjustComputedStyle() STDERR: #11 0x56419c877f3c blink::StyleResolver::PseudoStyleForElement() STDERR: #12 0x56419c964063 blink::Element::StyleForPseudoElement() STDERR: #13 0x56419c9a6bd9 blink::PseudoElement::CustomStyleForLayoutObject() STDERR: #14 0x56419c95b52f blink::Element::StyleForLayoutObject() etc see e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/22892/test-results Original change's description: > Refactor counter style updates > > Currently, counter style updates is a phase in UpdateActiveStyles. This > patch moves it out as a standalone phase of UpdateStyleAndLayoutTree, > so that we update counter styles only when needed. > > This patch also adds MarkCounterStylesNeedUpdate() to indicate whether > counter style updates are needed. > > Note: After refactoring, the framework of counter style updates looks > almost identical to font updates. This is intentional. We will try to > unify them in the future. > > Bug: 687225 > Change-Id: If07de2878ae5faa6800644a967029a569bef566a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846203} TBR=xiaochengh@chromium.org,futhark@chromium.org,andruud@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3c1e09dce14cd4edb366b911d3aaf5da66b2b100 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 687225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644742Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#846262}
-
Nicolas Arciniega authored
This policy allows an admin to specify a list of URLs for which their users can bypass the SSL error interstitial when the existing SSLErrorOverrideAllowed policy is enabled. On all other URLs, their users will not be able to bypass the SSL error interstitial. This policy has no effect if SSLErrorOverrideAllowed is disabled. Bug: 1156778 Change-Id: I4294c96f0bea4dfcc405e1d57539e92b4bda33ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631291 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
-
Rahul Singh authored
This CL updates the MFAttributes we use for video capture on Windows. By default, we only include MFAttributes for RGB color cameras. So, the resulting device enumeration contains only RGB cameras. When the newly added `kIncludeIRCamerasInDeviceEnumeration` feature flag is enabled, we also include MFAttributes for IR cameras. The resulting device enumeration contains both RGB and IR cameras. Testing: Created versions of the GetDevicesInfo unittest with the feature flag enabled, and with it disabled. Bug: 1144049 Change-Id: Id234413f5125e866be5177141decfc9a68bc2fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631409Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846260}
-
Sophie Chang authored
Bug: 1107336 Change-Id: Ia380c1f73fb2f5c768eb4c94602f061aafac3cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638445 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846259}
-
