- 24 Apr, 2020 40 commits
-
-
Aran Gilman authored
The tests did not previously use an established test framework, making tasks like executing certain code before or after every test and testing asynchronous code more difficult. It should also be easier for developers familiar with JavaScript testing in general and WebUI testing in particular to read and write JavaScript tests for DOM Distiller and Reader Mode. Follow-up work includes replacing the custom assert methods with Chai, as well as writing more tests to cover existing functionality. Bug: 1027612 Change-Id: I39acc923a0424881d2694281d9aa0323c8f9a913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992504Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#762551}
-
Vladimir Levin authored
We already had code to ensure that we don't recurse down into locked subtrees from within the visual overflow calculation. However, compositing navigates a different tree that can end up calling into a visual overflow recomputation on an object that is already inside a locked subtree (thus bypassing the checks in that function). This patch fixes the problem by blocking the compositing recursion on locked subtrees. This should be a performance optimization as well, so there's that. Note that I've updated the code to check for prepaint block not paint block. The difference is that prepaint can be forced. Since compositing relies on the visual overflow calculations, and compositing itself can be forced, the two need to align. Note that there is already a TODO for adding a separate compositing phase which should clear this up in the future. R=chrishtr@chromium.org Fixed: 1073452 Change-Id: I232427fef2093d30451323924bb80efe49832a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163409 Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#762550}
-
Frank Tang authored
zn is not an assigned ISO 639 language code and likely to be a typo of zh here. Correct it to the correct value zh to avoid code copy the wrong value for other tests. Bug: 1072175 Change-Id: I9141966d4ab9468b86a2142ad55bfbde2c57f3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157926Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#762549}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/89e298161eb3..5dc591fc6198 git log 89e298161eb3..5dc591fc6198 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 thestig@chromium.org Give CBC_SymbolInfo methods Chromium-style names. 2020-04-24 thestig@chromium.org Remove unneeded dependency for pdfium_diff target. 2020-04-24 gourabk@microsoft.com Add public API to support forced colors mode Created with: gclient setdep -r src/third_party/pdfium@5dc591fc6198 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I97a7c753e3095ec49e88bbc4394eda69f7c8ef74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762548}
-
Brian Sheedy authored
Doubles the tolerance for the GPU Maps pixel test from 3 to 6. This should hopefully get the test passing more consistently on the NVIDIA Shield devices. TBR=ynovikov@chromium.org Bug: 1043129 Change-Id: I45f87c37814825788690c830f3c9858257bd91b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165715Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#762547}
-
rajendrant authored
This CL implements eagerly loading the first K images heuristic for preload scanner. This CL also refactors lazyload logic in preload scanner to a separate function. Bug: 996963 Change-Id: I6c4c0414ee6e2f004f896720ad623031a84953da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804496 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#762546}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/efe0c6ebec56..59850f2c018b Created with: gclient setdep -r src-internal@59850f2c018b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042017,chromium:1046880,chromium:1071977,chromium:1074058 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: Ib1655cb81e88c25dec8602b6558d4ce3c4edfd9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165442Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762545}
-
Ankit Kumar authored
This change enables logging cases where we have multiple overlapping links and highlights in a single PDF page within an accessibility context. This data will help evaluate whether the text run breaking algorithm needs to be fine tuned for such cases. A method to count link and highlight overlaps is added, along with a test. Bug: 1008775 Change-Id: I367ef82211958ecaeeb07c820a551524db02226c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156645 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#762544}
-
Philip Rogers authored
The root background is painted from the coordinate space of the root element, but expands to fill the viewport. The difference between these spaces needs to be used as an offset when painting the background. For the non-transform case, this patch removes the paint offset adjustment made to the entire paint rect in ViewPainter, and only applies the paint offset for positioning the background in BackgroundImageGeometry::ComputePositioningArea. This way, painting starts from the origin, without paint offset. For the transform case, paint properties will apply the paint offset, and the entire paint rect needs to be adjusted to remove the paint offset. This patch specifies the transform state of the view and root element, and uses GeometryMapper to map the background paint rect into the coordinate space of the root element. A TODO has been added to more clearly specify the non-transform and transform cases. Bug: 1071957 Change-Id: Iedc1834ef9c400340b668b3eec73a0f3f4506194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161350 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Jia authored
This is the last part in changing the impl to c++ directly. For easier review 1. Diff between base and patch 1: - change names of factory .h and .cc files 2. Diff between patch 1 and patch 2: - change Factory class name - delete proxy class - implement LocalSearchService as a KeyedService, which is returned by the factory Bug: 1064424,1018613 Change-Id: I0c5a69088f991be3dbe827e15f28706504cc2170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162521Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#762542}
-
Henrique Nakashima authored
The example test_dummy is changed in https://chromium-review.googlesource.com/c/chromium/src/+/2157772 Some paths were outdated, assuming the module and the feature were in the same directory. Bug: 1071976 Change-Id: I65763bdd8071f3317edafe3de38b344cf254a756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165714 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#762541}
-
Roman Sorokin authored
Add waiters to WelcomeScreenBrowserTest.WelcomeScreenLanguageSelection Fix statements in WelcomeScreenBrowserTest.WelcomeScreenKeyboardSelection Bug: 1025396 Change-Id: Iea3b40b08910baae9e8a3d8214f0b292b5cd41c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164505 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#762540}
-
Bo Liu authored
Add ImmutableWeakReference that throws in clear(). Then use it in WindowAndroid and keep returning the same instance to clients to avoid gc churn. Change-Id: I568d5b5047214ebf8c6df776407b3c5fb368a6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165148Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762539}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/016ec06f4b68..f727d4670d60 git log 016ec06f4b68..f727d4670d60 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 rmhasan@google.com typ: Add method that adds more expected results to test expectations Created with: gclient setdep -r src/third_party/catapult@f727d4670d60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050754,chromium:1050760 Tbr: nuskos@google.com Change-Id: I6d886863ad30a7016ef1a96fc8e5ecbd9c071033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165441Reviewed-by:
-
Michael Crouse authored
This change adds a function that optimization guide clients can use to insert hints into the guide without knowledge of how the hints are fetched and stored. Bug: 1035698, 1074020 Change-Id: I30134ddafd93e4b0b564ff1a52f95e6943819b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163577 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#762537}
-
Megan Jablonski authored
Bug: 1071688 Change-Id: I2386f4ffcbe5d2b92b2bddcbcd9afb23bf66bbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159778Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#762536}
-
Nate Chapin authored
Change-Id: I89d2664735000d143a8cb0b943c61c76a89ecd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113514Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#762535}
-
Kyle Horimoto authored
This CL migrates Crostini UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: Iaf4e84cb39b30386a3baf87c82b67c2d8055e4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164038Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#762534}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c8660b1650ce..1b8ef63876eb git log c8660b1650ce..1b8ef63876eb --date=short --first-parent --format='%ad %ae %s' 2020-04-24 rgl@google.com Add an optional override for AudioRecord device Created with: gclient setdep -r src/third_party/webrtc@1b8ef63876eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifc3084fa7e63e0c8b806ae525fa174605c811ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165440Reviewed-by:
-
Ali Juma authored
This changes SafeBrowsingService into a pure virtual interface, moves the implementation to a new SafeBrowsingServiceImpl, and creates a new FakeSafeBrowsingService implementation. This fake implementation creates FakeSafeBrowsingUrlCheckerImpls that treat all queried URLs as safe. This CL uses FakeSafeBrowsingService in TestingApplicationContext, which lets us simplify SafeBrowsingTabHelper, since it no longer needs to handle the case where the current ApplicationContext returns a null SafeBrowsingService. Change-Id: I515e0e53a28b4f9173fcae892dd993e159dbc7b5 Bug: 1060300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106804 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#762532}
-
ckitagawa authored
Add a TODO about investigating an alternative sandbox. Bug: 1074323 Change-Id: Ic1b80a42fb2ae4b229d29513b4a3f2a0518777cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164571 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#762531}
-
David Bertoni authored
These Tab Capture API tests should be enabled per the referenced bug. Bug: 177163 Change-Id: I8ca71238532e245ae08216f4a7aa948eb1e916da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165706Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#762530}
-
Matt Mueller authored
net: url_request_unittest: add expected_ prefix to response_status and cert_status fields in OCSPVerifyTestData Makes it more obvious which fields are the test inputs and which are the test expectations. Change-Id: I5f4fb14b006954f910ff8cf65c9a4137b4b11565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165654 Commit-Queue: Matt Mueller <mattm@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#762529}
-
Matthew Porter authored
Modified Notification View to take out hardcoded colors. Moved them to NativeTheme::ColorId and used the GetSystemColor call at the different references to it. Replaced NotificationButtonMD with MDTextButton. Changed accent_color to base::Optional<SkColor>, updated associated calls to account for that Bug: 1056948 Change-Id: I28345c6b7f64301d1706531dc7df817348414d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141215 Commit-Queue: Matthew Porter <matt.porter@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#762528}
-
Haiyang Pan authored
The traffic in L CQ is relatively large after it is turned on. Remove this test suite for now to reduce test load. No-Try: true Bug: 1032336, 1060245 Change-Id: I2598b2a46ab411108a49f4170e2a1b7d5f3468e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165459Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#762527}
-
David Bertoni authored
Bug: 1071220 Change-Id: I6ff87fa96986647a8290707c148e643d4d45d55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151845 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#762526}
-
Alex Gough authored
No processes should be launched with an invalid combination of flags for sandboxing. This eliminates SandboxType::kInvalid and adds a CHECK at the point where the command line is parsed when child processes start. Unit tests exist for this code and continue to pass. Tests that verified that bad command lines were recognized are now removed as Chrome will safely CHECK in these cases. The following changes in default or behavior:- * cloud print service (--type=service) now reports kNoSandbox * NaCl loader process on non-Mac now reports kUtility - The NaCl loader defines its own sandbox but its command line is processed in some tests and needs a valid value. * Fuchsia: sandbox types are now enumerated and the type must be specified when the low level sandbox policy is constructed. * Linux: type added for Zygote to have before it grows up to get a real sandbox Bug: 1065087 Change-Id: Ibe277153fa58771d12bae7e3c2f9c6b92b9370a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120049Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#762525}
-
Aran Gilman authored
This reverts commit 23979013, which reverted an earlier implementation of this CL in commit a18fd063 due to https://crbug.com/1065341. The main functional difference between this and the original version is where the JavaScript code calls the pref-storing functions. They were previously called inside useTheme() and useFontFamily() instead of the UI callbacks. Changes to the synced prefs result in a series of observers being notified, which ultimately led to the useTheme() and useFontFamily() methods being called again, potentially leading to an infinite loop and the behavior seen in the bug. The updateThemeSelection() method from the original CL was excluded in this reimplementation because it was unintentionally never called in the original CL. Omitting it helps reduce the scope of the CL and highlight the important changes. Bug: 1016615, 1065341 Change-Id: Ifd0e71027afd196267419ed81f7bdc0d78978a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152901Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#762524}
-
Wenbin Zhang authored
Android builders on perf waterfall started failing since this commit. Reverting this change to mitigate. https://ci.chromium.org/p/chrome/g/chrome.perf/console?limit=200 Revert "Remove/replace unnecessary logging.h includes in .cc files (ipc)" This reverts commit ba6e417c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove/replace unnecessary logging.h includes in .cc files (ipc) > > CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved > to the much smaller headers check.h, check_op.h, and notreached.h, > respectively. > > This CL updates .cc files to use those headers instead when > possible, with the purpose of saving compile time. > > (Split out from https://crrev.com/c/2164525 which also has > notes on how the change was generated.) > > Bug: 1031540 > Change-Id: I9b41171cc43f427005f9a9d78e5cd61341ebeb40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164512 > Commit-Queue: Tom Sepez <tsepez@chromium.org> > Auto-Submit: Hans Wennborg <hans@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762412} TBR=hans@chromium.org,tsepez@chromium.org Change-Id: I21ebe546731e74bec8178d6bca889c1aeb4239c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165458Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#762523}
-
Morten Stenshorne authored
Each layout algorithm had a small portion of duplicated code to set up the fragment builder for block fragmentation. Move this into a SetupFragmentBuilderForFragmentation() utility function. Also move the code that sets the first-for-node bit and the sequence number into this function. This used to be done as part of FinishFragmentation(), but that function is skipped in cases where the fragmentainer size is unknown (column balancing pass). For now this doesn't cause any known problems, but I'm working on a CL that will require it to be correct. The old SetupFragmentation() was renamed to SetupSpaceBuilderForFragmentation(), to avoid confusion. No behavior changes expected for now. Change-Id: I17aa3c491bb4f3b03aa83d2f5db766df22964cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164516Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#762522}
-
Matt Mueller authored
The revocation_status field is only used when |response_status| == PROVIDED. (Both in the current test data and as defined in the OCSPVerifyResult header: https://source.chromium.org/chromium/chromium/src/+/master:net/cert/ocsp_verify_result.h;drc=32f60f7cc761469dc08b3757686a4e395566e4f7;l=72) Change-Id: Ifa3b6905c2e932db23abf50def13fc0843c6ba56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165652 Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 1069258 Change-Id: Iab2547dce1bbfd48d0892d630720d4b99e1bd868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163064 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#762520}
-
Robbie McElrath authored
This CL moves all drawables used by the Site Settings UI out of //chrome. Any images used only in site_settings are moved to //components/browser_ui/site_settings/java/res, and others that are used other places in //chrome are moved to //components/browser_ui/styles/java/res. This is part of an effort to componentize the Site Settings UI so it can be reused by WebLayer. Bug: 1058595 Change-Id: I4fd4efaaefbea9791932adcbafec233ab71f46fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160114Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#762519}
-
Tommy Li authored
This CL makes sure the header text is programmatically aligned with the small icons on the left. It also makes sure the collapse button is aligned with the remove suggestion button. Bug: 1052522 Change-Id: I4ee9e107bc92e32951a85714c90c3bc9dcfbc968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165722 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#762518}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I91305fe44026e637eaf7f2c543a9ad159e86e60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164812 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#762517}
-
Etienne Pierre-doray authored
This CL flips dependency MetadataRecorder <-> ProfileBuilder to define MetadataRecorder types directly in the class. This allows us to simplify MetadataProvider into a concrete class. Bug: 1056283 Change-Id: I25501a6af2cd8690802c6ed14dbb0e8efbedad9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164986Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#762516}
-
Alex Chau authored
- Except VAPID key creation to M85 only which should be deprecated soon Bug: 1072599, 1072598, 1072592 Change-Id: I6c345a4e7e914741ec6e5b3876a43cd82c2bdbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162987Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#762515}
-
Robert Ma authored
These tests start to produce non-deterministic outputs because of an upstream change. TBR=chlily Bug: 1074441 Change-Id: Id96cbb071b990ba2d39212efa2b65fa65965ca97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165717Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#762514}
-
David Bertoni authored
The AppApiTest.ReloadAfterAppCrash was disabled for flakiness many years ago. It is no longer flaky. Bug: 118502 Change-Id: I395ec6821ecb2fe46c82066ba5d5498eaa628ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145936Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#762513}
-
Andrew Grieve authored
A few people have hit this and the error message is really confusing (tells you that you forgot to add .java files as resources, rather than telling you that you've listed something that isn't a resource). Bug: 1026378 Change-Id: I8da70f83ed621837f740506d8fed6f24fddb97d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165245 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762512}
-
