- 18 Sep, 2018 40 commits
-
-
Zhenyao Mo authored
The original sample is outdated so replace with a newer one. BUG=838970 Change-Id: Id257239e3fdb6424bd7bb9b3bdaea563dd1743dc Reviewed-on: https://chromium-review.googlesource.com/1228783 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592106}
-
S. Ganesh authored
Since the tests introduced in install_service_work_item_unittest.cc could interfere with one another, I am also changing the setup unittests to tests in series rather than in parallel by switching to LaunchUnitTestsSerially in run_all_unittests.cc. Bug: 833687 Change-Id: I215feac65799c0278bf3503e929f3415e6d0ff36 Reviewed-on: https://chromium-review.googlesource.com/1137532 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592105}
-
Tommy Steimel authored
This CL removes the double-tap AnimatedArrows from the overlay play button and adds them into a new MediaControlAnimatedArrowContainer element. This is the first step of a refactoring of the overlay play button to remove non-play-button-related logic and elements. Bug: 884770 Change-Id: I4d247a0178fd353b294d70c510b9b5b230220c68 Reviewed-on: https://chromium-review.googlesource.com/1228984Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592104}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0639cbc44de0..804797362e1d git log 0639cbc44de0..804797362e1d --date=short --no-merges --format='%ad %ae %s' 2018-09-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@804797362e1d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0894a56fb702f036390a51ba3db0dc8f3fdfabf8 Reviewed-on: https://chromium-review.googlesource.com/1230640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592103}
-
Theresa authored
Default enable the simplified NTP ablation experiment that removes the bookmarks/downlaods sections on the NTP without replacing them with short buttons. BUG=865216 Change-Id: Ia77dd888db8541f0946788c8c4fc6c4763da6874 Reviewed-on: https://chromium-review.googlesource.com/1229313 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592102}
-
Saman Sami authored
Resetting the fallback is no longer necessary and might even result in surfaces outside of the desired range being shown. Bug: 857575 Change-Id: Ib66ad50d0297f2c93e3e9815a3ec2349fde4289b Reviewed-on: https://chromium-review.googlesource.com/1231034Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#592101}
-
Lei Zhang authored
Rename the static method to CreateUniqueId(). Mark more parts of CupsPrintJob as const as well. Change-Id: Ifd4cd5d27c71245aa9ad251addf915853b48f6a2 Reviewed-on: https://chromium-review.googlesource.com/1229369Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#592100}
-
Robbie McElrath authored
This is a follow up from a post-merge comment on crrev.com/c/1214081 which moves the SetUp code to the constructor. Bug: 868015 Change-Id: Ied0bd568560c49858eeb5261c5d89352f8b1d787 Reviewed-on: https://chromium-review.googlesource.com/1229356Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#592099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d6281d4bb47..0191ed8e87dc git log 1d6281d4bb47..0191ed8e87dc --date=short --no-merges --format='%ad %ae %s' 2018-09-18 mtklein@google.com Make listener lists threadsafe with a mutex. 2018-09-18 bsalomon@google.com Fix image_from_yuv_textures with --preAbandonContext Created with: gclient setdep -r src/third_party/skia@0191ed8e87dc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ia9c7909443e6e1be2a567f0fb6de73a525569fe2 Reviewed-on: https://chromium-review.googlesource.com/1231275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592098}
-
liberato@chromium.org authored
This addresses the CFI failures that caused the original revert. This reverts commit 45cb1008. Change-Id: I05fa7fbb8628c992639e960d9d3f41c6ad5fec2b Reviewed-on: https://chromium-review.googlesource.com/1228493 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592097}
-
Martin Robinson authored
This allows accessibility clients to have access to the links available in the text provided by the AtkText interface. Implementing this interface also allows us to write a fully-fleshed out text for the contents provided by the AtkText interface. Bug: 866337 Change-Id: I38e200512a835014922b51df677203e853d6ef4b Reviewed-on: https://chromium-review.googlesource.com/1227942 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592096}
-
Asanka Herath authored
Test is flaky. Bug: 884140 Change-Id: I41f4f3eb084edd56867ffecc437817be8f1bcc1b Reviewed-on: https://chromium-review.googlesource.com/1231037Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592095}
-
Etienne Pierre-Doray authored
This CL creates a feature kCookieStorePriorityBoost that changes SQLitePersistentCookieStore background_task_runner sequence priority to USER_BLOCKING. A CANARY_DEV_50 experiment will be launch and used to compare SessionRestore.ForegroundTabFirstPaint3. Bug: 878222 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I22bbd5b90cf4d36d3a858adbe94eff96f280a5a0 Reviewed-on: https://chromium-review.googlesource.com/1224671 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592094}
-
Xiaohui Chen authored
Bug: b:115918259 Test: locally build Change-Id: Ie1da988afddfbe446cb5860ceb799a9814927116 Reviewed-on: https://chromium-review.googlesource.com/1229184 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592093}
-
Elly Fong-Jones authored
This reverts commit 2065e9fc. Reason for revert: hangs Flash context menus in fullscreen, https://crbug.com/884158 Original change's description: > content: don't show context menus for invisible WebContents > > Bug: 855127 > Change-Id: I2942e122373c210bd0bceaa59791e2619186f79b > Reviewed-on: https://chromium-review.googlesource.com/1175935 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583317} TBR=ellyjones@chromium.org,avi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855127 Change-Id: Ic1f62597bfbebe43cd5002ec12f05e36562e8c96 Reviewed-on: https://chromium-review.googlesource.com/1230439Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592092}
-
Andrey Kosyakov authored
This removes DebugDevToolsInterceptor and supports DEBUG_DEVTOOLS layout as part of regular DevToolsDataSource. Change-Id: I06d5a805ff8b6b324127b131bb87801d3595311f Reviewed-on: https://chromium-review.googlesource.com/1229198Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592091}
-
Oystein Eftevaag authored
This bundles multiple events into the same higher-level message and adds a string table implementation for frequently repeated strings, on a per-thread basis; specifically the event name, category name, and the name of its arguments. Requires https://android-review.googlesource.com/c/platform/external/perfetto/+/755290 to roll into //third_party/perfetto before landing. R=primiano@chromium.org,skyostil@chromium.org Bug: 839116 Change-Id: Id2681970db5b7ea5cadf0ee9bbcbbc1ebbba08c3 Reviewed-on: https://chromium-review.googlesource.com/1225306 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#592090}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/95277a300f52..0fdb956d9c24 git log 95277a300f52..0fdb956d9c24 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 jmadill@chromium.org Re-land "Inline and micro-optimize more for perf tests."" Created with: gclient setdep -r src/third_party/angle@0fdb956d9c24 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iab9b61a4693af205a33d004a1a1a6685f9fb9a61 Reviewed-on: https://chromium-review.googlesource.com/1231213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592089}
-
Chris Lu authored
Cookie clearing is asynchronous operation, which can be interrupted by the app shutdown. Blocking shutdown should allow the app more time for cookie clearing. Bug: 857199 Change-Id: I53b3c34e3cb4af77e576bbc65a37b09489b675a4 Reviewed-on: https://chromium-review.googlesource.com/1228880 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592088}
-
Christian Fremerey authored
Adds an optional field yuv_strites for Mojo struct VideoFrameInfo. This field can be used to express that YUV frames use padding for row-by-row memory alignment. This information is carried through the video capture stack from virtual device to the Renderer in class VideoCaptureImpl, where it is then translated to a media::VideoFrame. Design Doc: https://docs.google.com/document/d/1ne5eQrkzAINzoHWSxEEy6N2nEVhnpCll6DF9dcQXAmI/edit?usp=sharing Bug: 879264 Change-Id: I23ba97c2a075a4d55b75bf7c5171e4bb117197ec Reviewed-on: https://chromium-review.googlesource.com/1208825Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592087}
-
Eugene But authored
.exe and .apk could be dangerous downloads and it would be useful to know if Chrome should use Safe Browsing for blacklisting these downloads. .zip is probably the most common downloaded format, so logging it can make "other" bucket smaller. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icbd76954c57756169ef942cfddfce29d8a34861c Reviewed-on: https://chromium-review.googlesource.com/1227132 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592086}
-
Asanka Herath authored
Both virtual/video-surface-layer/external/wpt/feature-policy/feature-policy-nested-header-policy-disallowed-for-all.https.sub.html and virtual/unified-autoplay/external/wpt/feature-policy/feature-policy-nested-header-policy-disallowed-for-all.https.sub.html are timing out in a flaky manner. They were added in https://chromium-review.googlesource.com/887324 around February of 2018. Started flaking out (as far as the dashboard knows) June 6, 2018. The most recent and more frequent flakes started around September 12, 2018. No clear culprit found. Bug: 884445 Change-Id: Ib26f9c51eaa41224aa964156e5b26c0174739008 Reviewed-on: https://chromium-review.googlesource.com/1231074Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592085}
-
Misha Efimov authored
- Avoid bug in iOS 10.0 and 10.1: http://www.openradar.me/28301343 Bug: 878589 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet Change-Id: Ifef1c2c6fa35023a947d53c77a9910a6726b55a6 Reviewed-on: https://chromium-review.googlesource.com/1231133 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592084}
-
Matt Menke authored
Some consumers want to be able to set socket properties, but they're not guaranteed to be set at all when called on a live socket. Existing code gets around this limitation by using TcpSocket directly, but that class doesn't support being mocked out for tests. This CL resolves the issue. Bug: 1204852 Change-Id: Ibd3d33261c90f02285c3160468d39eca64eed259 Reviewed-on: https://chromium-review.googlesource.com/1228839Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#592083}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6003ae575d57..c42c66b2dd05 git log 6003ae575d57..c42c66b2dd05 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 lalitm@google.com Revert "trace_processor: collapse sched slice table to a flat table" Created with: gclient setdep -r src/third_party/perfetto@c42c66b2dd05 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7cab2e34b39484c21cedca6e176d47f0b7ae399a Reviewed-on: https://chromium-review.googlesource.com/1230556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592082}
-
Eric Seckler authored
This delays initialization of MockMediaRouters in the test until the browser's task executor is initialized. This is required for the upcoming move of BrowserThread::GetTaskRunnerForThread to base::Create*TaskRunnerWithTraits. In the future, TaskRunners can only be obtained after thread initialization. Since MockMediaRouter obtains a TaskRunner in its constructor, this patch moves its creation. Bug: 878356 Change-Id: Idd599d23246d42427d35bccd3c027f0a24427cfa Reviewed-on: https://chromium-review.googlesource.com/1230024 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592081}
-
Anders Hartvoll Ruud authored
This adds a new CSSCustomListInterpolationType, which is to be used for all custom property lists, regardless of their syntax. CSSCustomListInterpolationType takes an inner CSSInterpolationType, which handles the operations on the items inside the list. R=flackr@chromium.org Bug: 868959 Change-Id: I9e77e6c2332569e3cbafa492022144850b5d11db Reviewed-on: https://chromium-review.googlesource.com/1165546 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592080}
-
Justin Cohen authored
Migrates IncognitoViewController and ContentSuggestionsCoordinator into CRWNativeContent. - This will change again when removing NTP from native content. Removes NTPHeaderViewAdapter from content suggestions. Removes all references to unreachable NTP code, such as NewTabPagePanelProtocol, tab bar related items, ntp view, the shadow logic, etc. Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I714b56b9a8db10462488f5542e14ba6318e8235f Reviewed-on: https://chromium-review.googlesource.com/1228853Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592079}
-
Jordan Demeulenaere authored
Change-Id: I94299257b0aafb5d258a6d99d5cb954e00181559 Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1222726 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592078}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2b7150b9323e..874b57542941 git log 2b7150b9323e..874b57542941 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 perezju@chromium.org [pinpoint_cli] Start creating simple pinpoint_service to make API calls Created with: gclient setdep -r src/third_party/catapult@874b57542941 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: I82ec0b83de4b308c070c2602b98bf58ac23cde7f Reviewed-on: https://chromium-review.googlesource.com/1230555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592077}
-
Charlie Harrison authored
This CL deletes default_local_state.json used by perf bots in favor of dynamically generating it via a compiled action step. This JSON is used to populate prefs at startup, so ad tagging works properly. Currently, we need to update it every time the format or checksum of the ruleset changes. With this CL, this maintenance is not longer needed. See http://crbug.com/823982 for more context. Bug: 884035 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ifaa112ffe25689051a9338ea40c21fe1f56abb78 Reviewed-on: https://chromium-review.googlesource.com/1226292 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592076}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/151945a7459c..748e4927773d git log 151945a7459c..748e4927773d --date=short --no-merges --format='%ad %ae %s' 2018-09-18 bhthompson@google.com Make skylab chrome PFQs experimental Created with: gclient setdep -r src/third_party/chromite@748e4927773d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0c9b8bfafc2de7576d7f4ae2f846799ed89ed04d Reviewed-on: https://chromium-review.googlesource.com/1230638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592075}
-
Moe Ahmadi authored
Adds tests to ensure UMA metrics are correctly logged and user data is saved as expected after user interaction with the credit card save infobar. Bug: 867106 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4966f694cfb02878f98af2fed324cda7a6f10058 Reviewed-on: https://chromium-review.googlesource.com/1228979 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592074}
-
Liquan(Max) Gu authored
The test LastTextPaint_ReportFirstPaintTime is flaky because it used EXPECT_GT for time comparison. This is an issue because time is clamped. We should use EXPECT_GE instead. Bug: 885123 Change-Id: I519eeb23dcd9a1376cf91ecdc288fbf6d7b40daa Reviewed-on: https://chromium-review.googlesource.com/1230436Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592073}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ec77b5574b4..1d6281d4bb47 git log 9ec77b5574b4..1d6281d4bb47 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 mtklein@google.com Reland "implement SkPixmap::getPixel() with this->readPixels()." 2018-09-18 fmalita@chromium.org [skottie] Fix NaN |t| in CompTimeMapper::onTick 2018-09-18 fmalita@chromium.org [skottie] UBSAN divide-by-zero workaround 2018-09-18 mtklein@google.com centralize RP loads and stores Created with: gclient setdep -r src/third_party/skia@1d6281d4bb47 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Id64db95e4de86b7220fa8c5698ef42335a6edc9f Reviewed-on: https://chromium-review.googlesource.com/1230639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592072}
-
Nicolas Pena authored
This CL ensures that the first call to MaybeUpdate() results in calling Update() so that MemoryInfo is populated. Technically the monotonic clock could be initialized to a small value and in this case the first time this check occurs it could fail, whereas we want it to pass: "now - last_update_time_ >= delta_allowed" Bug: 883490 Change-Id: I7143d453709db38068919cff9585c50e06e789ac Reviewed-on: https://chromium-review.googlesource.com/1228886Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#592071}
-
Mike Klein authored
Writing non-opaque pixels to a bitmap tagged opaque breaks the contract for tagging bitmaps opaque, and can lead to nonsense later inside Skia. Change-Id: I60abf381f091a3699939f4327c7029555bc9ce39 Reviewed-on: https://chromium-review.googlesource.com/1231053Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#592070}
-
Asanka Herath authored
This reverts commit 9c6ad309. Reason for revert: Tests added in this CL are failing on mac-cocoa-rel since landing. Original change's description: > Fix inconsistent hosted app title bar text color readability algorithm > > This CL updates the title text color for Linux and Windows 7 hosted > app windows to be more consistent with Windows 10, Chrome OS, Android > and text colors used by Gmail and Inbox. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1 > See bug for more screenshots. > > Bug: 883177 > Change-Id: Ic24e1cf0b445251ebfdcd1aa0ae74c9343b1ff8e > Reviewed-on: https://chromium-review.googlesource.com/1218186 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591279} TBR=jamescook@chromium.org,msw@chromium.org,alancutter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 883177 Bug: 885164 Change-Id: I22a52611a5478ee1d430ccd8ca1a507f7237d4f7 Reviewed-on: https://chromium-review.googlesource.com/1230435Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592069}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7f0a8877a213..0cd3e599ae3b git log 7f0a8877a213..0cd3e599ae3b --date=short --no-merges --format='%ad %ae %s' 2018-09-18 jaebaek@google.com Validator: correct out of bound check for OpMemberDecorate (#1881) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0cd3e599ae3b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3e43eebc2b28019f3db1e0d8961379779d3ba432 Reviewed-on: https://chromium-review.googlesource.com/1230635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592068}
-
Max Moroz authored
This reverts commit f37f3783. Reason for revert: broke fuzzing builds: crbug.com/885205 Original change's description: > Roll src/third_party/webrtc d574123c5035..6d800030ab7e (12 commits) > > Note: force submitting because of borked mac archive trybot. > All other bots are green so we should be good. > > https://webrtc.googlesource.com/src.git/+log/d574123c5035..6d800030ab7e > > > git log d574123c5035..6d800030ab7e --date=short --no-merges --format='%ad %ae %s' > 2018-09-17 mbonadei@webrtc.org Revert "Compile frame analyzer for the host machine on perf tests." > 2018-09-17 mbonadei@webrtc.org Add RTC_EXPORT macro to export WebRTC symbols. > 2018-09-17 mbonadei@webrtc.org Compile frame analyzer for the host machine on perf tests. > 2018-09-17 buildbot@webrtc.org Roll chromium_revision 1d75f6fc..0eb6b522 (591373:591627) > 2018-09-17 mbonadei@webrtc.org Rename RTC_EXPORT to RTC_OBJC_EXPORT. > 2018-09-17 mbonadei@webrtc.org Introduce GN arg rtc_exclude_runtime_enabled_features_default. > 2018-09-17 danilchap@webrtc.org Register video rtp header extensions in rtp_rtcp by uri > 2018-09-17 sprang@webrtc.org Add ability to throttle VideoBitrateAllocation updates. > 2018-09-17 mbonadei@webrtc.org Remove obsolete comments. > 2018-09-17 saza@webrtc.org Reland "Remove APM internal usage of EchoCancellation" > 2018-09-15 mbonadei@webrtc.org Merge field_trial and field_trial_default in a unique target. > 2018-09-15 mbonadei@webrtc.org Merge system_wrappers:metrics and system_wrappers:metrics_default. > > > Created with: > gclient setdep -r src/third_party/webrtc@6d800030ab7e > > The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng > > BUG=chromium:None > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: Id68bba413d71cbfb8cb52522b530e440249e459d > Reviewed-on: https://chromium-review.googlesource.com/1229778 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#591975} TBR=phoglund@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: I939c09c751590bef70e7bd6cf85b9089fc4a986f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:None Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1231273Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592067}
-