- 11 Dec, 2018 40 commits
-
-
David Jean authored
Bug: 886583 Change-Id: I107a11cdcd9d299533789cffed8c3446561f4968 Reviewed-on: https://chromium-review.googlesource.com/c/1365432Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#615464}
-
Takuto Ikuta authored
Bug: 576864 Change-Id: I3290cb0876f3ca84ec0efb13922b2756138b9492 Reviewed-on: https://chromium-review.googlesource.com/c/1369763Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615463}
-
Lei Zhang authored
Read and parse the plist, and tell Print Preview about the custom paper sizes. BUG=477699 Change-Id: Ia22e2d95e627d1796b1346ab6e3baeef89a9f2ae Reviewed-on: https://chromium-review.googlesource.com/c/1364228 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615462}
-
Marc Treib authored
The new test is similar to the existing PersonalDataManagerSanity test, but adds checks for the Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE histogram. Compared to PersonalDataManagerSanity, the new test skips the step of adding a duplicate profile, since that seems to produce flaky results. Bug: 904390 Change-Id: Ic85050dcab80e53ea1a5e1fa63f61db5e6c2cb09 Reviewed-on: https://chromium-review.googlesource.com/c/1369778Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#615461}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae0d860ba31b..264843e30745 git log ae0d860ba31b..264843e30745 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@264843e30745 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ie41dd4f4977bf51bd0d31225f555d62f0a6dafde Reviewed-on: https://chromium-review.googlesource.com/c/1371252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615460}
-
Rob Buis authored
Openssl does not take --subj parameter, but -subj. Bug: 803774 Change-Id: Ie5e1da18941468fc66ea567134a49178b4260aba Reviewed-on: https://chromium-review.googlesource.com/c/1370177Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#615459}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d31d9e9af460..8a7be9d55a9c Created with: gclient setdep -r src-internal@8a7be9d55a9c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iac716d778c5208ad7431b0daa4cdb1cde8f832fb Reviewed-on: https://chromium-review.googlesource.com/c/1371251Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615458}
-
Hiroki Nakagawa authored
Bug: 911415 Change-Id: I8f4a0e452bb508fa5ccb2c9f9701e1b9834b8b81 Reviewed-on: https://chromium-review.googlesource.com/c/1370163Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615457}
-
François Beaufort authored
Following Chris Palmer's email[1], this CL removes apacible from Picture-in-Picture related OWNERS as she is not actively working on Chromium. [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ZgEddsRE6do/UPcD-sptBgAJ Change-Id: I77f12a916c359c92dc329a5b59076983ecd86269 Reviewed-on: https://chromium-review.googlesource.com/c/1361729Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#615456}
-
Cathy Li authored
We limit the maximum number of rows shown by how many sites each category had to begin with (before any blacklisting occurs). Bug: 911362 Change-Id: I35ac39870422248ae830050bb6ccf4f405960f4d Reviewed-on: https://chromium-review.googlesource.com/c/1359694 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615455}
-
Reka Norman authored
This CL updates the FakePageHandler to use generated Mojo types. Bug: 906508 Change-Id: Ib04a9118e7ad7de6ac1aa9dfdf2d232c3280034a Reviewed-on: https://chromium-review.googlesource.com/c/1370232 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#615454}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/768c73895b2f..bdff670a66b9 git log 768c73895b2f..bdff670a66b9 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 athilenius@google.com Added a find_project_path script, updated repo_manifest lib Created with: gclient setdep -r src/third_party/chromite@bdff670a66b9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0d317d3eb531673796b8aa47ed41a98b4c2e69ca Reviewed-on: https://chromium-review.googlesource.com/c/1371250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615453}
-
Simon Que authored
BUG=913249 Change-Id: Icacda434b78bc09b85290734f888f914dc91d3ac Reviewed-on: https://chromium-review.googlesource.com/c/1369547Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#615452}
-
Eric Karl authored
Adds a method to SharedImage interface (SII) which allows us to create a shared image and upload initial data in a single command. This method is then used in LTHI to convert the UI Resource uploader code to SII. As SII can't rely on the command buffer, it uses the following pattern for uploads: - Allocate a 1MB (or required size) block of shared memory. - Sub allocate from it for each upload, duplicating the SHM and transferring ownership to the GPU service for each upload. - When the current shared memory buffer is used up, drop it on the client side. It will be kept alive by the duplicated handles passed to the service, until these are no longer needed. - Repeat. This may be a bit inefficient, so we may need a more complex allocation scheme in the future. Bug: 906794 Change-Id: Ie91ab352b06097da6e00f80582b0cc92d690a6f9 Reviewed-on: https://chromium-review.googlesource.com/c/1343346 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615451}
-
Yutaka Hirano authored
Bug: 911036 Change-Id: I1096638e46760674d9c9a85522f775f767f0faa1 Reviewed-on: https://chromium-review.googlesource.com/c/1370234Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#615450}
-
Sidney San Martín authored
Bug: 913688 Change-Id: Ibd0124bd99389142c4538fdb6c55ca2c634f6f42 Reviewed-on: https://chromium-review.googlesource.com/c/1371164Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615449}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f88410f8..5ca85e30 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id130e26eed952d7d9ff0a64c0c19531612c22ce6 Reviewed-on: https://chromium-review.googlesource.com/c/1370859Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615448}
-
Takashi Toyoshima authored
ResourceLoadScheduler was already launched, and enabled by default. fieldtrial_testing_config.json does not need to have a configuration for testing performance on the feature. Bug: 729954 Change-Id: Ie7d468ad320980c857e3612dbff3f18cc2b74bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1369550Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#615447}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea2cff61234c..d31d9e9af460 Created with: gclient setdep -r src-internal@d31d9e9af460 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I886418486b60a062c29400f1d0663311c55ddfed Reviewed-on: https://chromium-review.googlesource.com/c/1371249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615446}
-
Ryan Tseng authored
And remove blink::ToIsolate(ExecutionContext) altogether. Originally https://chromium-review.googlesource.com/c/chromium/src/+/1355944 The difference is added checks in: * AsyncTaskCanceled * AllAsyncTasksCanceled for nullptr ExecutionContext. Bug: 889542, 911800 Change-Id: Icef90fadbc89019118119f044dde8f10ddffa72f Reviewed-on: https://chromium-review.googlesource.com/c/1366358 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615445}
-
Sara Kato authored
This boundsForRange should return null in Non-arc, non-text nodes. Otherwise, since bounds for these nodes exist (eg - on images), highlighting for these would occur unexpectedly on select-to-speak side. Test: Manual Bug: 908509 Change-Id: I344a050a9033d7d839cb242b1fc56196ec28bcce Reviewed-on: https://chromium-review.googlesource.com/c/1358105 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615444}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bcd17a0. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure ksakamoto@chromium.org: external/wpt/resource-timing panicker@chromium.org: external/wpt/user-timing rmcilroy@chromium.org: external/wpt/requestidlecallback tdresser@chromium.org: external/wpt/hr-time external/wpt/navigation-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3a940f1891ee1fab3deac0ed104cc1c7a66bd1ca Reviewed-on: https://chromium-review.googlesource.com/c/1371217Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615443}
-
Xianzhu Wang authored
For now ViewportProperties contains the page scale node only, and Settings contains prefer_compositing_to_lcd_text only. In the future they will contain more properties/settings. Change-Id: I760b79191aa25a8fc489aa9c4d9ab1dc1e6204fc Reviewed-on: https://chromium-review.googlesource.com/c/1370278Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615442}
-
Giovanni Ortuño Urquidi authored
Some interfaces depend on many other interfaces. Before this patch users would have to manually add externs for every interface used. This CL introduces a new target that js_libraries can use to include all the necessary externs to use an interface. Bug: 849993 Change-Id: I97acb7bbbd604e7ebeb1cb5fe814e4afecefe2d6 Reviewed-on: https://chromium-review.googlesource.com/c/1369485Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#615441}
-
Matt Falkenhagen authored
Remove the following tests: - fetch-canvas-tainting.html - fetch-cors-xhr.html - fetch-csp.html These are redundant with corresponding WPT tests. They previously could not be removed without losing test coverage because the WPT tests were being skipped due to time outs, see https://codereview.chromium.org/2805313003/. But those WPT tests are now passing. A small exception is the WPT fetch-canvas-tainting* tests flakily timeout, but they are still enabled and mostly passing so we won't lose test coverage. These tests were originally written at r179595 and upstreamed to WPT at https://github.com/web-platform-tests/wpt/commit/b2e3ab765e26436850208dbdcf747c3be75b1999. Bug: 688116, 373120 Change-Id: Ic2dc2ddc322aae89b1e06e5a16b1ed8c30265d00 Reviewed-on: https://chromium-review.googlesource.com/c/1370236Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615440}
-
John Z Wu authored
ios webview uses butter sync which does not need overall sync consent because it will never be enabled. Bug: 873790 Change-Id: Id6f6dfd6ebd424f2d3c385a85f425171d03ef1d9 Reviewed-on: https://chromium-review.googlesource.com/c/1371203 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#615439}
-
John Z Wu authored
A new flag was added recently that prevented server cards from being offered as autofill suggestions. We simply enable to restore the intended behavior. Change-Id: I537ae79a6bf6acfef081f9002654e4d4fc202fe5 Reviewed-on: https://chromium-review.googlesource.com/c/1371202 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#615438}
-
Sam McNally authored
MetadataBoxController uses the availability of externalFileUrl in file metadata to decide whether to obtain metadata via ExternalMetadataProvider or by reading the file. With DriveFS, externalFileUrl is not set but ExternalMetadataProvider should be used for fetching metadata. Also use alternateUrl (which is only set for Drive files) to detect files where this metadata provider should be used. Also skip FSP metadata requests when none of the metadata fields are available via the FSP API. Bug: 913738, 587231 Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8 Reviewed-on: https://chromium-review.googlesource.com/c/1370154 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615437}
-
Yusuke Sato authored
This allows the job to use userdata.qcow in the user's /home. BUG=b:118408409 TEST=sign in, confirm the job is running Change-Id: I1bcb5ff1cfcae06a7ce404b17ffd2c329419736e Reviewed-on: https://chromium-review.googlesource.com/c/1367085Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#615436}
-
Fergal Daly authored
The test was testing that the element ended up green (starting red) however, if the browser has no support at all for ::part then the element actually starts green and stays green. Bug: 805271 Change-Id: Ida40c7963aa3a00c3d197b1309ddaea49e4f3b92 Reviewed-on: https://chromium-review.googlesource.com/c/1369500Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615435}
-
Adithya Srinivasan authored
Bug: 582328 Change-Id: I733060f119871b3de35c147e6d3eb1d6c83663f1 Reviewed-on: https://chromium-review.googlesource.com/c/1366299Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#615434}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40bd76027f8e..ae0d860ba31b git log 40bd76027f8e..ae0d860ba31b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 reed@google.com move intercepts call to textblob 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 153e0224da45..f5c88e7e1c1a (2 commits) Created with: gclient setdep -r src/third_party/skia@ae0d860ba31b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Id3ef54967dde692a364dcf9a2815c56e53de3c8a Reviewed-on: https://chromium-review.googlesource.com/c/1371248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615433}
-
Hiroki Nakagawa authored
Before this CL, SharedWorkerRepositoryClient is created in RenderFrameImpl::Initialize() and owned by WebLocalFrameImpl[*]. This needed unnecessary plumbing between blink/renderer and content/renderer. This CL removes the path, and instead makes Document own SharedWorkerRepositoryClient as Supplement<Document>. This changes the ownership model of SharedWorkerRepositoryClient from per-Frame to per-Document, but it shouldn't affect behavior. Also, this removes the mechanism to manage multiple Documents from SharedWorkerRepositoryClient (see ClientMap/Set in the class). As mentioned above, the client is a per-Frame (per-Document) object, and the mechanism doesn't make sense. [*] This was necessary for communicating with renderer's embedder but the path was removed by recent refactorings (Onion Soup). Bug: 911415 Change-Id: If9ae00b0fbdde99d8a0256dc7381fab5c72ff317 Reviewed-on: https://chromium-review.googlesource.com/c/1370224 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615432}
-
rbpotter authored
Previously, the height of the custom margins error message was fixed at 2 lines of text. However, this resulted in the message being cut off for some languages/font sizes. Allowing a variable height error message broke the logic setting the custom radio button's position, so this CL updates the positioning logic so that the radio button stays centered on the cr-input regardless of the height of the error message. Bug: 911958 Change-Id: If9e1655e0d2bb87de46ac3c1749b5b07cd831bd7 Reviewed-on: https://chromium-review.googlesource.com/c/1369027Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615431}
-
Matt Falkenhagen authored
The 'generated response' test used to fail. Fixed by r615063. Bug: 840881 Change-Id: Ia5773ee28ac4d9b2195f98f8dedd731fa166502e TBR: npm No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1370159Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615430}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/69540f44196e..8f66ddbae325 git log 69540f44196e..8f66ddbae325 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 steveanton@webrtc.org Move is_unified_plan flag to a member variable 2018-12-10 steveanton@webrtc.org [Unified Plan] Fix issues with recycling m= sections 2018-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a1b00bf1..aec72e9e (615131:615246) 2018-12-10 terelius@webrtc.org Remove support for having multiple SSRCs in an RtcEventVideoSendStreamConfig. 2018-12-10 benwright@webrtc.org New statistic added to VideoReceiveStream to determine latency to first decode. 2018-12-10 terelius@webrtc.org Fix header extension mapping bug in RTC event log analyzer. 2018-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d6dec397..a1b00bf1 (614285:615131) 2018-12-10 srte@webrtc.org Adds trial to fall back to probe rate if ack rate is missing. 2018-12-10 srte@webrtc.org Using more accurate receive time calculation in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@8f66ddbae325 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:899680,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iadd4ec06946097473111d30398341877f8149812 Reviewed-on: https://chromium-review.googlesource.com/c/1370653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615429}
-
Sam McNally authored
With the old Drive integration, all files were accessed via externalfile: URLs. Those for hosted docs redirected to the actual URL for accessing that doc. With DriveFS, real file: URLs are used so no externalfile: URLs exist. The drag and drop code populates the File and, if available, the externalfile: URL in the DataTransfer. For hosted docs under DriveFS, this is insufficient as the files are not openable. However, the alternateUrl is the URL needed to access the hosted doc so substitute it for the externalfile: URL for hosted docs. Bug: 913725 Change-Id: Ib9456042e1e864b378b71db404e1ea406959b1fe Reviewed-on: https://chromium-review.googlesource.com/c/1370152Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615428}
-
Cecilia Ni authored
This CL makes the app list show 4 apps by default with the rest in an expandable list. Bug: 1369498 Change-Id: I7e559d806dc85c64a6f01661e5ba2e0e89604c38 Reviewed-on: https://chromium-review.googlesource.com/c/1369498 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#615427}
-
Richard Li authored
The typemapping between content::BackgroundFetchRegistration and blink.mojom.BackgroundFetchRegistration causes the dependence for //third_party/blink/public:blink_headers. The dependence is a block for moving background_fetch.mojom into blink/public/mojom/. In this CL, content::BackgroundFetchRegistration is removed. In the future, background_fetch_types.typemap will be removed, and then background_fetch.mojom is able to move to new place. Change-Id: I913f64dd4e2ed47deacdfeda1e77781fcda3373a Reviewed-on: https://chromium-review.googlesource.com/c/1365079 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#615426}
-
Luciano Pacheco authored
Change util.getEntryLabel to special case Downloads folder to translate. Change DirectoryTree and FileList to use util.getEntryLabel for translating the entry labels and util.compareLabel for sorting the entries. Change FileList related types to carry volume manager to be able to pass LocationInfo to be able to use getEntryLabel for displaying and sorting entries on File List, as follows: - Add VolumeManager to FileListContext constructor, since this type is constructed only once. - Change DirectoryContents constructor to forward VolumeManager from FileListContext to FileListModel. - FileListModel uses VolumeManager to get LocationInfo to sort entries by labels. Add Closure markup for DirectoryContents attributes related to this change to add clarity for developers and stronger type in Closure. As part of this changed DirectoryContents.fileList_ to be always FileListModel instead of switching to a empty ArrayDataModel from |setFileList|. Test will come in follow up CL. :-) Bug: 873539 Change-Id: I46dd1879c14cbf046f5da5d96c29b34f13d404a1 Reviewed-on: https://chromium-review.googlesource.com/c/1370151 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615425}
-