- 21 Nov, 2017 40 commits
-
-
Wez authored
As the first step to merging ScopedPlatformHandle into PlatformHandle to have a single, always-managed container for platform handles, we: - Replace ScopedPlatformHandleVectorPtr and PlatformHandleVector with vector<ScopedPlatformHandle>. - Replace PlatformHandle with ScopedPlatformHandle in some core APIs. - Use const& to pass handles to APIs without passing ownership, for both individual platform handles, and vectors. Bug: 753541 Change-Id: Id965dcf3770ef11bf36f78277fa7199ea779599e Reviewed-on: https://chromium-review.googlesource.com/742309Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#518343}
-
Peter Lee authored
This reverts commit 445feb54. Reason for revert: This will break on iOS 11.2 beta. Original change's description: > Calls decisionsHandler asynchronously > > This change is a precursor to a more extensive change where > ExternalAppLauncher API is changed to be asynchronous. > > This simpler change is to call the decision handler in the implemention > of WKNavigateDelegate method > webView:decidePolicyForNavigationResponse:decisionHandler: > asynchronously on iOS 11 and up. > > iOS 10 (and possible below) has a bug where JavaScript on the page would > not execute if the decision handler is called asynchronously. > > This change is to make sure that there are no other unforeseen > issues with calling decision handler asynchronously on iOS 11. > > Bug: 774736 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I7a6dfe637cb6be4ce5c7efe5824728b8f06b902a > Reviewed-on: https://chromium-review.googlesource.com/773570 > Commit-Queue: Peter Lee <pkl@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517129} TBR=eugenebut@chromium.org,pkl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 774736 Change-Id: I007149ee9ef15d4187a76d66f90bc52d21ff09aa Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/782682 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#518342}
-
Qiang Xu authored
changes: - Move Is{Set}MonoAudioEnabled code to ash, the mono audio pref prefs::kAccessibilityMonoAudioEnabled is already moved to ash. - Remove audio_a11y_controller proxy, using CrasAudioHandler instance directly. Bug: 594887 Test: tested on device with/without --mash, the feature is working fine Change-Id: Ie1803f9e6a783b7bbd76305d91c5f81dcf83f916 Reviewed-on: https://chromium-review.googlesource.com/768338Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#518341}
-
Dave Tapuska authored
In TouchSelectionControllerClientAuraScaleFactorTest InsertionHandleCoordinates test the device scale factor is set. However the test sends input before the screen info is retrieved which adjusted the coordinates on the input router. This change adds the initialization of the scale factor immediately after the InputRouter is created. BUG=722928 Change-Id: Id2e8590a239b05530afc960e35f7d67a0a1aff7d Reviewed-on: https://chromium-review.googlesource.com/779884Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#518340}
-
Eugene But authored
TBR=sdefresne@chromium.org Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifb036c069fd34f3b7b59e613e8b1d130eb74e918 Reviewed-on: https://chromium-review.googlesource.com/782800 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518339}
-
Jonathan authored
We enabled viz_content_browsertests on the linux fyi bot over the weekend, with no new flakes nor failures appearing. This enables them as a part of the main linux test package. TBR=sky@chromium.org TEST=viz_content_browsertests Bug: 760181 Change-Id: If86e8e551bf007124aea88073a3f57b51fff27a3 Reviewed-on: https://chromium-review.googlesource.com/779221Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#518338}
-
Mehran Mahmoudi authored
Fix the bug for Bar Banner caused when orientation was changed. Bug: 786513 Change-Id: Icc098fc3b22eaa1ecf7977e30bb9c7d8294472b1 Reviewed-on: https://chromium-review.googlesource.com/780859Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518337}
-
Matthew Jones authored
If the Chrome Home promo is open in both windows in multi-window mode, enabling the feature will not work. The cause of this is the second promo being dismissed and detecting that the state had changed because of the first (thus resetting the state). This change checks the enabled state of Chrome Home when the promo is shown. If the state changed before the promo is dismissed, the promo does nothing. BUG=787330 Change-Id: I31fe4471640cc38c269cc5aaf02d9b9fc4b7a33d Reviewed-on: https://chromium-review.googlesource.com/782707Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#518336}
-
Chris Palmer authored
Bug: None Change-Id: I6a91e5cdeb9bd9a585c782eea1a5bf767f44147f Reviewed-on: https://chromium-review.googlesource.com/782705Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#518335}
-
Daniel Bratell authored
By using x11.h instead of X11 system headers we prevent spreading some common macros named None, Status, True, False, ... in the global namespace. These macros forced various workarounds in innocent code and made jumbo builds harder. This moves a lot of X11 configuration and defines from ui/event headers into ui/gfx/x/x11.h to make sure no code has to manually include X11 headers. Bug: 782184 Change-Id: Iab069db82d71cd27df395afefa34a54c252b874d Reviewed-on: https://chromium-review.googlesource.com/779144 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#518334}
-
xdai authored
See https://docs.google.com/presentation/d/13_Hgj3GPIjXG7RKspRpOAg-GiQ1TSCOjkBmuU979g9E/edit#slide=id.g2702f89868_0_0 for proposed change: - Combine Local Destinations and Google Cloud Destinations to Print Destinations - Click on the "Manage..." link will direct the user to Chrome Print settings page - Add one row "Printers" under the "Printing" section of Chrome settings page on operation systems other than Chrome OS. Click on the "Printers" item will open the System native print dialog. Bug: 779591 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I686719924aa956074345236be73a6cd3af44b530 Reviewed-on: https://chromium-review.googlesource.com/775578Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#518333}
-
Stefan Zager authored
We only need to convert to root layer content coordinates if we're calling into RootFrameViewport. BUG=711468 Change-Id: Iff2632078950350d00b3c1cee8741a9190fc07d6 Reviewed-on: https://chromium-review.googlesource.com/780201Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#518332}
-
Vaclav Brozek authored
If a CSV file contains a record with an invalid URL (such as ":") in the 'url' column, such record should be skipped. Bug: 786937 Change-Id: I59a6d85fd6ed099332b09d960784ad22190b94e3 Reviewed-on: https://chromium-review.googlesource.com/781919Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518331}
-
Jared Saul authored
Bug: Change-Id: I8df2791c1cd985023b3281d0a5179beb2328ecfb Reviewed-on: https://chromium-review.googlesource.com/780361 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#518330}
-
Daniel Cheng authored
Bug: 786386 Change-Id: I28d5809389aa86ee274b17725ca5312d4b8bb3ae Reviewed-on: https://chromium-review.googlesource.com/776411 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#518329}
-
Rouslan Solomakhin authored
Before this patch, if payment method manifest for https://alicepay.xyz/webpay prohibits payment handler https://bobpay.xyz/app, Chrome would print: "Payment handlers from https://bobpay.xyz are not allowed to use payment method https://alicepay.xyz/webpay." in terminal (sometimes even twice). Web developers rarely look at the terminal, however. Even if someone found these messages in the terminal, they would be confused by the message terseness and why it's printed twice. This patch makes the message more descriptive and prints it in the developer tools console, if possible. In addition, the patch ensures that the message is printed exactly once per PaymentRequest instantiation. To enable access to the developer tools console, the ManifestVerifier now takes WebContents as the first parameter instead of the BrowserContext that was used before. After this patch, if payment method manifest for https://alicepay.xyz/webpay prohibits payment handler https://bobpay.xyz.app, Chrome would print the following message in developer tools console: "The payment handler https://bobpay.xyz/app is not allowed to use payment method https://alicepay.xyz/webpay, because the payment handler origin https://bobpay.xyz is different from the payment method origin https://alicepay.xyz and the "supported_origins" field in the payment method manifest for https://alicepay.xyz/webpay is not "*" and is not a list that includes https://bobpay.xyz." This behavior can be tested on: https://rsolomakhin.github.io/pr/apps/alice/ Bonus: Not instantiating a GURL from non-UTF8 strings, which have been known to cause GURL constructor crashes in fuzz tests. Bug: 787054 Change-Id: I113270173cbc6c89bf81b58f36a46da4d7adf6ec Reviewed-on: https://chromium-review.googlesource.com/779662Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518328}
-
Leszek Swirski authored
Seperate the logs for missing cache handlers when there is no ScriptResource, and ScriptResources with null cache handlers. Bug: chromium:769203 Change-Id: I7abc1f5330ca2666b9ed67ddf1b54947598c23ca Reviewed-on: https://chromium-review.googlesource.com/778544Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#518327}
-
Daniel Cheng authored
Change-Id: I0e98ec9ad1b886509f791dcb19a727a0e6f14bd2 Reviewed-on: https://chromium-review.googlesource.com/776316Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#518326}
-
Peter Collingbourne authored
This includes a single entry that blacklists the C++ standard library. We need to blacklist libc++ for now because the Android port links against a prebuilt libc++_static.a from the NDK, and also links a prebuilt .a from third_party/gvr-android-sdk that uses libc++. Bug: 469376 Change-Id: I2fee239bf5239594ace9be465bdbd6954dcddb01 Reviewed-on: https://chromium-review.googlesource.com/780687Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#518325}
-
Xiaohan Wang authored
This will report a baseline event every time MojoCdm is created (unless connection error already happens during connection time). Then it will report an event if mojo connection error happens, which typically means the CDM process crashed. BUG=785713 TEST=Manually tested by inspecting about://histograms Change-Id: I0569c98435dcadd871774ec22234feb5c703110b Reviewed-on: https://chromium-review.googlesource.com/780047Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#518324}
-
Matthew Jones authored
If the user is scrolling on the bottom toolbar before the browser is ready and continues through the ready state, the gesture event filter starts processing the stream without a down event, causing a crash. This change adds null checks for the initial event in the gesture detector to defend against this. BUG=786889 Change-Id: I68a10c64653957f659e642f089a9037fddcbee5d Reviewed-on: https://chromium-review.googlesource.com/779866Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#518323}
-
Mustaq Ahmed authored
The EventDispatchMediator seems redundant. It doesn't store any state of its own, and is created (then destroyed) at every event dispatch only to provide event-type specific handling. This CL eliminates the unnecessary memory (de)allocation (thus reduces memory fragmentation) by handling type-specific tasks in event objects. Bug: 717191 Change-Id: I7c2bc14fe5d43a604c9af982f64947258d237eea Reviewed-on: https://chromium-review.googlesource.com/755855Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#518322}
-
Eugene But authored
The test tests DidStartLoading and DidFinishLoading callbacks so the name will reflect that better. Also fixed presubmit warnings related to deprecated API usage. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I870f640e142e11dd698b801dd670ffe340732c64 Reviewed-on: https://chromium-review.googlesource.com/777771 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#518321}
-
kylechar authored
Many TRACE_EVENT macros in viz have category "cc" still. Update all of them to "viz". Bug: 722935 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie308de936fc17205321ee419f3f6fa8b54ade9fa Reviewed-on: https://chromium-review.googlesource.com/782161 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#518320}
-
Nicolas Dossou-gbete authored
Simplifies the code path for the Framebust block infobar that was trying to share code with the desktop intrvention UI but ended up being unused. Makes the implementation closer to the one for the Near-OOM intervention. Most importantly, exposes Accept and DeclineIntervention methods for the Framebust Block intervention, that now enables callers to react when the intervention is accepted. Bug: 781890 Change-Id: I845f76bdbddf85f49c8e0fe8548a2e78d2e213b3 Reviewed-on: https://chromium-review.googlesource.com/779521 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#518319}
-
Lei Zhang authored
Rename it to PrintPageInternal() and give it the same method signature as PrintPageInternal() on other platforms. Change both PrintPageInternal() implementations to look more like each other. Change-Id: I087f784eeea8bf1b9dc4e5e0c8b2d1d30572d204 Reviewed-on: https://chromium-review.googlesource.com/780686Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#518318}
-
Rakina Zata Amni authored
window.event should be undefined if an Event's target is in a shadow tree, because it is leaking information from inside the shadow tree. This change will remove window.event support for events targeted to nodes within a V1 shadow tree. Discussion link: https://github.com/whatwg/dom/issues/334 Bug: 779461 Change-Id: I310bc72463369befd693de9321a9949a97e83f5e Reviewed-on: https://chromium-review.googlesource.com/773922 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518317}
-
Mehran Mahmoudi authored
This cl fixes a bug that caused the IPH bubble for Contextual Search to appear over the CS panel after screen rotation. Bug: 786492 Change-Id: Ibab38cde282e4e22f01f0dcb6ea035adf98498e0 Reviewed-on: https://chromium-review.googlesource.com/780723Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518316}
-
Magnus Jedvert authored
The JNI generation script fails to understand enums as inner classes, leading to incorrect signatures for the generated JNI code. Bug: webrtc:8556 Change-Id: Ib088f3a0af1493247c991d5ee39de73da725f5e9 Reviewed-on: https://chromium-review.googlesource.com/779523Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Magnus Jedvert <magjed@chromium.org> Cr-Commit-Position: refs/heads/master@{#518315}
-
Tao Bai authored
Bug: 786420 Change-Id: Ida64aef0ecde9b093dab58bfa097b0779079e3c5 Reviewed-on: https://chromium-review.googlesource.com/780802 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518314}
-
Daniel Bratell authored
There were two ImageDecodeTaskImpl classes in cc, one for the GPU image handling and one for the Software image handling they were small and slightly different so no reason trying to merge them Instead this renames them so that their names don't clash in jumbo builds where cc files are merged into large translation units. Bug: 786956 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9e481a969d9a897665855f05a5dedbc86e194eb1 Reviewed-on: https://chromium-review.googlesource.com/779194Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#518313}
-
Andrew Grieve authored
Also updates templates for gradle plugin 3.0 and makes --split-project work again for Chromium codebase. Bug: 620034, webrtc:8547, 786676 Change-Id: I89e937ff8a70cf30f890765b98efa0d331fba77e Reviewed-on: https://chromium-review.googlesource.com/779499 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#518312}
-
Artur Khachatryan authored
Verion 63 is added Bug: Change-Id: I4a4c02193ff5ea10f448e7a6cee2793cacaa66e9 Reviewed-on: https://chromium-review.googlesource.com/780697Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518311}
-
Luna Lu authored
The feature policy can be inspected via the following methods: allowsFeature(feature) -- whether or not |feature| is allowed on the origin of the document. allowsFeature(feature, origin) -- whether or not |feature| is allowed on the given origin. allowedFeatures() -- a list of features that are enabled on the origin of the document. getAllowlistForFeature(feature) -- a list of explicitly named origins where the given feature is enabled, or {'*'} if the feature is enabled on all origins. For more details, see the design doc at: https://docs.google.com/a/chromium.org/document/d/1wvk3cXkblNnbkMcsKayseK-k0SMGiP9b9fQFgfpqQpc/edit?usp=sharing Bug: 703703 Change-Id: I261f2251791ed18937d06c4eb24abf06676241cc Reviewed-on: https://chromium-review.googlesource.com/686036Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#518310}
-
Elly Fong-Jones authored
Bug: 610428 Change-Id: I314556a9c835606acc11b80da480971fe083b93c Reviewed-on: https://chromium-review.googlesource.com/757035Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#518309}
-
Sylvain Defresne authored
Convert PasswordController to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I227193a0a4040cff7a823c4e5926a3cad78650e6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778900 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518308}
-
Koji Ishii authored
The size and offset of NGPhysicalTextFragment included the leadings from the 'line-height' property. The size of text boxes are not defined in the spec, but pre-NG InlineTextBox does not include it, and using the same offset and size helps sharing the logic with pre-NG. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6fab82bf16e17da15306c14a04e690460a7f5712 Reviewed-on: https://chromium-review.googlesource.com/781482 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518307}
-
Sidney San Martín authored
Bug: 783340 Change-Id: I4b34e9d98627f49412bba3251820fa38445c5e63 Reviewed-on: https://chromium-review.googlesource.com/762667Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#518306}
-
Peter Beverloo authored
This will significantly help reduce flakiness in testing (one deflake included in this CL), and is required for migrating Android's intent handling system to the BackgroundTaskScheduler which needs to know when handling of the event has finished. In addition, a hack where the NativeNotificationDisplayService invoked the Close() method on a notification's delegate in order to fire the event for non-persistent Web Notifications has been removed. We can just fire the event from the NotificationMessageFilter instead. BUG=766854, 784951 Change-Id: I57d0a446e6c47281bb7b5e001c449fadddeba571 Reviewed-on: https://chromium-review.googlesource.com/779722 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#518305}
-
Fady Samuel authored
This CL adds some trace events that debug surface sync performance issues and visualize synchronization of surfaces across multiple clients. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I87a1f1695bc3536160ca7d8f669bfae81ce200fb Reviewed-on: https://chromium-review.googlesource.com/782062Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#518304}
-