- 10 Aug, 2020 40 commits
-
-
Omar Morsi authored
This CL 1) moves all key permissions files under platform_keys folder to platform_keys/key_permissions folder, 2) makes sure all key permissions classes are under chromeos::platform_keys namespace. Bug: 1113121 Change-Id: I45a2a9aaaff9b8dc2cf27e96355b435d2814fb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338215 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796355}
-
Victor Hugo Vianna Silva authored
TBR=vasilii@chromium.org Bug: None Change-Id: Ia4211f62e5fcd73a52f374c87cc56e7f8762faee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346269Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#796354}
-
arthursonzogni authored
There are no reasons to use kFollowRedirect. Using it make the reports contains less data. Bug: 1113163 Change-Id: Ifc66cf29da71d53b2bea11a0da1a7724c6a6756f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339748 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#796353}
-
Matt Jones authored
Prior to the refactor in https://crrev.com/c/2288909 the navigation handler was null checked. Since the handler is now owned by a new coordinator, the coordinator is checked instead of the handler itself, this patch re-adds that extra layer of checking. Bug: 1113548 Change-Id: I29e938ead6ed11a71e46441b3e00c7ccab13ab23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343575Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796352}
-
Maksim Sisov authored
The use_x11 && use_ozone config breaks compositor_unittests. Basically, we need to decide on runtime what test compositor host we need to use - X11 or Ozone. This CL fixes that using the same approach I used in other CLs. For example, https://crrev.com/c/2247719 ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Id5442da33def3cdf8f00deffc59e11d76dbf60a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335284Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#796351}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I3060245837948adb305900bbcf21dcc51ecd36d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345945Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796350}
-
Maksim Sisov authored
Atm, that case is only handled for !defined(USE_X11). Instead, it must be handled for !defined(OS_LINUX) as OS_LINUX can mean either USE_X11 or USE_OZONE now. Bug: 789065, 578890 Change-Id: I95d140cb515e833e5b195b1e746671db2cb57b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336600Reviewed-by:
-
Maksim Sisov authored
When use_x11 && use_ozone are set, vulkan tests start to use SkiaVulkan backend (that is actually used only for non-Ozone X11 builds on Linux). To suppress the crashes, default to a default backend for Ozone. Also, added a bug to enable that for Ozone/Linux. Bug: 1085700 Change-Id: Ib8e99caf046dc91e90a954b4665e241ed9c80f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336083Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#796348}
-
Greg Thompson authored
This reverts commit 67667a8e. Reason for revert: This change increases the failure rate from the mini_installer. Original change's description: > Stop leaking files extracted by mini_installer. > > With this CL, mini_installer now holds the files it creates open with > FLAG_DELETE_ON_CLOSE so that they are automatically deleted by the > filesystem when they are no longer needed. > > The most risky operation is the multi-step process to drop write > permission on the files so that they can be opened for consumption by > parties that do not allow writers. New process exits codes have been > introduced to track whether or not this operation fails in practice. > > BUG=516207 > > Change-Id: Ic5e25692cf3dca0fcc7cd01faf5759648f5c6890 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307250 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790735} TBR=forshaw@chromium.org,wfh@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 516207 Change-Id: I7da5dbbdf02aa1499f96b40af7f76f0b7ee0ed24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346344Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#796347}
-
Gauthier Ambard authored
The flag has been enabled for one release. Bug: none Change-Id: I75316536f01acd2d924da01f754dc4505ca98412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343035Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796346}
-
Zakhar Voit authored
Fixes browser crash when the --force-device-scale-factor flag is used on 4K monitors and the user is trying to open a popup window. Cause of the crash: ui_scale()/buffer_scale division here https://source.chromium.org/chromium/chromium/src/+/master:ui/ozone/platform/wayland/host/wayland_popup.cc;l=159;drc=1e3319e24d05bef56bcf40b2cacf256e285e1342 resulted in 0 because both methods return integer. This CL also simplifies scaling logic in WaylandPopup and WaylandAuxiliaryWindow. These classes used to convert pixel bounds to DIP before changing them to the coordinates relative to the parent (by applying mixed ui_scale/buffer_scale arithmetic). It's not necessary and doesn't work sometimes when ui_scale != buffer_scale. This CL was tested with --force-device-scale-factor flag as well as on single monitor setups with different scaling. Fixes for multi-monitor setups will be added in a separate CL, because at the moment scaling is not always correctly propagated to each window on them. Bug: 1052685 Change-Id: I6259e62c640e6f9cd6aeee45f27377dfa34d1ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318230Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Zakhar Voit <zvoit@igalia.com> Cr-Commit-Position: refs/heads/master@{#796345}
-
Peter Conn authored
This reverts commit a1ac648d. Reason for revert: Test failures were caused by a problem with one of the bots - https://crbug.com/1094008 Original change's description: > Disable DigitalGoodsTest#jsToTwaConnected > > Seems to be failing somewhat consistently for some of the bots > > BUG=1111906 > > Change-Id: I887a121bb77afdf8abedb39144727b7dddf88753 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332306 > Auto-Submit: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794457} TBR=yusufo@chromium.org,peconn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111906 Change-Id: I8ab059aa93fe6b8b362c9aabd6478eede10ddff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346268Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#796344}
-
Richard Stotz authored
This CL implements a flush function that attempts to flush any write buffers, including device buffers, by calling base::File::Flush(). This comes with the intent to evaluate developer feedback. Note that a future version of the API might include a faster, less reliable variant of flush. Bug: 914488 Change-Id: I556cea0f4872e5536e413b91df575c4f6a00a55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257934 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Eric Seckler authored
Adds a feature-list-controlled experiment to restrict execution of all Chrome processes/threads to LITTLE-cores only (on big.LITTLE-like architectures). We intend to run a limited experiment on Canary/Dev to estimate the potential power savings of running on the more efficient little cores, as well as the impact of this on system health metrics. We also plan to add a similar experiment for WebView. However, since WebView shares a process with the hosting app, we may need to be more careful about which threads we opt into little-core-only execution. TBR: dcheng@chromium.org Bug: 1111789 Change-Id: If2bc8c811692f7e716428398db3e5d0649da42d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332715Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#796342}
-
Maksim Sisov authored
The tests that use ClientHintsBrowserTest override FeatureList during ::SetUp call, which results in erasing UseOzonePlatform from that, and InProcessBrowserTest::SetScreenInstance cannot check the status of the feature flag during ::SetUp call. And, as a consequence, fail to decide what path it must use. Append the UseOzonePlatform feature flag back to the scoped feature list so that initialization happens properly. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I995a434a25b6e1a0db3d16bb516184c0d3bc87de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333843Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3bb048b167cc..c7ca0c496689 2020-08-10 szuend@chromium.org Remove pre-built from issues/BUILD.gn 2020-08-10 aerotwist@chromium.org Reland "Reland "Updates elements to devtools_module"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I03cf07546942efbe0027c78723d7cc841faf4269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796340}
-
Peter E Conn authored
TBR=meacer@chromium.org Change-Id: Iea493c1f49bc6180d8806988b38bae2f50aa4bf7 Bug: 1114659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346324Reviewed-by:
-
Alex Rudenko authored
Since M84 the inspector overlay shows additional a11y information that is retrieved via getters on the Element instances. The getters create new instances of AXContext which give access to the cached information about a11y in a document. When a document has no more active AXContexts, the cache is destroyed. In this case, a single context was being created and destroyed when invoking the Element getter resulting in cache misses. This CL fixes caching by making sure that the inspector overlay agent holds AXContexts for active documents. Fixed: 1112066 Change-Id: I0a006a7145cf52c9e81ccf9c30b25f2b202e6157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344345 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#796338}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008090800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/sQ-pH6rZbDHAmfK-kjBe53-R0rfRl9r_ObSKY2g81kUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/140700011,b/154289703,b/159394049,b/159394333,b/159394534,b/159863346,b/159964708,b/160203781,b/160646592,b/160930327,b/161170553,b/161179660,b/162207388,b/162207736,b/162209337,b/162211731,b/162901119 Tbr: help-app@grotations.appspotmail.com Change-Id: Ic8a8d3745ad2ae66a746b5daf388b1fc1bbb9b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344230Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796337}
-
Andy Paicu authored
TBR=davidmunro@google.com No-Presubmit: true Bug: 1114654 Change-Id: I5fd08f1532e091654e3ebb601df7e04f06569c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346244Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796336}
-
Antonio Sartori authored
This CL adds a new mojo call from blink to the browser for sending the parsed value of the frame 'csp' attribute. If the feature OutOfBlinkCSPEE is enabled: - blink parses the 'csp' attribute and sends it to the browser which will store it in the FrameTreeNode; - the required_csp FrameOwnerProperty is not being used anymore; - the required_csp frame owner attribute is not being synced between renderers anymore; - as a consequence, blink does not set the Sec-Required-CSP header on outgoing requests anymore. In a successive CL, the AncestorThrottle will use the parsed 'csp' attribute for setting the Sec-Required-CSP header on outgoing requests. Bug: 1094909 Change-Id: Idaa65d7eccde1ced19a75a86a889913071c71d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329892 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796335}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48ba75ac6845..e9cc27752c42 2020-08-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from a6d08c75d219 to 8446db62f194 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I1be8259819a90e9ca3157376767471a68b3cb8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346068Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4cba6578f09..577cc158d1e2 2020-08-10 eseckler@google.com Merge "Adds graph processor to Perfetto" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2885178e666651d1df27271cfd03b1b8d6b6d218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346066Reviewed-by:
-
Anders Hartvoll Ruud authored
This CL is a step towards improving the suboptimal ergonimics of the current CSSProperty API. The situation is this: Whenever you call CSSProperty::Get(CSSPropertyID::kVariable), the call will succeed, but the instance you get in return is an entirely useless instance of CSSProperty known as "the static Variable instance". This subclass, beyond being a NOTREACHED minefield, simply returns the wrong information "silently" in some cases. For example, CSSProperty::Get(CSSPropertyID::kVariable).GetPropertyName() unhelpfully returns "variable", which is not even a valid property name. There is a (slow) ongoing effort to remove the static Variable instance, and this CL eliminates some potential uses of it. In InspectorCSSAgent::setEffectivePropertyValueForNode, there is a lookup from a string to a CSSPropertyID, and then a CSSProperty::Get using that ID. This will not work for custom properties for the reasons already mentioned. This CL replaces that with a call to CSSPropertyName::From instead, which *does* handle custom properties correctly. In InspectorAnimationAgent::CreateCSSId, PropertyHandle::GetCSSProperty is called via the CSSTransition. The returned instance may be the static Variable instance, so we avoid this call, and instead use CSSPropertyName in this function. It is possible to get a CSSProperty instance that is valid for custom properties (see CSSPropertyRef), but since FindEffectiveDeclaration only cares about the name of the property anyway, it's more appropriate to use CSSPropertyName. Bug: 980160 Change-Id: I2291b650767b17870fc6d33e1062ea127213b757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340039 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#796332}
-
Christoph Schwering authored
FormStructure::GetServerTypes() created a vector that was always passed to data_util::DetermineGroups(). This CL removes FormStructure::GetServerTypes() and moves the relevant computation of the server into the loop in data_util::DetermineGroups(). We need to keep an overload data_util::DetermineGroups() that takes a vector because of one reference in LabelFormatter::Create(). Bug: 1007974 Change-Id: Idea5c2d4ea484701ac6a898b4eb6b667859de488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266173 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#796331}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/330914341bd4..3bb048b167cc 2020-08-10 kprokopenko@google.com [issues] Add eval CSP violations to Issues Tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082628 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iefc65c6ca4de7c3a3fbfe79deea85d4c286cd6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346070Reviewed-by:
-
Mahmoud Gawad authored
Introduce telemetry_extension_ui/test/untrusted_app_resources directory that represents how untrusted resources should be loaded from disk using TelemetryExtensionUntrustedSource. The previously registered resources (i.e. untrusted.html) is no longer needed to be registered after introducing the capability to load untrusted resources from disk. See b:156583406 This way, we simulate how 3P could load its resources and make telemetry requests. Also, since removing the registered resource untrusted.html would cause some browsertests to fail, modify the browsertest to load the registered resource: dpsl.js, instead. Bug: b:162875543 Change-Id: Ia12c1c010b8150940fb5a4a46163cfac82f17a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337473 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#796329}
-
arthursonzogni authored
Past me found something wrong in the code, but didn't change its current behavior: ``` TODO(arthursonzogni): |redirect_status| refers to the redirect status of the |blocked_url|. This is unrelated to |source_url|. Why using it in this case? This is obviously wrong: ``` Removing this weirdness fixes the previously introduced WPT test and likely fix: https://crbug.com/1113163 Bug: 1113163 Change-Id: I22cfcdd0ae5a088c9079fe3a045c49f193159d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339745 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chrome://appsAlexey Baskakov authored
The last compression step should take scaled skia image representation as the input: We should compress the image with the proper intended scale. Drive-by: Remove two duplicate apps_util::ConvertDipToPx() calls. Background: see previous change https://chromium-review.googlesource.com/c/chromium/src/+/2325349 Bug: 1112737 Change-Id: I16226014840408fc6b4792081fb528d411122de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338335 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#796327}
-
Miriam Polzer authored
Add a default value to the device policy enum for ChannelDowngradeBehavior. Bug: 1110808 Change-Id: Id5caf1988c0f2c4b9699a058213c772567316811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345145 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#796326}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbb7e0951a27..0fd4513a30ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I9951c079b16b1b83c9ef23387acfb3a1c4918ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346065Reviewed-by:
-
Maksim Sisov authored
This change doesn't bring any changes for the current Ozone/Linux config as long as the UseOzonePlatform feature is enabled by default there and cannot be disabled. Though, when use_x11 && use_ozone will be set together, we will need to specify what path to use by enabling the OzonePlatform feature. That is, we are going away from separate non-Ozone x11 and Ozone Linux configs that allow to switch between Ozone and non-Ozone with a runtime flag instead. Thus, to save some time and relax my testing, explicitly pass the --enable-features=UseOzonePlatform to tests even though UseOzonePlatform is enabled by default for OS_LINUX && USE_OZONE. Bug: 1085700 Change-Id: I3b49b45ff23ba0ad6b2ede3e3586d3db741e88fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340962 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 6503bbcb. Reason for revert: SafeBrowsingServiceTest.PersistentCookies is failing on iPad-device https://ci.chromium.org/p/chrome/builders/ci/ipad-device/11375 Original change's description: > [iOS] Use a persistent cookie store for Safe Browsing > > This makes SafeBrowsingService use a persistent cookie store, > and clears this cookie store whenever cookies are cleared for > "all time". This makes the behavior on iOS consistent with > the behavior of Safe Browsing on other platforms. > > Change-Id: I37fec41b6929386ecf2ce1e29fdbb8e95ac89383 > Bug: 1103219 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291694 > Commit-Queue: Ali Juma <ajuma@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796057} TBR=ajuma@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1103219 Change-Id: Ia5dadc043993898ddc339701f2742207f98ef41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344446Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796323}
-
Mihai Sardarescu authored
AccountConsistencyService now uses the cookie manager directly to add or delete the CHROME_CONNECTED cookies for google web domains (this change landed in CL https://chromium-review.googlesource.com/c/chromium/src/+/2323901 ). This means that it can update the CHROME_CONNECTED cookies even when the incognito mode is active as it no longer relies on using a WKWebView to inject the CHROME_CONNECTED cookies. Bug: 1102794 Change-Id: I2064ca62f801f46c0d2dae9b87276f1f6dc9bceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339656 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#796322}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64aee0acaab2..530fc3bb4cba 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3831ac2043e4 to 48ba75ac6845 (14 revisions) 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2acf87cc to 4430c2c5 (515 revisions) 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a202c209bc91 to 59b4828f293e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1112986 Tbr: fmalita@google.com Test: Test: Test: CQTest: Test: Compile and link NBA2K20 trace for AndroidTest: Test: Release build of Capture/Replay sampleTest: Test: angle_perftests --gtest_filter="*Trace*"Test: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: I68cdcc0b6840faaa26d5614a0d0f6b23111c0127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345293Reviewed-by:
-
Benoit Lize authored
Also add a CSV output to ease processing of the results. Bug: 998048 Change-Id: Iecbd99dd0ca3b468a9f954383fd6a59b709711a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341642Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796320}
-
Victor Hugo Vianna Silva authored
This CL introduces a per Gaia-account pref that keeps track of how many times a non-opted-in user has refused or ignored the bubble to move a password to the account. The pref is cleared when the user opts in. Bug: 1082152 Change-Id: I5b99f872ce30a86b65afd083c5a7f0e2285049f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340966 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#796319}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d3b414c97dd..330914341bd4 2020-08-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5bca4d9f5cd8114020af852e3a45fcf020cca78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345294Reviewed-by:
-
Victor Hugo Vianna Silva authored
Implementation: https://screenshot.googleplex.com/4Q2LOWL28un Mock: https://screenshot.googleplex.com/iNV6JAtE9t9 The CL also makes a change to <site-favicon> to allow embedding it as a round icon. Bug: 1102294 Change-Id: I70b702a1404b7c20bd0df65f7b0db06d3c999d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287297Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#796317}
-
Andrei-Laurențiu Olteanu authored
Update integration tests of GetAvailableRoutines to make them compliant. Change annotation types for Diagnostics and Telemetry to remove mojo dependency. Remove mojo dependency from untrusted.js. Change error handling for Diagnostics and Telemetry. Bug: b:153371185 Change-Id: Ia1f25b5a141551bcd37f92cc7cc895ab70aa0f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339984Reviewed-by:
-
