- 18 Jun, 2020 9 commits
-
-
Adam Argyle authored
Intent to prototype: https://groups.google.com/a/chromium.org/d/msg/blink-dev/oNJTem41LBs/CA4Nx05aAwAJ Bug: 1051189 Change-Id: I2ff88a70858cf322725f50e40f979c9596f45b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083838 Commit-Queue: Adam Argyle <argyle@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#779564}
-
Anand K Mistry authored
The provided implementations are the same as the default, so just use default. Bug: None Change-Id: Ie4c772a6371805cd869673b9979983cfa7714f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249284Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#779563}
-
Alexander Cooper authored
Bug: 1095740 Change-Id: I041f123e851ac4364e1c044b17f601f9925b3f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236038 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779562}
-
Andrew Xu authored
As reported by Clusterfuzz, hotseat widget may not have enough space to fully show even one shelf icon. Under that edge case, the end of the last shelf icon will be outside the scrollable shelf. Based on the current code, |last_visible_view_index| will be -1. This CL fixes the issue. Bug: 1094363 Change-Id: Ib4a49267c82a54e3c66f88df9702dddb216eca89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250706 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779561}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I0c69dcf8d27d25b30d4e211bce41f80de70d110b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248575 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779560}
-
Anand K Mistry authored
Using 'default' is the modern C++ approach used by chromium, and some analysers complain about the old style. Bug: None Change-Id: Ic531d39490f3005abb163830dfc312e1351b003a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249283Reviewed-by:
-
Xing Liu authored
A unit test only for compiling MockDownloadItem is not needed. Bug: NONE Change-Id: I106c2a9a5bacad516373905df1d4e8141ff1c441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250930 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779558}
-
Victor Vasiliev authored
R=dschinazi@chromium.org Change-Id: I561e3c9d88d6301e150c12b102911ffb22d92c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250954Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779557}
-
Jun Kokatsu authored
This change improves sanitizer in parse_html_subset.js by using allow-list of tags and attributes. Bug: 1086318 Change-Id: I56b94350d49bbb9e218336c9292897ac2e619316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222115Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779556}
-
- 17 Jun, 2020 31 commits
-
-
Matt Jones authored
This patch moves all of the bottom sheet files to their new home in components/browser_ui/android/bottomsheet. Files have been split into several build targets: - /: The root directory contains the public API; any feature is allowed to depend on this. - embedder: This target is for systems embedding the bottom sheet as part of their activity. These classes are necessary to effectively manage the sheet. - internal: This target contains the actual implementation of the sheet and should not be exposed outside of the bottom sheet component. - test: Tests (eventually) and test support. Bug: 1002277, 1004415 Change-Id: Ic6a76044555da27ce75d8843de8e624d1b1788c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242112 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#779555}
-
Daniel Libby authored
This is currently only used for scrollbar parts, which do not have descendant layers. Instead just set needs paint on the painting layer and invalidate the DisplayItemClient (the same LayoutObject the ObjectPaintInvalidator is initialized with) via SlowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient. There was not any unit test coverage for InvalidatePaintIncludingNonCompositingDescendants which uses the same traversal algorithm, so convert tests of the deleted method to use this one instead, and validate only the paint invalidation side-effects. Bug: 1007989 Change-Id: Ic9849f889958300941bc9a48d97cf7f04a91c786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247157Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779554}
-
Shengfa Lin authored
With JSON_REPLACE_INVALID_CHARACTERS option, json parser is replacing lone high surrogate but not lone low surrogate. This is to replace lone low surrogate. Tests: autoninja -C out/Default content_shell base base_unittests services services_unittests out/Default/base_unittests --gtest_filter="JSONParserTest.*:JSONReaderTest.*:JSONStringEscapeTest.*:StringUtilTest.IsStringUTF8" Bug: chromedriver:3515 Change-Id: I547b8b7edaa24e7de79dc980746815de607a0918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248342Reviewed-by:Mathias Bynens <mathias@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#779553}
-
Jacques Newman authored
By calling these methods internally, we cause the histograms to be inaccurate, as they should be tracking external calls. Bug: 1095772 AX-Relnotes: n/a Change-Id: I505a7bcddee34a382ead4387088c53dc921571af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247346 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779552}
-
Daniel Libby authored
No callers and is not correct for CompositeAfterPaint. Found as part of investigating crbug.com/1007989 Change-Id: Ic572b50a39f21e9e9ea30a5ed5d7fe3ca1b57f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246434 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
-
Ben Pastene authored
The two sets of pools should be identical now. So this moves all tests back to the old pools so we can delete the temporary *.template ones. Bug: 812428 Change-Id: Ibdb1525d299d911b1e5b1d4b0ba71cfa1abcc293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250086 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#779550}
-
Jason Lin authored
* kPluginVmAppId -> kPluginVmShelfAppId: This id is also used by Plugin VM installer as the shelf id on the window. Rename to make it clearer. * IsPluginVmWindow() -> IsPluginVmAppWindow(): This function only return true for the Plugin VM app window but not the installer window. Rename to make it clearer. Bug: 1087726 Change-Id: Ib7cf899133ed970bd795c859ac740f5c15f77b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247460Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Jose Dapena Paz authored
Calls to memset and std:all require the includes they are declared. Bug: 819294 Change-Id: I58f4ed8d6c0645a5785077e728faa500282e863e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248186Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#779548}
-
Sammie Quon authored
See linked bug for why the types of windows are undesirable and should also be fixed at the callsites. But in the meantime, they can exist so we need to protect. For these windows, they are part of the WindowCycleList. Since we group up transient related windows in overview/alt+tab, those two surfaces are seemingly unaffected. For tablet mode transition, a screenshot is first created and then deleted either if no animation is run, or at the end of TRANSFORM animation. Since these windows cannot be maximized, they are actually given a BOUNDS animation. The check to see if a window is animating should be specifically check for TRANSFORM animation. Test: added regression test Fixed: 1096128 Change-Id: Ide585fae26f6ed7a96d3a181b399385f2fa461f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250459 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#779547}
-
Allen Bauer authored
It is not used anyplace, only referenced in one file and BUILD.gn. Change-Id: I6a3bf313ae92273148c440789c4d95d2f72a02a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249596Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#779546}
-
dpapad authored
This is a temporary fix which will be replaced with an assertion in a follow up. Currently there is an assumption in the code that if unpack_pak.py is used the output of that script is placed in a folder that is suffixed with '.unpak', which is not true for NTP which uses a folder named 'unpak' without the dot. This fixes the contents of out/<out_folder>/gen/chrome/browser/resources/new_tab_page/optimized_js.d to not hold unexpected entries for files already in the unpak folder. Bug: 1093405 Change-Id: Ib84b5b0890d1a98e938dcdf691e621b397b8de91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250660Reviewed-by:
-
Lindsay Pasricha authored
Also updated ios fyi bot def to os=mac 10.15. Bug: 1087433 Change-Id: I348d9b8d9bb637a2c79bb58086cfe6ea8206005a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240459 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#779544}
-
Lexi Stavrakos authored
Bug: 1088004 Change-Id: I4657f338aeec6399e85035c5c800b704ff8b6f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248455 Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779543}
-
Alex Gough authored
PrivateExtractIcon (underlying the icon loading service) may fail to supply an icon for PE files that do not have one embedded and would display as a blank area when downloaded. This change fetches the default for the file extension prior to fetching the file's embedded icon. It is difficult to do this only on failure as the ownership of IconLoader means it has already been deleted when we learn about the failure. It should be relatively cheap to fetch the default icons as these will be cached by the OS, and this occurs in the main process. Tests: Added LoadDefaultIcon in icon_loader_browser_test Bug: 1032250 Change-Id: Ifad1c9f013d0e4fe87aaec5ec0cdeae08d06799e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242371 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779542}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ea4aec9cfcd7..1cdd473e5bca 2020-06-17 rwkeane@google.com Add Operators to ErrorOr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib50ce96ce6fa151ffc48a01ef8d4ee7380c42c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779541}
-
James Cook authored
Based on UI review comments this one has: * Title "You're signed in" * Subtitle "The following services help..." * Buttons "No thanks" and "Got it" See bug for screenshot. Bug: 1074436 Test: updated browser_tests Change-Id: Ifa214522511fadaed7bdf166b2a865632422de7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247327Reviewed-by:
-
Kyle Horimoto authored
This reverts commit 7ce70f8a. Reason for revert: Breaks Chrome uprev (https://crbug.com/1093405) Bug: 1045266, 1093405 TBR: dpapad@chromium.org TBR: rbpotter@chromium.org Change-Id: I96c8c8f95aa3f3b06b36373790b30b919c59e9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249595 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Meilin Wang authored
Removed the |UpdateDisplay()| call during test set up, since the effected test cases have been disabled due to flakiness. Bug: b/158617675 Test: manully. Change-Id: I4ff9ec8fd0474bbb85d19e658d5a3aa44e6f435f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250700Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#779538}
-
Chong Gu authored
Currently, stderr of AEMU is overwritten by the Fuchsia system logs when running test packages. Redirect stderr to system stderr to avoid this. Bug: 1095199 Change-Id: Ie4dc997093b94f2db4588ea6ba9e78ad000d427c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246993 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779537}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/70c2cfd61548..ceb64a4f57d1 2020-06-17 eliribble@chromium.org Improve Python-3 compatibility of download_from_google_storage.py 2020-06-17 wnwen@chromium.org Support formatting python3 scripts (reland) 2020-06-17 weiweilin@google.com [lucicfg] Update v1.15.1 -> v1.15.2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1062053,chromium:1066815,chromium:1095581 Tbr: agable@chromium.org Change-Id: I05818a5691cf3f031ac25deb72de6cd05677c491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250481 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Eugene But authored
Logs presentation of HttpAuth dialog, all JS dialogs, App Launching dialog and generic alerts. Also refactor breadcrumb_manager_browser_agent_unittest.mm to have less repetitive code, since this CL adds a lot of new tests. TBR: michaeldo@chromium.org Bug: 1082915 Change-Id: I5727e65717c57cd48bac03922342f6b8eee9b286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240394 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#779535}
-
Charlene Yan authored
Clicking on a tab deselects any other selections, same should happen for the tab group header. This also prevents scenarios where the collapsed group has a selected tab. Bug: 1018230, 1095779 Change-Id: I250323c4e5b2e7d766096140e7fe5284d8c7b2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250878 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#779534}
-
zhaoyangli authored
The EG2 test bundle name has a "-Runner" suffix appended to EG2 test target name. This change adds it to the bundle name check in chrome_test_case.mm for flaky and multitasking suites. Bug: 1093411, 1093981 Change-Id: I78b72f74109c945641ab23c35f09a2506df62a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250550Reviewed-by:
-
Victor Costan authored
The //storage/browser/blob/mojom directory was created to hold mojo interfaces decoupling the Blob subsystem from storage features using it, such as Cache Storage and IndexedDB. This location was chosen because the mojo interfaces conceptually belong in the Storage Service, but at the time the Storage Service did not exist in the source tree. Now that the Storage Service skeleton has been created at //components/services/storage, this CL moves the mojo interfaces there. This CL also adds a final relationship solidifying the dependency graph between the various directories holding storage code. The dependency hierarch, from the lowest to the highest level, is: 1) //components/services/storage 2) //storage/browser/ 3) //content/browser/ Mechanical replacements: * storage/browser/blob/mojom/blob_storage_context.mojom -> components/services/storage/public/mojom/blob_storage_context.mojom * //storage/browser:mojom -> //components/services/storage/public/mojom Bug: 1016063 Change-Id: I456d1f4a7f363d5b0bad73333acd6101860221d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247399Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779532}
-
Abhijeet Singh authored
The current https go-link is not getting redirected properly. As suggested in go/faq#keep-the-presentation-clean1 as a best practice, the go link should be prefixed by either http or a complete goto URL for the https version. Bug: b:159237992 Test: Tested on Chrome OS VM and Atlas test device. Change-Id: Icb1e60a1dc057b6f5b64f064ac485303ea09edf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250823Reviewed-by:
-
Rune Lillesveen authored
If we cache a ComputedStyle which is computed outside of the flat tree, any pending resources will stay StylePendingImage. That means we cannot use such a ComputedStyle for cached styles for a rendered element. We already did this check for display:none subtree ComputedStyles, but we need the same check for IsEnsuredOutsideFlatTree(). Bug: 1095669 Change-Id: Ide7395207a6d73b78bc793e4ee4c10cf31b9696f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250201Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#779530}
-
Nodir Turakulov authored
R=gbeaty@chromium.org Context: https://chromium-review.googlesource.com/c/chromium/src/+/2248674 Change-Id: I9a11214815aeda0ece8a8c0a2877ee0822852ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249298 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Christoph Schwering authored
This CL makes FormStructure::Encode{Query,Upload}Request() memorise the form and field signatures, including their order, and AutofillDownloadManager assign the field type predictions from the server response to *all* fields of the queried signatures. Before this CL, AutofillDownloadManager relied on (a) forms not changing during communication with the Autofill server, and (b) no FormStructures of a page having identical form signatures. The latter led to only the first of perhaps multiple FormStructures with identical signatures receiving server field type predictions. The bug became apparent only since revision 1bd72869 changed AutofillHandler's FormStructure cache to index by renderer ID instead of form signature, so that distinct forms with identical signatures can be represented by distinct FormStructures. Bug: 1064709 Change-Id: I8e3355c0f3ec9dde4b53cb766ba37b29b2c04397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244252Reviewed-by:Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#779528}
-
Yi Xu authored
canvas/offscreen/the-offscreen-canvas/offscreencanvas.resize.html is renamed to canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html Bug: 1093709 Change-Id: Ib775d1fec3d18a44ca0927a1c6828cbc594cf810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250779Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#779527}
-
Jose Dapena Paz authored
It breaks compilation of blink::WebServiceRegistrationObjectInfo that includes WebServiceWorkerObjectInfo instance. This one uses default move constructor without noexcept declaration, but has as members CrossVariantMojoAssociatedReceive and CrossVariantMojoAssociatedRemote with noexcept declaration in move constructor. declared noexcept. As resolved in other places, noexcept is not really much useful with -fno-exception and our codebase is not prepare to add it consistently. Clang will not report exception declaration incompatibilities in case -fno-exception is used, but GCC fails. Bug: 819294 Change-Id: Id5c46c271a8a92352d769de9c3c263d3dce4c9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247791 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#779526}
-
Collin Baker authored
A Profile can be deleted without a preceding OnSessionEnded call. See https://chromium-review.googlesource.com/c/chromium/src/+/2238363/1 and https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877847700690046144/+/steps/browser_tests__with_patch__on_Windows-10-15063/0/logs/Deterministic_failure:_TouchLocationBarViewBrowserTest.OmniboxViewViewsSize__status_CRASH_/0 for an example of this in action. This CL has ProfileActivityMetricsRecorder observe the currently active Profile to handle its deletion gracefully. Bug: 1094407 Change-Id: Ifaec71ad97671ab74f377ba44695c2e8b34153a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242435 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#779525}
-
