GitLab

This pulls in the following Native Client changes:

r13217: (jvoung) Remove old copy of nacl_file_info.h now that chrome uses new copy.
r13218: (noelallen) Roll GN binaries
r13219: (dschuff) Add pnacl win bot to default trybot set
r13220: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13221: (dyen) Fixed toolchain_build exception when gcc is not found on the system.
r13222: (dschuff) Add -DDEFINE_MAIN to build of unsandboxed IRT in pnacl_targetlibs.py
r13223: (sehr) Make android build with -Werror
r13224: (sehr) First gyp changes for Android chromium build
r13225: (dschuff) Update revision for PNaCl r13214->r13222
r13226: (dschuff) Move Mac and Linux32 Non-SFI and unsandboxed tests from toolchain bots

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/292353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272480 0039d316-1c4b-4281-b951-d872f2087c98

This API is called when initial metrics gathering should start, and takes in a
callback that is called when initial metrics gathering is complete. It is
currently empty but will be filled in as initial metrics gathering code moves
out of MetricsService.

BUG=374231
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/299663011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272479 0039d316-1c4b-4281-b951-d872f2087c98

Previously we would not define it in component builds because it didn't work with old versions of MSVC. These days it should work.

The macro is extra important for Clang, which doesn't currently support exceptions on Windows.

BUG=82385

Review URL: https://codereview.chromium.org/287193012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272478 0039d316-1c4b-4281-b951-d872f2087c98

This is to facilitate the addition of an app launcher example/demo app,
separate from the browser, and to assist testing of the out-of-process
compositor on mac.

The change splits out from the current views_examples_with_content_exe
target a new views_content_client target placed in
ui/views_content_client. views_examples_with_content_exe is updated to
use it.

This will allow the app launcher to have its own example app, while
reusing the logic to set up the multiprocess runtime environment for
using views and content.

Follow-up patches for the views_content_client runtime will: isolate
aura dependencies, introduce the gpu_process UI compositor, and
implement the runtime environment for mac.

BUG=365977

Review URL: https://codereview.chromium.org/284113011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345922

Review URL: https://codereview.chromium.org/296053017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272475 0039d316-1c4b-4281-b951-d872f2087c98

Also includes an updated histograms.xml after running the script.

Review URL: https://codereview.chromium.org/276663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272474 0039d316-1c4b-4281-b951-d872f2087c98

Support using single-threaded compositor with a single
DelegatedRendererLayer on a thread that does not have a MessageLoop.

First, Allow BlockingTaskRunner to be used on a thread that does not
have a MessageLoopProxy. For these threads, all PostTask calls must
be wrapped in CapturePostTasks. Use PlatformThreadId rather than
MessageLoopProxy::BelongsToCurrent thread to check for current.

Then fix DCHECK failures in Proxy to allow MessageLoopProxy to be
NULL.

Add tests to verify these code paths are indeed working.

BUG=344087

Review URL: https://codereview.chromium.org/292493006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272473 0039d316-1c4b-4281-b951-d872f2087c98

With this change, Mojo applications that link against mojo_environment_chromium
do not need to instantiate mojo::Environment. We rely on AtExitManager for all
finalization of singleton objects. This frees us up to use the familiar
base::Singleton and base::LazyInstance for any such state. Tests can use
ShadowingAtExitManager to clean the environment between test runs.

It becomes a link error to use mojo::Environment if you are not linking against
mojo_environment_standalone. I plan to follow this up with a change that buries
mojo::Environment for the case where you are linking against
mojo_environment_standalone. Ideally, this means no one will ever need to think
about mojo::Environment again.

Review URL: https://codereview.chromium.org/281353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272472 0039d316-1c4b-4281-b951-d872f2087c98

This mostly adds a TODO for POSIX. (We want to actually send "real"
messages with FDs attached, which means that we have to "split" any
message with too many FDs into multiple messages.)

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/297683012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272471 0039d316-1c4b-4281-b951-d872f2087c98

We've deprecated the proxyservice user in favor of the tlsdate
user tlsdated runs as. Add this user to the ACL for LibCrosService
so that we can delete the old one.

BUG=chromium:376526
TEST=tlsdated autotests

Review URL: https://codereview.chromium.org/299063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272470 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this, the RenderWidgetHostViewMac was responsible for drawing
(with its NSViews and CALayers) the contents coming from the renderer
compositor or the browser compositor. This was was getting too messy
(lots of state was shared unintentionally).

This create a BrowserCompositorViewMac sub-NSView of the 
RenderWidgetHostViewMac, which is responsible for drawing delegated
renderer content coming from the browser.

This class still uses the SoftwareLayer and CompositingIOSurfaceLayer 
classes used to draw content from renderer. In order to make this clean,
cut the dependencies from the CompositingIOSurfaceLayer to the
RenderWidgetHostViewMac, and hide all needed communication behind a
CompositingIOSurfaceLayerClient interface (which is likely to be needed
by the BrowserCompositorViewMac).

It would seem more reasonable to have BrowserCompositorViewMac live in
the ui namespace and directories, but that is not an option yet, because 
it needs to share so much code with RenderWidgetHostViewMac.  Once we
switch to using only a delegated renderer, we can move all of this code
over to ui.

Also, start replacing instances of "composited" with "accelerated". It
used to be that these were synonyms, but they are not anymore --
"composited" can be either "accelerated" or "software".

BUG=314190

Review URL: https://codereview.chromium.org/294023012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272469 0039d316-1c4b-4281-b951-d872f2087c98

* Generally follows guidelines in https://http2.github.io/http2-spec/#TLSUsage.
* Apply only to SPDY4+ versions
* Fail the stream job if the TLS version for SPDY is too old (<1.2)
* Fail the stream job if the TLS cipher suite is sucky. Note that we're stricter here than the HTTP/2 spec.

Also added while implementing this CL:
* Add SSLConnectionStatus setters.
* Add ability for SSLSocketDataProvider to set SSLConnectionStatus.
* Add modern cipher suite check into net/ssl.

BUG=374957

Review URL: https://codereview.chromium.org/291093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272467 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/291893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272466 0039d316-1c4b-4281-b951-d872f2087c98

As a result, Pipeline now handles prerolling and underflow/rebuffering
by listening for BUFFERING_HAVE_NOTHING/ENOUGH callbacks. Preroll() is
renamed StartPlayingFrom() and no longer accepts a completion callback.
In this new model, AudioRenderers immediately enter and remain in
the "playing" state and fire buffering state callbacks to let Pipeline
know when to start/stop the clock.

BUG=144683

Review URL: https://codereview.chromium.org/284763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272465 0039d316-1c4b-4281-b951-d872f2087c98

Forward-declare AndroidHistoryProviderService in history_service.h
instead of including android_history_provider_service.h since the
type is only used for a friendship declaration.

BUG=371820

Review URL: https://codereview.chromium.org/285763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272464 0039d316-1c4b-4281-b951-d872f2087c98

Compilation on Mac Builder (dbg)
FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/spy/mojo_spy.websocket_server.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=206824 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DMOJO_USE_SYSTEM_IMPL -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register -Wno-selector-type-mismatch -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all  -c ../../mojo/spy/websocket_server.cc -o obj/mojo/spy/mojo_spy.websocket_server.o
../../mojo/spy/websocket_server.cc:30:16:error: no member named 'SetClient' in 'mojo::spy_api::SpyServer'
  spy_server_->SetClient(this);
  ~~~~~~~~~~~  ^

> Adding more guts to the mojo spy.
> 
> This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.
> 
> Still a quite a few loose ends, specially on teardown.
> 
> I updated the design doc to reflect this CL:
> https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing
> 
> 
> BUG=360188
> TEST=manual via test/spy_repl_test.html
> 
> Review URL: https://codereview.chromium.org/284743002

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/296453021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272463 0039d316-1c4b-4281-b951-d872f2087c98

Also changes ProvideStabilityMetrics() to take a SystemProfileProto* instead
of the stability section, since the plugin provider needs to inspect things
in the system profile when writing its stability data.

Also, cleans up some header includes.

BUG=374220
R=isherman@chromium.org, thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/299783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/299833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272461 0039d316-1c4b-4281-b951-d872f2087c98

msg_handled_ should only be set if ref is this is still valid.

BUG=374320
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/296993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272460 0039d316-1c4b-4281-b951-d872f2087c98

R=brianderson@chromium.org
BUG=376463
TEST=SchedulerTest.TestTriggerDeadlineEarlyForLoseOutputSurface

Review URL: https://codereview.chromium.org/294473014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272459 0039d316-1c4b-4281-b951-d872f2087c98

This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.

Still a quite a few loose ends, specially on teardown.

I updated the design doc to reflect this CL:
https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing


BUG=360188
TEST=manual via test/spy_repl_test.html

Review URL: https://codereview.chromium.org/284743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272458 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=369521
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/296513020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272457 0039d316-1c4b-4281-b951-d872f2087c98

L bots need OpenJDK 7 and OpenJDK 7 works when building with older SDK's.
Also, this removes the awkward way we had to install Oracle's JDK.

BUG=353155

Review URL: https://codereview.chromium.org/294093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272456 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/290173011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272455 0039d316-1c4b-4281-b951-d872f2087c98

Guests can exhibit un-intended behavior otherwise.

BUG=None
Test=Internal

Review URL: https://codereview.chromium.org/298913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272454 0039d316-1c4b-4281-b951-d872f2087c98

Since GCMDriver is going to be moved into component, it cannot access
chrome build info. So we now let GCMProfileService retrieve and pass
it.

Also change to define build info in GCMClient, instead of relying on
the one defined in proto buffer generated file.

BUG=356716
TEST=existing tests

Patch

Review URL: https://codereview.chromium.org/293053014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272453 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272449 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174434:174635&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/296983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376695
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/299153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272447 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the readDescriptorValue function of the
bluetoothLowEnergy API.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*

Review URL: https://codereview.chromium.org/297003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272445 0039d316-1c4b-4281-b951-d872f2087c98

The test is supposed to ensure that the breakpad component is correctly
hooked up to content_shell, and that the surrounding tools can actually
convert a crash into a symbolized stack dump.

This version is currently Linux-only, other platforms will be added.

The test is based on
http://www.chromium.org/developers/testing/webkit-layout-tests/using-breakpad-with-content-shell

This would have caught e.g. a call to base::GetLinuxDistro() being added
on the UI thread, or dump_syms not supporting debug fission yet.

The test needs to be executed like this:

 $ content/shell/tools/breakpad_integration_test.py \
      --build-dir=out/Debug --binary=out/Debug/content_shell
 # Generate symbols.
 # Run content_shell and make it crash.
 # Retrieve crash dump.
 # Symbolize crash dump.
 PASS: Breakpad integration test ran successfully.

BUG=372928
R=thestig@chromium.org, rsesek@chromium.org

Review URL: https://codereview.chromium.org/293993017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272444 0039d316-1c4b-4281-b951-d872f2087c98

as broken unless the main job succeeds, do not mark Alternate-Protocol
broken in the QuicStreamFactory unless the session was a failed 0-RTT
connection (in which case the Job already "succeeded").

Review URL: https://codereview.chromium.org/293063013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272442 0039d316-1c4b-4281-b951-d872f2087c98

Instead, we have InterfacePtr::set_client(..) and InterfaceImpl getting a
client set on it internally. This simplifies InterfaceImpl quite a bit.

BUG=374436

Review URL: https://codereview.chromium.org/289063015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272441 0039d316-1c4b-4281-b951-d872f2087c98

Since ExtensionRegistry::AddObserver replaces it.

This CL is the result of below script, and 'git cl format'.

find -regex '.*/.*\.\(mm\|cc\|h\)$' |
xargs sed -i s/NOTIFICATION_EXTENSION_INSTALLED/NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED/g

BUG=376293

Review URL: https://codereview.chromium.org/298883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367029

Review URL: https://codereview.chromium.org/293033009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272439 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272437 0039d316-1c4b-4281-b951-d872f2087c98

TBR=slamm@chromium.org
BUG=

Review URL: https://codereview.chromium.org/299043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354775
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/291833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773

Review URL: https://codereview.chromium.org/294113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272434 0039d316-1c4b-4281-b951-d872f2087c98

This should simplify ifdefs and ensure flexibility as we move to new platforms.

BUG=370071

Review URL: https://codereview.chromium.org/294173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272433 0039d316-1c4b-4281-b951-d872f2087c98