- 01 Mar, 2018 40 commits
-
-
Qiang Xu authored
Bug: 805046 Test: covered by tests Change-Id: Iad3ab2364eb5c034e1d78c5160918d9c10fe9c31 Reviewed-on: https://chromium-review.googlesource.com/942345 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#540221}
-
Mihai Sardarescu authored
This CLs filters out accounts that do not match pattern RestrictSigninToPattern. Bug: 807799 Change-Id: I2bf581315883166502920c3e86e9e6e9dabcf120 Reviewed-on: https://chromium-review.googlesource.com/928401Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#540220}
-
Mounir Lamouri authored
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aXYvQ01tMhw Bug: 690364 Change-Id: I3357e97e437069012554b60b0ae527a7b9998606 Reviewed-on: https://chromium-review.googlesource.com/943502Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#540219}
-
Maks Orlovich authored
... since it's easy for test fixture to provide based on public API. This reduced SetCookieWithCreationTimeAndOptions down to a single caller, so fold it in and simplify it a little bit. Bug: 731236 Change-Id: Ib5acd742ddb6aea7d26dff4952f800826bf5f1e2 Reviewed-on: https://chromium-review.googlesource.com/940142Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#540218}
-
Yash Malik authored
Change-Id: Id158c8cb4327a6aa795dd6bdeb14439fa6ef4704 Reviewed-on: https://chromium-review.googlesource.com/943680Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#540217}
-
bsheedy authored
Adds a new VR browsing Telemetry benchmark using WPR archives. It re-uses the URL list and WPR archive from the memory.top_10_mobile benchmark since they're reasonable sites that users of the VR browser might visit. Bug: 808597 Change-Id: I37a2a9ba14cdf2887125564d1cf1f653940fed6d Reviewed-on: https://chromium-review.googlesource.com/942086Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#540216}
-
Elad Alon authored
Bug: 775415 Change-Id: I0f88d37212866ba343e26b63d955cb7ad4a744b0 Reviewed-on: https://chromium-review.googlesource.com/943421Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#540215}
-
Robert Sesek authored
RUSAGE_SELF is already allowed for process-wide rusage, so per-thread should be permitted as well. Bug: 812250 Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: I5e8a3203875238296cd96a861b70feff115bc97e Reviewed-on: https://chromium-review.googlesource.com/941592Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540214}
-
Christopher Grant authored
There doesn't seem to be a reason to re-bind every frame, and it takes 300 us of CPU time to do so. BUG= R=vollick Change-Id: I487cf7e9268396bb71fe3317c6b27edf72a59bdf Reviewed-on: https://chromium-review.googlesource.com/943347Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#540213}
-
Stephen McGruer authored
Previously nullable values in the animations code were tracked by storing nulls as quiet_NaN() and using std::isnan as a null-detector. It is much more explicit to store such values using WTF::Optional, which forces code to consider whether or not the offset exists. Bug: 791086 Change-Id: Iad5e53456c40859bb7e3322c0cb6152b01f376e2 Reviewed-on: https://chromium-review.googlesource.com/939748 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540212}
-
https://chromium.googlesource.com/angle/angle.git/+log/98e6a5f7b0ae..d6fef528fcfc $ git log 98e6a5f7b..d6fef528f --date=short --no-merges --format='%ad %ae %s' 2018-03-01 oetuaho Shorten mangled names of types Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I94b61a390ee85fe6c7bc340d0af5d7e2dd4472fd Reviewed-on: https://chromium-review.googlesource.com/943592Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540211}
-
Carlos IL authored
With committed interstitials on, supervised user interstitials are now displayed using the new codepath. For this, supervised user throttle was modified so it cancels the navigation with the interstitial HTML. Browser tests were also modified so they test the committed interstitials cases too. Will be done on future CLs (and disabled tests requiring this will be re-enabled): -Adding bindings for interstitials to request permission or go back. -Handling the case where the URL list changes and we have to block the current page. -Migrate everything off of base::Callback. Bug: 780032 Change-Id: I53af29c43cc9d905b078c308021562830c05f47e Reviewed-on: https://chromium-review.googlesource.com/940459Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#540210}
-
Patrick Monette authored
This function uses automation to automatically write the name of a program into the search box of the Apps & Features page. Bug: 717696 Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907 Reviewed-on: https://chromium-review.googlesource.com/907590Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#540209}
-
Ahmed Fakhry authored
This CL makes the existing shortcuts affect whatever magnifier is currently enabled. This was also an opportunity to unify some scale related code. BUG=817490 TEST=Added test coverage Change-Id: I366ee56629d09ae22c725b034bfc410077fe52ab Reviewed-on: https://chromium-review.googlesource.com/942052 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#540208}
-
Oystein Eftevaag authored
With the direction both tracing and resource_coordinator has taken, there's no actual shared code between the two; this undoes the original move from //services/tracing. Mainly a mechanical move, except for starting up as an independent service. Change-Id: I093015c419166655b2015f7eddf4477983a16af9 Reviewed-on: https://chromium-review.googlesource.com/939659 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540207}
-
Alexei Filippov authored
Change-Id: Ia0632c8b4fb4e3ba2daf9461f1ee11443db4efd8 Reviewed-on: https://chromium-review.googlesource.com/942028Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#540206}
-
Mustaq Ahmed authored
The nullptr was added in a past refactoring before UserActivationV2 was ready. Test failures with v2 enabled exposed the problem. Bug: 816527 Change-Id: Ia94fb85831c9ca312d45695e10cb0701c836153a Reviewed-on: https://chromium-review.googlesource.com/937659Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#540205}
-
Jay Civelli authored
Moving ZipFileInstaller from chrome/ to extensions/ and changing it to take a callback instead of directly installing the unpacked extension/theme. Providing a method in chrome/ to create a callback that does the installation (previous behavior). This CL is in preparation for using the Unzipper service to install extensions, as some of the logic performed by the utility handler code will be moved to this class and we'll be shared with the CrxInstaller class. Note that the zipfile_installer_unittest could not yet be moved to extensions/, it will be done later (see crbug.com/817131). Bug: 799220 Change-Id: I9ae6f13e5e9a0af4c111119952fd8915ff3dcfd3 Reviewed-on: https://chromium-review.googlesource.com/939842 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#540204}
-
Robert Liao authored
This change will be reverted after the M66 branch point. ExtensionPopup Views will need some harmonization work to bring it up to parity with some behavior provided by Mac. BUG=728174 Change-Id: Ia01160117c9dbda10e57d4f4b5a4fe706a39f36c Reviewed-on: https://chromium-review.googlesource.com/941883Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540203}
-
Vasilii Sukhanov authored
It happens when the form is prefilled when detected by the password manager. Bug: 817754 Change-Id: Ia6c8ecd2257950aa34b3fedf796a9696c71cf4fb Reviewed-on: https://chromium-review.googlesource.com/943503 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#540202}
-
Jeremy Roman authored
base/memory/ptr_util.h includes will be cleaned up later. Generated by: git grep -l base::MakeUnique chrome/browser/ | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/' Presubmit bypassed due to unrelated existing errors in touched lines. Bug: 755727 No-Presubmit: true Change-Id: Ib4480069b2a369566e6ae4a3d426a0797f5984bb Reviewed-on: https://chromium-review.googlesource.com/943461 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#540201}
-
Vadym Doroshenko authored
When a password form is added dynamically (i.e. with JavaScript after finishing of a page load) IOS Password Manager may learn about existing of this form only after user clicking on some field in this form. On CL https://chromium-review.googlesource.com/c/chromium/src/+/601969 it was implemented retrieving credentials from the Password Store as soon as the user clicked on dynamically added form and then credentials are autofilled. But fill on account select is not available until the user makes another interaction with the form (for example start typing of username). That's suboptimal user experience, it would be good to propose fill on account select immediately as soon as the user clicks the first time in the form. This CL implements async suggestion response to Autofill framework in the same way as it's already implemented in Autofill: 1.When checkIfSuggestionsAvailableForForm (password_controller.mm) is called, and it's found that credentials haven't been retrieved yet for this page, the callback is saved untile response from the Password Store is received. 2.It's implemented that Password Store response is propagated to PasswordController even if case when there are no credentials saved for this page in order to inform Autofill framework that no suggestions are available. Bug: 708597, 709011, 708634 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idecc3e621100f3e1b0a3803ce944c4cc116fc3a4 Reviewed-on: https://chromium-review.googlesource.com/921961 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540200}
-
Lukasz Anforowicz authored
After this CL, CrossSiteDocumentResourceHandler won't call |next_handler_|'s OnResponseStarted until it has made the allow-vs-block decision. Until that time network::ResourceResponse (which among other things include the response headers) is stored temporarily in a CrossSiteDocumentResourceHandler's field. Postponing the call to next handler's OnResponseStarted confuses MimeSniffingResourceHandler (which does the same thing to its downstream handlers, but doesn't expect this treatment from its upstream handler). The CL works around that by changing the relative order of the handlers (after CL, MimeSniffingResourceHandler is before CrossSiteDocumentResourceHandler). This change requires that the first CrossSiteDocumentResourceHandler::OnWillRead always allocates a |local_buffer_|, because MimeSniffingResourceHandler will make the first call to OnWillRead before letting CrossSiteDocumentResourceHandler determine |should_block_based_on_headers_| by calling OnResponseStarted. This CL adds CrossSiteDocumentResourceHandler unit tests that also cover MimeSniffingResourceHandler in the stream of resource handlers. The new tests help ensure that CrossSiteDocumentResourceHandler interoperates well with MimeSniffingResourceHandler (wrt call order and also the sniffed mime type). OTOH, the old tests are retained, because driving CrossSiteDocumentResourceHandler more directly allows the tests to make more assumptions about the internal state and make more test assertions (e.g. assert that downstream buffer differs until the block-or-allow decision is made). Bug: 808205 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I304df0b40c71dd212a469b6b3cc4c13bed533fb0 Reviewed-on: https://chromium-review.googlesource.com/907323Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#540199}
-
Sammie Quon authored
Remove md_pin_keyboard.html/js. It shares a lot of common code with cr_components/chromeos/quick_unlock/pin_keyboard.html. Modify cr_comp../c/qu/pin_keyboard to take a bunch of mixins and vars, so the settings keyboard and lock keyboard can keep their respective styles. Test: manual Bug: 809828 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I618c5325fe374c590b6e232675e77a06435d2604 Reviewed-on: https://chromium-review.googlesource.com/930480 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540198}
-
erikchen authored
Now that we emit private memory footprint, the former number is not particularly meaningful. Bug: 815328 Change-Id: I85cb76b08ef85073179b5c334c16d4775667b8e6 Reviewed-on: https://chromium-review.googlesource.com/940144 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540197}
-
Alex Newcomer authored
In the new applist folders we re-use various components. In AppsGridView we had a bool that was used to determine if we should show suggested apps, but the bool did not check to see if the AppsGridView was being used inside a folder. This was causing a DCHECK failure because row was being computed as -1 when there were 2 items in a folder and a folder item is dragged to the first position. Bug: 817475 Change-Id: Ie50583e947f9b9b6ba37a536ae327f935531d35e Reviewed-on: https://chromium-review.googlesource.com/941546Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#540196}
-
https://pdfium.googlesource.com/pdfium.git/+log/9002cd8cb5c9..198792b7e860 $ git log 9002cd8cb..198792b7e --date=short --no-merges --format='%ad %ae %s' 2018-03-01 thestig Fix some nits in CFX_DIBSource::CloneConvert(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I11dcd89b441046fc2187787900934d004e20603b Reviewed-on: https://chromium-review.googlesource.com/943245 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540195}
-
Greg Kerr authored
This CL establishes the correct ordering of the IPC which transmits the seatbelt profile to the child process. It must first map the FD into the child process, while launching the child process, and only send the profile once the child process is launched. Bug: 816824,801889 Change-Id: I453e307cc8f9a7416011ecc4eb101e702b11bca0 Reviewed-on: https://chromium-review.googlesource.com/939986Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#540194}
-
Fredrik Söderquist authored
This splits the various RemoveClientFromCache implementations into two parts: 1) removal of cached data from the resource, and 2) invalidation of the client. This avoids triggering invalidations as a side-effect of cache- invalidation, and separates concerns to help future refactorings. This also means that resources that perform no caching, or no per-client caching, need not override RemoveClientFromCache, but can use a default implementation. Since a kParentOnlyInvalidation argument to MarkClientForInvalidation is a no-op, it is removed in the relevant code-paths. LayoutSVGResourceContainer::MarkClientForInvalidation is made static to enable its use outside resource containers themselves. RemoveClientFromCache gets a new semantic in that it returns a bool indicating if anything was cached for the client (this is currently needed for invalidation of clients of filters.) Bug: 769774 Change-Id: I8deeaef8fdd46e6dcc171100e8d6394df483e232 Reviewed-on: https://chromium-review.googlesource.com/941332Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#540193}
-
Alex Clarke authored
Change-Id: I3bbbf936cce2d57dd918d64e8b406dd1b9f9c201 Reviewed-on: https://chromium-review.googlesource.com/943524 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540192}
-
Ramin Halavati authored
Network traffic annotation is added for credential update of Cloud Print Proxy Backend. Bug: 656607 Change-Id: I0dab745bfa4efae24d6091f99b2ac1090d230f33 Reviewed-on: https://chromium-review.googlesource.com/926011 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Scott Byer <scottbyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#540191}
-
Majid Valipour authored
Fix an issue in AnimationWorkletGlobalScope binding generation where EffectProxy was not being exposed in that scope. It also adds a test to verify all the interfaces that are exposed in the animation worklet global scope under origin trial. The test is relying on console.log and expectation file which is why I decided to not write it as a testharness based test. Bug: 811922 Change-Id: If13d3797f908d3f0a3945480e22c6e63cad9f76e Reviewed-on: https://chromium-review.googlesource.com/935702Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#540190}
-
Ian Clelland authored
The Feature-Policy HTTP header was not being properly replicated when set in a frame for which proxies already exist. This change fixes the problem by ensuring that the header is sent to RenderFrameProxy objects and properly updated there after a nagivation commits. Bug: 814887 Change-Id: I8dc5bcd3b0af28c36183d467ff5b886062dc41a3 Reviewed-on: https://chromium-review.googlesource.com/940422 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#540189}
-
Gauthier Ambard authored
This CL updates the the Search Icon used in the toolbar to focus the omnibox based on the default search engine for the application. Bug: 816843 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib40e76ed7e8837f8c1150252b9a169e822b93363 Reviewed-on: https://chromium-review.googlesource.com/943067 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#540188}
-
Ian Vollick authored
Adds a new "post scroll" state in which we extrapolate briefly before ending a scroll. Bug: 817173 Change-Id: I9ce00d4e958c7535e8ab42edf14a1261ab805956 Reviewed-on: https://chromium-review.googlesource.com/941365 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#540187}
-
Fady Samuel authored
Saman has been contributing high quality CLs to Viz for a long time. Bug: none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia1143cd79817c3eea0b589690ac822505481da5e Reviewed-on: https://chromium-review.googlesource.com/943593Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#540186}
-
Charles Harrison authored
Multiple PageHandlers can be created with isolating subframes. This breaks the devtools toggle which expects a single PageHandler for the main frame. This CL adds a bit to the PageHandler which classifies whether it is for the main frame. If it is not, then it cannot change the filtering toggle. Bug: 813197 Change-Id: I7698985822f5ee159399bd1d37884436c5278d0b Reviewed-on: https://chromium-review.googlesource.com/939602Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#540185}
-
Jialiu Lin authored
If enterprise policy specified the SafeBrowsingWhitelistDomains, Chrome should trust URLs in these domains. This CL covers: 1. Safe Browsing will not check for dangerous resources if their URLs match these domains (a.k.a no SB interstitial shown) Note that, we don't plan to skip SSL error checking even if domains are whitelisted. 2. Safe Browsing's password protection service will not check for password reuse if the page URL matches these domains. Changes in download protection, client phishing/malware detection, incident reporting, ads sampling will be in separate CLs. Bug: 811454 Change-Id: Ia439642ed1d68890ace4b8049aaec187158e2f5c Reviewed-on: https://chromium-review.googlesource.com/927531Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#540184}
-
Ken Rockot authored
This needed to be done at some point. The motivation here was to fix an extensions WebRequest API test with the Network Service enabled. This also plumbs through a signal so extensions API test JS code can detect whether Network Service is enabled. This is used to support conditional expectations in WebRequest tests since the test-only event behavior may differ slightly between Network Service and old networking. Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I009061f038eb3171721fe7645444695a77f3cfd3 Reviewed-on: https://chromium-review.googlesource.com/940447 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540183}
-
Jeremy Roman authored
A fairly direct copy of CoerceJavaScriptNullOrUndefinedToJavaValue. Bug: 794320 Change-Id: I6d057198262f589334d100800da63151280a38ce Reviewed-on: https://chromium-review.googlesource.com/941902Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540182}
-