- 29 May, 2019 22 commits
-
-
Danan S authored
This functionality will instead be implemented on the server side. Bug: 937995 Change-Id: I4c862a5d90f02a541cff3293b83cfb8f981cd069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627924Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664047}
-
Justin Cohen authored
ios/web quickly gets into a bad state when navigating while the currently committed url is a redirect URL. Similar to blocking navigation during session restoration, also block navigation during the redirect URL. This redirect happens very quickly, so don't update the UI -- rather ignore the tap. Not updating the UI prevents a flicker. Bug: 960326 Change-Id: Ibfe30f3341723bdc6cba122dccf21872ada2d072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630224 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664046}
-
Giovanni Ortuño Urquidi authored
Change-Id: I814de4b2943e9d6890bae260fab3e561a5f2ab23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632925Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#664045}
-
Sean Kau authored
Metric was set to expire in June. Extending metric into next year. Activity has not stabilized yet. Bug: chromium:967466 Change-Id: Ide6d07391fc919617bddc908442b9a8507d1dccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632418 Auto-Submit: Sean Kau <skau@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#664044}
-
David Benjamin authored
Sadly, enterprise usage of buggy middleware is still on the high side. Extend the metrics so we can continue to monitor this. Bug: 967483 Change-Id: I7b571b284315c2b0223b97e405d2e355313aac9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632779 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jonas Olsson authored
Media.Audio.Render.StreamBrokerDisconnectReason2 is still in use. This CL delays its expiry by another quarter. It also replaces me as owner of it. Bug: chromium:960094 Change-Id: Ic44d954b3fb156a12e5dd786d6cb06f7692a0da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631694 Auto-Submit: Jonas Olsson <jonasolsson@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Andrew Moylan authored
* Extend expiry on soon-to-be-expired histograms * Add expiry to all histograms per best practice * Add a second owner to all histograms per best practice The expiry date was chosen according to https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms where these histograms are "Actively in use now, useful for short [likely long] term". Bug: 967500 Test: none Change-Id: Idbfef38927d2856c99f2ad940b910695a7c4ab79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631852 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jeffrey Cohen authored
This reverts commit 8d639cb7. Reason for revert: failing test on macos10: http/tests/devtools/elements/highlight/highlight-node-vertical-rl.js Original change's description: > More physical coordinates in LayoutText and LayoutInline > > This further reduces back-and-forth flipping for LayoutNG, and makes it > clear that inspector highlight always uses physical coordinates. > > Change-Id: Iecec0c03c2a1a14d8ad2aeb29f61f3a912d5d670 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625876 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663927} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I1179b65f14a0e3f73454d1d271986e81acf7dbf2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633292Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664040}
-
rbpotter authored
It is possible that by changing various settings the length of the previewed document can change, which may invalidate the custom page range. Reset the custom page range to the full set of pages in the following 2 cases: (1) The custom page range was set to the full page range in JS, due to the user blurring an empty custom input. Note: reset even if the length change would not invalidate the value, so that leaving a custom input blank matches the behavior of selecting "All" in the dropdown. (2) The custom page range is set to the full page range, so it is clear that the user intends to print all the content, and the length of the previewed document decreases. Bug: 938214, 940386 Change-Id: Icdee3970c041f2d269c16967cc07a58514bdf811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629045Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/698a4380c296..d524d32f3c7c git log 698a4380c296..d524d32f3c7c --date=short --no-merges --format='%ad %ae %s' 2019-05-28 tsepez@chromium.org Avoid circular includes between CPDF_Document and CPDF_LinkList Created with: gclient setdep -r src/third_party/pdfium@d524d32f3c7c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: If7fe08992b68fbb9189d75c0a57eaa21f1f9ed2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633249Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664038}
-
Eric Aleshire authored
Also adds them to a test to confirm they execute. There aren't enough methods landed to be able to check for correctness yet - those will come in a follow-up. Change-Id: Id1ccdaeebebbea2c7f6e299ef192244c75f209f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628273 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5a06fa466186..f051812343eb git log 5a06fa466186..f051812343eb --date=short --no-merges --format='%ad %ae %s' 2019-05-28 zoddicus@users.noreply.github.com Add WebGPU specific fuzzer for validation (#2628) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f051812343eb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Id9ecea0cb29444249634ca3a13783824f13d09bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632805Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/90cb260644cd..cee3dffa8f79 git log 90cb260644cd..cee3dffa8f79 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bclayton@google.com LLVMReactor: Mutex calls to llvm::orc::IRCompileLayer. 2019-05-28 bclayton@google.com Reactor: Add UInt4 constructors taking UInt Created with: gclient setdep -r src/third_party/swiftshader@cee3dffa8f79 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133127573 TBR=swiftshader-team+autoroll@google.com Change-Id: I7c91d395a1c9fefc80c8f9902f78a8cf2b70ad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632946Reviewed-by:
-
Jeremy Chinsen authored
TabModalConfirmDialog takes ownership of the TabModalConfirmDialogDelegate* passed in, but its comment did not convey this. Changing the parameter to a unique_ptr expresses this explicitly. Bug: 961772 Change-Id: Id7f4242a0797d3d49237b833b0bd6af4c146dd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626502Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#664034}
-
Charles Zhao authored
Currently, when a tab is discarded, it has 0 ukm_source_id in TabActivityWatcher; which eventually leads to no logging. Fix: assign the old ukm_source_id to the new WebContentsData when replace is called. Bug: 967558 Change-Id: Ic989baafc6850c47d8d53c14bc775a2475e1f12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631914Reviewed-by:François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664033}
-
Kyle Horimoto authored
The issue was trigged by a JavaScript error in getDialogTitle_(). This function attempts to evaluate |this.managedProperties_.Name| without checking whether |this.managedProperties_| is set. I added an early return to prevent against this case. Bug: 967807 Change-Id: I14544a6185f255d73e405845446efb1fc07bf4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633213 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#664032}
-
Steven Bennetts authored
This also eliminates a NetworkHandler dependency in ash/system/network. Bug: 919691 Change-Id: Ie315a3a6589cd3f68a980ec17db9db8c83dba859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626684Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#664031}
-
Min Qin authored
Currently for each download stream, the data read from the network was immediately written to the disk. This CL allows each SourceStream to read some data before the file write offset for content validation purpose. And data will only be written after all the initial validation data are consumed. A new field called starting_file_write_offset_ is added to SourceStream to identify this checkpoint for file validation. BUG=965215 Change-Id: Ia46de1a588bc0c2fb4e6eb19e62ef794d706ad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625461 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664030}
-
Torne (Richard Coles) authored
Convert more cases where C++ code iterates over Java object arrays to use range-based for with the new helper class introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1283836 Also remove ConvertJStringArrayToString16Array from chrome_browser_provider.cc, as there is already a helper for this in jni_array.h. Change-Id: Ifb8ecf25dbde8d1fab6549df22153b9bf398b4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588961 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#664029}
-
Istiaque Ahmed authored
We can do this without any string copy, so use StringPiece variant from GURL. This is interesting because every extension resource fetch goes through this method. Bug: None Change-Id: Ief332c09295b1087f64721e44f026eccc4a49497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631938Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664028}
-
Piotr Bialecki authored
Bug: 966607 Change-Id: I3c2719ba8a3128b4c261a916a604626b82c1c1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632916Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#664027}
-
Edin Kadric authored
Bug: 965601 Change-Id: Ia212e7d969d431f5ece9e3da0702c516478fdd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628835Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#664026}
-
- 28 May, 2019 18 commits
-
-
Jinsuk Kim authored
Arrow widget used for history navigation UI was previously inherited from ChipView. This CL introduced its own UI widget class that simplifies APIs and has the right style for the design. It will also be used as a base class for other elements in the long term design. Also contains: - centered the arrow in the round icon - verified the style in dark mode - icon color is tinted by default to match that of the text - long text is ellipsized Bug: 966259 Change-Id: I5e25ded8b72886042b3ab05fe1d5254c03191b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626911 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#664025}
-
danakj authored
This makes an android_browsertests target that compiles but does not do anything too useful yet. The target has a dependency on a new test_support_ui_android target that mirrors the test_support_ui target desktop browser_tests depend on which will include in the future any BrowserTestBase subclasses. It also pulls in the //chrome/browser and //content/public/browser dependencies for tests. We do a bunch of cleanup in the desktop browser_tests target since it is no longer being built for android. 1) The //chrome/browser/test_support_ui target can be scoped entirely to non-android, and some of its deps are cleaned up: blink_headers and gtest are not used by that target and don't need to be there. 2) We merge the `sources`, `deps`, `data_deps` and `data` variables in the browser_tests target up into a single assignment since they do not need to split between shared-with-android and not-shared-with-android anymore. 3) I noticed we had both chromeos-and-nacl and nacl-and-chromeos sections, so merged them together into the latter. 4) Moved the blink_headers dependency to the browser_tests target where it is used by render_view_browsertest.cc. Removed it from //chrome/test:test_support_ui as well, as it was not used there either. R=sky@chromium.org Bug: 961849 Change-Id: I18262595db5c1713cb2d830894798cc82b90c200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627946 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Theresa authored
Add an AppMenuBlocker interface with a simple #canShowAppMenu method. Split ChromeActivity#shouldShowAppMenu implementation between activity class and RootUiCoordinator, moving UI-related checks into RootUiCoordinator#canShowAppMenu. Register both ChromeActivity and RootUiCoordinator as AppMenuBlocker's. BUG=956260 Change-Id: Ic0889d349287e687dbf239e5487b51cc3e45ac90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628231 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#664023}
-
Jordy Greenblatt authored
This CL just creates an infrastructure based on cr_settings_browsertest.js and runs the existing test of the settings-smb-shares-page element on the newly migrated file chrome/browser/resources/settings/chromeos/os_downloads_page/smb_shares_page.js. Bug: 966595 Change-Id: I5af3a28877a74474e3b715559e4a513d07c9119a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628014 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#664022}
-
Patrick Noland authored
Bug: 966176 Change-Id: Iee7c863bae5292fd576ad5b04d77060087c26364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626019Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#664021}
-
Sorin Jianu authored
BUG=967689 Change-Id: I8547f5c8b047dc1ddffc99fd576eb67bf817e22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630519Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0499a4436c35..86837544cd02 Created with: gclient setdep -r src-internal@86837544cd02 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I0fe7ece06c5449636847de905f2313784b569350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632308Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664019}
-
Aaron Colwell authored
Hosted apps no longer need to be a special case that does not require a dedicated process. This change removes the special case logic and isolates all extensions and all hosted apps in their own processes. Change-Id: Id6322038fcf5bef91775cec20ea61cf7a3f6b458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628334Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Ben Kelly authored
Remove the ServiceWorkerForegroundPriority feature since it has been successfully launched to 100% in Chrome 74. Bug: 928904 Change-Id: I64059e14b9eed99763db842fef248b5813b082de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633049Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#664017}
-
Justin Cohen authored
Currently page load count is done via the call to StabilityMetricsHelper::LogLoadStarted in WebStateDidStartLoading. DidStartLoading was never an ideal location, and the move to WKBasedNavigationManager introduces even more complexity. Instead, move this call to WebStateDidStartNavigation. Rollout will start behind a feature flag that will be paired with the SlimNav experiment and control groups. Bug: 786547 Change-Id: I1100bd0cca68fe511b992c1df67c449a6739fc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632570Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664016}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7b33124672f..5db62d36c9b5 git log a7b33124672f..5db62d36c9b5 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 hypan@google.com Set the fyi flag to False for pixel2-perf and pixel2_webview-perf Created with: gclient setdep -r src/third_party/catapult@5db62d36c9b5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867592 TBR=zhanliang@google.com Change-Id: If908b507ad60043e5614b1bcdc2c2e160944ccfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631359Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664015}
-
Morten Stenshorne authored
Normally, an RT element is somewhere inside a RUBY element. We already force legacy layout for the entire subtree established by RUBY elements, but we need to do the same for RT elements, in case they don't have a RUBY ancestor. RT elements create a special legacy layout object, without necessarily establishing a new formatting context. Bug: 967255 Change-Id: I35857fdeced55ee10a385b58b117f28007bd7791 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632261 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#664014}
-
Lorne Mitchell authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1613921/, which was reverted (Bug=966547) because third_party/blink/renderer/devtools/front_end/langpacks/devtools_ui_strings.grd was being picked up by Google's internal localization pipeline. Bug=941561 Change-Id: I9a97e16e367716189d34944b76605c9321d47092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627921Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#664013}
-
Ryan Sleevi authored
Chromium has had experimental support for the CT-over-DNS draft at https://github.com/google/certificate-transparency-rfcs/blob/master/dns/draft-ct-over-dns.md for some time. In support of this experiment, it's received STHes from Google using the Component Updater, and when a fresh STH is received, used that to trigger checks for any SCTs it may have from that Log, to ensure the Log is well-behaving. Due to the use of TXT records, this code was only implemented using our built-in resolver code, and only on platforms where CT was enabled; effectively limiting it to !Windows and !Mobile. Many of the privacy assumptions around this code were conceived of prior to, and independent of, work such as DoH or ESNI, and may not hold the same. Further, the limited experiments performed suggest abnormally high failure rates, which will require significant time to dig into. As such, we're putting a hold on the experiment to focus on other higher priority tasks. Due to the complexity this introduces for reasoning about DoH and ESNI, and with a mind to binary size, rather than leave the code in place, this CL unwinds it all, as hermetically as possible, so that it can be revisited in the future. Bug: 506227 Change-Id: I1b477b34e4445bc06cc4cef95b92909e74d28327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582766Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to production logic, mostly a no-change refactor in tests. This adds the AwActivityTestRule.addJavascriptInterfaceOnUiThread() helper method, which avoids some need for posting to UI thread manually in tests. This replaces all uses of bare addJavascriptInterface(), most of which are mechanical (NOOP) replacements. The non-trivial replacement is AwContentsTest, which had multiple operations in the same UI-thread section. Now we have multiple posts to UI thread, which is slower, but should be more readable. This is a follow-up CL to the test added to AwNetworkConfigurationTest. Bug: 960165 Test: run_webview_instrumentation_test_apk Change-Id: I1ad88c0cb37f288c7a3b43711ccaa204c02e7590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617649 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664011}
-
Caitlin Fischer authored
Bug: 966830 Change-Id: I738b691847869439dd38df6d6fa7595e87af9688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628042 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#664010}
-
Thanh Nguyen authored
Proto with the features and related information to be logged for Chrome OS Search and Ranking project. Bug: 959705 Change-Id: I047dfc312d37862800fb3b48e5f30a98e85da254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626837 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664009}
-
Nate Fischer authored
No change to production logic. This adds a regression test for http://crbug.com/960165. This loads a page and ensures that WebView correctly respects the Access-Control-Allow-Origin header, by using the JavaScript fetch() API. Bug: 960165 Test: run_webview_instrumentation_test_apk --enable-features=NetworkService,NetworkServiceInProcess -f AwNetworkConfigurationTest#testAccessControlAllowOriginHeader Change-Id: I74b6e789bb47a5ba8d70e1416bf963b0afbcb2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618160 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
