Commits · 7e2df8f479800f590de024526c0c0719598c4ce9 · eriksson monteiro / tangled

06 Sep, 2013 40 commits

Set the WindowId of the SessionTabHelper · 7e2df8f4

dtrainor@chromium.org authored Sep 06, 2013

- When initializing the WebContents for Android pull the
WindowId from the TabModel and push it to the SessionTabHelper.

BUG=277135
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23792002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221798 0039d316-1c4b-4281-b951-d872f2087c98

7e2df8f4

Update .DEPS.git · cc52dbc4

chrome-admin@google.com authored Sep 06, 2013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221796 0039d316-1c4b-4281-b951-d872f2087c98

cc52dbc4

Add interface for DesktopMediaPickerModel · b4d1748c

dcaiafa@chromium.org authored Sep 06, 2013

This CL adds an interface for DesktopMediaPickerModel
(DesktopMediaPickerModelInterface). It allows the model to be
faked/mocked/stubbed in unittests.

BUG=237907

Review URL: https://chromiumcodereview.appspot.com/23447012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221795 0039d316-1c4b-4281-b951-d872f2087c98

b4d1748c

Revert 220237 "Revert 220228 "FFmpeg roll for M31."" · 3a7b3443

dalecurtis@google.com authored Sep 06, 2013

> Revert 220228 "FFmpeg roll for M31."
> 
> Causing compile failure on "Google Chrome ChromeOS"
> http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/57680
> 
> > FFmpeg roll for M31.
> > 
> > BUG=none
> > TEST=asan media_unittests, ffmpeg_regression_tests + manual.
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23172019
> 
> TBR=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/23753002

Builder has been upgraded to handle gcc 4.6+ constructurs.

TBR=hashimoto@chromium.org
BUG=263385,281764

Review URL: https://codereview.chromium.org/23703009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221794 0039d316-1c4b-4281-b951-d872f2087c98

3a7b3443

Revert 221580 "Make AppShimHostManager a RefCountedThreadSafe." · 8a16e9b9

rsimha@chromium.org authored Sep 06, 2013

Reason for revert: Use-after-free heap errors caught by asan.
See bug 286483.

> Make AppShimHostManager a RefCountedThreadSafe.
> 
> This prevents a crash when Chrome shuts down immediately and 
> AppShimHostManager is destructed before InitOnFileThread is run.
> Note this means AppShimHostManager can stay around longer than
> BrowserProcessPlatformPart during initialization.
> 
> Review URL: https://chromiumcodereview.appspot.com/20065004

BUG=286483,242941
TBR=jackhou@chromium.org

Review URL: https://codereview.chromium.org/24052002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221793 0039d316-1c4b-4281-b951-d872f2087c98

8a16e9b9

Close Views collected cookies dialog on interstitial WebUI · e460a4dc

wittman@chromium.org authored Sep 06, 2013

Configure the collected cookies dialog to be closed when interstital
WebUI is displayed (e.g. for SSL warnings prior to page load).

BUG=240575
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23432007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221792 0039d316-1c4b-4281-b951-d872f2087c98

e460a4dc

Nukes outdated comment · 94fc9528

sky@chromium.org authored Sep 06, 2013

Comment is not applicable anymore.

BUG=none
TEST=none
R=pkotwicz@chromium.org
TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/24050002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221791 0039d316-1c4b-4281-b951-d872f2087c98

94fc9528

Use a weak pointer to determine if resizer was destroyed by nested Drag calls. · 1e87e370

flackr@chromium.org authored Sep 06, 2013

BUG=None
TEST=*ResizerTest.*

Review URL: https://chromiumcodereview.appspot.com/23645008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221790 0039d316-1c4b-4281-b951-d872f2087c98

1e87e370

Set position: absolute on NTP thumbnails · d9199870

mathp@chromium.org authored Sep 06, 2013

This fixes a bug where, when using two thumbnails in the same iframe, they would be reordered if their visibility changed. This would only happen on the second and further NTPs, perhaps on relayout by Chrome.

This changes it so that they are superposed, which is how it should have been all along. Putting position: absolute will make both anchor on body.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23619019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221789 0039d316-1c4b-4281-b951-d872f2087c98

d9199870

Add a new parameter |latency| to PPB_Audio. · 6b151126

yzshen@chromium.org authored Sep 06, 2013

This CL updates the version of PPB_Audio and PPB_Audio_Callback.

BUG=240900
TEST=updated test_audio.{h,cc}

Review URL: https://chromiumcodereview.appspot.com/22320004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221788 0039d316-1c4b-4281-b951-d872f2087c98

6b151126

Fixed CSS to hide AppsV1-only DOM. · 1151b025

jamiewalch@chromium.org authored Sep 06, 2013

https://chromiumcodereview.appspot.com/22006002/ moved the apps-v2 class from
the <body> to the <html> node, but did not update the CSS.

BUG=263090
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/23899005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221787 0039d316-1c4b-4281-b951-d872f2087c98

1151b025

Create mojo directory. · 97e0fc08

aa@chromium.org authored Sep 06, 2013

R=darin@chromium.org

Review URL: https://codereview.chromium.org/23716005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221786 0039d316-1c4b-4281-b951-d872f2087c98

97e0fc08

Clean up NetworkState members · bc1cd955

stevenjb@chromium.org authored Sep 06, 2013

This includes updating the (already asynchronous) calls in MobileActivator and MobileSetupUI to retrieve the complete set of service properties so that we do not need to cache some infrequently used properties.

BUG=252553
For test files:
TBR=armansito@chromium.org, pneubeck@chromium.org

Review URL: https://codereview.chromium.org/23441025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221785 0039d316-1c4b-4281-b951-d872f2087c98

bc1cd955

Re-enables three WebRTC unit tests in content. · aaf48c8b

henrika@chromium.org authored Sep 06, 2013

It looks like some disabled unit tests could easily be enabled again just by extending the MockMediaInternals class.

BUG=23533039
TEST=content_unittests

Review URL: https://chromiumcodereview.appspot.com/23533039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221784 0039d316-1c4b-4281-b951-d872f2087c98

aaf48c8b

Move DragDownloadItem() implementation to download_item_drag.cc · f53194f2

tfarina@chromium.org authored Sep 06, 2013

BUG=None
TEST=none, no functional change
R=asanka@chromium.org, erg@chromium.org

Review URL: https://codereview.chromium.org/23522023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221783 0039d316-1c4b-4281-b951-d872f2087c98

f53194f2

Added discrepancy and inverse RMS frame time to smoothness benchmark. · 23998ad7

ernstm@chromium.org authored Sep 06, 2013

Discrepancy is a measure for the largest area of jank in a series of time stamps.

Inverse RMS frame time is a generalization of frames/second that penalizes longer frame times. We can switch to the inverse of another generalized mean with a higher exponent if we want to penalize long frame times even more.

R=nduca@chromium.org, tonyg@chromium.org, klobag@chromium.org, vangelis@chromium.org
BUG=280627, 281544

Review URL: https://chromiumcodereview.appspot.com/23506030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221782 0039d316-1c4b-4281-b951-d872f2087c98

23998ad7

Fix MediaSourcePlayer unittests and minor code cleanup. · 9f282b48

acolwell@chromium.org authored Sep 06, 2013

Fixes a few tests were broken by minor changes in behavior 
introduced in http://crrev.com/220164.

BUG=281730
TEST=MediaSourcePlayerTest.StartTimeTicksResetAfterDecoderUnderruns
     and MediaSourcePlayerTest.ReadFromDemuxerAfterSeek pass now.

Review URL: https://chromiumcodereview.appspot.com/23620012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221781 0039d316-1c4b-4281-b951-d872f2087c98

9f282b48

Revert 221776 "RenderTextWin: Break runs between any two charact..." · 7c268def

rouslan@chromium.org authored Sep 06, 2013

Compile error:

render_text_unittest.cc(1662) :error C2039: 'Range' : is not a member of 'ui'

Revision 221776 change collided with revision 221762, which moved Range
from ui to gfx namespace.

> RenderTextWin: Break runs between any two characters that are not in the same code block
> 
> BUG=278913
> 
> Review URL: https://chromiumcodereview.appspot.com/23522018

TBR=ckocagil@chromium.org

Review URL: https://codereview.chromium.org/23707025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221780 0039d316-1c4b-4281-b951-d872f2087c98

7c268def

[NaCl SDK] Screen capture extension for use with SDK visual testing. · 081b5202

binji@chromium.org authored Sep 06, 2013

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/23458018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221777 0039d316-1c4b-4281-b951-d872f2087c98

081b5202

RenderTextWin: Break runs between any two characters that are not in the same code block · 5b854b8f

ckocagil@chromium.org authored Sep 06, 2013

BUG=278913

Review URL: https://chromiumcodereview.appspot.com/23522018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221776 0039d316-1c4b-4281-b951-d872f2087c98

5b854b8f

Generate passwords only for the forms that autofill server classifies one of... · 375564a1

zysxqn@google.com authored Sep 06, 2013

Generate passwords only for the forms that autofill server classifies one of its fields as ACCOUNT_CREATION_PASSWORD.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23432002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221773 0039d316-1c4b-4281-b951-d872f2087c98

375564a1

Use FavoriteList in ClientCertResolver instead of NetworkList · a15f140a

pneubeck@chromium.org authored Sep 06, 2013

This is required for EthernetEAP, because that one will not show up in the network list of NetworkStateHandler.

BUG=126870

Review URL: https://chromiumcodereview.appspot.com/23902011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221772 0039d316-1c4b-4281-b951-d872f2087c98

a15f140a

aura: Don't Show() a newly created RenderWidgetHostView() for a hidden RenderWidgetHost. · c89d3dff

sadrul@chromium.org authored Sep 06, 2013

BUG=284817
R=creis@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/23448003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221771 0039d316-1c4b-4281-b951-d872f2087c98

c89d3dff

[Webapps] Add switch to about:flags · 9af61ee9

dfalcantara@chromium.org authored Sep 06, 2013

Adds a flag to about:flags to make the "Add to Homescreen"
menu item visible.  Requires a downstream patch to actually put
the menu item in.

BUG=286156

Review URL: https://chromiumcodereview.appspot.com/23676005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221770 0039d316-1c4b-4281-b951-d872f2087c98

9af61ee9

Update find_unused_resources.py to ignore third party resources. · 235ea291

newt@chromium.org authored Sep 06, 2013

find_unused_resources.py thinks that resources defined in third party
libraries are all unused. This updates the script to ignore those
resources.

BUG=149661
R=bulach@chromium.org, cjhopman@chromium.org

Review URL: https://codereview.chromium.org/23591017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221769 0039d316-1c4b-4281-b951-d872f2087c98

235ea291

Fix typing of accented characters on the VK in Google Docs. · b245e75b

kevers@chromium.org authored Sep 06, 2013

BUG=257093, 257098

Review URL: https://chromiumcodereview.appspot.com/23536030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221768 0039d316-1c4b-4281-b951-d872f2087c98

b245e75b

Thread-local trace-event buffers · 07b87731

wangxianzhu@chromium.org authored Sep 06, 2013

Previously we use a central trace-event buffer to store trace events
from all threads, which needs a lock. Measurement showed that on
Android the lock contributes over 50% of the total overhead of
trace event.

Use thread-local trace-event buffers so that in most times trace
events can be handled lock-free.

TraceLog::Flush() now may asynchronously call the callback.

TODO: Now for a message loop running a blocking task, async flush
doesn't work. The async flush will timeout and finish without
collecting the last batch of such thread if any.

On Nexus 4 this patch can reduce the average overhead of trace_event
from 15~20us to about 5~8us for a busy app. Note the numbers are not
very accurate because
- the time tick seems 30us on Android. The average number may be just
a result of increased percentage of trace events whose overhead < 30us.
- there are differences in the measurement method of the overhead
because of the change of the code structure.

BUG=264667
TEST=Updated existing tests: TraceEventTestFixture.DataCapturedOnThread
and TraceEventTestFixture.DataCapturedManyThreads. Existing unit/browser
tests using trace_event should still pass.
R=nduca, dsinclair
TBR=phajdan.jr (for base/test/trace_event_analyzer_unittest.cc)

Review URL: https://chromiumcodereview.appspot.com/22962004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221766 0039d316-1c4b-4281-b951-d872f2087c98

07b87731

Switch to doing user-resizing via system for panels on Mac · 11699976

jianli@chromium.org authored Sep 06, 2013

We used to track and handle user-resizing by ourselves. This brings up a few problems and makes the user-resizing hard to use on Mac. For example, the user-resizing could not be triggered outside or on the edge. Switching to doing it via system solve all these problems.

Also removed EnableResizeByMouse which is not really used in our code.

BUG=282652,282657
TEST=manual test by user-resizing panels

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221651

Review URL: https://chromiumcodereview.appspot.com/23918002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221765 0039d316-1c4b-4281-b951-d872f2087c98

11699976

Don't create PepperMessageFilter for renderer processes. · ce5effe4

sergeyu@chromium.org authored Sep 06, 2013

PepperMessageFilter is used for PPB_NetworkMonitor and
PPB_X509Certificate. Neither of these APIs is supported for
in-process plugins.

TBR=sky@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/23997002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221764 0039d316-1c4b-4281-b951-d872f2087c98

ce5effe4

Support Page.getNavigationHistory and Page.navigateToHistoryEntry in RendererOverridesHandler · 99022276

kaznacheev@chromium.org authored Sep 06, 2013

BUG=285169

Review URL: https://chromiumcodereview.appspot.com/23943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221763 0039d316-1c4b-4281-b951-d872f2087c98

99022276

Move Range code to gfx. · db4fc1e2

ben@chromium.org authored Sep 06, 2013

Part of a set of changes to fix the circular dependency between ui/base and ui/gfx, with the aim of making gfx its own component.

R=jam@chromium.org, jschuh@chromium.org, rsesek@chromium.org
BUG=285385,103304

Review URL: https://codereview.chromium.org/24012002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221762 0039d316-1c4b-4281-b951-d872f2087c98

db4fc1e2

Update .DEPS.git · 02ee41de

chrome-admin@google.com authored Sep 06, 2013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221761 0039d316-1c4b-4281-b951-d872f2087c98

02ee41de

Update linux_syscall_support.h (LSS) and Breakpad revisions in DEPS · b974edb2

mseaborn@chromium.org authored Sep 06, 2013

The LSS update changes the prctl() wrapper, which requires pulling in
an updated Breakpad version too.

BUG=none
TEST=trybots

Review URL: https://chromiumcodereview.appspot.com/23869004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221760 0039d316-1c4b-4281-b951-d872f2087c98

b974edb2

Update .DEPS.git · b857a455

chrome-admin@google.com authored Sep 06, 2013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221759 0039d316-1c4b-4281-b951-d872f2087c98

b857a455

Update .DEPS.git · 29c00e2a

chrome-admin@google.com authored Sep 06, 2013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221757 0039d316-1c4b-4281-b951-d872f2087c98

29c00e2a

Roll reference builds to r221697. · da72b40b

tonyg@chromium.org authored Sep 06, 2013

This is intended to fix flaky crashes in the current ref builds on the startup
and blink_perf measurements.

BUG=282098,278582,273988
TBR=xusydoc@chromium.org

Review URL: https://codereview.chromium.org/24047002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221756 0039d316-1c4b-4281-b951-d872f2087c98

da72b40b

[rAC, OSX] Namespaced constants. · 3e034359

groby@chromium.org authored Sep 06, 2013

Keep autofill dialog related constants in named namespace.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23546007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221755 0039d316-1c4b-4281-b951-d872f2087c98

3e034359

Replace FileResource::set_labels with mutable_labels · 32e29a29

tzik@chromium.org authored Sep 06, 2013

Review URL: https://chromiumcodereview.appspot.com/23627008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221754 0039d316-1c4b-4281-b951-d872f2087c98

32e29a29

Convert a bunch of resource IPCs to be control messages. They didn't need to be routed. · f465319a

jam@chromium.org authored Sep 06, 2013

BUG=286074
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/23583039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221751 0039d316-1c4b-4281-b951-d872f2087c98

f465319a

Add a DCHECK to RenderWidgetHost::FromID to ensure that it's only called on the UI thread. · b926d6a8

jam@chromium.org authored Sep 06, 2013

R=avi@chromium.org

Review URL: https://codereview.chromium.org/23471009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221750 0039d316-1c4b-4281-b951-d872f2087c98

b926d6a8