- 25 Jun, 2020 40 commits
-
-
Sahel Sharify authored
This cl adds an UMA use counter to count the number of cases where Chrome crawls to refetch the missing icon of installed payment apps. The icon refetch logic will be removed once this count drops to zero. Bug: 1069010 Change-Id: I59260337c2743bff3c1197f2369f78f083962f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265137 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#782688}
-
Ella Ge authored
This reverts commit 5cd3140c. Reason for revert: test failing on win7 bot https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/104437 Original change's description: > Use wheelTick in forms/resources/common-wheel-event.js > > After we finish the scroll unification, the scrolls happens mainly on > the compositor thread, and the scroll code in the main thread will be > removed. eventSender sends the scroll events to main thread, so it > would not work after the scroll unification. This CL we should replace > eventSender.mouseScrollBy with wheelTick which uses > gpuBenchmarking.smoothScrollByXY in > forms/resources/common-wheel-event.js. > > Bug: 1047176 > Change-Id: I7416727dfcfbe2d88a283907ee132c838952747e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171955 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782599} TBR=ellyjones@chromium.org,avi@chromium.org,sadrul@chromium.org,sky@chromium.org,ccameron@chromium.org,bokan@chromium.org,lanwei@chromium.org Change-Id: I5348ccf4d638c0c4be96ac111d41a6f45e772a32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268226Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#782687}
-
Haiyang Pan authored
And change mb config for "Network Service Linux" to release_bot It does not seems right for a CI builder to use a trybot config Bug: 1099088 Change-Id: Iab1c9cb742a3ccd5334f2927b5d376064069fa3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267843Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#782686}
-
Connie Wan authored
This is very similar to crrev.com/c/2003922, but accommodating the ctrl+shift+pgup/pgdown shortcut on Linux. Bug: 1086123 Change-Id: Idb9c933a823518aae8eda92db8045cc1b6bed64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267432Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782685}
-
Devlin Cronin authored
There was an integer division error in reporting one of our percentages. Fix it, and add a test to cover the case. Bug: None Change-Id: Ibc1993852644c86fdfe356862cbb8e5bc51644dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265420Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782684}
-
Alexander Surkov authored
DumpAccTree testing: add helper macroses to report failures when parsing parameters for parameterized attributes Bug: 1095619 Change-Id: Icf80cd3b96bc790150d91774a5843817751194fc AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260395 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782683}
-
Hans Wennborg authored
This is a reland of f85481f8 Fixes since the previous commit: https://chrome-internal-review.googlesource.com/c/chrome/deps/amd/+/3133484 https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3133487 https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3135083 https://chromium-review.googlesource.com/c/chromium/src/+/2264371 Original change's description: > [base] Stop including check.h, notreached.h, etc. in logging.h > > The CHECK, CHECK_EQ etc., and NOTREACHED macros have moved out > of logging.h into separate, much cheaper to include, headers. > > Now that the code has been updated to use the new headers, and > to not rergess on that, stop including them in logging.h. > > Bug: 1031540 > Change-Id: Idfa891b991cbca1dfef93630c0f37b1b022f99df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264413 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781970} TBR=thakis Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: 1031540 Change-Id: Ie889e031d229745f93363c7bb2605c4f65591f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264297 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782682}
-
John Abd-El-Malek authored
Bug: 1096670 Change-Id: I5780bd39e44b914369047bb054dc191f16a979ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264792 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
David Bertoni authored
There is code to conditionally enable the UpdateWindowShowState test. This cl moves the #ifdef block to the location of the function, rather than the beginning of the file. Change-Id: Ifae53e01f262e747f84292a32599bfd39de5eaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268260 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782680}
-
Natalie Chouinard authored
Additional downstream FeedbackSourceProviders were removed in https://crrev.com/i/3119108, so this now removes redundant classes and methods. Bug: 1098518 Change-Id: I4c3cedadc9538126c45a4255f20427c1452f088e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261615 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782679}
-
Donn Denman authored
Updates the UX for showing the in product help balloon for promoting a longpress when switching away from tap. When the user taps and we show the balloon we want to also highlight the word tapped. BUG=1096323 Change-Id: Ic048c4b5b410fb4389c60c0a5437dab3f493c45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266018 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#782678}
-
rajendrant authored
Infobar should be shown for users who enabled LiteMode before M85 release date. The user likely saw the old help center article (or privacy whitepaper), and does not know about https image compression. For users who enabled LiteMode after M85, infobar need not be shown. Bug: 1090843 Change-Id: I6df372d34d5e4309f66e9f7eb5f8467f6c972d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262121 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#782677}
-
Leonard Grey authored
On Mac, this was replaced by the email share service in the share menu. It doesn't appear to have ever been hooked up on other platforms. Bug: 1098822 Change-Id: Ibb3c30c0c32d98e7c46f04e80e01c05e145b5ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264583Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#782676}
-
Ella Ge authored
This reverts commit c858e90e. Reason for revert: compile failure on win64 bot https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/3761?blamelist=1#blamelist-tab Original change's description: > [Nearby Share] Add NearbyShareClient, NearbyShareClientImpl > > Implement an HTTP client to make calls to the OnePlatform server > defined here: > https://source.corp.google.com/piper///depot/google3/google/internal/location/nearby/sharing/v1/service.proto > > Bug: b/154863110 > Change-Id: I0a3b06d067e7f06a0fc933f2cf69aac4ca20036f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229299 > Reviewed-by: Josh Nohle <nohle@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Curt Clemens <cclem@google.com> > Cr-Commit-Position: refs/heads/master@{#782646} TBR=nohle@chromium.org,vecore@google.com,cclem@google.com Change-Id: I55c1fd117a81bda2135a3f0dcb56ef2ee88f4524 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/154863110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268205Reviewed-by:
-
Zhongyi Shi authored
Non-functional change for measurement. Follow up changes will add functionality protected by flags. Add QuicConnectivityMonitor to track QUIC sessions that are degrading on the default network. 1.When NetworkHandle is supported, QuicStreamFactory is registered as NetworkObserver and picks up default network change with the associated NetworkHandle. Note IPAddressChange notification in this case is ignored by QuicConnectivityMonitor. Case 1: if connection migration is supported, QUIC session may use different network, the active network being used is tracked by the bound network bound by the last socket. Case 2: otherwise, QUIC session always sticks on the |default_network_| passed in upon construction. 2.When NetworkHandle is not supported, QuicStreamFactory is not registered as NetworkObserver. Default network changes are notified via IPAddressChange which is spurious though. a. Connection Migration is never supported in this case. The QUIC session will either goaway (Cronet on iOS) or killed or stay until the OSS kills the underlying socket. b. Reporting from the session is immediately disabled when IP address changes, as there is no way to track if the session stays on the default network or not. For simplicity, reporting for go_away_on_path_degrading is disabled. Bug: 1090532 Change-Id: I4649ddef72249d64b9a2faa7070efaef0c383ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247130 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#782674}
-
David Bertoni authored
ExtensionApiTabTest.TabOpener was disabled for flakiness on Windows. It passed 3000 iterations on the Windows bots with no flakes. Bug: 238667 Change-Id: I1838fe53f0c3e14c3524793610f8d5f9fbb6c422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264029Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782673}
-
Domenic Denicola authored
See https://github.com/WICG/origin-isolation/issues/24 and https://github.com/WICG/origin-isolation/pull/30 for background, and https://github.com/whatwg/html/pull/5545 for the specification. Failing test expectations include: - We implement (3) from https://github.com/WICG/origin-isolation/issues/24 instead of (2) for now, so we fail getter-sandboxed-iframe. Tracking at https://crbug.com/1095653. - The initial about:blank, as well as removed iframes, are not properly returning true, so about-blank and removing-iframes are failing. Also tracking at https://crbug.com/1095653. - data: URLs are not [SecureContext] in Chromium (https://crbug.com/1095656) so getter-data-url fails. Note that per ongoing discussion in https://github.com/WICG/origin-isolation/issues/31 the naming of this API, as well as its edge-case behavior (e.g. for sandboxed iframes) will likely change. Bug: 1042415 Change-Id: I20c2d3e3fec7a5c0f1d12c386999c32fe27b6a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243994Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#782672}
-
Takumi Fujimoto authored
Log route creation results in CastMediaRouteProvider and CastActivityManager using media_router::LoggerImpl. Add two methods to the MediaRouter Mojo interface. GetLogger() is used by components like CastMediaRouteProvider to obtain a Mojo pointer to the logger. GetLogsAsString() is used by the component extension to get logs to attach to feedback reports. LoggerImpl was added by crrev.com/c/2079535. Bug: 687380, b/154273698 Change-Id: Ifbfbd512783b49d3bfe1c4a894709380b10ebd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259493 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
-
Carlos Frias authored
Updating the feature flag expiration milestone to be 88 instead of 85. Shortcuts Menu and Run on OS Login features are still in development. Change-Id: I0dc129278bac083708afccd1f566db353fa8ca22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265395Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782670}
-
Yi Gu authored
This test has been really flaky recently therefore marking it so. NOTRY=TRUE Bug: 1080609 Change-Id: I79615022391579c5c17f6eb7e3ff416d71f902f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268203 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Miriam Zimmerman authored
Per chrome inclusive language efforts, this CL replaces uses of the term "whitelist" with more-descriptive alternatives. BUG=1099354 TEST=CQ Change-Id: Ie7c71d3048f4123fddbad5813eeaf0e84de6fa62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266962Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#782668}
-
David Bokan authored
ForceLoadAtTop is a policy which pages can apply that blocks any kind of scroll-on-load behavior including: fragments, text-fragments, history scroll restoration. However, we had a bug where by it blocked all fragment navigations, including same page navigations (e.g. clicking a link that changes only the fragment in the current URL). Since this isn't a new load, the policy shouldn't apply in this case. In addition to the small fix to this check, this CL also cleans up and makes the scrolling to fragment condition more readable. Bug: 1091247 Change-Id: Ic523b5b331720a822a5530698ab6560f580d2b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265758Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782667}
-
Katie Dillon authored
This cl turns on prioritize rendering until begin main frame by default. Currently, the scheduler will prioritize rendering every 100ms until any rendering related task is run. This feature changes that behavior so that rendering will stay prioritized until we actually do a BeginMainFrame task, ie render. This is more in line with developer expectation wrt prioritizing rendering. Bug: 966177 Change-Id: Id50ee8c1542ff0dda5612a3d40f3354cd6849192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261753Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#782666}
-
Miriam Zimmerman authored
The changes in this CL were auto-generated using the instructions in tools/gritsettings/README.md at https://crrev.com/782137. BUG=1098028 TEST=CQ Change-Id: I17ff2d5068efbb7206f5af2272c7ffb422b3fade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267623Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#782665}
-
Takashi Toyoshima authored
As we still monitor metrics on Canary, extend metrics expiry date to track them. Bug: 1053064 Change-Id: I2dad57a79ae0618531f19407f0a700957a14e590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264180 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Sammie Quon authored
Also moves resizer shadow code out of overview so it is together with the mult-resizer widget as I think they should be together. Test: manual, added test Bug: 1097383 Change-Id: Iefe82b984d9ac49f7d0569a15af66d739aac40fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261362 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#782663}
-
Yue Zhang authored
Trendy-terms is like omnibox-only, with the only difference that there is a horizontal RecyclerView below the omnibox that contains clickable trendy terms. Note that since this component is not yet hooked with data source, the trendy-terms variation looks the same as omnibox-only right now. This CL only introduces the components to contain the trendy terms that come later. Bug: 1099037 Change-Id: I579589123efc275d62d14f0c202f575d2609ce6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265236Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782662}
-
Cezary Kulakowski authored
It's necessary to check if creatorPid is not null as it won't be present in the notification's data if it was created by Chromium without change which added this field to the notifications. Bug: 1097737 Change-Id: I146e00616f854cc1ab15a960107c17d09682197a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264314Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#782661}
-
Jimmy Gong authored
- Fixes a bug where the file icon of a print management would shrink when the app's browser window gets smaller. Before: https://screenshot.googleplex.com/0qO99Th9238 After: https://screenshot.googleplex.com/dDjGUuMEU33 Bug: 1053704 Change-Id: Ifd985e3715c3a4b095e0d3adfc89a0b963c92884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265449 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782660}
-
Kyle Horimoto authored
Change-Id: Iadb1c5c6f6f5cbc710346e4b04e15b1be241d40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268459 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#782659}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab90f3a64a2a..dca7f0682577 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cmumford@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098933 Tbr: cmumford@google.com,eirage@google.com Change-Id: I4174a10f0b64d92fc1c663b338e95a964f9d7057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Yulun Wu authored
Bug: 1033219 Change-Id: Iaf760307c32a67e3ef5da7308235a3c297c2d0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242832Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782657}
-
Sinan Sahin authored
Currently, top margin for the control container is calculated using top_controls_height - tab_strip_and_toolbar_height (dimen). On tablet CCTs, this may be negative since the tablet CCTs don't have a tab strip while the tab_strip_and_toolbar_height always includes the tab strip height on tablets. A better way is to use the real view heights instead of dimens. Bug: 1098716 Change-Id: I7428536b722df4489028115511a0c743665fd964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265176Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#782656}
-
Joshua Pawlicki authored
Bug: 1092936 Fixed: 1092936 Change-Id: If2aff003d64a945b05ba2154b9cac94e4622b542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240060 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782655}
-
Robert Ogden authored
If a subresource redirects to an origin that the user has cookies for, none of that subresource's redirect chain should be reported as successfully cached. Uses some recursion! Bug: 1082505 Change-Id: I2ff30e073d4a9051c7eeb81c6fd7d8912b23f61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264261Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782654}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39adce149810..e3296b6d4cb4 2020-06-25 danilchap@webrtc.org Ignore inactive chains when writing DependencyDescriptor rtp header extension. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iec35b8b58ddfcabf33d5d022f57dabf73d12793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782653}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593104261-feaf838502d2cebda7dce5b42f2db042fba267b5.profdata to chrome-win64-master-1593108049-347f75b6d1676a52301ec3ad36e2e55c1372542f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4a4e0848862ecfed32c2395adff9806dd5540ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268082Reviewed-by:
-
Xiyuan Xia authored
Bug: 1021774 Change-Id: I1fa60f4f920e2cade3b2fd9249f85cf049c8564b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268085Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782651}
-
Anupam Snigdha authored
When the |RenderWidgetHostViewAura| or the focused window is getting destroyed, we shouldn't be accessing the frame tree and do non trivial work in |VirtualKeyboardControllerWin| to notify about the VK insets. This should only be done during window focus changes. Added a flag in |DetachFromInputMethod| that indicates whether the call is during a window destruction or focus loss to detect these cases explicitly in |VirtualKeyboardControllerWin| code. Bug: 1098700 Change-Id: Ifbece79ba10e229c1e1c1ce09c40913ccd7b1f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265363Reviewed-by:
-
Tamer Tas authored
Google Docs loading story doesn't produce any metrics due to configuration errors. This CL re-uses the interactive event which is common across GSuite products. R=johnchen@chromium.org,ulan@chromium.org Bug: 1044682 Change-Id: I8979fec52b4365bf6b908485f11725bfba4f0477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266961 Commit-Queue: Tamer Tas <tmrts@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782649}
-
