GitLab

The M68 branch has a non-working implementation of the
enable-websocket-auth-connection-reuse flag. In order to avoid the
confusion of having a flag that works in some versions and not in
others, temporarily remove the flag from about:flags.

Once the flag has been disabled in the M68 branch it will be re-enabled
for M69 by reverting this CL.

BUG=423609

Change-Id: Id17ac18e13effcfd5bd946dc1fe0f1c70df96539
Reviewed-on: https://chromium-review.googlesource.com/1090700
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566730}

This patch converts the test to reftest since that test
just confirms repaint after load.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Bug: 708452
Change-Id: Iffc00614c617a64c5f185029014f1d43734fbbca
Reviewed-on: https://chromium-review.googlesource.com/1092610
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566729}

Some cleanup work for components/drive/ briging it in line
with recomended practices/c++ modernization.

- clang tidy modernize-make-unique.
- Fix up headers.

This CL introduces NO logic changes.

Bug: 841659
Change-Id: I9b8e1dfbacee96c4411abd304c8faf0feb24e118
Reviewed-on: https://chromium-review.googlesource.com/1093334
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566728}

https://skia.googlesource.com/skia.git/+log/e73d7d84d770..efd99cc92817


git log e73d7d84d770..efd99cc92817 --date=short --no-merges --format='%ad %ae %s'
2018-06-12 caryclark@skia.org clean up SkPicture include


Created with:
  gclient setdep -r src/third_party/skia@efd99cc92817

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: I56c3ce7048b7b9456042030d73150345856f65db
Reviewed-on: https://chromium-review.googlesource.com/1098236Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566727}

The function had a public helper function that didn't add much value. We
were duplicating checks like !provider_ and the flow of data was more
complicated.

It's hard to read the diff so the changes are:
* Removed RegisterServiceWorkerImpl.
* Removed duplicate if (!provider_) check.
* Removed |raw_script_url|, it's unneeded indirection.
* Unified the preparation of |script_url|, |pattern_url|, and
|update_via_cache| to just before they are used.

Change-Id: Icef9dd5b26f4009fbf69d62ad918066be2c0733c
Reviewed-on: https://chromium-review.googlesource.com/1098425
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566726}

Design doc: http://go/cros-qs-restyling

TEST=ash_unittests,browser_tests
BUG=842079

Change-Id: Ia9eaac6e494fc8ec1b35aaedd9ebf9814890ec57
Reviewed-on: https://chromium-review.googlesource.com/1088458
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566725}

The presentation-time from gpu gives a more correct view of what the
user experiences, rather than the swap-time in the renderer process.
So switch to using the presentation-time to measure the various
paint-time metrics.

The various paint-time metrics in telemetry tests (loading benchmark)
will go up after this change, but it is expected, and it is not a
regression. Results on various platforms with this change:

Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000
Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000
Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000
Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000
Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000

BUG=811961

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I70a86eb85e84670942fe3fe6341926b5bc6255b9
Reviewed-on: https://chromium-review.googlesource.com/1050693
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566724}

According to xhr spec[1], no CRLF normalize operation need to be
performed when invoking FormData methods, so all normalization
call is removed in this commit.

But in form sepc[2], when appending data from form controls to
FormData, both name and value should be normalized. New methods
|FormData::AppendFromElement| will perform the normalize operation.

[1] https://xhr.spec.whatwg.org/#dom-formdata-append
[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#append-an-entry

BUG=798030

Change-Id: If90a8e500705013c2935e5290624d4414dd32a72
Reviewed-on: https://chromium-review.googlesource.com/1091238Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566723}

This CL mechanically renames SettingsObject to
FetchClientSettingsObjectSnapshot, and revises the class level comments of the
class.

This change is a part of the Modulator cleanup project. See the design doc for
details:
https://docs.google.com/document/d/1R0VgKZtrBL9hAq8SgCVuDOv-2vzB15M9HDwzdad0J6k/edit#heading=h.5rwrtojwiu5c

Bug: 845285
Change-Id: I0359d650e97a5972b2cdc5a39c223b50f2e42afc
TBR: haraken@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1090592
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566722}

CL:857742 and CL:857743 added the support for APN authentication method
specified in the mobile operator database in shill. CL:1081764 updated shill to
respect the authentication method in the user-specified APN property. This CL
adds the ONC translation of the APN authentication property, so that a
follow-up CL can update the settings UI to allow specifying the APN
authentication for the user-specified APN.

BUG=b:68680371

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7e110a3a4841f8ec2ee725cdc799999b51a45746
Reviewed-on: https://chromium-review.googlesource.com/1096430
Commit-Queue: Ben Chan <benchan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566721}

Site settings's All Sites back end was updated in r562730 to group sites by
their eTLD+1. This patch updates the front end to match. Clicking on an eTLD+1
group will expand the list to show all relevant origins under it, and clicking
one of those origins retains the previous behavior where it will navigate to
Site Details. Similarly sites that have no eTLD+1 group will retain existing
behavior.

Bug: 835712
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I075a1befd49211d0a3b29820ea3aa71887f9dd0e
Reviewed-on: https://chromium-review.googlesource.com/1088274
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566720}

This makes them available in the save-as dialog.

Bug: 845088
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I37dbb73a8de6a115e70a3bc8549b0e4351086bb6
Reviewed-on: https://chromium-review.googlesource.com/1098421Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566719}

It fixes FirstRunUIBrowserTest when UnifiedSystemTray is enabled.

The test is regressed by interactive_ui_tests fix
https://crrev.com/c/1096718. We only have to set initial focus when
system tray bubble is activated.

This is a flag flip blocker of
chrome://flags/#enable-system-tray-unified.

TEST=FirstRunUIBrowserTest.EscapeCancelsTutorial
BUG=847104

Change-Id: Iccb8ea92724fffc787a649e1a4fdac36507f3b71
Reviewed-on: https://chromium-review.googlesource.com/1098419
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566718}

MSVC's STL has aggressive [[nodiscard]] attribute, that traps subtle
bugs. That is enabled by default in C++17, and can be opted in C++14.

Change-Id: Ie30bad0ae0ebd81d15f2f50cbdf66c85050b5033
Reviewed-on: https://chromium-review.googlesource.com/1097044
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566717}

https://chromium.googlesource.com/catapult.git/+log/fdacd1639e2a..459c4d0417df


git log fdacd1639e2a..459c4d0417df --date=short --no-merges --format='%ad %ae %s'
2018-06-12 benjhayden@chromium.org Add an index for GetAlertsAroundRevision for non-internal users.
2018-06-12 achuith@chromium.org oobe: Also support gaiastaging.
2018-06-12 nednguyen@google.com Revert "[Sheriff] Disable telemetry.internal.browser.browser_unittest.BrowserTest.testForegroundTab"
2018-06-12 nednguyen@google.com Revert "Disable BrowserTest.testActivateTab on Mac"
2018-06-12 perezju@chromium.org [Telemetry] Remove measurement property from TimelineBasedPageTest


Created with:
  gclient setdep -r src/third_party/catapult@459c4d0417df

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:851463,chromium:851463,chromium:851948
TBR=sullivan@chromium.org

Change-Id: Ib82446d7c3fe1aa9f915886dfdee5059fecd4bf1
Reviewed-on: https://chromium-review.googlesource.com/1097817Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566716}

Without this the observers who only care about the Loaded <=> Loading
transitions don't know if a transition to Loading is coming from a
Loaded state or not (some logic could be added in the observer directly
but this seems cleaner).

Change-Id: I077314c2afc800f14dfddd3b65fa4530feacb559
Reviewed-on: https://chromium-review.googlesource.com/1096306Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566715}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/51360dbda4aa..11376cfc6fe9


git log 51360dbda4aa..11376cfc6fe9 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 dgarrett@google.com chromeos_config: Mark assorted standalone builders important.
2018-06-12 dgarrett@google.com chromeos_config: Create a master-full builder.


Created with:
  gclient setdep -r src/third_party/chromite@11376cfc6fe9

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:851183
TBR=chrome-os-gardeners@chromium.org

Change-Id: Icad4a216ddef676124ce5ef2227e94d120c41c79
Reviewed-on: https://chromium-review.googlesource.com/1098435Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566714}

Change-Id: Ibc19664d191f8bee18711170e5feeedc26fa0362
Reviewed-on: https://chromium-review.googlesource.com/1094820
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566713}

Bug: 851996
Change-Id: Id1b01007c65fe417dc9f3beac1aac158e5c97bd0
Reviewed-on: https://chromium-review.googlesource.com/1097701Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566712}

When the browser is resized to be very, very narrow the picker should
resize to one column. At this point the option dialog will also need
to be resized and the text may now overflow.

Bug: 850338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I06d08f15b631f9810ead7e01180aacf2a4a66c18
Reviewed-on: https://chromium-review.googlesource.com/1097461Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566711}

https://skia.googlesource.com/skia.git/+log/47fd204aa6c0..e73d7d84d770


git log 47fd204aa6c0..e73d7d84d770 --date=short --no-merges --format='%ad %ae %s'
2018-06-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@e73d7d84d770

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: Id6ca5e7b17c5db0f8d9f0b094357929da73b63be
Reviewed-on: https://chromium-review.googlesource.com/1098495Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566710}

Change-Id: I2437f4bae9bfd7384d42a586fd7ee6cfba54210d
Reviewed-on: https://chromium-review.googlesource.com/1098418Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566709}

LayoutNGMarker has pre white-space. If its parent changes color and
PropagateStyle() without carry marker's white-space, this will cause extra
layout passes.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I388f1811baf45f31f1ce168b9c7b68d51c2dd1d2
Reviewed-on: https://chromium-review.googlesource.com/1096590Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#566708}

//services/network/public/mojom:websocket is split from
//services/network/public/mojom:mojom due to an issue related with
lazy serialization[1]. network_param.mojom is in the
websocket_mojom target because websocket.mojom depends on the
file, but network_ipc_param_traits.(cc|h), some of its typemap
files, depend on services/network/public/cpp, and that results in
a circular build dependency.

This CL fixes that by splitting network_ipc_param_traits.(cc|h).

1: https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/UoDBRD3GhVE/nizRiiOEBgAJ

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I31ee8c8e56f4e5b7087fc991b4b0059a8a5e9beb
Bug: 850869
Reviewed-on: https://chromium-review.googlesource.com/1094911Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566707}

This changes prepares DeviceSensorEventPump and its subclasses for
the move to blink by removing the inheritance of DeviceSensorEventPump
from PlatformEventObserver and moving listener-related logic to
DeviceSensorEventPump. Since Device*EventPump instances can no longer be
stored in RendererBlinkPlatformImpl::platform_event_observers_, separate
variables have been added temporarily that will be moved to appropriate
Device*Dispatcher classes along with the logic when Device*EventPump
classes are moved to blink.

Bug: 850997
Change-Id: Iedf23e368adb9180091d094146306330987bcf9c
Reviewed-on: https://chromium-review.googlesource.com/1091275
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566706}

When a new Folder is created, the folder cell is created on edit mode. If we try to delete the cell
at this point (by swiping the cell to the left) a crash occurs (both on legacy and UIRefresh).

This Cl prevent this crash by returning NO on canEditRowAtIndexPath for the editingFolderCell.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaca9d4d7001d89d795d2ce2c82db46a092086ec9
Reviewed-on: https://chromium-review.googlesource.com/1098230
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566705}

Use CompletionOnceCallback in most places in //net/dns, except for
dns_transaction.cc.

Bug: 807724
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie2a8ad3ed9e5285761d7321ec337e888b55b9dd9
Reviewed-on: https://chromium-review.googlesource.com/1091596Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566704}

The number of decoded frames should be equal to the number of frames of input
video, if no Reset() is invoked before Flush().
Should check this condition in VDA unittest.

BUG=chromium:834170
TEST=VDA unittest on eve and kevin
TEST=VDA unittest on non-Chrome OS platforms in CQ.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2eda613522b9a1e6259a9d72c4f86b616bc90996
Reviewed-on: https://chromium-review.googlesource.com/1063910
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566703}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Iac2d8e016f55f31b210e1e737f9f9d4258299480
Reviewed-on: https://chromium-review.googlesource.com/1098206Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566702}

This is recorded for pages in OnComplete and it is recorded for all
pages that were paused when the page load completed.

Bug: 797989
Change-Id: Ia42b917305cf96160134085d7608a25e3f828ae7
Reviewed-on: https://chromium-review.googlesource.com/1093431
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566701}

The test tests that Quick View closes when users click Quick View when
it is in open state.

Change the test to use a text file, rather than a PNG image, to remove
image decode and rescale costs from the test-time.

The test awaits the close using a pending() call, but did not define a
|caller|, which is a required argument of pending(). Fix that.

Also put all tests steps in a StepRunner group, so that all test steps
can be debugged using the step runner browser test flag. Document each
of the test steps.

Bug: 851888
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I39310b57f9ed09e5d164b95b11b7494dc45adffa
Reviewed-on: https://chromium-review.googlesource.com/1097048
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566700}

The test tests that Quick View opens by the usual method: user presses
the space key on a selected file.

Change the test to use a text file, rather than a PNG image, to remove
image decode and rescale costs from the test-time.

Also put all tests steps in a StepRunner group, so that all test steps
can be debugged using the step runner browser test flag. Document each
of the steps.

Bug: 851888
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ief21de93e9496f463506d2ae22ab28db76c087ef
Reviewed-on: https://chromium-review.googlesource.com/1097041Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566699}

This replaces the GLsync object in WebGLSync with the
GL_READBACK_SHADOW_COPIES_UPDATED_CHROMIUM query from the
GL_CHROMIUM_nonblocking_readback extension.

In order to prevent invalid readback results when using transform
feedback, this calls InvalidateReadbackBufferShadowDataCHROMIUM on
buffers when they are written by transform feedback.

Bug: 828135
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia5662e01fb2485595a1cd46e5c66d4db04efaf92
Reviewed-on: https://chromium-review.googlesource.com/1036403
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566698}

With new update on the Cable spec, the ordering of elements in
client/authenticator advertisement packets has changed. Update
FidoCableDiscovery accordingly.

Bug: 851004
Change-Id: Ib40ec3af1e10490ea80e8934403cd1a381319f83
Reviewed-on: https://chromium-review.googlesource.com/1093256
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566697}

By default, all FYI tests run at pri 40, while all non-FYI tests run at pri 30.

Since some optional CQ bots mirror FYI bots, their tests run at a lower pri
than other CQ tests. Consequently, if the pool is in full use, there's a chance
that the optional tests will get starved out and expired. This leads to a blocked
CQ run if the CL in question is required to pass these optional bots via
"Cq-Include-Trybots" commit msg footer.

This increases priority of all known CQ-optional FYI bots to match normal CQ
tests.

Bug: 851115
Change-Id: I9c7625e498f098a6613729777d3782c2b4b6625c
Reviewed-on: https://chromium-review.googlesource.com/1097600Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566696}

This commit:

- moves AppListPresenterImpl into //ash/app_list/presenter, and extracts all
  its accesses to Ash out to ash::AppListPresenterDelegateImpl;
- moves AppListPrenseterImplTestApi into AppListPresenterImpl;
- moves AppListPresenterImplTest into ash_unittests and reenables all
  tests in it.

With this commit, we'll have the following dependency chain for app list:
ash -> presenter -> view -> model

An upstream component has access to its downstream components (e.g.from
presenter to view, fromash to model).

A downstream component can access its upstream components with specific
interfaces:
model     -> *: via AppListModelObserver;
view      -> *: via AppListViewDelegtate;
presenter -> *: via AppListPresenterDelegate;

Bug: 733662
Change-Id: Iaa67c44aacdc79ecf7fd27682b6d9f89c2554c70
Reviewed-on: https://chromium-review.googlesource.com/1096549Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#566695}

BUG=b:109773984
BUG=841886

Change-Id: Ib04cd920450f7e63e779220b24a65956f3bc1e1f
Reviewed-on: https://chromium-review.googlesource.com/1088342Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566694}

Currently FileTransferController starts a 2s timer to change to
a directory if you drag and then hover over a root.  This happens
on the dragenter event.  The dragleave event will cancel the timer
if it has not already fired.

For crostini, we want to change to the directory immediately.

Test fires dragenter and then dragleave events immediately after each
other.  Usually this would cause no change if the events are
received within 2s of each other.  We test for crostini that even
if these events are fired right after each other, we still change
directory.

Bug: 846917
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4f0f463ff1c4bc164328a2764ff235ee399d6e4c
Reviewed-on: https://chromium-review.googlesource.com/1096801
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566693}

Enables it for Windows and ChromeOS

Bug: None
Change-Id: Id612d9893cc329dbd9d405c63261a049246e33d5
Reviewed-on: https://chromium-review.googlesource.com/1090408
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566692}

This is a reland of ac0ccdc1 with
FileManagerBrowserTestBase::drive_volume_ null-initialized.

Original change's description:
> Add a FakeDriveFs and change FileManagerBrowserTestBase to use it.
>
> Bug: 848126
> Change-Id: Icb7b5edf28aa61e133aff0f0bf639f06b32adcfa
> Reviewed-on: https://chromium-review.googlesource.com/1088336
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Sasha Morrissey <sashab@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566333}

Bug: 848126
Change-Id: I583fd6ebe92e5f191de93a3b3167a1c50e595a95
Tbr: noel@chromium.org, sashab@chromium.org, xiyuan@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1098395Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566691}