- 09 May, 2018 40 commits
-
-
Chris Harrelson authored
Bug: 838811 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I98804e49d7b50d7f192e54806a00669dc843a1ae Reviewed-on: https://chromium-review.googlesource.com/1048970 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557280}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Change-Id: Ie49af916b267bc49d4385bf2a1eeadaed860fa16 Reviewed-on: https://chromium-review.googlesource.com/1033954Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#557279}
-
Egor Pasko authored
After ~M44 a handful of MobileStartup.* histograms are only recorded with a suffix corresponding to the activity type (ChromeTabbedActivity, CustomTabbedActivity, DocumentActivity). Unsuffixed histograms are not recorded since then. It seems that there is no way to mark a prefix as obsolete and leave suffixes showing up on the dashboard. However, since the suffix-ification happened a while ago, we can mark the common prefix as "partial name" today. It will remove auto-suggest for old versions (not too bad), and would avoid the confusion of finding the unsuffixed versions on the dashboard without samples from modern Chrome versions. In other words, this change adds base="true" to those histograms. Bug: None Change-Id: Ie5c9a3755c6fe187cdfe2d00af6d3b2771131037 Reviewed-on: https://chromium-review.googlesource.com/1052470Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557278}
-
Miguel Casas authored
CanvasResourceGpuMemoryBuffer always uses GL_TEXTURE_RECTANGLE_ARB as texture target [0] when it should use gpu::GetPlatformSpecificTextureTarget() (which boils down to the said GL_TEXTURE_RECTANGLE_ARB on Mac [1] which is the only enabled platform [2]). This change is needed to use CanvasResourceGMBs on CrOs. Unittests extended (I just wanted to mock & expect BindTexture but somehow that needed adding other expectations). [0] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/canvas_resource.cc?type=cs&q=canvas_resource.cc+GL_TEXTURE_RECTANGLE_ARB&sq=package:chromium&l=207 [1] https://cs.chromium.org/chromium/src/gpu/command_buffer/common/gpu_memory_buffer_support.cc?type=cs&q=GetPlatformSpecificTextureTarget&sq=package:chromium&l=169 [2] https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?dr=CSs&q=runtime_features.cc&sq=package:chromium&l=154 Bug: 839970 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iaa1150e95f83d8ab91464b0d8d385556ba5a9ed6 Reviewed-on: https://chromium-review.googlesource.com/1049832Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#557277}
-
Michael Lippautz authored
Bail out on zeroed memory for HeapVectorBacking<Member<T>> instead of further dispatching through TraceTraits to Visitor. Bug: chromium:840696 Change-Id: I071858b597d3de82710b89990bd2fa942acb964e Reviewed-on: https://chromium-review.googlesource.com/1051988 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557276}
-
Justin Cohen authored
Bug: 841212 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4cdfef554f257a7bd920aa9efba184ae8d4126ba Reviewed-on: https://chromium-review.googlesource.com/1052549Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557275}
-
Karandeep Bhatia authored
Extensions: Disable ExtensionWebRequestApiTest.WebRequestClientsGoogleComProtection with network service. r548673 enabled the WebRequestApiTest.WebRequestClientsGoogleComProtection test for network service. To make a network request from the browser, the test replaced the usage of URLFetcher with SimpleURLLoader. However this network request never reaches the WebRequest API layer, hence defeating the purpose of the test. To sanity check that a browser request is intercepted by extension, this CL makes another browser request. This causes the test to fail with the network service. BUG=721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6b18ed906b3f01c10521fd89a24414e9a4351edd Reviewed-on: https://chromium-review.googlesource.com/1049276Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557274}
-
John Budorick authored
TBR=vitalii@chromium.org,nednguyen@google.com Bug: 841189,812051 Change-Id: Ifddff5dca063ebebe2567f62c0f8257daaddee54 Reviewed-on: https://chromium-review.googlesource.com/1052224Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#557273}
-
Ovidio Henriquez authored
This change adds a WorkerNavigatorUSB supplement for WorkerNavigator. The WorkerNavigatorUSB interface contains a usb attribute that returns a USB object. The constructor for this USB object was also changed to use an ExecutionContext* parameter to allow a worker to properly initialize the object. This change also updates the global interface listing tests to reflect the new attribute that WorkerNavigator contains and adds web platform tests to check that the WorkerNavigator does indeed have the usb attribute defined in the supported contexts. Due to a bug (https://crbug.com/839117) with the WebIDL bindings generator, the global-interface-listing-service-worker.html test exposes the usb attribute of WorkerNavigator. Therefore, a check is performed in WorkerNavigatorUSB to return a null pointer if the execution context is a ServiceWorkerGlobalScope. Since the intended behavior for navigator.usb in a service worker is to be undefined, the web platform test for this checks that condition instead. Bug: 837414 Change-Id: I3ca63c9ae0b85e5425134024d2fdd9b29ef7d8c3 Reviewed-on: https://chromium-review.googlesource.com/1024724 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557272}
-
dpapad authored
This is effectively applying MD refresh toggle style, as well as preparing for removing paper-toggle-button from third_party/polymer. Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I90c3eb4098304b3ca707665d52bb6b54e67bdce6 Reviewed-on: https://chromium-review.googlesource.com/1048167 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557271}
-
Paul Jensen authored
They're unneeded (esp now that the parent class is excluded), and have the potential to overlap with cronet_test_java.jar classes. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I14b884c9b3c2e66ac0dd93007ed668c1ff22db79 Reviewed-on: https://chromium-review.googlesource.com/1040546Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557270}
-
Matthew Jones authored
Bug: 840523 Change-Id: I4676c3ee4f5b812173193b45a02a88291afac8ab Reviewed-on: https://chromium-review.googlesource.com/1048403Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#557269}
-
nednguyen authored
Later, when we refactor story_runner to use shared_state's platform for determining test disabling logic, we would need to make sure that platform is not None. Bug: 841311 Change-Id: If38d9ae2f03d12034ed2b1352672cb5ef33ebc40 Reviewed-on: https://chromium-review.googlesource.com/1052207Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#557268}
-
Johnny(Jianning) Ding authored
This is a reland of 79b28587 Original change's description: > Using non-override time in InspectorPerformanceAgent.cpp. > > Right now the InspectorPerformanceAgent returns incorrect performance metrics > (such as LayoutDuration, ScriptDuration, etc.) if there is an time override in > place. The InspectorPerformanceAgent needs to return real time elapsed. > > Per offline discussion with Pavel(pfeldman@), the reason we don't expose the > non-override time API in the web platform (<blink>/platform/time.h) is that time > override is to abstract the web platform from the time. The web platform should > just deal with time and not know about whether the time is overridden. Exposing > the non-override time API in the very core part of blink will leak the override > aspect and hence compromising the whole design > > BUG: 830033 > Change-Id: If3140892ac60bc853ef5f98f7b478a98ae332806 > Reviewed-on: https://chromium-review.googlesource.com/988833 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Johnny Ding <jnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556012} Change-Id: I6f04a582d63376b3d6eeb80e27615c455dba4a61 Reviewed-on: https://chromium-review.googlesource.com/1045566 Commit-Queue: Johnny Ding <jnd@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557267}
-
Xing Liu authored
DownloadLocationDialog uses ModalDialogView to limit the whole layout inside a small area. During the measuring pass of layout area on the view hierarchy, LayoutParams of views cannot be null. However, we also use a Spinner inside the ModalDialogView, where the view is dynamically attached to its parent, and may not have LayoutParams when the measuring pass happens. This CL ensures the LayoutParams non null when generating the view for the Spinner in download location dialog. Bug: 840340,792775 Change-Id: Ibae3ab3561f51afc49ed4d0ce29611f6fe322b5a Reviewed-on: https://chromium-review.googlesource.com/1050977Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557266}
-
danakj authored
We introduced a mistake where if the image was not opaque, the background color was no longer drawn behind it, so on chromeos the chrome header ui could be seen through. This fixes the issue by rearranging the painting some, and improving some performance corner cases while we're here. First, we only need to use SaveLayerWithFlags() when we are blending together 2+ things *that are not opaque*, then want to apply alpha to them together. This is only needed when alpha is < 255, or when we have both |frame_image| and |frame_overlay_image|. Otherwise the background color is opaque, so drawing it first then blending one image into it is equivalent. Then, in both this and the other case, we draw the background color first, then draw the images above it, in order to ensure the bar is opaque. Note also that we use kPlus blending mode when alpha < 255 so that between the active and inactive background colors, they add up to 255 alpha, giving us something opaque. R=estade@chromium.org Bug: 836023 Change-Id: Ibc6b7a3dbec0d9d63b0b07f70a4c17405a3eeec2 Reviewed-on: https://chromium-review.googlesource.com/1050690Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#557265}
-
Dave Schuyler authored
Most answers and entities have single line descriptions, but dictionary definitions are allowed to wrap. This CL allows for that wrapping. Also, fixes bug where the cached font_height_ wasn't updated properly. (Which would occasionally cause a line to be too tall). Bug: 838733 Change-Id: Ic1478acd6c62420f3bfd426b206973590b625729 Reviewed-on: https://chromium-review.googlesource.com/1048865Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557264}
-
Eugene But authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I61aa929e8ca773b15f54f05b5bcb44961d488c4a Reviewed-on: https://chromium-review.googlesource.com/1052487Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557263}
-
Kyle Horimoto authored
The class has been split between a pure-virtual class, an implementation class, and a test double. The test double will be used in a follow-up CL. Note: This CL also removes the is_active() function from the class. As I was implementing contents for a future CL, I realized it was never actually used. Bug: 824568, 752273 Change-Id: I748b5400ee02f86d1978fa866febf85132acb153 Reviewed-on: https://chromium-review.googlesource.com/1050951 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#557262}
-
Eugene But authored
The following changes mde to the test: - everything is placed into web namespace - do not assert inside helper fulctions (assert inside tests instead) - use EmbeddedTestServer instead of deprecated web::HttpServer - use WaitUntilConditionOrTimeout for waiting - s/TestNavigationDelegate/FakeNavigationDelegate Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4369091a71f16e9e4ab2e6e5c24723d77f2c833e Reviewed-on: https://chromium-review.googlesource.com/1052169Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557261}
-
Mike Wasserman authored
Add a PropertyConverter to WindowService to support property syncing. Implement SetWindowProperty[Impl] on WindowServiceClient. Add a unit test, split up the existing fixture, refine GL init. Add a helper function for Ash window property registration. (consolidate out-of-sync registrations between Chrome and Ash) Add a helper function for window service init in Ash. Make kRenderTitleAreaProperty public (mojo side used by Chrome) Check that properties are not registered twice with the converter. Optionally register kShadowElevationKey in helper (for Ash, not Chrome). Update and add crbug.com/837695 TODOs. Bug: 837695 Change-Id: Ic026d06e3aeb39bb7008f8d7fec2392fa08f176c Reviewed-on: https://chromium-review.googlesource.com/1050575Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#557260}
-
Dave Schuyler authored
This Cl removes an unnecessary local var as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1048865/4/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc#246 Bug: None Change-Id: I35eab5fc55ca218080e2a37878636b8df40eb152 Reviewed-on: https://chromium-review.googlesource.com/1050578Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557259}
-
Thomas Guilbert authored
The FlingingRenderer needs a MediaController in order to be created. RemotingMediaRouteProvider signals MediaRoute creation as soon as we start to launch the RemotingCastSession. This can trigger the creation of a FlingingRenderer before the CastSession finishes launching, which means that FlingingRenderer ends up with a null MediaController. This CL delays the moment at which RemotingMediaRouteProvider completes the route creation request, to after the RemotingCastSession launches. This guarantees that we won't create a FlingingRenderer until we have a valid MediaController to retrieve. Bug: 790766 Change-Id: Ib74ab54890976f7735140e7eac79548898fbb667 Reviewed-on: https://chromium-review.googlesource.com/1043527 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557258}
-
Joshua Bell authored
The code contained an optimization to skip rebuilding sets of held shared/granted locks if there was no pending request. This was not valid, since a request could come in later and rely on the sets to correctly determine if the lock was grantable. Bug: 840994 Change-Id: I64218cfaebe4ff7b46f133665a94378c66d0e738 Reviewed-on: https://chromium-review.googlesource.com/1050807Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#557257}
-
Elly Fong-Jones authored
The EndToEnd test in this suite is flaky on Mac. TBR=miu@chromium.org Bug: 841387 Change-Id: I73480393c499dbd05a7891a78b24d7d4ba11d326 Reviewed-on: https://chromium-review.googlesource.com/1052428Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#557256}
-
Friedrich Horschig authored
Experimentally wire the password generation into the keyboard accessory. When the PasswordsKeyboardAccessory feature is enabled, the accessory should provide an option to use the generated password. With this CL, the popup should still be shown. Bug: 835234 Change-Id: I5a0693430ca55d67ad8c922caacfce02ab23112a Reviewed-on: https://chromium-review.googlesource.com/1013943 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557255}
-
Sarah Hu authored
This CL adds some basic fingerprint UI to views lock screen to support fingerprint fishfood. The detailed specs are not ready and may be subject to change. So it may need to be polished in the future for adding animation, adjusting styles etc. Current mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw Bug: 835357 Change-Id: Ifab074ca53bb0a8a5128d9b3da6139d68bb03b09 Reviewed-on: https://chromium-review.googlesource.com/1047958Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557254}
-
Zach Helfinstein authored
Add dictation setting to settings/manageAccessibility Bug: 801398 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8e0c1b0508801ee9b7b7f0e3c6ac616dcdfa3e88 Reviewed-on: https://chromium-review.googlesource.com/1043085 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557253}
-
Min Qin authored
If the server doesn't support partial responses, Chrome should cancel parallel download requests. These requests result in the wrong write offset and makes the file larger than the original BUG=838627 Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba Reviewed-on: https://chromium-review.googlesource.com/1048130 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557252}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: I51e9af84ff43b34044851f409a7bc4b1877a0ab6 Reviewed-on: https://chromium-review.googlesource.com/1052071 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557251}
-
Christopher Cameron authored
Add an explicit method on GLSurface that is to be called while the GLContext is still current, but before the GLSurface is destroyed. A step in this direction was taken in https://crrev.com/538387, where we made the GLContext current again after its decoder had been destroyed, but that path has proved unstable. In particular, the GLSurface internals on macOS are created while the decoder is active, and so destroying them after the decoder is destroyed is precarious. Bug: 772576, 817830 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3ff1c395c4e9d7ac0b0f1ab54400cde28bdbe298 Reviewed-on: https://chromium-review.googlesource.com/1046046Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#557250}
-
Joe Downing authored
This CL implements tests for a couple of TODOs that arose during the initial code review for my content layer changes for this feature. During implementation I found an issue where we weren't clearing KeyboardLock during navigation, that now works correctly. A big portion of this change involves codifying the behavior between iframes and the KeyboardLock feature. I haven't written many of these tests before so I'd like to make sure that the tests I have are set up correctly, testing what I think they are testing, and the behavior I have codified is reasonable. BUG=680809 Change-Id: Ief1fbfef48d396f4df72319bb5bb61120033eada Reviewed-on: https://chromium-review.googlesource.com/1041137Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#557249}
-
Michael Thiessen authored
Note that this doesn't handle the case where the banner is already open when entering VR. That's complicated and I'm not going to try to merge a fix for that back to M67. (This CL is targeted for M67) Bug: 840811 Change-Id: I9e4daba4baeed7aeb8f5b841fdb7acb1f7872ff7 Reviewed-on: https://chromium-review.googlesource.com/1052211 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557248}
-
Ian Kilpatrick authored
Small cleanup - there should be no behaviour change. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ife84f116812fc949f039418168b5d005096c46c2 Reviewed-on: https://chromium-review.googlesource.com/1052208Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#557247}
-
Min Chen authored
Bug: 818331 Change-Id: I811f3f12af9c75e9be2581d38e89093deb023c0a Reviewed-on: https://chromium-review.googlesource.com/1050877 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#557246}
-
Dmitry Gozman authored
Used in "<extension name> is debugging this browser" infobar. Bug: 823194 Change-Id: Iff6627097c020cccca8f7cc3e21a803a41fd8f2c Reviewed-on: https://chromium-review.googlesource.com/1048064 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557245}
-
Hiroshige Hayashizaki authored
It is suspicious that GetDocument() can be nullptr in ImageDocumentParser::AppendBytes(). This CL adds an IsDetached() check there, just like DecodedDataDocumentParser::AppendBytes() does. Bug: 826198 Change-Id: I297fe5bbe609a380ce8a175529d1216a88d1c1ee Reviewed-on: https://chromium-review.googlesource.com/1050697Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#557244}
-
Mugdha Lakhani authored
downloadTotal is a field that can be set by the developer from the fetch() API, through BackgroundFetchOptions (https://wicg.github.io/background-fetch/#dictdef-backgroundfetchoptions). Before this change, the progress bar in the UI showed a percentage based on number of files downloaded. After this change, the progress bar will use bytes downloaded out of total bytes to be downloaded to calculate this percentage. If downloadTotal is set incorrectly (larger than total size of downloads), or not set at all, we fall back to previous behavior. Additionally, we update the progress bar more often with this change -- whenever DownloadManager notifies us of more bytes downloaded (~500 ms) instead of only updating when a download is completed or aborted. Bug: 813565 Change-Id: Ia704ea99b9ee3966aabb3f64a4ccd2112e36ab80 Reviewed-on: https://chromium-review.googlesource.com/998105 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557243}
-
Pavel Feldman authored
Bug: 837446 Change-Id: I8e2d61e50fe9bf800a1577642a458791fb777057 Reviewed-on: https://chromium-review.googlesource.com/1048401Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557242}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 737f592b. With Chromium commits locally applied on WPT: 04a79336 "Send boundary events rightaway after pointerup" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17191 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source chongz@chromium.org: external/wpt/pointerlock drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts mlamouri@chromium.org: external/wpt/screen-orientation panicker@chromium.org: external/wpt/page-visibility yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=danyao No-Export: true Change-Id: I31bec31c54e422553a77d31ec8d9af1c0a031422 Reviewed-on: https://chromium-review.googlesource.com/1052427 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557241}
-