GitLab

Remove the RecordWithSlowSink test.  The test has problems running on the build bots and after discussing its benefits, we decided that we don't need to test this level of tolerance and that the Record test is enough.

BUG=107546
Review URL: http://codereview.chromium.org/8957006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114628 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16659
TEST=chrome and tests build


Review URL: http://codereview.chromium.org/8934019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114627 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114626 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kbr@chromium.org

BUG=none
TEST=browser_tests,ui_tests,interactive_ui_tests,webkit_tests

Review URL: http://codereview.chromium.org/8960001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114625 0039d316-1c4b-4281-b951-d872f2087c98

Extend the controlled settings bubble code to allow for an event to be
fired upon user request to apply the recommended setting. Handle the
recommended case properly for the internet detail dialog by enabling
controls for recommended settings and handling resets by restoring the
default value in the control.

BUG=chromium-os:23124
TEST=Configure recommended settings for a network (currently only AutoConnect is relevant) and check the "Options" dialog for that network.

Review URL: http://codereview.chromium.org/8815014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114624 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure policy-configured networks get assigned to the correct profile. Also, they're now removed from the profile when the policy doesn't specify them any longer. Relies on the GUID fields in the network specifications, and requires https://gerrit.chromium.org/gerrit/#change,12437 on the flimflam side.

BUG=chromium-os:19411
TEST=Configure a network through policy. Remove that network and reload policy. The network should disappear from the network list.

Review URL: http://codereview.chromium.org/8804021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23124
TEST=Set up a policy-configured ONC network, observe that the network settings are locked down and the network cannot be removed.

Review URL: http://codereview.chromium.org/8804020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95971
TEST=This requires a special branded build to test (and master_preferences set to have auto_launch_chrome: true or specify mini_installer param --auto-launch-chrome), but after installing it you should see an item under the Wrench \ Options \ Basics that lets you configure Chrome to not auto-launch. If you instead, log out and log in again, Chrome should start with an infobar saying that it was auto-launched. The infobar should stay for a max of 5 launches and then not appear again. Pressing "Cut it out!" on the infobar should turn off this feature. If you just want to test the infobar, launch chrome with --auto-launch-at-startup. Also, uninstall and make sure Chrome is not auto-launched (a Windows error about Chrome not being found should not be shown).
Review URL: http://codereview.chromium.org/8729009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114621 0039d316-1c4b-4281-b951-d872f2087c98

Adding tests + minor code cleanup.

BUG=NONE
TEST=BrowserListTest.AttemptRestart, BrowserInitTest.ReadingWasRestartAfter(Restart|NormalStart)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114441

Review URL: http://codereview.chromium.org/8929027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114620 0039d316-1c4b-4281-b951-d872f2087c98

Revert 114615 - chrome.clear: Increasing granularity of public API

http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.

At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.

BUG=94334
TEST=browser_tests

Review URL: http://codereview.chromium.org/8008012

TBR=mkwst@chromium.org
Review URL: http://codereview.chromium.org/8949014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114619 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114618 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rnk
BUG=105667,107181
Review URL: http://codereview.chromium.org/8947015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114616 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.

At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.

BUG=94334
TEST=browser_tests

Review URL: http://codereview.chromium.org/8008012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106845
TBR=thestig
Review URL: http://codereview.chromium.org/8951010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107063
TEST=none
TBR=jam
Review URL: http://codereview.chromium.org/8951008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114611 0039d316-1c4b-4281-b951-d872f2087c98

Also, this CL moves chrome/browser/ui/webui/sync_promo_* to
chrome/browser/ui/webui/sync_promo/sync_promo_*.

BUG=107223
R=stevet@chromium.org,rogerta@chromium.org,sail@chromium.org
TEST=The sync promo responds to brand code and records results of the field
trial correctly.

Review URL: http://codereview.chromium.org/8933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114608 0039d316-1c4b-4281-b951-d872f2087c98

schema_generated_bindings.js.


BUG=80310
TEST=browser_tests --gtest_filter=*Extensions*


Review URL: http://codereview.chromium.org/8916019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114606 0039d316-1c4b-4281-b951-d872f2087c98

Print preview: A quick hack to support printing to the default printer without user confirmation in kiosk mode.

BUG=31395
TEST=none

Review URL: http://codereview.chromium.org/8915027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114605 0039d316-1c4b-4281-b951-d872f2087c98

- Add RUN_TEST_WITH_REFERENCE_CHECK macro which run a test then check leaked
 pepper objects.
- Use that macro to run all WebSocket related PPAPI unit tests
- Fix some object leak in tests found by the macro

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_*'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114389

Review URL: http://codereview.chromium.org/8934003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23640,106862,106850
TEST=run unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113601

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=113624

Review URL: http://codereview.chromium.org/8833008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114603 0039d316-1c4b-4281-b951-d872f2087c98

GLES2Implemetation::FreeEverything now fress everything it can.
the transfer buffer, the command buffer and any unused mapped
buffer (glMapSubXXX).

BUG=103989
TEST=unit tests


Review URL: http://codereview.chromium.org/8953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114602 0039d316-1c4b-4281-b951-d872f2087c98

aura-x11: Make sure the list of devices to track are updated when device hierarchy changes, and turn XInput2 back on.

If a device gets initialized after chrome boots up, then it is necessary to
update the list of devices chrome accepts input-events from.

BUG=106516
TEST=manually


Review URL: http://codereview.chromium.org/8892005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114601 0039d316-1c4b-4281-b951-d872f2087c98

Split out pointer, touchpad and mouse settings.

BUG=chromium-os:22305
TEST=chrome://settings/system should have separate pointer, touchpad and mouse settings.

Review URL: http://codereview.chromium.org/8905025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114600 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8958001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114599 0039d316-1c4b-4281-b951-d872f2087c98

Merge these redundant classes and their unit tests.
Do not try_mirroring_arrow with dummy anchor rects.
Deprecate unused allow_bubble_offscreen bubble flag.
Replace GetArrowLocation virtual with simple setter/getter pair.
Return anchor view bounds in BubbleDelegateView::GetAnchorRect.
Other refactoring and simplification.

BUG=106050
TEST=Bubbles are anchored correctly with their arrows in the right location.

Review URL: http://codereview.chromium.org/8870003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114598 0039d316-1c4b-4281-b951-d872f2087c98

This removes a lot of boilerplate with checking host_ (which was never
[locally] thread-safe, anyway).

Make as many things in SyncBackendHost private as possible.

BUG=103410,107279
TEST=


Review URL: http://codereview.chromium.org/8938013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17585
TEST=browser_tests --gtest_filter=SystemPrivateChromeOsApiTest.GetUpdateStatus

Review URL: http://codereview.chromium.org/8747003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114596 0039d316-1c4b-4281-b951-d872f2087c98

Move D&D client stuff into client namespace.
Provide some convenient getters/setters.

BUG=none
TEST=existing automation
TBR=sky
Review URL: http://codereview.chromium.org/8949010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114595 0039d316-1c4b-4281-b951-d872f2087c98

When VarTracker remove PP_Var from VarMap, it release its Var object
if needed, but never reset var_id stored in Var object. Then, if Var's
reference count is not 1, Var continue to exist with invalid var_id until
the last reference is released.

BUG=87310
TEST=ui_tests, browser_tests, nacl_integration

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114384

Review URL: http://codereview.chromium.org/8872065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8952002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=new tests


Review URL: http://codereview.chromium.org/8872044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114590 0039d316-1c4b-4281-b951-d872f2087c98

Add loop to _VerifySearchInPDFURL to try FindInPage 10 times and re-raise
the exception on the final loop. This is required because
_GetResultFromJSONRequest appears to timeout if called before the PDF has
loaded.

Add timeout parameter to pyauto.FindInPage to be passed to
_GetResultFromJSONRequest to speed up the loop in _VerifySearchInPDFURL
from the default of 45 seconds to 1 second.

Re-enable test on Mac.

BUG=107448, 70927, 93956

Review URL: http://codereview.chromium.org/8913012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114589 0039d316-1c4b-4281-b951-d872f2087c98

This change has been made at the parent class level, where the rendering
of the BookmarkButtonCell is implemented. It aligns the favicon with
NSImageLeft if there is no title.

A test has also been added to check for the differences in image positioning between these two classes.

BUG=105276


Review URL: http://codereview.chromium.org/8792001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107063
TEST=none

Review URL: http://codereview.chromium.org/8926001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114586 0039d316-1c4b-4281-b951-d872f2087c98

Some NaClLog invocations were left with detail level 0, which gets
printed by default.  This CL just increases some of these, so that
NACLVERBOSITY environment variable would have to be set to see events
such as NaCl module crash log messages that occur while generating the
'crashed' event.

BUG= None
TEST= None


Review URL: http://codereview.chromium.org/8929022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114585 0039d316-1c4b-4281-b951-d872f2087c98

Add a component installer for Portable NaCl. Registration of installer is hidden behind a commandline flag '--enable-pnacl'.

Still some of TODOs: finalize the metadata associated with the CRX, figure out what to do when a NaCl plugin needs Pnacl, but it's not there yet.


BUG= http://code.google.com/p/nativeclient/issues/detail?id=2365
TEST= none yet, only manually test:

(1) put a pnacl omaha config in the omaha sandbox, pointing at a crx.

(2) run out/Debug/chrome --user-data-dir=/tmp/temp_profile/ --enable-pnacl --component-updater-debug=fast-update --apps-gallery-update-url=http://omaha.sandbox.google.com/service/update2/crx

check /tmp/temp_profile/PNaCl/0.1.0.X is installed after a few seconds.

restart chrome, check that PathService registers /tmp/temp_profile/PNaCl/0.1.0.X soonish.


Review URL: http://codereview.chromium.org/8348026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8907052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114583 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8490001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles


Review URL: http://codereview.chromium.org/8680040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114580 0039d316-1c4b-4281-b951-d872f2087c98