- 16 Nov, 2020 40 commits
-
-
Liquan (Max) Gu authored
Changes: * Removed CPRService.mPaymentRequestOptions * onQueryForQuotaCreated has taken passed-in payment options from PRService. * Saved PaymentOptions in PaymentRequestSpec. Bug: 1025619 Change-Id: Ifafd0e4d0e1b5ac8815c63fe75eb3e779196c6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538110 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827796}
-
Bartek Nowierski authored
Amendment to crrev.com/c/2529150 to avoid a call to SetLastError in a typical case. Bug: 998048 Change-Id: Id39f072da22017e10882d57fa32c61882265478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537741Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827795}
-
Camillo Bruni authored
Bug: v8:11165, v8:8124 Change-Id: I7d86d7b2c6127490a15c20d6d230efd31b24aad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540467 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827794}
-
Dave Tapuska authored
Make the implementation common for both frame widgets. For OOPIFs the visual viewport transformation will be 1:1 so this code is the same. No behavioral changes intended. BUG=1097816 Change-Id: I5be86c5b9f5be377b8e0d8f7efda4258ffebdb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538010Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#827793}
-
Jérôme Lebel authored
Remove DCHECK in -[AddAccountSigninCoordinator start]. It overtriggers when the user wants to sign-in back with the primary account after being removed from the phone by another app. This DCHECK has been introduced with: crrev.com/c/2464274 Fixed: 1147837 Change-Id: I4d2199e66ad2e7a825e26e973dc4b1ddd2e518ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536446 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827792}
-
Brian Salomon authored
New versions don't have Done procs, allow null for release procs, and the YUVA variation internally figures out the texture channels from higher level inputs (formats + planar configuration). Bug: skia:10632 Change-Id: Ifb49bcb2fce4edc88b0c4425f9031be37113fd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537878Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#827791}
-
David Tseng authored
The intent of this change is to prevent unintended dependencies from chrome/browser -> content/public/browser/...*tts*. Achieve this by subtracting content/public/browser/tts_controller.h from chrome/browser/DEPS; this header is the central interface for tts services. Audit existing usages. Every such dependency should go through review from a tts owner if possible, but at least have some owner approve. R=dmazzoni@chromium.org Bug: 1148093 Change-Id: I25ce026ccb8b3fbc87e7d3a12237c7eb22c36f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534694 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#827790}
-
Christoph Schwering authored
This reverts commit 170f7981. The CL crrev.com/c/2527060 broke ~63 captured-site tests: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel?limit=200 Bug: 1111809 Change-Id: I6eb1f225d1e965fe8bcf85000912ae669722712a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537685Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#827789}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2dbcdc10..cfb8bc49 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2126d1b39ceebca8c4fdba5b70e6bd44946ca6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538125Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827788}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605506334-ef94e462f1073999e0940c25684c1ff8aa83ac59.profdata to chrome-win64-master-1605516929-4169c4fef8b75b908f60a07df9383038ad3b6191.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6372146610744334f74c9130519868aa7f9bab9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827787}
-
Rune Lillesveen authored
Bug: 988125 Change-Id: Iaec7cd80f39849da0a476c1653655b68cef1452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529103 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827786}
-
Sylvain Defresne authored
The new Widget requires Xcode 12.0 or higher to build, so assert that the version of Xcode used for the build is recent enough. Update the documentation to recommend the same version of Xcode as enforced by the code, and add tips on steps recommended to perform when updating Xcode. Bug: none Change-Id: I8b8fbf3d53ef2ab98c2407e28e46ce4321cd72f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527175 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#827785}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c231bde8eaa..f9474249e20d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,hkamila@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104817 Tbr: lgrey@google.com,hkamila@google.com Change-Id: Id7a993d832b83aeb21fb9d32268ded91771102f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540235Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827784}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 62972354. With Chromium commits locally applied on WPT: e5ccea4e "[LayoutNG] Carry over incoming inline break token when no new lines." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I856a68377255f0ef01779bfaa263ed57d083c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540366Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97868bd80a1f..dc4637c1a983 2020-11-16 tvanderlippe@chromium.org Update escodegen and recast 2020-11-16 jacktfranklin@chromium.org [DataGrid] fix stretching of table rows 2020-11-16 kimanh@chromium.org [e2e] Temporarily skip flaky shortcuts test 2020-11-16 kimanh@chromium.org [e2e] Temporarily skip flaky browser tests 2020-11-16 tvanderlippe@chromium.org Use TypeScript-authored files in network/ 2020-11-16 kimanh@chromium.org [LMI] Fix resizing issues in CSS 2020-11-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-16 kimanh@chromium.org [LMI] Add ls for localization and fix ValueInterpreterDisplay view 2020-11-16 tvanderlippe@chromium.org Fix ESLint tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1110202,chromium:1125968,chromium:1149334,chromium:1149346 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia1aae48d5221498a23779298cf197cccce724721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827782}
-
Thiabaud Engelbrecht authored
received. This is already obeyed in the code, but not enforced. Add DCHECKs to make it explicit. Bug: 1142834 Change-Id: I08c6ec08563c662fb5f98be6c965721655c87fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535611 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827781}
-
Dylan Cutler authored
the resulting cookie is not canonical. This unit test coverage will prevent future changes from reintroducing the crash that caused http://crbug.com/1146386. Bug: 1146386 Change-Id: I86f2196a6aa2d73b97cee0525cff026ce6e1a1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536983Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#827780}
-
Javier Ernesto Flores Robles authored
Add missing strings in the generated files. Set keys type as LocalizedStringKey to enable lookups. Wrap small widgets so they act as one whole tap target. Bug: N/A Change-Id: Ife034a1913d4417a71352acabf99c2f77a324d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539401Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#827779}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59bafeeaa7de..0fc077e0651c 2020-11-13 herb@google.com use SkMask::Format in SkGlyph and SkScalerContextRec 2020-11-13 bsalomon@google.com Remove unused copy-to-external YUV SkImage factories. 2020-11-13 stani@google.com Skottie perf metric improvements 2020-11-13 scroggo@google.com Revert "SkAndroidCodec: Support decoding all frames" 2020-11-13 scroggo@google.com Revert "SkAnimatedImage: Use fSampleSize" 2020-11-13 johnstiles@google.com Simplify the ModifiersPool class. 2020-11-13 hcm@google.com add M88 release notes 2020-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 47b3db22be33 to 9eff98952674 (36 revisions) 2020-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2cd5dabd to 3fae5295 (1029 revisions) 2020-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f3c829047220 to b6f4d53126d3 (9 revisions) 2020-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4804ac8724ff to e4c1a25cc679 (6 revisions) 2020-11-12 nifong@google.com Deprecate some debugger bindings in favor of ones that better serve the lit html debugger 2020-11-12 scroggo@google.com SkAnimatedImage: Use fSampleSize 2020-11-12 scroggo@google.com SkAndroidCodec: Support decoding all frames 2020-11-12 jvanverth@google.com Switch to using GrMtlBackendContext for GrDirectContext creation. 2020-11-12 scroggo@google.com SkAnimatedImage: Reject invalid crops 2020-11-12 herb@google.com make constexpr variants for SkCLZ/SkCLT and similar functions 2020-11-12 scroggo@google.com Handle EXIF orientation in SkAnimatedImage 2020-11-12 fmalita@chromium.org [skottie] Fix font style parsing 2020-11-12 herb@google.com don't use MASK_FORMAT_UNKNOWN to represent scaler context state 2020-11-12 mtklein@google.com Reland "add ERMS (enhanced rep mov/sto) SkOpts slice" 2020-11-12 brianosman@google.com Test & implement exponential intrinsics 2020-11-12 reed@google.com mark bitmap immutable in bench 2020-11-12 brianosman@google.com Implement two-argument atan in public SkSL, improve GM 2020-11-12 johnstiles@google.com Improve performance of skia_compile_processors. 2020-11-12 hcm@google.com Update Skia milestone to 89 2020-11-12 mast@google.com Remove windows:enabled from skia_deps 2020-11-12 mtklein@google.com support NDK r22 beta 2020-11-12 djsollen@google.com Revert "make quickReject treat empty rects and paths the same" 2020-11-12 mtklein@google.com Revert "add ERMS (enhanced rep mov/sto) SkOpts slice" 2020-11-12 kjlubick@google.com [canvaskit] Roll to 0.20.0 2020-11-12 adlai@google.com Remove intermediary RenderTaskDAG class 2020-11-12 robertphillips@google.com Remove GrSurfaceContext::flush calls ... 2020-11-12 jlavrova@google.com Revert "Some testing images in Google3 look slightly different with this change. Need to change them, too." 2020-11-12 johnstiles@google.com Update skslc to compile multiple files during one invocation. 2020-11-12 mtklein@google.com add ERMS (enhanced rep mov/sto) SkOpts slice 2020-11-12 mtklein@google.com add arm64 mac builders 2020-11-12 kjlubick@google.com [canvaskit] Revert raster change. 2020-11-12 scroggo@google.com Handle EXIF orientation in SkAnimCodecPlayer 2020-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 019feda602ec to 4804ac8724ff (9 revisions) 2020-11-12 kjlubick@google.com [canvaskit] Fix the build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Test: Test: Ran tests on wearos and android.Test: Test: Test: MultisampledRenderToTextureES3Test.RenderbufferBlitFramebufferTestTest: Test: PbufferTest.ClearAndBindTexImageSrgb*VulkanTest: Test: VulkanPerformanceCounterTest.DepthStencilTextureClearAndLoadTest: Test: dEQP.KHR_GLES31/core_texture_buffer_texture_buffer_errorsTest: Test: mTest: Test: mmm external/skia Change-Id: I05779f0f235eae56d41a10300caaf90d4094fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537034Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827778}
-
Fabian Sommer authored
Add notification UI to SecurityTokenSessionController. These notifications appear the first time a user was logged out / their session was locked because of the SecurityTokenSessionBehavior policy. A profile pref is used to save whether a user has already seen such a notification once. If the session is locked, the controller creates the notification directly. If the user is logged out, a local state pref is used to schedule the creation of the notification. Bug: 1131450 Change-Id: I27da14ec8d7a2fed53c46764ef64d156f399e86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505877Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#827777}
-
Yutaka Hirano authored
Proposal: https://docs.google.com/document/d/1XYsa2W1zjWIvrpuAq7IA1wEGZIvbJLoiPF6rMob01Tg/edit Bug: 1147816 Change-Id: I0c030b7ba142ceb72a4cc8a2425bad2118689f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532016 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#827776}
-
Dale Curtis authored
There are a lot of crashes happening due to an invalid source, so it appears clear that AudioUnitStop() isn't always working. This adds a lock so that we do nothing in this case and attempts to remove the InputProc callback during Close() to prevent UaF on the stream itself Fixed: 737527 Change-Id: I97f3442f105317a6214722455dab497280c07336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532775 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827775}
-
Juanmi Huertas authored
The ReadARGBPixelsAsync expects that the Context being passed in has a RasterInterface. In the 3D path (WebGL), due to current limitations, there is a copy of the internal texture being made, encapsulated into an external canvas resource, and provided with a Context that does not have a RasterInterface. This CL adds an special handling for the WebGL offscreenCanvas case, and it gets the SharedGPUContext to produce the rendering, to avoid using the one provided from the image. As this CL is handling a Crash in a corner case in WebGL it has been proven hard to find a proper test for this. I'm adding a new DCHECK to make this more robust. Bug: 1148345 Change-Id: I7aff4bf7182233543533c33c42bfd4a36a7d4a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535892Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#827774}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99df1af2aed6..62a9a329373a 2020-11-16 danilchap@webrtc.org In Av1 packetizer set marker bit with respect of end_of_picture flag 2020-11-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c2eb9777..32410c4f (827634:827734) 2020-11-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b7fa55af..c2eb9777 (827532:827634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I241d00d58756ce3b74b04e056ec590970481f8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827773}
-
Yunke Zhou authored
Bug: 1133203 Change-Id: Ib30cb16ac7705f575452b2f22ef96060443a351a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537530Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#827772}
-
Tanmoy Mollik authored
Batch tests in BookmarkModelTest to reduce runtime of chrome_public_test_apk. Bug: 1145843 Change-Id: Ide04b1754e0c3c6992d38e23bae40bc5c5cd19e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526445Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827771}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605506334-8e819d7371bb25516f19d1591aa22eeb3af9fbfb.profdata to chrome-linux-master-1605526350-6d778517c3f2c76fab9ee032fc1ed855eedd9044.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7cd524fb075a9cd0f109ebe0befde02342d5f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827770}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f0f67f786d1..97868bd80a1f 2020-11-16 tvanderlippe@chromium.org Update `@types` packages 2020-11-16 tvanderlippe@chromium.org Use TypeScript-authored files in resources/ 2020-11-16 petermarshall@chromium.org [typescript] TypeScript-ify profiler/HeapTimelineOverview.js 2020-11-16 aerotwist@chromium.org [unit test] Adds is_debug check for coverage reports 2020-11-16 petermarshall@chromium.org [tests] Run chromium before prompting during interactive e2e mode 2020-11-16 sigurds@chromium.org [ts] Type-check resources/ApplicationPanelSidebar.js with TypeScript 2020-11-16 alcastano@google.com Add title to DataGrid cells If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1101784,chromium:1148296,chromium:1148760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6d1191db931c85008fe7ede6a5c08865e2bbb385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827769}
-
Asami Doi authored
This CL just renames `omt-worker-fetch` directory to `plz-dedicated-worker`. There is no change in tests themselves. Bug: 906991 Change-Id: I83794034f6fe163482b3b55d7c040d6a0464450b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537251 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827768}
-
Ehimare Okoyomon authored
Create function to add a strikethough overlay on top of icon if the permission is blocked. Screenshots: crbug.com/1077766#c96 Bug: 1077766 Change-Id: I6d081ad69c4817be3158aacca9f8d6997a12d36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526302 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#827767}
-
Chris Lu authored
Bug: 1107489 Change-Id: Ib5686a3200dbd2783854f8dc19dbd9c3618d8f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512382 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827766}
-
Nohemi Fernandez authored
Improve structure and documentation for AccountConsistencyServiceTest. These tests are crucial to ensure that sign-in cookies are properly set within the framework. With the recent and upcoming changes in ensuring identity consistency across platforms, we, as developers, need to ensure that this code continues to work as expected. Bug: 1148814 Change-Id: I734e7c150c612f11371079c60e61f8e3b2bdc230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536445Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#827765}
-
Rohit Rao authored
Multiple content suggestions tests load pages with the same title, and tab grid cells appear to stick around from test to test. They are hidden and in the tab grid behind the BVC, so they can't be seen by the user, but they are visible to EG matchers. EG tests were failing because the same page title was shared by multiple tests, and the second test was seeing duplicate labels between the NTP entry it was trying to tap and a hidden tab grid cell from the previous test. This was not turning the bots red because the test passed on retry, when run in isolation. This CL fixes the test failures by adding grey_sufficientlyVisible() to the matcher, so that it no longer matches against hidden tab grid cells. BUG=1148938 Change-Id: If0d8b958cace5aa34dfe5e2ed854620b5adc51ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538116Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827764}
-
Boris Sazonov authored
This reverts commit f4a2ff7e. Reason for revert: https://crbug.com/1149027. Original change's description: > [Test] Refactor BookmarkPersonalizedSigninPromoDismissTest > > Refactor BookmarkPersonalizedSigninPromoDismissTest to use > AccountManagerTestRule and ChromeActivityTestRule instead of > SyncTestRule so that it can be batched easily. > > Bug: 1145843 > Change-Id: Ia005508ccd84c439b04b25a65af0930b5a15ee0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527021 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827278} TBR=treib@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145843, 1149027 Change-Id: I59fad358639d2b85378dfff422fbe9adf7b75a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540287Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827763}
-
Christoph Schwering authored
This reverts commit 2239f82c. The CL crrev.com/c/2506575 is broke the aeropostale and bestbuy captured-site tests starting with build 3111: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel?limit=200 Bug: 1101280 Change-Id: Iaab775e74c8ec5c20616973f031ce6597deb2290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538213 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#827762}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605484714-baf112bc95e811272919ec65bd3b64ed1dae8200.profdata to chrome-win32-master-1605506334-6616cc9fde8be6f4a346f03421646a2f18c74624.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I964d5d8cc106c92eb755539c12d9ffbbec734db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827761}
-
Karandeep Bhatia authored
In preparation of adding support for session scoped rules (which are not file backed), split the class FileBackedRulesetSource into two classes: a RulesetSource base class and a FileBackedRulesetSource derived class. Since the session scoped ruleset will not be file backed, it will use the RulesetSource class. BUG=1043200 Change-Id: Ia06d4b2ca956de516a542aa3dc69bc70cbe1829d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495787 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827760}
-
Sylvain Defresne authored
Conceptually, //ios is on top of //base, so having a dependency from //base/ios on //ios is breaking the layering (this also make it difficult to use //base without using all of Chromium). Implement IsMultiwindowSupported() and IsSceneStartupSupported() by checking for the scene API manifest information in the app Info.plist which is more robust as it will work for any iOS app build on top of //base that set the information in Info.plist even if they do not re-use the rest of Chromium. Bug: none Change-Id: I5ea006ea617c284dc114b2f8f8ecd6eb2f2dcc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529122 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#827759}
-
Henrik Boström authored
This CL adds two tests that were discovered missing while reviewing the test coverage, both of which we PASS: - getStats(tracks) throws if multiple senders have the same track. (Actually it turns out such a test already existed, the old one is removed because it was asserting unnecessarily many things.) - RTCStats.timestamp should increase with time elapsed. This CL also makes exsting tests more behavior driven. For example, a test that advertises itself to test that "report containing peer-connection stats and outbound-track-stats" should not fail because we have not implemented RTCCodecStats.sdpFmtpLine - this is a different behavior. As such, tests that are designed to test the existence of a stats object are updated only to verify that. What the old tests were verifying - that the ENTIRE REPORT is valid and complete - are moved and tested in a separate test that asserts everything. These tests we still fail because of sdpFmtpLine. Lastly, the outbound-rtp tests are updated to perform an O/A exchange. If the senders have not been negotiated to send, there doesn't exist an encoder or RTP packetizer and as such we shouldn't expect to see outbound-rtp objects yet. Bug: chromium:1148286 Change-Id: I50d476f1af41cfae80c77486481e3de06a1d8f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534911Reviewed-by:
Philipp Hancke <philipp.hancke@googlemail.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827758}
-
Robbie Gibson authored
The TabStrip uses a CGAffineTransform to implement RTL. Because of this, when we display the snapshot for the thumb strip transition, the CGAffineTransform for the transition also needs to take the RTL behavior into account. Bug: 1094335 Change-Id: I736a2b2b74781407f8b685bfb21bef81ab8c0ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536444 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#827757}
-