- 04 Jan, 2017 40 commits
-
-
liaoyuke authored
Test files need to be known to Xcode for proper indexing and for discovery of tests function for XCTest, but the compilation is done via ninja, which causes Xcode fail find object files when trying to link. This CL configures the build settings of XCTest targets to trick Xcode to blindly return success when trying to link object files. BUG=614818 Review-Url: https://codereview.chromium.org/2594033002 Cr-Commit-Position: refs/heads/master@{#441500}
-
qyearsley authored
Background: The recent change https://github.com/w3c/web-platform-tests/commit/758f6c45dd335e276ab822ef5d96ac31398b76e9 updated wpt-tools to include https://github.com/w3c/wpt-tools/commit/8777171a5568e9fa967ef7a807dc400d89a07637, which changed some things about the manifest format and also the way that the manifest update is done. After that change, the manifest update script looked at all files in the current repo, which in our case is the whole Chromium repo. This CL resolves this by passing the flag --work to the manifest script. BUG=678077 Review-Url: https://codereview.chromium.org/2613753002 Cr-Commit-Position: refs/heads/master@{#441499}
-
msw authored
Consolidate WmShell, etc. to always use mojo (app list -> presenter). Remove ShellDelegate::GetAppListPresenter and classic/shell members. Remove AppListPresenterMus, combine AppListPresenter and *Impl. Move delegate factory ownership to the presenter impl object. Add app_list::mojom::AppList functions for reporting visibility changes. Add helpers to get ash's cached visibility state, reported by chrome. Add TestAppListPresenter to track ash->chrome calls for tests. Add TestAppListViewPresenterImpl for tests of impl/delegate behavior. Add TestAppListViewDelegateFactory for ash test and shell users. Add an ExampleAppListPresenter for ash_shell_with_content. Add an integration interactive ui test; enable another. Update tests; cleanup ifdefs (ash is Chrome OS only now). TODO: App list toggling in --mash causes ink drop DCHECKs (unchanged by this CL) TODO: Consolidate and simplify more app list code... BUG=557408 TEST=No Chrome OS app list behavior changes. R=mfomitchev@chromium.org,xiyuan@chromium.org,derat@chromium.org,tsepez@chromium.org,yzshen@chromium.org Review-Url: https://codereview.chromium.org/2576913002 Cr-Commit-Position: refs/heads/master@{#441498}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/dc39e377e1a3..0ef7ba086f9e $ git log dc39e377e..0ef7ba086 --date=short --no-merges --format='%ad %ae %s' 2017-01-04 npm Kill render_int.h Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2614823002 Cr-Commit-Position: refs/heads/master@{#441497}
-
ccameron authored
Move all uniform locations into a single base class (but leave configuring them to the sub-classes). Merge all the head and body of vertex shaders into one segment. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2610803002 Cr-Commit-Position: refs/heads/master@{#441496}
-
tedchoc authored
To work around crbug.com/273763, we were previously removing all text after the selection end if the selection range was entirely before the autocomplete text. On certain keyboards, this could result in deleting new user text that differs from the previously autcompleted text. Now, we only clear the text if it matches the autocompleted text. I verified that this fix did not regress the HTC issue (tested on 4.2.2 w/ the Sense keyboard), and it also address the Japanese IME issue mentioned in the new bug. BUG=569144 Review-Url: https://codereview.chromium.org/2617493003 Cr-Commit-Position: refs/heads/master@{#441495}
-
rdevlin.cronin authored
TBR=mfomitchev@chromium.org NOTRY=true BUG=678388 Review-Url: https://codereview.chromium.org/2612133002 Cr-Commit-Position: refs/heads/master@{#441494}
-
mek authored
Calls out to the mojo localstorage implementation for querying and deleting local storage. Also avoids initializing the mojo implementation unless it is actually enabled. BUG=586194 Review-Url: https://codereview.chromium.org/2611743002 Cr-Commit-Position: refs/heads/master@{#441493}
-
mfomitchev authored
Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content. - Use SurfaceLayers in embedders and Window Manager to properly position the embedded content in the layer tree. - WM no longer uses underlay surfaces for window decorations. Instead they are submitted to Mus as part of the WM's surface. - FrameGenerator now only creates SurfaceDrawQuad for the top-level window rather than recursively creating SurfaceDrawQuad for all windows in the window tree, since all surfaces are now part of the tree rooted at the surface of the top-level window. BUG=672943,669964 Review-Url: https://codereview.chromium.org/2580063002 Cr-Commit-Position: refs/heads/master@{#441492}
-
reillyg authored
This change replaces the PermissionService::GetNextPermissionChange method with a PermissionObserver interface that more closely matches the permission subscription model that exists in the browser process as it is unnecessary for the client to throttle these low-frequency updates. This also makes it cheaper (1 message vs. 2) to send an update to the renderer. BUG=677774 Review-Url: https://codereview.chromium.org/2573573002 Cr-Commit-Position: refs/heads/master@{#441491}
-
avi authored
GetDefaultStoragePartition() is here to stay. BUG=none Review-Url: https://codereview.chromium.org/2614813002 Cr-Commit-Position: refs/heads/master@{#441490}
-
mariakhomenko authored
BUG=661276 Review-Url: https://codereview.chromium.org/2611023002 Cr-Commit-Position: refs/heads/master@{#441489}
-
robertogden authored
BUG= Review-Url: https://codereview.chromium.org/2610003003 Cr-Commit-Position: refs/heads/master@{#441488}
-
jwd authored
end_date is a replacement for expiry_date, which is deprecated by this change. The difference is that end_date is acts as a normal filter, and causes study to not be created when the date is past. expiry_date caused the study to be created, and forced to the default group. This change introduces a generic default group name, which is used for the field trial API when a study doesn't specify one. BUG=677976 Review-Url: https://codereview.chromium.org/2614443002 Cr-Commit-Position: refs/heads/master@{#441487}
-
robhogan authored
Also, ensure the selected text is painted correctly when an ellipsis is present in a mixed-flow context (e.g. ltr text in an rtl container). BUG=642454, 642450, 642460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2594983002 Cr-Commit-Position: refs/heads/master@{#441486}
-
xunjieli authored
This CL instruments SdchManager using MemoryDumpProvider. Even though SDCH might be unshipped (see blink-dev), it is useful to get an idea of how much memory dictionaries cost. BUG=669108 Review-Url: https://codereview.chromium.org/2541073003 Cr-Commit-Position: refs/heads/master@{#441485}
-
khorimoto authored
[CrOS Tether] Create BleScanner, a class which scan BLE advertisements and identifies nearby devices. This class provides an API for registering or unregistering RemoteDevices. As long as at least one RemoteDevice is registered, a discovery session is active. If an advertisement from a registered RemoteDevice is scanned, observers are notified. BUG=672263 Review-Url: https://codereview.chromium.org/2604063003 Cr-Commit-Position: refs/heads/master@{#441484}
-
twellington authored
Adds HistoryAdapterTest and HistoryManagerTest with tests for removing history items and basic tests for initializing the adapter. Also fixes two bugs related to removing items: - Remove header if only 1 item is remaining so empty view is shown - Set item positions after removing an item BUG=654071 Review-Url: https://codereview.chromium.org/2603403003 Cr-Commit-Position: refs/heads/master@{#441483}
-
liaoyuke authored
Previously, our generated Xcode project has the issue that Xcode couldn't find our xctests. And to fix it, one must first find the list of xctest files under each of the application targets and then associate them with the corresponding xctest target. This CL enables identifying application targets and also find the list of xctest files (xctests.mm and egtest.mm) under them recursively. BUG=614818 Review-Url: https://codereview.chromium.org/2574643002 Cr-Commit-Position: refs/heads/master@{#441482}
-
rsleevi authored
SHA-1 is being phased out, and beginning with M57, SHA-1 certificates signed by locally installed trust anchors is being disabled by default. To re-enable, Enterprises should set an EnableSha1ForLocalAnchors policy to allow it. However, for platforms without enterprise policies, or for embedders, this raises a question about what the default state should be - enabled or disabled. As Chrome itself expects there to be non-trivial impact (thus, the policy, supported until 1 Jan 2019), it is safer to leave the current behaviour, enabling SHA-1 for these certs, on by default, and leave it to embedders to disable (via the SSLConfig/SSLConfigService). If embedders support preferences, that's seen as sufficient support to enable some degree of run-time control/flexibility, thus the default is moved from //net to //components/ssl_config. Embedders using //net will continue to support SHA-1 anchors by default, while embedders that include //components/ssl_config (and use it) will disable it by default. BUG=673036 Review-Url: https://codereview.chromium.org/2613533004 Cr-Commit-Position: refs/heads/master@{#441481}
-
gogerald authored
BUG=661357 Review-Url: https://codereview.chromium.org/2592733002 Cr-Commit-Position: refs/heads/master@{#441480}
-
marcin authored
Review-Url: https://codereview.chromium.org/2608733005 Cr-Commit-Position: refs/heads/master@{#441479}
-
dtapuska authored
We want to align all touchmoves regardless of whether they cause a regression in scroll start. The expected regression would on average half a frame. BUG=642368 Review-Url: https://codereview.chromium.org/2612823002 Cr-Commit-Position: refs/heads/master@{#441478}
-
rtoy authored
Manually convert audiobuffer.html to use testharness BUG=676355 TEST=audiobuffer.html Review-Url: https://codereview.chromium.org/2595073002 Cr-Commit-Position: refs/heads/master@{#441477}
-
rtoy authored
Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-one-sample-loop.html Review-Url: https://codereview.chromium.org/2591383002 Cr-Commit-Position: refs/heads/master@{#441476}
-
rtoy authored
Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-grain.html Review-Url: https://codereview.chromium.org/2595153002 Cr-Commit-Position: refs/heads/master@{#441475}
-
sky authored
It overlaps with properties, and properties add type safety. BUG=none TEST=none R=ben@chromium.org Review-Url: https://codereview.chromium.org/2610203002 Cr-Commit-Position: refs/heads/master@{#441474}
-
rjshade authored
There are no flags to be updated. Migrate StringPiece::AppendToString to StrAppend Merge internal change: 143299373 https://codereview.chromium.org/2617523002/ Add tests for QuicTextUtils::HexEncode and HexDecode which use non-ASCII printable data. Merge internal change: 143126254 https://codereview.chromium.org/2616493003/ R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2618433002 Cr-Commit-Position: refs/heads/master@{#441473}
-
wkorman authored
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2608163007 Cr-Commit-Position: refs/heads/master@{#441472}
-
eroman authored
BUG=677863 Review-Url: https://codereview.chromium.org/2611933003 Cr-Commit-Position: refs/heads/master@{#441471}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/6745f96fab41..dc39e377e1a3 $ git log 6745f96fa..dc39e377e --date=short --no-merges --format='%ad %ae %s' 2017-01-04 tsepez Add missing operator<() to CFX_RetainPtr. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2614793002 Cr-Commit-Position: refs/heads/master@{#441470}
-
sunyunjia authored
Previously, we implement scrollIntoView by scrolling the intersection of the viewport and the content. However, when the content is not visible in the viewport, e.g. outside boundary and the viewport's overflow attribute is hidden, the intersection would be empty and the browser would stop the scrolling logic. In this case, we presume the webpage wants to scroll the position of the content but for some reason doesn't want to show it. In this patch, we scroll the content's position for this special case. BUG=673396 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2576963002 Cr-Commit-Position: refs/heads/master@{#441469}
-
mariakhomenko authored
BUG=656193 Review-Url: https://codereview.chromium.org/2614783002 Cr-Commit-Position: refs/heads/master@{#441468}
-
mfomitchev authored
TBR=wjmaclean,rdevlin.cronin BUG=678267 Review-Url: https://codereview.chromium.org/2616693002 Cr-Commit-Position: refs/heads/master@{#441467}
-
xunjieli authored
so AddOwnershipEdge can attribute memory correctly between URLRequestContexts. See the following doc for more details on why it is needed. https://docs.google.com/document/d/1-dmr_dVgO090Y5_3K9itjsE0MsBTmbqwovu6lup1i14/edit BUG=669108 Review-Url: https://codereview.chromium.org/2560593002 Cr-Commit-Position: refs/heads/master@{#441466}
-
jeffcarp authored
Revert of Make run_webkit_tests random order by default for all platforms (patchset #2 id:20001 of https://codereview.chromium.org/2591933002/ ) Reason for revert: fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots. Original issue's description: > Make run_webkit_tests random order by default for all platforms. > > BUG=671805 > R=dpranke@chromium.org,qyearsley@chromium.org > > Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95 > Cr-Commit-Position: refs/heads/master@{#441424} TBR=dpranke@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671805 Review-Url: https://codereview.chromium.org/2617563002 Cr-Commit-Position: refs/heads/master@{#441465}
-
lhchavez authored
Now that Mojo can generate the min_version information automatically, migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to GET_INTERFACE_FOR_METHOD(), which does not require the explicit version number to be passed. BUG=649782 TEST=git try Review-Url: https://codereview.chromium.org/2599673005 Cr-Commit-Position: refs/heads/master@{#441464}
-
martiniss authored
BUG=677311 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2612673002 Cr-Commit-Position: refs/heads/master@{#441463}
-
zhaobin authored
[Presentation API] Resolve PresentationRequest::reconnect() with existing presentation connection if such connection exists Check if any presentation connection with specific presentationUrl and presentationId exists in current browsing context. If so, resolve reconnect() with existing connection instead of creating a new connection. BUG=677540 Review-Url: https://codereview.chromium.org/2602523002 Cr-Commit-Position: refs/heads/master@{#441462}
-
thomasanderson authored
This CL rolls the sysroots after 3b607160. In addition, it also fixes a bug in build-and-upload.py which would cause the script to fail if not run in build/linux/sysroot-scripts. BUG=668205 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2599763004 Cr-Commit-Position: refs/heads/master@{#441461}
-