- 26 Nov, 2020 1 commit
-
-
James MacLean authored
This reverts commit 0ea7d517. Reason for revert: A fix for the problem that lead to this revert has been landed in r831153 and we need to re-enable this change to test it. Original change's description: > Revert "Origin isolation: enable by default" > > This reverts commit 824b062d. > > Reason for revert: Causing crashes with hosted apps in https://crbug.com/1141721. > > Original change's description: > > Origin isolation: enable by default > > > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI > > > > Further work on removing origin trial code and the flags is tracked in > > https://crbug.com/1148056 and https://crbug.com/1148057. > > > > Bug: 1042415 > > Change-Id: Icbeecd0b592c76d36e2111b8e4d8fe30dbb63343 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533145 > > Commit-Queue: Domenic Denicola <domenic@chromium.org> > > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826910} > > TBR=creis@chromium.org,alexmos@chromium.org,jochen@chromium.org,domenic@chromium.org,yoavweiss@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1042415, 1141721 > Change-Id: I428b190fc4c6bdf39de5ffb43226ba91851e7544 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553209 > Reviewed-by: Domenic Denicola <domenic@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829937} TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042415 Bug: 1141721 Change-Id: I6cf3211dc675bd2351c8dc6831e8d3e2495d8c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560907Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#831175}
-
- 25 Nov, 2020 39 commits
-
-
danakj authored
Step 3 for bug 1125106. This is a subset of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. The BeginNavigation() path does not read the same-document field when deciding its navigation type. However, a regression could conceivably allow the renderer to specify same-document, bypass our checks to move into a new RenderFrame/RenderProcess, and load a document in the wrong process. We drop BeginNavigation() messages from the renderer which have the same-document flag set. Then we verify in RenderFrameHostManager when we bypass from picking a RenderFrameHost, using the current one explicitly, that the NavigationRequest did not come from BeginNavigation(). R=nasko@chromium.org Bug: 1125106 Change-Id: I58d50f524bf948c5ca4f76c237c6fe32e7fcf4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558776 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831174}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/12af0f03..b8bd12af Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id0b3c99ba25936301cc4379f368e4a5370b74101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560833Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831173}
-
Sophey Dong authored
Bug: 1152119 Change-Id: Ifd622c16af140d799f5ccecd35e3d6a420bfee69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555471Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#831172}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I36449825112a19d53494c155b4d221c9ff951f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831171}
-
Gil Dekel authored
This CL exposes the path topology of a display via its DisplaySnapshot representation. This will later be used during display configuration fallback strategies. In addition, this CL adds three UMAs to track (two of them use the new exposed path topology property): 1) the number of configured external displays 2) the number of configured external displays that are connected via an MST. 3) the percentage of configured displays connected via MST (i.e. num of external MST displays over total num of external displays). Bug: b:170745518, 1105919 Test: display_unittests && ozone_unittests Change-Id: Ida7270e60ff8d5969e1664788e2dcf7831d52c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527955 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#831170}
-
Rafael Cintron authored
Lack of xrDestroySession entry in xrGetInstanceProcAddr was causing calls to xrDestroySession in code to crash and make it difficult to debug XR tests. This CL adds an entry for xrDestroySession. Change-Id: Ib6cfe2a5181fb328409ab54e60284da1cfb816e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561297Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#831169}
-
Anton Bikineev authored
Using base::ThreadPool was not safe and prone to deadlocks, which caused DCHECKs in base::CheckedLock to fail (https://bit.ly/3l0cd5p). This CL adds an ever running thread specific to pcscan tasks. Please note that to stay indepedent of //base/ (and the allocating BindOnce function), the C++11 thread API is used. Bug: 11297512 Change-Id: I8223d7f8875f3a256ccc7e87ba190720bcfb4074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556858 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831168}
-
Andres Medina authored
Bug: 1152807 Test: Manual build and run on linux. Change-Id: I8b82206d47995aa1b90e3196774535de8a0be9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560061Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andres Medina <medinaandres@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#831167}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04353ebb2005..31df00826801 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com,etiennep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1149681,chromium:1151505 Tbr: ramyan@google.com,etiennep@google.com Change-Id: I2f95208168fed8fbc62f111ca7455a4268d828d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560666Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3762a907c02..36f2a96290e7 2020-11-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I63bd6f2ec53ec8aafc2d45b4676e299f58d70d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560669Reviewed-by:
-
Dominic Farolino authored
This CL allows for the creation of an AgentSchedulingGroup(Host) per SiteInstance. The changes can be summarized as: - Parameterizing the MBI base::Feature into the following states: - Legacy mode - Enabled: AgentSchedulingGroup-per-RenderProcessHost - Enabled: AgentSchedulingGroup-per-SiteInstance - Modifying AgentSchedulingGroupHostUserData such that it holds an std::set of AgentSchedulingGroupHosts - Introducing a std::map<SiteInstance*, AgentSchedulingGroupHost*> to preserve the invariant that no SiteInstance should ever request multiple AgentSchedulingGroupHosts during its lifetime, from the same RenderProcessHost - When the base::FeatureParam is in the ASG-per-RPH state, we DCHECK that only a single AgentSchedulingGroupHost exists in the set of owned hosts - When the base::FeatureParam is in the ASG-per-SI state, we DCHECK that a SiteInstance is never requesting an AgentSchedulingGroupHost more than once from the same RenderProcessHost is enabled. We do this by maintaining the std::map mentioned above, to preserve this invariant. Design doc: https://docs.google.com/document/d/1q-Tvdpf0bDsbzgO9lNlmEEEXMYFvgN81fN6xLFuBJPA/edit Bug: 1149830 Change-Id: I14055ecd8675b695d202924c6431dc59a6e2f059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536756Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
zhiyuancai authored
Bug: 1146636 Change-Id: I33159beed89636fd09367c2466dbc6844ab1be14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561220Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#831163}
-
rajendrant authored
Moves the PreviewsResourceLoadingHints interface away from blink, since its not used in blink. This also refactors the subresource redirect interface out of PreviewsResourceLoadingHints. Bug: 1152527 TBR: dom@chromium.org Change-Id: Id3036c3ef91240cb9fb986f06cf478780e18492c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556566 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#831162}
-
Sigurður Ásgeirsson authored
This reverts commit 0dadfa21. Reason for revert: Top crasher on Canary. Original change's description: > PM: Enable service worker relationships by default. > > Bug: 1143281 > Change-Id: I5107ca4d324248456470f5880429d10760d77076 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557223 > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830661} TBR=pmonette@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152860, 1143281 Change-Id: Ie1e445d3da4185e65bfb8f895b6d63468b01be1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561538Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#831161}
-
Kyle Horimoto authored
Previously, we'd just call DisconnectFromEndpoint() and invoke the callback immediately. This CL adds a "disconnecting" state which waits for the OnDisconnected() callback to be called. This works around a race condition in the Nearby Connections library during shutdown. Because we're now waiting for an event to be called, this CL also adds timeouts for each step of this flow. This CL also tweaks the log level for a few logs to help with debugging. Bug: 1152609 Change-Id: Ib23c606e4658f5ad1f5fbf013891d80888683530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561469Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#831160}
-
Karandeep Bhatia authored
Remove //extensions/browser/api/declarative_net_request/filter_list_converter:* from being excluded from gn checks. BUG=None Change-Id: Icc9f38b062823e5fcb5f700e3f26d4ae71e7c03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557725 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#831159}
-
spdonghao authored
Bug: 1139515 Change-Id: I8efb2168d15a78c48eb9bcd28fd579004ad0fbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560542Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Alexander Bolodurin authored
This is a variant of CopyFile to use when the file paths are not accessible, e.g. passing a file descriptor across containers. Change-Id: I87a674b389139ced34cfc3ece11df5c2765df640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536652 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
-
Pavel Yatsuk authored
This CL adds logic in SingleActionMessage to dismiss the message when the user taps on primary button. BUG=1152520 R=lazzzis@chromium.org Change-Id: I6f32c69278cd613f47839af7c70e8d41db99a848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560829 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#831156}
-
Gavin Williams authored
Adds a link button after a successfully scan that calls the ScanningBrowserProxy to open the Files app. The last page of the scanned in the scan job will be highlighted. A follow up CL will use the return value from the call to showFileInLocation() to show an error-state when Files app fails to open. http://screen/BANhubFawHU6oLM Bug: 1059779 Change-Id: I0368c91393382f5f46ea21dd530801e12a4035cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546102 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#831155}
-
Daniel Nicoara authored
Bug: 1152873 Test: Run cast_accessibility_unittests Change-Id: I01dc08d5418d779de60fb1bdf41141b7121d3eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561579Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#831154}
-
W. James MacLean authored
Prior to this CL, when we record opted-in origins we did it using the site_url() value from the site's SiteInfo. But that causes problems for hosted apps, where the effective and actual urls don't match --- this leads to mis-matches in CanAccessDataForOrigin when it compares expected and actual process locks. Bug: 1141721 Change-Id: If1dfd6752a66686bc29afc0a60d64dee915fa504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558744 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#831153}
-
Ajit Narayanan authored
The setting controls the display of a navigation panel beside the current focus ring, as well as related navigation functionality (such as auto-dismiss on completion of reading and sentence navigation). The setting is only shown if the #select-to-speak-navigation-control flag is enabled. Bug: 1143830 Change-Id: I1f275a26cdde7c4bf6ea1104a6e2f34ab2acff6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556761Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Cr-Commit-Position: refs/heads/master@{#831152}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/51b74afb84d4..f2efb80bc316 2020-11-25 michaelludwig@google.com Clamp really big recording bounds to safe ints 2020-11-25 michaelludwig@google.com Preserve dithering for SkImageFilters::Shader 2020-11-25 johnstiles@google.com Remove accidentally-commited conflict markers. 2020-11-25 johnstiles@google.com Add early-outs to buildCandidateList. 2020-11-25 brianosman@google.com IWYU fix for sk_app/Window.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Id7d51aee3e2fe544a5ea06092a67da3264570e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560664Reviewed-by:
-
Lukasz Anforowicz authored
This CL removes |force_ignore_site_for_cookies| from IPC payloads, making it impossible for a compromised renderer process to spoof/forge |force_ignore_site_for_cookies|. In particular, the CL removes a |force_ignore_site_for_cookies| from network::ResourceRequest and from content::mojom::BeginNavigationParams. The CL preserves the old behavior, by moving the |force_ignore_site_for_cookies| calculations that used to be performed by ChromeExtensionsRendererClient::WillSendRequest. These calculations are moved into URLLoader::ShouldForceIgnoreSiteForCookies, which can see if an extension has special access to the destination URL based on an OriginAccessList that is already maintained by the NetworkContext. Relevant tests: - *ExtensionSameSiteCookiesTest* - *ThirdPartyCookiesAllowedForExtensions* Bug: 927967, 1068792 Change-Id: Id794fca957f44680e21150ac5d662c2e3ee958d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499162 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
-
Michael Hansen authored
In a recent CL (crrev.com/c/2548454) we switched from iron-list to dom-repeat for displaying the list of contacts on the device visibility page. This cleans up some remaining references and support for iron-list. Bug: b:168841167 Change-Id: If112c4f134dab370a08d8911aa45e090e4272ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560933Reviewed-by:
-
Lan Wei authored
Use testdriver Action API to simulate key actions in css/selectors/focus-visible-012.html. Bug: 1145677 Change-Id: I14a5362801ac407ad6129d02feb7003960485cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551229 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#831148}
-
danakj authored
Step 1 for bug 1125106. This is a subset of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. A same-document navigation means that a Frame has a Document `A` loaded inside it, and we want to navigate by mutating the state of `A` without reloading it. If there is a cross-document navigation in flight for the FrameTreeNode already (either inside the current RenderFrameHost, or in a speculative one), then by the time the same-document navigation would complete, the Document `A` would be gone, replaced by the cross-document navigation. In that case, make the would-be same-document navigation a cross- document one from the get-go to avoid this race condition, and having the renderer need to request the navigation to restart since it has changed its document in the meantime. Following CLs will remove that request from the renderer (in blink's DocumentLoader) and replace it with a CHECK. R=alexmos@chromium.org, creis@chromium.org Bug: 1125106 Change-Id: I413d455e1e8bf69689b79156a5c7e85b656c4617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552584 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Peter Kasting authored
This is a reland of e0e81ba9 Original change's description: > More inclusive terminology for chrome/browser/win/conflicts/. > > Bug: 1097283 > Change-Id: I570f98b1f42487aff2696c50f87fd0832667379b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547620 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830830} Bug: 1097283 TBR: chrisha, gab, jwd, tedchoc, pmonette, aee Change-Id: I8139a42cb63cdcb1d645ba9ead72bf086409d10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560906 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#831146}
-
dpapad authored
The |flattenhtml| property of grd file entries is considered deprecated and new usages of it are discouraged. Removing unnecessary usages, both to: - discourage copy/paste usage - reveal which files actually still rely on it The files that don't need it were detected by locally modifying Grit, to compare the file contents before and after flattenhtml is applied. In this CL only affecting files that don't need flattenhtml=true nor preprocess=true. Cases where |flattenhtml| can be removed, but |preprocess| is still needed will be addressed in a follow-up. Bug: 1152343 Change-Id: Iee0cb3fd9b9da0cc82a04c4fbd2e2e8a69f4cdc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555879Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#831145}
-
Jeremy Roman authored
It is mostly accessed for read, which means that the memory locality is likely to be more useful than pointer stability or fast insertions. At least one call site to base::FeatureList has indicated concern about the access times, and base/containers/README.md recommends flat_map for cases such as this. Two fields in a private struct must be non-const for this to work, since having const fields makes them not assignable and thus not usable in a vector. Change-Id: Iaed0d07e5dd765e592d57f6ff5b38b2b48040119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560060Reviewed-by:
-
Thomas Guilbert authored
Currently, web authors new to the WebCodecs API can forget to call destroy() on frames when they are done with them. This can result in some non-obvious but easy to fix stalls. We want to display a console error message when a frame is GC'ed without having been destroyed. This would involve accessing the ExecutionContext from the VideoFrame (or VideoFrameHandle) destructor, which is not permitted, due to non-deterministic GC order. Using a prefinalizer is also not recommended, due to how often VideoFrames are created, and its potential performance impact on the GC. Instead, this CL adds a VideoFrameLogger, which has 1:1 relationship with its ExecutionContext. The logger periodically polls if auditor flag has been set, and logs a console error message when it has. A reference to this flag is given to all VideoFrameHandles creating within the context. When a handle is destroyed without having invalidated, it means destroy() was never called on its VideoFrames, and the auditor flag is set to true. This is safe to do, because neither the flag or the handles are GC'ed. Note: VideoFrames will report their leaks in the context in which they are created or cloned. This means that a frame created on the main window, serialized to a worker, and cloned in the worker context would report a message through the main context and the worker context. Bug: 1149542 Change-Id: Ic97e4c88c6aea45f4e83c094b7acc5ab9671fe41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553403 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831143}
-
John Lee authored
Bug: 1142077 Change-Id: I7f77980b2fd1ad1f50f94adaa63fa537c3199037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559159 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Charlene Yan authored
This reverts commit 2c73aa66. Reason for revert: Disabling test on linux Original change's description: > Revert "[Tab Scrolling] Add test for tabstrip resizing when dragging." > > This reverts commit a4b670d5. > > Reason for revert: Test is flaky/failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95514? > > ../../chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2470: Failure > Expected equality of these values: > tab_strip_width + TabStyle::GetStandardWidth() > Which is: 751 > tab_strip->width() > Which is: 761 > > Original change's description: > > [Tab Scrolling] Add test for tabstrip resizing when dragging. > > > > When the browser window is large enough, the tabstrip should expand to > > accommodate tabs dragging past the last tab. This is a test for > > crrev.com/c/2472577 > > > > Bug: 1141674 > > Change-Id: Icfb4b0d6b9ebfa243a0e352b0cef68a2a6f2c263 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537068 > > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > > Commit-Queue: Charlene Yan <cyan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827998} > > TBR=tbergquist@chromium.org,cyan@chromium.org > > Change-Id: Iaee8c99d3a53eb4f1031d969b01e39d86febe6a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1141674 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545744 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828425} TBR=mek@chromium.org,tbergquist@chromium.org,cyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1141674 Change-Id: If7b71337950554f49dc9d635dbb2a2a35f0c280c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559577Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831141}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3c2d8c6c5a356af367d84304a7ca7c3d72b9621e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560307 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831140}
-
Moe Ahmadi authored
Whitespaces are removed from the beginning of the input string returned in the AutocompleteResult. This should be taken into account when deciding whether the results are fresh when they arrive as well as when navigating to them. This CL accounts for that subtlety in the latter. Fixed: 1102345 Change-Id: I2f34805dfd2cb02aed6659f497347c93771e5666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560070Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#831139}
-
Aaron Leventhal authored
1. Add DCHECKs that prevent an AXObject from being detached during serialization. This prevents situations where an object is detached at an unexpected time such as during UpdateCachedAttributesIfNeeded(). That causes crashes because the detached object is still running its own code attempts to use private variables such ax ax_object_cache_, which is now null. 2. Get() is now safe to call at any time, and never detaches nor creates AXObjects. However, it will check whether an object is not the correct type (AXNodeObject vs AXLayoutObject) and, if necessary, mark the object as invalid to be refreshed when layout is clean.. These changes ensure the following cases do not lead to crashes due to suddenly needing to change from an AXLayoutObject to an AXNodeObject or vice versa. * Changing CSS display, e.g. to table cell or toggling display:none * Changing CSS appearance / -webkit-appearance on a control * Reparenting node into or out of a <canvas> * Display lock changes (CSS content-visibility) Also removes 8 TODOs, but adds 2. This is a cleaner, more long term fix for these types of crashes and the content-visibility-auto-crash.html test than the fix in CL:2553695. TBR=kinuko@chromium.org Bug: 1138861,1138837 Change-Id: I8c7ac9617e27b9eeb725c9c794ffdfd570bd6f13 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485519 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#831138}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3642900e6d46..81585eced14b 2020-11-25 raphael.kubo.da.costa@intel.com Rewrite some UI.Geometry.EulerAngles layout tests as unittests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137281 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie9ec09621be99f352b7d426b74ebd443d58dcecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561288Reviewed-by:
-
Karandeep Bhatia authored
This was disabled in crrev.com/c/1688731 due to failures in linking of filter_list_converter target. This has now been fixed. BUG=981112 Change-Id: I3e4f5947d345c2c96dac6c3c2fe531309e7b827d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561442Reviewed-by:
-
