GitLab

Also make sure that the user cannot click pay until we
get the callback from the merchant.

BUG=715170,715597

Review-Url: https://codereview.chromium.org/2836353002
Cr-Commit-Position: refs/heads/master@{#467698}

After https://codereview.chromium.org/2789363004 landed, Ozone Drm
supports the KMS "rotation" property that can be used to set a transform
to HW overlays.

This CL relaxes the transform restrictions of the fullscreen and
single on top overlay strategies.

Additionally, it makes sure that any configuration containing a transform
will be reject if the legacy page flip is being used.

After this CL WebGL and Pepper content can be promoted to HW overlay when
backed by a Gpu Memory Buffer.

BUG=b/36752417
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2794343003
Cr-Commit-Position: refs/heads/master@{#467697}

The fix for handling case thread_time equals None was landed.
BUG=715822
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2849553002
Cr-Commit-Position: refs/heads/master@{#467696}

Reland of Break page load metrics test dependency on IPC. (patchset #1 id:1 of https://codereview.chromium.org/2847803002/ )

Reason for revert:
The flake that caused the previous revert by zmin existed before the original patch landed, so the original patch is not the cause of the flake.

This refactor should help us to un-flake the test, so I'm re-landing it.

Original issue's description:
> Revert of Break page load metrics test dependency on IPC. (patchset #2 id:20001 of https://codereview.chromium.org/2847513002/ )
>
> Reason for revert:
> PageLoadMetricsBrowserTest.DocumentWriteReloada is flaky
>
> https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/387
>
> Original issue's description:
> > Break page load metrics test dependency on IPC.
> >
> > This change breaks direct dependencies on IPC for page load metrics
> > tests, in order to ease the transition to mojo.
> >
> > Previously, unit tests exercised the IPC dispatch path. This
> > achieved slightly increased coverage but coupled unit tests to
> > IPC. We now dispatch simulated timing events directly to callbacks,
> > bypassing the IPC dispatch.
> >
> > Additionally, we break the browsertest dependency on IPC and add
> > a MetricsWebContentsObserver::TestingObserver, which can observe
> > state changes at the observer level, instead of watching for IPC
> > messages. This both simplifies the logic and more directly verifies
> > expected behavior at the appropriate level.
> >
> > BUG=715744
> > TBR=csharrison
> >
> > Review-Url: https://codereview.chromium.org/2847513002
> > Cr-Commit-Position: refs/heads/master@{#467687}
> > Committed: https://chromium.googlesource.com/chromium/src/+/9567f9fa3fcfcaa50fc7b6a6adf66106a2eb6be5
>
> TBR=lpy@chromium.org,bmcquade@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=715744
>
> Review-Url: https://codereview.chromium.org/2847803002
> Cr-Commit-Position: refs/heads/master@{#467691}
> Committed: https://chromium.googlesource.com/chromium/src/+/2cb37fe0beb13e6baa8852662362e9204d1ebfa3

TBR=lpy@chromium.org,zmin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=715744

Review-Url: https://codereview.chromium.org/2849563002
Cr-Commit-Position: refs/heads/master@{#467695}

Many layout changes e.g. resizing doesn't affect computed collapsed
borders so don't need to invalidate collapsed borders.

We need to invalidate collapsed borders when
1. Table sections are set need recalc (when table structure changes);
2. A cell is appended into a row (which could belong to 1 but we have an
   optimization not to recalc table sections if the added cell is the
   last cell of the table);
3. Border style changes;
4. border-collapse CSS property changes;

This CL will reduce frame time of PerformanceTests/Mutation/large-
table-row-height-change-with-collapsed-border.html (in
https://codereview.chromium.org/2842313002/) by about 35% by avoiding
unnecessary collapsed border recalculations.

BUG=626748

Review-Url: https://codereview.chromium.org/2840723005
Cr-Commit-Position: refs/heads/master@{#467694}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=jialiul@chromium.org

Review-Url: https://codereview.chromium.org/2833373004
Cr-Commit-Position: refs/heads/master@{#467693}

The flag should only be set by tests and will allow all autoplay related
restrictions such as autoplay policy and background playback to be
disabled.

BUG=714676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2843913003
Cr-Commit-Position: refs/heads/master@{#467692}

Revert of Break page load metrics test dependency on IPC. (patchset #2 id:20001 of https://codereview.chromium.org/2847513002/ )

Reason for revert:
PageLoadMetricsBrowserTest.DocumentWriteReloada is flaky

https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/387

Original issue's description:
> Break page load metrics test dependency on IPC.
>
> This change breaks direct dependencies on IPC for page load metrics
> tests, in order to ease the transition to mojo.
>
> Previously, unit tests exercised the IPC dispatch path. This
> achieved slightly increased coverage but coupled unit tests to
> IPC. We now dispatch simulated timing events directly to callbacks,
> bypassing the IPC dispatch.
>
> Additionally, we break the browsertest dependency on IPC and add
> a MetricsWebContentsObserver::TestingObserver, which can observe
> state changes at the observer level, instead of watching for IPC
> messages. This both simplifies the logic and more directly verifies
> expected behavior at the appropriate level.
>
> BUG=715744
> TBR=csharrison
>
> Review-Url: https://codereview.chromium.org/2847513002
> Cr-Commit-Position: refs/heads/master@{#467687}
> Committed: https://chromium.googlesource.com/chromium/src/+/9567f9fa3fcfcaa50fc7b6a6adf66106a2eb6be5

TBR=lpy@chromium.org,bmcquade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=715744

Review-Url: https://codereview.chromium.org/2847803002
Cr-Commit-Position: refs/heads/master@{#467691}

BUG=715691

Review-Url: https://codereview.chromium.org/2842293002
Cr-Commit-Position: refs/heads/master@{#467690}

After this patch, Android payment applications can support "interledger"
payment method by adding the following section to their
AndroidManifest.xml file:

<activity android:name=".PaymentActivity" android:exported="true">
  <intent-filter>
    <action android:name="org.chromium.intent.action.PAY" />
  </intent-filter>
  <meta-data android:name="org.chromium.default_payment_method_name"
             android:value="interledger" />
</activity>

Flag:
chrome://flags/#android-payment-apps

Design:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

BUG=715577

Review-Url: https://codereview.chromium.org/2850503002
Cr-Commit-Position: refs/heads/master@{#467689}

In this patch:
Try to fetch all supported web app ids for the payment method from
the cache before downloading its manifest online. If cached web app
ids contain all matching apps ids, proceed fetching corresponding web
apps manifests from the cache. Otherwise fall back to download the
payment method's manifest online. If failed to fetch at least one web
app's manifest from the cache, then fall back to download payment
method's manifest online.

In addition:
Cache downloaded and parsed supported web apps ids of the payment
method for future reference. Cache downloaded and parsed web app
manifest sections for future reference.

Refer to below doc for details.
https://docs.google.com/a/google.com/document/d/1Ncsp96Ae5836NLOdPwHRzcX3zkgj-4-5fq_nI2azC7M

BUG=708508

Review-Url: https://codereview.chromium.org/2838433002
Cr-Commit-Position: refs/heads/master@{#467688}

This change breaks direct dependencies on IPC for page load metrics
tests, in order to ease the transition to mojo.

Previously, unit tests exercised the IPC dispatch path. This
achieved slightly increased coverage but coupled unit tests to
IPC. We now dispatch simulated timing events directly to callbacks,
bypassing the IPC dispatch.

Additionally, we break the browsertest dependency on IPC and add
a MetricsWebContentsObserver::TestingObserver, which can observe
state changes at the observer level, instead of watching for IPC
messages. This both simplifies the logic and more directly verifies
expected behavior at the appropriate level.

BUG=715744
TBR=csharrison

Review-Url: https://codereview.chromium.org/2847513002
Cr-Commit-Position: refs/heads/master@{#467687}

This CL adds ui.mojom.CandidateWindowProperties and
ui.mojom.CandidateWindowEntry and corresponding struct traits.

BUG=637416, 672587

Review-Url: https://codereview.chromium.org/2839243002
Cr-Commit-Position: refs/heads/master@{#467686}

These four properties were not being copied over when populating a
WebServiceWorkerRequest from a Request. These properties are
already being copied over when converting in the other direction
in FetchRequestData::Create().

BUG=

Review-Url: https://codereview.chromium.org/2828293002
Cr-Commit-Position: refs/heads/master@{#467685}

There were two helper functions IsInDocument implementations in
core/input and this moves them to EventHandlingUtil so they can
be shared.

R=dtapuska@chromium.org

Review-Url: https://codereview.chromium.org/2845973002
Cr-Commit-Position: refs/heads/master@{#467684}

R=enne@chromium.org

Review-Url: https://codereview.chromium.org/2843233002
Cr-Commit-Position: refs/heads/master@{#467683}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2835643002
Cr-Commit-Position: refs/heads/master@{#467682}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2769803002
Cr-Commit-Position: refs/heads/master@{#467681}

Duplicates configs defined in //build/config/mac/BUILD.gn that
are shared with iOS to //build/config/ios/BUILD.gn. Remove all
conditions testing "is_mac" or "is_ios" (as they are now known
from the filename).

Change dependencies on previously shared targets to select the
correct target based on the "target_os".

BUG=635745

Review-Url: https://codereview.chromium.org/2843493002
Cr-Commit-Position: refs/heads/master@{#467680}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/594d9c9e..3338869a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2845933003
Cr-Commit-Position: refs/heads/master@{#467679}

TBR=reed@google.com
NO_TRY=true

BUG=skia:6464

Review-Url: https://codereview.chromium.org/2844223003
Cr-Commit-Position: refs/heads/master@{#467678}

Don't do work in DCHECKs.

BUG=715792
R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2847573002 .
Cr-Commit-Position: refs/heads/master@{#467677}

There are some valid DOM positions (*) that do not have corresponding
valid flat tree positions. This patch adds special handling of such
DOM positions, so that when computing VisibleSelectionInFlatTree from
SelectionInDOMTree, such positions are converted to NULL instead of
invalid flat tree positions, so that the renderer does not crash.

(*) If NODE is a direct child of a shadow host but is not distributed
into the flat tree, NODE@BeforeAnchor and NODE@AfterAnchor are valid
Position but invalid PositionInFlatTree. This patch handles these two
kind of positions.

BUG=702756, 709872, 712984
TEST=FrameSelectionTest.SelectInvalidPositionInFlatTreeDoesntCrash

Review-Url: https://codereview.chromium.org/2850443002
Cr-Commit-Position: refs/heads/master@{#467676}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2843583002
Cr-Commit-Position: refs/heads/master@{#467675}

In blink, we convert mouse enter and leave events to mouse move events,
we should not do it anymore. We should keep their types, so we know
they are actual enter or leave events.

I looked at the code, PointerEventManager::SendMousePointerEvent has a
separate argument called mouse_event_type, which is always the type of
mouse move, and mouseevent's type is not referred anymore. It should
be safe to remove the conversion.

BUG=686196

Review-Url: https://codereview.chromium.org/2839103002
Cr-Commit-Position: refs/heads/master@{#467674}

This change maps VR controller input to non-content UI elements. The
content element is treated separately, so that it can handle scrolling
and fling-type input (these are currently not useful to other elements).

BUG=715554

Review-Url: https://codereview.chromium.org/2840183003
Cr-Commit-Position: refs/heads/master@{#467673}

HTML Chunks inserted by document.write() are run through a separate
instance of the preload scanner from the main document.  If the main
document scanner has already discovered an image then all scripts
discovered by any preload scanner regardless of where they came from
would be considered late-body.

This behavior causes a regression where a document.write() in the head
that includes multiple script tags will discover them but treat them as
late-body scripts and only load them one at a time.

reland of http://crbug.com/2826213003

Only change from the original was to fix the layout test.  Specifically,
the URL for the preload image was not re-used for the actual image
which caused the test to issue a console warning about the preload
not being used but only if the overall test took long enough for the
warning to trigger.

Patch set #1 is the original CL untouched

BUG=713727, 712338
Review-Url: https://codereview.chromium.org/2826213003
Cr-Commit-Position: refs/heads/master@{#467029}
Committed: https://chromium.googlesource.com/chromium/src/+/1e0d3cbbf60c67ba9856eadcb9e829b3c4bec6c7

patch from issue 2826213003 at patchset 70001 (http://crrev.com/2826213003#ps70001)

Review-Url: https://codereview.chromium.org/2841363002
Cr-Commit-Position: refs/heads/master@{#467672}

We want ultimately to move to a model where memory-infra does not have its own
custom thread and instead uses base::scheduler. However this is risky at the
moment given the tracing entanglement and the various other refactorings going
on. For now we change the logic to never kill the background thread. This will
simplify the logic of the MemoryDumpManager significantly and pave the way for
us to disentangle tracing.

BUG=705564
BUG=702289

Review-Url: https://codereview.chromium.org/2836933002
Cr-Commit-Position: refs/heads/master@{#467671}

TestBrowserThread is deprecated. TestBrowserThreadBundle provides all
browser threads, a blocking pool and a TaskScheduler.

This CL was generated using the script posted on the bug +
git cl format +
tools/sort-headers.py +
some manual adjustments.

BUG=272091
R=gab@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2799883003
Cr-Commit-Position: refs/heads/master@{#467670}

BUG=chromium:714521

Review-Url: https://codereview.chromium.org/2839913002
Cr-Commit-Position: refs/heads/master@{#467669}

I had the issue that vscode didn't notice file changes e.g.
by git cl format. Excluding out/ and third_party/ with
files.watcherExclude seems to help.

Files per folder:
10934 v8
14436 native_client
17478 data
26470 build
37676 chrome
389528 third_party
426532 out

BUG=

Review-Url: https://codereview.chromium.org/2847723002
Cr-Commit-Position: refs/heads/master@{#467668}

Disable org.chromium.android_webview.test.PostMessageTest#testMessageCha
nnelUsingPendingPort because it is flaky.

TBR=sgurun@chromium.org

BUG=715960

Review-Url: https://codereview.chromium.org/2845863004
Cr-Commit-Position: refs/heads/master@{#467667}

BUG=715716

Review-Url: https://codereview.chromium.org/2844793002
Cr-Commit-Position: refs/heads/master@{#467666}

spdy/platform/*/spdy_ptr_util{,_impl}.h are almost verbatim copies of
quic/platform/*/quic_ptr_util{,_impl}.h.  Note "util" versus "utils" in
the filenames, despite some other headers are pluralized: this is for
consistency with //net/quic/platform/quic_ptr_util and
//base/memory/ptr_util.h.

(Also note that quic/platform/*/quic_ptr_util{,_impl}.h incorrectly uses
std::move in return, which potentially prevents return value
optimization, so I'm not doing it here.)

Also change most naked new's to SpdyMakeUnique, because clearly, naked
new is the devil itself.  And add #include <new> for most remaining new
(except for the ones that I plan to remove in the near future).

This CL lands server change 153775072 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2840563003
Cr-Commit-Position: refs/heads/master@{#467665}

base::BarrierClosure calls the given callback object only once upon the
Nth invocation of resulting wrapper callback. That means, the wrapped
callback should be OnceCallback, and the resulting callback should be
RepeatingCallback.

BUG=714018

Review-Url: https://codereview.chromium.org/2833293004
Cr-Commit-Position: refs/heads/master@{#467664}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2836083003
Cr-Commit-Position: refs/heads/master@{#467663}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=bartfab@chromium.org

Review-Url: https://codereview.chromium.org/2836133002
Cr-Commit-Position: refs/heads/master@{#467662}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2835313002
Cr-Commit-Position: refs/heads/master@{#467661}

https://skia.googlesource.com/skia.git/+log/ac0e705af1d6..56de05fec3fa

$ git log ac0e705af..56de05fec --date=short --no-merges --format='%ad %ae %s'
2017-04-26 mtklein add #defines to limit SkCpu

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I4f6463f27b702185e8fe23fd112e6a9d33f783b0
Reviewed-on: https://chromium-review.googlesource.com/488461Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467660}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8062a5765bb7..c46500e9c5b7

$ git log 8062a5765..c46500e9c --date=short --no-merges --format='%ad %ae %s'
2017-04-27 lpy [ESLint] Turn on dot-notation.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I9ae6aff18aff11e4bfa7639208b935c1208a9be8
Reviewed-on: https://chromium-review.googlesource.com/488481
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467659}