GitLab

This addresses a TODO from http://crrev.com/147862 to
not leak CFAttributedString attributes and additionally
ensures that the CTFontRef is properly disposed.

Also renames SkColorToCGColorRef() to CGColorCreateFromSkColor()
to be clear that it follows the Create rule.

BUG=125664
TEST=No leaks on waterfall.

Review URL: https://chromiumcodereview.appspot.com/10808084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128027
TEST=Text is drawn correctly in omnibox suggest drop down.

Review URL: https://chromiumcodereview.appspot.com/10692101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147947 0039d316-1c4b-4281-b951-d872f2087c98

Now that seccomp filter looks good in 3.5, remove the disable.

BUG=None
TEST=Chrome logs "Enable seccomp filter sandbox...".


Review URL: https://chromiumcodereview.appspot.com/10786023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136962

Review URL: https://chromiumcodereview.appspot.com/10808058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135249

Review URL: https://chromiumcodereview.appspot.com/10816025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147941 0039d316-1c4b-4281-b951-d872f2087c98

- The files are updated to work with decryptor changes from
  crbug.com/119845.

BUG=132801
TEST=media_unittests

Review URL: https://chromiumcodereview.appspot.com/10806046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147940 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zmo
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10809056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138498
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10805035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113688
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10805054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147937 0039d316-1c4b-4281-b951-d872f2087c98

Reverting because composite_unittests were failing on Linux (aura) and Linux ChromeOS Tests bots.

Bug=None
Test=Compiles on Mac and CrOS
R=oshima,sky
TBR=sadrul,sail

Review URL: https://chromiumcodereview.appspot.com/10701063

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10790128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147936 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10805061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147935 0039d316-1c4b-4281-b951-d872f2087c98

The new PacketSocketFactory will be used by chromoting host in order to be able to
use chromium UDP sockets instead of libjingle sockets

BUG=137140


Review URL: https://chromiumcodereview.appspot.com/10783028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147934 0039d316-1c4b-4281-b951-d872f2087c98

The root cause of crbug.com/137878 was r103533, which replaced a class whose
default constructor initialized objects fully, with a struct for which that
isn't the case.


Review URL: https://chromiumcodereview.appspot.com/10796072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147933 0039d316-1c4b-4281-b951-d872f2087c98

Wiring: 
- Added bindings for glProgramBinary, glGetProgramBinary, glProgramParameteri 
- Plumbed the shader cache from gl_channel_manager to program_manager 
- Program cache creation after first context is created 

Refactoring: 
- moved DoCompile to ProgramManager 

New: 
- added functionality to ShaderInfo to store if we have a possible pending cache compile 
- exposed attrib_map and uniform_map in ShaderInfo for the cache 
- program_cache base class with in-memory status storage 
- Simple memory_program_cache implementation, stores programs with lru eviction 
- Added caching logic to DoCompileShader and Link in ProgramMAnager 
- MemoryProgramCache, the in-memory cache implementation 
- ProgramCacheLruHelper, an O(1) lru implementation 

Misc: 
- A couple style fixes in modified files 

Design doc: https://docs.google.com/document/d/1Vceem-nF4TCICoeGSh7OMXxfGuJEJYblGXRgN9V9hcE/edit 

BUG=88572


Review URL: https://chromiumcodereview.appspot.com/10797055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147932 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147931 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the function tries to compare a point in the window's coordinates and a rect in the root window's coordinates.

BUG=None
TEST=added a unit test (WindowTest.ContainsPointInRoot) which fails on tot and passes with this CL; ./out/Debug/aura_unittests --gtest_filter='*WindowTest.ContainsPoint*'

Review URL: https://chromiumcodereview.appspot.com/10806055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147930 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10800073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147929 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10807074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147927 0039d316-1c4b-4281-b951-d872f2087c98

ssl_client_socket_nss.cc calls ReportUMAOnPinFailure when pinning fails.
However, that function currently assumes that the pin failure came from a
built-in pin. When that's not the case, it hits a NULL pointer.

BUG=138521
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10802067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147926 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=Compiles, code looks nicer
R=oshima,sky
TBR=sadrul

Review URL: https://chromiumcodereview.appspot.com/10704199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147925 0039d316-1c4b-4281-b951-d872f2087c98

Info.plist files by setting __CFPREFERENCES_AVOID_DAEMON.

BUG=138199
TEST=Chrome should update on 10.8 without errors, and the new version should
     be reflected immediately in the Keystone ticket

Review URL: https://chromiumcodereview.appspot.com/10810059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147924 0039d316-1c4b-4281-b951-d872f2087c98

Latency tests require instrumenting where the SwapBuffers call is received, as opposed to where it is completed. Fix a regression introduced by r146621 in the latency tests by restoring the TRACE_EVENT placement.

R=jbates
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10805022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147923 0039d316-1c4b-4281-b951-d872f2087c98

This removes the sticky preference and instead makes the two keyboard shortcuts
each toggle the respective mode, such that hitting the same shortcut twice will
always exit that mode (making the actions symmetric). Diagram:
https://docs.google.com/open?id=0B4kReKV-OI17Y1lscGhISEtCYjg

After this CL, the only operation that does not work is entering Lion FS mode
from presentation mode. Using that shortcut exits fullscreen. That will be
addressed in a followup CL.

BUG=114373
TEST=Perform operations in diagram. All work except Presentation->FS mode.


Review URL: https://chromiumcodereview.appspot.com/10800011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147921 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10800077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147920 0039d316-1c4b-4281-b951-d872f2087c98

Move the HungRendererDialogView and HungPagesTableModel classes into a header
file hung_renderer_view.h.

Add a windows specific override of the HungRendererDialogView class. This is in
preparation for displaying the hung renderer dialog using the native metro dialog UI
in Windows 8 metro.

BUG=125672
R=sky
Review URL: https://chromiumcodereview.appspot.com/10815060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147919 0039d316-1c4b-4281-b951-d872f2087c98

entry_proto can be NULL if there was an error in GetEntryInfoByPath()
hence we should check entry_proto.get() beforehand.

BUG=137882
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10815058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147917 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=1
CID=104503
BUG=none
TEST=none
R=groby
TBR=aa


Review URL: https://chromiumcodereview.appspot.com/10808077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147916 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=Compiles on Mac and CrOS
R=oshima,sky
TBR=sadrul,sail

Review URL: https://chromiumcodereview.appspot.com/10701063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147915 0039d316-1c4b-4281-b951-d872f2087c98

Remove possibility of stale user_buffer_ member in PPB_URLLoader_Impl when FinishedLoading() is called.

BUG=137778

Review URL: https://chromiumcodereview.appspot.com/10797037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147914 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138544
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10790123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147912 0039d316-1c4b-4281-b951-d872f2087c98

This splits the force-compositing-mode field trial into 3 groups:
- disabled
- force-compositing-mode
- force-compositing-mode + threaded-compositing


Review URL: https://chromiumcodereview.appspot.com/10811002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147907 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137044
TEST=Manual verification that Windows host input injection works correctly.


Review URL: https://chromiumcodereview.appspot.com/10795053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147906 0039d316-1c4b-4281-b951-d872f2087c98

In the NaCl standalone build, this invocation on the PNaCl bots produced the following error:

./scons --verbose bitcode=1 skip_trusted_tests=1 -j6 do_not_run_tests=1 --mode=opt-host,nacl platform=x86-64
...
scons: *** [scons-out/nacl-x86-64-pnacl-pexe-clang/staging/ppapi_ppb_audio.nmf] Source `scons-out/nacl-x86-64-pnacl-pexe-clang/staging/ppapi_ppb_audio_x86-64.nexe' not found, needed by target `scons-out/nacl-x86-64-pnacl-pexe-clang/staging/ppapi_ppb_audio.nmf'.

TEST=the scons invocation above
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10796092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133636
TEST=choices_unittest.cc


Review URL: https://chromiumcodereview.appspot.com/10790040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147904 0039d316-1c4b-4281-b951-d872f2087c98

This is part 2 of the revert. First part in 147897.

Does not compile.

BUG=none
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10806023

TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10816024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147902 0039d316-1c4b-4281-b951-d872f2087c98

Broke WebKit layout tests, will update and reland.


Also stop supporting non-square widgets, no other browser seems to do this and
it exposes bugs in web pages.

BUG=125773
TEST=


Review URL: https://chromiumcodereview.appspot.com/10796071

TBR=rbyers@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10810060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147899 0039d316-1c4b-4281-b951-d872f2087c98

Does not compile.

BUG=none
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10806023

TBR=estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10805064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10806023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147895 0039d316-1c4b-4281-b951-d872f2087c98