GitLab

Move prefs::kTapDraggingEnabled pref to ash, with ownership still in
chrome. This helps eliminating two ash::AccessibilityDelegate methods.

TBR=michaelpg@chromium.org

Bug: 594887
Change-Id: I9e91546431d9f3029d8a819e710d0303098faa62
Reviewed-on: https://chromium-review.googlesource.com/942686
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541044}

Following bot results are included.
4063 4064 4065 4067 4068

5 lines were removed and 21 lines were deflaked by consecutive
results since 4045.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ifc74b160e495333f097e8db2591f3a13cc89dfa0
Reviewed-on: https://chromium-review.googlesource.com/949342
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541043}

This reverts commit 8b30e16c.

Reason for revert: Causing failure on "Android Build" bot:
https://ci.chromium.org/buildbot/chromium/Android/82487

Original change's description:
> WindowServices: moves a couple more interfaces to OnceCallback
> 
> BUG=714018
> TEST=none
> 
> Change-Id: I6c8f6644a55fecccadf6257cd908404ca5bb7250
> Reviewed-on: https://chromium-review.googlesource.com/947807
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541039}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I626381e7df397ed4a9ea2823c85440599be811db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714018
Reviewed-on: https://chromium-review.googlesource.com/949943Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541042}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I2188b2a856fb04c9bac4bcd31dda483c5e282d15
Reviewed-on: https://chromium-review.googlesource.com/950562Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541041}

This CL changes "Add" to "Install" when a modal native app banner is
triggered. It also ensures that:
 - the ambient badge is shown prior to the beforeinstallpromptevent
   being dispatched for native apps.
 - native app banners are subject to the engagement threshold when the
   ExperimentalAppBanners feature is active.

BUG=811578

Change-Id: I19c0367e3bc52736467d1ecfc69e3cb472b82170
Reviewed-on: https://chromium-review.googlesource.com/938686
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541040}

BUG=714018
TEST=none

Change-Id: I6c8f6644a55fecccadf6257cd908404ca5bb7250
Reviewed-on: https://chromium-review.googlesource.com/947807
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541039}

"R.h" in core/BUILD.gn should be "r.h".
This is a follow-up of crrev.com/541035.

TBR=nainar@chromium.org
NOTRY=true

Bug: 770603
Change-Id: I89efbac7dbaccf263344766b64610b1b822a85d8
Reviewed-on: https://chromium-review.googlesource.com/950524Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541038}

This patch fixes some TODOs in image transfer cache serialization around
SkColorSpace.  Because SkImages are stored in the transfer cache, this
patch does not send the SkColorSpace separately in the transfer cache
and serializes it along with the image itself.

The SkColorSpace serialization in PaintOpReader/Writer is not exercised
by existing fuzzers, so the followup to this patch is to write a
transfer cache service-side deserialization fuzzer.

This patch also modifies the logic of the GpuImageDecodeCache to be
more consistent about when it applies color conversion.  Previously,
if color_type_ was 4444 then color space conversion would not be
applied to uploaded images but would be applied to "too large"
images that were kept as software bitmaps.  With this patch, no
color space conversion is applied in any mode if the color_type_
is not supported.

Bug: 815354
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I100acafb89bed2f7d8e80f0a0e6af2997b7d5590
Reviewed-on: https://chromium-review.googlesource.com/939725
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541037}

Before this change, the SQLite store and the cookie
monster had different notions of how exactly |key| passed to
PersistentStore::LoadCookiesForKey should be computed[1], and the
version used by CookieMonster was not really computable from a
CanonicalCookie.  This changes both of these to use
CookieMonster::GetKey, which is already used with both
CanonicalCookie's and URLs, and can therefore be easily called from
SetCanonicalCookieAsync as well.

[1] In particular they disagreed on chrome-extension:// cookies, but
that appeared to have been deterministically masked by implementation
details of the SQLite cookie store, so doesn't seem to have been a bug
that actually affected our users.

Bug: 813141
Change-Id: Iaa3840a1e1e28992c99413142a62fddff97c7f78
Reviewed-on: https://chromium-review.googlesource.com/940141
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541036}

Generated files in these directories are often identical to other
checked-in files. It's difficult to make move_blink_source.py workable
in such situation. So, this CL renames these generated files beforehand.

This CL has no behavior changes.

Differnce from #540796:
 #540796 had an error in core/BUILD.gn. "D.h" in it should have been
"d.h". This caused a bot error only on clobber build AND case-sensitive
filesystem.

TBR=nainar@chromium.org

Bug: 770603
Change-Id: I1491eec1aa3fb5b7824f1d742dd197498c3516eb
Reviewed-on: https://chromium-review.googlesource.com/949803Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541035}

in order to increase the number of owners of build/scripts/core/css/.

Change-Id: I36f2b7931b2d475a9fc4405088d61a5efccc45d6
Reviewed-on: https://chromium-review.googlesource.com/949804Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541034}

This CL finishes to address the comments for
https://chromium-review.googlesource.com/c/chromium/src/+/934510

Bug: 813497
Change-Id: If09a1070c8a67d57fc178a19f236ba613f876b7e
Reviewed-on: https://chromium-review.googlesource.com/950282Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541033}

Introduce a new SpdyFramerVisitorInterface method,
OnSetting(SpdySettingsId id, uint32_t value), which can be passed both
defined and undefined SETTINGS IDs.  This method is intended to replace
the old method that only accepted known (defined) values. The CL renames
the old method to OnSettingOld(SpdyKnownSettingsId id, uint32_t value),
which will be slayed upon deprecation.

Also change SettingsMap key type,
BufferedSpdyFrameVisitorInterface::OnSettings() argument type, and some
test variable type from SpdyKnownSettingsId to SpdySettingsId.

Since the only production implementer of
BufferedSpdySessionVisitorInterface::OnSetting() is
SpdySession::OnSetting(), which calls SpdySession::HandleSetting(),
which ignores unknown settings, this CL should be a no-op.

This CL lands server changes 186393706 and 186774234 by diannahu.

BUG=488484

Change-Id: Ibd76ea918a6b94d959fa49b268a17a756a2d027c
Reviewed-on: https://chromium-review.googlesource.com/948982
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541032}

Auto hide state can still be reached by full screening an app (F4 or app requests).

Test: ash_unittests ShelfLayoutManagerTest.SwipingUpOnShelfInTabletModeForFullscreenAppList
Bug: 801684
Change-Id: I4da8d7b7ecf7d25310f3f55861bf5f82b6cd7f23
Reviewed-on: https://chromium-review.googlesource.com/939646
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541031}

This article serves as a central location for steps developers should
take to ensure a secure extension.

Bug: None
Change-Id: I655a1ac99aabcbe3988423a0d5216ae3db9bb849
Reviewed-on: https://chromium-review.googlesource.com/807449
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541030}

GCC: explicitely std::move to base::Optional instead of implicit conversion to base::Optional in return

GCC 7.2/7.3 complains in this pattern of code:
base::Optional<Foo>
Method() {
  ...
  Foo response;
  ...
  return response;
}

It seems it cannot properly resolve the implicit move to base::Optional, and
ends up failing to compile. To avoid that, this change explicitely moves to
base::Optional as return value:
  return base::Optional<Foo>(std::move(response));

Change-Id: Ic0390e1c31340dc34a71bb4175bd63a4631248d6
Reviewed-on: https://chromium-review.googlesource.com/944402
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541029}

Notify cros performance team for any cros_benchmarks update.
Signed-off-by: Chung-yih Wang <cywang@chromium.org>
Bug: 818100
Change-Id: Ie74dd855bd7c8ba124cb4a88e25ea776ab081ab5
Reviewed-on: https://chromium-review.googlesource.com/945589Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#541028}

Tests that CWVTranslationController can properly set and read policies for both languages and page hosts.

Bug: 770983
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iac693f6ab83224cc55b234113a37f5f5c907a28b
Reviewed-on: https://chromium-review.googlesource.com/949825
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541027}

https://chromium.googlesource.com/angle/angle.git/+log/f0e89be69906..e05ffdd19837

$ git log f0e89be69..e05ffdd19 --date=short --no-merges --format='%ad %ae %s'
2018-02-19 lfy GLES1: caps: Use GLES3 spec shader compiler
2018-02-08 lfy GLES1: state: Add crop rect / generate mipmap texparameters
2018-02-19 lfy GLES1: caps: Allow ES1 to use formats from core ES2

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I9a2c8582edcf747085704a68a6312b492f192db4
Reviewed-on: https://chromium-review.googlesource.com/950224
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541026}

Use shorter names which can prefixed so that a page can be instantiated
multiple times in upcoming rendering benchmarks.

R=nednguyen@google.com

Bug: 760553
Change-Id: Iaea23d607aca859e72dff0015154551b32935d72
Reviewed-on: https://chromium-review.googlesource.com/942188
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#541025}

The name and the condition were backwards, so it worked out to be ok.

Change-Id: Idb8f2d99b93bdb193dec4aed2416247596fc060f
Reviewed-on: https://chromium-review.googlesource.com/944622Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541024}

The sid sysroot change seems to have stuck.  Now remove the stretch sysroot so
we don't have to maintain both of them.

R=thestig

Change-Id: I5ae295143a3ca2db70299ea0773fd316ff04ac48
Reviewed-on: https://chromium-review.googlesource.com/950310Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541023}

https://skia.googlesource.com/skia.git/+log/9d28974d16d1..2388cd1f69e3

$ git log 9d28974d1..2388cd1f6 --date=short --no-merges --format='%ad %ae %s'
2018-03-05 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 76a0bf463..8a7ec86c0 (1 commit)
2018-03-05 jvanverth Add bilerp support to scaled emojis
2018-03-05 herb Remove routines no longer needed since stripping NVPR

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: Iac177c58c34933819165a32134902a52be67601a
Reviewed-on: https://chromium-review.googlesource.com/950130Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541022}

Breaking debug component build, gpu process.  There is a component DLL called
display.dll that is clashing with the same name in system32.

Temporary disable for the moment.

(Note: also removing the other IMAGE_LOAD mitigations from the browser
process (post-startup) for now.  Only set in child processes.)

BUG=818388
TEST=sbox_integration_tests.exe, ProcessMitigationsTest.*

Change-Id: I1198e2222493a792df675d4b7675220d0da3459f
Reviewed-on: https://chromium-review.googlesource.com/950128Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541021}

Bug: internal b/67951135
Test: unit-tests pass and verified on device

Change-Id: Ie758e3a7566cff31297894516c61656ec29f40ab
Reviewed-on: https://chromium-review.googlesource.com/945068Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541020}

This follows mouse and touch events in input handler.

Bug: 746266
Change-Id: I10e08dbc6af952e240e6426a145bf1257ccd93ae
Reviewed-on: https://chromium-review.googlesource.com/947470
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541019}

This CL:
* Disables non hardware backed user certs
* Displays an error message when no user certs or no hardware backed
  certs are available
* Fixes edge cases where certifiates are added or removed while the
  config UI is visible
* Adds/improves configuration event logging

Bug: 810079
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f2374d16bf2300fd2937c8ce873d40cf4c44321
Reviewed-on: https://chromium-review.googlesource.com/949442Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541018}

In ARIA 1.1 the spec changed so that now a list item should be focusable not only if the ancestor has an active descendant, but also if either itself or an ancestor is controlled by a textbox with an active descendant.
R=dmazzoni@chromium.org, aleventhal@chromium.org
Tested; layout test, ARIA 1.1 sample HTML

Bug: 792059
Change-Id: I77902f1cb2423ebe5e9095ddd135754d1b061e97
Reviewed-on: https://chromium-review.googlesource.com/832989
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541017}

Bug: 733662
Change-Id: I1ffa62c7382de312425e9eef8a99db9e055c8733
Reviewed-on: https://chromium-review.googlesource.com/944609
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541016}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/00dbe028..f4c40134

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If1e61303efe498b0745b6deeda050767aa59922b
Reviewed-on: https://chromium-review.googlesource.com/949922Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541015}

In ChromeContentBrowserClient::RegisterNonNetworkSubresourceURLLoaderFactories,
it's possible that no ExtensionWebContentsObserver is attached to the
WebContents for the given RenderFrameHost. Return early in that case.

BUG=818875

Change-Id: Ifca9cc67d36fe5aee0da496952125ef8ee199849
Reviewed-on: https://chromium-review.googlesource.com/950134Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541014}

DownloadFilePicker is a lisener of SelectFileDialog.
When it creates a SelectFileDialog, it should inform the latter
when it is killed.
Otherwise, SelectFileDialog might hit NPE when calling the listener method.

BUG=818066

Change-Id: Idc5e67b5cba9eac5f72b8e7a2df1ca70f2adbd8e
Reviewed-on: https://chromium-review.googlesource.com/949099Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Joy Ming <jming@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541013}

Range check `operator[]`, `front`, `back`, and  `remove_{pre,suf}fix`.

Bug: 817982,818376,818844
Change-Id: I3a0b560af273c9b04237a18a1bc0b56283d3d824
Reviewed-on: https://chromium-review.googlesource.com/945049
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541012}

These should just be slow not flakily fail.

BUG=817705,694855

Change-Id: I371f57744442eebad53aea566b751df47d8b9a9e
Reviewed-on: https://chromium-review.googlesource.com/950142Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541011}

This commit adds a mojo API in AppListControllerImpl, so that Chrome
can reset the app list models in Ash when user profile changes and
before sync happens.

Bug: 733662
Change-Id: Iebaf78bf356d2f9fe8c16fa1a90543b9105f8d01
Reviewed-on: https://chromium-review.googlesource.com/944303Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#541010}

Querying the registry is expensive and contributes to start up time,
omnibox query time and idle. Since the brand code is not expected to
change on Windows during the course of a session, this CL caches
the value, so that future queries are free.

This should restore the Omnibox perf that regressed by
https://chromium-review.googlesource.com/c/chromium/src/+/824363
and also improve perf elsewhere since the caching is now done at
a lower level than that change. Since this is expensive only on
Windows, the caching is done in the Windows codepath only.

Bug: 816698, 806130
Change-Id: I458fad29f18b1b1ff2d55b9334ae733fa448eec9
Reviewed-on: https://chromium-review.googlesource.com/947522
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541009}

It fixes asan failure on shutdown when SystemTrayUnified flag is
enabled.
WebNotificationTray explicitly set |system_tray_| as the next focusable
view. However, the focusable view linked list was broken when
UnifiedSystemTray is enabled, as UnifiedSystemTray is inserted between
these views.
UnifiedSystemTray is invisible, and these viewss are adjacent, so we
don't have to set the focusable view explicitly.
It also renames |system_tray_unified_| in Shell to
|unified_system_tray_|.

TEST=out/asan/ash_unittests --gtest_filter=UnifiedStatusAreaWidgetTest.Basics
BUG=none

Change-Id: Ifac7ae910771802cc1515e4e05318264c6f82a52
Reviewed-on: https://chromium-review.googlesource.com/940707Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541008}

This was the case until
https://chromium.googlesource.com/chromium/src/+/8e4234fdc272ddda5ec9c156a2397c64d7a69f60,
which removed scroll offset.

Bug:818519

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id79668c0ea9ca62ff8c181de2b4f1a0be6594e82
Reviewed-on: https://chromium-review.googlesource.com/949969Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541007}

This reverts commit 31fd846e.

This causes debug Windows component builds to not run on Windows, giving the error below. Bruce & Rob tracked it to the change in util/BUILD.gn which adds mincore.lib

---------------------------
chrome.exe - System Error
---------------------------
The program can't start because api-ms-win-power-base-l1-1-0.dll is missing from your computer. Try reinstalling the program to fix this problem."


Original change's description:
> Update Crashpad to 4375233ad2dad48f2332ecc20221df10f98b668a
> 
> This includes a reland of 58866fc9, which was reverted at
> 68255cbf. The cause for the revert was addressed by upstream
> 82777cff5848.
> 
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
>              end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
>              kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
>              again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
>              resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add  UploadReport to manage database resources during
>              upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
>              symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
>              implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
>              CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
>              ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
>              functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
>              Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
>              source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
>              from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
>              ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
>              ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
>              test
> c69ba3d52783 non-win: Add
>              Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
> cd3afe616e63 Linux: Pull and use clang toolchain in third_party
> 8e80a575d15f Linux: Pull a sysroot if pulling a local clang
> fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
> a869ae18d256 Workaround for death test failure when in threadsafe mode
>              on Mac
> 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
> 9affa2a0e72d Optionally stub out the libcurl-based implementation of
>              HTTPTransport
> dec23bef5769 win gn: reintroduce flags to disable warnings
> 746ce1a63703 Roll mini_chromium to 987bde8
> 493e29bc3df0 win: Use correct format specifier
> a45e88602b90 Skip ELF notes with a p_vaddr of zero
> 71d90608828d Add Linux trybots to CQ
> 449506d59c6a Roll mini_chromium to ef0df11
> 82777cff5848 win: fix warnings when building with clang
> 23b2156fb694 Don’t read beyond a StringPiece’s bounds in
>              StringToNumber()
> 4375233ad2da win: fix 64-bit build
> 
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
> 
> Bug: crashpad:30, chromium:817982, chromium:818376
> Change-Id: Ib4fcc423f68a4c80907968498264413f3f229c5c
> Reviewed-on: https://chromium-review.googlesource.com/947745
> Commit-Queue: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540894}

TBR=palmer@chromium.org,jperaza@chromium.org,mark@chromium.org,siggi@chromium.org

Change-Id: I2fbdde093d12fc1f93bd10478f6022effa0d8d2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30, chromium:817982, chromium:818376
Reviewed-on: https://chromium-review.googlesource.com/950343Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541006}

Use URLPattern::MatchesEffectiveTld() in parsing
ExternallyConnectableInfo. Now that we canonicalize the URL for the
URLPattern, the behavior of these is the same and we can remove the
duplicate logic.

Bug: None
Change-Id: I3a84c0aca81284ecca4ce60f1beb0bdeff05a961
Reviewed-on: https://chromium-review.googlesource.com/935453Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541005}