- 24 Jun, 2020 40 commits
-
-
Gauthier Ambard authored
When the sessions are being restored, the UserAgent is wrongly restored because the AUTOMATIC description wasn't added to the list of string describing the different UserAgent. Fixed: 1097794 Change-Id: Idf6d4e68a2e7b1ae634809deba2c7e03f3a2ac88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256216 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#781851}
-
Jérôme Lebel authored
This reverts commit 053f6124. Reason for revert: AddAccountSigninManagerTest fail on iOS 12: https://ci.chromium.org/p/chrome/builders/ci/iphone-device/9356 Original change's description: > [iOS] Remove unused ChromeIdentityInteractionManager APIs. > > This patch removes the old, unused APIs for adding an account to Chrome. > > Bug: 1078815 > Change-Id: I0ec5d29af7566d8287090ee83b8a67d4a1abb9ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226809 > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781345} TBR=jlebel@chromium.org,fernandex@chromium.org Change-Id: I7aa551337517a9c2b4a106e1530b7add58d00f8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264333 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781850}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I96a2faa1a6ae358cd3d81c556139e2c4689e1c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263835 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781849}
-
Vikas Soni authored
Add a utility function to create VkImage from ScopedHardwareBufferHandle. This helps to unify common code. Bug: 1091945 Change-Id: I87448b6a577bba95420ed0dd4f8d6925501cdec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263478Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781848}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2056b03530a70d514952f2165ec63eae79e167c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781847}
-
Koji Ishii authored
This patch fixes hit testing culled inline when a text node (or LayoutText) is fragmented. This can happen for trailing spaces, `::first-letter`, and a few other cases. |HitTestCulledInlineAncestors| checks if the current fragment is the first one in the line, but only by checking |LayoutObject|, so it fails when a |LayoutObject| is fragmented. This patch adds check if the current fragment is from the same |LayoutObject| as the previous sibling. Bug: 1009042 Change-Id: Id9cd8b834528bda999fb557e0a6f0d2aeec69e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262401Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#781846}
-
Bret Sepulveda authored
TBR=zatrudo@google.com Bug: 1098359 Change-Id: Ia11ea7fb24f0c1de6494546620baba44d56c15f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263875Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#781845}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2975a0d2f04a..46ce35498890 2020-06-24 treehugger-gerrit@google.com Merge "Fix links to old docs page." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1986b80411336e2e1c08194122437b442988da35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263183Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b021d08278b8..5040a447f271 2020-06-24 changhaohan@chromium.org Disable Grid adorner interactivity 2020-06-24 sigurds@chromium.org [issues] Link frame resource to rest of devtools 2020-06-24 mathias@chromium.org Update What's New UI for Chrome 85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1066772,chromium:1095617,chromium:986998 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6ab835518fc09a50382a82f075121f519fc27ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263186Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592977371-60cb1203aa6c110107f3f77527ea01cdc8177bb5.profdata to chrome-mac-master-1592999982-db22937bc7e305fa743bdb260ed4ee93f882ca20.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I55b8e8b6be04189c0dddda44d142571a75d29f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263189Reviewed-by:
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Ibeb7cc26e331161c5a1490b84ef5a59ecd122413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254029 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#781841}
-
Tommi authored
Some modern webcams such as the Logi 4K camera don't work with the mjpeg path as we currently set it up in our avfoundation code, although they do appear to work in that mode with the aid of VTDecoderXPCService if another app has first opened the camera. The reason we did this initially, is documented in issue 346634 and is related to CPU load in VTDecoderXPCService when using it to translate from mjpeg to a format we ask for. This was an issue 5-8 years ago and in my testing, is not an issue today with some of the same cameras. For that reason and to get better camera compatibility, I think it's safe to remove this resolution based switch. Bug: 346634, 1077871 Change-Id: I2a21aae2227d6c8c7b20ab7c3602e31dc54bc6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264053Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781840}
-
Vladimir Levin authored
This patch fixes a bug that happens in the following situation: - We find some text - Exit the selection, while keeping the selection - Scroll the auto locked context off screen, so the only thing keeping it unlocked is selection - Find the same text again which will first clear the selection, causing us to lock in the mind of a find-in-page and invalidate self layout for the object, which ultimately results in a DCHECK. This patch addresses the issue by deferring selection clear when activatable locks are forced to the beginning of the next lifecycle. Visually this is equivalent, but we simply defer the lock to the beginning of the frame instead of in the middle of another operation. R=chrishtr@chromium.org Change-Id: Ibd296197638ab66dd4714b4d95cd0371ef67d5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261617Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781839}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09f635e5871b..755c65d8b5cc 2020-06-24 handellm@webrtc.org Reland RtpTransceiverInterface: introduce SetOfferedRtpHeaderExtensions. 2020-06-24 mbonadei@webrtc.org Add absl_deps to webrtc_fuzzer_test. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1046390,chromium:1051821 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5fef501f80414a75d1a420f5b62426a8f237cc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263185Reviewed-by:
-
Ali Juma authored
This CL cancels prerendering when a prerendered WebState tries to load an unsafe URL. This fixes a bug where a prerendered page would try to load an unsafe iframe, and that load would be blocked but prerendering would not be cancelled, resulting in that iframe being rendered with empty contents when that prerendered WebState is loaded into the WebStateList. This also makes explicit that prerendering should not be used for unsafe main frames. Currently, prerendered unsafe main frames are blank, but are implicitly not used because of an unrelated early-out in PrerenderServiceImpl:: MaybeLoadPrerenderedURL, since the last committed URL in the prerendered WebState matches the last committed URL of the active WebState. Bug: 1091182 Change-Id: I4034c0abed2c09910d7e1b9249dbc47080c946ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233612Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#781837}
-
Sreeja Kamishetty authored
This CL removes kActive checks which are surplus in querying the RenderWidgetHostView/is_main_frame as we don't need to worry about accessing the per-page objects unless they update any states. This will help in cleaning up additional lines of code. BUG=1096019 Change-Id: Ifa24ea60179e5c26cd00ac36be83bb3356bf7bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249057Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#781836}
-
Nico Weber authored
Bug: 1098738 Change-Id: Ibab53f0dd1c24e28f82d5b5d22abffc934a05782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264152 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781835}
-
W. James MacLean authored
This CL adds a test for https://chromium-review.googlesource.com/c/chromium/src/+/2247749. Bug: 1076450 Change-Id: I1111f5b06b81fe4b58e0eba530dde10a35b6c006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254461Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#781834}
-
Nohemi Fernandez authored
This patch also removes mentions of 'experimental' in code. Bug: 1097994 Change-Id: I8bd8a8748e7d7511d514d705ad5bcc3898464901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260777 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
The data is still interesting. Bug: 1095039 Change-Id: I2ba18ec980a2978521609eab7b6e6973679c251d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247882 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781832}
-
Bret Sepulveda authored
This reverts commit 533f873d. Reason for revert: Causing consistent failures on Linux CFI bot in All/DocumentPolicyParserTest.* and DocumentLoaderSimTest.* See example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/17607 Confirmed by local revert. Original change's description: > Switch from LinkedHashSet to HashCountedSet for DocumentPolicyFeatureSet > > bartekn@ is planning to remove custom hash support for LinkedHashSet. > To unblock him, use HashCountedSet for DocumentPolicyFeatureSet > for now. > > Bug: 1069021 > Change-Id: I94218dbd29eb59f26d67bdd52d990f21a7af26ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259484 > Commit-Queue: Charlie Hu <chenleihu@google.com> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781396} TBR=iclelland@chromium.org,chenleihu@google.com Change-Id: Id5004e1f73104d09bd0ac752a9b13b09569d6128 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264352Reviewed-by:
-
Olivier Robin authored
Safe mode require sceneState to be fully initialized. Bug: 1080907 Change-Id: I7626acf96444ae8ba5f15b2a5939109cc2b3ceef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263161Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781830}
-
Denis Kuznetsov authored
Added OOBE-specific screens Bug: 1073095 Change-Id: I06a66b4eb00e274ebec2e314b8f8a6078b4d1541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263813 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#781829}
-
Mikel Astiz authored
Undeletions as a concept no longer exists within the sync engine because changes as propagated as-is to model processors. The tests deleted here are hence outdated, exercise the legacy codepath only, and are conceptually similar to the undeletion-related tests in processor implementations, most notably ClientTagBasedModelTypeProcessorTest. A few scenarios lacked unit-test coverage. There are various integration-like unittests and browser tests, but a bunch of new unit tests have now been added for them. Change-Id: I8487887628df1d9c20caf680b7d441d5a654d702 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260661Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781828}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/88ed5b1e..15229ea0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I923e7a4249ea6a4d8e5f3258168e53c2b4cba0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263793Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781827}
-
James Cook authored
Bug: none Change-Id: I4abbefaddd045a8deea708bb13056fc137ba7a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262112 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781826}
-
Raphael Kubo da Costa authored
This is sort of a reland of https://crrev.com/c/2260872, but rather than calling bytes.decode() on every line we pass |universal_newlines=True| to subprocess.Popen() so that |lines| is still a string and not a bytes object in Python 3. This approach does not cause the significant slowdown during linking that led to the previous CL being reverted. Bug: 941669 Change-Id: I92bc14d4dea01085f9f81153f610663960cc2fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263712 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Alex Danilo authored
Creates a new 'multi_menu_button.js' file that encapsulates all the menu button logic in there and moves all the sub-menu specific code to 'multi_menu.js'. Result is that the cr.ui.MultiMenu type can be used anywhere a cr.ui.Menu is used with the sub-menu functionality encapsulated in the implementation so that a caller using cr.ui.MultiMenu doesn't need to know it behaves differently to a normal cr.ui.Menu (which can have only one level of menu). Uses the 'decorate' pattern class cr.ui.MultiMenu to extend the functionality of cr.ui.Menu by chaining decorate() calls to combine the properties and methods of both classes onto the one object. Adds an 'activate' listener on any active sub-menu which fires on the parent element so that any element attaching a cr.ui.MultiMenu will have it's activate listeners fired from either the top level or child (sub) menus. Monkey patches a few methods to hide the existence of multiple layers of menu from the hosting element. No change in behavior, minor update in unit tests to directly reference the menu itself since the menu button is now distinct from the menu it hosts. Bug: 1002396 Tests: browser_tests --gtest_filter="*MultiMenu" Change-Id: Id61eb161730656cd2916c85a2188359e8403fca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248389 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#781824}
-
Clemens Arbesser authored
This CL moves ownership of the radio button controller into the generic-ui controller. It also moves the implementation into autofill_assistant component, which allows easier unit-testing. The change of ownership is required for an upcoming refactoring, where nested UI controllers should not create their own independent radio button controllers. Bug: b/145043394 Change-Id: I1a2998b682463892160378d2111899e98d7ce18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253856Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#781823}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1c99a943d920..b021d08278b8 2020-06-24 tvanderlippe@chromium.org Extract e2e-test fixes in prepartion of e2e-tests-on-build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1088463 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8bf29fecf73528a29281297678dfdb846e692a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263181Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0f5a11e32143df0d046905e6744f46011e16cfa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263476Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592971072-917710ea24284ef9aa6ebcca30f6d2746c0234cd.profdata to chrome-win64-master-1592981921-d7f3480d3d068518c011ab351ddf99cd52e5b689.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8008b2f9dd8f95775e8b8d19092f809e91885b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263179Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e0c317566197..2975a0d2f04a 2020-06-24 treehugger-gerrit@google.com Merge "Remove unused file." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6e317bda69c475b5d766bcb6968d7fa9ae1f5af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263180Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I64fd8246c491c36211504b2e9b3fcee96564f9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263475Reviewed-by:
-
Oriol Brufau authored
The marker-list-style-position.html WPT test was created by Mozilla, and it relies on inside list markers being affected by ::first-line. However, that doesn't happen in Chromium and WebKit, and the relevant issue (https://github.com/w3c/csswg-drafts/issues/4506) is still open. Therefore I'm adding a 2nd expectation in order to allow both behaviors. Bug: 457718 Change-Id: Id61fbdd07940d541eb7a9638a0fc1aefc13bb545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260618Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#781817}
-
Ramin Halavati authored
Non-Primary OTR profiles are not supposed to be used to create browser windows. "DevTools::BrowserContext" are an exception to this ban and |AllowsBrowserWindows| is added to cover them. Bug: 1033903 Change-Id: Ib7ee274887943106f36ebaf915d48a7843bf73d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250181Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#781816}
-
Cheng Zhao authored
Pen may also send non client pointer events on Windows 10, by treating them as normal touch events we can properly handle them in one place. Without this non client messages from pen would be ignored, and users would not be able to use pen to interact with window's native frame, like dragging titlebar or clicking the close button. Bug: 1093125, 841580 Change-Id: I45703932ee2729f93e3446fdecd1d4633fbf0aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237535 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL is generalizing the ResetSelectedLine() test Before this CL: The test had strong assumptions about the number of entries in the autofill suggestions. After this CL: This is relaxed to be compatible with upcoming feature that adds a new entry in the autocomplete menu to hide the suggestions. Bug: 1030649 Change-Id: I3ce570f295ae211a2d4f4d0e113a7bfb162617fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250599Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Carlos Caballero authored
TabSpecificContentSettings is bound to the page (aka main frame) and might be null at times this TabSpecificContentSettings clients should be able to tolerate null instances. Bug: 1096101 Change-Id: I6aa51f710a92cd883727525a2adf65b2588b5e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260617 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781813}
-
Rune Lillesveen authored
This seems to work with googlesource.com urls and hopefully still will if googlesource decides to rename master. Also, use main instead of master for a github url. Change-Id: I5a7d799fe37535b622be270d3ae9b30d6aa54b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263732Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781812}
-
