- 11 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1bdc5980b3a4..cbf7f5178da6 git log 1bdc5980b3a4..cbf7f5178da6 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rwkeane@google.com Platform: Add Operator < to IPAddress Created with: gclient setdep -r src/third_party/openscreen/src@cbf7f5178da6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0238407c5b3f468baa0a3b7ee6bfe9b2a015a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749028}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8bf3aecd3335..a8e510a1a6cb git log 8bf3aecd3335..a8e510a1a6cb --date=short --first-parent --format='%ad %ae %s' 2020-03-11 abennetts@google.com Fix minor errors in example command lines in bq_export README. 2020-03-10 phoglund@google.com Remove the proto test driver. 2020-03-10 phoglund@google.com Add a small proto->JSON tool. Created with: gclient setdep -r src/third_party/catapult@a8e510a1a6cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: eseckler@google.com Change-Id: I0b07061056783c46f40ac2c9625908bae6663e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095108Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e263aa8a4e6..c5b3cbdb4502 git log 9e263aa8a4e6..c5b3cbdb4502 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 cclao@google.com Vulkan: Use VK_FORMAT_D24_UNORM_S8_UINT for 24 bit depth if available 2020-03-10 tikuta@chromium.org use go swarming client in trigger.py Created with: gclient setdep -r src/third_party/angle@c5b3cbdb4502 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I44aa9c7371615fde48d25eb5f35fdb90f5e460e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097471Reviewed-by:
-
David authored
chrome://media-app uses a postMessage API to communicate between its trusted and untrusted contexts to gain access to privileged functionality such as opening the feedback dialog. Use an object (Message) to indicate the action being communicated across the postMessage API instead of strings which are more error prone. Bug: 996088, b/138961540 Change-Id: I17185bdde143f8fb061ec2000075dd4a463cd7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096057 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#749025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76a104eafd23..08d2ab0bcd7e Created with: gclient setdep -r src-internal@08d2ab0bcd7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: jbudorick@google.com Change-Id: I61adf7c211c082c7b9f46afd07047a482ce66bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097469Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749024}
-
Maggie Cai authored
The intent handling feature is not ready, extend the intent handling flag expiry milestone to 85. Bug: 853604 Change-Id: I4160c649598fba7ab5930c00d43ed8072b9c152f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096797Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749023}
-
Nektarios Paisios authored
In BrowserAccessibilityManager, we were relying on the presence of other accessibility events, such as kChildrenChanged, in order to tricker the firing of a focus event. However, when page navigation is cancelled, or is simply completed after the page contents have been loaded in the accessibility tree, there are no other events that would tricker the focus event. This creates a situation where the screen reader does not move its virtual cursor to the web contents. As a result, focus appears to be nowhere, and the user develops the mistaken belief that the virtual buffer in screen readers such as NVDA is also blank. R=dmazzoni@chromium.org, kbabbitt@microsoft.com Bug: 1058959 Change-Id: I29150977d032152d5337889b1ae0c2e196fda065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095758Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#749022}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I733476b0febb6bb0db715b6710d69c4dd857b469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094874 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#749021}
-
Sam McNally authored
CrasAudioHandler converts media metadata from UTF-16 to ASCII. This is invalid if the metadata is non-ASCII, which it can be. This DCHECK fails when converting and later CHECK fails trying to send over D-Bus. Convert to UTF-8 instead. Bug: 1059929 Change-Id: I367e6ab718a1e875a69fd551e8c2e5c68a00f139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096328Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749020}
-
Jonathan Kingston authored
Bug: 1011830 Change-Id: If411450952c0e4018933eba636d168d98ece90cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070201 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#749019}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8332950f4a88..430e4a09e0ca git log 8332950f4a88..430e4a09e0ca --date=short --first-parent --format='%ad %ae %s' 2020-03-10 minyue@chromium.org Allow to negotiate absolute capture time rtp header extension. Created with: gclient setdep -r src/third_party/webrtc@430e4a09e0ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I20f1a13f7bd93e730fbecdb51e355934a9e813de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097474Reviewed-by:
-
sczs authored
- If the Coordinator that owns the InfobarBannerVC is destroyed before the InfobarBannerVC finish disappearing then infobarBannerWasDismissed won't be called. This means that the InfobarContainerCoordinator in charge of queuing the InfobarCoordinators/Banners won't know its time to present a new Banner. In order to achieve this an InfobarBannerContainer delegate is set directly on the Banner. - If the Coordinator that owns the InfobarBannerVC still exists once the InfobarBannerVC has dissapeared then we should let it handle the next banner presentation (e.g. Translate might present another Banner) - When InfobarCoordinator is presenting a Banner, we currently do not hold a strong reference to it in the completion block, so if the InfobarCoordinator (along with the transition/presentation objects) gets destroyed then the presentation looks like Bug 1057125. We also do not do some cleanup tasks like configureAccessibilityForBannerInViewController, which are needed. Since stop is called whenever the Coordinator is destroyed then badgeDelegate should be nil and we shouldn't be trying to update the badge then. Bug: 1057125 Change-Id: I12f3437a2bf23d2e54ff05a146d2bd4bd0459e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090711 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#749017}
-
Peter Kasting authored
Also moves this to ui/base/pointer/, and while I'm touching all the lines anyway, renames GetInstance() to Get(). Bug: 940769 Tbr: gab Change-Id: I399c3502e8d67f8e70c513ce1d3a9d9648fa6e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092426 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749016}
-
Sebastien Marchand authored
Most of the coverage configuration can be re-used for general Clang-based profiling (e.g. the profiling step of a PGO build). This changes most of the |use_clang_coverage| checks to |use_clang_profiling|. The toolchain opt-out option is still limited to the coverage builds (grep for "toolchain_use_clang_coverage" in CodeSearch). I.e. targets built simply with |use_clang_profiling=true| won't be opted out by the clang_code_coverage_wrapper.py script. This CL is a pure refactoring with no functional change. Getting profiling information from the sandboxed renderers work this way: - After creating a new child process the browser will open a profiling file for this process and pass the handle to the child via the SetProfilingProfile Mojo call (see change in content/browser/renderer_host/render_process_host_impl.cc). - This process will used by the LLVM instrumentation to record profiling information. - When terminating, child processes will call WriteClangProfilingProfile to write the data to the profiling data file. - Once all the raw profile data files have been collected, they'll be merged (via the "llvm-profdata" tool) and used. Note that this isn't meant to be enabled into any build that will be shipped to users (a profiling build is usually 10x bigger than a normal build anyway, not really shippable). The goal of this refactoring is to make it possible to reuse this mechanism for the instrumentation step of PGO builds. Bug: 1058979 Change-Id: If8321234f6b6f86befd81f6e9e068a342728d605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090493Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sajjad Mirza <sajjadm@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#749015}
-
Joseph Kim authored
Typo in comment and unused variable. Change-Id: I72ef1da2ec445d088faf61c181783c4b8f3b5f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091094Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Joseph Kim <josephkimsh@google.com> Cr-Commit-Position: refs/heads/master@{#749014}
-
Kevin Ellis authored
https://github.com/w3c/csswg-drafts/issues/4822 Bug: 1059772 Change-Id: Id21c3c152f8cf6771703a16fcab8e80686608170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090197 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#749013}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ab98a3792093..715c8c459f00 git log ab98a3792093..715c8c459f00 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 brcui@microsoft.com Infobar Improvements Created with: gclient setdep -r src/third_party/devtools-frontend/src@715c8c459f00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056348 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I593aa05cee03aaabb044bb3118c73587d822eb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097473Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf355123ae3b..3e192165cb65 git log bf355123ae3b..3e192165cb65 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 jvanverth@google.com Hoist GrVkResource up so it can be used for D3D and Metal. Created with: gclient setdep -r src/third_party/skia@3e192165cb65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I2196c14f5c9ff4230123de180cdc5f1427d297e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097472Reviewed-by:
-
Sajjad Mirza authored
crrev.com/c/2071164 created an unusued operator<< for this type which conflicts with the autogenerated one in the out/ directory. In most builds this is OK because the bad definition is `inline`, but never used, so the compiler never emits into an object file. However in a coverage build the symbol has to be emitted so that coverage can be tracked, and then it collides with the other operator<< definition. Note that it's illegal to have both inline and non-inline definitions of the same function in C++, so this was always invalid code, even though it took a behavior of the coverage system to expose it. Bug: 1060343 Change-Id: Ifb5f5143fa5d651e17305ba1b364b22af644b93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097128Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#749010}
-
Chris Lu authored
Adds metrics to track user taps on the overflow badge, the number of times the overflow badge is shown, and when a user taps on a row in the overflow menu. Fixed: 1055549 Change-Id: I43fa4fcb2bced7bdcda5209688fba5ffe5066e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076662 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Ryan Sleevi authored
This reverts commit d828e2eb. Reason for revert: Despite the original description, this didn't update schema_org_properties with the correct //base dep, causing build flakiness again. Original change's description: > Reland: "Add validator for schema org entities and types in doc metadata mojo." > > " > * Add a validator that removes properties that are not the right type. > * Add double, time, and timedelta types in the document metadata mojo > structure. > * Use the new mojo types in document metadata extractor. > " > > This is a reland of https://crrev.com/c/2062907 which was reverted in > https://crrev.com/c/2095670. > > The substantial changes are two-fold: > (1) add build dep on base in schema_org_properties. This should fix the > try bot issue which was somehow skipped. > (2) Rebase on top of https://crrev.com/c/2073337 which was submitted and > contains some changes to the mojo structure. > > Change-Id: I7f47d74e8833f76d4077028eac0dcb43790a1d26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097059 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#748945} TBR=dcheng@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I3e6b80e0469267cc658ba2f2ac63bbcdc0d913e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097190Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749008}
-
Kei Nakashima authored
In the current code, |insert| doesn't work correctly since it does not update prev/next indices when free list is not empty. This CL fixes it. Change-Id: I6355bfd61e4a7b8f928a462e45fb98702f005f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094491Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Tom Anderson authored
A very commonly recurring bug is forgetting to call ParentClass::OnThemeChanged() in DerivedClass::OnThemeChanged(). This CL adds a DCHECK that attempts to address this issue. In the process, many missing OnThemeChanged() calls were discovered. It's probable that some of these may cause unexpected colors in certain UI that was relying on the hardcoded default colors. BUG=None R=sky CC=pkasting Change-Id: Ifad583b4bce077454b1f9f1c7df4762b966b026b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090713 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Alex Newcomer authored
This continues to be useful to our team, bump it by a year. Bug: 1043691 Change-Id: I68a729b54c11e96569f5f3880c188b6b1b2e2f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085376Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#749005}
-
Noel Gordon authored
To expose more of the elider button tap-target surface, move the drop- down menu vertically down. Use for 4px for now, to semi-align with the other toolbar action-icons that have a drop-down menu [1]. [1] In future CLs, we should consider moving all the action-icon menus down by 8px so their menu top position aligns with their <button> tap- target box bottom position => issue 1059490. .___. | | <= <button> tap-target 48px box |___|_________. | | | menu-item 1 | | menu-item 2 | <= drop-down menu box | menu-item 3 | |_____________| Bug: 1035691,1059490 Change-Id: I1fbea5c42f47906775dbb3c89c9104d02168c888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096321 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#749004}
-
Joel Hockey authored
Delay first progress output for startup status so that terminal opened when crostini is already running should expect no display. Removed emojis. Bug: 1016680 Change-Id: Iedd177241430980b6232bbd3d08343a1437f0009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096060 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#749003}
-
Bettina authored
Real time url checks are currently allowed for MBB users. Real time url checks with tokens are allowed for only users with MBB and sync enabled. Now, users will only have to enabled enhanced protection to get real time url check with or without tokens. Bug: 1059994 Change-Id: I470ed7396dbc16fa95ebb3d44699f41f0c0e09c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095917 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749002}
-
dpapad authored
The enum is used by the WebUI.Settings.PathVisited histogram. Bug: 1059098 Change-Id: I5ce62b70691ed810834b5ed5ce18b326bf8fca0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097358Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4bdcfb7b6e69..8bf3aecd3335 git log 4bdcfb7b6e69..8bf3aecd3335 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 chonggu@google.com [Telemetry] Add logic to test whether port forwarding has started. 2020-03-10 eseckler@chromium.org trace_data: Raise exceptions only after traces are added to artifacts Created with: gclient setdep -r src/third_party/catapult@8bf3aecd3335 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058255,chromium:1059767 Tbr: eseckler@google.com Change-Id: Ic24d0e80802261b818624eee5424dadd434fdb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097466Reviewed-by:
-
Luciano Pacheco authored
Bug: 1058536 Change-Id: I153bc4fd016523e5aa44409798326237e180c247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096798 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748999}
-
Piotr Bialecki authored
Change-Id: I554f2879cee4bd87160ccfc48c63e93aab236970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097465 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#748998}
-
dpapad authored
This regressed at r742504 Fixed: 1059855 Change-Id: Ife8236a8eea460536bb9c8a440a92fcea865b86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097355 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748997}
-
Luciano Pacheco authored
The new breadcrumbs is positioned only on top of the file list/grid, instead of on top of directory tree and file list/grid, this changes the logical order of the tab sequence. Additionally, because the new breadcrumb is a custom element with shadowRoot, using tabindex > 0 on its sub-elements doesn't follow the desired order and having the tabindex > 0 is not recommended by lighthouse [1]. This CL changes all Files app tabindex to 0 instead of greater than 0. For previous design this doesn't change any tab order, for the new design it has a different order and this is desired due to new breadcrumb position, see bug for tab order details. This CL updates the tab_index.js integration tests to have these 2 different tab orders. Change helper function checkNextTabFocus() to dive in to shadowRoot to be able to test the breadcrumbs sub-elements being focused. [1] - https://developers.google.com/web/fundamentals/accessibility/focus/using-tabindex Bug: 1059137 Test: browser_tests --gtest_filter="TabIndex/*" Change-Id: Id39f2b1347235858b394229227e10288fe157b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089192Reviewed-by:
-
Henrique Nakashima authored
Bug: 1012975 Change-Id: I5d4d97d0826238cd296f630c3bc82c18283b1905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095567Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748995}
-
Will Harris authored
BUG=767906 Change-Id: I7016b8ffe9b07345f008916c5b7b54462edb5b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097239 Auto-Submit: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748994}
-
Xiaohan Wang authored
These are currently only used for Flash, which is scheduled to be deprecated in M87 (https://www.chromium.org/flash-roadmap). Hence, delay the expiry to M87. Bug: 1037200 Change-Id: Icfb64eda728eea20d39f299407217729fd3e335a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097459 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Tommy C. Li authored
This CL puts a very simple cr-autocomplete-match-list web component within the chrome://resources/cr_components shared directory for usage in both the top chrome omnibox (experimentally under a flag) and the WebUI NTP. Bug: 1046561 Change-Id: I760d7ce2b4eeebf63277a9ca1ca5891bf49dcef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091631 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Darren Shen authored
Change-Id: I1aec44b39dca1a7d3a85e3ac962643de4fa6e979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096326 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#748991}
-
Jun Cai authored
This CL converts base::Closure to base::OnceClosure in //components/sessions Bug: 1007732 Change-Id: Ib49c7e022e67a974e79637f386f941f627abcd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097018Reviewed-by:
-
Raymond Toy authored
Convert more places including: filters/decrypting_demuxer_stream filters/decoder_selector Also needed to pass a TimeDelta object by value to fix a presubmit error about passing Time objects. Bug: 1007799 Change-Id: I8f9b363a8a28dcbdae566e20d9cf73ca0820c768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092168 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#748989}
-
