GitLab

We already did this in Chrome [1], and we should also do it here to
prevent confusing error messages for old devices that are not using
cros-camera service.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_stream_manager.cc?l=541&rcl=db450183134eacfd8b877f7c55ada55f52d4dd1f

  "bind /var/run/camera/camera3.sock: Permission denied (13)"
  on old devices.

Bug: b:132770443
Test: Passes capture_unittests, and there is no error message like
Change-Id: I02a0bab188a242b0690fb1f24f123305bb2d5dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627273
Auto-Submit: Shik Chen <shik@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662583}

No behavioral changes are expected, although it's not trivial to claim
so due to subtle ordering changes.

In particular, the registration of control types is now taken care of
in SyncManagerImpl, immediately before NotifyInitializationSuccess() is
run, which continues in SyncEngineBackend where the old code lived.

Somewhat related, the mechanism to brodcast SyncEncryptionHandler-
related events via a proxy observer is also moved to SyncManagerImpl.

We do this in preparation for changing the behavior in future patches.

Bug: 922900
Change-Id: Ie43d06e40403e1bb0476ffec6f82d2596e018588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619813
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662582}

Replace both of their usages by didInsertWebState.
Previously willOpenTab was called from WebStateListObserver's method
didInsertWebState defined in TabModelNotificationObserver. Also didInsertTab
was called from didInsertWebState defined in TabModelObserverBridge. The problem
is there are expectations for the didInsertTab to be called before willOpenTab.
And that it just happens that they get run in the proper order based on which
one is inserted first!
To fix this problem I'm adding a restoration state to TabModel, and entirely
removing the TabModelNotificationObserver. This state (isRestoringSession) will
be used by BVC to determine if the animation part of Tab should run or not
(previously located inside TabModelNotificationObserver which was disabled when
the restoration starts and re-enabled after the restoration is done). This
should be considered a temporary solution as the optimal solution is to move
restoration logic out of TabModel and have a keyed service for it and use the
service to get the restoration state.


This CL also :
Changes tabViewForTab to tabViewForWebState in TabStripController.
Changes updateContentOffsetForTabIndex to updateContentOffsetForWebStateIndex
in TabStripController.
Introduces initiateNewTabAnimationForWebState which handles the logic of
starting the animation previously handled by TabWillOpen in BVC.
Changes animateNewTab to animateNewTabForWebState in BVC.
Updates DisplaySyncErrors in sync_utils.h/mm to take webState instead of Tab as
input and its users.
Updates ReSignInInfoBarDelegate::Create to take webState instead of Tab and its
users.

Bug: 911350
Change-Id: I9aa62b85dfa2a7fcb63b5a1c85c2a5336823cc35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617547
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662581}

This CL moves some referrer and back-forward-list related code from
CRWWebController into CRWWKNavigationHandler.

Bug: 956511
Change-Id: I5411795ab6d814ea38e075804889b76d6a3c20d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624808
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662580}

Clear the response_body_loader_client field on ScriptResource when the
resource body finishes loading. This matches what the ResourceLoader
does, and removes a memory leak.

Bug: 944471
Change-Id: Icd2ef954c7f19624f4947a816882ef028321c95c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626858Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662579}

The crashes occur (on beta channel) when network service is enabled and
web_contents are null, see crbug.com/965488.

Fix: Similar to chrome, early-out when web_contents is null.

BUG=841556,965488

Change-Id: I37a1f5c4d992507adfc4693f4d348ecba993c387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622205Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662578}

This reverts commit db977c4b.

Reason for revert: Suspected culprit for failing Linux ChromiumOS MSan Tests. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/13070

Original change's description:
> Mash cleanup: begin converting login mojo to C++
> 
> This patch moves types implemented in login_user_info.mojom to
> //ash/public/cpp/login_types.h. The handful of methods on
> mojom::LoginScreen which used these types are moved to C++
> interfaces.
> 
> There are two new public-facing C++ interfaces:
> 1. ash::LoginScreen, which is a direct translation of the mojom.
>    This is implemented by ash::LoginScreenController.
> 2. ash::LoginScreenModel, which is used for the methods that
>    were simple thunks in LoginScreenController.
>    (LoginDataDispatcher implements this interface.)
> 
> Bug: 958206
> Change-Id: I329d606b234556bf05aee40849f3aa5ccc6c0be0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610588
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662372}

TBR=xiyuan@chromium.org,estade@chromium.org,tsepez@chromium.org

Change-Id: I0b132ea591725613e9cf2751a099f8376546a18f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 958206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626420Reviewed-by: Lowell Manners <lowell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662577}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8d98ba69205..22003298ae1b


Created with:
  gclient setdep -r src-internal@22003298ae1b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: I9b97a432c650a667570e7cf58035fd6a77a23cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627296Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662576}

The copy_bundle_data tool is implemented in terms of pax for directories
and ln hard links for files. The pax command does preserve symbolic
links within the tree that is being copied. But with the way that pax is
invoked by the tool, cd-ing into the source, if the source is itself
a symbolic link to a directory, the tree will be logically copied rather
than just as a symbolic link.

A similar issue exists with the non-directory symbolic link source case,
where a hard link will be produced instead of a symbolic link.

Fix both of these cases by specifically testing if the source is a
symbolic link and then re-creating it if so.

Bug: 955936
Change-Id: I69cf96878e59b0b7b121ae46cba5bc1e81f261ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626269Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662575}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/24e3eea4..bd0a8835

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I57e8105e16ca8e10d615230da10d4b98e5fb784c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625793Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662574}

Note that <image>, <transform-list> and <transform-function> syntaxes
aren't shipping at this time, and remain enabled for testing only.

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QjcyhPZ_sNI/SuB-GuNPDAAJ

Bug: 641877
Change-Id: I548db4896c355ab61c0b3a98bfa5119c2fd896f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623945
Auto-Submit: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662573}

This function is never used except in the function unit tests.
Remove it and the corresponding unit tests.

Bug: 842655, 964232, 714018
Change-Id: Ia0e2f85dd86019db776dfed9980b4800def49580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627370
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662572}

During experimentation phase, passwords sync metadata got corrupted
when trying different approaches during the USS passwords sync launch.

This CL is pumping up the database version and clean any
potentially corrupted sync metadata.

This is safe because the corrupted version influenced only
Canary and Dev users, and hence very small number of users should
be affected.

This CL only clears the sync metadata and doesn't remove any password
data. Users will then automatically go through the first sync
experience!

Bug: 902349
Change-Id: If6179c814045b24c16aff8d34b769dc8fe14aaad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625114
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662571}

Before this CL:
The PasswordSyncBridge report a model error whenever adding a password
fails.

After this CL:
Depending on the reason of the failure, if the reason is the remote
update contains an invalid password data, the bridge will instruct the
processor untrack that entity and ignore that update.

Bug: 902349
Change-Id: I5fbb04e91d888593e4ecf0cd028c116ce3a1a3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622211
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662570}

Changing -[AdvancedSigninSettingsCoordinator abortWithDismiss:] to
-[AdvancedSigninSettingsCoordinator abortWithDismiss:animated:completion:]
This is to prepare the main controller to dismiss the SigninInteractionCoordinator.

Related to: http://go/open-url-unity-project

See: crrev.com/c/1621136

Bug: 965463
Change-Id: Idd560498c544a9165a59274f41239fa9c968fd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621172
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662569}

Multilogin was using GoogleServiceAuthError, but it's misleading.
In particular, it was using INVALID_GAIA_CREDENTIALS to represent
transient errors, which is not intuitive.

This CL uses a new error type instead.

This CL also does some cleanup in oauth_multilogin_result:
- removes the use of JSONReader::ReadDeprecated(),
- removes uninitialized variables in parsing code which would
  cause the behavior to be inconsistent when keys are missing.

Bug: 956570
Change-Id: Ic5b29dcea8753b4c471fc5a943326436f59e6d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588557
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662568}

Bug: 520391

Change-Id: Ica3bc5d021cf406e6c0743ed5691b6475e3151ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625792Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Auto-Submit: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#662567}

This CL adds Finch-activated IPH bubbles pointing to the autofill
suggestion chips in the Keyboard Accessory bar.

Screenshots: (supposed to be public, fallback below)
https://storage.googleapis.com/chromium-translation-screenshots/c7398a54e31c16465587c316a41f47c3b457fe57
https://storage.googleapis.com/chromium-translation-screenshots/10e4465d1a9ae7342337b6042611348482ffceaf
https://storage.googleapis.com/chromium-translation-screenshots/415cb951b4882a3d26048284f875747f2836b4c8
Fallback screenshots:
https://photos.app.goo.gl/42TLVALJWSPWsbiKA
https://photos.app.goo.gl/GVg7U3hm5tGNHt229
https://photos.app.goo.gl/kSM3xTA1JhfFBYNx9

The IPH will be activated via Finch by defining studies as shown in
testing/variations/fieldtrial_testing_config.json. To test the IPH,
save a configuration as shown below to ~/tmp/SomeStudy.json and
launch chrome with:
  python ./tools/variations/fieldtrial_util.py \
  ~/tmp/SomeStudy.json android shell_cmd | xargs -I {} \
  out/AndroidDebug/bin/chrome_apk run --args="{}"

Below, one example study that shows IPH iff ...
 ... the feature becomes available to the user (no delay),
 ... it wasn't used at least twice within the last 90 days,
 ... the IPH hasn't already been shown within the last 90 days
 ... and *no* other IPH was shown during this session.
This is also how I intend to launch them and how all three are
currently defined in fieldtrial_testing_config.json:
{
    "KeyboardAccessoryAddressIPH": [
        {
            "platforms": [
                "android"
            ],
            "experiments": [
                {
                    "name": "Address_IPH_Enabled",
                    "params": {
                        "availability": "any",
                        "event_trigger": "name:keyboard_accessory_address_filling_iph_trigger;comparator:<1;window:90;storage:360",
                        "event_used": "name:keyboard_accessory_address_suggestion_accepted;comparator:<2;window:90;storage:360",
                        "session_rate": "<1"
                    },
                    "enable_features": [
                        "IPH_KeyboardAccessoryAddressFilling"
                    ],
                    "disable_features": []
                }
            ]
        }
    ]
}

Bug: 911085
Change-Id: I4477365faf881256804b50c8bc15397cfcb0eed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585883Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662566}

This patch enables port matching in network::OriginAccessList.
Callers in Blink and chrome, or extensions will specify port
information to support port matching in following CLs.

In this CL, all callers still use kAnyPort not to make any
behavior changes.

Bug: 936900
Change-Id: I572ee883050035acb719aaabf71355048472c43a
Tbr: rdevlin.cronin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617561
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662565}

WebThreadSupportingGC is mostly wrapping blink::Thread. Code should use
blink::scheduler::WorkerThread instead.

This CL replaces all the WebThreadSupportingGC::Post*Task() methods by
TaskRunner's Post*Task() ones. That requires a new temporary API in
WebThreadSupportingGC to retrieve the TaskRunner. This will ease the transition
from WebThreadSupportingGC to WorkerThread.

Bug: 961743
Change-Id: I7f323e1a3d79b7c70ee45152df90b841b9a5975f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625107
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662564}

Start WilcoDtcSupportdManager only if WilcoDtc feature is set.

BUG=b:123926541
TEST=local device

Change-Id: I3caab04b1445c43b8a32e4a8ef1bfbbaa357b871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604275
Commit-Queue: Polina Bondarenko <pbond@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662563}

PasswordStore::AddLogin() can fail for various reasons.
Before this CL:
AddLogin() returns an empty change list in case of error.
After this CL:
AddLogin() accepts an optional output parameter to report the exact
error. This is required for Sync machinery because it will react
differently to different bugs.

Follow up patches will consume this output parameter.

Change-Id: I2e58d945cbd4f3a099e27dce75075062f24b0785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621135Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662562}

Moves CertVerificationError into //ios/web/security so that it can be
shared between CRWWebController and CRWWKNavigationHandler.

Bug: 956511
Change-Id: I69ec8ed7112f7e69a6d7ebb8303eb91b0de6687c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620639
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662561}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9d034a4e2c20..b8d98ba69205


Created with:
  gclient setdep -r src-internal@b8d98ba69205

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: Ib7992d09d58a127fc28cde1f4d935aba7b13da24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627293Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662560}

Unified Plan has been default for a while. Fixed the message to reflect
that.

drive-by: remove redundant expectation file for passing test.

Bug: 965989
Change-Id: I1544e6b8016ca459f0ffa6470ac762240f8127a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624909
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662559}

The last comment on the bug suggests this is no longer applicable. If
so, we should remove the suppression.

Bug: 347534
Change-Id: I9da64043c95c167a5cab72f09645f6db9a3a50f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625099
Commit-Queue: Adam Klein <adamk@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662558}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d49c2a06..24e3eea4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id539e9f2b9ac756f15e189b6de3cb52f718b2039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626642Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662557}

https://swiftshader.googlesource.com/SwiftShader.git/+log/cae8cde7fa65..8458639991d4


git log cae8cde7fa65..8458639991d4 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 swiftshader.regress@gmail.com Regres: Update test lists @ cae8cde7


Created with:
  gclient setdep -r src/third_party/swiftshader@8458639991d4

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Change-Id: I56877e4f927aecda7ed5226cfad4c7b1df626e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627292Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662556}

We currently discard any NavigationRequest that matched a DidCommit*
IPC but that had a different URL than returning parameters. Instead,
we just modify the internal state of NavigationRequest to have the
returning URL instead.

See the design doc in the bug for discussion about why this is an
okay change to make.

Bug: 963396
Change-Id: If7f2a158ff1901e5403a3bc88b0bcd7e83f48aba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554760Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662555}

https://skia.googlesource.com/skia.git/+log/e85b6a54b641..550868a2b2b4


git log e85b6a54b641..550868a2b2b4 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fb8e1b25ad71..8224a58b4749 (5 commits)
2019-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src aacbdfe8..a410b698 (444 commits)
2019-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f4d2a446cc12..cae8cde7fa65 (12 commits)


Created with:
  gclient setdep -r src/third_party/skia@550868a2b2b4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Change-Id: Ic332d69e101382793d80cd79fc9712f259630823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627289Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662554}

When on the verified origin in a Trusted Web Activity, the page's theme
color will be used for the status bar. Previously this was ignored and
the toolbar color provided by the client was used. The page's theme
color takes precedence over the toolbar color if provided.

This results in the following logic for the status bar color in TWAs:
- If on the verified origin:
  - If the page has a theme color, use that.
  - Otherwise if the client provided a toolbar color, use that.
  - Otherwise use Chrome's default.
- Otherwise, if not on the verified origin:
  - If the client provided a toolbar color, use that.
  - Otherwise use Chrome's default.

Bug: 964914
Change-Id: Ic41f4cfd1b834fdc9c3444f33dc163de52c9792f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624332
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662553}

This temporarily disabled the test to unblock webrtc from rolling in to
chromium.
After the roll, this CL[1] will fix the failure and the test can be
re-enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1621912

TBR=guidou@chromium.org
NOTRY=True

Bug: webrtc:10453
Change-Id: I732b6680e318d55c0700540982a01dbc8ee086a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627030Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Auto-Submit: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662552}

This reverts commit 9f25eee5.

Reason for revert: UnifiedAutoplaySettingBrowserTest.Block_Wildcard failing

The UnifiedAutoplaySettingBrowserTest.Block_Wildcard test is failing consistently on linux-chromeos-dbg, e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12528.

#0 0x7f7f4f902c7f base::debug::CollectStackTrace()
#1 0x7f7f4f66af5d base::debug::StackTrace::StackTrace()
#2 0x7f7f4f66af18 base::debug::StackTrace::StackTrace()
#3 0x55f1ab98d34d content::(anonymous namespace)::DumpStackTraceSignalHandler()
#4 0x7f7f0f0a1cb0 <unknown>
#5 0x7f7f4921a366 std::__Cr::default_delete<>::operator()()
#6 0x7f7f4921a2ef std::__Cr::unique_ptr<>::reset()
#7 0x7f7f49219c5d std::__Cr::unique_ptr<>::operator=()
#8 0x7f7f49219726 gfx::AnimationContainer::SetAnimationRunner()
#9 0x7f7f4a35f1fa views::AnimationDelegateViews::UpdateAnimationRunner()
#10 0x7f7f4a35f2f9 views::AnimationDelegateViews::OnViewRemovedFromWidget()
#11 0x7f7f4a4d55f0 views::View::PropagateRemoveNotifications()
#12 0x7f7f4a4d54d3 views::View::PropagateRemoveNotifications()
#13 0x7f7f4a4d54d3 views::View::PropagateRemoveNotifications()
#14 0x7f7f4a4d54d3 views::View::PropagateRemoveNotifications()
#15 0x7f7f4a4d54d3 views::View::PropagateRemoveNotifications()
#16 0x7f7f4a4d54d3 views::View::PropagateRemoveNotifications()
#17 0x7f7f4a4d54d3 views::View::PropagateRemoveNotifications()
#18 0x7f7f4a4c983b views::View::DoRemoveChildView()
#19 0x7f7f4a4c9ad0 views::View::RemoveAllChildViews()
#20 0x7f7f4a4edfb3 views::internal::RootView::~RootView()
#21 0x55f1af7f9e26 BrowserRootView::~BrowserRootView()
#22 0x55f1af7f9f7c BrowserRootView::~BrowserRootView()
#23 0x7f7f4a4fb5df std::__Cr::default_delete<>::operator()()
#24 0x7f7f4a4f93df std::__Cr::unique_ptr<>::reset()
#25 0x7f7f4a4f3045 views::Widget::DestroyRootView()
#26 0x7f7f4a4f2db9 views::Widget::~Widget()
#27 0x55f1af7f3ba7 BrowserFrame::~BrowserFrame()
#28 0x55f1af7f3c6c BrowserFrame::~BrowserFrame()
#29 0x7f7f4a534ab5 views::NativeWidgetAura::~NativeWidgetAura()
#30 0x55f1af852032 BrowserFrameAsh::~BrowserFrameAsh()
#31 0x55f1af85213c BrowserFrameAsh::~BrowserFrameAsh()
#32 0x7f7f4a5338b8 views::NativeWidgetAura::OnWindowDestroyed()
#33 0x7f7f3c8dd499 aura::Window::~Window()
#34 0x7f7f3c8ddbbc aura::Window::~Window()
#35 0x7f7f4a531fc2 views::NativeWidgetAura::CloseNow()
...

Original change's description:
> Use views::AnimationDelegateViews wherever possible
>
> Replace gfx::AnimationDelegate with views::AnimationDelegateViews.
> This will help gfx::AnimationContainer be driven by ui::Compositor.
>
> TODO:
> * files under ash/
> * other files which can't use AnimationDelegateViews.
>
> Bug: 953585
> Change-Id: I39279bcc779c72bedb26f8c1e43661f0a0a9691d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616921
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662481}

TBR=pkasting@chromium.org,sangwoo108@chromium.org

Change-Id: Id63677148acee966377a6ec7a4c4b0ab2becde76
Bug: 953585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626064
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662551}

Change-Id: Idc736ea18951da0f52fcc4635c31218a7f1e2212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624806Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662550}

Before this change, a PromptProto.Choice with only element_exists would
be rendered as a chip with no names.

After this change, we can add PromptProto.Choice again with only
element_exists set and no chip definitions set, neither name, nor icon,
nor chip type. This is useful to script automatic end of the prompt
action.

Bug: b/132950869
Change-Id: Ie552934311d8345c4a5496b10d7a63e2bc97c705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617520Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Auto-Submit: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662549}

Checks whether script execution is allowed or not in IDL callbacks.
See the bug for details.

Bug: 964928
Change-Id: Icfe11d7cd029a52794cdd4525d04288735dc3b29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624985
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662548}

These values get translated into a generic "other" error, so it's
useful to see what the underlying code was.

Change-Id: I320b41f82efe6a2b2a168d4b1ee87f5a01c2acf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626731
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#662547}

There can legitimately be invalid WebFeatures on disk when features are
removed from the WebFeature enum. Just ignore them when reading.

Bug: 965944
Change-Id: I45dbcf0b4e92adf5f648c6cf7ba1e09f6b7cc63a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626917
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662546}

The ViewPager has timing issues that surface if any bottom sheet is
invoked very, very quickly after its creation.
I witnessed this approximately 1 out of 30 times when testing manually
and approximately 1 in 5 times in automated tests. As far as I know,
this test flakiness wasn't reported yet and the most affected test has
yet to land.

This CL posts a SetCurrentItem call right after it's regularly called.
That way, if there are no async issues, it will work as it should.
But if another SetCurrentItem marks the wrong item active, it will be
overridden very soon after.
Visually, the difference can (afaict) only be perceived during the very
first opening _if_ the wrong sheet would trigger. The flickering is not
perceivable unless expected (since the sheet is still opening at the
moment when the switch happens).

Bug: None
Change-Id: I2dcd7ab329746efed6aff294f2dbdb5657357a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624816Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662545}

Bug: 966001
Change-Id: I7546061c0b7e245720c3706aa7d5e48a510cf059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625109
Auto-Submit: Chen Xing <chxg@google.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Chen Xing <chxg@google.com>
Cr-Commit-Position: refs/heads/master@{#662544}