- 25 Jul, 2020 40 commits
-
-
Ian Kilpatrick authored
This appears only to have previously been used for LayoutThemeMac (obsolete now that form-controls-refresh has launched) for controlling the scrollbar thickness within a list-box. There should be no other behaviour change. Change-Id: I2e2698d492c354d58003697c2527a1961ea65401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270685Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#791552}
-
Anders Hartvoll Ruud authored
Previously, animated custom properties were part of the base style, and the call to CalculateAnimationUpdate _could_ take place during the base style calculation if custom properties were animated or undergoing a transition. In that world it made sense to compute transitions for custom properties early, since it could affect the base computed style. However, after the introduction of StyleCascade, CalculateAnimationUpdate now always takes place after the base computed style has already been produced. It therefore no longer makes sense to separate kCustom/kStandard transition passes. The two passes can be merged to one, but for now this CL just moves the two passes together. Change-Id: Ibc2b82d4c58af168ceaf2572f98dc09744795702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307222 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#791551}
-
Maciek Kumorek authored
Bug: 1060701 Change-Id: I7e0a2dff71b20a2ebf36139fa1bc180508cb0bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134943 Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791550}
-
Peter Kotwicz authored
This CL also changes histogram ownership to the WebAPK team mailing list for the following histograms: WebApk.Notification.Permission.Status WebApk.Install.AvailableSpaceAfterFreeUpCache.Fail BooleanWebApkNotificationPermission BUG=1105087 Change-Id: I8e3ae20c493e3ee8d8a60f709b11d4b0714d939c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297722Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791549}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ifcaa3c0c24796782ac6247310c8db41169512105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791548}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/search_engines. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=orinj@chromium.org Bug: 1106699 Change-Id: I40bb5c4a6624623f2548babc4ef8fed32566b9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316362 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791547}
-
David Black authored
This pref will eventually be used to target onboarding features to users who have not been using Assistant for a long time. Bug: b:161908220 Change-Id: I336b8193182765054126abf504c786c766ff51fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314157 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791546}
-
dpapad authored
Known issue: Scrolling in the new layout is not detected by the C++ plugin code and therefore the contents of the plugin do not repaint upon scrolling. This is addressed in follow up CLs. Bug: 1101598 Change-Id: I137e5fea6ac924ee360392d2f06ef3259cc8d72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278441 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#791545}
-
Filip Gorski authored
Introduces incognito specific divider_line_incognito drawable that is not prone to changing the background color with the theme change. Bug: 1096290 Change-Id: Icde04438a76dcdb2c3d1ff9006dde345d21d3c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296623 Commit-Queue: Krishna Govind <govind@chromium.org> Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Reviewed-by: Ender💬 =🕐 (ping me for faster reviews) <ender@google.com> Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#791544}
-
Richard Townsend authored
__asm is an MSVC-specific syntax for inline assembly. Clang imitates it - but only for x86/x64 targets. Using asm instead means it works on all architectures. Bug: 1108769 Change-Id: I83966999ffce13c412cc3c6f99ef9086a8a4295d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315871Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#791543}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7260027e661..4ceefeb36e0e 2020-07-25 mathias@chromium.org Add support for rolling ClientVariationsParser.js 2020-07-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-24 szuend@chromium.org Migrate 'front_end/search' to 'devtools_entrypoint' 2020-07-24 szuend@chromium.org Migrate 'front_end/components' to 'devtools_entrypoint' 2020-07-24 jacktfranklin@chromium.org Fix interface detection in union types in component bridges generator 2020-07-24 janscheffler@chromium.org [TypeScript] Move TimlineModel to TypeScript 2020-07-24 jacktfranklin@chromium.org Improve bridges generation interface detection 2020-07-24 jacktfranklin@chromium.org Migrate color_picker to devtools_entrypoint 2020-07-24 petermueller@chromium.org New icons for COEP & COOP integration 2020-07-24 jacktfranklin@chromium.org Migrate diff to devtools_entrypoint 2020-07-24 jacktfranklin@chromium.org Migrate formatter to devtools_entrypoint 2020-07-24 mathias@chromium.org De-obfuscate X-Client-Data header values in Network tab 2020-07-24 jacktfranklin@chromium.org Migrate workspace to devtools_entrypoint 2020-07-24 sigurds@chromium.org Add ad status to frame details in application panel 2020-07-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-24 isherman@chromium.org [Cleanup] Fix indentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1095617,chromium:1101738,chromium:1103854 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibc6f992826dcc118dc6c058581a216518c4c08f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318869Reviewed-by:
-
Joanmarie Diggs authored
Fixes three dcheck failures, each of which is related to attempting to emit AtkText events on objects which should not emit them. Therefore add checks to EmitsAtkTextEvents to ensure AtkText is implemented for the object, and that the object is not invisible or ignored. In addition: * For an HTMLMediaElement whose sole content is text (i.e. no player and no source), do not expose any children and treat as included but ignored. * Always include Role::kVideo and Role::kAudio in the internal accessibility tree, even when ignored, for consistency. AX-Relnotes: N/A as there is no change in end-user experience. Bug: 1041414, 1104047, 1104048 Change-Id: Id643f148fdaba3c865c6cefe8f20151c3181135b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297431 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791541}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/33265b79e5b1..bcad714ddf45 2020-07-23 taylori@google.com Merge "perfetto-ui: Always update resolution" 2020-07-23 lalitm@google.com Merge "tp: add option to filter ftrace before all_data_sources_started" 2020-07-23 simonmacm@google.com Merge "Add metrics for sleep time." 2020-07-23 primiano@google.com Docs: fix typos If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2ad54a49141f373d1d234521667597ec63414052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316287Reviewed-by:
-
Kalvin Lee authored
This change modifies the PrinterConfigCache and FakePrinterConfigCache classes to post callback tasks rather than Run()ning them synchronously. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PrinterConfigCacheTest.*' Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: I4a42c855eb49b5eb58f0831141ddfbeae373d676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303860 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#791539}
-
behdad authored
This change is to verify the changes in latency metrics reported, and make sure there has been no other chanegs responsible for recent changes in the values of latency metrics. TBR=jonross@chromium.org Bug: chromium:1096661 Change-Id: Iafac9541c2b773cba52c3693c61d8cfb0c184064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317829Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791538}
-
Yuke Liao authored
A temporary solution to allow different downloading behaviors when building and testing on bots until version is pinned to chromium/src. Bug: 1104318 Change-Id: I945a8be7f39a3762107791f70ff48cd09410b8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315424Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#791537}
-
chrome://nearby-internalsJuliet Levesque authored
Create Notifier class to pass messages to observers, which will lead to HTTP responses and requests to be displayed in the HTTP Messages tab of the internal debug page. Bug: 1093634 Change-Id: Iafcc02a1bcfb3e89085ab60ed35d16cecc312e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299521 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791536}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b6183ea36975..8cfc41ae955d 2020-07-25 wl@gnu.org Fix `-Wformat' compiler warnings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ie307782c724c00f818c37909d6cb1b5ebd698918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318998Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL changes the video encode accelerator test that exercises the scaling path for zero-copy encoding so that the scaling factor is 1/2 instead of 3/4. The reason is that per b/160141652#comment3, half down scaling is expected to be the practical case. Note that this requires making sure that the input stream is not too small. That's because if it's too small, scaling down might produce a stream that's below the minimum supported resolution of the encoder. Bug: b:160141652 Test: video.EncodeAccel.*_dmabuf on rammus and kukui. Change-Id: I8e6b4595ac5e67bc00669f5d224c8c21a1b93edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315799 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791534}
-
David Tseng authored
Test: tools/json_schema_compiler/compiler.py -g externs extensions/common/api/automation.idl > third_party/closure_compiler/externs/automation.js results in no diffs. automation.js was hand edited previously. Run tools/json_schema_compiler/js_externs_generator_test.py Change-Id: I949530eecb24e5a26bc2f5bff13c831bdad3dbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314016 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791533}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui/webui/history. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=calamity@chromium.org Bug: 1106699 Change-Id: Ic96df4cdd31606f2d8b0397a67304ffa0d6d0ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316578Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791532}
-
Anastasiia N authored
- Migrate inline login flow to use Polymer. - Remove unused method: "handleOAuth2TokenFailure" - Remove "show-back-button" call, and use <if expr="chromeos"> to show the button on ChromeOS only. Bug: 1096007 Test: browser_tests --gtest_filter="*InlineLoginBrowserTest*" Change-Id: If146b080bb0fef65f8e931ac35809a8dfa8aa66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279795Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#791531}
-
Dylan Cutler authored
This web IDL annotation will automatically add instrumentation with the bindings code to record how much entropy these APIs leak about users' cross-site identity. Bug: 973801 Change-Id: Ie4d1aa3483bd1883511ccc46d9e4cb2879884c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302726Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#791530}
-
Michael Tang authored
Allows for subframe recordings to be saved to either the disk or memory buffers. Change-Id: I0630babd421716ed9bf354e22a3b8eca8ce46932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274166Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791529}
-
Lei Zhang authored
Convert the few remaining callers within base/. Bug: 1009837 Change-Id: I32d4aa4290deb753c2b1c0773a3cbde1cdf71578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313376 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791528}
-
dpapad authored
The test code was waiting for an event emitted from the prod code, but in some cases the event had already fired before the test code had registered the listener, causing the test to hang indefinitely. Fixed: 1104824 Change-Id: I10597aabc565ecbcef2dcd4e191cc80521f1686e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316129 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791527}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df7cabc2cd02..96de0520b550 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1109003 Tbr: Change-Id: I28d1912f3a689c92d5f5deda9a0848d2063eba2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319000Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791526}
-
Stefan Zager authored
LocalFrame::RemoteViewportOffset and LocalFrameView::MapLocalToRemoteRootFrame are legacy artifacts from when ViewportIntersectionState contained only an offset from an OOPIF to the main frame, rather than a full transform. BUG=1088483 Change-Id: I9d0aa3ffe127ff184f2f0741d2e4e6effa7d799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304968 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791525}
-
bttk authored
CallbackControllerTest covers the same functionality as before, but is more readable. Change-Id: I54d1409964ed0b077747abc0173a464867c9540d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315255Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#791524}
-
Cammie Smith Barnes authored
Currently the FCP ads metric only records the FCP of the main frame and ignores the FCP of any child frames. This CL updates the metric to store the earliest FCP in the ad frame tree, taking into account the child frames as well as the root ad frame. Tests: chrome/test:unit_tests --gtest_filter=*FirstContentfulPaint* Bug: 1103782 Change-Id: Id1cb1e9a98ba03656bb3da1ef6592b779bd5fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307442Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791523}
-
Noah Rose Ledesma authored
Add a method to the notification service for switching audio output devices. This currently has no effect. Bug: 1096243 Change-Id: I638bf11c36a3b5d0aa7a3beece9394a1df8e545c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293073Reviewed-by:
-
Daniel Hosseinian authored
Disallow wrapping within the #end div and add a 20px padding to the left. When window width is less than or equal to 600px, do not display the PDF title and the zoom input. Bug: 1108453 Change-Id: I60dbd2ada5a6a81cdf9f40daf6019889498d308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314788 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Peng Huang authored
This is a reland of 0c9696bf Original change's description: > ExternalVkImageBacking: fix concurrent read problem > > Concurrent read access from both GL and Vulkan is not allowed. > Get rid of the concurrent read problem by releasing the texture > from GL temporarily, when a Vulkan read is requested. And resume > GL read access, when the Vulkan read access is over. > Current chrome GL and Vulkan concurrent read pattern is - Blink holds > and caches read access for a backing shared image for a WebGL or > 2D canvas. SkiaOutputSurfaceImplOnGpu only requests read access just > before playing back DDL and releases the read access after playing back > DDL and before SwapBuffers. The GPU will not schedule other tasks > between playing back DDL and SwapBuffers. So it should be safe to > temporarily pause GL read access. > > Bug: 1104231 > Change-Id: I729eeebd5196bc5387ac148133b5926358bb4b53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311330 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791022} Bug: 1104231 Change-Id: Ia916f250ca30b3c2b8a07016d2530fad79385aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316399Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791520}
-
Swapnil authored
We have several failure reasons that specify why the extension failed to install. We want to add failure reason to the existing event type INSTALLATION_FAILED for the event based reporting for force installed extensions. Bug: 1106343 Change-Id: I7c0e8a098c468904189b47c101036fd59279bca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302033 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#791519}
-
Gayane Petrosyan authored
Adding FindUniqueMatch function that checks if provided selector has a unique match. Additionally adds a basic use case when selector is an exact text without context. Bug: 1102382 Change-Id: Ifd105517d4ce4af36e7cd500e17ff0ca28a8d0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283244 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791518}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595656565-f8273935e4463fa6320c26f96bf11cce31594e4d.profdata to chrome-mac-master-1595678123-cab8caa4f93e8afba47417bd0b38f6939852da88.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I18cd0c0b7a93d80952cdf457a8009a84088c5f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319116Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0d158ac68107..d5a4775cfc77 2020-07-25 hao.x.li@intel.com Query API: QuerySet on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib3a7c6cafe9b147e351644e6afdc44b53f9b009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319122Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Move the following methods from PRImpl to PaymentUIsManager without logic changes. - getModifier - getLineItems - loadCurrencyFormattersForPaymentDetails - isMixedOrChangedCurrency - getOrCreateCurrencyFormatter * Because the methods being moved reference some PR parameters, we also add getModifiers and getRawTotals to PaymentRequestParams. * Because the methods reference mCurrencyFormatterMap, mUiShoppingCart, they are moved into PaymentUIsManager as well. Bug: 1102522 Change-Id: Iaf69afee236bc9369bea4e87ee4d2547800d5487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310900 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791515}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0ca429b29e9d5e72bbbdd9950f486212b61f13ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314935Reviewed-by:
-
Marijn Kruisselbrink authored
Introduces directories where access to the directory itself is blocked, and access to subdirectories is blocked as well, but individual files can still be opened. This enables opening of individual files stored on for example MTP devices on Windows, which is implemented on Windows by copying the file to a temporary directory and returning that path to chrome. This does not give access to folders on things like MTP devices. That will require a much larger rewrite/implementation of new file system backends, and is unlikely to happen anytime soon. But at least it won't result in the confusing "blocked because in a system folder" error if a user opens individual files on an MTP device (anything else is already filtered out/blocked by the file dialog itself, by the flags chrome passes to the file dialog). Also adds logging when we block access to a directory to make it easier to troubleshoot why certain paths are blocked, even if we can't reproduce it ourselves. Bug: 1094835 Change-Id: I170c3b9fa83c809d63d0a031aec5debd10bb3ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316888 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791513}
-
