- 11 Nov, 2020 40 commits
-
-
Sammie Quon authored
Starts tracking when a desk switch animation starts. Sets up a timer which then records the number of traversals during a sequence of desk animations. There may be multiple animations during the timer duration, they will notify the metrics collector class on animation end with how many traversals have happened. For touchpad swipes, add some logic to track how much visible desk switches the user has seen. This is different from the number of desk activations. For all other desk switch sources, the number of traversals during an animation is 1 + #Replacements. Test: manual, added tests Bug: 1146479 Change-Id: Ie3c46ebe80e35a768a89eb6e7105d807db087529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523061 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826426}
-
danakj authored
Although extensions now uses mojo to receive SkBitmaps, even those still have a variety of color types. And some of those colortypes use other pixel sizes than 32bpp, which can lead to buffer overflow bugs. So we convert any incoming arbitrary bitmaps received from (extensions) renderer processes to be N32 upon receipt. R=reillyg@chromium.org Bug: 1144462 Change-Id: I66acc7fbfcc0565411a1b9b9bc5a01b70558c5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532663Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826425}
-
Maria Kazinova authored
Bug: 1131038, 1075444 Change-Id: Ic120ef48c37885ecc93c18a5ecbf4731240f02c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532559Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#826424}
-
Majid Valipour authored
Implement a new web-otp-backend auto which uses two existing backends and can automatically switch between them when necessary. It first tries to use a preferred backend (i.e., verification backend) and automatically switches over to the fallback backend (i.e., user consent) when that is not available. In order to be able to automatically switch between the two backends we move the backend API switch-over logic to the Java implementation side and add a new component SmsProviderGms which can use two types of receivers. The provider callers can specify which backend to use. This is used to emulate the existing behavior and in tests. Alternatively callers can specify the new auto backend. This also enabled multiple refactoring: - The receivers now only talk to the provider and don't need to be aware of the native code. - A single test suite for both backends which means we can de-dupe common tests. - A single fake can be used for all backends. Follow up: - The onSuccess callback should return the method used so that the caller can decide which user consent handler to use. Test: ./bin/run_content_unittests --gtest_filter=*SmsProvider* Bug:1141024 Change-Id: I2094496ee759fe50d7e6981c490ecc18066dfb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495910 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#826423}
-
Liquan (Max) Gu authored
Reorders CPRService#continueShow() so that the method can be separated into two parts: the part that will stay in CPRService and the part that will be moved into PRService. Bug: 1131059 Change-Id: I93c57a3b7b8ee957b4fd5695243f05ad65e040ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533024Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826422}
-
Josh Nohle authored
Record whether or not a transfer fully completes. If the transfer does not complete, record reason. Also, add histograms that slice by share target type (phone, laptop, etc.) and whether the transfer is incoming and outgoing. Bug: 1105579 Change-Id: I8e124ea761ca0f372f0cbdb77881dc5fd855579a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524123Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#826421}
-
Yuheng Huang authored
This CL moves the active tab to the bottom of the list because it's not likely users want to click on it. It's guarded by TabSearchMoveActiveTabToBottom feature param. Bug: 1099917 Change-Id: Ie3aab227e68ee2e17b1e1e1cee5bf47e29fa6d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530317Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826420}
-
David Black authored
New actions include: - kShowContextMenu - kShowPreviews - kHidePreviews This should tell us how discoverable the holding space pod context menu is and how often users are enabling/disabling previews. Bug: 1131266 Change-Id: I2b3d8c02afd6167ee1b516780ac29669e8566b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531495 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826419}
-
Doug Turner authored
Bug: None Change-Id: I990ea0ab11ed6476b8114b0d89663b05a6657616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533274Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#826418}
-
Tim Judkins authored
There seems to be a potential flake at the moment when loading service workers on unpacked extensions in tests, related to https://crbug.com/1146173 Adding a flag to allow file access stops the extension being reloaded and avoids this issue for now. Bug: 1146301 Change-Id: Ia952ec24fa501ed379a67f8c6cb2313eca5851cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527362Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#826417}
-
Liquan (Max) Gu authored
Moves MethodChecker from CPRService into PRService. Bug: 1131059 Change-Id: Iedc3fb57a884e957b715d89b89ec356508032f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530799Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826416}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/98035e11d907..c360709829e1 2020-11-11 timvp@google.com Revert "Vulkan: Let shader use rotation specialized constant" 2020-11-11 jmadill@chromium.org Revert "Created test and fixed texture storage bug in d3d11" 2020-11-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 90258074 to ca966cfb (459 revisions) 2020-11-11 cclao@google.com Vulkan: Let shader use rotation specialized constant 2020-11-10 jmadill@chromium.org Vulkan: Remove hasPrimaryCommands(). 2020-11-10 vantablack@google.com Created test and fixed texture storage bug in d3d11 2020-11-10 cclao@google.com Vulkan: Add specialization constants for surface rotation 2020-11-10 jmadill@chromium.org Vulkan: Move CommandQueue to CommandProcessor.h. 2020-11-10 timvp@google.com Add tests to show bad waitSync/flush behavior 2020-11-10 jmadill@chromium.org Vulkan: Merge command paths in submitFrame. 2020-11-10 m.maiya@samsung.com Vulkan: Support VK_KHR_image_format_list for RenderBuffers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: FenceSyncTest::MultipleFenceDrawTest: Test: ImageTest.SourceRenderbuffer*VulkanTest: Test: MultithreadingTestES3, MultithreadFenceTexImageTest: Test: MultithreadingTestES3::MultithreadFenceDraw Change-Id: I13763f04c9a7b53b7f0e54283ea3abf3122954f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826415}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bcwhite@chromium.org Bug: 1145565 Change-Id: I7abefcdf0a512108ecd78ff910f59b9c116db74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533173 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826414}
-
Akihiro Ota authored
This change: 1. Removes the interactive tutorial flag 2. Removes the old tutorial from the codebase 3. Un-flakes the RestartNudges test 4. Performs code clean up Fixed: 1075752, 1147169, 1145059 Change-Id: I419714e40974abe0bef8ee328ddb7b21508e3973 AX-Relnotes: Launch ChromeVox interactive tutorial. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522312 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826413}
-
John Delaney authored
What: Delete Conversion Measurement API data when an origin is completely deleted from history. Why: This avoids a situation where the conversions database is the only place where any record of an origin is kept. There is no risk of web breakage by clearing API data, as the storage is not directly web observable. In contrast to other site data like cookies which stands the risk of breaking the web. How: Adds a new flow in BrowsingDataHistoryObserverService which clears StoragePartition data when an origin is completely deleted from history. Bug: 1108973 Change-Id: I5db807d965b654aea2a166080f48f9f690d8ec28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493707 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#826412}
-
Adrienne Walker authored
This patch uses a schema bump to do a one-time check of all blob files on disk. http://crbug.com/1131151 is a bug where under some rare circumstances blob files may be written and then secretly deleted, leaving the database with knowledge of an external file that doesn't exist. During this one-time check, if any blob files are missing, then the database is marked as corrupted and will be deleted. We use a schema bump to only do this once. Bug: 1143975 Change-Id: Ibb78e2bfaa4a1ba1becd77b88b5e07b8e0f3fe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508645 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#826411}
-
Arnaud Mandy authored
during testing, mock-sensor is used, values and timestamp are artificially generated in the test. to comply with test restriction, IsRunningWebTests() has been used to simulate timestamp. IsRunningWebTests() is only working under CI wpt testing, and does not work in upstream wpt. This patch removes the test specific code from blink, and changes the timestamp value to be acceptable for the calculation of sensor.timestamp Bug: 1135537 Change-Id: I94ca3e4ba63ce99fcc64bef070374483db218ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517959Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#826410}
-
Regan Hsu authored
Previously, the enable hotspot button stays "connecting" indefinitely. This is because CrosNetworkConfig::OnDeviceListChanged() is not called immediately when a tether scan state completes. This CL corrects that. Fixed: 1146611 Bug: 1106937 Change-Id: Ieafc1fdd0f03343861aaf6dca5233b863dd69cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531898 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826409}
-
Ian Clelland authored
This change implements the algorithmic changes for a recent change to the Feature/Permissions policy spec: https://github.com/w3c/webappsec-permissions-policy/pull/378 With this change, the Feature-Policy or Permissions-Policy headers by themselves cannot be used to delegate powerful features to cross-origin iframes; the allow attribute must be used as well. To allow this to still be ergonomic, the default value for the header for powerful features is effectively '*', so that delegation is allowed by the header implicitly. The header can now be used effectively to completely block access to a feature, as any origins not present in the header allowlist cannot be granted the feature through the allow attribute. This also removes some code which previously only existed to track the cases where this change would affect the output of an IsFeatureEnabled call. Several tests will have been modified or rewritten prior to landing this change; this CL depends on the following (though they are all independent, so they are not chained together): - https://crrev.com/c/2424633 - https://crrev.com/c/2424634 - https://crrev.com/c/2424635 - https://crrev.com/c/2424654 - https://crrev.com/c/2424655 - https://crrev.com/c/2424657 - https://crrev.com/c/2425003 - https://crrev.com/c/2425004 (See Patchset 8 for a version with the changes from all of those CLs included.) This CL, while large, can best be understood as the union of the following changes: - Algorithm changes, including the removal of previous "what-if" code and metrics: feature_policy.cc feature_policy.h execution_context.cc - Unit tests to cover those changes: feature_policy_unittest.cc render_frame_host_feature_policy_unittest.cc - Update WPT test expectations to account for the change in behaviour when only the header is used: 3p/b/web_tests/external/wpt/feature-policy/feature-policy-* 3p/b/web_tests/external/wpt/permissions-policy/permissions-policy-* - Update Blink web tests for fullscreen and payment request to validate that both are now working correctly with the new header semantics: 3p/b/web_tests/http/tests/feature-policy/fullscreen* 3p/b/web_tests/http/tests/feature-policy/payment* - Update Blink web tests for the iframe policy JS interface because of new test expectations when features are allowed/disallowed by header: 3p/b/renderer/core/feature_policy/policy_test.cc 3p/b/web_tests/http/tests/feature-policy/policy_iframes.php Bug: 1095641, 937131 Change-Id: Iecbb0950c27a4565998ee5192590d6691a03b4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363169Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#826408}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 44 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-02-08. TBR=chromium-metrics-reviews@google.com Change-Id: I8d739166f458d861cff936467f658b736a62c597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530976Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#826407}
-
James MacLean authored
This reverts commit d22a4cef. Reason for revert: build failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863899624870692272/+/steps/compile/0/stdout Original change's description: > wtf: Build traits based on cppgc for when using Oilpan library > > Currently WTF uses forward declarations to define basic GC traits that > are used throughout WTF and Blink globally, i.e., without any specific > context or other traits being available. This is an implicit > dependency on blink. > > With Oilpan throuhg V8, we make this dependency a header-only > dependency that is explicit which allows to re-use existing traits > from the library to define the WTF equivalents. > > Change-Id: I3995c0d587424299ed880adcd5ac848a635e4f1e > Bug: chromium:1056170 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532236 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826397} TBR=haraken@chromium.org,mlippautz@chromium.org Change-Id: Ifaf0414b054fd37de410acfd8ced1a5814e04232 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532729Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#826406}
-
Kenneth Russell authored
This reverts commit ff1d9dd5. Reason for revert: crbug.com/1146687 still occurring after this revert. Original change's description: > Revert "Refactor subresource redirect renderer code" > > This reverts commit 674a1af2. > > Reason for revert: suspected cause of crbug.com/1146687 > > Original change's description: > > Refactor subresource redirect renderer code > > > > This CL refactors the existing subresource redirect code to make the > > robots rules and login based image compression implementation easy. > > > > * Separate out the url loader throttle that does redirect and timeout > > handling from the public image hints decider logic. The robots decider can > > be subclassed and used. > > > > * Make public image hints agent as renderframeobserver. This reduces > > cluttter in ResourceLoadingHintsAgent. The upcoming robots checker agent > > could also observe renderframeobserver directly. > > > > No change in behavior is expected. > > > > Change-Id: Ic555a4402016a645b8820fa87dd5157c7112fb71 > > Bug: 1144836 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514068 > > Commit-Queue: rajendrant <rajendrant@chromium.org> > > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825115} > > TBR=rajendrant@chromium.org,mcrouse@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1144836, 1146687 > Change-Id: I483882b29ac342d188137690e7ba9f8cbedcd6ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527859 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825966} TBR=kbr@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1144836 Bug: 1146687 Change-Id: I5334a53226d6641fbc4ec601e6b4d01bb6c8b48c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533196Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#826405}
-
Antonio Gomes authored
The class will be used by BrowserNonClientFrameViewAsh, in both ChromeOS and Lacros builds. CL also migrates BrowserFrameHeaderAsh away from using ash::TabletMode, in favor of chromeos::TabletState. For more details, see phase 2.12 in [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org TBR=sky@chromium.org Change-Id: I8a6c3ee2138ee9659454afd25c4c016a394a1b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529492 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#826404}
-
Ben Goldberger authored
Also -Add histogram to track js execution time. -Pipe web contents into internal code to allow for triggering this module from the lens sdk. Bug: 1145865 Change-Id: Ia22e285d7b8ebcf6fa214dcb7d8aa35aa7202c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520334Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ben Goldberger <benwgold@google.com> Auto-Submit: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#826403}
-
Guido Urdaneta authored
This reverts commit ef949e14. Reason for revert: Fix the compile issue, caused by a change after trybots run but before landing. Original change's description: > [BreakoutBox] Add MediaStreamTrackProcessor > > This CL introduces MediaStreamTrackProcessor, an object that allows > exposing a MediaStreamTrack's media frames as a readable stream, > enabling applications to perform custom processing. > This basically allows the creation of a custom sink, in terms of the > model proposed by the Media Capture and Streams spec [1]. > A MediaStreamTrackProcessor can be combined with a TransformStream and a > MediaStreamTrackGenerator to effectively insert a processing step inside > an existing track. > > [1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings > > Bug: 1142955 > Change-Id: I2a119f0c2ea9ce50432509286bd0f43758d8a272 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524322 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826153} TBR=kinuko@chromium.org Change-Id: Ia68309f8e5d8b3c58174ec13e520040984d4809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532213Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#826402}
-
James Cook authored
* Fix a couple of incorrect include guards. * Use "return std::make_unique<T>(...)" instead of "return std::unique_ptr<T>(...)" because the latter is banned by a presubmit. https://source.chromium.org/chromium/chromium/src/+/master:PRESUBMIT.py;drc=9c1f87c53ca0d29afdd5763b50cb26341ba1fd64;l=2596 I just noticed these incidentally while investigating another issue. Bug: none Change-Id: Id5ea994517ff41641a724cf0832da80f8ac7b680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530900 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#826401}
-
Ali Juma authored
A navigation redirect chain can include the same URL more than once, for example, b.com -> a.com -> c.com -> a.com. However, when mapping Safe Browsing decisions to pending queries, the logic assumes there can only be at most one pending query with a given URL. This means that, in the above example, if the Safe Browsing decisions for a.com arrive after there are two queries for a.com, only one of these queries will be assigned a result, even after both decisions are computed. This CL modifies SafeBrowsingTabHelper::PolicyDecider::GetPendingMainFrameQuery to return the oldest matching query that does not yet have a decision, and renames this method to GetOldestPendingMainFrameQuery. With this change, decisions for URLs in a redirect chain are sent to the first query that doesn't yet have a decision. This CL also relaxes a DCHECK in SafeBrowsingTabHelper::PolicyDecider::HandleMainFrameResponsePolicy that currently checks that the given URL (passed in by ShouldAllowResponse) matches the pending query's URL (from ShouldAllowRequest). There are at least two cases where this fails to hold: 1) Sometimes when there's a server redirect, a ShouldAllowRequest call is never made for the target of the redirect. Instead, an additional ShouldAllowRequest call arrives for the source of the redirect, and WKWebView's URL is still the source URL when DidRedirectNavigation is called. This bug does not seem to reproduce in trunk WebKit, so may be fixed there. 2) When the request is handled by a ServiceWorker, the ServiceWorker is able to set a different URL on the response it produces. In these cases, the URL still has the same origin as the request. Bug: 1144690 Change-Id: Idae3161c9ddee4fd6e1fe6e13c111a5e90b29c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518330 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#826400}
-
Moe Ahmadi authored
Deletion from the in-memory URL DB can be slow: http://shortn/_eSkRG8RvpV This CL makes the deletion of queries from the in-memory URL DB async by posting the deletion task to a sequenced task runner on the UI thread. Fixed: 1110077 Change-Id: Ia8099093eea6efde952bfbb58cd182b06174f8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531654Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826399}
-
Chan Li authored
android test runner has integrated with resultsink directly, so we should update those test suites to stop using default result_adapter. Bug: 1104245 Change-Id: I581afa657d972d7a30aca7c70a9b939b436b54d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530524Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#826398}
-
Michael Lippautz authored
Currently WTF uses forward declarations to define basic GC traits that are used throughout WTF and Blink globally, i.e., without any specific context or other traits being available. This is an implicit dependency on blink. With Oilpan throuhg V8, we make this dependency a header-only dependency that is explicit which allows to re-use existing traits from the library to define the WTF equivalents. Change-Id: I3995c0d587424299ed880adcd5ac848a635e4f1e Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532236 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826397}
-
Evan Stade authored
This matches the current logic of the internal TabImpl#isVisible method (inverted), which is true when a tab is active and in a started fragment. The name reflects the reason for exposing this method, i.e. why we think it's notable to clients. Test coverage will be added in a follow up. Bug: 1146058 Change-Id: Ibb538fa349623ca214774ef53496fab2414a6c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525848 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#826396}
-
James Robinson authored
Some tests in the AgentImplTest suite were accidentally sending FIDL messages over unbound channels. This was not caught by the test because the tests did not spin the run loop to let the asynchronous callbacks run or not run. This error is caught by new instrumentation being added to the FIDL bindings. This fixes up the bindings mismatch, spins the run loop to perform the asynchronous portions of the test, and also adds some cleanup logic that is also necessary now that the asynchronous portion of the test is executing. Test: cr_fuchsia_base_unittests Bug: fuchsia:63593 Change-Id: I251124d9099695fc56096fd7baeb7a8fb67fdf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530268 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: James Robinson <jamesr@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826395}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d4297e6b205..dfff133590c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3133bd26e0edf4e9e914b082dd32b8bba52719d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826394}
-
Daniel Cheng authored
Miscellaneous fixes: - Simplify the unit tests by unparameterizing them. Instead, the tests simply iterate over an array of test cases, using SCOPED_TRACE() to make it easier to debug failures. - Convert metrics enums to be a scoped enumeration, which allows: - clang to enforce kMaxValue correctness - autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION() - Remove the unused Gamma enum. The metric itself was removed in https://crrev.com/c/1684563. Bug: 742517, 1047547 Change-Id: I0a5b4aeaa8540505a7b0596a4d0df6f871fef8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527341Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826393}
-
Chan Li authored
typ has integrated with resultsink directly, so we should update those test suites to stop using default result_adapter. Bug: 1104252 Change-Id: I7210d3abf2e2b259b61e148c59c69f85f1482fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531513Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#826392}
-
yiyix authored
After allocate a large buffer in memory and creating canvas, it will trigger the garbage collection from v8, which will trigger offscreenCanvas::Dispose to be called. This call will cause the offscreencanvas detached from the |host|. However the |host| is saved as a valid callback in the observer list of the canvas resource provider. Calling this |host| without offscreencanvas causes this access to poison address. In my fix, after garbage collection is triggered and dispose is called, DiscardResourceProvider() is called as well, so it removes itself from the observer list. Bug: 1143662 Change-Id: I82c9a1f70c117b03de9fb64f4849c1f3c4311d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531136Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#826391}
-
Chan Li authored
This reverts commit 6f8b5118. Reason for revert: caused compile failure on multiple builders. Sample build: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/90601? Original change's description: > Remove empty base/bind_helpers.h > > The contents moved to callback_helpers.h. > > Also renames a few new bind_helpers.h includes that have been added > in the meantime. > > R=dcheng@chromium.org > TBR= > > Change-Id: Ia511a4939d60bd2ef5b474185e3716017543f8af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523545 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826387} TBR=danakj@chromium.org,dcheng@chromium.org Change-Id: I7405532513d9195295aab659f565c8d00cdb3016 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533278Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#826390}
-
Dave Tapuska authored
crrev.com/6f8b5118 adjusted location of callback helpers. TBR=danakj@chromium.org NOTRY=true Change-Id: I4af7bd6b70c4716db7059b16ec7dd7843fc0fd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533026Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#826389}
-
David Tseng authored
Adds back call mistakenly removed in https://chromium-review.googlesource.com/c/chromium/src/+/2496287 R=dmazzoni@chromium.org Change-Id: I3fab6b94a8c9c80527b0b2d451ef1d6911be1f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532928Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826388}
-
danakj authored
The contents moved to callback_helpers.h. Also renames a few new bind_helpers.h includes that have been added in the meantime. R=dcheng@chromium.org TBR= Change-Id: Ia511a4939d60bd2ef5b474185e3716017543f8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523545 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826387}
-