GitLab

This CL replaces ScopedVector with std::vector<std::unique_ptr>
in components/cronet.
ScopedVector is deprecated, see bug.

BUG=554289

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I93ed1cac20093344cc9d46c648f02cb579629794
Reviewed-on: https://chromium-review.googlesource.com/536240
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481036}

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c20

BUG=705816

Review-Url: https://codereview.chromium.org/2950673002
Cr-Commit-Position: refs/heads/master@{#481035}

TBR=wez

Bug: 
Change-Id: I3016dea4130a0020158cb5d0ff610b6c4fa19268
Reviewed-on: https://chromium-review.googlesource.com/541897Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481034}

We currently build Skia with SK_IGNORE_GPU_DITHER, effectively disabling GPU dithering.

Remove the build flag to align Ganesh with the sw rasterizer dithering behavior.

Note: Blink only sets the SkPaint dither flag for gradients at this time.

Aside from the flag change, this CL includes:

  * a handful of trivial layout tests rebaselines
  * some Canvas layout/unit test adjustments (relaxed exact pixel value checks to
    accommodate dithering)
  * a couple of trivial GPU pixel test rebaselines

BUG=731693

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2fc6f8d23272504838c55427c48c4ea7d641deae
Reviewed-on: https://chromium-review.googlesource.com/535714Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Mike Reed <reed@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481033}

- Add a new OOBE screen for waiting for container ready.
- The screen will be shown after user click Continue in the value prop
  screen.
- The screen will show a progress animation while container is
  initializing.
- The OOBE flow will end after container is ready or a one
  minute timeout is reached.
- A temporary 5 second delay is added to avoid potential racing issue.

BUG=b/62549680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2947483002
Cr-Commit-Position: refs/heads/master@{#481032}

It's required recently that any extension loaded from a directory
as an unpacked extension in chrome://extensions must be whitelisted
with a unique whitelisted ID. Otherwise it will be blocked from being
installed.

Bug: 735242
Change-Id: I7c5aa5460cee5f17e76ef7fc4473ed9cf48e0bea
Reviewed-on: https://chromium-review.googlesource.com/541955Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481031}

Using the ScreenAvailability enum added in
https://chromium-review.googlesource.com/c/527376/ in content/browser
and chrome/browser/

BUG=723032
TEST=existing/updated tests

Change-Id: I6667f4d6237c242dfe9446cbf9e82dd30f0858ec
Reviewed-on: https://chromium-review.googlesource.com/530284
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481030}

Revert of Move SafeBrowsing files from //chrome/browser to a separate target. (patchset #5 id:80001 of https://codereview.chromium.org/2940403002/ )

Reason for revert:
This caused compile failures (https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%20x64%20Builder/builds/34160)

Original issue's description:
> Move SafeBrowsing files from //chrome/browser to a separate target.
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2940403002
> Cr-Commit-Position: refs/heads/master@{#481019}
> Committed: https://chromium.googlesource.com/chromium/src/+/e4da0e76b5b75d453fec094f62ad06659e66708e

TBR=rockot@chromium.org,vakh@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2951883002
Cr-Commit-Position: refs/heads/master@{#481029}

Bug: 654988
Change-Id: I7f91eafc52aed40c8243e657b85c821605f9c76b
Reviewed-on: https://chromium-review.googlesource.com/526914Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481028}

This can happen when rotation animator sets the orientation after
animation is completed. We shouldn't save this anyway, as we changed
the semantics as follows:
a) A user/API driven rotation change in tablet mode should be treated
  as user locked rotation.
b) A user will not be able to change the orientation in tablet mode
  from settings.

BUG=734107
TEST=Manual + unit test

Review-Url: https://codereview.chromium.org/2951773002
Cr-Commit-Position: refs/heads/master@{#481027}

This CL addresses a TODO from
chrome/renderer/chrome_render_view_observer.cc to associate
ChromeViewMsg_GetWebApplicationInfo and
ChromeViewHostMsg_DidGetWebApplicationInfo IPCs with frame, rather than
view.

This CL helps ensure that
ChromeRenderFrameObserver::OnGetWebApplicationInfo (formerly a method of
ChromeRender*View*Observer) always operates on a local frame (and
therefore this CL helps with moving GetDocument method from WebFrame to
WebLocalFrame in a follow-up CL - https://crrev.com/2928033002).

BUG=416660

Review-Url: https://codereview.chromium.org/2942583004
Cr-Commit-Position: refs/heads/master@{#481026}

Different types are: inline, fullscreen and picture-in-picture.

Bug: 727322
Change-Id: I72bfa1a1f8f46079880f60cfd5b5d886875d06d6
Reviewed-on: https://chromium-review.googlesource.com/528082Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481025}

BUG=None

Change-Id: I4f0c8fd5a24a5bfc1f3a81c96026a33c7700639e
Reviewed-on: https://chromium-review.googlesource.com/538980
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481024}

The patch which added the butter-bar for unimplemented modes
broke the task-profiler case for the heap-profiling flag.

Bug: 705461
Change-Id: Ib293ce8aa8d4c2f763c7b9ba414923381f2d9870
Reviewed-on: https://chromium-review.googlesource.com/540983Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481023}

This CL sends the Expect-CT expiration into the reporter, to include in the
report as key "effective-expiration-date".

http://httpwg.org/http-extensions/expect-ct.html#rfc.section.3.1

BUG=679012

Review-Url: https://codereview.chromium.org/2944953002
Cr-Commit-Position: refs/heads/master@{#481022}

[Offline pages]: Check ResponseHeader for null pointer before getting response code in Background Offliner

Bug: 734371
Change-Id: Ie5f3803931c67d27223564b542657c9824a59e36
Reviewed-on: https://chromium-review.googlesource.com/538740
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481021}

NOTRY=true
TBR=ulan@chromium.org

Bug: 735173
Change-Id: Iac9cceb3f5a05aa249d1565337602f2a65b4ee79
Reviewed-on: https://chromium-review.googlesource.com/541607
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481020}

BUG=

Review-Url: https://codereview.chromium.org/2940403002
Cr-Commit-Position: refs/heads/master@{#481019}

Add a feature to enable a timestamp on the Previews infobar. This
timestamp should be shown when the previews_freshness is greater
than the finch controlled "min_staleness_in_minutes" and less than
"max_staleness_in_minutes".

BUG=718643

Review-Url: https://codereview.chromium.org/2940083003
Cr-Commit-Position: refs/heads/master@{#481018}

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I012ede587d5445937b1a92f0c985853a91e6d55c
Reviewed-on: https://chromium-review.googlesource.com/540827Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481017}

At this point there seems to be little danger that people will add
lines to SmokeTests willy-nilly, so I don't think we need special
owners for it.

R=ojan@chromium.org, jbudorick@chromium.org, peter@chromium.org

Change-Id: I75a71b1ee800348742177caf3ea94b1aca675d8b
Reviewed-on: https://chromium-review.googlesource.com/541603Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481016}

PersistenceDelegate is a new interface for persisting the contents of
the HostCache. This commit includes the interface itself, the logic in
HostCache for interacting with it, and a mock implementation of the
interface for testing. It does not include support for immediate data
removal since that won't be needed for the currently planned use case.

BUG=605149

Review-Url: https://codereview.chromium.org/2943143002
Cr-Commit-Position: refs/heads/master@{#481015}

Added the logic to create archive directories if the result of SavePage
is ARCHIVE_CREATION_FAILED. This is going to prevent potential increment
of failure rate once we move temporary pages to cache directory, and
download pages to external downloads directory which are vulnerable to
removal by user actions.
Also added an UMA counting the result of archive creation and related
tests.

Bug: 725266
Change-Id: Id726365ea53786077d71b02831f6dfca0d16c4f3
Reviewed-on: https://chromium-review.googlesource.com/540995Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481014}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/821867d51814..1556ddcf20a1

$ git log 821867d51..1556ddcf2 --date=short --no-merges --format='%ad %ae %s'
2017-06-20 simonhatch Dashboard - Add link to bisect docs in output.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I2ec3f077748783a87a826a41aae8a9ae74dc6580
Reviewed-on: https://chromium-review.googlesource.com/541553
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481013}

Reintroduces document click handler to screen_account_picker which brings
lock screen app window (if one exists) to foreground - this should happen
if the user clicks outside user pod/login header bar.

Removes background dim when an app window is in background - new UI
has the background dimmed by default.

Review-Url: https://codereview.chromium.org/2945153002
Cr-Commit-Position: refs/heads/master@{#481012}

BlockingPool is deprecated and being replaced with TaskScheduler.

BUG=667892

Change-Id: I9a4f133ccb3b173de468e8e26be179182b57eb64
Reviewed-on: https://chromium-review.googlesource.com/540475Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481011}

This file contains a ChromeRecovery.crx3, which contains a
ChromeRecovery.exe.

Bug: 687231
Change-Id: Ia9789b1c5c4cd8884d56c25e0765045dda7a749a
Reviewed-on: https://chromium-review.googlesource.com/541101Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481010}

The allocator shim is temporary until the base on can be refactored. The rest of the machinery for out-of-process heap profiling is hooked up in this patch.

Review-Url: https://codereview.chromium.org/2949703002
Cr-Commit-Position: refs/heads/master@{#481009}

This CL creates a feature-policy directory under wpt/, as well, provides some
framework for testing features with feature policy.

Using the framework, this CL added feature policy tests for payment, and
modified existing feature policy usb tests using the framework introduced.

Bug: 732003
Change-Id: I7d690acfe70b63d4935f6a4c6c43e94da5503827
Reviewed-on: https://chromium-review.googlesource.com/533953Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481008}

NOPRESUBMIT=true

Bug: 
Change-Id: I5c5b274bb7f520ef55081f3779922c5d0955e12a
Reviewed-on: https://chromium-review.googlesource.com/540289
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481007}

This CL:

* Introduces the RemotingResourceFactory class for providing different resources
  depending on whether it's an external or internal build.
* Adds an AppInitializer for initializing common resources.

BUG=731851

Review-Url: https://codereview.chromium.org/2937733003
Cr-Commit-Position: refs/heads/master@{#481006}

Add qiangchen@ as owner of c/b/ui/views/desktop_capture/.

Bug: None
Change-Id: I0e0ca093f1224abcd7ce7accf9400b11f1eab7cb
Reviewed-on: https://chromium-review.googlesource.com/540822
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481005}

Currently content download only supports upper case guid. This CL
limits guid in download service to be upper case ascii chars.

In the future, we should consider the two guid approach to decouple
from content layer guid details.



Bug: 734818
Change-Id: Id03a234c0edb14c9ee7a66d5bb486cb1503e1840
Reviewed-on: https://chromium-review.googlesource.com/540679Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481004}

Revert of Skip missing translations when generating JSON resources. (patchset #2 id:60001 of https://codereview.chromium.org/1676793002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 480994 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyZjUzYmUxNjFiMDFhNGNmMDRkZmEzODdiNjZiZGE3MTBmNjAxYzAM

Original issue's description:
> Skip missing translations when generating JSON resources.
>
> It doesn't make sense to replace missing translations with english
> strings because Chrome can do this automatically when getting
> resources.
>
> BUG=369572
>
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Commit-Position: refs/heads/master@{#480994}
> Committed: https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66bda710f601c0

TBR=thakis@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369572

Review-Url: https://codereview.chromium.org/2948893002
Cr-Commit-Position: refs/heads/master@{#481003}

Prep CL for https://codereview.chromium.org/2882063002

BUG=721395
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2903213004
Cr-Commit-Position: refs/heads/master@{#481002}

In general, if a try job is successful, there
are no interesting new baselines or expectations to add.

If the tests were run, this just saves us one request;
if the tests were not run because the change doesn't
affect some platform, then this prevents us from printing
a warning message.

Change-Id: I937f4686bdf8911f10ba5f19d401ac088a3975eb
Reviewed-on: https://chromium-review.googlesource.com/526253
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481001}

https://pdfium.googlesource.com/pdfium.git/+log/d5a13afe9265..e10509a3d2a1

$ git log d5a13afe9..e10509a3d --date=short --no-merges --format='%ad %ae %s'
2017-06-20 janeliulwq Wrapper class for annotation dictionary + CPDF_Form

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I97324f780352e85c7fb7b53620f2b2de8c6bba34
Reviewed-on: https://chromium-review.googlesource.com/541795
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481000}

The drivers for several devices on Windows appear to not properly handle
querying for controls used in the context of Image Capture. These cases lead to
video capture being broken and users seeing only a blank image.

This CL adds a feature flag kImageCaptureControls Image Capture on Windows. 
For now, we disable this feature by default. The feature can be enabled by 
adding --enable-features=ImageCaptureControls to the command-line.

Bug: 722038
Test: Manual tested on Windows using iSpy virtual device.
Change-Id: I654ff72772af10c2d5356d5131ed7ed98e300c1f
Reviewed-on: https://chromium-review.googlesource.com/530076Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480999}

This logic matches the surface creation logic on Wayland.

BUG=angleproject:1651

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icca63e3778d2f4c327da44758b09b9328d02adee
Reviewed-on: https://chromium-review.googlesource.com/537967Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480998}

Zucchini is a patching tool inspired by Courgette, for delta compression of archives containing common exexecutable formats.
This is the first step of integrating Zucchini in Chrome Installer.

BUG=729154

Review-Url: https://codereview.chromium.org/2922273002
Cr-Commit-Position: refs/heads/master@{#480997}