GitLab

http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html is flaky, but
I cannot reproduce it and don't see any cause. To understand the problem, this
CL adds two more layout tests.

R=hiroshige
BUG=415872

Review URL: https://codereview.chromium.org/950813002

git-svn-id: svn://svn.chromium.org/blink/trunk@190652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=jl@opera.com, haraken@chromium.org

Review URL: https://codereview.chromium.org/946293003

git-svn-id: svn://svn.chromium.org/blink/trunk@190651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=420515

Review URL: https://codereview.chromium.org/946163003

git-svn-id: svn://svn.chromium.org/blink/trunk@190650 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://dom.spec.whatwg.org/#interface-domtokenlist

BUG=460722

Review URL: https://codereview.chromium.org/947833002

git-svn-id: svn://svn.chromium.org/blink/trunk@190649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously ScriptRunner could execute an arbitrary number of scripts
leading to janks.  Now ScriptRunner polls shouldYieldForHighPriorityWork
before running each script.

In addition the task to execute the scripts is now posted on the
loading task queue.

BUG=456777

Review URL: https://codereview.chromium.org/866273005

git-svn-id: svn://svn.chromium.org/blink/trunk@190648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [Oilpan] Set stack limit using estimated sizes (Re-land) (patchset #2 id:20001 of https://codereview.chromium.org/943293002/)

Reason for revert:
Speculatively reverted due to failures in browser test ExtensionPageCaptureApiTest.SaveAsMHTML.

BUG=460868

Original issue's description:
> Set the stack limit size based on estimated sizes.
> 
> To check if the stack memory has enough room for recursive
> calls, we tried to allocate a large object and assumed the size.
> This CL estimate the real thread stack limit using APIs.
> On some platforms where such APIs do not work correctly,
> we set the limit using the old algorithm.
> 
> ---
> This CL is re-land of https://codereview.chromium.org/910663002/
> and https://codereview.chromium.org/927213002/.
> Test was changed in another CL https://codereview.chromium.org/946483002/
> 
> BUG=420515, 457982
> R=kouhei
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190636

TBR=oilpan-reviews@chromium.org,kouhei@chromium.org,peria@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420515, 457982

Review URL: https://codereview.chromium.org/953453003

git-svn-id: svn://svn.chromium.org/blink/trunk@190647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds yukishiino@ (myself) as an owner of bindings/.

BUG=

Review URL: https://codereview.chromium.org/938633002

git-svn-id: svn://svn.chromium.org/blink/trunk@190646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simply removes [Replaceable] extended attribute at Window.location.

https://heycam.github.io/webidl/#Replaceable says
"An attribute with the [Replaceable] extended attribute must not
also be declared with the [PutForwards] extended attribute."

https://html.spec.whatwg.org/multipage/browsers.html#window says
[PutForwards=href, Unforgeable] readonly attribute Location location;

Thus, this CL removes [Replaceable] extended attribute.

There is no change in generated code.

Note that Document.idl has correctly been specifying
[PutForwards=href, Unforgeable] readonly attribute Location location;
With this CL, Window.idl specifies the same.

BUG=

Review URL: https://codereview.chromium.org/943313002

git-svn-id: svn://svn.chromium.org/blink/trunk@190645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaStatusDisplay and MediaTextTrackDisplay, that is.

BUG=448795

Review URL: https://codereview.chromium.org/946243003

git-svn-id: svn://svn.chromium.org/blink/trunk@190644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are no changes to the generated code.

One instance of TreatReturnedNullStringAs=Null remains for
Node.textContent, where removing it does change the generated code
because TreatUndefinedAs=NullString is also involved.

BUG=460722

Review URL: https://codereview.chromium.org/950763002

git-svn-id: svn://svn.chromium.org/blink/trunk@190643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Have the window.internals Geolocation test methods typecheck its arguments,
throwing TypeError if passed invalid Document arguments.

Additionally, have the methods gracefully handle detached documents.

R=tkent
BUG=460550

Review URL: https://codereview.chromium.org/925953003

git-svn-id: svn://svn.chromium.org/blink/trunk@190642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add isTabStop attribute which exposes the "tab focusable flag" defined
in the HTML spec so that shadow hosts can control its own focusability.

By default this is disabled under "experimental web platform features" flag.

Design doc:
https://docs.google.com/a/chromium.org/document/d/1k93Ez6yNSyWQDtGjdJJqTBPmljk9l2WS3JTe5OHHB50/edit

BUG=380445
TEST=fast/dom/shadow/{focus-navigation-with-istabstop.html,focusable-elements-with-istabstop.html}

Review URL: https://codereview.chromium.org/917613004

git-svn-id: svn://svn.chromium.org/blink/trunk@190640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Have the [TypeChecking] extended attribute on a partial interface
distribute down to its methods and attributes. This avoids having the
interface that it extends to declare the [TypeChecking] behavior that
the partial interface methods&attributes require.

The attribute's value is appended to any [TypeChecking] attribute
values already present on the partial interface members.

R=haraken,jl@opera.com,bashi
BUG=460550

Review URL: https://codereview.chromium.org/938403007

git-svn-id: svn://svn.chromium.org/blink/trunk@190639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, a pointer to a GarbageCollected object is stored by RawPtr<T> or
T* in CrossThreadTaskN.  If a GC happened before the task is performed,
the object can be swept.

Applying ParamStorageTraits makes it CrossThreadPersistent<T>, and
we can safely use createCrossThreadTask() for GarbageCollected objects.

BUG=378192

Review URL: https://codereview.chromium.org/934963003

git-svn-id: svn://svn.chromium.org/blink/trunk@190638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use ExclusiveStreamReader to forbid a user from reading data via body
attribute.

BUG=435393

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189611

Review URL: https://codereview.chromium.org/899653002

git-svn-id: svn://svn.chromium.org/blink/trunk@190637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To check if the stack memory has enough room for recursive
calls, we tried to allocate a large object and assumed the size.
This CL estimate the real thread stack limit using APIs.
On some platforms where such APIs do not work correctly,
we set the limit using the old algorithm.

---
This CL is re-land of https://codereview.chromium.org/910663002/
and https://codereview.chromium.org/927213002/.
Test was changed in another CL https://codereview.chromium.org/946483002/

BUG=420515, 457982
R=kouhei

Review URL: https://codereview.chromium.org/943293002

git-svn-id: svn://svn.chromium.org/blink/trunk@190636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes the gesture tap not to highlight editable nodes even
when they have "cursor: pointer" in their ancestor chains.

It was unlikely to occur until bug 399522 changed the tap highlighting
to use the composed tree traversal. With that fixed, input elements
with "cursor: pointer" in their ancestor nodes can hit this issue.

BUG=457552
TEST=compositing/gestures/gesture-tapHighlight-form-input-text.html

Review URL: https://codereview.chromium.org/931753002

git-svn-id: svn://svn.chromium.org/blink/trunk@190635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=460356
TBR=kbr

Review URL: https://codereview.chromium.org/944363002

git-svn-id: svn://svn.chromium.org/blink/trunk@190634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Check for an active document in WebPluginContainerImpl::windowClipRect (patchset #1 id:1 of https://codereview.chromium.org/944753004/)

Reason for revert:
This did not fix the crash but it gave us enough info to fix this (in a followup).

Original issue's description:
> Check for an active document in WebPluginContainerImpl::windowClipRect
> 
> This is a speculative fix for crbug.com/459713. The exact cause is not
> clear in our crash reports but this change may fix an issue where the
> document is being destroyed. A Document's m_frame is only reset
> during destruction, after the lifecycle is set to be not active, so
> this patch adds a check for isActive. Additionally, this patch will
> move the crash location if the node's renderer is null.
> 
> BUG=459713
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190582

TBR=eae@chromium.org,esprehn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459713

Review URL: https://codereview.chromium.org/947873002

git-svn-id: svn://svn.chromium.org/blink/trunk@190633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes us compare unvisited background colors consistently
when determining LayoutTheme adjustment. Previously CachedUAStyle would
read out unvisited colors, while authorStyleInfo would read visited
dependent colors.

BUG=381808

Review URL: https://codereview.chromium.org/950743002

git-svn-id: svn://svn.chromium.org/blink/trunk@190632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://dom.spec.whatwg.org/#interface-documenttype

BUG=460722

Review URL: https://codereview.chromium.org/943253002

git-svn-id: svn://svn.chromium.org/blink/trunk@190631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The latest editor's draft introduces MIDIPortState state attribute in
MIDIPort. To support the attribute, update the blink API to use enum
for representing MIDIPortState instead of bool isActive flag.

Spec: http://webaudio.github.io/web-midi-api/#idl-def-MIDIPort

This is the first step of three to update the MIDIAccessor blink API.

BUG=279097
TEST=build with chromium

Review URL: https://codereview.chromium.org/942243002

git-svn-id: svn://svn.chromium.org/blink/trunk@190630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=190615

BUG=460408
TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/943263002

git-svn-id: svn://svn.chromium.org/blink/trunk@190627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=460722, 437205, 460725, 460726

Review URL: https://codereview.chromium.org/942303002

git-svn-id: svn://svn.chromium.org/blink/trunk@190626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://dom.spec.whatwg.org/#interface-characterdata
https://dom.spec.whatwg.org/#interface-comment
https://dom.spec.whatwg.org/#interface-processinginstruction
https://dom.spec.whatwg.org/#interface-text

This replaces |length| with |count| in a few places. The implementation
already uses |count| as the argument name.

BUG=460722

Review URL: https://codereview.chromium.org/946823002

git-svn-id: svn://svn.chromium.org/blink/trunk@190625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up r190347 and support the retirement of contiguous container
annotations for 'non-inline' heap vector backing stores.

In order to handle the tracing of heap vector backing stores identified
conservatively via the stack or other roots without overflowing such
annotations, the tracing of these will implicitly widen the annotation
to apply to the entire backing store allocation.

R=haraken,inferno
BUG=420515

Review URL: https://codereview.chromium.org/941073002

git-svn-id: svn://svn.chromium.org/blink/trunk@190624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Layout object is no longer on the heap, so comment no longer applies.

R=haraken
BUG=398342
NOTRY=true

Review URL: https://codereview.chromium.org/941923003

git-svn-id: svn://svn.chromium.org/blink/trunk@190623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Flickering is observed on text selection when hitting culled
inline, because culled inline doesn't get the right position
from RenderInline::positionForPoint for the selection.

This patch changes the condition to firstLineBox to
firstLineBoxIncludingCulling for culled inline.

BUG=460077
R=pdr@chromium.org
TEST=fast/events/drag-selects-culled-inlines.html

Review URL: https://codereview.chromium.org/929883003

git-svn-id: svn://svn.chromium.org/blink/trunk@190622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://dom.spec.whatwg.org/#interface-attr

BUG=460722

Review URL: https://codereview.chromium.org/942283002

git-svn-id: svn://svn.chromium.org/blink/trunk@190621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now the latest editor's draft has MIDIPortState state attribute
in MIDIPort.
http://webaudio.github.io/web-midi-api/#midiport-interface

BUG=279097
TEST=LayoutTest/webmidi

Review URL: https://codereview.chromium.org/942153004

git-svn-id: svn://svn.chromium.org/blink/trunk@190620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is part of a three-sided CL:
1- https://codereview.chromium.org/926793004
2- https://codereview.chromium.org/937563004
3- <this>

BUG=449178

Review URL: https://codereview.chromium.org/936873002

git-svn-id: svn://svn.chromium.org/blink/trunk@190619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is part 3/4 of a clean up to switch to int64 time stamps when caching metadata. The background to this is that converting int64 time stamps to double and back to int64 is lossy and causes false time stamp mismatches.

BUG=453298

Review URL: https://codereview.chromium.org/940443002

git-svn-id: svn://svn.chromium.org/blink/trunk@190618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=333143
NOTRY=true

Review URL: https://codereview.chromium.org/945233002

git-svn-id: svn://svn.chromium.org/blink/trunk@190617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=457134
R=dgozman

Review URL: https://codereview.chromium.org/943963002

git-svn-id: svn://svn.chromium.org/blink/trunk@190616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For some reason, the wrong bot didn't use XP baselines. :/

BUG=460408,458813

Review URL: https://codereview.chromium.org/945943002

git-svn-id: svn://svn.chromium.org/blink/trunk@190615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a category is selected, the first preset is used instead of the last
chosen preset. This change fixes this issue by setting the correct bezier.

BUG=450140
TBR=dgozman

Review URL: https://codereview.chromium.org/945163005

git-svn-id: svn://svn.chromium.org/blink/trunk@190614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec: https://w3c.github.io/encrypted-media/#queue-waitingforkey

BUG=337975
TEST=none yet, need Chromium changes to call it.

Review URL: https://codereview.chromium.org/946503003

git-svn-id: svn://svn.chromium.org/blink/trunk@190611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL connects main-thread scrolls to existing top controls machinery in
compositor. Main-thread now updates top controls "content offset" during
slow-scrolls. This value is synced with compositor during the commit and
ensures that compositor properly animates top controls if necessary.

Also deprecated top_controls_layout_height in favor of two properties:
 - top_controls_height: The height of top controls
 - top_controls_shrink_viewport: flag controlling if blink view port should
 	shrink as a result of top_controls being show.

Chromium side CL: http://crrev.com/814083004

BUG=333143

Review URL: https://codereview.chromium.org/893683003

git-svn-id: svn://svn.chromium.org/blink/trunk@190610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=400339
R=eae@chromium.org,leviw@chromium.org
TEST=editing/input/orphan-set-selection-range.html

Review URL: https://codereview.chromium.org/945873003

git-svn-id: svn://svn.chromium.org/blink/trunk@190609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There was a FIXME about not re-resolving positions if the grid is grown during
auto-placement. But as the spec has changed [1] and you can only refer to the
explicit grid (even if you use for example grid-column: 1 / -1). It seems that
we can get rid of this FIXME as it's not a causing a problem anymore.

[1] http://dev.w3.org/csswg/css-grid/#grid-placement-int

Review URL: https://codereview.chromium.org/925593004

git-svn-id: svn://svn.chromium.org/blink/trunk@190608 bbb929c8-8fbe-4397-9dbb-9b2b20218538