- 25 Nov, 2019 40 commits
-
-
Owen Min authored
This test is flaky on multiple platforms. Bug: 1028292 Tbr: yangguo@chromium.org Change-Id: I807194f48011818dd070ae27ef6f34271ef9db07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933562Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718835}
-
Owen Min authored
The test are flaky on win, mac and chromeos. Bug: 1028272, 1022213 Tbr: rbpotter@chromium.org Change-Id: I0d233a9fc1236a33880ef8e2bf1114037268e336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933409Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I14168acf78224e50f783501a9570de87a4d77422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934429Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#718833}
-
Xianzhu Wang authored
This is mainly for CompositeAfterPaint, but the code also applies to pre-CAP. Previously we used the box as the display item client for scroll corner which was too big when the scroll corner paint chunk can't be merged into other chunks thus gets composited. The too big composited layer prevents later scrolling contents from being merged into the box's scrolling background, causing extra layers. Bug: 524134 Change-Id: I8317cfd36a03127b9d8722984b423348b842e649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931757Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718832}
-
Jasper Chapman-Black authored
Previously, the JavaScript Web Worker backing the Tiger Viewer would stream newline-delimited JSON content and render incrementally. The new WebAssembly web worker made tradeoffs to not support streaming, but have significantly smaller file sizes and faster load times. Change-Id: Iba8d73e7e6e1f7e3d97113a8a6942e8443865244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933561 Auto-Submit: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718831}
-
Megan Jablonski authored
Change-Id: Ied29ff46bbe283b264d844b67fa317c1527b5535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921655 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#718830}
-
Shakti Sahu authored
Fixed extra padding to the left of favicon and to the left of lock icon. Also aligned the baseline of URL to the bottom of lock icon. Bug: 1027713, 1025101 Change-Id: I69b7edd5d0c18eb8c6acd6d2d530149eac837fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931799Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718829}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f20323a4a264..98b58ad3de71 git log f20323a4a264..98b58ad3de71 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 tsepez@chromium.org Call FPDFPage_FormFieldZOrderAtPoint() from embedder test. 2019-11-25 tsepez@chromium.org Improve embedder test coverage of FPDFBookmark_GetDest()/GetAction(). 2019-11-25 tsepez@chromium.org Call two more app methods from JavaScript tests. 2019-11-25 tsepez@chromium.org Put two more instances of std::vector<wchar_t> into the partition. Created with: gclient setdep -r src/third_party/pdfium@98b58ad3de71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6338d7d8d63245e8218b649b4c8ddc523f135882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718828}
-
David Bokan authored
Change-Id: I83d46f26a670e4e6a28375c44a6762b784e1e5c7 Bug: 1027918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932883 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718827}
-
Andres Calderon Jaramillo authored
This CL fixes the RasterTaskSchedulingDelay UMA to not count raster tasks that depend on at-raster image decodes. This is because measuring the delay for them may or may not include the decode/upload time depending on whether we do a software or a hardware decode. At-raster image decodes should be rare enough that we don't need to consider them. Bug: 995155 Test: this CL adds unit testing for the new behavior. Change-Id: I040ed17f647033aeed3314c76e9ac81d5c5ed2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924613Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#718826}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7b9ad5a0b6c3dd85d04d40b6d4eaef75c3988f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934256Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#718825}
-
Danyao Wang authored
Without this patch, an incomplete autofill instrument is still offered to the user even when kStrictHasEnrolledAutofillInstrument is enabled. This is due a bug in PaymentRequestImpl.show() that checks the strict criteria before the correct value of |mIsUserGestureShow| is updated. This patch moves |mIsUserGestureShow| update to earlier in the call flow to fix the bug. A browsertest is added to guard against regression. Bug: 1028114 Change-Id: Id0f89e8d8f7180cc3a85c0f30ee8e05a1d849042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934510 Commit-Queue: Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718824}
-
Adrienne Walker authored
Instead of going ui -> io thread -> cache storage task runner, instead have the ui just post two tasks. This should cut down on any potential races on startup. This is a followup to comments left on: https://chromium-review.googlesource.com/c/chromium/src/+/1907095/4#message-d81d6b0b2d2ab774ba9aeff7674e1c4b842fe342 Bug: 1022104 Change-Id: Icdfd30c36969795ba3625179137360258171b170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931580 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#718823}
-
chrome://flagsDemetrios Papadopoulos authored
Bug: None Change-Id: Iaed9563517a5b48138d2cd6417ec30ff55c550b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930211Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#718822}
-
James Hawkins authored
In the multidevice world, all phones support sign in. Bug: none Test: none Change-Id: Ie0626f0e2066be376b9cf0c9dac0036f5a0fa6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932698 Auto-Submit: James Hawkins <jhawkins@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#718821}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f70aafdb1ad2..e8f39ab95539 Created with: gclient setdep -r src-internal@e8f39ab95539 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:none Tbr: jbudorick@google.com Change-Id: Ibd0787d2f79b80a61b70f88b3fafddee62835057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933765Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718820}
-
Piotr Bialecki authored
Along with blink-side implementation of the Web IDL. Change-Id: I1f975c0b36f2a0e8d38400368455fd4a23cb19c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919942 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#718819}
-
Dominique Fauteux-Chapleau authored
Every call to DlpTriggeredRulesOK implicitly assumes that DLP should be checked. By returning true on non-UPLOADS policy values we avoid getting false-negatives on DLP checks. Also update tests since they all run with the assumption that every response has both a malware and a dlp verdict. Change-Id: I2fd329ced7932ce98d9af8d376ceaf984614f3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929851Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718818}
-
Austin Eng authored
This patch makes the |layout| member of the GPUPipelineDescriptorBase optional. If it is not provided, a default layout is inferred from the ShaderModules provided. |pipeline.getBindGroupLayout| may be called to get the existing, or the computed bind group layout. If no bind group layout exists at the provided index, an empty bind group layout is returned. Bug: chromium:852089 Change-Id: I12b0421980a88f8fe0cc94217fa623c1b3c601c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934607Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@google.com> Cr-Commit-Position: refs/heads/master@{#718817}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f534a6404772..15be5282e91b git log f534a6404772..15be5282e91b --date=short --first-parent --format='%ad %ae %s' 2019-11-25 orphis@webrtc.org Add support for RtpEncodingParameters::max_framerate Created with: gclient setdep -r src/third_party/webrtc@15be5282e91b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic67b66942fc031a3f632d60f572f13eb31d4e669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934575Reviewed-by:
-
Etienne Bergeron authored
The typesetter was used to do the migration from the native rendertext to the skia implementation. There is no longer any use of the native typesetter and the concept can now be removed. Bug: 454835 Change-Id: Ic4e2c5f136f9c52243cf07e538a8025dbe91af2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924882Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718815}
-
Albert Chaulk authored
If the window has no root window then calling Focus() crashes with a suspected null FocusClient. CanFocus will return false for this case Test: None Bug: 144861135 Change-Id: I0dcf37406fd26e4a307889575d9a66ab60b1d14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934511Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#718814}
-
Lily Chen authored
This renumbers the CookieInclusionStatus::ExclusionReason enum to remove the gap where EXCLUDE_SAMESITE_EXTENDED previously was. Bug: 953995 Change-Id: I40e202d97f98bdb1c9bb2e67c6e2e3c01baf1bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933018 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#718813}
-
Dave Tapuska authored
This was changed in https://crrev.com/388754 for DOMImplementation createDocument and should have been done the same for cloneNode. This brings our implementation in alignment with Firefox. BUG=605203 Change-Id: I501ae7ea21dc8017e3f21181aed6cf274a71a728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927024 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Change-Id: I12bcf5d208b4f272bc5e3e538093ebe968e2f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914552 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Rohit Rao authored
BUG=1022461 Change-Id: I772b9007194f54f7cac4523826bc05e65281047f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933732Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#718810}
-
Samuel Huang authored
This CL redoes section processing in DisassemblerElf to fix 4 bugs discovered by zucchini_disassembler_elf_fuzzer that ckitagawa@ recently added. These bugs all involve some malformed SHF_EXECINSTR section that sneaks past early checks to reach pointer extraction, then triggers another check. Summaries: * Issue 1023095: |sh_type == SHT_NOBITS| helps section bypass bound checks. DCHECK is triggered in Abs32GapFinder::Abs32GapFinder() because |sh_size| grossly exceeds bounds. * Issue 1023183: |sh_size == 0| and |sh_offset < image_.size()| makes section seem benign, but |sh_offset| is ignored when computing |offset_bound|. DCHECK is triggred in Abs32GapFinder() ctor because |sh_offset| > estimated image size (|offset_bound|). * Issue 1023203: ELF64. |sh_size == 0| and |sh_offset == 0| make section seem benign. However, |sh_addr| far exceeds 32-bit bound. In ParseExecSection(), |sh_addr| fails base::checked_cast(). * Issue 1023210: Section has vaid bounds, and |sh_addr == 0| makes section excluded (heuristically) from AddressTranslator. Section proceeds to ParseExecSection(), which finds a rel32 whose: * Location offset is assumed okay. * Location RVA, by optimization, is converted directly using section data, and is also okay. * Target RVA is validated by AddressTranslator. But in Rel32ReaderX86::GetNext(), location offset -> RVA now uses AddressTranslator, which by earlier exclusion, results in kInvalidOffset. This pollutes target RVA and target offset, and triggers DCHECK. The above shows mismatches among usage of sections for the following: * Location / RVA matching (AddressTranslator), * ELF image size estimation (|offset_bound|), * Pointer extraction, against bypasses due to |sh_type == SHT_NOBITS|, |sh_size == 0|, and |sh_addr == 0|. To fix the issues, this CL separates decision logic from enactment. Decision logic is moved to JudgeSections(), which takes a section and returns a "judgement" consisting of bit field defined from new enum SectionJudgement. The judgement is enacted in ParseHeader(), which chooses to invalidate the ELF, ignore the section, or use the section with greater discretion on applying pointer extraction. Additional fix: Ignore (non-fatal) sections with SHF_TLS bit, since these sections can have offset-RVA ranges that conflict with other section's. Without this fix, Zucchini on Ubuntu won't recognize itself as an ELF file! Bug: 1023095, 1023183, 1023203, 1023210, 1022538 Change-Id: Icc86f26db17a61bb41b432177ef6c3dc0dcd1a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933632 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#718809}
-
Yusuke Sato authored
The param is just ignored when the image is squashfs, but setting "rw" for the read-only fs is still confusing. This also adds a test that covers the case where no serial number is given. BUG=None TEST=try Change-Id: Id153e51f4d44432728e7735620853833f784a82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931919 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#718808}
-
Devlin Cronin authored
Push back the expiration of soon-expiring histograms that are still useful. This marks the following metrics as never expiring, since they are always valuable in monitoring extension usage or performance: Extensions.ContextMenuAction Extensions.InjectEnd_BlockingScriptCount Extensions.InjectEnd_ScriptCount Extensions.InjectIdle_BlockingScriptCount Extensions.InjectIdle_ScriptCount Extensions.InjectStart_CssCount Extensions.InjectStart_Time Extensions.LoadAllComponentTime Extensions.LoadAppUser Extensions.LoadBrowserAction Extensions.LoadNoExtensionAction Extensions.InjectStart_Time Extensions.LoadAllComponentTime Extensions.LoadAppUser Extensions.LoadBrowserAction Extensions.LoadNoExtensionAction Extensions.RuntimeHostPermissions.ExtensionHasWithheldHosts Extensions.RuntimeHostPermissions.GrantedHostCount And marks the following as expiring later, since they are still useful for now, but may not be required in the future: ExtensionInstallVerifier.GetSignatureResult ExtensionInstallVerifier.InitResult Extensions.PopupCreateTime Extensions.PopupLoadTime2 Extensions.SyncGetMessageBundle ProxyOverriddenBubble.UserSelection Bug: 1016417, 1025803, 1025818, 1025827, 1025837, 1025849, 1025850, 1025859, 1025865, 1025887 Change-Id: Ie1542aedba4c413409bb10c06ec255b51da11f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927215Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718807}
-
bttk authored
This change reduces dependency on RecordHistogram.Natives and unblocks its refactoring in https://chromium-review.googlesource.com/c/chromium/src/+/1915193 Change-Id: I5b532083c22b94298dc087b8515709be787dbd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928377Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#718806}
-
Lily Chen authored
This fixes a bug where cookies that would be rejected for other reasons (e.g. domain mismatch) would still generate a SameSite warning message. This led to misleading/alarming messages that implied that sites were fetching resources from domains that they were not in fact making requests to. The fix is to not attach a warning to the cookie status if there are any exclusion reasons other than the new SameSite ones. Bug: 1027318 Change-Id: I77a26ee4679aa6010b0e6b604476ec364614ce96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929780 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Eldar Rello authored
Bug: chromium:1025557 Change-Id: I34fab1c438b9cde8b7df90e75a3cf875cb327ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924367 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#718804}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a59e70ec48ac..7b29abfc486e git log a59e70ec48ac..7b29abfc486e --date=short --first-parent --format='%ad %ae %s' 2019-11-25 sugoi@google.com Improved pNext pointer handling Created with: gclient setdep -r src/third_party/swiftshader@7b29abfc486e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/144999059,chromium:b/119321052 Tbr: swiftshader-team+autoroll@google.com Change-Id: I6f72919542f9b4da034d0cfff0eece407baee706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933758Reviewed-by:
-
Reilly Grant authored
Bug: 1007633 Change-Id: I225b0ac97a202041fbe6cd92fa78ae5a1f4d79b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931621 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718802}
-
Jonathan Backer authored
This is a speculative fix for https://crbug.com/1022151. Based on the crash error and stack trace, it seems likely that we are calling ClearFramebufferResourceManager::Destroy after a context is unavailable (i.e. released or lost). In this case, we shouldn't be making any more GL calls. This copies a pattern of GLES2DecoderImpl::Destroy, so that CFRM::Destroy is only called if we have a current context. Bug: 1022151 Change-Id: Icc76e505fa32c3b3bc5bea68a973ac4550828bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934519Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#718801}
-
Daniel Rubery authored
The ternary operator here was backwards, with light mode colors being used when the system is in dark mode, and vice versa. Change-Id: Id6788f601a4cd741fb6ddce6ebe1aeb8fb44f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933386 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#718800}
-
Kristi Park authored
The actual screenshot image editor implementation lives downstream in Clank and should be used over the upstream implementation. See go/chrome-screenshotz-dd Bug: 1024586 Change-Id: Ia79a8ea9b9d95e40a5965168be435d325dc68b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931270 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Theresa Wellington authored
Some clean-up from nits in http://crrev.com/c/1929262. BUG=1018170 Change-Id: Ib062e2ed3f512d3d3789099424534412519f5025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934449Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718798}
-
Lily Chen authored
Bug: 1007122 Change-Id: I1fd2715b5d18b512d3b498779c5e9495c2a6ed44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929986Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#718797}
-
Shawn Gallea authored
This is needed to prevent a crash where WebContentController::AttachTo is called after the controller is destroyed. Bug: Internal b/144546163 Bug: Internal b/144861135 Test: Compile cast_shell Change-Id: I71b05e3f6d404a4044c623a1712650e4f459e85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934652Reviewed-by:
-
