GitLab

This CL changes the tests for generate_buildbot_json.py to capture all
printed lines. It requires tests to assert about the contents of these
printed lines, and then clear them.

It also adds a --verbose flag to the main script, which is passed when
checking the configs.

Also fixes a test for swarming mixins and how they interact with certain
classes of tests.

Bug: 886993
Change-Id: I047d74689d72f35bc7d19c8da338c070a8a5d9a5
Reviewed-on: https://chromium-review.googlesource.com/1237239
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593015}

Bug: 721403
Change-Id: I56ab262ba7349e6261816e99fe01fe1d39e0e79a
Reviewed-on: https://chromium-review.googlesource.com/1237252Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593014}

So far the display ID was recognizesed on creation of a toplevel,
but moving across displays isn't considered well.

This CL recognizes the timing of a window moving to another
display, and let WindowTreeHostMus updates its own display ID
properly.

BUG=866947
TEST=the new test case covers

Change-Id: I1e859f879a919674e90875a74434bb73e94edd73
Reviewed-on: https://chromium-review.googlesource.com/1234857
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593013}

MakeMultipleFramesPacket() method has already existed but not all packet makers were using it. This CL cleans up the redudant code. No behavior change.

Change-Id: Ic1379d9cf97c2c776be826608d04f7f013e39600
Reviewed-on: https://chromium-review.googlesource.com/1236928
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593012}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/b64cb7b68093..9f85491d8830


git log b64cb7b68093..9f85491d8830 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 iannucci@chromium.org Whitespace to trigger additional builds.


Created with:
  gclient setdep -r src/native_client@9f85491d8830

The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:861512
TBR=mseaborn@chromium.org

Change-Id: Ib74c016615152c02dea0c08364c6e443524349f8
Reviewed-on: https://chromium-review.googlesource.com/1237353Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593011}

This is a follow up CL of go/cgcl/1194340 to fix the same issue when
blur is not enabled.

Bug: 878162
Change-Id: Ia6c3b6942b4304a12bfa3049e0b37252a4deae8f
Reviewed-on: https://chromium-review.googlesource.com/1237403Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593010}

Cleanup ruleset manage unittests by removing the need to use net::URLRequest.
Also, make WebRequestInfo movable.

BUG=696822

Change-Id: I0a0d93406b67ff1a9338b470ef68b03062ae22fd
Reviewed-on: https://chromium-review.googlesource.com/1235331
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593009}

https://pdfium.googlesource.com/pdfium.git/+log/4bf804086c4f..e65756725f82


git log 4bf804086c4f..e65756725f82 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 npm@chromium.org Make some methods const in XFAJSEmbedderTest


Created with:
  gclient setdep -r src/third_party/pdfium@e65756725f82

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iee59439218814050299cdd2615982e0fd5eb505d
Reviewed-on: https://chromium-review.googlesource.com/1236485Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593008}

There are some rules for showing/hiding the virtual keyboard when
navigating to a new page / tab. Added some tests to make sure we don't
regress these scenarios.

Bug: 849995
Change-Id: I2fee098943b6073a0d1c1f8b86cdf1a3b35455e5
Reviewed-on: https://chromium-review.googlesource.com/1233097Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593007}

The return type of size() was recently changed from size_t to
unsigned.  Adjust printf string for that.

Bug: 887639
Test: Doesn't affect any test
Change-Id: I371ee874bc4e3af6fd9891f059ce6423fdd498a8
Reviewed-on: https://chromium-review.googlesource.com/1236269Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593006}

https://android.googlesource.com/platform/external/perfetto.git/+log/7397af8da50b..97f63244f536


git log 7397af8da50b..97f63244f536 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 dproy@google.com Make all mithril components class components


Created with:
  gclient setdep -r src/third_party/perfetto@97f63244f536

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I01d82904e216a765f5cb28950f8b579a0da14eff
Reviewed-on: https://chromium-review.googlesource.com/1237356Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593005}

The IDL file did not fully specify all of the output.

Bug: 887688
Change-Id: I5ee75419006a27504e978164379acf7c024988db
Reviewed-on: https://chromium-review.googlesource.com/1237374
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593004}

This reverts commit 60d359fd.

Reason for revert: This logic could still be flaky (what if we go invisible after deferring commits), and isn't needed after https://chromium-review.googlesource.com/c/chromium/src/+/1184376, so let's revert.

Original change's description:
> Android OOP-D: DisplayScheduler should only report draw-inducing damage
> 
> Currently DisplayScheduler reports damage to SurfaceManager in any case
> where a damaged surface ID damages the display. While these cases will
> trigger a draw when visible, they don't necessarily trigger a draw
> in any defined timeframe. This can lead to issues. Consider:
> 
> 1) Display 1 is not visible, embeds surface A.
> 2) Surface A sends CF 1, we don't immediately ack as we will wait for
>    Display 1 to draw.
> 3) Display 2 becomes visible, embeds surface A with a new surface ID.
> 4) Display 2 will never update, as no new frames will be produced for
>    surface A as the renderer is continually waiting on the ack for
>    CF 1.
> 
> By having DisplayScheduler report no damage if invisible, we always
> ack frames in a timely manner. This may allow a renderer to produce
> some extra frames when its display is invisible, but this should be
> limited as the renderer itself receives visibility notifications and
> won't get additional BeginFrames once visibility is fully processed.
> 
> Bug: 875895
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I272de950d8e4d4c819c445dc8162ac360afb80a1
> Reviewed-on: https://chromium-review.googlesource.com/1182862
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584917}

TBR=fsamuel@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 875895
Change-Id: Idefad0b80d08b3c9fecf655b27b3c6ffb85eca10
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1232335Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593003}

- Deletes legacy recent_tabs files.
- Modifies recent_tabs_table_coordinator_test to work with the new coordinator.
(Deletes tableVC related asserts, since a coordinator shouldn't be tied to a VC)
- Renames RecentTabsHandsetViewControllerCommand to RecentTabsPresentationDelegate.h
and moves it to its own file.
- Renames LegacyRecentTabsTableViewControllerDelegate to RecentTabsTableViewControllerDelegate.

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iea5b2aa8c32bdac7c6f8070cf721d8ad0991962a
Reviewed-on: https://chromium-review.googlesource.com/1235278Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593002}

Allows ws clients to close touch ui on events outside their windows.

Add a new PointerWatcher plumbing to [Mus]ViewsDelegate.
Wires up watchers to the Mus-only PointerWatcherEventRouter.
(ui/views/mus/* is not allowed as a dependency of ui/views/*)

Destroy the touch selection ui on PointerWatcher mouse events.

Bug: 884394, 887725
Test: Mouse events outside the KSV window close KSV text touch ui.
Change-Id: I0e41da4d03719001191f7d5ab669bcc1805bd63c
Reviewed-on: https://chromium-review.googlesource.com/1232955Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593001}

After saving a card locally, we see a "Card saved" text animation. When the text is clicked on, the icon is highlighted and the text looks bold and clunky. This CL makes the text look normal.

Before: https://screenshot.googleplex.com/Jt3omKZ7RY9
After: https://screenshot.googleplex.com/jAMgKyYs3RQ


Bug: 881320
Change-Id: I604c981fad7171c88d93d95d9029a2aa0a70484e
Reviewed-on: https://chromium-review.googlesource.com/1236271Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#593000}

Bug: 832124
Change-Id: If17c7e3cdd5143e2014176feb5bcfda60a8da4fe
Reviewed-on: https://chromium-review.googlesource.com/1236755Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592999}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b20563f5defb..477dda58e6d7


Created with:
  gclient setdep -r src-internal@477dda58e6d7

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I80a4f6e091ed5b7a14ae26c2479bd2d087ffd4ab
Reviewed-on: https://chromium-review.googlesource.com/1237355Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592998}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9cba9ffdfdc6..0c22dec277af


git log 9cba9ffdfdc6..0c22dec277af --date=short --no-merges --format='%ad %ae %s'
2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@0c22dec277af

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I5beae3f74292c7d2764e31d90c1f9071a14ac96d
Reviewed-on: https://chromium-review.googlesource.com/1236892Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592997}

https://skia.googlesource.com/skia.git/+log/268707284dcd..32f12aca36e0


git log 268707284dcd..32f12aca36e0 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 mtklein@google.com roll zilb
2018-09-20 mtklein@google.com remove pin in SkColor4f::premul()
2018-09-20 hcm@google.com progress on canvaskit page
2018-09-20 benjaminwagner@google.com Fix bzl missing include dir.
2018-09-20 benjaminwagner@google.com Fix bzl formatting.
2018-09-20 bungeman@google.com Properly align inside GrTextBlob.
2018-09-20 robertphillips@google.com Revert "add getAlphaf() to pixmap/bitmap"
2018-09-20 jvanverth@google.com Check for valid input to text draw.
2018-09-20 reed@google.com add getAlphaf() to pixmap/bitmap


Created with:
  gclient setdep -r src/third_party/skia@32f12aca36e0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I3e41b0438287af85d040e23dda800d378310b59b
Reviewed-on: https://chromium-review.googlesource.com/1236891Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592996}

It's not uncommon to get an event fired on a View whose ancestor Window
is invisible, so it's not actually in a reachable part of the
accessibility tree. Suppress sending events in those cases (but still
serialize tree changes to be safe).

This eliminates a lot of harmless but annoying warnings from
automation_node.js like
"Got locationChanged event on unknown node: 10; this: 311"

Bug: none
Change-Id: I4cc127f74d57953c9a4f6b5ecd44902a368730ca
Reviewed-on: https://chromium-review.googlesource.com/1225950
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592995}

Bug: 877671
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1ab57a336a1cccd169f311c1d64db813cd4a1250
Reviewed-on: https://chromium-review.googlesource.com/1232615
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592994}

This converts the custom view tracking logic with just static/
explicit offsets.  This view no longer is under the crazy development
that made the custom tracking somewhat reasonable.  It is now just
overly complicated and more difficult to reason about.  Phone converted
to static offsets a while ago, so this unifies it with tablets.

BUG=883143

Change-Id: I6076501bee54f052a372be97aaab97686f44497b
Reviewed-on: https://chromium-review.googlesource.com/1228985
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592993}

When password protection verdict comes back from Safe Browsing backend,
it is possible that the web_contents has already gone. Therefore, we
need to check if web_contents is still valid before getting navigation
ID from it.

Bug: 885359
Change-Id: I3c80a8f2a3158ad3c459317e4d4954aa60f6d1f9
Reviewed-on: https://chromium-review.googlesource.com/1236816Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592992}

https://chromium.googlesource.com/catapult.git/+log/b0768af22643..6f7c60dde99f


git log b0768af22643..6f7c60dde99f --date=short --no-merges --format='%ad %ae %s'
2018-09-20 benjhayden@chromium.org Fix report_template.Static()


Created with:
  gclient setdep -r src/third_party/catapult@6f7c60dde99f

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:870324
TBR=sullivan@chromium.org

Change-Id: Ibc8513b6446fca3dbbc0996caf339432e2e1004e
Reviewed-on: https://chromium-review.googlesource.com/1236890Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592991}

Instead, simply rely on the DBUS call to compute an EID. This removes
the possibility that this observer and the AttestationPolicyObserver
both start concurrent flows.

BUG=chromium:886938
TEST=unit_tests --gtest_filter=*EnrollmentPolicyObserverTest*

Change-Id: Id26d78440bd10ca7121764431179b618469cf6fa
Reviewed-on: https://chromium-review.googlesource.com/1234373Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592990}

Bug: 881745
Change-Id: I46d30ba82182ce47d9f78a9765db76fba835febf
Reviewed-on: https://chromium-review.googlesource.com/1237258Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592989}

Bug: 864796
Change-Id: Ic975c0b63742476415a995e74a351e746908468f
Reviewed-on: https://chromium-review.googlesource.com/1231741Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592988}

Works for both tabbing and reverse tabbing. Chromevox announces
"Time's up" and "Come back at xxx" separately.

Bug: 870459
Change-Id: Icdf76ba4a24ba3a2de48dfea7e2698ea7df4c114
Reviewed-on: https://chromium-review.googlesource.com/1228482
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592987}

This CL introduces NewSplashWebApk.apk The logic for displaying the
splash screen earlier will be implemented in NewSplashWebApk.apk
Once everything is ready we will switch the server over.

This CL also refactors WebappSplashScreenController in order to share code
with NewSplashWebApk.apk

Design doc:
https://docs.google.com/document/d/1ZvpZPAIxLl_ElyMWOkDybOhCFzYk0Di4WgpLVSJdEu8/edit?usp=sharing

BUG=817263

Change-Id: Id0561eede51fa7c2d293b321cfdcae755f1e03cf
Reviewed-on: https://chromium-review.googlesource.com/1201348
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592986}

Default ripple size of 40px is 2px larger than the desired height for
a print preview settings section/row of settings section. Reduce
ripple size to match this limitation.

For copies' collate box, remove unnecessary margin that caused the
number input to shift when the checkbox appeared. Also reduce the
default size for number inputs, since neither should exceed 3 digits,
and ensure the inline margin is always large enough for the ripple
regardless of font size.

Bug: 885013, 885026, 886551
Change-Id: I29b8316b9f49e24ffcb020085ef9bc3cdb6e0ec9
Reviewed-on: https://chromium-review.googlesource.com/1235204Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592985}

Bug: 887397, 886663, 886908
Change-Id: I904a9c647c676185ce98faecd16cf815bff10e5f
Reviewed-on: https://chromium-review.googlesource.com/1236839Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592984}

ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange
was renamed and started failing since:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/35102

TBR=jam@chromium.org

Bug: 882610
Change-Id: I7caef8a59d7447d8d2420c6cff13f93e68311c1b
Reviewed-on: https://chromium-review.googlesource.com/1236284Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592983}

We don't actually have much (if any) documentation on how we
do the proper generation of credits and display licenses in Chrome;
this CL attempts to fill the gap.

TBR=jbudorick@chromium.org

Change-Id: I99c76055784475de436bef3628a0c4b191bc953a
Reviewed-on: https://chromium-review.googlesource.com/1162964
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592982}

These seems to be flaky in content_browsertests in single process
mash mode.

Bug: 874089, 887711
Change-Id: Iee0aeb5ed0c502c692eade56dfd4ae8f3248137d
Reviewed-on: https://chromium-review.googlesource.com/1237377Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592981}

This CL removes the doubletap handling logic out of the overlay play
button and onto MediaControlsImpl. This allows us to shrink the overlay
play button down to only be the clickable area for play/pause,
simplifying the event handling logic and removing zoom calculations
that were crashing.

As a side effect, this CL also fixes an issue where the user couldn't
doubletap to fast-forward/rewind without first showing the controls.

Bug: 884770, 827535
Change-Id: Ic5ff2b911d631bb10d10ac60a3b2e199ac2c3b01
Reviewed-on: https://chromium-review.googlesource.com/1235326Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592980}

Fixing 2 bugs:
(1) When "More settings" is expanded, margin should be 16px
(2) Make links actionable so hand pointer shows up

Bug: 887071, 887228
Change-Id: Iccb185f7e75e6a6fd87eac45b9b0a9f21dae15ca
Reviewed-on: https://chromium-review.googlesource.com/1236501Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592979}

Delegate the decision to blur the shelf to the shelf layout manager,
and do not blur it unless there is an active session (e.g. login
screen).

Cache whether the background is currently blurred to avoid unnecessary
updates.

Bug: 883558
Change-Id: I6bc881f8133a0363260f88efd4225fb072009fc0
Reviewed-on: https://chromium-review.googlesource.com/1227813Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592978}

BUG=778245
TEST=none
TBR=xhwang

Change-Id: Ib27cef70fe4519678dfc4b0446ee4c734c31225a
Reviewed-on: https://chromium-review.googlesource.com/1237265Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592977}

Also, adding gogerald@ to components/payments OWNERS


Bug: None
Change-Id: Id20aa0198de1363d640ddddf2438155717a82eba
Reviewed-on: https://chromium-review.googlesource.com/1236233Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592976}