- 01 Aug, 2017 40 commits
-
-
gambard authored
Bug: none Change-Id: If9a779ee684cbbd991236d590f52a18c00ed53ae Reviewed-on: https://chromium-review.googlesource.com/591149 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#490940}
-
Ramya Sharma authored
Change-Id: Iac8368f6a25931ad8f759a9655ba7a99d99f9e34 Reviewed-on: https://chromium-review.googlesource.com/595367Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#490939}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/78567f11..2b50fdbf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ibdde9a420525f836dd0870a2b385955b8cabc2a2 Reviewed-on: https://chromium-review.googlesource.com/594686Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#490938}
-
tzik authored
This CL convert WTF::Function from pass-by-unique_ptr to pass-by-value semantics. After this, WTF::Bind returns a WTF::Function object rather than an std::unique_ptr of it, and WTF::Function becomes a move-only type rather than a noncopyable type. The pass-by-value semantics reduces an allocation and indirection for each WTF::Function usage, and is a preparation to make WTF::Function closer to base::Callback. Bug: 554299 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib7758f269d120b1fb017b984c0e7a52ed5bf4bfd Reviewed-on: https://chromium-review.googlesource.com/577472 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#490937}
-
Robert Hogan authored
Bug: 636053 Change-Id: I9ed72d459d43f2a0113e4c46a496f6ecf65665d6 Reviewed-on: https://chromium-review.googlesource.com/593308Reviewed-by:
Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#490936}
-
Matt Falkenhagen authored
Also teach it to handle the case where there is no response body. This test class will evolve as more cases are added. Currently it just tests the simple case where a service worker handles the request, with no response body. Bug: 748416 Change-Id: Ifda79696eff766e725e6ee28fc27ca3d9ef9cf84 Reviewed-on: https://chromium-review.googlesource.com/590836 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490935}
-
Friedrich Horschig authored
This reverts commit 12af7241. Reason for revert: Please realnd without NOTRY as it caused compile failure. Compile log: test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test-gen.cc python ../../tools/gypv8sh.py ./v8_shell ../../chrome/third_party/mock4js/mock4js.js ../../chrome/test/data/webui/test_api.js ../../chrome/test/base/js2gtest.js extension --external=y ../../chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test-gen.cc test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs undefined:68: SyntaxError: Invalid or unexpected token #if defined(OS_CHROMEOS) ^ SyntaxError: Invalid or unexpected token at ../../chrome/test/base/js2gtest.js:462:6 Original change's description: > [Sheriff] Disabling PanelTest.* on ChromiumOS > > The tests are flaky on ChromiumOS. > > TBR=dtseng@chromium.org, yutak@chromium.org > NOTRY=true > > Bug: 751046 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Id28f1ba7cb1c42c617b041c74a3698937d21eed5 > Reviewed-on: https://chromium-review.googlesource.com/595589 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490929} TBR=dtseng@chromium.org,yutak@chromium.org,jkrcal@chromium.org Change-Id: I0e62ca5b253292bd0ae4ef5e4f12e065589494db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/595687Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#490934}
-
Tatiana Gornak authored
As per latest decision all users should use native password manager setting page instead of being redirected to the passwords.google.com BUG=619868 Change-Id: I668722d4be34b605517bd846e071779e56f61346 Reviewed-on: https://chromium-review.googlesource.com/587187Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#490933}
-
Sam Zackrisson authored
Implementation can be found here: https://codereview.webrtc.org/2979833002/ BUG=webrtc:7882 Change-Id: Iafcb65d780e73aa6bfcf58a89e5ce6603aee1bbd Reviewed-on: https://chromium-review.googlesource.com/575238 Commit-Queue: Sam Zackrisson <saza@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#490932}
-
Yoshifumi Inoue authored
This patch fixes typo in "VisibleSelectionTest.cpp" for improving code health. This is done by %s/selectin_/selection_/ Change-Id: Ib92dfd26e52154b8b279e7a6c920db1675aff737 Reviewed-on: https://chromium-review.googlesource.com/595354Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#490931}
-
gambard authored
In order to have the feature accessible, all the actions using gestures (long press, swipe to dismiss) must have custom accessibility actions. Also adds action sheet to Read Later cells. Bug: 749131 Change-Id: I2c81f6443a49bdf0cdccc3ec747b0ffd42513ef1 Reviewed-on: https://chromium-review.googlesource.com/593652 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#490930}
-
Jan Krcal authored
The tests are flaky on ChromiumOS. TBR=dtseng@chromium.org, yutak@chromium.org NOTRY=true Bug: 751046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id28f1ba7cb1c42c617b041c74a3698937d21eed5 Reviewed-on: https://chromium-review.googlesource.com/595589 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#490929}
-
gambard authored
In order to be able to add Earl Grey test for Content Suggestions working without internet connection, the test must be able to set the providers of the service. It allows the test to registers fake providers to have control on event which are normally triggered by server responses. Bug: 749981 Change-Id: I2952630e3e4ff59da42aae21454e95a4b23ac674 Reviewed-on: https://chromium-review.googlesource.com/591449 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: Ied94052421afbc26a348fe0ead6d0d75ed3f2461 Reviewed-on: https://chromium-review.googlesource.com/588877 Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#490927}
-
Yoshifumi Inoue authored
This patch change |VisibleSelection::GetSelection() == kCaretSelection| in "UnsafeSVGAttributeSanitizationTest.cpp" to |VisibleSelection::IsCaret()| for a preparation of getting rid of |selection_type_| from |VisibleSelectionTemplate|[1]. [1] http://crrev.com/c/579896: Get rid of VisibleSelectionTemplate::selection_type_ Bug: 657237 Change-Id: I4bfbbf913626588e89aa03a0db63152bd34e76a9 Reviewed-on: https://chromium-review.googlesource.com/595311Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#490926}
-
Jan Krcal authored
This test is flaky. TBR=tzik@chromium.org, yutak@chromium.org NOTRY=true Bug: 750800 Change-Id: Ie46050f53dab1c328a795658d935b02ac573e1ee Reviewed-on: https://chromium-review.googlesource.com/595469Reviewed-by:
-
Tomasz Garbus authored
Contains a declaration of a Feature, an empty JS interface and unittest. Injects credential_manager.js onto the website if and only if the Feature is enabled (is disabled by default). Bug: 435046 Change-Id: I805d9a0591670a601772f57d25643b7942db9eee Reviewed-on: https://chromium-review.googlesource.com/587190Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Cr-Commit-Position: refs/heads/master@{#490924}
-
Boris Sazonov authored
When child badge is overlayed on top of user avatar, it increases the width of the avatar image. ImageView for this avatar had insufficient width for avatar to fit in and it was forcing avatar to be downscaled. This CL increases ImageView width to fix it. Bug: 750069 Change-Id: Iec696dd17b5972a2c178bb076c056102fa866a9a Reviewed-on: https://chromium-review.googlesource.com/591487Reviewed-by:
-
Julien Brianceau authored
Bug: 750830 Change-Id: Ie4cc9f02e3cc23f0ed3e44b5372745eee9944165 Reviewed-on: https://chromium-review.googlesource.com/594770Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Julien Brianceau <jbriance@cisco.com> Cr-Commit-Position: refs/heads/master@{#490922}
-
Jialiu Lin authored
kPasswordFieldOnFocusPinging feature was mistakenly used in checking pinging status for password reuse study. As a result, the effective user pool of password reuse study is the same as password on focus study (a.k.a SBER and no incognito). Bug: 750410 Change-Id: I2579f5b5119ccfb68074b735d814dc3c8efa4a75 Reviewed-on: https://chromium-review.googlesource.com/592790 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#490921}
-
jkrcal authored
Revert of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #6 id:120001 of https://codereview.chromium.org/2969093002/ ) Reason for revert: Breaking build https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Audio%20Linux/builds/3356 Original issue's description: > Make rendering of MediaStreams reflect changes to its set of tracks. > > Before this CL, MediaStreams assigned to a media element required > reassignment of the stream to the element in order to make changes > to the set of tracks visible. > > This CL fixes this problem by making WebMediaPlayerMS subscribe to > changes in the set of tracks of a MediaStream, and correspondingly > update audio and video renderers. > > BUG=720258 > > Review-Url: https://codereview.chromium.org/2969093002 > Cr-Commit-Position: refs/heads/master@{#490906} > Committed: https://chromium.googlesource.com/chromium/src/+/c9612ba8bf66e48a32301e35425dd3384f48a3d8 TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,guidou@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=720258 Review-Url: https://codereview.chromium.org/2985393002 Cr-Commit-Position: refs/heads/master@{#490920}
-
Darren Shen authored
Moves: build/scripts/{ => core/css}/make_css_property_metadata.py build/scripts/{ => core/css}/templates/CSSPropertyMetadata.cpp.tmpl Changes the code_generator GN template to accept additional inputs, instead of overriding the default. Also fixes some linter issues. Bug: 732657 Change-Id: I597cb476b9973d0e44d42965d41d3c8883d95a54 Reviewed-on: https://chromium-review.googlesource.com/590590Reviewed-by:meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#490919}
-
Daniel Hintze authored
As part of the effort to move CORS handling out of blink, this CL moves the CORSURLLoader scaffolding introduced in https://chromium-review.googlesource.com/c/567610 into separate files in content/child/loader. (see comment https://chromium-review.googlesource.com/c/558226/23/content%252Frenderer%252Frenderer_blink_platform_impl.cc#b200) Note that this code is temporary and the final destination of the CORS implementation (which is supposed to be in network service) is yet to be determined. Big picture: https://docs.google.com/document/d/1mIk2or1y8nXHSQXQ6mJLGp3gLrtImONIuYhHtx1zInM Bug: 736308 Change-Id: Icc4472d402d7b4d06d0fe6a688e907240ff0b914 Reviewed-on: https://chromium-review.googlesource.com/593319 Commit-Queue: Daniel Hintze <hintzed@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490918}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9e69c338846a..4d5d88c3e04c $ git log 9e69c3388..4d5d88c3e --date=short --no-merges --format='%ad %ae %s' 2017-07-31 benjhayden Fix object-instance-track heading. 2017-07-31 loloangela Remove pylintrc bad-continuation and fix resulting errors pt.42 2017-07-31 rnephew [Telemetry] Add ability to disable by mac os version number. 2017-07-31 loloangela Fixed errors related to bad-continuation pt.41 2017-07-31 xunjieli [wpr-go] Allow disabling script injection 2017-07-31 loloangela Fixed errors related to bad-continuation pt.40 2017-07-31 benjhayden Fix ObjectSnapshot.userFriendlyName. 2017-07-31 simonhatch Dashboard - Add entities to _INTERNAL_ONLY_KINDS in datastore_hooks 2017-07-31 loloangela Fixed errors related to bad-continuation pt.39 2017-07-31 sullivan Set bug status to 'Assigned' when assigning to culprit author. 2017-07-31 loloangela Fixed errors related to bad-continuation pt.38 2017-07-31 charliea Upload a new version of the BattOr agent firmware Created with: roll-dep src/third_party/catapult BUG=713222,728496 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If6aca002e8592ed8dc89391f6964933fab5bcea6 Reviewed-on: https://chromium-review.googlesource.com/595226 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490917}
-
Erik Luo authored
DevTools collapses sequential messages with a repeat count if they are the same. This CL modifies the equality check to be more aggressive when collapsing. Thrown errors in the console with different exceptionIds will now be treated as equal. We also need to avoid altering message.parameters in _format() so that equality checks do not flake. This is a reland of: https://chromium-review.googlesource.com/c/580364/ Bug: 742526 Change-Id: I49450482af8fb129a662f3b84765d07e99b9723b Reviewed-on: https://chromium-review.googlesource.com/590931Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#490916}
-
Jan Krcal authored
This reverts commit db51f647. Reason for revert: This CL seem to break Android bots https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29 The output log: C 192.874s Main [FAIL] PaintLayerScrollableAreaTest.SelectElementPromotionTest: C 192.874s Main [ RUN ] PaintLayerScrollableAreaTest.SelectElementPromotionTest C 192.874s Main [INFO:SkFontMgr_android_parser.cpp(609)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened C 192.874s Main C 192.874s Main [INFO:SkFontMgr_android_parser.cpp(609)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened C 192.874s Main C 192.874s Main ../../third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp:607: Failure C 192.874s Main Value of: paint_layer C 192.875s Main Actual: false C 192.875s Main Expected: true C 192.875s Main [ FAILED ] PaintLayerScrollableAreaTest.SelectElementPromotionTest (83 ms) C 192.875s Main [----------] 1 test from PaintLayerScrollableAreaTest (83 ms total) Original change's description: > Experiment on not compositing small scrollers > > This patch is to avoid compositing scrollers smaller than 160000px to > save memory. On Android devices ~90% scrollers are smaller than this > threshold so we could expect a lot of memory save by not compositing > them. Meanwhile ~70% scrollers that users actually scroll are greater > than this threshold which means that at least 70% scrolls won't be > affected by this experiment. > > Note: for small scrollers with separate compositing reasons, e.g. > "will-change: transform;", they should be composited anyway. > > Bug: 684631, 746018 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I354ce936e981e66bcbc59f7248474cd29a9ecf8c > Reviewed-on: https://chromium-review.googlesource.com/585290 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490869} TBR=flackr@chromium.org,chrishtr@chromium.org,yigu@chromium.org Change-Id: I0a1cba3eb485799f25f5a97cab90d883df9a0c1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 684631, 746018 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/595285Reviewed-by:
-
Uzair Jaleel authored
CommandBufferProxyImpl uses weak pointers within the class only. Hence, it does not have to inherit SupportsWeakPtr. BUG=None Change-Id: I4163b4ed7787f2f31b184878c75181fcd2cd19da Reviewed-on: https://chromium-review.googlesource.com/590871Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#490914}
-
Yutaka Hirano authored
Bug: 750999 Change-Id: I2310e5d048f163841f9cfe32086fc0f7d1e5555a Reviewed-on: https://chromium-review.googlesource.com/595388 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#490913}
-
Dmitry Gozman authored
Bug: 546953, 702384 Change-Id: I73460b641d4083d615dfffb284aee8fd9cd1cdd7 Reviewed-on: https://chromium-review.googlesource.com/590348Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490912}
-
Trent Apted authored
Since 10.13, a trip to the runloop seems to be been necessary to ensure [NSApp orderedWindows] updates inside WidgetTest::IsWindowStackedAbove(). Since tests using this are only concerned with relative ordering of windows in the same process, flushing the run queue here shouldn't cause flakiness. Bug: 749905 Change-Id: I2fdd42994f759613d91458bf4c2d15cb20cf3c65 Reviewed-on: https://chromium-review.googlesource.com/590332Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#490911}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3650168..78567f11 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2cc02a9516bdd83bb528487eee6f470695c598be Reviewed-on: https://chromium-review.googlesource.com/594188Reviewed-by:
-
Hans Wennborg authored
It's a new target, and we want test coverage from the Clang bots. BUG=749827 Change-Id: I8637cf46fb345c0970c457b561b05b74afc5b944 Reviewed-on: https://chromium-review.googlesource.com/595156 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490909}
-
Emil A Eklund authored
Move box painting logic that can be shared across LayoutNG/legacy layout to BoxPainterBase. Layout implementation specific logic, such as scroll; text; and inline handling, is handled by the appropriate sub-class. Bug: 743221 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2d10403f955a0d18ab63b175fe250b7780225835 Reviewed-on: https://chromium-review.googlesource.com/576386Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490908}
-
Stuart Langley authored
This CL is part of the work to remove the *Base classes that were introduced to facilitate moving files from web/ -> core/. For this change I updated the defintion of MainFrame() in WebViewImpl to return WebLocalFrameImpl* rather than WebLocalFrameBase* and then updated all of the usage sites. Bug: 590591 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib6ed2085ddfe7567073fea67756433f4e8703b6c Reviewed-on: https://chromium-review.googlesource.com/595014Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
guidou authored
Before this CL, MediaStreams assigned to a media element required reassignment of the stream to the element in order to make changes to the set of tracks visible. This CL fixes this problem by making WebMediaPlayerMS subscribe to changes in the set of tracks of a MediaStream, and correspondingly update audio and video renderers. BUG=720258 Review-Url: https://codereview.chromium.org/2969093002 Cr-Commit-Position: refs/heads/master@{#490906}
-
Guido Urdaneta authored
This reverts commit 82918d4d. Reason for revert: Will reland a patched version of this CL. Original change's description: > Revert "Support GetAssociatedOutputDeviceID on CrOS." > > This reverts commit c8bc83f1. > > Reason for revert: crbug.com/748267 > > Original change's description: > > Support GetAssociatedOutputDeviceID on CrOS. > > > > With this CL, AudioManagerCras associates devices with each other > > based on their chromeos::AudioDevice::device_name, which represents > > the physical hardware of a device. This will also allow Chrome to > > compute group ids for audio devices. > > > > Also fix lint errors. > > > > BUG=636300 > > > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Change-Id: Idbbb4b3ad833564f603e317093108eadfbbdddf8 > > Reviewed-on: https://chromium-review.googlesource.com/538754 > > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > > Reviewed-by: Tommi <tommi@chromium.org> > > Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> > > Commit-Queue: Max Morin <maxmorin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#487814} > > TBR=jennyz@chromium.org,tommi@chromium.org,warx@chromium.org,maxmorin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR: jennyz@chromium.org, tommi@chromium.org, maxmorin@chromium.org > Bug: 636300,748267 > Change-Id: I916e1075026f419beed8948312435c9d23d226cc > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/585402 > Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> > Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490031} TBR=jennyz@chromium.org,tommi@chromium.org,warx@chromium.org,maxmorin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 636300, 748267 Change-Id: I5d8c518c5c840ea77f3f712d0b5e54e2d5aa8a75 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/593687 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#490905}
-
gambard authored
Bug: 667892 Change-Id: I6a044a60e212c8cd8f264a8d6c6d3e2c74a3bcdf Reviewed-on: https://chromium-review.googlesource.com/591147 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
junweifu authored
Add a method to generate tested bitmap with drawing texts on new canvas for testing flexibility. Add instrumentation test for text detection on Android Platform, these new test end up being rolled up in chrome_public_test_apk. BUG=722931 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Change-Id: I769c7fb09f5e7e40be9190bb6c13ea6a31a43645 Reviewed-on: https://chromium-review.googlesource.com/578585 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490903}
-
Yoshifumi Inoue authored
This patch makes |base_| and |extent_| to hold same position when |ComputeSelctionType()| returns |kCaretSelection| since there are no good reasons to have different positions for caret selection for a preparation of getting rid of |selection_type_| and improving code health. Changes in |VisibleSelectionTest| are cases of caret selection have different base and extent for broken visible position canonicalization on tree boundary crossing, e.g. positions of distributed nodes are swapped. These test results are snapshot of current behavior instead of meaningful results. * ShadowCrossing: distributed node "one" to end of shadow root. * ShadowNested: like ShadowCrossing but on nested shadow tree. Note: Following patch will remove |selection_type_| and make |Validate()| as static function taking |SelectionTempalte| and returning |EphemeralRange| and selection direction for |base_is_first_|. Bug: 657237 Change-Id: I57f85953e049f089e92c821ee7e24f418506f2f9 Reviewed-on: https://chromium-review.googlesource.com/590600Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#490902}
-
Khushal authored
1) Replace DecodedImageHolder with ScopedDecodedDrawImage to return a scoped object for managing the decode lifetime in the ImageDecodeCache. 2) Use base::Optional to limit the use of the ImageProvider during raster instead of a unique_ptr. Bug: 735747 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4b23103760a7edf96ea782df0015dacd0bb79943 Reviewed-on: https://chromium-review.googlesource.com/594639 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490901}
-
