- 17 Mar, 2020 40 commits
-
-
Jerome Jiang authored
BUG=1055917 Change-Id: Ic3e12c711c5470a1ebf09dd72df392d85d1226cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106557Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#751099}
-
Jan Wilken Dörrie authored
This change removes IDS_SETTINGS_LEAKED_PASSWORDS_COUNT, which was initially removed in r748277, but then accidentally re-added in r748728. There are no usages of this string, and thus it can safely be removed. Bug: 1047726 Change-Id: Ib765f74ad8a031cb45cbf229c7031e2a7d39682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107484 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751098}
-
W. James MacLean authored
This test is flaking a lot recently, disabling until a fix is found. TBR=jkrcal@chromium.org Bug: 1021930 Change-Id: I47d5b1ca51686febf5bbd2e712573937d867625c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107685Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751097}
-
Sergey Ulanov authored
Previously fuchsia-dir was registered as a standard URL scheme only in WebEngine, but not in runners. As result fuchsia-dir:// URLs were not always handled correctly, particularly because GURL::GetOrigin() returns an empty string when called for an URL with a non-standard scheme. When trying to start an app from a custom content directory cast_runner was getting empty string from GetOrigin() and passing that empty string to Frame::SetPermissionState(). As result WebEngine would terminate the Frame. Added RegisterFuchsiaDirScheme() helper that's now used in runners to register fuchsia-dir scheme. This ensures that GURL::GetOrigin() works properly for fuchsia-dir URLs. Bug: 1062120 Change-Id: Ibe28f07e4a6b08cf62526c5f7ee81e2783c6d667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106748 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#751096}
-
Manu Cornet authored
Change-Id: I7b86172efd0c870b3be9242086956b5bc687220d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106654Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751095}
-
John Budorick authored
Shards are liable to time out when running on minis, e.g. https://chromium-swarm.appspot.com/task?id=4b017cb46b89c910 Change-Id: I025c898985dd524fb1d29c7f6ea93efc5c2341a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106461 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751094}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/141ac68fa0f7..beefcb9d38c0 git log 141ac68fa0f7..beefcb9d38c0 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 kjlubick@google.com Reland saveLayer can omit the rectangle argument. 2020-03-17 hcm@google.com add m82 release notes 2020-03-17 senorblanco@chromium.org Dawn: embed a staging buffer inside the uniform ring buffer. Created with: gclient setdep -r src/third_party/skia@beefcb9d38c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I88d24aca627cee61cc8d0ebe8f9079eb2e862a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751093}
-
Kevin Marshall authored
Addresses some post-LGTM feedback items that narrowly missed the initial landing of LegacyMetricsUserEventRecorder. TBR=ddorwin@chromium.org Bug: 1060768 Change-Id: I9f20281b11585439947de89eb71fa15aa6750a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107712Reviewed-by:
-
Rahul Arakeri authored
This CL adds the plumbing to make features::kPercentBasedScrolling accessible to LayerTreeHostImpl via LayerTreeSettings. Bug: 1062163 Change-Id: Ic8676f3c1d76533fcc3639de68ece2763baae711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107153Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751091}
-
Jonah Chin authored
The cause of this bug was the switch to a RecordPaintCanvas() on the CanvasResourceProvider. Previously, a Clear Operation was done directly on the skia canvas in OffscreenCanvas::GetOrCreateResourceProvider(). Now that CanvasResourceProvider::Canvas() returns a RecordPaintCanvas(), a Clear Op is recorded, but not drawn to the backing skia canvas until flush. The context's tracking boolean, |have_recorded_draw_commands_|, was not updated to signal that a flush was needed. This resulted in WritePixels()'s call to FlushRecording() earlying out with no flush, despite the existence of draw operations. By replacing |have_recorded_draw_commands_| with a check of the recorder's actual DisplayItemList, we can avoid juggling the |have_recorded_draw_commands_| boolean and can always correctly determine if a flush is necessary. Bug: 1059121 Change-Id: Ic511229a0cdb0ef3fe48dbd4d760066a0be2d10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099299Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751090}
-
Askar Aitzhan authored
The field is needed to verify that the policy view of DMServer and Chrome OS device is consistent during the ongoing Certificate Provisioning Process. See more: go/built-in-cert-provisioning. Bug: 1045895 Change-Id: Ia1326a6a58720be1e430206882520529a4b16385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100968 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#751089}
-
Pavel Yatsuk authored
This CL extracts methods that InfoBar calls on InfoBarContainer into InfoBar.Container interface. This breaks InfoBar dependency on InfoBarContainer and allows moving InfoBar.java to chrome/browser/ui/messages. BUG=1056346 R=mdjones@chromium.org Change-Id: I1b16b6021979dcdfcff1aa5e48cc9aacf613b02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103140Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#751088}
-
Xing Liu authored
This CL adds the functionality to decode image safely in a utility process. The decoding details is hidden behind an interface, for caller to build unit tests effectively. Bug: 1058534 Change-Id: Ibbcf7afa4e6d7ee97ed0baa2fcdfacaeddcdcbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106768 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751087}
-
Anatoliy Potapchuk authored
AccessibilityControllerImpl had a lot of duplications. Let's fix that. Also, now it controls fullscreen and docked magnifiers. Before that, we have to go AccessibilityDelegate and MagnificationManager to do this. Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d Bug: 1051892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#751086}
-
Jan Wilken Dörrie authored
This change re-enables the Password Check tests. They were disabled as part of https://crbug.com/1061249, however were never actually flaky as described in https://crbug.com/1060948#c3. Bug: 1060948, 1061249 Change-Id: If69270fa0b19f45b60340e5d0d823bef79e001bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107582 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#751085}
-
Nate Chapin authored
Bug: 1061348, 1061614 Test: fast/animation/report-violation-in-detached-document-crash.html Change-Id: I9a1345979f19ff5e849d336fd576cbf715b0034f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103029 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751084}
-
Andrew Grieve authored
It's an unmaintained feature that hasn't been updated since M67. Change-Id: I5c7554189176f53b1cf7605c38850efbe745e53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107422 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751083}
-
W. James MacLean authored
Also disabling NavigationWithBothLocalPredictionAndOptimizationHint on Linux. TBR=tbansal@chromium.org Bug: 1060966 Change-Id: I4ee8348c8e0bed4248583327749552200bfa66f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107572Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751082}
-
Kevin Marshall authored
Adds a class which accumulates a buffer of user events, which are timestamped strings recorded with the base::RecordAction() API. The buffer will periodically be drained and sent over FIDL IPC (not in scope for this CL). Bug: 1060768 Change-Id: Ieb235654e030eef81eefd963ae614ce68b72dba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103393 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#751081}
-
Mike Wittman authored
Removes the dependency on support for native modules in ModuleCache to run V8UnwinderTest.CanUnwindFrom_OtherModule. Fuchsia and Android ARM64 do not have native module support yet. Bug: 1035855 Change-Id: Ib3e29aa72d183029babad57e790ddc8c0f419d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106489Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#751080}
-
John Lee authored
https://i.imgur.com/iep45bz.png Fixed: 1035675 Change-Id: Ic73a425a68b5e7275df29f347592715880d39259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106348Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751079}
-
Robert Ogden authored
With the pending rollouts of some features that use the client config, we should enable everybody to fetch it by default, but leave a kill switch. Bug: 1048736 Change-Id: I6f88289173425551c10a0fa44dcc144570a2618b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107561Reviewed-by:
-
Sinan Sahin authored
NPE was caused by a line in ToolbarManager where mCanAnimateNativeBrowserControls was used before being set. The fix is to check if null. Also, it might make sense to update the if statement where the feature is checked to make sure we return early if ChromeFeatureList isn't initialized. Otherwise, we end up running feature specific code if CFL isn't initialized. Bug: 1062302 Change-Id: Ieac75c96d285f5768321c6d8425fda4511d0fa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107701 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751077}
-
Brian White authored
Bug: 1056622 Change-Id: Idd256e94b179137500bf732289c6992e150d6d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106561 Commit-Queue: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#751076}
-
Ted Meyer authored
and media: :Status::IsOk() => media::Status::is_ok() media: :Status::Ok() => media::OkStatus() Change-Id: I94d09a860513e0c3efb54da392e56d3035dfddee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106740Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751075}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e73d36798847..80517cb9ee4c git log e73d36798847..80517cb9ee4c --date=short --first-parent --format='%ad %ae %s' 2020-03-17 aerotwist@chromium.org [global] Remaps self.Bindings.resourceMapping 2020-03-17 tvanderlippe@chromium.org Fix command menu items for snippets Created with: gclient setdep -r src/third_party/devtools-frontend/src@80517cb9ee4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1058320,chromium:1060565 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4daced7f414fed57dd0c7a81a215775c374d60bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107329Reviewed-by:
-
Jarryd Goodman authored
Bumps expiry from M82 to M85, as the change is only being wrapped up now. Change-Id: Ic381576f33569d1ce5cd3eb8b33997afcb8942cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062884Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c3c88819af7..f297c2cef4e4 Created with: gclient setdep -r src-internal@f297c2cef4e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053735 Tbr: jbudorick@google.com Change-Id: Ia8c973bc63ced1bef4e5ebfe93f9e61451f3def1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107420Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751072}
-
Juanmi Huertas authored
Refactors the GetOrCreateResourceProvider of OffscreenCanvas simplifying the logic and removing AcceleratedResourceUsage. Also removes the usage parameter an metric capture, as in next CLs this usage will be completely removed. Part of a big refactor for CanvasResourceProvider. Bug: 1035589 Change-Id: Icd46f812d312f56454205c6f23f70c72e6e44d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103080 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
-
Nate Fischer authored
These were fixed by SafeBrowsingCommittedInterstitials, which is on by default since M82. We no longer need to skip these tests. Fixed: 1006953 Test: N/A Change-Id: I0d7659c055fa9c51e93dc0a82bccff7a0b4fcf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107683 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751070}
-
chrome://sync-confirmationDemetrios Papadopoulos authored
- Extract ui into a <sync-disabled-confirmation-app> element and migrate to Polymer 3 (similar to <sync-confirmation-app>). - Use SyncConfirmationBrowserProxy instead of making direct chrome.send() calls. - Delete remaining code from sync_disabled_confirmation.js, and use identical code in sync_confirmation.js Bug: 1012533 Change-Id: I142090cf297a288e807b4ddf9346ac4c9d3d742d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101860 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#751069}
-
Maks Orlovich authored
This is mostly to get clarity on what this should be doing before I change how parsing of client hints and communication from browser works, though it's not really dependent. Change-Id: I04e8b403a6aeae544d2616688a39c65c0e60b5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083449 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#751068}
-
Chris Harrelson authored
This is a follow-on to [1]. In addition to the added unittest, this fixes a failure in a test [2] when trying to land [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2092698 [2] http/tests/lazyload/image-subpixel-position.html [3] https://chromium-review.googlesource.com/c/chromium/src/+/2103708 Bug: 992765 Change-Id: I32b28ff0ab4cd4f9f527c6601413a16d2a1d703c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106418Reviewed-by:
-
Livvie Lin authored
UX proposal: https://docs.google.com/document/d/19iu3ISlOw9L_PCpOh8LB4TSKC8uBPzSBiEnkZm4IiQI/edit#heading=h.qyrxas7ncbc9 Design doc: go/context-menu-unelide-dd Bug: 1061576 Change-Id: I3627f0090112378f6df8bbaf274b40c35024a7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103291 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#751066}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/440fc9959f06..2aa80df14528 git log 440fc9959f06..2aa80df14528 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 digit@google.com [vulkan]: Support multiple external semaphore implementations. Created with: gclient setdep -r src/third_party/swiftshader@2aa80df14528 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I20a9dc345b0d0f5a5bad04ac21e53d3aa1c66ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107328Reviewed-by:
-
danakj authored
For LocalFrames that are in a Page owned by a WebView, each LocalFrame has a WebLocalFrameImpl which has a WebFrameWidget. This is always present except very early during initialization which most code can ignore. For LocalFrames in non-ordinary Pages, which live without a WebView (such as WebPagePopupImpl, devtools agent, unit tests) the LocalFrame has an EmptyLocalFrameClient instead of WebLocalFrameImpl and thus there are no WebFrameWidgets. Currently parts of core/ can not get to the WebFrameWidget because WebLocalFrameImpl is banned due to the layering mess being unresolved. It is also difficult to find the path there as going from LocalFrame requires: WebLocalFrameImpl::FromFrame(local_frame)->LocalRootFrameWidget() Since the conversion to WebLocalFrameImpl isn't a member of LocalFrame it's very hard to find and remember this path! We introduce here a well-lit road from LocalFrame to its WebFrameWidget and use it throughout ChromeClientImpl. While updating ChromeClientImpl we note that it was early-outting on WebViewImpl::does_composite() due to a null WebWidgetClient which it is no longer using, as it defers to the WebFrameWidget. Since ChromeClient means we have a WebView, we also know that WebFrameWidget does exist, and it is a better place to early out. So these are moved. This change will allow my display-mode CL for 1060336 to find the WebFrameWidget from code in core/css/ without changing blink layering more dramatically. And it is a long time coming to make this path clearer. R=dtapuska@chromium.org Bug: 1060336, 844547, 1058633 Change-Id: Iabb71ebf0c5ebaf7daea924425c9d3a3a2c23d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101847Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#751064}
-
Adam Langley authored
r745162 adds a v1 event in FidoCableDiscovery::OnStartDiscoverySession, but it's recorded unconditionally. With caBLE v2, there might not be v1 data in play. Change-Id: Ie0aa18f10137f028c4ef06f2ee8d00fc5a19490b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107424 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#751063}
-
Koji Ishii authored
This patch modifies the snap-to-pixel behavior implemented in r736251 <crrev.com/c/2024133>. The CL changed to snap the top of the padding box of the parent box to match legacy and |NGPaintFragment| behavior. It did so even for culled inline boxes too, but this part was not compatible. This patch changes the logic to ignore culled inline boxes for the snap-to-pixel behavior, matching legacy and |NGPaintFragment|. Bug: 982194 Change-Id: I667f35d4b55909505502633b2d7e70b058191c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106044 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751062}
-
Lily Chen authored
Bug: 1061664 Change-Id: I577aedb7e78d5ad2b8359254f8af1fc384410f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107439 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#751061}
-
Daniel Murphy authored
R=pwnall@chromium.org TBR: pwnall@chromium.org Change-Id: I3e66ad4dbfdc66e4f54192ee81c275bb54848a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107576Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#751060}
-
