- 26 Dec, 2019 40 commits
-
-
Kurt Horimoto authored
Much of OverlayPresenter's public interface is based around OverlayRequest and OverlayResponse, whose interfaces are intentionally opaque and leverages C++ templates to provide special behavior. This was done in order to ensure type safety and prevent misuse of these objects. Despite the benefits of this approach, template code can become unwieldy to use. Already, there are several instances of templated c++ container objects that are used to associate objects with their supported request/response types. This CL adds OverlayRequestSupport in order to abstract away some of this shared functionality. Follow-up CLs will use these objects to help implement these objects without having to use additional templates in each case. Additionally, this CL adds an OverlayRequestConfig template that allows for easy creation of OverlayRequestSupports for each config type. Bug: none Change-Id: I54bd0361f4ca5de2ae17e2b859ad36b98ca24fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980859 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727505}
-
Andrey Kosyakov authored
This reverts commit 20cefba5. Reason for revert: suspected cause of crbug.com/1037652 BUG: 1037652, 1034954 Original change's description: > Headless: fix a crash in ~HeadlessWebContentsImpl > > ... due to reentrancy while waiting for a [sync] call to > FrameSink::DestroyCompositorFrameSink() from Compositor destructor. > > Bug: 1034954 > Change-Id: I8b47560d18bdab38e40e67e6506d30a2043f1474 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977741 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726858} TBR=caseq@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034954 Change-Id: I244a6d9a9e36b8edb1297e9a3aa523b133f764e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982223Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727504}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22a241986380..f2d522a3f434 git log 22a241986380..f2d522a3f434 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 brianosman@google.com Update MSVC toolchain asset to 2019 Created with: gclient setdep -r src/third_party/skia@f2d522a3f434 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I27a7da0baae40d266b4b3b74e2470517c03117a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727503}
-
Demetrios Papadopoulos authored
The rule disallows == in favor of ===, and != in favor of !==, which matches the Google JS styleguide (which Chromium's JS styleguide inherits from). The stricter checks actually revealed a small bug where parameters to a function were passed in the wrong order from destination_settings_test.js Bug: 720034 Change-Id: Ic74d92a89fa5d8e89379c5843636f08f45505c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978164 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#727502}
-
Khushal authored
TBR=jonross@chromium.org Bug: 1037939 Change-Id: I7ebc15845b1c23e5972807f0a077a939e110eda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982225 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#727501}
-
Caleb Rouleau authored
Dirk is out for few weeks, so the only owner available right now is John B. Seems like some redundancy here would be helpful. John and I have been doing some work in this area including work on test_env.py and xvfb.py so it seems like we would be reasonable OWNERS. R=jbudorick@chromium.org, johnchen@chromium.org Change-Id: Ia5a959a6ab96a6b31507432688b7eb62fbf60cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982222Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727500}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53366c4e..8c170824 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9035b69e2328b6c506c537335c1cf938f7ce716b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981091Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727499}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/533cb856c0c9..f0edda42e7d3 Created with: gclient setdep -r src-internal@f0edda42e7d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iee7fb607bd9e44e4348a6021575d24c87d10ceb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982719Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727498}
-
meacer authored
The presubmit currently imports grd_reader on all presubmit invocations (i.e. git cl upload) even though it's only needed when the CL touches a .grd or .grdp file. This CL does not import if no .grd/grdp files are affected. Bug: 1031189 Change-Id: Ib63873771a2ba6d0e60da76a457d2c22b89791b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978939Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#727497}
-
Stefan Zager authored
TBR=chrishtr@chromium.org Change-Id: I0e2d68aecb6b20ecec5ec4a88e41b57a69b06341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982684Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#727496}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e5672715a8f..22a241986380 git log 1e5672715a8f..22a241986380 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 brianosman@google.com Fix CMake build Created with: gclient setdep -r src/third_party/skia@22a241986380 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Ic9a7cb6356ce1b720946c8d903fb1b5cfe0e058e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982701Reviewed-by:
-
Archana Simha authored
Records user actions when a user cancels and accepts the extension uninstall dialog and if the user checks the report abuse box. Design Doc: http://go/extensionscheckupmetrics Bug: 1034541 Change-Id: I477a5c03514feb2ea74d92d9c6067b91cc1638b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972584 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#727494}
-
Thomas Lukaszewicz authored
Changed menu scroll view container to have its bubble border use the color id for background color instead of the color id for border color when determining background color. Following the change made in patch https://chromium-review.googlesource.com/c/chromium/src/+/1949105 the color of context menus in ChromeOS shifted to a darker shade of grey. This is contrary to how the context menu should be colored according to UX guidance. The code path for the bubble border in the menu scroll view container is only exercised in the following ash components: - ash/app_list/views/search_result_tile_item_view.cc - ash/app_list/views/app_list_item_view.cc - ash/root_window_controller.cc - ash/shelf/shelf_view.cc The scope of this change is thus isolated to ChromeOS, restoring the context menu color to its intended values on the platform. Bug: 1035600 Change-Id: I115df0b2781cba696713d96ead77ad50888538a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980768Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727493}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/b93b64e6bec7..85240a12ed2b $ git log b93b64e6b..85240a12e --date=short --no-merges --format='%ad %ae %s' 2019-12-23 rch Rename HandshakerDelegate to HandshakerInterface in QuicCryptoServerStream and QuicCryptoClientStream to make it clear that this is an interface which defines the handshaker as opposed to a delegate of the handshaker (Which is defined by the similarly named HandshakerDelegateInterface). 2019-12-23 wub gfe-relnote: For QUIC BBR v1 and v2, only produce one bandwidth/rtt sample per congestion event. Protected by --gfe2_reloadable_flag_quic_one_bw_sample_per_ack_event. 2019-12-23 ianswett Deprecate gfe2_reloadable_flag_quic_stop_reading_when_level_triggered. 2019-12-20 nharper gfe-relnote: Create handshaker for QuicCryptoServerStream in constructor instead of later. Protected by reloadable flag quic_set_server_handshaker_in_constructor. 2019-12-20 danzh gfe-relnote: n/a(code clean up) Add default definition of copy assignment for QuicPacketHeader. 2019-12-20 rch gfe-relnote: Drop QUIC INITIAL packets which are less than 1200 bytes. Protected by --gfe2_reloadable_flag_quic_drop_small_initial_packets 2019-12-20 wub gfe-relnote: Change quic::SendTimeState.bytes_in_flight to include the bytes from the packet just sent. Protected by v2 flag --gfe2_reloadable_flag_quic_bw_sampler_remove_packets_once_per_congestion_event2. 2019-12-20 wub gfe-relnote: (n/a) Add a QUIC BBRv2 simulator test to make sure inflight_hi is cut gradually upon loss from PROBE_UP. Test only. Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: Id400aee98f6e184794f27f4aac554dbaa760ebeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982621Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727492}
-
Caleb Rouleau authored
This prevents us from hitting builder timeouts. Bug: 1036447 Change-Id: Id1337b795aa61648ca7ca1a69a71263ad27f4eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977965 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a46fc1dcdc3d..189074525f47 git log a46fc1dcdc3d..189074525f47 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 rmhasan@google.com [Typ] Fix indentation in code block in expectations_parser.py Created with: gclient setdep -r src/third_party/catapult@189074525f47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036130 Tbr: zhanliang@google.com Change-Id: I18dd26db5c8f2736c3ad4a322c9499ef8524eb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982596Reviewed-by:
-
Dana Fried authored
Fixes a rare use-after-free crash that could occur when an animating layout manager was already fading out a view and then that view was removed from its parent. Also adds a DCHECK and two regression tests to prevent the problem from occurring again (the DCHECK covers ALL LayoutManagerBase-derived layouts, not just AnimatingLayoutManager). Bug: 1037625 Change-Id: I87f4611a081bad7bb4fcffa30ab60a81502aeb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981338Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#727489}
-
Renato Silva authored
Changes the contrast of the separator under the password field on the login/lock screen. When the password field receives focus, the separator will be highlighted. When it loses focus, the highlight is removed. TBR=xiyuan@chromium.org Fixed: 908967 Change-Id: I8e953497586b96e8836745a8e086d3adb36edeca Bug: 908967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969340 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#727488}
-
Matthew Mourgos authored
ShelfWidgetTest::ShelfEdgeOverlappingWindowHitTestMouse is broken when enabling the hotseat. It is caused by the CL (https://crrev.com/c/1966428) which fails to set window insets for hotseat widget. To accelerate the process of enabling the hotseat flag, only run this test with hotseat disabled. TBR=xiyuan@chromium.org Bug: 1032702 Change-Id: I0a6ee824f23ea8ae948f4b6db2f0f9b27d828fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981113Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727487}
-
Matthew Mourgos authored
With this change, the padding between the edge of the screen and the status area widget no longer has anything to do with the hotseat state. This edge padding will now only ever have two possible values, one value in tablet mode and another value in clamshell mode. Bug: 1035716 Change-Id: I70f8ffe99ddf8e44482a3c9772f72dcf7adb9885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977025Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727486}
-
Takumi Fujimoto authored
Whenever a Cast session is started from the Cast dialog, we record how the dialog was opened, and the cast mode of the session. Bug: 1033591 Change-Id: I7c5122b706b71e66ab37aef4ae7066fb6d537b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965442 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727485}
-
Caleb Rouleau authored
https://chromium-review.googlesource.com/c/catapult/+/1961011 makes it so that if you do no specify a --webview-embedder-apk flag then we will use WebLayerShellSystemWebView.apk for a weblayer browser. It is also nicer not to explicit specify a flag for the reasons described in https://chromium.googlesource.com/chromium/src.git/+/c1324fa4ee0802370abbd624df217ef7b479180c R=johnchen@chromium.org Bug: 1028125 Change-Id: I01ac075f8ef92928ca9e15dbb665ea9ce8c95f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981068Reviewed-by:
-
Dominic Mazzoni authored
For exporting tagged PDFs, we need the ability to take a snapshot of the accessibility tree for a RenderFrame, and to have the accessibility context stay alive long enough that IDs in the snapshot, and IDs sent to the printing system, are consistent. We already had code to do AX tree snapshotting, so this patch is just some refactoring to make it a class instead, and to have it return a public type rather than a content-specific type. This will be used in the follow-up change that implements support for tagged PDFs: http://crrev.com/c/1970742 Bug: 607777 Change-Id: I5163561c2cabcb2dd3579ce9d7a2de8ac96106d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970579 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727483}
-
Alice Wang authored
This CL removes the unused method isMobileIdentityConsistencyEnabled. Bug: 1035950 Change-Id: I39ce79e68a5e03ff281358673451a9bf4d8507c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980740Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727482}
-
Chris Harrelson authored
This reverts commit f3d96d04. The original commit was reverted because it caused flakiness in some browser tests (in particular, HostZoomMapBrowserTest.PageScaleIsOneChanged) The flakiness was caused by a real bug in the CL, which is fixed in the latest patchset. The bug was that the base::Optional pending_view_state_ was not being rest after being applied. See https://chromium-review.googlesource.com/c/chromium/src/+/1981806/1..3 for what has changed from the original CL. Bug: 1018632 Change-Id: I0f93094569c52deee02e6bf6296b2c181fb226bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981806Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727481}
-
Maggie Chen authored
DX12/Vulkan info collection is not needed for headless mode. Don't launch the unsandboxed GPU process, which is only for info collection. Bug: 1008904 Change-Id: Ibd0a58ab02675752e86282ef91e2b0b87935e256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981130Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Kevin Qin authored
Current OpenXR runtime only supports microsoft motion controller and Khronos simple controller. Add suggest interaction profile for Oculus touch controller. Fixed: 1033708 Change-Id: I6904a2335c50291b3b4338b2004d262fdb2772e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966354 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#727479}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/07d744fb8a53..1e5672715a8f git log 07d744fb8a53..1e5672715a8f --date=short --first-parent --format='%ad %ae %s' 2019-12-26 brianosman@google.com Roll ICU and Harfbuzz 2019-12-26 rmistry@google.com Add bots to push apps from skia/skia-wasm docker images Created with: gclient setdep -r src/third_party/skia@1e5672715a8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I060e24e5cff3417cb4812da37dc9ee2efa0913ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982666Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bd97b6f9f213..5de15a256eb0 git log bd97b6f9f213..5de15a256eb0 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 cepheus@frii.com HLSL: Fix #2037: Integer dot used incorrect input for adds. Created with: gclient setdep -r src/third_party/glslang/src@5de15a256eb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Ie4150648153c95016603f79192369006787684c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982662Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fe10b5cac14e..a46fc1dcdc3d git log fe10b5cac14e..a46fc1dcdc3d --date=short --first-parent --format='%ad %ae %s' 2019-12-26 crouleau@chromium.org [Pinpoint] Telemetry: pick support apk from next to the release APK. Created with: gclient setdep -r src/third_party/catapult@a46fc1dcdc3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028125 Tbr: zhanliang@google.com Change-Id: I16746b5ddfc6213a8b1bf5fdb1fff29dbebf0330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982663Reviewed-by:
-
Stepan Khapugin authored
Reverts changes that maintain the downstream tests compileable. This should land after CL 2277302 in ios_internal which updates the call site to use MainController instead of SceneController. Bug: none Change-Id: I028c096279fbd9dd5b9dbfd8e7720c9818a1580b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958121 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727475}
-
Avery Musbach authored
Before the present CL, SplitViewDivider::OnWindowDragStarted checks if the dragged window and the divider window have the same parent, and if so, stacks the divider window below the dragged window. For when the parents are different, there is no provision, and that is a problem as shown in the video linked on https://crbug.com/1035984. Fixed: 1035984 Change-Id: Ib5a5e628b59a87b55fc5369150b784d3004d86fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979102Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#727474}
-
Devlin Cronin authored
Callers of ResultCatcher::GetNextResult() should always, always check the result. Typically, a return value of `false` means that something went wrong (because it is returned when a test fails), so it should be explicitly checked. (Note that we don't just assert in the ResultCatcher itself, because some tests do expect to fail). Update the one call site that didn't already check the result. Bug: None Change-Id: I690b794b0c1ac07cb0a30b5d3078ffdb258195a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980752Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727473}
-
Devlin Cronin authored
Remove: - ExtensionBrowserTest::installed_ - ExtensionBrowserTest::loaded_ - ExtensionBrowserTest::LaunchBrowserForAppInTab() - ExtensionBrowserTest::InstallExtensionWithUI() - ExtensionBrowserTest::WaitForExtensionLoadError() - browser_test_util::LaunchBrowserForAppInTab() None of these had active usage. No functional changes; pure deletion. Bug: None Change-Id: I815af35198ebeb0b75139086060eedb48a0d8209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981067Reviewed-by:
-
John Chen authored
Disabling perf test v8.browsing_mobile/browse:media:imgur:2019 on Android Nexus6 WebView Perf. TBR=crouleau@chromium.org NOTRY=True Bug: 1037905 Change-Id: I69f2cab841c944e00e4aa11c336f7422b877c417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982592Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2f4e0cb1acb..533cb856c0c9 Created with: gclient setdep -r src-internal@533cb856c0c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iacbf2d48f7a2b915a3e1c97d20bea4d25ee52ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981807Reviewed-by:
-
Siye Liu authored
We should reset the flag |new_text_inserted_| after each |RequestLock| call because the flag is used to indicate whether current session has new text inserted/replaced. We should clear the flag at the end of current session to prepare the state for next edit session. Bug: 1013472 Change-Id: I6efd9600d84550857ba4f55a42966753d2a7bdab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972752Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727469}
-
Nazerke authored
This CL adds helper methods to signin_earlgrey_utils_app_interface.* and converts the following tests: -testSyncUploadBookmarkOnFirstSync -testSyncUploadBookmark -testSyncDownloadBookmark -testSyncCheckSameCacheGuid_SyncRestarted -testSyncCheckDifferentCacheGuid_SignOutAndSignIn -testSyncCheckSameCacheGuid_SyncRestartedAfterSignOutAndSignIn -testSyncDownloadAutofillProfile -testSyncUpdateAutofillProfile -testSyncDeleteAutofillProfile -testSyncUploadOpenTabs -testSyncTypedURLUpload -testSyncTypedUrlDownload -testSyncTypedURLDeleteFromClient -testSyncTypedURLDeleteFromServer. Bug: 987646 Change-Id: I559a90182f78996399bfc1ae9ac98a184c36d914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955555 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#727468}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dadde9348d46..63b6be2bbc99 git log dadde9348d46..63b6be2bbc99 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@63b6be2bbc99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I26f4d3f290fa7c13c467157589bf928a94c42516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981805Reviewed-by:
-
David Bertoni authored
The ExtensionBrowserTest and ExtensionApiTest classes have a set of enums for flags that have identical names and, in some cases, conflicting values. This is a problem when a function expecting one set of values is called with the other set of values. This CL removes the overlap between these sets of names and breaks their use into separate function parameters.. Bug: 1031605 Change-Id: Ie8aef41b0cfa0029ebbbb330b80bc4491c5ac5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954715Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
